Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <rpc/rawtransaction_util.h>
12 : : #include <rpc/util.h>
13 : : #include <script/script.h>
14 : : #include <util/rbf.h>
15 : : #include <util/translation.h>
16 : : #include <util/vector.h>
17 : : #include <wallet/coincontrol.h>
18 : : #include <wallet/feebumper.h>
19 : : #include <wallet/fees.h>
20 : : #include <wallet/rpc/util.h>
21 : : #include <wallet/spend.h>
22 : : #include <wallet/wallet.h>
23 : :
24 : : #include <univalue.h>
25 : :
26 : : using common::FeeModeFromString;
27 : : using common::FeeModesDetail;
28 : : using common::InvalidEstimateModeErrorMessage;
29 : : using common::StringForFeeReason;
30 : : using common::TransactionErrorString;
31 : : using node::TransactionError;
32 : :
33 : : namespace wallet {
34 : 1807 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
35 : : {
36 : 1807 : std::vector<CRecipient> recipients;
37 [ + + ]: 23481 : for (size_t i = 0; i < outputs.size(); ++i) {
38 [ + - + - ]: 21674 : const auto& [destination, amount] = outputs.at(i);
39 [ + - ]: 43348 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
40 [ + - ]: 21674 : recipients.push_back(recipient);
41 : 21674 : }
42 : 1807 : return recipients;
43 : 0 : }
44 : :
45 : 306 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
46 : : {
47 [ + - + - : 895 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
48 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
49 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
50 : : }
51 : : } else {
52 [ + - + - ]: 564 : options.pushKV("conf_target", conf_target);
53 [ + - + - ]: 564 : options.pushKV("estimate_mode", estimate_mode);
54 : : }
55 [ + + ]: 606 : if (options.exists("fee_rate")) {
56 [ + + ]: 26 : if (!fee_rate.isNull()) {
57 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
58 : : }
59 : : } else {
60 [ + - + - ]: 554 : options.pushKV("fee_rate", fee_rate);
61 : : }
62 [ + - + - : 662 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
63 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
64 : : }
65 : 302 : }
66 : :
67 : 647 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
68 : : {
69 [ + + ]: 647 : std::set<int> sffo_set;
70 [ + + ]: 647 : if (sffo_instructions.isNull()) return sffo_set;
71 : :
72 [ + - + + ]: 194 : for (const auto& sffo : sffo_instructions.getValues()) {
73 : 102 : int pos{-1};
74 [ + + ]: 102 : if (sffo.isStr()) {
75 [ + - + + ]: 9 : auto it = find(destinations.begin(), destinations.end(), sffo.get_str());
76 [ + + + - : 10 : if (it == destinations.end()) throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', destination %s not found in tx outputs", sffo.get_str()));
+ - + - ]
77 : 8 : pos = it - destinations.begin();
78 [ + + ]: 93 : } else if (sffo.isNum()) {
79 [ + - ]: 92 : pos = sffo.getInt<int>();
80 : : } else {
81 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', invalid value type: %s", uvTypeName(sffo.type())));
+ - ]
82 : : }
83 : :
84 [ + + ]: 100 : if (sffo_set.contains(pos))
85 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', duplicated position: %d", pos));
86 [ + + ]: 98 : if (pos < 0)
87 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', negative position: %d", pos));
88 [ + + ]: 97 : if (pos >= int(destinations.size()))
89 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', position too large: %d", pos));
90 [ + - ]: 96 : sffo_set.insert(pos);
91 : : }
92 : : return sffo_set;
93 : 6 : }
94 : :
95 : 197 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, const CMutableTransaction& rawTx)
96 : : {
97 : : // Make a blank psbt
98 : 197 : PartiallySignedTransaction psbtx(rawTx);
99 : :
100 : : // First fill transaction with our data without signing,
101 : : // so external signers are not asked to sign more than once.
102 : 197 : bool complete;
103 [ + - ]: 197 : pwallet->FillPSBT(psbtx, complete, std::nullopt, /*sign=*/false, /*bip32derivs=*/true);
104 [ + - ]: 197 : const auto err{pwallet->FillPSBT(psbtx, complete, std::nullopt, /*sign=*/true, /*bip32derivs=*/false)};
105 [ - + ]: 197 : if (err) {
106 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
107 : : }
108 : :
109 [ + - ]: 197 : CMutableTransaction mtx;
110 [ + - ]: 197 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
111 : :
112 : 197 : UniValue result(UniValue::VOBJ);
113 : :
114 [ + - + - : 218 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
115 [ + - + + : 394 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
116 [ + + + + : 197 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
117 : : // Serialize the PSBT
118 : 52 : DataStream ssTx{};
119 [ + - ]: 52 : ssTx << psbtx;
120 [ + - + - : 104 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
121 : 52 : }
122 : :
123 [ + + ]: 197 : if (complete) {
124 [ + - + - ]: 171 : std::string hex{EncodeHexTx(CTransaction(mtx))};
125 [ + - ]: 171 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
126 [ + - + - : 342 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
127 [ + + ]: 171 : if (add_to_wallet && !psbt_opt_in) {
128 [ + - + - ]: 435 : pwallet->CommitTransaction(tx, {}, /*orderForm=*/{});
129 : : } else {
130 [ + - + - : 52 : result.pushKV("hex", hex);
+ - ]
131 : : }
132 : 171 : }
133 [ + - + - : 394 : result.pushKV("complete", complete);
+ - ]
134 : :
135 : 394 : return result;
136 : 197 : }
137 : :
138 : 302 : static void PreventOutdatedOptions(const UniValue& options)
139 : : {
140 [ + + ]: 604 : if (options.exists("feeRate")) {
141 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
142 : : }
143 [ - + ]: 602 : if (options.exists("changeAddress")) {
144 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
145 : : }
146 [ - + ]: 602 : if (options.exists("changePosition")) {
147 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
148 : : }
149 [ - + ]: 602 : if (options.exists("includeWatching")) {
150 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use include_watching instead of includeWatching");
151 : : }
152 [ - + ]: 602 : if (options.exists("lockUnspents")) {
153 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
154 : : }
155 [ - + ]: 602 : if (options.exists("subtractFeeFromOutputs")) {
156 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
157 : : }
158 : 301 : }
159 : :
160 : 1218 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, mapValue_t map_value, bool verbose)
161 : : {
162 : 1218 : EnsureWalletIsUnlocked(wallet);
163 : :
164 : : // This function is only used by sendtoaddress and sendmany.
165 : : // This should always try to sign, if we don't have private keys, don't try to do anything here.
166 [ - + ]: 1218 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
167 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
168 : : }
169 : :
170 : : // Shuffle recipient list
171 : 1218 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
172 : :
173 : : // Send
174 : 1218 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
175 [ + + ]: 1218 : if (!res) {
176 [ + - + - ]: 32 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
177 : : }
178 : 1202 : const CTransactionRef& tx = res->tx;
179 [ + - + - ]: 3606 : wallet.CommitTransaction(tx, std::move(map_value), /*orderForm=*/{});
180 [ + + ]: 1202 : if (verbose) {
181 : 2 : UniValue entry(UniValue::VOBJ);
182 [ + - + - : 4 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
183 [ + - + - : 4 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_calc.reason));
+ - + - ]
184 : 2 : return entry;
185 : 0 : }
186 [ + - + - ]: 1200 : return tx->GetHash().GetHex();
187 : 1202 : }
188 : :
189 : :
190 : : /**
191 : : * Update coin control with fee estimation based on the given parameters
192 : : *
193 : : * @param[in] wallet Wallet reference
194 : : * @param[in,out] cc Coin control to be updated
195 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
196 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
197 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
198 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
199 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
200 : : * verify only that fee_rate is greater than 0
201 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
202 : : */
203 : 1886 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
204 : : {
205 [ + + ]: 1886 : if (!fee_rate.isNull()) {
206 [ + + ]: 387 : if (!conf_target.isNull()) {
207 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
208 : : }
209 [ + + + + ]: 384 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
210 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
211 : : }
212 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
213 [ - + ]: 381 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
214 [ + + ]: 305 : if (override_min_fee) cc.fOverrideFeeRate = true;
215 : : // Default RBF to true for explicit fee_rate, if unset.
216 [ + + ]: 305 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
217 : 305 : return;
218 : : }
219 [ + + + + ]: 1499 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
220 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
221 : : }
222 [ + + ]: 1472 : if (!conf_target.isNull()) {
223 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().estimateMaxBlocks());
224 : : }
225 : : }
226 : :
227 : 1944 : RPCHelpMan sendtoaddress()
228 : : {
229 : 1944 : return RPCHelpMan{
230 : : "sendtoaddress",
231 : 1944 : "Send an amount to a given address." +
232 [ + - ]: 1944 : HELP_REQUIRING_PASSPHRASE,
233 : : {
234 [ + - ]: 1944 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
235 [ + - ]: 3888 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
236 [ + - ]: 1944 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
237 : : "This is not part of the transaction, just kept in your wallet."},
238 [ + - ]: 1944 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
239 : : "to which you're sending the transaction. This is not part of the \n"
240 : : "transaction, just kept in your wallet."},
241 [ + - ]: 3888 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
242 : : "The recipient will receive less bitcoins than you enter in the amount field."},
243 [ + - ]: 3888 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
244 [ + - ]: 3888 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
245 [ + - ]: 3888 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
246 [ + - + - ]: 3888 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
247 [ + - ]: 3888 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
248 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
249 [ + - ]: 5832 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
250 [ + - ]: 3888 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
251 : : },
252 : : {
253 : : RPCResult{"if verbose is not set or set to false",
254 : : RPCResult::Type::STR_HEX, "txid", "The transaction id."
255 [ + - + - : 3888 : },
+ - + - ]
256 : : RPCResult{"if verbose is set to true",
257 : : RPCResult::Type::OBJ, "", "",
258 : : {
259 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
260 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
261 : : },
262 [ + - + - : 7776 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
263 : : },
264 : 1944 : RPCExamples{
265 : : "\nSend 0.1 BTC\n"
266 [ + - + - : 5832 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
267 : 1944 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
268 [ + - + - : 9720 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
269 [ + - ]: 3888 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
270 [ + - + - : 9720 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
271 : 1944 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
272 [ + - + - : 9720 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
273 [ + - ]: 3888 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
274 [ + - + - : 9720 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
275 [ + - + - : 7776 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
276 [ + - ]: 1944 : },
277 : 1170 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
278 : : {
279 : 1170 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
280 [ - + ]: 1170 : if (!pwallet) return UniValue::VNULL;
281 : :
282 : : // Make sure the results are valid at least up to the most recent block
283 : : // the user could have gotten from another RPC command prior to now
284 [ + - ]: 1170 : pwallet->BlockUntilSyncedToCurrentChain();
285 : :
286 [ + - ]: 1170 : LOCK(pwallet->cs_wallet);
287 : :
288 : : // Wallet comments
289 [ + - ]: 1170 : mapValue_t mapValue;
290 [ + - + + : 1170 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
291 [ + - + - : 2 : mapValue["comment"] = request.params[2].get_str();
+ - + - +
- ]
292 [ + - + + : 1170 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
293 [ + - + - : 2 : mapValue["to"] = request.params[3].get_str();
+ - + - +
- ]
294 : :
295 [ + - ]: 1170 : CCoinControl coin_control;
296 [ + - + + ]: 1170 : if (!request.params[5].isNull()) {
297 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
298 : : }
299 : :
300 [ + - + - ]: 1170 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
301 : : // We also enable partial spend avoidance if reuse avoidance is set.
302 : 1170 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
303 : :
304 [ + - + - : 1170 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
305 : :
306 [ + + ]: 1170 : EnsureWalletIsUnlocked(*pwallet);
307 : :
308 : 1169 : UniValue address_amounts(UniValue::VOBJ);
309 [ + - + - : 1169 : const std::string address = request.params[0].get_str();
+ - ]
310 [ + - + - : 2338 : address_amounts.pushKV(address, request.params[1]);
+ - + - ]
311 : :
312 [ + - ]: 1169 : std::set<int> sffo_set;
313 [ + - + + : 1169 : if (!request.params[4].isNull() && request.params[4].get_bool()) {
+ - + - +
+ ]
314 [ + - ]: 216 : sffo_set.insert(0);
315 : : }
316 : :
317 [ + + + - ]: 1169 : std::vector<CRecipient> recipients{CreateRecipients(ParseOutputs(address_amounts), sffo_set)};
318 [ + - + + : 1167 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
319 : :
320 [ + - + + ]: 1171 : return SendMoney(*pwallet, coin_control, recipients, mapValue, verbose);
321 [ + - ]: 3526 : },
322 [ + - + - : 112752 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
323 [ + - + - : 54432 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- ]
324 : :
325 : 854 : RPCHelpMan sendmany()
326 : : {
327 : 854 : return RPCHelpMan{"sendmany",
328 : 854 : "Send multiple times. Amounts are double-precision floating point numbers." +
329 [ + - ]: 854 : HELP_REQUIRING_PASSPHRASE,
330 : : {
331 [ + - ]: 1708 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
332 [ + - + - ]: 1708 : RPCArgOptions{
333 : : .oneline_description = "\"\"",
334 : : }},
335 [ + - ]: 854 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
336 : : {
337 [ + - ]: 1708 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
338 : : },
339 : : },
340 [ + - ]: 854 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value"},
341 [ + - ]: 854 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
342 [ + - ]: 854 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
343 : : "The fee will be equally deducted from the amount of each selected address.\n"
344 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
345 : : "If no addresses are specified here, the sender pays the fee.",
346 : : {
347 [ + - ]: 854 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
348 : : },
349 : : },
350 [ + - ]: 1708 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
351 [ + - ]: 1708 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
352 [ + - ]: 1708 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
353 [ + - + - ]: 1708 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
354 [ + - ]: 2562 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
355 [ + - ]: 1708 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
356 : : },
357 : : {
358 : : RPCResult{"if verbose is not set or set to false",
359 : : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
360 : : "the number of addresses."
361 [ + - + - : 1708 : },
+ - + - ]
362 : : RPCResult{"if verbose is set to true",
363 : : RPCResult::Type::OBJ, "", "",
364 : : {
365 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
366 : : "the number of addresses."},
367 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
368 : : },
369 [ + - + - : 3416 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
370 : : },
371 : 854 : RPCExamples{
372 : : "\nSend two amounts to two different addresses:\n"
373 [ + - + - : 3416 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
374 : 854 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
375 [ + - + - : 5124 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
376 : 854 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
377 [ + - + - : 6832 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
378 : 854 : "\nAs a JSON-RPC call\n"
379 [ + - + - : 4270 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
380 [ + - ]: 854 : },
381 : 80 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
382 : : {
383 : 80 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
384 [ - + ]: 80 : if (!pwallet) return UniValue::VNULL;
385 : :
386 : : // Make sure the results are valid at least up to the most recent block
387 : : // the user could have gotten from another RPC command prior to now
388 [ + - ]: 80 : pwallet->BlockUntilSyncedToCurrentChain();
389 : :
390 [ + - ]: 80 : LOCK(pwallet->cs_wallet);
391 : :
392 [ + - + + : 80 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
393 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
394 : : }
395 [ + - + - : 80 : UniValue sendTo = request.params[1].get_obj();
+ - ]
396 : :
397 [ + - ]: 80 : mapValue_t mapValue;
398 [ + - + + : 80 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
399 [ # # # # : 0 : mapValue["comment"] = request.params[3].get_str();
# # # # #
# ]
400 : :
401 [ + - ]: 80 : CCoinControl coin_control;
402 [ + - - + ]: 80 : if (!request.params[5].isNull()) {
403 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
404 : : }
405 : :
406 [ + - + - : 80 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
407 : :
408 : 57 : std::vector<CRecipient> recipients = CreateRecipients(
409 [ + - ]: 102 : ParseOutputs(sendTo),
410 [ + - + - : 57 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ + ]
411 [ + - ]: 51 : );
412 [ + - + + : 51 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
413 : :
414 [ + + ]: 63 : return SendMoney(*pwallet, coin_control, recipients, std::move(mapValue), verbose);
415 [ + - ]: 252 : },
416 [ + - + - : 50386 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
417 [ + - + - : 24766 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
418 : :
419 : 793 : RPCHelpMan settxfee()
420 : : {
421 : 793 : return RPCHelpMan{
422 : : "settxfee",
423 [ + - ]: 1586 : "(DEPRECATED) Set the transaction fee rate in " + CURRENCY_UNIT + "/kvB for this wallet. Overrides the global -paytxfee command line parameter.\n"
424 : 793 : "Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.\n",
425 : : {
426 [ + - ]: 1586 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The transaction fee rate in " + CURRENCY_UNIT + "/kvB"},
427 : : },
428 : 0 : RPCResult{
429 : : RPCResult::Type::BOOL, "", "Returns true if successful"
430 [ + - + - : 1586 : },
+ - ]
431 : 793 : RPCExamples{
432 [ + - + - : 1586 : HelpExampleCli("settxfee", "0.00001")
+ - ]
433 [ + - + - : 3172 : + HelpExampleRpc("settxfee", "0.00001")
+ - + - ]
434 [ + - ]: 793 : },
435 : 19 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
436 : : {
437 : 19 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
438 [ - + ]: 19 : if (!pwallet) return UniValue::VNULL;
439 : :
440 [ + - ]: 19 : LOCK(pwallet->cs_wallet);
441 : :
442 [ + - + - : 19 : if (!pwallet->chain().rpcEnableDeprecated("settxfee")) {
+ + ]
443 [ + - ]: 1 : throw JSONRPCError(RPC_METHOD_DEPRECATED, "settxfee is deprecated and will be fully removed in v31.0."
444 [ + - + - ]: 2 : "\nTo use settxfee restart bitcoind with -deprecatedrpc=settxfee.");
445 : : }
446 : :
447 [ + - + - ]: 18 : CAmount nAmount = AmountFromValue(request.params[0]);
448 [ + - ]: 18 : CFeeRate tx_fee_rate(nAmount, 1000);
449 [ + - ]: 18 : CFeeRate max_tx_fee_rate(pwallet->m_default_max_tx_fee, 1000);
450 [ + + ]: 18 : if (tx_fee_rate == CFeeRate(0)) {
451 : : // automatic selection
452 [ + - + + ]: 16 : } else if (tx_fee_rate < pwallet->chain().relayMinFee()) {
453 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than min relay tx fee (%s)", pwallet->chain().relayMinFee().ToString()));
+ - + - ]
454 [ + + ]: 15 : } else if (tx_fee_rate < pwallet->m_min_fee) {
455 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than wallet min fee (%s)", pwallet->m_min_fee.ToString()));
+ - ]
456 [ + + ]: 14 : } else if (tx_fee_rate > max_tx_fee_rate) {
457 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be more than wallet max tx fee (%s)", max_tx_fee_rate.ToString()));
+ - ]
458 : : }
459 : :
460 [ + - ]: 15 : pwallet->m_pay_tx_fee = tx_fee_rate;
461 [ + - ]: 15 : return true;
462 : 34 : },
463 [ + - + - : 8723 : };
+ - + - +
- + + -
- ]
464 [ + - + - ]: 2379 : }
465 : :
466 : :
467 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
468 : 3791 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
469 : : {
470 : 3791 : std::vector<RPCArg> args = {
471 [ + - + - ]: 15164 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
472 [ + - ]: 7582 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
473 [ + - + - : 7582 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - ]
474 : : {
475 [ + - ]: 7582 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
476 : : "Allows this transaction to be replaced by a transaction with higher fees"
477 : : },
478 [ + - + - : 60656 : };
+ - + - +
- + - + -
+ + - - ]
479 [ + - ]: 3791 : if (solving_data) {
480 [ + - + - : 102357 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + + +
+ + - - -
- - - -
- ]
481 : : "Used for fee estimation during coin selection.",
482 : : {
483 : : {
484 : 7582 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
485 : : {
486 [ + - ]: 3791 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
487 : : }
488 : : },
489 : : {
490 : 7582 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
491 : : {
492 [ + - ]: 3791 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
493 : : }
494 : : },
495 : : {
496 : 7582 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
497 : : {
498 [ + - ]: 3791 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
499 : : }
500 : : },
501 : : }
502 : : });
503 : : }
504 : 3791 : return args;
505 [ + - + - : 72029 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - ]
506 : :
507 : 587 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
508 : : {
509 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
510 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
511 : 587 : CHECK_NONFATAL(tx.vout.empty());
512 : : // Make sure the results are valid at least up to the most recent block
513 : : // the user could have gotten from another RPC command prior to now
514 : 587 : wallet.BlockUntilSyncedToCurrentChain();
515 : :
516 : 587 : std::optional<unsigned int> change_position;
517 : 587 : bool lockUnspents = false;
518 [ + + ]: 587 : if (!options.isNull()) {
519 [ + + ]: 529 : if (options.type() == UniValue::VBOOL) {
520 : : // backward compatibility bool only fallback
521 : 1 : coinControl.fAllowWatchOnly = options.get_bool();
522 : : }
523 : : else {
524 [ + + + + : 15335 : RPCTypeCheckObj(options,
+ + ]
525 : : {
526 [ + - ]: 528 : {"add_inputs", UniValueType(UniValue::VBOOL)},
527 [ + - ]: 528 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
528 [ + - ]: 528 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
529 [ + - ]: 528 : {"changeAddress", UniValueType(UniValue::VSTR)},
530 [ + - ]: 528 : {"change_address", UniValueType(UniValue::VSTR)},
531 [ + - ]: 528 : {"changePosition", UniValueType(UniValue::VNUM)},
532 [ + - ]: 528 : {"change_position", UniValueType(UniValue::VNUM)},
533 [ + - ]: 528 : {"change_type", UniValueType(UniValue::VSTR)},
534 [ + - ]: 528 : {"includeWatching", UniValueType(UniValue::VBOOL)},
535 [ + - ]: 528 : {"include_watching", UniValueType(UniValue::VBOOL)},
536 [ + - ]: 528 : {"inputs", UniValueType(UniValue::VARR)},
537 [ + - ]: 528 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
538 [ + - ]: 528 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
539 [ + - ]: 528 : {"locktime", UniValueType(UniValue::VNUM)},
540 [ + - ]: 528 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
541 [ + - ]: 528 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
542 [ + - ]: 528 : {"psbt", UniValueType(UniValue::VBOOL)},
543 [ + - ]: 528 : {"solving_data", UniValueType(UniValue::VOBJ)},
544 [ + - ]: 528 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
545 [ + - ]: 528 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
546 [ + - ]: 528 : {"replaceable", UniValueType(UniValue::VBOOL)},
547 [ + - ]: 528 : {"conf_target", UniValueType(UniValue::VNUM)},
548 [ + - ]: 528 : {"estimate_mode", UniValueType(UniValue::VSTR)},
549 [ + - ]: 528 : {"minconf", UniValueType(UniValue::VNUM)},
550 [ + - ]: 528 : {"maxconf", UniValueType(UniValue::VNUM)},
551 [ + - ]: 528 : {"input_weights", UniValueType(UniValue::VARR)},
552 [ + - ]: 528 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
553 : : },
554 : : true, true);
555 : :
556 [ + + ]: 1010 : if (options.exists("add_inputs")) {
557 [ + - + - ]: 171 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
558 : : }
559 : :
560 [ + - + - : 1506 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
561 [ + + + - : 39 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - + -
+ + + + -
- - - ]
562 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
563 : :
564 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
565 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
566 : : }
567 : :
568 [ + - ]: 22 : coinControl.destChange = dest;
569 : 15 : }
570 : :
571 [ + - + - : 1505 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
572 [ + + + - : 111 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
573 [ + - + + ]: 37 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
574 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
575 : : }
576 : 36 : change_position = (unsigned int)pos;
577 : : }
578 : :
579 [ + + ]: 1004 : if (options.exists("change_type")) {
580 [ + - + - : 227 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
581 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
582 : : }
583 [ + - + + : 150 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
+ - + + ]
584 [ - + ]: 146 : coinControl.m_change_type.emplace(parsed.value());
585 : : } else {
586 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
587 : : }
588 : : }
589 : :
590 [ + + + - : 1497 : const UniValue include_watching_option = options.exists("include_watching") ? options["include_watching"] : options["includeWatching"];
+ - + - +
- + - + +
+ + - - -
- ]
591 [ + - ]: 499 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(include_watching_option, wallet);
592 : :
593 [ + - + - : 1494 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
594 [ + - + + : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + -
+ + + + -
- - - ]
595 : : }
596 : :
597 [ + - + + ]: 998 : if (options.exists("include_unsafe")) {
598 [ + - + - : 5 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
+ - ]
599 : : }
600 : :
601 [ + - + + ]: 998 : if (options.exists("feeRate")) {
602 [ + - + + ]: 116 : if (options.exists("fee_rate")) {
603 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
604 : : }
605 [ + - + + ]: 112 : if (options.exists("conf_target")) {
606 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
607 : : }
608 [ + - + + ]: 108 : if (options.exists("estimate_mode")) {
609 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
610 : : }
611 [ + - + - : 104 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
+ + - + ]
612 : 36 : coinControl.fOverrideFeeRate = true;
613 : : }
614 : :
615 [ + - + + ]: 954 : if (options.exists("replaceable")) {
616 [ + - + - : 7 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
617 : : }
618 : :
619 [ + - + + ]: 954 : if (options.exists("minconf")) {
620 [ + - + - : 8 : coinControl.m_min_depth = options["minconf"].getInt<int>();
+ - ]
621 : :
622 [ + + ]: 8 : if (coinControl.m_min_depth < 0) {
623 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
624 : : }
625 : : }
626 : :
627 [ + - + + ]: 952 : if (options.exists("maxconf")) {
628 [ + - + - : 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
629 : :
630 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
631 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
632 : : }
633 : : }
634 [ + - + - : 1146 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + - +
+ ]
635 : 499 : }
636 : : } else {
637 : : // if options is null and not a bool
638 : 58 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(NullUniValue, wallet);
639 : : }
640 : :
641 [ + + ]: 876 : if (options.exists("solving_data")) {
642 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
643 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
644 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
645 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
646 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
647 : : // Add witness script for pubkeys
648 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
649 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
650 : 3 : }
651 : : }
652 : :
653 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
654 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
655 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
656 [ + - + + ]: 6 : if (!IsHex(script_str)) {
657 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
658 : : }
659 [ + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
660 : 5 : const CScript script(script_data.begin(), script_data.end());
661 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
662 : 5 : }
663 : : }
664 : :
665 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
666 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
667 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
668 : 8 : FlatSigningProvider desc_out;
669 [ + - ]: 8 : std::string error;
670 : 8 : std::vector<CScript> scripts_temp;
671 [ + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
672 [ + + ]: 8 : if (descs.empty()) {
673 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
674 : : }
675 [ + + ]: 14 : for (auto& desc : descs) {
676 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
677 : : }
678 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
679 : 10 : }
680 : : }
681 : 14 : }
682 : :
683 [ + + ]: 868 : if (options.exists("input_weights")) {
684 [ + - + - : 2595 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
685 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
686 : :
687 : 2491 : const UniValue& vout_v = input.find_value("vout");
688 [ + + ]: 2491 : if (!vout_v.isNum()) {
689 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
690 : : }
691 : 2490 : int vout = vout_v.getInt<int>();
692 [ + + ]: 2490 : if (vout < 0) {
693 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
694 : : }
695 : :
696 : 2489 : const UniValue& weight_v = input.find_value("weight");
697 [ + + ]: 2489 : if (!weight_v.isNum()) {
698 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
699 : : }
700 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
701 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
702 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
703 [ + + ]: 2488 : if (weight < min_input_weight) {
704 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
705 : : }
706 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
707 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
708 : : }
709 : :
710 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
711 : : }
712 : : }
713 : :
714 [ + + ]: 856 : if (options.exists("max_tx_weight")) {
715 [ + - + - ]: 8 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
716 : : }
717 : :
718 [ - + ]: 428 : if (recipients.empty())
719 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
720 : :
721 [ + - ]: 428 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
722 [ + + ]: 428 : if (!txr) {
723 [ + - + - ]: 138 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
724 : : }
725 : 359 : return *txr;
726 [ + - + - : 910 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
727 : :
728 : 403 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
729 : : {
730 [ + + ]: 806 : if (options.exists("input_weights")) {
731 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
732 : : }
733 [ + + ]: 401 : if (inputs.size() == 0) {
734 : : return;
735 : : }
736 : 140 : UniValue weights(UniValue::VARR);
737 [ + - + + ]: 2895 : for (const UniValue& input : inputs.getValues()) {
738 [ + - + + ]: 5510 : if (input.exists("weight")) {
739 [ + - + - ]: 6 : weights.push_back(input);
740 : : }
741 : : }
742 [ + - + - ]: 280 : options.pushKV("input_weights", std::move(weights));
743 : 140 : }
744 : :
745 : 960 : RPCHelpMan fundrawtransaction()
746 : : {
747 : 960 : return RPCHelpMan{
748 : : "fundrawtransaction",
749 : : "If the transaction has no inputs, they will be automatically selected to meet its out value.\n"
750 : : "It will add at most one change output to the outputs.\n"
751 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
752 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
753 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
754 : : "or signrawtransactionwithwallet for that.\n"
755 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
756 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
757 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
758 : : "in the wallet using importdescriptors (to calculate fees).\n"
759 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
760 : : "Only pay-to-pubkey, multisig, and P2SH versions thereof are currently supported for watch-only\n",
761 : : {
762 [ + - ]: 960 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
763 [ + - ]: 960 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "For backward compatibility: passing in a true instead of an object will result in {\"includeWatching\":true}",
764 [ + - + - : 76800 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
765 : : {
766 [ + - ]: 1920 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
767 [ + - ]: 1920 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
768 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
769 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
770 [ + - ]: 1920 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
771 [ + - ]: 960 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
772 [ + - ]: 1920 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
773 [ + - ]: 1920 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
774 [ + - ]: 1920 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
775 [ + - ]: 1920 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
776 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
777 : : "e.g. with 'importdescriptors'."},
778 [ + - ]: 1920 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
779 [ + - + - ]: 3840 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
780 [ + - + - ]: 3840 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
781 : 1920 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
782 : : "The fee will be equally deducted from the amount of each specified output.\n"
783 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
784 : : "If no outputs are specified here, the sender pays the fee.",
785 : : {
786 [ + - ]: 960 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
787 : : },
788 : : },
789 [ + - ]: 960 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
790 : : {
791 [ + - ]: 960 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
792 : : {
793 [ + - ]: 960 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
794 [ + - ]: 960 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
795 [ + - ]: 960 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
796 : : "including the weight of the outpoint and sequence number. "
797 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
798 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
799 : : "Remember to convert serialized sizes to weight units when necessary."},
800 : : },
801 : : },
802 : : },
803 : : },
804 [ + - ]: 1920 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
805 : : "Transaction building will fail if this can not be satisfied."},
806 : : },
807 [ + - ]: 1920 : FundTxDoc()),
808 [ + - + - ]: 1920 : RPCArgOptions{
809 : : .skip_type_check = true,
810 : : .oneline_description = "options",
811 : : }},
812 [ + - ]: 1920 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
813 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
814 : : "If true, only witness deserialization will be tried.\n"
815 : : "If false, only non-witness deserialization will be tried.\n"
816 : : "This boolean should reflect whether the transaction has inputs\n"
817 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
818 : : },
819 : : },
820 : 0 : RPCResult{
821 : : RPCResult::Type::OBJ, "", "",
822 : : {
823 : : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
824 [ + - ]: 1920 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
825 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
826 : : }
827 [ + - + - : 6720 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
828 : 960 : RPCExamples{
829 : : "\nCreate a transaction with no inputs\n"
830 [ + - + - : 1920 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
831 : 960 : "\nAdd sufficient unsigned inputs to meet the output value\n"
832 [ + - + - : 3840 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
833 : 960 : "\nSign the transaction\n"
834 [ + - + - : 3840 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
835 : 960 : "\nSend the transaction\n"
836 [ + - + - : 3840 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
837 [ + - ]: 960 : },
838 : 186 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
839 : : {
840 : 186 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
841 [ - + ]: 186 : if (!pwallet) return UniValue::VNULL;
842 : :
843 : : // parse hex string from parameter
844 [ + - ]: 186 : CMutableTransaction tx;
845 [ + - - + : 186 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
846 [ + - - + : 186 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
847 [ + - + - : 186 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
848 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
849 : : }
850 [ + - + - ]: 186 : UniValue options = request.params[1];
851 : 186 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
852 [ + + ]: 11986 : for (const auto& tx_out : tx.vout) {
853 : 11800 : CTxDestination dest;
854 [ + - ]: 11800 : ExtractDestination(tx_out.scriptPubKey, dest);
855 [ + - ]: 11800 : destinations.emplace_back(dest, tx_out.nValue);
856 : 11800 : }
857 [ + - + - ]: 186 : std::vector<std::string> dummy(destinations.size(), "dummy");
858 [ + - ]: 186 : std::vector<CRecipient> recipients = CreateRecipients(
859 : : destinations,
860 [ + - + - : 372 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
861 [ + - ]: 186 : );
862 [ + - ]: 186 : CCoinControl coin_control;
863 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
864 : 186 : coin_control.m_allow_other_inputs = true;
865 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
866 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
867 : 186 : tx.vout.clear();
868 [ + + ]: 186 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
869 : :
870 : 107 : UniValue result(UniValue::VOBJ);
871 [ + - + - : 214 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
872 [ + - + - : 214 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
873 [ + + + - : 214 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
874 : :
875 : 107 : return result;
876 [ + - ]: 902 : },
877 [ + - + - : 16320 : };
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
878 [ + - + - : 46080 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
879 : :
880 : 1065 : RPCHelpMan signrawtransactionwithwallet()
881 : : {
882 : 1065 : return RPCHelpMan{
883 : : "signrawtransactionwithwallet",
884 : : "Sign inputs for raw transaction (serialized, hex-encoded).\n"
885 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
886 : 1065 : "this transaction depends on but may not yet be in the block chain." +
887 [ + - ]: 1065 : HELP_REQUIRING_PASSPHRASE,
888 : : {
889 [ + - ]: 1065 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
890 [ + - ]: 1065 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
891 : : {
892 [ + - ]: 1065 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
893 : : {
894 [ + - ]: 1065 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
895 [ + - ]: 1065 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
896 [ + - ]: 1065 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
897 [ + - ]: 1065 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
898 [ + - ]: 1065 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
899 [ + - ]: 1065 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
900 : : },
901 : : },
902 : : },
903 : : },
904 [ + - ]: 2130 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
905 : : " \"DEFAULT\"\n"
906 : : " \"ALL\"\n"
907 : : " \"NONE\"\n"
908 : : " \"SINGLE\"\n"
909 : : " \"ALL|ANYONECANPAY\"\n"
910 : : " \"NONE|ANYONECANPAY\"\n"
911 : : " \"SINGLE|ANYONECANPAY\""},
912 : : },
913 : 0 : RPCResult{
914 : : RPCResult::Type::OBJ, "", "",
915 : : {
916 : : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
917 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
918 : : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
919 : : {
920 : : {RPCResult::Type::OBJ, "", "",
921 : : {
922 : : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
923 : : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
924 : : {RPCResult::Type::ARR, "witness", "",
925 : : {
926 : : {RPCResult::Type::STR_HEX, "witness", ""},
927 : : }},
928 : : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
929 : : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
930 : : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
931 : : }},
932 : : }},
933 : : }
934 [ + - + - : 17040 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
935 : 1065 : RPCExamples{
936 [ + - + - : 2130 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
937 [ + - + - : 4260 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
938 [ + - ]: 1065 : },
939 : 291 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
940 : : {
941 [ - + ]: 291 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
942 [ - + ]: 291 : if (!pwallet) return UniValue::VNULL;
943 : :
944 [ + - ]: 291 : CMutableTransaction mtx;
945 [ + - + - : 291 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
946 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
947 : : }
948 : :
949 : : // Sign the transaction
950 [ + - ]: 291 : LOCK(pwallet->cs_wallet);
951 [ + + ]: 291 : EnsureWalletIsUnlocked(*pwallet);
952 : :
953 : : // Fetch previous transactions (inputs):
954 : 290 : std::map<COutPoint, Coin> coins;
955 [ + + ]: 1036 : for (const CTxIn& txin : mtx.vin) {
956 [ + - ]: 746 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
957 : : }
958 [ + - ]: 290 : pwallet->chain().findCoins(coins);
959 : :
960 : : // Parse the prevtxs array
961 [ + - + + ]: 290 : ParsePrevouts(request.params[1], nullptr, coins);
962 : :
963 [ + - + + ]: 281 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
964 [ + + ]: 280 : if (!nHashType) {
965 : 277 : nHashType = SIGHASH_DEFAULT;
966 : : }
967 : :
968 : : // Script verification errors
969 [ + - ]: 280 : std::map<int, bilingual_str> input_errors;
970 : :
971 [ + - ]: 280 : bool complete = pwallet->SignTransaction(mtx, coins, *nHashType, input_errors);
972 : 280 : UniValue result(UniValue::VOBJ);
973 [ + + ]: 280 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
974 : 278 : return result;
975 [ + - ]: 1154 : },
976 [ + - + - : 42600 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - ]
977 [ + - + - : 35145 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
978 : :
979 : : // Definition of allowed formats of specifying transaction outputs in
980 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
981 : 3664 : static std::vector<RPCArg> OutputsDoc()
982 : : {
983 : 3664 : return
984 : : {
985 [ + - ]: 3664 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
986 : : {
987 [ + - ]: 3664 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
988 : 3664 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
989 : : },
990 : : },
991 [ + - ]: 3664 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
992 : : {
993 [ + - ]: 3664 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data that becomes a part of an OP_RETURN output"},
994 : : },
995 : : },
996 [ + - + - : 51296 : };
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
997 [ + - + - : 32976 : }
+ - + - +
- - - ]
998 : :
999 : 1707 : static RPCHelpMan bumpfee_helper(std::string method_name)
1000 : : {
1001 : 1707 : const bool want_psbt = method_name == "psbtbumpfee";
1002 : 1707 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeEstimateMode::SAT_VB)};
1003 : :
1004 : 1707 : return RPCHelpMan{method_name,
1005 : : "Bumps the fee of a transaction T, replacing it with a new transaction B.\n"
1006 [ + + + - : 4340 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
+ - ]
1007 : : "A transaction with the given txid must be in the wallet.\n"
1008 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
1009 : : "It may add a new change output if one does not already exist.\n"
1010 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
1011 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
1012 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
1013 : : "The user can specify a confirmation target for estimatesmartfee.\n"
1014 [ + - ]: 3414 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
1015 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
1016 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
1017 [ + - + - ]: 5121 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
1018 : : {
1019 [ + - ]: 1707 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
1020 [ + - ]: 1707 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1021 : : {
1022 [ + - ]: 3414 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
1023 [ + - ]: 3414 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
1024 : 1707 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
1025 [ + - ]: 3414 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
1026 [ + - + - ]: 5121 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
1027 [ + - ]: 3414 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true},
1028 : : "Whether the new transaction should be\n"
1029 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
1030 : : "be set to 0xfffffffd. If false, any input sequence numbers in the\n"
1031 : : "transaction will be set to 0xfffffffe\n"
1032 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
1033 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
1034 : : "are replaceable).\n"},
1035 [ + - ]: 3414 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1036 [ + - + - ]: 3414 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1037 : 3414 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1038 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1039 : : "At least one output of either type must be specified.\n"
1040 : : "Cannot be provided if 'original_change_index' is specified.",
1041 [ + - ]: 3414 : OutputsDoc(),
1042 [ + - ]: 3414 : RPCArgOptions{.skip_type_check = true}},
1043 [ + - ]: 3414 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
1044 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1045 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1046 : : "original change output. The change output’s amount can increase if bumping the transaction "
1047 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1048 : : },
1049 [ + - + - ]: 1707 : RPCArgOptions{.oneline_description="options"}},
1050 : : },
1051 : 0 : RPCResult{
1052 [ + - + - : 15363 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1053 [ + + + - : 8535 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1054 [ + - + - : 4831 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ - + - +
+ + + + +
- - - - -
- ]
1055 [ + - + - : 5411 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ - + - +
+ + + + +
- - - - -
- ]
1056 : : {
1057 : : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1058 : : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1059 : : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1060 : : {
1061 : : {RPCResult::Type::STR, "", ""},
1062 : : }},
1063 : : })
1064 [ + - + - : 5121 : },
+ - ]
1065 : 1707 : RPCExamples{
1066 [ + + + - : 4340 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1067 [ + - + - : 5121 : HelpExampleCli(method_name, "<txid>")
+ - ]
1068 : 1707 : },
1069 [ + - ]: 1707 : [want_psbt](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1070 : : {
1071 : 159 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1072 [ - + ]: 159 : if (!pwallet) return UniValue::VNULL;
1073 : :
1074 [ + - + + : 159 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1075 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1076 : : }
1077 : :
1078 [ + - + - ]: 158 : Txid hash{Txid::FromUint256(ParseHashV(request.params[0], "txid"))};
1079 : :
1080 [ + - ]: 158 : CCoinControl coin_control;
1081 [ + - ]: 158 : coin_control.fAllowWatchOnly = pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS);
1082 : : // optional parameters
1083 [ + - ]: 158 : coin_control.m_signal_bip125_rbf = true;
1084 : 158 : std::vector<CTxOut> outputs;
1085 : :
1086 : 158 : std::optional<uint32_t> original_change_index;
1087 : :
1088 [ + - + + ]: 158 : if (!request.params[1].isNull()) {
1089 [ + - + - ]: 67 : UniValue options = request.params[1];
1090 [ + + + + : 607 : RPCTypeCheckObj(options,
+ + ]
1091 : : {
1092 [ + - ]: 67 : {"confTarget", UniValueType(UniValue::VNUM)},
1093 [ + - ]: 67 : {"conf_target", UniValueType(UniValue::VNUM)},
1094 [ + - ]: 67 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1095 [ + - ]: 67 : {"replaceable", UniValueType(UniValue::VBOOL)},
1096 [ + - ]: 67 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1097 [ + - ]: 67 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1098 [ + - ]: 67 : {"original_change_index", UniValueType(UniValue::VNUM)},
1099 : : },
1100 : : true, true);
1101 : :
1102 [ + - + - : 127 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1103 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1104 : : }
1105 : :
1106 [ + - - + : 186 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1107 : :
1108 [ + - + + ]: 124 : if (options.exists("replaceable")) {
1109 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1110 : : }
1111 [ + - + - : 143 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1112 : :
1113 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1114 [ + - + - : 43 : if (!options["outputs"].isNull()) {
+ + ]
1115 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- + + + +
- - ]
1116 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1117 : : }
1118 [ + - ]: 10 : CMutableTransaction tempTx;
1119 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1120 [ + - ]: 8 : outputs = tempTx.vout;
1121 : 10 : }
1122 : :
1123 [ + - + + ]: 80 : if (options.exists("original_change_index")) {
1124 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1125 : : }
1126 : 90 : }
1127 : :
1128 : : // Make sure the results are valid at least up to the most recent block
1129 : : // the user could have gotten from another RPC command prior to now
1130 [ + - ]: 130 : pwallet->BlockUntilSyncedToCurrentChain();
1131 : :
1132 [ + - ]: 130 : LOCK(pwallet->cs_wallet);
1133 : :
1134 [ + + ]: 130 : EnsureWalletIsUnlocked(*pwallet);
1135 : :
1136 : :
1137 : 129 : std::vector<bilingual_str> errors;
1138 : 129 : CAmount old_fee;
1139 : 129 : CAmount new_fee;
1140 [ + - ]: 129 : CMutableTransaction mtx;
1141 : 129 : feebumper::Result res;
1142 : : // Targeting feerate bump.
1143 [ + - ]: 129 : res = feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index);
1144 [ + + ]: 129 : if (res != feebumper::Result::OK) {
1145 [ - - + + : 23 : switch(res) {
+ ]
1146 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1147 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1148 : 0 : break;
1149 : 0 : case feebumper::Result::INVALID_REQUEST:
1150 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1151 : 16 : break;
1152 : 16 : case feebumper::Result::INVALID_PARAMETER:
1153 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1154 : 6 : break;
1155 : 6 : case feebumper::Result::WALLET_ERROR:
1156 [ + - ]: 6 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1157 : 1 : break;
1158 : 1 : default:
1159 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1160 : 106 : break;
1161 : : }
1162 : : }
1163 : :
1164 : 212 : UniValue result(UniValue::VOBJ);
1165 : :
1166 : : // For bumpfee, return the new transaction id.
1167 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1168 [ + + ]: 106 : if (!want_psbt) {
1169 [ + - - + ]: 99 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1170 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1171 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1172 : : }
1173 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1174 : : }
1175 : :
1176 [ + - ]: 99 : Txid txid;
1177 [ + - - + ]: 99 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1178 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1179 : : }
1180 : :
1181 [ + - + - : 198 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1182 : : } else {
1183 [ + - ]: 7 : PartiallySignedTransaction psbtx(mtx);
1184 : 7 : bool complete = false;
1185 [ + - ]: 7 : const auto err{pwallet->FillPSBT(psbtx, complete, std::nullopt, /*sign=*/false, /*bip32derivs=*/true)};
1186 [ + - ]: 7 : CHECK_NONFATAL(!err);
1187 [ + - ]: 7 : CHECK_NONFATAL(!complete);
1188 : 7 : DataStream ssTx{};
1189 [ + - ]: 7 : ssTx << psbtx;
1190 [ + - + - : 14 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1191 : 7 : }
1192 : :
1193 [ + - + - : 212 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1194 [ + - + - : 212 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1195 : 212 : UniValue result_errors(UniValue::VARR);
1196 [ - + ]: 106 : for (const bilingual_str& error : errors) {
1197 [ # # # # ]: 0 : result_errors.push_back(error.original);
1198 : : }
1199 [ + - + - ]: 212 : result.pushKV("errors", std::move(result_errors));
1200 : :
1201 : 106 : return result;
1202 [ + - + - : 516 : },
+ - + - +
- + - + -
+ - + - -
+ ]
1203 [ + - + - : 75108 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
1204 [ + - + - : 39261 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
1205 : :
1206 [ + - ]: 1852 : RPCHelpMan bumpfee() { return bumpfee_helper("bumpfee"); }
1207 [ + - ]: 1562 : RPCHelpMan psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1208 : :
1209 : 980 : RPCHelpMan send()
1210 : : {
1211 : 980 : return RPCHelpMan{
1212 : : "send",
1213 : : "EXPERIMENTAL warning: this call may be changed in future releases.\n"
1214 : : "\nSend a transaction.\n",
1215 : : {
1216 [ + - ]: 980 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1217 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1218 : : "At least one output of either type must be specified.\n"
1219 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1220 [ + - ]: 1960 : OutputsDoc(),
1221 [ + - ]: 1960 : RPCArgOptions{.skip_type_check = true}},
1222 [ + - ]: 1960 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1223 [ + - ]: 1960 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1224 [ + - + - ]: 1960 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1225 [ + - ]: 2940 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1226 [ + - ]: 980 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1227 [ + - + - : 98000 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + +
+ + + + +
- - - - -
- - - ]
1228 : : {
1229 [ + - ]: 1960 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
1230 [ + - ]: 1960 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1231 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1232 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1233 [ + - ]: 1960 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1234 [ + - ]: 980 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1235 [ + - ]: 1960 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
1236 [ + - ]: 1960 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1237 [ + - ]: 1960 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1238 [ + - ]: 1960 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\" and \"bech32m\"."},
1239 [ + - + - : 4900 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1240 [ + - ]: 1960 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
1241 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1242 : : "e.g. with 'importdescriptors'."},
1243 : 1960 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
1244 : : {
1245 [ + - ]: 980 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
1246 [ + - ]: 980 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1247 [ + - ]: 980 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1248 [ + - ]: 1960 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1249 [ + - ]: 1960 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1250 : : "including the weight of the outpoint and sequence number. "
1251 : : "Note that signature sizes are not guaranteed to be consistent, "
1252 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1253 : : "Remember to convert serialized sizes to weight units when necessary."},
1254 : : }},
1255 : : },
1256 : : },
1257 [ + - ]: 1960 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1258 [ + - ]: 1960 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1259 [ + - ]: 1960 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1260 : 1960 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1261 : : "The fee will be equally deducted from the amount of each specified output.\n"
1262 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1263 : : "If no outputs are specified here, the sender pays the fee.",
1264 : : {
1265 [ + - ]: 980 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1266 : : },
1267 : : },
1268 [ + - ]: 1960 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1269 : : "Transaction building will fail if this can not be satisfied."},
1270 : : },
1271 [ + - ]: 1960 : FundTxDoc()),
1272 [ + - + - ]: 1960 : RPCArgOptions{.oneline_description="options"}},
1273 : : },
1274 : 0 : RPCResult{
1275 : : RPCResult::Type::OBJ, "", "",
1276 : : {
1277 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1278 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1279 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1280 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1281 : : }
1282 [ + - + - : 5880 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1283 : 980 : RPCExamples{""
1284 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1285 [ + - + - : 2940 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1286 [ + - ]: 1960 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1287 [ + - + - : 4900 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1288 [ + - ]: 1960 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1289 [ + - + - : 4900 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1290 [ + - ]: 1960 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1291 [ + - + - : 4900 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1292 : 980 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1293 [ + - + - : 4900 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1294 [ + - ]: 980 : },
1295 : 206 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1296 : : {
1297 : 206 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1298 [ - + ]: 206 : if (!pwallet) return UniValue::VNULL;
1299 : :
1300 [ + - + + : 206 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1301 [ + - + - : 206 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1302 [ + + ]: 202 : PreventOutdatedOptions(options);
1303 : :
1304 : :
1305 [ + - + + : 402 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1306 : 201 : UniValue outputs(UniValue::VOBJ);
1307 [ + - + - ]: 201 : outputs = NormalizeOutputs(request.params[0]);
1308 : 201 : std::vector<CRecipient> recipients = CreateRecipients(
1309 [ + + ]: 401 : ParseOutputs(outputs),
1310 [ + - + - : 403 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1311 [ + - ]: 200 : );
1312 [ + - + - : 400 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf);
+ - + - +
- + - ]
1313 [ + - ]: 200 : CCoinControl coin_control;
1314 : : // Automatically select coins, unless at least one is manually selected. Can
1315 : : // be overridden by options.add_inputs.
1316 [ + - ]: 200 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1317 [ + - - + ]: 400 : if (options.exists("max_tx_weight")) {
1318 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1319 : : }
1320 [ + - + - : 201 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1321 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1322 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1323 : 199 : rawTx.vout.clear();
1324 [ + + ]: 199 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1325 : :
1326 [ + - + - : 472 : return FinishTransaction(pwallet, options, CMutableTransaction(*txr.tx));
+ - ]
1327 : 689 : }
1328 [ + - + - : 26460 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ - - ]
1329 [ + - + - : 55860 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
1330 : :
1331 : 874 : RPCHelpMan sendall()
1332 : : {
1333 : 874 : return RPCHelpMan{"sendall",
1334 : : "EXPERIMENTAL warning: this call may be changed in future releases.\n"
1335 : : "\nSpend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1336 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1337 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1338 : : {
1339 [ + - ]: 874 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1340 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1341 : : {
1342 [ + - ]: 874 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1343 [ + - ]: 874 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1344 : : {
1345 [ + - ]: 1748 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1346 : : },
1347 : : },
1348 : : },
1349 : : },
1350 [ + - ]: 1748 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1351 [ + - ]: 1748 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1352 [ + - + - ]: 1748 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1353 [ + - ]: 2622 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1354 : : {
1355 [ + - ]: 874 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1356 [ + - + - : 54188 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1357 : : {
1358 [ + - ]: 1748 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
1359 [ + - + - : 4370 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1360 [ + - ]: 1748 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch-only.\n"
1361 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1362 : : "e.g. with 'importdescriptors'."},
1363 : 1748 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1364 : : {
1365 [ + - ]: 874 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1366 : : {
1367 [ + - ]: 874 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1368 [ + - ]: 874 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1369 [ + - ]: 1748 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1370 : : },
1371 : : },
1372 : : },
1373 : : },
1374 [ + - ]: 1748 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1375 [ + - ]: 1748 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1376 [ + - ]: 1748 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1377 [ + - ]: 1748 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
1378 [ + - ]: 1748 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
1379 [ + - ]: 874 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1380 : : },
1381 [ + - ]: 1748 : FundTxDoc()
1382 : : ),
1383 [ + - + - ]: 1748 : RPCArgOptions{.oneline_description="options"}
1384 : : },
1385 : : },
1386 : 0 : RPCResult{
1387 : : RPCResult::Type::OBJ, "", "",
1388 : : {
1389 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1390 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1391 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1392 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1393 : : }
1394 [ + - + - : 5244 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1395 : 874 : RPCExamples{""
1396 [ + - ]: 1748 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1397 [ + - + - : 4370 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1398 [ + - ]: 1748 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1399 [ + - + - : 4370 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1400 [ + - ]: 1748 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1401 [ + - + - : 5244 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1402 [ + - ]: 1748 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1403 [ + - + - : 4370 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1404 [ + - + - ]: 2622 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1405 [ + - + - : 5244 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1406 [ + - ]: 874 : },
1407 : 100 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1408 : : {
1409 : 100 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1410 [ - + ]: 100 : if (!pwallet) return UniValue::VNULL;
1411 : : // Make sure the results are valid at least up to the most recent block
1412 : : // the user could have gotten from another RPC command prior to now
1413 [ + - ]: 100 : pwallet->BlockUntilSyncedToCurrentChain();
1414 : :
1415 [ + - + + : 100 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1416 [ + - + - : 100 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1417 [ + - ]: 100 : PreventOutdatedOptions(options);
1418 : :
1419 : :
1420 : 100 : std::set<std::string> addresses_without_amount;
1421 : 100 : UniValue recipient_key_value_pairs(UniValue::VARR);
1422 [ + - ]: 100 : const UniValue& recipients{request.params[0]};
1423 [ + + ]: 213 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1424 [ + - ]: 113 : const UniValue& recipient{recipients[i]};
1425 [ + + ]: 113 : if (recipient.isStr()) {
1426 : 104 : UniValue rkvp(UniValue::VOBJ);
1427 [ + - + - : 208 : rkvp.pushKV(recipient.get_str(), 0);
+ - + - ]
1428 [ + - ]: 104 : recipient_key_value_pairs.push_back(std::move(rkvp));
1429 [ + - + - ]: 104 : addresses_without_amount.insert(recipient.get_str());
1430 : 104 : } else {
1431 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1432 : : }
1433 : : }
1434 : :
1435 [ + + ]: 100 : if (addresses_without_amount.size() == 0) {
1436 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1437 : : }
1438 : :
1439 [ + - ]: 98 : CCoinControl coin_control;
1440 : :
1441 [ + - + - : 196 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1442 : :
1443 [ + - + - : 98 : coin_control.fAllowWatchOnly = ParseIncludeWatchonly(options["include_watching"], *pwallet);
+ - ]
1444 : :
1445 [ + - + + ]: 196 : if (options.exists("minconf")) {
1446 [ + - + - : 5 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1447 : : {
1448 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1449 : : }
1450 : :
1451 [ + - + - : 4 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1452 : : }
1453 : :
1454 [ + - + + ]: 194 : if (options.exists("maxconf")) {
1455 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1456 : :
1457 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1458 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1459 : : }
1460 : : }
1461 : :
1462 [ + - - + : 194 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1463 : :
1464 : 97 : FeeCalculation fee_calc_out;
1465 [ + - ]: 97 : CFeeRate fee_rate{GetMinimumFeeRate(*pwallet, coin_control, &fee_calc_out)};
1466 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1467 : : // provided one
1468 [ + + + + ]: 97 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1469 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s)", coin_control.m_feerate->ToString(FeeEstimateMode::SAT_VB), fee_rate.ToString(FeeEstimateMode::SAT_VB)));
+ - + - ]
1470 : : }
1471 [ + + + - ]: 96 : if (fee_calc_out.reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1472 : : // eventually allow a fallback fee
1473 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1474 : : }
1475 : :
1476 [ + - + - : 193 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf)};
+ - + - +
+ ]
1477 [ + - ]: 95 : LOCK(pwallet->cs_wallet);
1478 : :
1479 : 95 : CAmount total_input_value(0);
1480 [ + - + + : 190 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1481 [ + - + - : 205 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1482 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1483 [ + - + - : 215 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1484 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1485 [ + - + + ]: 186 : } else if (options.exists("inputs")) {
1486 [ + + ]: 22 : for (const CTxIn& input : rawTx.vin) {
1487 [ + - + + ]: 13 : if (pwallet->IsSpent(input.prevout)) {
1488 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1489 : : }
1490 [ + - ]: 11 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1491 [ + + + + : 19 : if (!tx || input.prevout.n >= tx->tx->vout.size() || !(pwallet->IsMine(tx->tx->vout[input.prevout.n]) & (coin_control.fAllowWatchOnly ? ISMINE_ALL : ISMINE_SPENDABLE))) {
+ - + + +
- ]
1492 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1493 : : }
1494 : 9 : total_input_value += tx->tx->vout[input.prevout.n].nValue;
1495 : : }
1496 : : } else {
1497 : 80 : CoinFilterParams coins_params;
1498 : 80 : coins_params.min_amount = 0;
1499 [ + - + - : 2538 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1500 [ + - ]: 2458 : CHECK_NONFATAL(output.input_bytes > 0);
1501 [ + + + - : 2458 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1502 : 2 : continue;
1503 : : }
1504 [ + + + - ]: 2458 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::SEQUENCE_FINAL);
1505 [ + - ]: 2456 : rawTx.vin.push_back(input);
1506 : 2456 : total_input_value += output.txout.nValue;
1507 : 2536 : }
1508 : : }
1509 : :
1510 : 89 : std::vector<COutPoint> outpoints_spent;
1511 [ + - ]: 89 : outpoints_spent.reserve(rawTx.vin.size());
1512 : :
1513 [ + + ]: 2554 : for (const CTxIn& tx_in : rawTx.vin) {
1514 [ + - ]: 2465 : outpoints_spent.push_back(tx_in.prevout);
1515 : : }
1516 : :
1517 : : // estimate final size of tx
1518 [ + - + - ]: 89 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1519 [ + - ]: 89 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1520 [ + - ]: 89 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1521 [ + - ]: 89 : CAmount effective_value = total_input_value - fee_from_size - total_bump_fees.value_or(0);
1522 : :
1523 [ + + ]: 89 : if (fee_from_size > pwallet->m_default_max_tx_fee) {
1524 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1525 : : }
1526 : :
1527 [ + + ]: 88 : if (effective_value <= 0) {
1528 [ - + ]: 3 : if (send_max) {
1529 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1530 : : } else {
1531 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1532 : : }
1533 : : }
1534 : :
1535 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1536 [ + + ]: 85 : if (tx_size.weight > MAX_STANDARD_TX_WEIGHT) {
1537 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1538 : : }
1539 : :
1540 : 84 : CAmount output_amounts_claimed{0};
1541 [ + + ]: 181 : for (const CTxOut& out : rawTx.vout) {
1542 : 97 : output_amounts_claimed += out.nValue;
1543 : : }
1544 : :
1545 [ + + ]: 84 : if (output_amounts_claimed > total_input_value) {
1546 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1547 : : }
1548 : :
1549 : 83 : const CAmount remainder{effective_value - output_amounts_claimed};
1550 [ + + ]: 83 : if (remainder < 0) {
1551 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1552 : : }
1553 : :
1554 : 82 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1555 : :
1556 : 82 : bool gave_remaining_to_first{false};
1557 [ + + ]: 171 : for (CTxOut& out : rawTx.vout) {
1558 : 92 : CTxDestination dest;
1559 [ + - ]: 92 : ExtractDestination(out.scriptPubKey, dest);
1560 [ + - ]: 92 : std::string addr{EncodeDestination(dest)};
1561 [ + + ]: 92 : if (addresses_without_amount.count(addr) > 0) {
1562 : 86 : out.nValue = per_output_without_amount;
1563 [ + + ]: 86 : if (!gave_remaining_to_first) {
1564 : 81 : out.nValue += remainder % addresses_without_amount.size();
1565 : 81 : gave_remaining_to_first = true;
1566 : : }
1567 [ + - + - : 86 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1568 : : // Dynamically generated output amount is dust
1569 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1570 : : }
1571 : : } else {
1572 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1573 : : // Specified output amount is dust
1574 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", addr));
1575 : : }
1576 : : }
1577 : 95 : }
1578 : :
1579 [ + - + + : 158 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1580 [ + + ]: 79 : if (lock_unspents) {
1581 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1582 [ + - ]: 2 : pwallet->LockCoin(txin.prevout);
1583 : : }
1584 : : }
1585 : :
1586 [ + - + - ]: 237 : return FinishTransaction(pwallet, options, rawTx);
1587 [ + - ]: 403 : }
1588 [ + - + - : 31464 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ - - - -
- - ]
1589 [ + - + - : 41952 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - - -
- - ]
1590 : :
1591 : 1130 : RPCHelpMan walletprocesspsbt()
1592 : : {
1593 : 1130 : return RPCHelpMan{
1594 : : "walletprocesspsbt",
1595 : : "Update a PSBT with input information from our wallet and then sign inputs\n"
1596 : 1130 : "that we can sign for." +
1597 [ + - ]: 1130 : HELP_REQUIRING_PASSPHRASE,
1598 : : {
1599 [ + - ]: 1130 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1600 [ + - ]: 2260 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
1601 [ + - ]: 2260 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
1602 : : " \"DEFAULT\"\n"
1603 : : " \"ALL\"\n"
1604 : : " \"NONE\"\n"
1605 : : " \"SINGLE\"\n"
1606 : : " \"ALL|ANYONECANPAY\"\n"
1607 : : " \"NONE|ANYONECANPAY\"\n"
1608 : : " \"SINGLE|ANYONECANPAY\""},
1609 [ + - ]: 2260 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1610 [ + - ]: 2260 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
1611 : : },
1612 : 0 : RPCResult{
1613 : : RPCResult::Type::OBJ, "", "",
1614 : : {
1615 : : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1616 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1617 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1618 : : }
1619 [ + - + - : 5650 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1620 : 1130 : RPCExamples{
1621 [ + - + - : 2260 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1622 [ + - ]: 1130 : },
1623 : 356 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1624 : : {
1625 [ - + ]: 356 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1626 [ - + ]: 356 : if (!pwallet) return UniValue::VNULL;
1627 : :
1628 [ + - ]: 356 : const CWallet& wallet{*pwallet};
1629 : : // Make sure the results are valid at least up to the most recent block
1630 : : // the user could have gotten from another RPC command prior to now
1631 [ + - ]: 356 : wallet.BlockUntilSyncedToCurrentChain();
1632 : :
1633 : : // Unserialize the transaction
1634 : 356 : PartiallySignedTransaction psbtx;
1635 [ + - ]: 356 : std::string error;
1636 [ + - + - : 356 : if (!DecodeBase64PSBT(psbtx, request.params[0].get_str(), error)) {
+ - + + ]
1637 [ + - + - ]: 4 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", error));
1638 : : }
1639 : :
1640 : : // Get the sighash type
1641 [ + - + + ]: 354 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
1642 : :
1643 : : // Fill transaction with our data and also sign
1644 [ + - + + : 353 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1645 [ + - + + : 353 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1646 [ + - + + : 353 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1647 : 353 : bool complete = true;
1648 : :
1649 [ + + + + ]: 353 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1650 : :
1651 [ + - ]: 352 : const auto err{wallet.FillPSBT(psbtx, complete, nHashType, sign, bip32derivs, nullptr, finalize)};
1652 [ + + ]: 352 : if (err) {
1653 [ + - ]: 7 : throw JSONRPCPSBTError(*err);
1654 : : }
1655 : :
1656 : 345 : UniValue result(UniValue::VOBJ);
1657 : 345 : DataStream ssTx{};
1658 [ + - ]: 345 : ssTx << psbtx;
1659 [ + - + - : 690 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1660 [ + - + - : 690 : result.pushKV("complete", complete);
+ - ]
1661 [ + + ]: 345 : if (complete) {
1662 [ + - ]: 38 : CMutableTransaction mtx;
1663 : : // Returns true if complete, which we already think it is.
1664 [ + - + - ]: 38 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1665 : 38 : DataStream ssTx_final;
1666 [ + - ]: 38 : ssTx_final << TX_WITH_WITNESS(mtx);
1667 [ + - + - : 76 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - ]
1668 : 76 : }
1669 : :
1670 : 345 : return result;
1671 : 701 : },
1672 [ + - + - : 35030 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1673 [ + - + - : 16950 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
1674 : :
1675 : 977 : RPCHelpMan walletcreatefundedpsbt()
1676 : : {
1677 : 977 : return RPCHelpMan{
1678 : : "walletcreatefundedpsbt",
1679 : : "Creates and funds a transaction in the Partially Signed Transaction format.\n"
1680 : : "Implements the Creator and Updater roles.\n"
1681 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1682 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1683 : : {
1684 [ + - ]: 977 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1685 : : {
1686 [ + - ]: 977 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1687 : : {
1688 [ + - ]: 977 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1689 [ + - ]: 977 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1690 [ + - ]: 1954 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
1691 [ + - ]: 1954 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1692 : : "including the weight of the outpoint and sequence number. "
1693 : : "Note that signature sizes are not guaranteed to be consistent, "
1694 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1695 : : "Remember to convert serialized sizes to weight units when necessary."},
1696 : : },
1697 : : },
1698 : : },
1699 : : },
1700 [ + - ]: 977 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1701 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1702 : : "At least one output of either type must be specified.\n"
1703 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1704 : : "accepted as second parameter.",
1705 [ + - ]: 1954 : OutputsDoc(),
1706 [ + - ]: 1954 : RPCArgOptions{.skip_type_check = true}},
1707 [ + - ]: 1954 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1708 [ + - ]: 977 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1709 [ + - + - : 63505 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1710 : : {
1711 [ + - ]: 1954 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
1712 [ + - ]: 1954 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1713 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1714 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1715 [ + - ]: 1954 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1716 [ + - ]: 977 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1717 [ + - ]: 1954 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1718 [ + - ]: 1954 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1719 [ + - ]: 1954 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
1720 [ + - ]: 1954 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only"},
1721 [ + - ]: 1954 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1722 [ + - + - ]: 3908 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1723 [ + - + - ]: 3908 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
1724 : 1954 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1725 : : "The fee will be equally deducted from the amount of each specified output.\n"
1726 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1727 : : "If no outputs are specified here, the sender pays the fee.",
1728 : : {
1729 [ + - ]: 977 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1730 : : },
1731 : : },
1732 [ + - ]: 1954 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1733 : : "Transaction building will fail if this can not be satisfied."},
1734 : : },
1735 [ + - ]: 1954 : FundTxDoc()),
1736 [ + - + - ]: 1954 : RPCArgOptions{.oneline_description="options"}},
1737 [ + - ]: 1954 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1738 : : },
1739 : 0 : RPCResult{
1740 : : RPCResult::Type::OBJ, "", "",
1741 : : {
1742 : : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1743 [ + - ]: 1954 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1744 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1745 : : }
1746 [ + - + - : 6839 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
1747 : 977 : RPCExamples{
1748 : : "\nCreate a PSBT with automatically picked inputs that sends 0.5 BTC to an address and has a fee rate of 2 sat/vB:\n"
1749 [ + - + - : 2931 : + HelpExampleCli("walletcreatefundedpsbt", "\"[]\" \"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" 0 \"{\\\"add_inputs\\\":true,\\\"fee_rate\\\":2}\"")
+ - + - ]
1750 : 977 : + "\nCreate the same PSBT as the above one instead using named arguments:\n"
1751 [ + - + - : 4885 : + HelpExampleCli("-named walletcreatefundedpsbt", "outputs=\"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" add_inputs=true fee_rate=2")
+ - + - ]
1752 [ + - ]: 977 : },
1753 : 203 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1754 : : {
1755 : 203 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1756 [ - + ]: 203 : if (!pwallet) return UniValue::VNULL;
1757 : :
1758 [ + - ]: 203 : CWallet& wallet{*pwallet};
1759 : : // Make sure the results are valid at least up to the most recent block
1760 : : // the user could have gotten from another RPC command prior to now
1761 [ + - ]: 203 : wallet.BlockUntilSyncedToCurrentChain();
1762 : :
1763 [ + - + + : 203 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1764 : :
1765 [ + - + - ]: 203 : const UniValue &replaceable_arg = options["replaceable"];
1766 [ + + + - ]: 203 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1767 [ + - + - : 203 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf);
+ - + - ]
1768 : 203 : UniValue outputs(UniValue::VOBJ);
1769 [ + - + - ]: 203 : outputs = NormalizeOutputs(request.params[1]);
1770 : 203 : std::vector<CRecipient> recipients = CreateRecipients(
1771 [ + - ]: 406 : ParseOutputs(outputs),
1772 [ + - + - : 406 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1773 [ + - ]: 203 : );
1774 [ + - ]: 203 : CCoinControl coin_control;
1775 : : // Automatically select coins, unless at least one is manually selected. Can
1776 : : // be overridden by options.add_inputs.
1777 [ + - ]: 203 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1778 [ + - + + ]: 203 : SetOptionsInputWeights(request.params[0], options);
1779 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1780 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1781 : 202 : rawTx.vout.clear();
1782 [ + + ]: 202 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1783 : :
1784 : : // Make a blank psbt
1785 [ + - + - ]: 134 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx));
1786 : :
1787 : : // Fill transaction with out data but don't sign
1788 [ + - + + : 134 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1789 : 134 : bool complete = true;
1790 [ + - ]: 134 : const auto err{wallet.FillPSBT(psbtx, complete, std::nullopt, /*sign=*/false, /*bip32derivs=*/bip32derivs)};
1791 [ - + ]: 134 : if (err) {
1792 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1793 : : }
1794 : :
1795 : : // Serialize the PSBT
1796 : 134 : DataStream ssTx{};
1797 [ + - ]: 134 : ssTx << psbtx;
1798 : :
1799 : 134 : UniValue result(UniValue::VOBJ);
1800 [ + - + - : 268 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1801 [ + - + - : 268 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1802 [ + + + - : 268 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1803 : 134 : return result;
1804 [ + - ]: 812 : },
1805 [ + - + - : 42988 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1806 [ + - + - : 49827 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1807 : : } // namespace wallet
|
