Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <rpc/rawtransaction_util.h>
12 : : #include <rpc/util.h>
13 : : #include <script/script.h>
14 : : #include <util/rbf.h>
15 : : #include <util/translation.h>
16 : : #include <util/vector.h>
17 : : #include <wallet/coincontrol.h>
18 : : #include <wallet/feebumper.h>
19 : : #include <wallet/fees.h>
20 : : #include <wallet/rpc/util.h>
21 : : #include <wallet/spend.h>
22 : : #include <wallet/wallet.h>
23 : :
24 : : #include <univalue.h>
25 : :
26 : : using common::FeeModeFromString;
27 : : using common::FeeModesDetail;
28 : : using common::InvalidEstimateModeErrorMessage;
29 : : using common::StringForFeeReason;
30 : : using common::TransactionErrorString;
31 : : using node::TransactionError;
32 : :
33 : : namespace wallet {
34 : 1822 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
35 : : {
36 : 1822 : std::vector<CRecipient> recipients;
37 [ + + ]: 23512 : for (size_t i = 0; i < outputs.size(); ++i) {
38 [ + - + - ]: 21690 : const auto& [destination, amount] = outputs.at(i);
39 [ + - ]: 43380 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
40 [ + - ]: 21690 : recipients.push_back(recipient);
41 : 21690 : }
42 : 1822 : return recipients;
43 : 0 : }
44 : :
45 : 308 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
46 : : {
47 [ + - + - : 901 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
48 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
49 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
50 : : }
51 : : } else {
52 [ + - + - ]: 568 : options.pushKV("conf_target", conf_target);
53 [ + - + - ]: 568 : options.pushKV("estimate_mode", estimate_mode);
54 : : }
55 [ + + ]: 610 : if (options.exists("fee_rate")) {
56 [ + + ]: 26 : if (!fee_rate.isNull()) {
57 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
58 : : }
59 : : } else {
60 [ + - + - ]: 558 : options.pushKV("fee_rate", fee_rate);
61 : : }
62 [ + - + - : 666 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
63 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
64 : : }
65 : 304 : }
66 : :
67 : 651 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
68 : : {
69 [ + + ]: 651 : std::set<int> sffo_set;
70 [ + + ]: 651 : if (sffo_instructions.isNull()) return sffo_set;
71 : :
72 [ + - + + ]: 194 : for (const auto& sffo : sffo_instructions.getValues()) {
73 : 102 : int pos{-1};
74 [ + + ]: 102 : if (sffo.isStr()) {
75 [ + - + + ]: 9 : auto it = find(destinations.begin(), destinations.end(), sffo.get_str());
76 [ + + + - : 10 : if (it == destinations.end()) throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', destination %s not found in tx outputs", sffo.get_str()));
+ - + - ]
77 : 8 : pos = it - destinations.begin();
78 [ + + ]: 93 : } else if (sffo.isNum()) {
79 [ + - ]: 92 : pos = sffo.getInt<int>();
80 : : } else {
81 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', invalid value type: %s", uvTypeName(sffo.type())));
+ - ]
82 : : }
83 : :
84 [ + + ]: 100 : if (sffo_set.contains(pos))
85 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', duplicated position: %d", pos));
86 [ + + ]: 98 : if (pos < 0)
87 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', negative position: %d", pos));
88 [ + + ]: 97 : if (pos >= int(destinations.size()))
89 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', position too large: %d", pos));
90 [ + - ]: 96 : sffo_set.insert(pos);
91 : : }
92 : : return sffo_set;
93 : 6 : }
94 : :
95 : 199 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, const CMutableTransaction& rawTx)
96 : : {
97 : : // Make a blank psbt
98 : 199 : PartiallySignedTransaction psbtx(rawTx);
99 : :
100 : : // First fill transaction with our data without signing,
101 : : // so external signers are not asked to sign more than once.
102 : 199 : bool complete;
103 [ + - ]: 199 : pwallet->FillPSBT(psbtx, complete, std::nullopt, /*sign=*/false, /*bip32derivs=*/true);
104 [ + - ]: 199 : const auto err{pwallet->FillPSBT(psbtx, complete, std::nullopt, /*sign=*/true, /*bip32derivs=*/false)};
105 [ + + ]: 199 : if (err) {
106 [ + - ]: 1 : throw JSONRPCPSBTError(*err);
107 : : }
108 : :
109 [ + - ]: 198 : CMutableTransaction mtx;
110 [ + - ]: 198 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
111 : :
112 : 198 : UniValue result(UniValue::VOBJ);
113 : :
114 [ + - + - : 219 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
115 [ + - + + : 396 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
116 [ + + + + : 198 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
117 : : // Serialize the PSBT
118 : 52 : DataStream ssTx{};
119 [ + - ]: 52 : ssTx << psbtx;
120 [ + - + - : 104 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
121 : 52 : }
122 : :
123 [ + + ]: 198 : if (complete) {
124 [ + - + - ]: 172 : std::string hex{EncodeHexTx(CTransaction(mtx))};
125 [ + - ]: 172 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
126 [ + - + - : 344 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
127 [ + + ]: 172 : if (add_to_wallet && !psbt_opt_in) {
128 [ + - + - ]: 438 : pwallet->CommitTransaction(tx, {}, /*orderForm=*/{});
129 : : } else {
130 [ + - + - : 52 : result.pushKV("hex", hex);
+ - ]
131 : : }
132 : 172 : }
133 [ + - + - : 396 : result.pushKV("complete", complete);
+ - ]
134 : :
135 : 396 : return result;
136 : 199 : }
137 : :
138 : 304 : static void PreventOutdatedOptions(const UniValue& options)
139 : : {
140 [ + + ]: 608 : if (options.exists("feeRate")) {
141 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
142 : : }
143 [ - + ]: 606 : if (options.exists("changeAddress")) {
144 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
145 : : }
146 [ - + ]: 606 : if (options.exists("changePosition")) {
147 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
148 : : }
149 [ - + ]: 606 : if (options.exists("lockUnspents")) {
150 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
151 : : }
152 [ - + ]: 606 : if (options.exists("subtractFeeFromOutputs")) {
153 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
154 : : }
155 : 303 : }
156 : :
157 : 1229 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, mapValue_t map_value, bool verbose)
158 : : {
159 : 1229 : EnsureWalletIsUnlocked(wallet);
160 : :
161 : : // This function is only used by sendtoaddress and sendmany.
162 : : // This should always try to sign, if we don't have private keys, don't try to do anything here.
163 [ - + ]: 1229 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
164 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
165 : : }
166 : :
167 : : // Shuffle recipient list
168 : 1229 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
169 : :
170 : : // Send
171 : 1229 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
172 [ + + ]: 1229 : if (!res) {
173 [ + - + - ]: 32 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
174 : : }
175 : 1213 : const CTransactionRef& tx = res->tx;
176 [ + - + - ]: 3639 : wallet.CommitTransaction(tx, std::move(map_value), /*orderForm=*/{});
177 [ + + ]: 1213 : if (verbose) {
178 : 2 : UniValue entry(UniValue::VOBJ);
179 [ + - + - : 4 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
180 [ + - + - : 4 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_calc.reason));
+ - + - ]
181 : 2 : return entry;
182 : 0 : }
183 [ + - + - ]: 1211 : return tx->GetHash().GetHex();
184 : 1213 : }
185 : :
186 : :
187 : : /**
188 : : * Update coin control with fee estimation based on the given parameters
189 : : *
190 : : * @param[in] wallet Wallet reference
191 : : * @param[in,out] cc Coin control to be updated
192 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
193 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
194 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
195 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
196 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
197 : : * verify only that fee_rate is greater than 0
198 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
199 : : */
200 : 1901 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
201 : : {
202 [ + + ]: 1901 : if (!fee_rate.isNull()) {
203 [ + + ]: 389 : if (!conf_target.isNull()) {
204 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
205 : : }
206 [ + + + + ]: 386 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
207 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
208 : : }
209 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
210 [ - + ]: 383 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
211 [ + + ]: 307 : if (override_min_fee) cc.fOverrideFeeRate = true;
212 : : // Default RBF to true for explicit fee_rate, if unset.
213 [ + + ]: 307 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
214 : 307 : return;
215 : : }
216 [ + + + + ]: 1512 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
217 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
218 : : }
219 [ + + ]: 1485 : if (!conf_target.isNull()) {
220 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().estimateMaxBlocks());
221 : : }
222 : : }
223 : :
224 : 1965 : RPCHelpMan sendtoaddress()
225 : : {
226 : 1965 : return RPCHelpMan{
227 : : "sendtoaddress",
228 : 1965 : "Send an amount to a given address." +
229 [ + - ]: 1965 : HELP_REQUIRING_PASSPHRASE,
230 : : {
231 [ + - ]: 1965 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
232 [ + - ]: 3930 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
233 [ + - ]: 1965 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
234 : : "This is not part of the transaction, just kept in your wallet."},
235 [ + - ]: 1965 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
236 : : "to which you're sending the transaction. This is not part of the \n"
237 : : "transaction, just kept in your wallet."},
238 [ + - ]: 3930 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
239 : : "The recipient will receive less bitcoins than you enter in the amount field."},
240 [ + - ]: 3930 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
241 [ + - ]: 3930 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
242 [ + - ]: 3930 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
243 [ + - + - ]: 3930 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
244 [ + - ]: 3930 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
245 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
246 [ + - ]: 5895 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
247 [ + - ]: 3930 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
248 : : },
249 : : {
250 : : RPCResult{"if verbose is not set or set to false",
251 : : RPCResult::Type::STR_HEX, "txid", "The transaction id."
252 [ + - + - : 3930 : },
+ - + - ]
253 : : RPCResult{"if verbose is set to true",
254 : : RPCResult::Type::OBJ, "", "",
255 : : {
256 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
257 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
258 : : },
259 [ + - + - : 7860 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
260 : : },
261 : 1965 : RPCExamples{
262 : : "\nSend 0.1 BTC\n"
263 [ + - + - : 5895 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
264 : 1965 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
265 [ + - + - : 9825 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
266 [ + - ]: 3930 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
267 [ + - + - : 9825 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
268 : 1965 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
269 [ + - + - : 9825 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
270 [ + - ]: 3930 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
271 [ + - + - : 9825 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
272 [ + - + - : 7860 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
273 [ + - ]: 1965 : },
274 : 1181 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
275 : : {
276 : 1181 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
277 [ - + ]: 1181 : if (!pwallet) return UniValue::VNULL;
278 : :
279 : : // Make sure the results are valid at least up to the most recent block
280 : : // the user could have gotten from another RPC command prior to now
281 [ + - ]: 1181 : pwallet->BlockUntilSyncedToCurrentChain();
282 : :
283 [ + - ]: 1181 : LOCK(pwallet->cs_wallet);
284 : :
285 : : // Wallet comments
286 [ + - ]: 1181 : mapValue_t mapValue;
287 [ + - + + : 1181 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
288 [ + - + - : 2 : mapValue["comment"] = request.params[2].get_str();
+ - + - +
- ]
289 [ + - + + : 1181 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
290 [ + - + - : 2 : mapValue["to"] = request.params[3].get_str();
+ - + - +
- ]
291 : :
292 [ + - ]: 1181 : CCoinControl coin_control;
293 [ + - + + ]: 1181 : if (!request.params[5].isNull()) {
294 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
295 : : }
296 : :
297 [ + - + - ]: 1181 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
298 : : // We also enable partial spend avoidance if reuse avoidance is set.
299 : 1181 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
300 : :
301 [ + - + - : 1181 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
302 : :
303 [ + + ]: 1181 : EnsureWalletIsUnlocked(*pwallet);
304 : :
305 : 1180 : UniValue address_amounts(UniValue::VOBJ);
306 [ + - + - : 1180 : const std::string address = request.params[0].get_str();
+ - ]
307 [ + - + - : 2360 : address_amounts.pushKV(address, request.params[1]);
+ - + - ]
308 : :
309 [ + - ]: 1180 : std::set<int> sffo_set;
310 [ + - + + : 1180 : if (!request.params[4].isNull() && request.params[4].get_bool()) {
+ - + - +
+ ]
311 [ + - ]: 216 : sffo_set.insert(0);
312 : : }
313 : :
314 [ + + + - ]: 1180 : std::vector<CRecipient> recipients{CreateRecipients(ParseOutputs(address_amounts), sffo_set)};
315 [ + - + + : 1178 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
316 : :
317 [ + - + + ]: 1182 : return SendMoney(*pwallet, coin_control, recipients, mapValue, verbose);
318 [ + - ]: 3559 : },
319 [ + - + - : 113970 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
320 [ + - + - : 55020 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- ]
321 : :
322 : 864 : RPCHelpMan sendmany()
323 : : {
324 : 864 : return RPCHelpMan{"sendmany",
325 : 864 : "Send multiple times. Amounts are double-precision floating point numbers." +
326 [ + - ]: 864 : HELP_REQUIRING_PASSPHRASE,
327 : : {
328 [ + - ]: 1728 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
329 [ + - + - ]: 1728 : RPCArgOptions{
330 : : .oneline_description = "\"\"",
331 : : }},
332 [ + - ]: 864 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
333 : : {
334 [ + - ]: 1728 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
335 : : },
336 : : },
337 [ + - ]: 864 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value"},
338 [ + - ]: 864 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
339 [ + - ]: 864 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
340 : : "The fee will be equally deducted from the amount of each selected address.\n"
341 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
342 : : "If no addresses are specified here, the sender pays the fee.",
343 : : {
344 [ + - ]: 864 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
345 : : },
346 : : },
347 [ + - ]: 1728 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
348 [ + - ]: 1728 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
349 [ + - ]: 1728 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
350 [ + - + - ]: 1728 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
351 [ + - ]: 2592 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
352 [ + - ]: 1728 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
353 : : },
354 : : {
355 : : RPCResult{"if verbose is not set or set to false",
356 : : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
357 : : "the number of addresses."
358 [ + - + - : 1728 : },
+ - + - ]
359 : : RPCResult{"if verbose is set to true",
360 : : RPCResult::Type::OBJ, "", "",
361 : : {
362 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
363 : : "the number of addresses."},
364 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
365 : : },
366 [ + - + - : 3456 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
367 : : },
368 : 864 : RPCExamples{
369 : : "\nSend two amounts to two different addresses:\n"
370 [ + - + - : 3456 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
371 : 864 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
372 [ + - + - : 5184 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
373 : 864 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
374 [ + - + - : 6912 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
375 : 864 : "\nAs a JSON-RPC call\n"
376 [ + - + - : 4320 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
377 [ + - ]: 864 : },
378 : 80 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
379 : : {
380 : 80 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
381 [ - + ]: 80 : if (!pwallet) return UniValue::VNULL;
382 : :
383 : : // Make sure the results are valid at least up to the most recent block
384 : : // the user could have gotten from another RPC command prior to now
385 [ + - ]: 80 : pwallet->BlockUntilSyncedToCurrentChain();
386 : :
387 [ + - ]: 80 : LOCK(pwallet->cs_wallet);
388 : :
389 [ + - + + : 80 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
390 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
391 : : }
392 [ + - + - : 80 : UniValue sendTo = request.params[1].get_obj();
+ - ]
393 : :
394 [ + - ]: 80 : mapValue_t mapValue;
395 [ + - + + : 80 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
396 [ # # # # : 0 : mapValue["comment"] = request.params[3].get_str();
# # # # #
# ]
397 : :
398 [ + - ]: 80 : CCoinControl coin_control;
399 [ + - - + ]: 80 : if (!request.params[5].isNull()) {
400 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
401 : : }
402 : :
403 [ + - + - : 80 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
404 : :
405 : 57 : std::vector<CRecipient> recipients = CreateRecipients(
406 [ + - ]: 102 : ParseOutputs(sendTo),
407 [ + - + - : 57 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ + ]
408 [ + - ]: 51 : );
409 [ + - + + : 51 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
410 : :
411 [ + + ]: 63 : return SendMoney(*pwallet, coin_control, recipients, std::move(mapValue), verbose);
412 [ + - ]: 252 : },
413 [ + - + - : 50976 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
414 [ + - + - : 25056 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
415 : :
416 : 803 : RPCHelpMan settxfee()
417 : : {
418 : 803 : return RPCHelpMan{
419 : : "settxfee",
420 [ + - ]: 1606 : "(DEPRECATED) Set the transaction fee rate in " + CURRENCY_UNIT + "/kvB for this wallet. Overrides the global -paytxfee command line parameter.\n"
421 : 803 : "Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.\n",
422 : : {
423 [ + - ]: 1606 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The transaction fee rate in " + CURRENCY_UNIT + "/kvB"},
424 : : },
425 : 0 : RPCResult{
426 : : RPCResult::Type::BOOL, "", "Returns true if successful"
427 [ + - + - : 1606 : },
+ - ]
428 : 803 : RPCExamples{
429 [ + - + - : 1606 : HelpExampleCli("settxfee", "0.00001")
+ - ]
430 [ + - + - : 3212 : + HelpExampleRpc("settxfee", "0.00001")
+ - + - ]
431 [ + - ]: 803 : },
432 : 19 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
433 : : {
434 : 19 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
435 [ - + ]: 19 : if (!pwallet) return UniValue::VNULL;
436 : :
437 [ + - ]: 19 : LOCK(pwallet->cs_wallet);
438 : :
439 [ + - + - : 19 : if (!pwallet->chain().rpcEnableDeprecated("settxfee")) {
+ + ]
440 [ + - ]: 1 : throw JSONRPCError(RPC_METHOD_DEPRECATED, "settxfee is deprecated and will be fully removed in v31.0."
441 [ + - + - ]: 2 : "\nTo use settxfee restart bitcoind with -deprecatedrpc=settxfee.");
442 : : }
443 : :
444 [ + - + - ]: 18 : CAmount nAmount = AmountFromValue(request.params[0]);
445 [ + - ]: 18 : CFeeRate tx_fee_rate(nAmount, 1000);
446 [ + - ]: 18 : CFeeRate max_tx_fee_rate(pwallet->m_default_max_tx_fee, 1000);
447 [ + + ]: 18 : if (tx_fee_rate == CFeeRate(0)) {
448 : : // automatic selection
449 [ + - + + ]: 16 : } else if (tx_fee_rate < pwallet->chain().relayMinFee()) {
450 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than min relay tx fee (%s)", pwallet->chain().relayMinFee().ToString()));
+ - + - ]
451 [ + + ]: 15 : } else if (tx_fee_rate < pwallet->m_min_fee) {
452 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than wallet min fee (%s)", pwallet->m_min_fee.ToString()));
+ - ]
453 [ + + ]: 14 : } else if (tx_fee_rate > max_tx_fee_rate) {
454 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be more than wallet max tx fee (%s)", max_tx_fee_rate.ToString()));
+ - ]
455 : : }
456 : :
457 [ + - ]: 15 : pwallet->m_pay_tx_fee = tx_fee_rate;
458 [ + - ]: 15 : return true;
459 : 34 : },
460 [ + - + - : 8833 : };
+ - + - +
- + + -
- ]
461 [ + - + - ]: 2409 : }
462 : :
463 : :
464 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
465 : 3835 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
466 : : {
467 : 3835 : std::vector<RPCArg> args = {
468 [ + - + - ]: 15340 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
469 [ + - ]: 7670 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
470 [ + - + - : 7670 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - ]
471 : : {
472 [ + - ]: 7670 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
473 : : "Allows this transaction to be replaced by a transaction with higher fees"
474 : : },
475 [ + - + - : 61360 : };
+ - + - +
- + - + -
+ + - - ]
476 [ + - ]: 3835 : if (solving_data) {
477 [ + - + - : 103545 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + + +
+ + - - -
- - - -
- ]
478 : : "Used for fee estimation during coin selection.",
479 : : {
480 : : {
481 : 7670 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
482 : : {
483 [ + - ]: 3835 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
484 : : }
485 : : },
486 : : {
487 : 7670 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
488 : : {
489 [ + - ]: 3835 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
490 : : }
491 : : },
492 : : {
493 : 7670 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
494 : : {
495 [ + - ]: 3835 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
496 : : }
497 : : },
498 : : }
499 : : });
500 : : }
501 : 3835 : return args;
502 [ + - + - : 72865 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - ]
503 : :
504 : 591 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
505 : : {
506 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
507 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
508 : 591 : CHECK_NONFATAL(tx.vout.empty());
509 : : // Make sure the results are valid at least up to the most recent block
510 : : // the user could have gotten from another RPC command prior to now
511 : 591 : wallet.BlockUntilSyncedToCurrentChain();
512 : :
513 : 591 : std::optional<unsigned int> change_position;
514 : 591 : bool lockUnspents = false;
515 [ + + ]: 591 : if (!options.isNull()) {
516 [ + + ]: 533 : if (options.type() == UniValue::VBOOL) {
517 : : // backward compatibility bool only fallback, does nothing
518 : : } else {
519 [ + + + + : 15451 : RPCTypeCheckObj(options,
+ + ]
520 : : {
521 [ + - ]: 532 : {"add_inputs", UniValueType(UniValue::VBOOL)},
522 [ + - ]: 532 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
523 [ + - ]: 532 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
524 [ + - ]: 532 : {"changeAddress", UniValueType(UniValue::VSTR)},
525 [ + - ]: 532 : {"change_address", UniValueType(UniValue::VSTR)},
526 [ + - ]: 532 : {"changePosition", UniValueType(UniValue::VNUM)},
527 [ + - ]: 532 : {"change_position", UniValueType(UniValue::VNUM)},
528 [ + - ]: 532 : {"change_type", UniValueType(UniValue::VSTR)},
529 [ + - ]: 532 : {"includeWatching", UniValueType(UniValue::VBOOL)},
530 [ + - ]: 532 : {"include_watching", UniValueType(UniValue::VBOOL)},
531 [ + - ]: 532 : {"inputs", UniValueType(UniValue::VARR)},
532 [ + - ]: 532 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
533 [ + - ]: 532 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
534 [ + - ]: 532 : {"locktime", UniValueType(UniValue::VNUM)},
535 [ + - ]: 532 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
536 [ + - ]: 532 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
537 [ + - ]: 532 : {"psbt", UniValueType(UniValue::VBOOL)},
538 [ + - ]: 532 : {"solving_data", UniValueType(UniValue::VOBJ)},
539 [ + - ]: 532 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
540 [ + - ]: 532 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
541 [ + - ]: 532 : {"replaceable", UniValueType(UniValue::VBOOL)},
542 [ + - ]: 532 : {"conf_target", UniValueType(UniValue::VNUM)},
543 [ + - ]: 532 : {"estimate_mode", UniValueType(UniValue::VSTR)},
544 [ + - ]: 532 : {"minconf", UniValueType(UniValue::VNUM)},
545 [ + - ]: 532 : {"maxconf", UniValueType(UniValue::VNUM)},
546 [ + - ]: 532 : {"input_weights", UniValueType(UniValue::VARR)},
547 [ + - ]: 532 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
548 : : },
549 : : true, true);
550 : :
551 [ + + ]: 1018 : if (options.exists("add_inputs")) {
552 [ + - + - ]: 171 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
553 : : }
554 : :
555 [ + - + - : 1518 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
556 [ + + + - : 39 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - + -
+ + + + -
- - - ]
557 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
558 : :
559 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
560 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
561 : : }
562 : :
563 [ + - ]: 22 : coinControl.destChange = dest;
564 : 15 : }
565 : :
566 [ + - + - : 1517 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
567 [ + + + - : 111 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
568 [ + - + + ]: 37 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
569 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
570 : : }
571 : 36 : change_position = (unsigned int)pos;
572 : : }
573 : :
574 [ + + ]: 1012 : if (options.exists("change_type")) {
575 [ + - + - : 227 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
576 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
577 : : }
578 [ + - + + : 150 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
+ - + + ]
579 [ - + ]: 146 : coinControl.m_change_type.emplace(parsed.value());
580 : : } else {
581 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
582 : : }
583 : : }
584 : :
585 [ + - + - : 1506 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
586 [ + + + - : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + +
+ + - - -
- ]
587 : : }
588 : :
589 [ + + ]: 1006 : if (options.exists("include_unsafe")) {
590 [ + - + - ]: 5 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
591 : : }
592 : :
593 [ + + ]: 1006 : if (options.exists("feeRate")) {
594 [ + + ]: 116 : if (options.exists("fee_rate")) {
595 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
596 : : }
597 [ + + ]: 112 : if (options.exists("conf_target")) {
598 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
599 : : }
600 [ + + ]: 108 : if (options.exists("estimate_mode")) {
601 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
602 : : }
603 [ + - + + : 104 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
- + ]
604 : 36 : coinControl.fOverrideFeeRate = true;
605 : : }
606 : :
607 [ + + ]: 962 : if (options.exists("replaceable")) {
608 [ + - + - ]: 7 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
609 : : }
610 : :
611 [ + + ]: 962 : if (options.exists("minconf")) {
612 [ + - + - ]: 8 : coinControl.m_min_depth = options["minconf"].getInt<int>();
613 : :
614 [ + + ]: 8 : if (coinControl.m_min_depth < 0) {
615 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
616 : : }
617 : : }
618 : :
619 [ + + ]: 960 : if (options.exists("maxconf")) {
620 [ + - + - ]: 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
621 : :
622 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
623 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
624 : : }
625 : : }
626 [ + - + - : 1154 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + + ]
627 : : }
628 : : }
629 : :
630 [ + + ]: 884 : if (options.exists("solving_data")) {
631 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
632 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
633 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
634 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
635 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
636 : : // Add witness script for pubkeys
637 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
638 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
639 : 3 : }
640 : : }
641 : :
642 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
643 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
644 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
645 [ + - + + ]: 6 : if (!IsHex(script_str)) {
646 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
647 : : }
648 [ + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
649 : 5 : const CScript script(script_data.begin(), script_data.end());
650 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
651 : 5 : }
652 : : }
653 : :
654 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
655 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
656 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
657 : 8 : FlatSigningProvider desc_out;
658 [ + - ]: 8 : std::string error;
659 : 8 : std::vector<CScript> scripts_temp;
660 [ + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
661 [ + + ]: 8 : if (descs.empty()) {
662 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
663 : : }
664 [ + + ]: 14 : for (auto& desc : descs) {
665 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
666 : : }
667 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
668 : 10 : }
669 : : }
670 : 14 : }
671 : :
672 [ + + ]: 876 : if (options.exists("input_weights")) {
673 [ + - + - : 2595 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
674 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
675 : :
676 : 2491 : const UniValue& vout_v = input.find_value("vout");
677 [ + + ]: 2491 : if (!vout_v.isNum()) {
678 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
679 : : }
680 : 2490 : int vout = vout_v.getInt<int>();
681 [ + + ]: 2490 : if (vout < 0) {
682 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
683 : : }
684 : :
685 : 2489 : const UniValue& weight_v = input.find_value("weight");
686 [ + + ]: 2489 : if (!weight_v.isNum()) {
687 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
688 : : }
689 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
690 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
691 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
692 [ + + ]: 2488 : if (weight < min_input_weight) {
693 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
694 : : }
695 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
696 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
697 : : }
698 : :
699 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
700 : : }
701 : : }
702 : :
703 [ + + ]: 864 : if (options.exists("max_tx_weight")) {
704 [ + - + - ]: 8 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
705 : : }
706 : :
707 [ - + ]: 432 : if (recipients.empty())
708 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
709 : :
710 [ + - ]: 432 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
711 [ + + ]: 432 : if (!txr) {
712 [ + - + - ]: 138 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
713 : : }
714 : 363 : return *txr;
715 [ + - + - : 918 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
716 : :
717 : 405 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
718 : : {
719 [ + + ]: 810 : if (options.exists("input_weights")) {
720 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
721 : : }
722 [ + + ]: 403 : if (inputs.size() == 0) {
723 : : return;
724 : : }
725 : 140 : UniValue weights(UniValue::VARR);
726 [ + - + + ]: 2895 : for (const UniValue& input : inputs.getValues()) {
727 [ + - + + ]: 5510 : if (input.exists("weight")) {
728 [ + - + - ]: 6 : weights.push_back(input);
729 : : }
730 : : }
731 [ + - + - ]: 280 : options.pushKV("input_weights", std::move(weights));
732 : 140 : }
733 : :
734 : 972 : RPCHelpMan fundrawtransaction()
735 : : {
736 : 972 : return RPCHelpMan{
737 : : "fundrawtransaction",
738 : : "If the transaction has no inputs, they will be automatically selected to meet its out value.\n"
739 : : "It will add at most one change output to the outputs.\n"
740 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
741 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
742 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
743 : : "or signrawtransactionwithwallet for that.\n"
744 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
745 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
746 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
747 : : "in the wallet using importdescriptors (to calculate fees).\n"
748 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
749 : : "Note that if specifying an exact fee rate, the resulting transaction may have a higher fee rate\n"
750 : : "if the transaction has unconfirmed inputs. This is because the wallet will attempt to make the\n"
751 : : "entire package have the given fee rate, not the resulting transaction.\n",
752 : : {
753 [ + - ]: 972 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
754 [ + - ]: 972 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
755 [ + - + - : 77760 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
756 : : {
757 [ + - ]: 1944 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
758 [ + - ]: 1944 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
759 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
760 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
761 [ + - ]: 1944 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
762 [ + - ]: 972 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
763 [ + - ]: 1944 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
764 [ + - ]: 1944 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
765 [ + - ]: 1944 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
766 [ + - ]: 1944 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
767 [ + - ]: 1944 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
768 [ + - + - ]: 3888 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
769 [ + - + - ]: 3888 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
770 : 1944 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
771 : : "The fee will be equally deducted from the amount of each specified output.\n"
772 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
773 : : "If no outputs are specified here, the sender pays the fee.",
774 : : {
775 [ + - ]: 972 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
776 : : },
777 : : },
778 [ + - ]: 972 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
779 : : {
780 [ + - ]: 972 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
781 : : {
782 [ + - ]: 972 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
783 [ + - ]: 972 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
784 [ + - ]: 972 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
785 : : "including the weight of the outpoint and sequence number. "
786 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
787 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
788 : : "Remember to convert serialized sizes to weight units when necessary."},
789 : : },
790 : : },
791 : : },
792 : : },
793 [ + - ]: 1944 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
794 : : "Transaction building will fail if this can not be satisfied."},
795 : : },
796 [ + - ]: 1944 : FundTxDoc()),
797 [ + - + - ]: 1944 : RPCArgOptions{
798 : : .skip_type_check = true,
799 : : .oneline_description = "options",
800 : : }},
801 [ + - ]: 1944 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
802 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
803 : : "If true, only witness deserialization will be tried.\n"
804 : : "If false, only non-witness deserialization will be tried.\n"
805 : : "This boolean should reflect whether the transaction has inputs\n"
806 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
807 : : },
808 : : },
809 : 0 : RPCResult{
810 : : RPCResult::Type::OBJ, "", "",
811 : : {
812 : : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
813 [ + - ]: 1944 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
814 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
815 : : }
816 [ + - + - : 6804 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
817 : 972 : RPCExamples{
818 : : "\nCreate a transaction with no inputs\n"
819 [ + - + - : 1944 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
820 : 972 : "\nAdd sufficient unsigned inputs to meet the output value\n"
821 [ + - + - : 3888 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
822 : 972 : "\nSign the transaction\n"
823 [ + - + - : 3888 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
824 : 972 : "\nSend the transaction\n"
825 [ + - + - : 3888 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
826 [ + - ]: 972 : },
827 : 188 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
828 : : {
829 : 188 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
830 [ - + ]: 188 : if (!pwallet) return UniValue::VNULL;
831 : :
832 : : // parse hex string from parameter
833 [ + - ]: 188 : CMutableTransaction tx;
834 [ + - - + : 188 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
835 [ + - - + : 188 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
836 [ + - + - : 188 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
837 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
838 : : }
839 [ + - + - ]: 188 : UniValue options = request.params[1];
840 : 188 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
841 [ + + ]: 11990 : for (const auto& tx_out : tx.vout) {
842 : 11802 : CTxDestination dest;
843 [ + - ]: 11802 : ExtractDestination(tx_out.scriptPubKey, dest);
844 [ + - ]: 11802 : destinations.emplace_back(dest, tx_out.nValue);
845 : 11802 : }
846 [ + - + - ]: 188 : std::vector<std::string> dummy(destinations.size(), "dummy");
847 [ + - ]: 188 : std::vector<CRecipient> recipients = CreateRecipients(
848 : : destinations,
849 [ + - + - : 376 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
850 [ + - ]: 188 : );
851 [ + - ]: 188 : CCoinControl coin_control;
852 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
853 : 188 : coin_control.m_allow_other_inputs = true;
854 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
855 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
856 : 188 : tx.vout.clear();
857 [ + + ]: 188 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
858 : :
859 : 109 : UniValue result(UniValue::VOBJ);
860 [ + - + - : 218 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
861 [ + - + - : 218 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
862 [ + + + - : 218 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
863 : :
864 : 109 : return result;
865 [ + - ]: 910 : },
866 [ + - + - : 16524 : };
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
867 [ + - + - : 46656 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
868 : :
869 : 1078 : RPCHelpMan signrawtransactionwithwallet()
870 : : {
871 : 1078 : return RPCHelpMan{
872 : : "signrawtransactionwithwallet",
873 : : "Sign inputs for raw transaction (serialized, hex-encoded).\n"
874 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
875 : 1078 : "this transaction depends on but may not yet be in the block chain." +
876 [ + - ]: 1078 : HELP_REQUIRING_PASSPHRASE,
877 : : {
878 [ + - ]: 1078 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
879 [ + - ]: 1078 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
880 : : {
881 [ + - ]: 1078 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
882 : : {
883 [ + - ]: 1078 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
884 [ + - ]: 1078 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
885 [ + - ]: 1078 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
886 [ + - ]: 1078 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
887 [ + - ]: 1078 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
888 [ + - ]: 1078 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
889 : : },
890 : : },
891 : : },
892 : : },
893 [ + - ]: 2156 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
894 : : " \"DEFAULT\"\n"
895 : : " \"ALL\"\n"
896 : : " \"NONE\"\n"
897 : : " \"SINGLE\"\n"
898 : : " \"ALL|ANYONECANPAY\"\n"
899 : : " \"NONE|ANYONECANPAY\"\n"
900 : : " \"SINGLE|ANYONECANPAY\""},
901 : : },
902 : 0 : RPCResult{
903 : : RPCResult::Type::OBJ, "", "",
904 : : {
905 : : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
906 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
907 : : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
908 : : {
909 : : {RPCResult::Type::OBJ, "", "",
910 : : {
911 : : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
912 : : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
913 : : {RPCResult::Type::ARR, "witness", "",
914 : : {
915 : : {RPCResult::Type::STR_HEX, "witness", ""},
916 : : }},
917 : : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
918 : : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
919 : : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
920 : : }},
921 : : }},
922 : : }
923 [ + - + - : 17248 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
924 : 1078 : RPCExamples{
925 [ + - + - : 2156 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
926 [ + - + - : 4312 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
927 [ + - ]: 1078 : },
928 : 294 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
929 : : {
930 [ - + ]: 294 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
931 [ - + ]: 294 : if (!pwallet) return UniValue::VNULL;
932 : :
933 [ + - ]: 294 : CMutableTransaction mtx;
934 [ + - + - : 294 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
935 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
936 : : }
937 : :
938 : : // Sign the transaction
939 [ + - ]: 294 : LOCK(pwallet->cs_wallet);
940 [ + + ]: 294 : EnsureWalletIsUnlocked(*pwallet);
941 : :
942 : : // Fetch previous transactions (inputs):
943 : 293 : std::map<COutPoint, Coin> coins;
944 [ + + ]: 1042 : for (const CTxIn& txin : mtx.vin) {
945 [ + - ]: 749 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
946 : : }
947 [ + - ]: 293 : pwallet->chain().findCoins(coins);
948 : :
949 : : // Parse the prevtxs array
950 [ + - + + ]: 293 : ParsePrevouts(request.params[1], nullptr, coins);
951 : :
952 [ + - + + ]: 284 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
953 [ + + ]: 283 : if (!nHashType) {
954 : 280 : nHashType = SIGHASH_DEFAULT;
955 : : }
956 : :
957 : : // Script verification errors
958 [ + - ]: 283 : std::map<int, bilingual_str> input_errors;
959 : :
960 [ + - ]: 283 : bool complete = pwallet->SignTransaction(mtx, coins, *nHashType, input_errors);
961 : 283 : UniValue result(UniValue::VOBJ);
962 [ + + ]: 283 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
963 : 281 : return result;
964 [ + - ]: 1166 : },
965 [ + - + - : 43120 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - ]
966 [ + - + - : 35574 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
967 : :
968 : : // Definition of allowed formats of specifying transaction outputs in
969 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
970 : 3706 : static std::vector<RPCArg> OutputsDoc()
971 : : {
972 : 3706 : return
973 : : {
974 [ + - ]: 3706 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
975 : : {
976 [ + - ]: 3706 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
977 : 3706 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
978 : : },
979 : : },
980 [ + - ]: 3706 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
981 : : {
982 [ + - ]: 3706 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data that becomes a part of an OP_RETURN output"},
983 : : },
984 : : },
985 [ + - + - : 51884 : };
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
986 [ + - + - : 33354 : }
+ - + - +
- - - ]
987 : :
988 : 1727 : static RPCHelpMan bumpfee_helper(std::string method_name)
989 : : {
990 : 1727 : const bool want_psbt = method_name == "psbtbumpfee";
991 : 1727 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeEstimateMode::SAT_VB)};
992 : :
993 : 1727 : return RPCHelpMan{method_name,
994 : : "Bumps the fee of a transaction T, replacing it with a new transaction B.\n"
995 [ + + + - : 4390 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
+ - ]
996 : : "A transaction with the given txid must be in the wallet.\n"
997 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
998 : : "It may add a new change output if one does not already exist.\n"
999 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
1000 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
1001 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
1002 : : "The user can specify a confirmation target for estimatesmartfee.\n"
1003 [ + - ]: 3454 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
1004 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
1005 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
1006 [ + - + - ]: 5181 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
1007 : : {
1008 [ + - ]: 1727 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
1009 [ + - ]: 1727 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1010 : : {
1011 [ + - ]: 3454 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
1012 [ + - ]: 3454 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
1013 : 1727 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
1014 [ + - ]: 3454 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
1015 [ + - + - ]: 5181 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
1016 [ + - ]: 3454 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true},
1017 : : "Whether the new transaction should be\n"
1018 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
1019 : : "be set to 0xfffffffd. If false, any input sequence numbers in the\n"
1020 : : "transaction will be set to 0xfffffffe\n"
1021 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
1022 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
1023 : : "are replaceable).\n"},
1024 [ + - ]: 3454 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1025 [ + - + - ]: 3454 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1026 : 3454 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1027 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1028 : : "At least one output of either type must be specified.\n"
1029 : : "Cannot be provided if 'original_change_index' is specified.",
1030 [ + - ]: 3454 : OutputsDoc(),
1031 [ + - ]: 3454 : RPCArgOptions{.skip_type_check = true}},
1032 [ + - ]: 3454 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
1033 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1034 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1035 : : "original change output. The change output’s amount can increase if bumping the transaction "
1036 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1037 : : },
1038 [ + - + - ]: 1727 : RPCArgOptions{.oneline_description="options"}},
1039 : : },
1040 : 0 : RPCResult{
1041 [ + - + - : 15543 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1042 [ + + + - : 8635 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1043 [ + - + - : 4891 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ - + - +
+ + + + +
- - - - -
- ]
1044 [ + - + - : 5471 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ - + - +
+ + + + +
- - - - -
- ]
1045 : : {
1046 : : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1047 : : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1048 : : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1049 : : {
1050 : : {RPCResult::Type::STR, "", ""},
1051 : : }},
1052 : : })
1053 [ + - + - : 5181 : },
+ - ]
1054 : 1727 : RPCExamples{
1055 [ + + + - : 4390 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1056 [ + - + - : 5181 : HelpExampleCli(method_name, "<txid>")
+ - ]
1057 : 1727 : },
1058 [ + - ]: 1727 : [want_psbt](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1059 : : {
1060 : 159 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1061 [ - + ]: 159 : if (!pwallet) return UniValue::VNULL;
1062 : :
1063 [ + - + + : 159 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1064 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1065 : : }
1066 : :
1067 [ + - + - ]: 158 : Txid hash{Txid::FromUint256(ParseHashV(request.params[0], "txid"))};
1068 : :
1069 [ + - ]: 158 : CCoinControl coin_control;
1070 : : // optional parameters
1071 [ + - ]: 158 : coin_control.m_signal_bip125_rbf = true;
1072 : 158 : std::vector<CTxOut> outputs;
1073 : :
1074 : 158 : std::optional<uint32_t> original_change_index;
1075 : :
1076 [ + - + + ]: 158 : if (!request.params[1].isNull()) {
1077 [ + - + - ]: 67 : UniValue options = request.params[1];
1078 [ + + + + : 607 : RPCTypeCheckObj(options,
+ + ]
1079 : : {
1080 [ + - ]: 67 : {"confTarget", UniValueType(UniValue::VNUM)},
1081 [ + - ]: 67 : {"conf_target", UniValueType(UniValue::VNUM)},
1082 [ + - ]: 67 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1083 [ + - ]: 67 : {"replaceable", UniValueType(UniValue::VBOOL)},
1084 [ + - ]: 67 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1085 [ + - ]: 67 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1086 [ + - ]: 67 : {"original_change_index", UniValueType(UniValue::VNUM)},
1087 : : },
1088 : : true, true);
1089 : :
1090 [ + - + - : 127 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1091 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1092 : : }
1093 : :
1094 [ + - - + : 186 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1095 : :
1096 [ + - + + ]: 124 : if (options.exists("replaceable")) {
1097 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1098 : : }
1099 [ + - + - : 143 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1100 : :
1101 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1102 [ + - + - : 43 : if (!options["outputs"].isNull()) {
+ + ]
1103 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- + + + +
- - ]
1104 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1105 : : }
1106 [ + - ]: 10 : CMutableTransaction tempTx;
1107 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1108 [ + - ]: 8 : outputs = tempTx.vout;
1109 : 10 : }
1110 : :
1111 [ + - + + ]: 80 : if (options.exists("original_change_index")) {
1112 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1113 : : }
1114 : 90 : }
1115 : :
1116 : : // Make sure the results are valid at least up to the most recent block
1117 : : // the user could have gotten from another RPC command prior to now
1118 [ + - ]: 130 : pwallet->BlockUntilSyncedToCurrentChain();
1119 : :
1120 [ + - ]: 130 : LOCK(pwallet->cs_wallet);
1121 : :
1122 [ + + ]: 130 : EnsureWalletIsUnlocked(*pwallet);
1123 : :
1124 : :
1125 : 129 : std::vector<bilingual_str> errors;
1126 : 129 : CAmount old_fee;
1127 : 129 : CAmount new_fee;
1128 [ + - ]: 129 : CMutableTransaction mtx;
1129 : 129 : feebumper::Result res;
1130 : : // Targeting feerate bump.
1131 [ + - ]: 129 : res = feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index);
1132 [ + + ]: 129 : if (res != feebumper::Result::OK) {
1133 [ - - + + : 23 : switch(res) {
+ ]
1134 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1135 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1136 : 0 : break;
1137 : 0 : case feebumper::Result::INVALID_REQUEST:
1138 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1139 : 16 : break;
1140 : 16 : case feebumper::Result::INVALID_PARAMETER:
1141 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1142 : 6 : break;
1143 : 6 : case feebumper::Result::WALLET_ERROR:
1144 [ + - ]: 6 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1145 : 1 : break;
1146 : 1 : default:
1147 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1148 : 106 : break;
1149 : : }
1150 : : }
1151 : :
1152 : 212 : UniValue result(UniValue::VOBJ);
1153 : :
1154 : : // For bumpfee, return the new transaction id.
1155 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1156 [ + + ]: 106 : if (!want_psbt) {
1157 [ + - - + ]: 99 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1158 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1159 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1160 : : }
1161 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1162 : : }
1163 : :
1164 [ + - ]: 99 : Txid txid;
1165 [ + - - + ]: 99 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1166 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1167 : : }
1168 : :
1169 [ + - + - : 198 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1170 : : } else {
1171 [ + - ]: 7 : PartiallySignedTransaction psbtx(mtx);
1172 : 7 : bool complete = false;
1173 [ + - ]: 7 : const auto err{pwallet->FillPSBT(psbtx, complete, std::nullopt, /*sign=*/false, /*bip32derivs=*/true)};
1174 [ + - ]: 7 : CHECK_NONFATAL(!err);
1175 [ + - ]: 7 : CHECK_NONFATAL(!complete);
1176 : 7 : DataStream ssTx{};
1177 [ + - ]: 7 : ssTx << psbtx;
1178 [ + - + - : 14 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1179 : 7 : }
1180 : :
1181 [ + - + - : 212 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1182 [ + - + - : 212 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1183 : 212 : UniValue result_errors(UniValue::VARR);
1184 [ - + ]: 106 : for (const bilingual_str& error : errors) {
1185 [ # # # # ]: 0 : result_errors.push_back(error.original);
1186 : : }
1187 [ + - + - ]: 212 : result.pushKV("errors", std::move(result_errors));
1188 : :
1189 : 106 : return result;
1190 [ + - + - : 516 : },
+ - + - +
- + - + -
+ - + - -
+ ]
1191 [ + - + - : 75988 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
1192 [ + - + - : 39721 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
1193 : :
1194 [ + - ]: 1872 : RPCHelpMan bumpfee() { return bumpfee_helper("bumpfee"); }
1195 [ + - ]: 1582 : RPCHelpMan psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1196 : :
1197 : 992 : RPCHelpMan send()
1198 : : {
1199 : 992 : return RPCHelpMan{
1200 : : "send",
1201 : : "EXPERIMENTAL warning: this call may be changed in future releases.\n"
1202 : : "\nSend a transaction.\n",
1203 : : {
1204 [ + - ]: 992 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1205 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1206 : : "At least one output of either type must be specified.\n"
1207 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1208 [ + - ]: 1984 : OutputsDoc(),
1209 [ + - ]: 1984 : RPCArgOptions{.skip_type_check = true}},
1210 [ + - ]: 1984 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1211 [ + - ]: 1984 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1212 [ + - + - ]: 1984 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1213 [ + - ]: 2976 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1214 [ + - ]: 992 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1215 [ + - + - : 99200 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + +
+ + + + +
- - - - -
- - - ]
1216 : : {
1217 [ + - ]: 1984 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
1218 [ + - ]: 1984 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1219 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1220 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1221 [ + - ]: 1984 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1222 [ + - ]: 992 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1223 [ + - ]: 1984 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
1224 [ + - ]: 1984 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1225 [ + - ]: 1984 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1226 [ + - ]: 1984 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\" and \"bech32m\"."},
1227 [ + - + - : 4960 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1228 [ + - ]: 1984 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{"false"}, "(DEPRECATED) No longer used"},
1229 : 1984 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
1230 : : {
1231 [ + - ]: 992 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
1232 [ + - ]: 992 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1233 [ + - ]: 992 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1234 [ + - ]: 1984 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1235 [ + - ]: 1984 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1236 : : "including the weight of the outpoint and sequence number. "
1237 : : "Note that signature sizes are not guaranteed to be consistent, "
1238 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1239 : : "Remember to convert serialized sizes to weight units when necessary."},
1240 : : }},
1241 : : },
1242 : : },
1243 [ + - ]: 1984 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1244 [ + - ]: 1984 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1245 [ + - ]: 1984 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1246 : 1984 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1247 : : "The fee will be equally deducted from the amount of each specified output.\n"
1248 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1249 : : "If no outputs are specified here, the sender pays the fee.",
1250 : : {
1251 [ + - ]: 992 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1252 : : },
1253 : : },
1254 [ + - ]: 1984 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1255 : : "Transaction building will fail if this can not be satisfied."},
1256 : : },
1257 [ + - ]: 1984 : FundTxDoc()),
1258 [ + - + - ]: 1984 : RPCArgOptions{.oneline_description="options"}},
1259 : : },
1260 : 0 : RPCResult{
1261 : : RPCResult::Type::OBJ, "", "",
1262 : : {
1263 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1264 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1265 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1266 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1267 : : }
1268 [ + - + - : 5952 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1269 : 992 : RPCExamples{""
1270 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1271 [ + - + - : 2976 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1272 [ + - ]: 1984 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1273 [ + - + - : 4960 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1274 [ + - ]: 1984 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1275 [ + - + - : 4960 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1276 [ + - ]: 1984 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1277 [ + - + - : 4960 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1278 : 992 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1279 [ + - + - : 4960 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1280 [ + - ]: 992 : },
1281 : 208 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1282 : : {
1283 : 208 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1284 [ - + ]: 208 : if (!pwallet) return UniValue::VNULL;
1285 : :
1286 [ + - + + : 208 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1287 [ + - + - : 208 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1288 [ + + ]: 204 : PreventOutdatedOptions(options);
1289 : :
1290 : :
1291 [ + - + + : 406 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1292 : 203 : UniValue outputs(UniValue::VOBJ);
1293 [ + - + - ]: 203 : outputs = NormalizeOutputs(request.params[0]);
1294 : 203 : std::vector<CRecipient> recipients = CreateRecipients(
1295 [ + + ]: 405 : ParseOutputs(outputs),
1296 [ + - + - : 407 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1297 [ + - ]: 202 : );
1298 [ + - + - : 404 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf);
+ - + - +
- + - ]
1299 [ + - ]: 202 : CCoinControl coin_control;
1300 : : // Automatically select coins, unless at least one is manually selected. Can
1301 : : // be overridden by options.add_inputs.
1302 [ + - ]: 202 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1303 [ + - - + ]: 404 : if (options.exists("max_tx_weight")) {
1304 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1305 : : }
1306 [ + - + - : 203 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1307 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1308 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1309 : 201 : rawTx.vout.clear();
1310 [ + + ]: 201 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1311 : :
1312 [ + - + + : 480 : return FinishTransaction(pwallet, options, CMutableTransaction(*txr.tx));
+ - ]
1313 : 696 : }
1314 [ + - + - : 26784 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ - - ]
1315 [ + - + - : 56544 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
1316 : :
1317 : 884 : RPCHelpMan sendall()
1318 : : {
1319 : 884 : return RPCHelpMan{"sendall",
1320 : : "EXPERIMENTAL warning: this call may be changed in future releases.\n"
1321 : : "\nSpend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1322 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1323 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1324 : : {
1325 [ + - ]: 884 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1326 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1327 : : {
1328 [ + - ]: 884 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1329 [ + - ]: 884 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1330 : : {
1331 [ + - ]: 1768 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1332 : : },
1333 : : },
1334 : : },
1335 : : },
1336 [ + - ]: 1768 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1337 [ + - ]: 1768 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1338 [ + - + - ]: 1768 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1339 [ + - ]: 2652 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1340 : : {
1341 [ + - ]: 884 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1342 [ + - + - : 54808 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1343 : : {
1344 [ + - ]: 1768 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
1345 [ + - + - : 4420 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1346 [ + - ]: 1768 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
1347 : 1768 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1348 : : {
1349 [ + - ]: 884 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1350 : : {
1351 [ + - ]: 884 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1352 [ + - ]: 884 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1353 [ + - ]: 1768 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1354 : : },
1355 : : },
1356 : : },
1357 : : },
1358 [ + - ]: 1768 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1359 [ + - ]: 1768 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1360 [ + - ]: 1768 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1361 [ + - ]: 1768 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
1362 [ + - ]: 1768 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
1363 [ + - ]: 884 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1364 : : },
1365 [ + - ]: 1768 : FundTxDoc()
1366 : : ),
1367 [ + - + - ]: 1768 : RPCArgOptions{.oneline_description="options"}
1368 : : },
1369 : : },
1370 : 0 : RPCResult{
1371 : : RPCResult::Type::OBJ, "", "",
1372 : : {
1373 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1374 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1375 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1376 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1377 : : }
1378 [ + - + - : 5304 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1379 : 884 : RPCExamples{""
1380 [ + - ]: 1768 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1381 [ + - + - : 4420 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1382 [ + - ]: 1768 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1383 [ + - + - : 4420 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1384 [ + - ]: 1768 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1385 [ + - + - : 5304 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1386 [ + - ]: 1768 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1387 [ + - + - : 4420 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1388 [ + - + - ]: 2652 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1389 [ + - + - : 5304 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1390 [ + - ]: 884 : },
1391 : 100 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1392 : : {
1393 : 100 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1394 [ - + ]: 100 : if (!pwallet) return UniValue::VNULL;
1395 : : // Make sure the results are valid at least up to the most recent block
1396 : : // the user could have gotten from another RPC command prior to now
1397 [ + - ]: 100 : pwallet->BlockUntilSyncedToCurrentChain();
1398 : :
1399 [ + - + + : 100 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1400 [ + - + - : 100 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1401 [ + - ]: 100 : PreventOutdatedOptions(options);
1402 : :
1403 : :
1404 : 100 : std::set<std::string> addresses_without_amount;
1405 : 100 : UniValue recipient_key_value_pairs(UniValue::VARR);
1406 [ + - ]: 100 : const UniValue& recipients{request.params[0]};
1407 [ + + ]: 213 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1408 [ + - ]: 113 : const UniValue& recipient{recipients[i]};
1409 [ + + ]: 113 : if (recipient.isStr()) {
1410 : 104 : UniValue rkvp(UniValue::VOBJ);
1411 [ + - + - : 208 : rkvp.pushKV(recipient.get_str(), 0);
+ - + - ]
1412 [ + - ]: 104 : recipient_key_value_pairs.push_back(std::move(rkvp));
1413 [ + - + - ]: 104 : addresses_without_amount.insert(recipient.get_str());
1414 : 104 : } else {
1415 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1416 : : }
1417 : : }
1418 : :
1419 [ + + ]: 100 : if (addresses_without_amount.size() == 0) {
1420 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1421 : : }
1422 : :
1423 [ + - ]: 98 : CCoinControl coin_control;
1424 : :
1425 [ + - + - : 196 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1426 : :
1427 [ + - + + ]: 196 : if (options.exists("minconf")) {
1428 [ + - + - : 5 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1429 : : {
1430 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1431 : : }
1432 : :
1433 [ + - + - : 4 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1434 : : }
1435 : :
1436 [ + - + + ]: 194 : if (options.exists("maxconf")) {
1437 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1438 : :
1439 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1440 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1441 : : }
1442 : : }
1443 : :
1444 [ + - - + : 194 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1445 : :
1446 : 97 : FeeCalculation fee_calc_out;
1447 [ + - ]: 97 : CFeeRate fee_rate{GetMinimumFeeRate(*pwallet, coin_control, &fee_calc_out)};
1448 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1449 : : // provided one
1450 [ + + + + ]: 97 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1451 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s)", coin_control.m_feerate->ToString(FeeEstimateMode::SAT_VB), fee_rate.ToString(FeeEstimateMode::SAT_VB)));
+ - + - ]
1452 : : }
1453 [ + + + - ]: 96 : if (fee_calc_out.reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1454 : : // eventually allow a fallback fee
1455 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1456 : : }
1457 : :
1458 [ + - + - : 193 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf)};
+ - + - +
+ ]
1459 [ + - ]: 95 : LOCK(pwallet->cs_wallet);
1460 : :
1461 : 95 : CAmount total_input_value(0);
1462 [ + - + + : 190 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1463 [ + - + - : 205 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1464 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1465 [ + - + - : 215 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1466 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1467 [ + - + + ]: 186 : } else if (options.exists("inputs")) {
1468 [ + + ]: 22 : for (const CTxIn& input : rawTx.vin) {
1469 [ + - + + ]: 13 : if (pwallet->IsSpent(input.prevout)) {
1470 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1471 : : }
1472 [ + - ]: 11 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1473 [ + + + + : 11 : if (!tx || input.prevout.n >= tx->tx->vout.size() || !(pwallet->IsMine(tx->tx->vout[input.prevout.n]) & ISMINE_SPENDABLE)) {
+ - + - ]
1474 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1475 : : }
1476 : 9 : total_input_value += tx->tx->vout[input.prevout.n].nValue;
1477 : : }
1478 : : } else {
1479 : 80 : CoinFilterParams coins_params;
1480 : 80 : coins_params.min_amount = 0;
1481 [ + - + - : 2540 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1482 [ + - ]: 2460 : CHECK_NONFATAL(output.input_bytes > 0);
1483 [ + + + - : 2460 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1484 : 2 : continue;
1485 : : }
1486 [ + + + - ]: 2460 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::SEQUENCE_FINAL);
1487 [ + - ]: 2458 : rawTx.vin.push_back(input);
1488 : 2458 : total_input_value += output.txout.nValue;
1489 : 2538 : }
1490 : : }
1491 : :
1492 : 89 : std::vector<COutPoint> outpoints_spent;
1493 [ + - ]: 89 : outpoints_spent.reserve(rawTx.vin.size());
1494 : :
1495 [ + + ]: 2556 : for (const CTxIn& tx_in : rawTx.vin) {
1496 [ + - ]: 2467 : outpoints_spent.push_back(tx_in.prevout);
1497 : : }
1498 : :
1499 : : // estimate final size of tx
1500 [ + - + - ]: 89 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1501 [ + - ]: 89 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1502 [ + - ]: 89 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1503 [ + - ]: 89 : CAmount effective_value = total_input_value - fee_from_size - total_bump_fees.value_or(0);
1504 : :
1505 [ + + ]: 89 : if (fee_from_size > pwallet->m_default_max_tx_fee) {
1506 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1507 : : }
1508 : :
1509 [ + + ]: 88 : if (effective_value <= 0) {
1510 [ - + ]: 3 : if (send_max) {
1511 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1512 : : } else {
1513 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1514 : : }
1515 : : }
1516 : :
1517 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1518 [ + + ]: 85 : if (tx_size.weight > MAX_STANDARD_TX_WEIGHT) {
1519 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1520 : : }
1521 : :
1522 : 84 : CAmount output_amounts_claimed{0};
1523 [ + + ]: 181 : for (const CTxOut& out : rawTx.vout) {
1524 : 97 : output_amounts_claimed += out.nValue;
1525 : : }
1526 : :
1527 [ + + ]: 84 : if (output_amounts_claimed > total_input_value) {
1528 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1529 : : }
1530 : :
1531 : 83 : const CAmount remainder{effective_value - output_amounts_claimed};
1532 [ + + ]: 83 : if (remainder < 0) {
1533 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1534 : : }
1535 : :
1536 : 82 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1537 : :
1538 : 82 : bool gave_remaining_to_first{false};
1539 [ + + ]: 171 : for (CTxOut& out : rawTx.vout) {
1540 : 92 : CTxDestination dest;
1541 [ + - ]: 92 : ExtractDestination(out.scriptPubKey, dest);
1542 [ + - ]: 92 : std::string addr{EncodeDestination(dest)};
1543 [ + + ]: 92 : if (addresses_without_amount.count(addr) > 0) {
1544 : 86 : out.nValue = per_output_without_amount;
1545 [ + + ]: 86 : if (!gave_remaining_to_first) {
1546 : 81 : out.nValue += remainder % addresses_without_amount.size();
1547 : 81 : gave_remaining_to_first = true;
1548 : : }
1549 [ + - + - : 86 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1550 : : // Dynamically generated output amount is dust
1551 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1552 : : }
1553 : : } else {
1554 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1555 : : // Specified output amount is dust
1556 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", addr));
1557 : : }
1558 : : }
1559 : 95 : }
1560 : :
1561 [ + - + + : 158 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1562 [ + + ]: 79 : if (lock_unspents) {
1563 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1564 [ + - ]: 2 : pwallet->LockCoin(txin.prevout);
1565 : : }
1566 : : }
1567 : :
1568 [ + - + - ]: 237 : return FinishTransaction(pwallet, options, rawTx);
1569 [ + - ]: 403 : }
1570 [ + - + - : 31824 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ - - - -
- - ]
1571 [ + - + - : 42432 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - - -
- - ]
1572 : :
1573 : 1141 : RPCHelpMan walletprocesspsbt()
1574 : : {
1575 : 1141 : return RPCHelpMan{
1576 : : "walletprocesspsbt",
1577 : : "Update a PSBT with input information from our wallet and then sign inputs\n"
1578 : 1141 : "that we can sign for." +
1579 [ + - ]: 1141 : HELP_REQUIRING_PASSPHRASE,
1580 : : {
1581 [ + - ]: 1141 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1582 [ + - ]: 2282 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
1583 [ + - ]: 2282 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
1584 : : " \"DEFAULT\"\n"
1585 : : " \"ALL\"\n"
1586 : : " \"NONE\"\n"
1587 : : " \"SINGLE\"\n"
1588 : : " \"ALL|ANYONECANPAY\"\n"
1589 : : " \"NONE|ANYONECANPAY\"\n"
1590 : : " \"SINGLE|ANYONECANPAY\""},
1591 [ + - ]: 2282 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1592 [ + - ]: 2282 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
1593 : : },
1594 : 0 : RPCResult{
1595 : : RPCResult::Type::OBJ, "", "",
1596 : : {
1597 : : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1598 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1599 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1600 : : }
1601 [ + - + - : 5705 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1602 : 1141 : RPCExamples{
1603 [ + - + - : 2282 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1604 [ + - ]: 1141 : },
1605 : 357 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1606 : : {
1607 [ - + ]: 357 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1608 [ - + ]: 357 : if (!pwallet) return UniValue::VNULL;
1609 : :
1610 [ + - ]: 357 : const CWallet& wallet{*pwallet};
1611 : : // Make sure the results are valid at least up to the most recent block
1612 : : // the user could have gotten from another RPC command prior to now
1613 [ + - ]: 357 : wallet.BlockUntilSyncedToCurrentChain();
1614 : :
1615 : : // Unserialize the transaction
1616 : 357 : PartiallySignedTransaction psbtx;
1617 [ + - ]: 357 : std::string error;
1618 [ + - + - : 357 : if (!DecodeBase64PSBT(psbtx, request.params[0].get_str(), error)) {
+ - + + ]
1619 [ + - + - ]: 4 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", error));
1620 : : }
1621 : :
1622 : : // Get the sighash type
1623 [ + - + + ]: 355 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
1624 : :
1625 : : // Fill transaction with our data and also sign
1626 [ + - + + : 354 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1627 [ + - + + : 354 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1628 [ + - + + : 354 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1629 : 354 : bool complete = true;
1630 : :
1631 [ + + + + ]: 354 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1632 : :
1633 [ + - ]: 353 : const auto err{wallet.FillPSBT(psbtx, complete, nHashType, sign, bip32derivs, nullptr, finalize)};
1634 [ + + ]: 353 : if (err) {
1635 [ + - ]: 7 : throw JSONRPCPSBTError(*err);
1636 : : }
1637 : :
1638 : 346 : UniValue result(UniValue::VOBJ);
1639 : 346 : DataStream ssTx{};
1640 [ + - ]: 346 : ssTx << psbtx;
1641 [ + - + - : 692 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1642 [ + - + - : 692 : result.pushKV("complete", complete);
+ - ]
1643 [ + + ]: 346 : if (complete) {
1644 [ + - ]: 39 : CMutableTransaction mtx;
1645 : : // Returns true if complete, which we already think it is.
1646 [ + - + - ]: 39 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1647 : 39 : DataStream ssTx_final;
1648 [ + - ]: 39 : ssTx_final << TX_WITH_WITNESS(mtx);
1649 [ + - + - : 78 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - ]
1650 : 78 : }
1651 : :
1652 : 346 : return result;
1653 : 703 : },
1654 [ + - + - : 35371 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1655 [ + - + - : 17115 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
1656 : :
1657 : 987 : RPCHelpMan walletcreatefundedpsbt()
1658 : : {
1659 : 987 : return RPCHelpMan{
1660 : : "walletcreatefundedpsbt",
1661 : : "Creates and funds a transaction in the Partially Signed Transaction format.\n"
1662 : : "Implements the Creator and Updater roles.\n"
1663 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1664 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1665 : : {
1666 [ + - ]: 987 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1667 : : {
1668 [ + - ]: 987 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1669 : : {
1670 [ + - ]: 987 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1671 [ + - ]: 987 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1672 [ + - ]: 1974 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
1673 [ + - ]: 1974 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1674 : : "including the weight of the outpoint and sequence number. "
1675 : : "Note that signature sizes are not guaranteed to be consistent, "
1676 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1677 : : "Remember to convert serialized sizes to weight units when necessary."},
1678 : : },
1679 : : },
1680 : : },
1681 : : },
1682 [ + - ]: 987 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1683 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1684 : : "At least one output of either type must be specified.\n"
1685 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1686 : : "accepted as second parameter.",
1687 [ + - ]: 1974 : OutputsDoc(),
1688 [ + - ]: 1974 : RPCArgOptions{.skip_type_check = true}},
1689 [ + - ]: 1974 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1690 [ + - ]: 987 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1691 [ + - + - : 64155 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1692 : : {
1693 [ + - ]: 1974 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
1694 [ + - ]: 1974 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1695 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1696 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1697 [ + - ]: 1974 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1698 [ + - ]: 987 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1699 [ + - ]: 1974 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1700 [ + - ]: 1974 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1701 [ + - ]: 1974 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
1702 [ + - ]: 1974 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
1703 [ + - ]: 1974 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1704 [ + - + - ]: 3948 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1705 [ + - + - ]: 3948 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
1706 : 1974 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1707 : : "The fee will be equally deducted from the amount of each specified output.\n"
1708 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1709 : : "If no outputs are specified here, the sender pays the fee.",
1710 : : {
1711 [ + - ]: 987 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1712 : : },
1713 : : },
1714 [ + - ]: 1974 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1715 : : "Transaction building will fail if this can not be satisfied."},
1716 : : },
1717 [ + - ]: 1974 : FundTxDoc()),
1718 [ + - + - ]: 1974 : RPCArgOptions{.oneline_description="options"}},
1719 [ + - ]: 1974 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1720 : : },
1721 : 0 : RPCResult{
1722 : : RPCResult::Type::OBJ, "", "",
1723 : : {
1724 : : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1725 [ + - ]: 1974 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1726 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1727 : : }
1728 [ + - + - : 6909 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
1729 : 987 : RPCExamples{
1730 : : "\nCreate a PSBT with automatically picked inputs that sends 0.5 BTC to an address and has a fee rate of 2 sat/vB:\n"
1731 [ + - + - : 2961 : + HelpExampleCli("walletcreatefundedpsbt", "\"[]\" \"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" 0 \"{\\\"add_inputs\\\":true,\\\"fee_rate\\\":2}\"")
+ - + - ]
1732 : 987 : + "\nCreate the same PSBT as the above one instead using named arguments:\n"
1733 [ + - + - : 4935 : + HelpExampleCli("-named walletcreatefundedpsbt", "outputs=\"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" add_inputs=true fee_rate=2")
+ - + - ]
1734 [ + - ]: 987 : },
1735 : 203 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1736 : : {
1737 : 203 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1738 [ - + ]: 203 : if (!pwallet) return UniValue::VNULL;
1739 : :
1740 [ + - ]: 203 : CWallet& wallet{*pwallet};
1741 : : // Make sure the results are valid at least up to the most recent block
1742 : : // the user could have gotten from another RPC command prior to now
1743 [ + - ]: 203 : wallet.BlockUntilSyncedToCurrentChain();
1744 : :
1745 [ + - + + : 203 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1746 : :
1747 [ + - + - ]: 203 : const UniValue &replaceable_arg = options["replaceable"];
1748 [ + + + - ]: 203 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1749 [ + - + - : 203 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf);
+ - + - ]
1750 : 203 : UniValue outputs(UniValue::VOBJ);
1751 [ + - + - ]: 203 : outputs = NormalizeOutputs(request.params[1]);
1752 : 203 : std::vector<CRecipient> recipients = CreateRecipients(
1753 [ + - ]: 406 : ParseOutputs(outputs),
1754 [ + - + - : 406 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1755 [ + - ]: 203 : );
1756 [ + - ]: 203 : CCoinControl coin_control;
1757 : : // Automatically select coins, unless at least one is manually selected. Can
1758 : : // be overridden by options.add_inputs.
1759 [ + - ]: 203 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1760 [ + - + + ]: 203 : SetOptionsInputWeights(request.params[0], options);
1761 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1762 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1763 : 202 : rawTx.vout.clear();
1764 [ + + ]: 202 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1765 : :
1766 : : // Make a blank psbt
1767 [ + - + - ]: 134 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx));
1768 : :
1769 : : // Fill transaction with out data but don't sign
1770 [ + - + + : 134 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1771 : 134 : bool complete = true;
1772 [ + - ]: 134 : const auto err{wallet.FillPSBT(psbtx, complete, std::nullopt, /*sign=*/false, /*bip32derivs=*/bip32derivs)};
1773 [ - + ]: 134 : if (err) {
1774 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1775 : : }
1776 : :
1777 : : // Serialize the PSBT
1778 : 134 : DataStream ssTx{};
1779 [ + - ]: 134 : ssTx << psbtx;
1780 : :
1781 : 134 : UniValue result(UniValue::VOBJ);
1782 [ + - + - : 268 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1783 [ + - + - : 268 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1784 [ + + + - : 268 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1785 : 134 : return result;
1786 [ + - ]: 812 : },
1787 [ + - + - : 43428 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1788 [ + - + - : 50337 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1789 : : } // namespace wallet
|
