Branch data Line data Source code
1 : : // Copyright (c) 2011-present The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <policy/truc_policy.h>
12 : : #include <rpc/rawtransaction_util.h>
13 : : #include <rpc/util.h>
14 : : #include <script/script.h>
15 : : #include <util/rbf.h>
16 : : #include <util/translation.h>
17 : : #include <util/vector.h>
18 : : #include <wallet/coincontrol.h>
19 : : #include <wallet/feebumper.h>
20 : : #include <wallet/fees.h>
21 : : #include <wallet/rpc/util.h>
22 : : #include <wallet/spend.h>
23 : : #include <wallet/wallet.h>
24 : :
25 : : #include <univalue.h>
26 : :
27 : : using common::FeeModeFromString;
28 : : using common::FeeModesDetail;
29 : : using common::FeeReasons;
30 : : using common::InvalidEstimateModeErrorMessage;
31 : : using common::StringForFeeReason;
32 : : using common::TransactionErrorString;
33 : : using node::TransactionError;
34 : :
35 : : namespace wallet {
36 : 2040 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
37 : : {
38 : 2040 : std::vector<CRecipient> recipients;
39 [ - + + + ]: 23160 : for (size_t i = 0; i < outputs.size(); ++i) {
40 [ + - + - ]: 21120 : const auto& [destination, amount] = outputs.at(i);
41 [ + - ]: 42240 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
42 [ + - ]: 21120 : recipients.push_back(recipient);
43 : 21120 : }
44 : 2040 : return recipients;
45 : 0 : }
46 : :
47 : 455 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
48 : : {
49 [ + - + - : 1342 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
50 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
51 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
52 : : }
53 : : } else {
54 [ + - + - ]: 862 : options.pushKV("conf_target", conf_target);
55 [ + - + - ]: 862 : options.pushKV("estimate_mode", estimate_mode);
56 : : }
57 [ + + ]: 904 : if (options.exists("fee_rate")) {
58 [ + + ]: 28 : if (!fee_rate.isNull()) {
59 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
60 : : }
61 : : } else {
62 [ + - + - ]: 848 : options.pushKV("fee_rate", fee_rate);
63 : : }
64 [ + - + - : 960 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
65 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
66 : : }
67 : 451 : }
68 : :
69 : 775 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
70 : : {
71 [ + + ]: 775 : std::set<int> sffo_set;
72 [ + + ]: 775 : if (sffo_instructions.isNull()) return sffo_set;
73 : :
74 [ + - + + ]: 200 : for (const auto& sffo : sffo_instructions.getValues()) {
75 : 105 : int pos{-1};
76 [ + + ]: 105 : if (sffo.isStr()) {
77 [ + - ]: 9 : auto it = find(destinations.begin(), destinations.end(), sffo.get_str());
78 [ + + + - : 10 : if (it == destinations.end()) throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', destination %s not found in tx outputs", sffo.get_str()));
+ - + - ]
79 : 8 : pos = it - destinations.begin();
80 [ + + ]: 96 : } else if (sffo.isNum()) {
81 [ + - ]: 95 : pos = sffo.getInt<int>();
82 : : } else {
83 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', invalid value type: %s", uvTypeName(sffo.type())));
+ - ]
84 : : }
85 : :
86 [ + + ]: 103 : if (sffo_set.contains(pos))
87 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', duplicated position: %d", pos));
88 [ + + ]: 101 : if (pos < 0)
89 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', negative position: %d", pos));
90 [ - + + + ]: 100 : if (pos >= int(destinations.size()))
91 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', position too large: %d", pos));
92 [ + - ]: 99 : sffo_set.insert(pos);
93 : : }
94 : : return sffo_set;
95 : 6 : }
96 : :
97 : 308 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, CMutableTransaction& rawTx)
98 : : {
99 : 616 : bool can_anti_fee_snipe = !options.exists("locktime");
100 : :
101 [ + + ]: 1779 : for (const CTxIn& tx_in : rawTx.vin) {
102 : : // Checks sequence values consistent with DiscourageFeeSniping
103 [ + + + + ]: 1480 : can_anti_fee_snipe = can_anti_fee_snipe && (tx_in.nSequence == CTxIn::MAX_SEQUENCE_NONFINAL || tx_in.nSequence == MAX_BIP125_RBF_SEQUENCE);
104 : : }
105 : :
106 [ + + ]: 308 : if (can_anti_fee_snipe) {
107 : 301 : LOCK(pwallet->cs_wallet);
108 : 301 : FastRandomContext rng_fast;
109 [ + - ]: 301 : DiscourageFeeSniping(rawTx, rng_fast, pwallet->chain(), pwallet->GetLastBlockHash(), pwallet->GetLastBlockHeight());
110 [ + - ]: 602 : }
111 : :
112 : : // Make a blank psbt
113 : 308 : PartiallySignedTransaction psbtx(rawTx, /*version=*/2);
114 : :
115 : : // First fill transaction with our data without signing,
116 : : // so external signers are not asked to sign more than once.
117 : 308 : bool complete;
118 [ + - ]: 308 : pwallet->FillPSBT(psbtx, {.sign = false, .bip32_derivs = true}, complete);
119 [ + - ]: 308 : const auto err{pwallet->FillPSBT(psbtx, {.sign = true, .bip32_derivs = false}, complete)};
120 [ + + ]: 308 : if (err) {
121 [ + - ]: 1 : throw JSONRPCPSBTError(*err);
122 : : }
123 : :
124 [ + - ]: 307 : CMutableTransaction mtx;
125 [ + - ]: 307 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
126 : :
127 : 307 : UniValue result(UniValue::VOBJ);
128 : :
129 [ + - + - : 328 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
130 [ + - + + : 648 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
131 [ + + + + : 307 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
132 : : // Serialize the PSBT
133 : 61 : DataStream ssTx{};
134 [ + - ]: 61 : ssTx << psbtx;
135 [ + - + - : 183 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
136 : 61 : }
137 : :
138 [ + + ]: 307 : if (complete) {
139 [ + - + - ]: 279 : std::string hex{EncodeHexTx(CTransaction(mtx))};
140 [ + - ]: 279 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
141 [ + - + - : 558 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
142 [ + + ]: 279 : if (add_to_wallet && !psbt_opt_in) {
143 [ + - + - ]: 984 : pwallet->CommitTransaction(tx);
144 : : } else {
145 [ + - + - : 66 : result.pushKV("hex", hex);
+ - ]
146 : : }
147 : 279 : }
148 [ + - + - : 614 : result.pushKV("complete", complete);
+ - ]
149 : :
150 : 614 : return result;
151 : 308 : }
152 : :
153 : 451 : static void PreventOutdatedOptions(const UniValue& options)
154 : : {
155 [ + + ]: 902 : if (options.exists("feeRate")) {
156 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
157 : : }
158 [ - + ]: 900 : if (options.exists("changeAddress")) {
159 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
160 : : }
161 [ - + ]: 900 : if (options.exists("changePosition")) {
162 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
163 : : }
164 [ - + ]: 900 : if (options.exists("lockUnspents")) {
165 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
166 : : }
167 [ - + ]: 900 : if (options.exists("subtractFeeFromOutputs")) {
168 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
169 : : }
170 : 450 : }
171 : :
172 : 1327 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, std::optional<std::string> comment, std::optional<std::string> comment_to, bool verbose)
173 : : {
174 : 1327 : EnsureWalletIsUnlocked(wallet);
175 : :
176 : : // This function is only used by sendtoaddress and sendmany.
177 : : // This should always try to sign, if we don't have (all) private keys, don't
178 : : // try to do anything here.
179 [ + + ]: 1327 : if (wallet.IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
180 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: sendtoaddress and sendmany are not supported for wallets with external signers; use send instead");
181 : : }
182 [ + + ]: 1325 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
183 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
184 : : }
185 : :
186 : : // Shuffle recipient list
187 : 1324 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
188 : :
189 : : // Send
190 : 1324 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
191 [ + + ]: 1324 : if (!res) {
192 [ + - + - ]: 38 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
193 : : }
194 : 1305 : const CTransactionRef& tx = res->tx;
195 [ + - + - : 6525 : wallet.CommitTransaction(tx, /*replaces_txid=*/std::nullopt, comment, comment_to);
+ - + - ]
196 [ + + ]: 1305 : if (verbose) {
197 : 8 : UniValue entry(UniValue::VOBJ);
198 [ + - + - : 16 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
199 [ + - + - : 16 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_reason));
+ - + - ]
200 : 8 : return entry;
201 : 0 : }
202 [ + - + - ]: 1297 : return tx->GetHash().GetHex();
203 : 1305 : }
204 : :
205 : :
206 : : /**
207 : : * Update coin control with fee estimation based on the given parameters
208 : : *
209 : : * @param[in] wallet Wallet reference
210 : : * @param[in,out] cc Coin control to be updated
211 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees/block_policy_estimator.h;
212 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
213 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
214 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
215 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
216 : : * verify only that fee_rate is greater than 0
217 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
218 : : */
219 : 2278 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
220 : : {
221 [ + + ]: 2278 : if (!fee_rate.isNull()) {
222 [ + + ]: 614 : if (!conf_target.isNull()) {
223 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
224 : : }
225 [ + + + + ]: 611 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
226 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
227 : : }
228 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
229 [ - + ]: 608 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
230 [ + + ]: 532 : if (override_min_fee) cc.fOverrideFeeRate = true;
231 : : // Default RBF to true for explicit fee_rate, if unset.
232 [ + + ]: 532 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
233 : 532 : return;
234 : : }
235 [ + + - + : 1664 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
+ + ]
236 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
237 : : }
238 [ + + ]: 1637 : if (!conf_target.isNull()) {
239 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().maximumFeeEstimationTargetBlocks());
240 : : }
241 : : }
242 : :
243 : 2178 : RPCMethod sendtoaddress()
244 : : {
245 : 2178 : return RPCMethod{
246 : 2178 : "sendtoaddress",
247 : 2178 : "Send an amount to a given address." +
248 [ + - ]: 2178 : HELP_REQUIRING_PASSPHRASE,
249 : : {
250 [ + - + - ]: 4356 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
251 [ + - + - ]: 4356 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
252 [ + - + - ]: 4356 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
253 : : "This is not part of the transaction, just kept in your wallet."},
254 [ + - + - ]: 4356 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
255 : : "to which you're sending the transaction. This is not part of the \n"
256 : : "transaction, just kept in your wallet."},
257 [ + - + - : 6534 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
+ - ]
258 : : "The recipient will receive less bitcoins than you enter in the amount field."},
259 [ + - + - : 6534 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
+ - ]
260 [ + - + - : 6534 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
261 [ + - + - ]: 4356 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
262 [ + - + - : 4356 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
263 [ + - + - : 6534 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
+ - ]
264 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
265 [ + - + - : 6534 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
266 [ + - + - : 6534 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
+ - ]
267 : : },
268 : : {
269 [ + - ]: 2178 : RPCResult{"if verbose is not set or set to false",
270 [ + - + - ]: 4356 : RPCResult::Type::STR_HEX, "txid", "The transaction id."
271 : 2178 : },
272 [ + - ]: 4356 : RPCResult{"if verbose is set to true",
273 [ + - + - ]: 4356 : RPCResult::Type::OBJ, "", "",
274 : : {
275 [ + - + - ]: 4356 : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
276 [ + - + - : 4356 : {RPCResult::Type::STR, "fee_reason", "The reason the wallet selected this fee rate (\"" + FeeReasons("\", \"") + "\")."}
+ - + - ]
277 : : },
278 [ + - + + : 13068 : },
- - ]
279 : : },
280 : 2178 : RPCExamples{
281 : : "\nSend 0.1 BTC\n"
282 [ + - + - : 6534 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
283 : 2178 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
284 [ + - + - : 10890 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
285 [ + - ]: 4356 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
286 [ + - + - : 10890 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
287 : 2178 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
288 [ + - + - : 10890 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
289 [ + - ]: 4356 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
290 [ + - + - : 10890 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
291 [ + - + - : 8712 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
292 [ + - ]: 2178 : },
293 : 2178 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
294 : : {
295 : 1277 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
296 [ - + ]: 1277 : if (!pwallet) return UniValue::VNULL;
297 : :
298 : : // Make sure the results are valid at least up to the most recent block
299 : : // the user could have gotten from another RPC command prior to now
300 [ + - ]: 1277 : pwallet->BlockUntilSyncedToCurrentChain();
301 : :
302 [ + - ]: 1277 : LOCK(pwallet->cs_wallet);
303 : :
304 : : // Wallet comments
305 : 1277 : std::optional<std::string> comment;
306 : 1277 : std::optional<std::string> comment_to;
307 [ + - + + : 1277 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
308 [ + - + - : 7 : comment = request.params[2].get_str();
+ - ]
309 [ + - + + : 1277 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
310 [ + - + - : 1 : comment_to = request.params[3].get_str();
+ - ]
311 : :
312 [ + - ]: 1277 : CCoinControl coin_control;
313 [ + - + + ]: 1277 : if (!request.params[5].isNull()) {
314 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
315 : : }
316 : :
317 [ + - + - ]: 1277 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
318 : : // We also enable partial spend avoidance if reuse avoidance is set.
319 : 1277 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
320 : :
321 [ + - + - : 1277 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
322 : :
323 [ + + ]: 1277 : EnsureWalletIsUnlocked(*pwallet);
324 : :
325 : 1274 : UniValue address_amounts(UniValue::VOBJ);
326 [ + - + - : 1274 : const std::string address = request.params[0].get_str();
- + ]
327 [ + - + - : 3822 : address_amounts.pushKV(address, request.params[1]);
+ - ]
328 : :
329 [ + - ]: 1274 : std::set<int> sffo_set;
330 [ + - + + : 1274 : if (!request.params[4].isNull() && request.params[4].get_bool()) {
+ - + - +
+ ]
331 [ + - ]: 216 : sffo_set.insert(0);
332 : : }
333 : :
334 [ + + + - ]: 1274 : std::vector<CRecipient> recipients{CreateRecipients(ParseOutputs(address_amounts), sffo_set)};
335 [ + - + + : 1272 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
336 : :
337 [ + - + - : 5097 : return SendMoney(*pwallet, coin_control, recipients, comment, comment_to, verbose);
+ + ]
338 [ + - ]: 3876 : },
339 [ + - + - : 43560 : };
+ - + - +
+ + + - -
- - ]
340 [ + - + - : 65340 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- - - - -
- - ]
341 : :
342 : 985 : RPCMethod sendmany()
343 : : {
344 : 985 : return RPCMethod{"sendmany",
345 : 985 : "Send multiple times. Amounts are double-precision floating point numbers." +
346 [ + - ]: 985 : HELP_REQUIRING_PASSPHRASE,
347 : : {
348 [ + - + - : 2955 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
+ - ]
349 [ + - ]: 1970 : RPCArgOptions{
350 : : .oneline_description = "\"\"",
351 : : .placeholder = true,
352 : : }},
353 [ + - + - ]: 1970 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
354 : : {
355 [ + - + - ]: 1970 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
356 : : },
357 : : },
358 [ + - + - ]: 1970 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value",
359 [ + - ]: 1970 : RPCArgOptions{.placeholder = true}},
360 [ + - + - ]: 1970 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
361 [ + - + - ]: 1970 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
362 : : "The fee will be equally deducted from the amount of each selected address.\n"
363 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
364 : : "If no addresses are specified here, the sender pays the fee.",
365 : : {
366 [ + - + - ]: 1970 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
367 : : },
368 : : },
369 [ + - + - : 2955 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
+ - ]
370 [ + - + - : 2955 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
371 [ + - + - ]: 1970 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
372 [ + - + - : 1970 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
373 [ + - + - : 2955 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
374 [ + - + - : 2955 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
+ - ]
375 : : },
376 : : {
377 [ + - ]: 985 : RPCResult{"if verbose is not set or set to false",
378 [ + - + - ]: 1970 : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
379 : : "the number of addresses."
380 : 985 : },
381 [ + - ]: 1970 : RPCResult{"if verbose is set to true",
382 [ + - + - ]: 1970 : RPCResult::Type::OBJ, "", "",
383 : : {
384 [ + - + - ]: 1970 : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
385 : : "the number of addresses."},
386 [ + - + - : 1970 : {RPCResult::Type::STR, "fee_reason", "The reason the wallet selected this fee rate (\"" + FeeReasons("\", \"") + "\")."}
+ - + - ]
387 : : },
388 [ + - + + : 5910 : },
- - ]
389 : : },
390 : 985 : RPCExamples{
391 : : "\nSend two amounts to two different addresses:\n"
392 [ + - + - : 3940 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
393 : 985 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
394 [ + - + - : 5910 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
395 : 985 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
396 [ + - + - : 7880 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
397 : 985 : "\nAs a JSON-RPC call\n"
398 [ + - + - : 4925 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
399 [ + - ]: 985 : },
400 : 985 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
401 : : {
402 : 84 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
403 [ - + ]: 84 : if (!pwallet) return UniValue::VNULL;
404 : :
405 : : // Make sure the results are valid at least up to the most recent block
406 : : // the user could have gotten from another RPC command prior to now
407 [ + - ]: 84 : pwallet->BlockUntilSyncedToCurrentChain();
408 : :
409 [ + - ]: 84 : LOCK(pwallet->cs_wallet);
410 : :
411 [ + - + + : 84 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
412 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
413 : : }
414 [ + - + - : 84 : UniValue sendTo = request.params[1].get_obj();
+ - ]
415 : :
416 : 84 : std::optional<std::string> comment;
417 [ + - + + : 84 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
418 [ # # # # : 0 : comment = request.params[3].get_str();
# # ]
419 : :
420 [ + - ]: 84 : CCoinControl coin_control;
421 [ + - - + ]: 84 : if (!request.params[5].isNull()) {
422 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
423 : : }
424 : :
425 [ + - + - : 84 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
426 : :
427 : 61 : std::vector<CRecipient> recipients = CreateRecipients(
428 [ + - ]: 110 : ParseOutputs(sendTo),
429 [ + - + - : 61 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ + ]
430 [ + - ]: 55 : );
431 [ + - + + : 55 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
432 : :
433 [ + - + + ]: 178 : return SendMoney(*pwallet, coin_control, recipients, comment, /*comment_to=*/std::nullopt, verbose);
434 [ + - ]: 265 : },
435 [ + - + - : 24625 : };
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
436 [ + - + - : 29550 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - - -
- - - - ]
437 : :
438 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
439 : 4540 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
440 : : {
441 : 4540 : std::vector<RPCArg> args = {
442 [ + - + - : 13620 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
+ - + - ]
443 [ + - + - ]: 9080 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
444 [ + - + - : 9080 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - + - ]
445 : : {
446 [ + - + - : 13620 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
+ - ]
447 : : "Allows this transaction to be replaced by a transaction with higher fees"
448 : : },
449 [ + - + + : 22700 : };
- - ]
450 [ + - ]: 4540 : if (solving_data) {
451 [ + - + - : 77180 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
452 : : "Used for fee estimation during coin selection.",
453 : : {
454 : : {
455 [ + - + - ]: 9080 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
456 : : {
457 [ + - + - ]: 9080 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
458 : : }
459 : : },
460 : : {
461 [ + - + - ]: 9080 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
462 : : {
463 [ + - + - ]: 9080 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
464 : : }
465 : : },
466 : : {
467 [ + - + - ]: 9080 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
468 : : {
469 [ + - + - ]: 9080 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
470 : : }
471 : : },
472 : : }
473 : : });
474 : : }
475 : 4540 : return args;
476 [ + - + - : 77180 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
477 : :
478 : 711 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
479 : : {
480 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
481 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
482 : 711 : CHECK_NONFATAL(tx.vout.empty());
483 : : // Make sure the results are valid at least up to the most recent block
484 : : // the user could have gotten from another RPC command prior to now
485 : 711 : wallet.BlockUntilSyncedToCurrentChain();
486 : :
487 : 711 : std::optional<unsigned int> change_position;
488 : 711 : bool lockUnspents = false;
489 [ + + ]: 711 : if (!options.isNull()) {
490 [ + + + + : 19598 : RPCTypeCheckObj(options,
+ + ]
491 : : {
492 [ + - ]: 675 : {"add_inputs", UniValueType(UniValue::VBOOL)},
493 [ + - ]: 675 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
494 [ + - ]: 675 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
495 [ + - ]: 675 : {"changeAddress", UniValueType(UniValue::VSTR)},
496 [ + - ]: 675 : {"change_address", UniValueType(UniValue::VSTR)},
497 [ + - ]: 675 : {"changePosition", UniValueType(UniValue::VNUM)},
498 [ + - ]: 675 : {"change_position", UniValueType(UniValue::VNUM)},
499 [ + - ]: 675 : {"change_type", UniValueType(UniValue::VSTR)},
500 [ + - ]: 675 : {"includeWatching", UniValueType(UniValue::VBOOL)},
501 [ + - ]: 675 : {"include_watching", UniValueType(UniValue::VBOOL)},
502 [ + - ]: 675 : {"inputs", UniValueType(UniValue::VARR)},
503 [ + - ]: 675 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
504 [ + - ]: 675 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
505 [ + - ]: 675 : {"locktime", UniValueType(UniValue::VNUM)},
506 [ + - ]: 675 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
507 [ + - ]: 675 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
508 [ + - ]: 675 : {"psbt", UniValueType(UniValue::VBOOL)},
509 [ + - ]: 675 : {"solving_data", UniValueType(UniValue::VOBJ)},
510 [ + - ]: 675 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
511 [ + - ]: 675 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
512 [ + - ]: 675 : {"replaceable", UniValueType(UniValue::VBOOL)},
513 [ + - ]: 675 : {"conf_target", UniValueType(UniValue::VNUM)},
514 [ + - ]: 675 : {"estimate_mode", UniValueType(UniValue::VSTR)},
515 [ + - ]: 675 : {"minconf", UniValueType(UniValue::VNUM)},
516 [ + - ]: 675 : {"maxconf", UniValueType(UniValue::VNUM)},
517 [ + - ]: 675 : {"input_weights", UniValueType(UniValue::VARR)},
518 [ + - ]: 675 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
519 : : },
520 : : true, true);
521 : :
522 [ + + ]: 1304 : if (options.exists("add_inputs")) {
523 [ + - + - ]: 174 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
524 : : }
525 : :
526 [ + - + - : 1947 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
527 [ + + + - : 52 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - - +
+ + + + -
- - - ]
528 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
529 : :
530 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
531 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
532 : : }
533 : :
534 [ + - ]: 22 : coinControl.destChange = dest;
535 : 15 : }
536 : :
537 [ + - + - : 1922 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
538 [ + + + - : 183 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
539 [ + - - + : 61 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
+ + ]
540 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
541 : : }
542 : 60 : change_position = (unsigned int)pos;
543 : : }
544 : :
545 [ + + ]: 1298 : if (options.exists("change_type")) {
546 [ + - + - : 299 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
547 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
548 : : }
549 [ + - + + : 198 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
- + + - +
+ ]
550 [ - + ]: 194 : coinControl.m_change_type.emplace(parsed.value());
551 : : } else {
552 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
553 : : }
554 : : }
555 : :
556 [ + - + - : 1935 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
557 [ + + + - : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + +
+ + - - -
- ]
558 : : }
559 : :
560 [ + + ]: 1292 : if (options.exists("include_unsafe")) {
561 [ + - + - ]: 46 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
562 : : }
563 : :
564 [ + + ]: 1292 : if (options.exists("feeRate")) {
565 [ + + ]: 116 : if (options.exists("fee_rate")) {
566 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
567 : : }
568 [ + + ]: 112 : if (options.exists("conf_target")) {
569 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
570 : : }
571 [ + + ]: 108 : if (options.exists("estimate_mode")) {
572 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
573 : : }
574 [ + - + + : 104 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
- + ]
575 : 36 : coinControl.fOverrideFeeRate = true;
576 : : }
577 : :
578 [ + + ]: 1248 : if (options.exists("replaceable")) {
579 [ + - + - ]: 5 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
580 : : }
581 : :
582 [ + + ]: 1248 : if (options.exists("minconf")) {
583 [ + - + - ]: 9 : coinControl.m_min_depth = options["minconf"].getInt<int>();
584 : :
585 [ + + ]: 9 : if (coinControl.m_min_depth < 0) {
586 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
587 : : }
588 : : }
589 : :
590 [ + + ]: 1246 : if (options.exists("maxconf")) {
591 [ + - + - ]: 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
592 : :
593 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
594 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
595 : : }
596 : : }
597 [ + - + - : 1440 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + + ]
598 : : }
599 : :
600 [ + + ]: 1124 : if (options.exists("solving_data")) {
601 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
602 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
603 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
604 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
605 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
606 : : // Add witness script for pubkeys
607 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
608 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
609 : 3 : }
610 : : }
611 : :
612 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
613 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
614 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
615 [ - + + - : 6 : if (!IsHex(script_str)) {
+ + ]
616 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
617 : : }
618 [ - + + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
619 : 5 : const CScript script(script_data.begin(), script_data.end());
620 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
621 : 5 : }
622 : : }
623 : :
624 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
625 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
626 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
627 : 8 : FlatSigningProvider desc_out;
628 [ - + ]: 8 : std::string error;
629 : 8 : std::vector<CScript> scripts_temp;
630 [ - + + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
631 [ + + ]: 8 : if (descs.empty()) {
632 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
633 : : }
634 [ + + ]: 14 : for (auto& desc : descs) {
635 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
636 : : }
637 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
638 : 10 : }
639 : : }
640 : 14 : }
641 : :
642 [ + + ]: 1116 : if (options.exists("input_weights")) {
643 [ + - + - : 2647 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
644 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
645 : :
646 : 2491 : const UniValue& vout_v = input.find_value("vout");
647 [ + + ]: 2491 : if (!vout_v.isNum()) {
648 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
649 : : }
650 : 2490 : int vout = vout_v.getInt<int>();
651 [ + + ]: 2490 : if (vout < 0) {
652 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
653 : : }
654 : :
655 : 2489 : const UniValue& weight_v = input.find_value("weight");
656 [ + + ]: 2489 : if (!weight_v.isNum()) {
657 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
658 : : }
659 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
660 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
661 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
662 [ + + ]: 2488 : if (weight < min_input_weight) {
663 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
664 : : }
665 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
666 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
667 : : }
668 : :
669 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
670 : : }
671 : : }
672 : :
673 [ + + ]: 1104 : if (options.exists("max_tx_weight")) {
674 [ + - + - ]: 10 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
675 : : }
676 : :
677 [ + + ]: 552 : if (tx.version == TRUC_VERSION) {
678 [ + + - + ]: 36 : if (!coinControl.m_max_tx_weight.has_value() || coinControl.m_max_tx_weight.value() > TRUC_MAX_WEIGHT) {
679 [ - + ]: 34 : coinControl.m_max_tx_weight = TRUC_MAX_WEIGHT;
680 : : }
681 : : }
682 : :
683 [ - + ]: 552 : if (recipients.empty())
684 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
685 : :
686 [ + - ]: 552 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
687 [ + + ]: 552 : if (!txr) {
688 [ + - + - ]: 182 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
689 : : }
690 : 461 : return *txr;
691 [ + - + - : 1159 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
692 : :
693 : 469 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
694 : : {
695 [ + + ]: 938 : if (options.exists("input_weights")) {
696 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
697 : : }
698 [ - + + + ]: 467 : if (inputs.size() == 0) {
699 : : return;
700 : : }
701 : 192 : UniValue weights(UniValue::VARR);
702 [ + - + + ]: 3003 : for (const UniValue& input : inputs.getValues()) {
703 [ + - + + ]: 5622 : if (input.exists("weight")) {
704 [ + - + - ]: 6 : weights.push_back(input);
705 : : }
706 : : }
707 [ + - + - ]: 384 : options.pushKV("input_weights", std::move(weights));
708 : 192 : }
709 : :
710 : 1146 : RPCMethod fundrawtransaction()
711 : : {
712 : 1146 : return RPCMethod{
713 : 1146 : "fundrawtransaction",
714 [ + - ]: 2292 : "If the transaction has no inputs, they will be automatically selected to meet its out value.\n"
715 : : "It will add at most one change output to the outputs.\n"
716 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
717 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
718 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
719 : : "or signrawtransactionwithwallet for that.\n"
720 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
721 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
722 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
723 : : "in the wallet using importdescriptors (to calculate fees).\n"
724 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
725 : : "Note that if specifying an exact fee rate, the resulting transaction may have a higher fee rate\n"
726 : : "if the transaction has unconfirmed inputs. This is because the wallet will attempt to make the\n"
727 : : "entire package have the given fee rate, not the resulting transaction.\n",
728 : : {
729 [ + - + - ]: 2292 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
730 [ + - + - ]: 2292 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
731 [ + - + - : 30942 : Cat<std::vector<RPCArg>>(
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
732 : : {
733 [ + - + - : 3438 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
+ - ]
734 [ + - + - : 3438 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
735 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
736 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
737 [ + - + - : 3438 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
738 [ + - + - ]: 2292 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
739 [ + - + - : 3438 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
740 [ + - + - : 3438 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
741 [ + - + - : 3438 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
742 [ + - + - : 3438 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
743 [ + - + - : 3438 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
744 [ + - + - : 3438 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
745 [ + - + - : 3438 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
+ - ]
746 [ + - + - ]: 2292 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
747 : : "The fee will be equally deducted from the amount of each specified output.\n"
748 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
749 : : "If no outputs are specified here, the sender pays the fee.",
750 : : {
751 [ + - + - ]: 2292 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
752 : : },
753 : : },
754 [ + - + - ]: 2292 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
755 : : {
756 [ + - + - ]: 2292 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
757 : : {
758 [ + - + - ]: 2292 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
759 [ + - + - ]: 2292 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
760 [ + - + - ]: 2292 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
761 : : "including the weight of the outpoint and sequence number. "
762 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
763 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
764 : : "Remember to convert serialized sizes to weight units when necessary."},
765 : : },
766 : : },
767 : : },
768 : : },
769 [ + - + - : 3438 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
770 : : "Transaction building will fail if this can not be satisfied."},
771 : : },
772 [ + - ]: 2292 : FundTxDoc()),
773 [ + - ]: 2292 : RPCArgOptions{
774 : : .oneline_description = "options",
775 : : }},
776 [ + - + - : 3438 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
+ - ]
777 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
778 : : "If true, only witness deserialization will be tried.\n"
779 : : "If false, only non-witness deserialization will be tried.\n"
780 : : "This boolean should reflect whether the transaction has inputs\n"
781 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
782 : : },
783 : : },
784 [ + - ]: 2292 : RPCResult{
785 [ + - + - ]: 2292 : RPCResult::Type::OBJ, "", "",
786 : : {
787 [ + - + - ]: 2292 : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
788 [ + - + - ]: 2292 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
789 [ + - + - ]: 2292 : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
790 : : }
791 [ + - + - : 9168 : },
+ + - - ]
792 : 1146 : RPCExamples{
793 : : "\nCreate a transaction with no inputs\n"
794 [ + - + - : 2292 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
795 : 1146 : "\nAdd sufficient unsigned inputs to meet the output value\n"
796 [ + - + - : 4584 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
797 : 1146 : "\nSign the transaction\n"
798 [ + - + - : 4584 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
799 : 1146 : "\nSend the transaction\n"
800 [ + - + - : 4584 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
801 [ + - ]: 1146 : },
802 : 1146 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
803 : : {
804 : 244 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
805 [ - + ]: 244 : if (!pwallet) return UniValue::VNULL;
806 : :
807 : : // parse hex string from parameter
808 [ + - ]: 244 : CMutableTransaction tx;
809 [ + - - + : 244 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
810 [ + - - + : 244 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
811 [ + - + - : 244 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
812 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
813 : : }
814 [ + - + - ]: 244 : UniValue options = request.params[1];
815 : 244 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
816 [ + + ]: 11711 : for (const auto& tx_out : tx.vout) {
817 : 11467 : CTxDestination dest;
818 [ + - ]: 11467 : ExtractDestination(tx_out.scriptPubKey, dest);
819 [ + - ]: 11467 : destinations.emplace_back(dest, tx_out.nValue);
820 : 11467 : }
821 [ + - + - ]: 488 : std::vector<std::string> dummy(destinations.size(), "dummy");
822 : 244 : std::vector<CRecipient> recipients = CreateRecipients(
823 : : destinations,
824 [ + - + - : 488 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
825 [ + - ]: 244 : );
826 [ + - ]: 244 : CCoinControl coin_control;
827 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
828 : 244 : coin_control.m_allow_other_inputs = true;
829 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
830 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
831 : 244 : tx.vout.clear();
832 [ + + ]: 244 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
833 : :
834 : 145 : UniValue result(UniValue::VOBJ);
835 [ + - + - : 290 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
836 [ + - + - : 290 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
837 [ + + + - : 290 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
838 : :
839 : 145 : return result;
840 [ + - ]: 1174 : },
841 [ + - + - : 8022 : };
+ + - - ]
842 [ + - + - : 56154 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- - - - -
- - - - ]
843 : :
844 : 1225 : RPCMethod signrawtransactionwithwallet()
845 : : {
846 : 1225 : return RPCMethod{
847 : 1225 : "signrawtransactionwithwallet",
848 : : "Sign inputs for raw transaction (serialized, hex-encoded).\n"
849 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
850 : 1225 : "this transaction depends on but may not yet be in the block chain." +
851 [ + - ]: 1225 : HELP_REQUIRING_PASSPHRASE,
852 : : {
853 [ + - + - ]: 2450 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
854 [ + - + - ]: 2450 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
855 : : {
856 [ + - + - ]: 2450 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
857 : : {
858 [ + - + - ]: 2450 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
859 [ + - + - ]: 2450 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
860 [ + - + - ]: 2450 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
861 [ + - + - ]: 2450 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
862 [ + - + - ]: 2450 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
863 [ + - + - ]: 2450 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
864 : : },
865 : : },
866 : : },
867 : : },
868 [ + - + - : 3675 : {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
+ - ]
869 : : " \"DEFAULT\"\n"
870 : : " \"ALL\"\n"
871 : : " \"NONE\"\n"
872 : : " \"SINGLE\"\n"
873 : : " \"ALL|ANYONECANPAY\"\n"
874 : : " \"NONE|ANYONECANPAY\"\n"
875 : : " \"SINGLE|ANYONECANPAY\""},
876 : : },
877 [ + - ]: 2450 : RPCResult{
878 [ + - + - ]: 2450 : RPCResult::Type::OBJ, "", "",
879 : : {
880 [ + - + - ]: 2450 : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
881 [ + - + - ]: 2450 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
882 [ + - + - ]: 2450 : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
883 : : {
884 [ + - + - ]: 2450 : {RPCResult::Type::OBJ, "", "",
885 : : {
886 [ + - + - ]: 2450 : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
887 [ + - + - ]: 2450 : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
888 [ + - + - ]: 2450 : {RPCResult::Type::ARR, "witness", "",
889 : : {
890 [ + - + - ]: 2450 : {RPCResult::Type::STR_HEX, "witness", ""},
891 : : }},
892 [ + - + - ]: 2450 : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
893 [ + - + - ]: 2450 : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
894 [ + - + - ]: 2450 : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
895 : : }},
896 : : }},
897 : : }
898 [ + - + - : 33075 : },
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
899 : 1225 : RPCExamples{
900 [ + - + - : 2450 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
901 [ + - + - : 4900 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
902 [ + - ]: 1225 : },
903 : 1225 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
904 : : {
905 [ - + ]: 324 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
906 [ - + ]: 324 : if (!pwallet) return UniValue::VNULL;
907 : :
908 [ + - ]: 324 : CMutableTransaction mtx;
909 [ + - + - : 324 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
910 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
911 : : }
912 : :
913 : : // Sign the transaction
914 [ + - ]: 324 : LOCK(pwallet->cs_wallet);
915 [ + + ]: 324 : EnsureWalletIsUnlocked(*pwallet);
916 : :
917 : : // Fetch previous transactions (inputs):
918 : 323 : std::map<COutPoint, Coin> coins;
919 [ + + ]: 731 : for (const CTxIn& txin : mtx.vin) {
920 [ + - ]: 408 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
921 : : }
922 [ + - ]: 323 : pwallet->chain().findCoins(coins);
923 : :
924 : : // Parse the prevtxs array
925 [ + - + + ]: 323 : ParsePrevouts(request.params[1], nullptr, coins);
926 : :
927 [ + - + + ]: 314 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
928 [ + + ]: 313 : if (!nHashType) {
929 : 304 : nHashType = SIGHASH_DEFAULT;
930 : : }
931 : :
932 : : // Script verification errors
933 [ + - ]: 313 : std::map<int, bilingual_str> input_errors;
934 : :
935 [ + - ]: 313 : bool complete = pwallet->SignTransaction(mtx, coins, *nHashType, input_errors);
936 : 313 : UniValue result(UniValue::VOBJ);
937 [ + + ]: 313 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
938 : 311 : return result;
939 [ + - ]: 1286 : },
940 [ + - + - : 22050 : };
+ - + - +
+ + + + +
- - - - -
- ]
941 [ + - + - : 51450 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - - -
- - - - -
- ]
942 : :
943 : : // Definition of allowed formats of specifying transaction outputs in
944 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
945 : 4256 : static std::vector<RPCArg> OutputsDoc()
946 : : {
947 : 4256 : return
948 : : {
949 [ + - + - ]: 8512 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
950 : : {
951 [ + - ]: 8512 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
952 [ + - ]: 8512 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
953 : : },
954 : : },
955 [ + - + - ]: 8512 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
956 : : {
957 [ + - + - ]: 8512 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data that becomes a part of an OP_RETURN output"},
958 : : },
959 : : },
960 [ + - + - : 46816 : };
+ - + + +
+ + + - -
- - - - ]
961 [ + - + - : 34048 : }
+ - + - -
- ]
962 : :
963 : 1979 : static RPCMethod bumpfee_helper(std::string method_name)
964 : : {
965 : 1979 : const bool want_psbt = method_name == "psbtbumpfee";
966 : 1979 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeRateFormat::SAT_VB)};
967 : :
968 [ - + ]: 1979 : return RPCMethod{method_name,
969 : : "Bumps the fee of a transaction T, replacing it with a new transaction B.\n"
970 [ + - + - ]: 3958 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
971 : : "A transaction with the given txid must be in the wallet.\n"
972 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
973 : : "It may add a new change output if one does not already exist.\n"
974 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
975 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
976 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
977 : : "The user can specify a confirmation target for estimatesmartfee.\n"
978 [ + - ]: 3958 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
979 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
980 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
981 [ + - + - ]: 5937 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
982 : : {
983 [ + - + - ]: 3958 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
984 [ + - + - ]: 3958 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
985 [ + - + - : 15832 : Cat(
+ + - - ]
986 : : {
987 [ + - + - : 5937 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
+ - ]
988 [ + - + - ]: 3958 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
989 [ + - ]: 3958 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
990 [ + - ]: 3958 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
991 [ + - + - ]: 5937 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
992 [ + - + - ]: 3958 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true},
993 [ + - ]: 3958 : "Whether the new transaction should be\n"
994 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
995 : : "be set to 0xfffffffd. If false, any input sequence numbers in the\n"
996 : : "transaction will be set to 0xfffffffe\n"
997 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
998 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
999 : : "are replaceable).\n"},
1000 [ + - + - ]: 3958 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1001 [ + - + - : 3958 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1002 [ + - + - ]: 3958 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1003 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1004 : : "At least one output of either type must be specified.\n"
1005 : : "Cannot be provided if 'original_change_index' is specified.",
1006 [ + - ]: 3958 : OutputsDoc(),
1007 [ + - ]: 3958 : RPCArgOptions{.skip_type_check = true}},
1008 [ + - + - : 5937 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
+ - ]
1009 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1010 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1011 : : "original change output. The change output’s amount can increase if bumping the transaction "
1012 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1013 : : },
1014 [ + + + - : 10492 : want_psbt ? std::vector<RPCArg>{{"psbt_version", RPCArg::Type::NUM, RPCArg::Default(2), "The PSBT version number to use."}} : std::vector<RPCArg>()
+ - + - +
- + + + +
+ + + + +
+ + + - -
- - - - -
- - - -
- ]
1015 : : ),
1016 [ + - ]: 3958 : RPCArgOptions{.oneline_description="options"}},
1017 : : },
1018 [ + - ]: 3958 : RPCResult{
1019 [ + - + - : 27706 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + + + +
- - - - ]
1020 [ + + + - : 9895 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1021 [ + - + - : 5623 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ + + + +
+ - - - -
- - ]
1022 [ + - + - : 6251 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ + + + +
+ - - - -
- - ]
1023 : : {
1024 [ + - + - ]: 3958 : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1025 [ + - + - ]: 3958 : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1026 [ + - + - ]: 3958 : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1027 : : {
1028 [ + - + - ]: 3958 : {RPCResult::Type::STR, "", ""},
1029 : : }},
1030 : : })
1031 [ + - ]: 3958 : },
1032 : 1979 : RPCExamples{
1033 [ + + + - : 5026 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1034 [ + - + - : 5937 : HelpExampleCli(method_name, "<txid>")
+ - ]
1035 : 1979 : },
1036 [ + - ]: 3958 : [want_psbt](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1037 : : {
1038 : 177 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1039 [ - + ]: 177 : if (!pwallet) return UniValue::VNULL;
1040 : :
1041 [ + - + + : 177 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1042 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1043 : : }
1044 : :
1045 [ + - + - ]: 176 : Txid hash{Txid::FromUint256(ParseHashV(request.params[0], "txid"))};
1046 : :
1047 [ + - ]: 176 : CCoinControl coin_control;
1048 : : // optional parameters
1049 : 176 : coin_control.m_signal_bip125_rbf = true;
1050 : 176 : std::vector<CTxOut> outputs;
1051 : :
1052 : 176 : std::optional<uint32_t> original_change_index;
1053 : :
1054 : 176 : uint32_t psbt_version = 2;
1055 : :
1056 [ + - + + ]: 176 : if (!request.params[1].isNull()) {
1057 [ + - + - ]: 85 : UniValue options = request.params[1];
1058 [ + + + + : 854 : RPCTypeCheckObj(options,
+ + ]
1059 : : {
1060 [ + - ]: 85 : {"confTarget", UniValueType(UniValue::VNUM)},
1061 [ + - ]: 85 : {"conf_target", UniValueType(UniValue::VNUM)},
1062 [ + - ]: 85 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1063 [ + - ]: 85 : {"replaceable", UniValueType(UniValue::VBOOL)},
1064 [ + - ]: 85 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1065 [ + - ]: 85 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1066 [ + - ]: 85 : {"original_change_index", UniValueType(UniValue::VNUM)},
1067 [ + - ]: 85 : {"psbt_version", UniValueType(UniValue::VNUM)},
1068 : : },
1069 : : true, true);
1070 : :
1071 [ + - + - : 163 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1072 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1073 : : }
1074 : :
1075 [ + - - + : 240 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1076 : :
1077 [ + - + + ]: 160 : if (options.exists("replaceable")) {
1078 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1079 : : }
1080 [ + - + - : 179 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1081 : :
1082 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1083 [ + - + - : 61 : if (!options["outputs"].isNull()) {
+ + ]
1084 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- - + + +
+ + - - ]
1085 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1086 : : }
1087 [ + - ]: 10 : CMutableTransaction tempTx;
1088 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1089 [ + - ]: 8 : outputs = tempTx.vout;
1090 : 10 : }
1091 : :
1092 [ + - + + ]: 116 : if (options.exists("original_change_index")) {
1093 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1094 : : }
1095 : :
1096 [ + - + + ]: 114 : if (options.exists("psbt_version")) {
1097 [ + - + - : 3 : psbt_version = options["psbt_version"].getInt<uint32_t>();
+ - ]
1098 : : }
1099 [ + + ]: 57 : if (psbt_version != 2 && psbt_version != 0) {
1100 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "The PSBT version can only be 2 or 0");
1101 : : }
1102 : 109 : }
1103 : :
1104 : : // Make sure the results are valid at least up to the most recent block
1105 : : // the user could have gotten from another RPC command prior to now
1106 [ + - ]: 147 : pwallet->BlockUntilSyncedToCurrentChain();
1107 : :
1108 [ + - ]: 147 : LOCK(pwallet->cs_wallet);
1109 : :
1110 [ + + ]: 147 : EnsureWalletIsUnlocked(*pwallet);
1111 : :
1112 : :
1113 : 146 : std::vector<bilingual_str> errors;
1114 : 146 : CAmount old_fee;
1115 : 146 : CAmount new_fee;
1116 [ + - ]: 146 : CMutableTransaction mtx;
1117 : : // Targeting feerate bump.
1118 : 292 : [&](){
1119 [ - - + + : 146 : switch (feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index)) {
+ - + ]
1120 : 113 : case feebumper::Result::OK:
1121 : 113 : return;
1122 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1123 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1124 : 0 : case feebumper::Result::INVALID_REQUEST:
1125 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1126 : 16 : case feebumper::Result::INVALID_PARAMETER:
1127 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1128 : 16 : case feebumper::Result::WALLET_ERROR:
1129 [ + - ]: 16 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1130 : 1 : case feebumper::Result::MISC_ERROR:
1131 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1132 : : } // no default case, so the compiler can warn about missing cases
1133 [ # # ]: 0 : NONFATAL_UNREACHABLE();
1134 [ + + ]: 146 : }();
1135 : :
1136 : 113 : UniValue result(UniValue::VOBJ);
1137 : :
1138 : : // For bumpfee, return the new transaction id.
1139 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1140 [ + + ]: 113 : if (!want_psbt) {
1141 [ + - - + ]: 104 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1142 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1143 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1144 : : }
1145 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1146 : : }
1147 : :
1148 [ + - ]: 104 : Txid txid;
1149 [ + - - + ]: 104 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1150 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1151 : : }
1152 : :
1153 [ + - + - : 208 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1154 : : } else {
1155 [ + - ]: 9 : PartiallySignedTransaction psbtx(mtx, psbt_version);
1156 : 9 : bool complete = false;
1157 [ + - ]: 9 : const auto err{pwallet->FillPSBT(psbtx, {.sign = false, .bip32_derivs = true}, complete)};
1158 [ + - ]: 9 : CHECK_NONFATAL(!err);
1159 [ + - ]: 9 : CHECK_NONFATAL(!complete);
1160 : 9 : DataStream ssTx{};
1161 [ + - ]: 9 : ssTx << psbtx;
1162 [ + - + - : 27 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1163 : 9 : }
1164 : :
1165 [ + - + - : 226 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1166 [ + - + - : 226 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1167 : 113 : UniValue result_errors(UniValue::VARR);
1168 [ - + ]: 113 : for (const bilingual_str& error : errors) {
1169 [ # # # # ]: 0 : result_errors.push_back(error.original);
1170 : : }
1171 [ + - + - ]: 226 : result.pushKV("errors", std::move(result_errors));
1172 : :
1173 : 113 : return result;
1174 [ + - + - : 700 : },
+ - + - +
- + - + -
+ - + - +
- - + ]
1175 [ + + + - : 13853 : };
+ - + + -
- ]
1176 [ + - + - : 57234 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - - -
- - - - ]
1177 : :
1178 [ + - ]: 2136 : RPCMethod bumpfee() { return bumpfee_helper("bumpfee"); }
1179 [ + - ]: 1822 : RPCMethod psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1180 : :
1181 : 1140 : RPCMethod send()
1182 : : {
1183 : 1140 : return RPCMethod{
1184 : 1140 : "send",
1185 [ + - ]: 2280 : "Send a transaction.\n",
1186 : : {
1187 [ + - + - ]: 2280 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1188 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1189 : : "At least one output of either type must be specified.\n"
1190 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1191 [ + - ]: 2280 : OutputsDoc(),
1192 [ + - ]: 2280 : RPCArgOptions{.skip_type_check = true}},
1193 [ + - + - : 3420 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
1194 [ + - + - ]: 2280 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1195 [ + - + - : 2280 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1196 [ + - + - : 3420 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1197 [ + - + - ]: 2280 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1198 [ + - + - : 34200 : Cat<std::vector<RPCArg>>(
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
1199 : : {
1200 [ + - + - : 3420 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
+ - ]
1201 [ + - + - : 3420 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
1202 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1203 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1204 [ + - + - : 3420 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
1205 [ + - + - ]: 2280 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1206 [ + - + - : 3420 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
+ - ]
1207 [ + - + - : 3420 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
1208 [ + - + - : 3420 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
1209 [ + - + - : 3420 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
1210 [ + - + - : 4560 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - + - ]
1211 [ + - + - : 3420 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1212 [ + - + - ]: 2280 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
1213 : : {
1214 [ + - + - ]: 2280 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
1215 [ + - + - ]: 2280 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1216 [ + - + - ]: 2280 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1217 [ + - + - : 3420 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
+ - ]
1218 [ + - + - : 3420 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
+ - ]
1219 : : "including the weight of the outpoint and sequence number. "
1220 : : "Note that signature sizes are not guaranteed to be consistent, "
1221 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1222 : : "Remember to convert serialized sizes to weight units when necessary."},
1223 : : }},
1224 : : },
1225 : : },
1226 [ + - + - : 3420 : {"locktime", RPCArg::Type::NUM, RPCArg::DefaultHint{"locktime close to block height to prevent fee sniping"}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1227 [ + - + - : 3420 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1228 [ + - + - : 3420 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
+ - ]
1229 [ + - + - ]: 2280 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1230 : : "The fee will be equally deducted from the amount of each specified output.\n"
1231 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1232 : : "If no outputs are specified here, the sender pays the fee.",
1233 : : {
1234 [ + - + - ]: 2280 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1235 : : },
1236 : : },
1237 [ + - + - : 3420 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
1238 : : "Transaction building will fail if this can not be satisfied."},
1239 : : },
1240 [ + - ]: 2280 : FundTxDoc()),
1241 [ + - ]: 2280 : RPCArgOptions{.oneline_description="options"}},
1242 [ + - + - : 3420 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1243 : : },
1244 [ + - ]: 2280 : RPCResult{
1245 [ + - + - ]: 2280 : RPCResult::Type::OBJ, "", "",
1246 : : {
1247 [ + - + - ]: 2280 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1248 [ + - + - ]: 2280 : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1249 [ + - + - ]: 2280 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1250 [ + - + - ]: 2280 : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1251 : : }
1252 [ + - + - : 11400 : },
+ + - - ]
1253 : 1140 : RPCExamples{""
1254 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1255 [ + - + - : 3420 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1256 [ + - ]: 2280 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1257 [ + - + - : 5700 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1258 [ + - ]: 2280 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1259 [ + - + - : 5700 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1260 [ + - ]: 2280 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1261 [ + - + - : 5700 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1262 : 1140 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1263 [ + - + - : 5700 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical null '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1264 [ + - ]: 1140 : },
1265 : 1140 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1266 : : {
1267 : 239 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1268 [ - + ]: 239 : if (!pwallet) return UniValue::VNULL;
1269 : :
1270 [ + - + + : 239 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1271 [ + - + - : 239 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1272 [ + + ]: 235 : PreventOutdatedOptions(options);
1273 : :
1274 : :
1275 [ + - - + : 468 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1276 : 234 : UniValue outputs(UniValue::VOBJ);
1277 [ + - + - ]: 234 : outputs = NormalizeOutputs(request.params[0]);
1278 : 234 : std::vector<CRecipient> recipients = CreateRecipients(
1279 [ + + ]: 467 : ParseOutputs(outputs),
1280 [ + - + - : 469 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1281 [ + - ]: 233 : );
1282 [ + - ]: 233 : CCoinControl coin_control;
1283 [ + - ]: 233 : coin_control.m_version = self.Arg<uint32_t>("version");
1284 [ + - + - : 466 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf, coin_control.m_version);
+ - + - +
- + - ]
1285 : : // Automatically select coins, unless at least one is manually selected. Can
1286 : : // be overridden by options.add_inputs.
1287 [ - + ]: 233 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1288 [ + - - + ]: 466 : if (options.exists("max_tx_weight")) {
1289 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1290 : : }
1291 : :
1292 [ + - + - : 234 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1293 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1294 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1295 : 232 : rawTx.vout.clear();
1296 [ + + ]: 232 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1297 : :
1298 [ + - ]: 149 : CMutableTransaction tx = CMutableTransaction(*txr.tx);
1299 [ + - + + ]: 447 : return FinishTransaction(pwallet, options, tx);
1300 [ + - ]: 941 : }
1301 [ + - + - : 11400 : };
+ + - - ]
1302 [ + - + - : 69540 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
1303 : :
1304 : 1117 : RPCMethod sendall()
1305 : : {
1306 : 1117 : return RPCMethod{"sendall",
1307 [ + - ]: 2234 : "Spend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1308 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1309 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1310 : : {
1311 [ + - + - ]: 2234 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1312 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1313 : : {
1314 [ + - + - ]: 2234 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1315 [ + - + - ]: 2234 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1316 : : {
1317 [ + - + - ]: 2234 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1318 : : },
1319 : : },
1320 : : },
1321 : : },
1322 [ + - + - : 3351 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
1323 [ + - + - ]: 2234 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1324 [ + - + - : 2234 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1325 [ + - + - : 3351 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1326 : : {
1327 [ + - + - ]: 2234 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1328 [ + - + - : 23457 : Cat<std::vector<RPCArg>>(
+ - + - +
+ + + + +
- - - - -
- ]
1329 : : {
1330 [ + - + - : 3351 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
+ - ]
1331 [ + - + - : 4468 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - + - ]
1332 [ + - + - : 3351 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1333 [ + - + - ]: 2234 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1334 : : {
1335 [ + - + - ]: 2234 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1336 : : {
1337 [ + - + - ]: 2234 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1338 [ + - + - ]: 2234 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1339 [ + - + - : 3351 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
+ - ]
1340 : : },
1341 : : },
1342 : : },
1343 : : },
1344 [ + - + - : 3351 : {"locktime", RPCArg::Type::NUM, RPCArg::DefaultHint{"locktime close to block height to prevent fee sniping"}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1345 [ + - + - : 3351 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1346 [ + - + - : 3351 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
+ - ]
1347 [ + - + - : 3351 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
+ - ]
1348 [ + - + - : 3351 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
+ - ]
1349 [ + - + - ]: 2234 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1350 [ + - + - : 3351 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1351 : : },
1352 [ + - ]: 2234 : FundTxDoc()
1353 : : ),
1354 [ + - ]: 2234 : RPCArgOptions{.oneline_description="options"}
1355 : : },
1356 : : },
1357 [ + - ]: 2234 : RPCResult{
1358 [ + - + - ]: 2234 : RPCResult::Type::OBJ, "", "",
1359 : : {
1360 [ + - + - ]: 2234 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1361 [ + - + - ]: 2234 : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1362 [ + - + - ]: 2234 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1363 [ + - + - ]: 2234 : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1364 : : }
1365 [ + - + - : 11170 : },
+ + - - ]
1366 : 1117 : RPCExamples{""
1367 [ + - ]: 2234 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1368 [ + - + - : 5585 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1369 [ + - ]: 2234 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1370 [ + - + - : 5585 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1371 [ + - ]: 2234 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1372 [ + - + - : 6702 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1373 [ + - ]: 2234 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1374 [ + - + - : 5585 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1375 [ + - + - ]: 3351 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1376 [ + - + - : 6702 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1377 [ + - ]: 1117 : },
1378 : 1117 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1379 : : {
1380 : 216 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1381 [ - + ]: 216 : if (!pwallet) return UniValue::VNULL;
1382 : : // Make sure the results are valid at least up to the most recent block
1383 : : // the user could have gotten from another RPC command prior to now
1384 [ + - ]: 216 : pwallet->BlockUntilSyncedToCurrentChain();
1385 : :
1386 [ + - + + : 216 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1387 [ + - + - : 216 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1388 [ + - ]: 216 : PreventOutdatedOptions(options);
1389 : :
1390 : :
1391 : 216 : std::set<CTxDestination> addresses_without_amount;
1392 : 216 : UniValue recipient_key_value_pairs(UniValue::VARR);
1393 [ + - ]: 216 : const UniValue& recipients{request.params[0]};
1394 [ - + + + ]: 1141 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1395 [ + - ]: 925 : const UniValue& recipient{recipients[i]};
1396 [ + + ]: 925 : if (recipient.isStr()) {
1397 : 916 : UniValue rkvp(UniValue::VOBJ);
1398 [ + - + - : 2748 : rkvp.pushKV(recipient.get_str(), 0);
- + + - ]
1399 [ + - ]: 916 : recipient_key_value_pairs.push_back(std::move(rkvp));
1400 : : // Store the decoded destination, so it matches the outputs below
1401 : : // also when the address was given in another case (e.g. uppercase bech32)
1402 [ + - + - : 916 : addresses_without_amount.insert(DecodeDestination(recipient.get_str()));
+ - ]
1403 : 916 : } else {
1404 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1405 : : }
1406 : : }
1407 : :
1408 [ + + ]: 216 : if (addresses_without_amount.size() == 0) {
1409 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1410 : : }
1411 : :
1412 [ + - ]: 214 : CCoinControl coin_control;
1413 : :
1414 [ + - + - : 428 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1415 : :
1416 [ + - + + ]: 428 : if (options.exists("minconf")) {
1417 [ + - + - : 7 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1418 : : {
1419 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1420 : : }
1421 : :
1422 [ + - + - : 6 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1423 : : }
1424 : :
1425 [ + - + + ]: 426 : if (options.exists("maxconf")) {
1426 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1427 : :
1428 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1429 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1430 : : }
1431 : : }
1432 : :
1433 [ + - + + ]: 426 : if (options.exists("version")) {
1434 [ + - + - : 9 : coin_control.m_version = options["version"].getInt<decltype(coin_control.m_version)>();
+ - ]
1435 : : }
1436 : :
1437 [ + + ]: 213 : if (coin_control.m_version == TRUC_VERSION) {
1438 [ - + ]: 7 : coin_control.m_max_tx_weight = TRUC_MAX_WEIGHT;
1439 : : } else {
1440 : 206 : coin_control.m_max_tx_weight = MAX_STANDARD_TX_WEIGHT;
1441 : : }
1442 : :
1443 [ + - + + : 426 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1444 : :
1445 [ + - ]: 213 : auto [fee_rate, fee_reason, returned_target] = GetMinimumFeeRate(*pwallet, coin_control);
1446 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1447 : : // provided one
1448 [ + + + + ]: 213 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1449 : 1 : const auto feerate_format = FeeRateFormat::SAT_VB;
1450 : 1 : auto msg{strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s).",
1451 [ + - ]: 2 : coin_control.m_feerate->ToString(feerate_format),
1452 [ + - + - ]: 2 : fee_rate.ToString(feerate_format))};
1453 [ + - ]: 1 : if (fee_reason == FeeReason::REQUIRED) {
1454 [ + - ]: 3 : msg += strprintf("\nConsider modifying -mintxfee (%s) or -minrelaytxfee (%s).",
1455 [ + - ]: 2 : pwallet->m_min_fee.ToString(feerate_format),
1456 [ + - + - ]: 3 : pwallet->chain().relayMinFee().ToString(feerate_format));
1457 : : }
1458 [ + - ]: 1 : throw JSONRPCError(RPC_INVALID_PARAMETER, msg);
1459 : 1 : }
1460 [ + + + - ]: 212 : if (fee_reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1461 : : // eventually allow a fallback fee
1462 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1463 : : }
1464 : :
1465 [ + - + - : 425 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf, coin_control.m_version)};
+ - + - +
+ ]
1466 [ + - ]: 211 : LOCK(pwallet->cs_wallet);
1467 : :
1468 : 211 : CAmount total_input_value(0);
1469 [ + - + + : 424 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1470 [ + - + - : 451 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1471 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1472 [ + - + - : 475 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1473 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1474 [ + - + + ]: 418 : } else if (options.exists("inputs")) {
1475 [ + + ]: 51 : for (const CTxIn& input : rawTx.vin) {
1476 [ + - + + ]: 28 : if (pwallet->IsSpent(input.prevout)) {
1477 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1478 : : }
1479 [ + - ]: 26 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1480 [ + + + - : 75 : if (!tx || input.prevout.n >= tx->GetTx()->vout.size() || !pwallet->IsMine(tx->GetTx()->vout[input.prevout.n])) {
- + + + +
- + - + -
+ + + + -
- - - ]
1481 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1482 : : }
1483 [ + - + + ]: 24 : if (pwallet->GetTxDepthInMainChain(*tx) == 0) {
1484 [ + - - + : 32 : if (tx->GetTx()->version == TRUC_VERSION && coin_control.m_version != TRUC_VERSION) {
- - - + ]
1485 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Can't spend unconfirmed version 3 pre-selected input with a version %d tx", coin_control.m_version));
1486 [ - + - - : 16 : } else if (coin_control.m_version == TRUC_VERSION && tx->GetTx()->version != TRUC_VERSION) {
- - - + ]
1487 [ # # # # : 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Can't spend unconfirmed version %d pre-selected input with a version 3 tx", tx->GetTx()->version));
# # # # ]
1488 : : }
1489 : : }
1490 [ + - + - ]: 48 : total_input_value += tx->GetTx()->vout[input.prevout.n].nValue;
1491 : : }
1492 : : } else {
1493 : 182 : CoinFilterParams coins_params;
1494 : 182 : coins_params.min_amount = 0;
1495 [ + - + - : 3029 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1496 [ + + + - : 2847 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1497 : 2 : continue;
1498 : : }
1499 : : // we are spending an unconfirmed TRUC transaction, so lower max weight
1500 [ + + + + ]: 2845 : if (output.depth == 0 && coin_control.m_version == TRUC_VERSION) {
1501 [ + - ]: 4 : coin_control.m_max_tx_weight = TRUC_CHILD_MAX_WEIGHT;
1502 : : }
1503 [ + + + - ]: 2848 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::MAX_SEQUENCE_NONFINAL);
1504 [ + - ]: 2845 : rawTx.vin.push_back(input);
1505 : 2845 : total_input_value += output.txout.nValue;
1506 : 3027 : }
1507 : : }
1508 : :
1509 : 205 : std::vector<COutPoint> outpoints_spent;
1510 [ - + + - ]: 205 : outpoints_spent.reserve(rawTx.vin.size());
1511 : :
1512 [ + + ]: 3074 : for (const CTxIn& tx_in : rawTx.vin) {
1513 [ + - ]: 2869 : outpoints_spent.push_back(tx_in.prevout);
1514 : : }
1515 : :
1516 : : // estimate final size of tx
1517 [ + - + - ]: 205 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1518 [ + + ]: 205 : if (tx_size.vsize == -1) {
1519 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, "Unable to determine the size of the transaction, the wallet contains unsolvable descriptors");
1520 : : }
1521 [ + - ]: 203 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1522 [ + - ]: 203 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1523 [ + - ]: 203 : const CAmount actual_fee{fee_from_size + total_bump_fees.value_or(0)};
1524 : 203 : CAmount effective_value = total_input_value - actual_fee;
1525 : :
1526 [ + + ]: 203 : if (actual_fee > pwallet->m_max_tx_fee) {
1527 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1528 : : }
1529 [ + - + + ]: 201 : if (actual_fee > pwallet->m_max_tx_fee_rate.GetFee(tx_size.vsize)) {
1530 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_RATE_EXCEEDED).original);
1531 : : }
1532 : :
1533 [ + + ]: 200 : if (effective_value <= 0) {
1534 [ - + ]: 33 : if (send_max) {
1535 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1536 : : } else {
1537 [ + - + - ]: 66 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1538 : : }
1539 : : }
1540 : :
1541 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1542 [ + - ]: 167 : if (tx_size.weight > coin_control.m_max_tx_weight) {
1543 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1544 : : }
1545 : :
1546 : 164 : CAmount output_amounts_claimed{0};
1547 [ + + ]: 689 : for (const CTxOut& out : rawTx.vout) {
1548 : 525 : output_amounts_claimed += out.nValue;
1549 : : }
1550 : :
1551 [ + + ]: 164 : if (output_amounts_claimed > total_input_value) {
1552 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1553 : : }
1554 : :
1555 : 163 : const CAmount remainder{effective_value - output_amounts_claimed};
1556 [ + + ]: 163 : if (remainder < 0) {
1557 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1558 : : }
1559 : :
1560 : 162 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1561 : :
1562 : 162 : bool gave_remaining_to_first{false};
1563 [ + + ]: 679 : for (CTxOut& out : rawTx.vout) {
1564 : 520 : CTxDestination dest;
1565 [ + - ]: 520 : ExtractDestination(out.scriptPubKey, dest);
1566 [ + + ]: 520 : if (addresses_without_amount.contains(dest)) {
1567 : 514 : out.nValue = per_output_without_amount;
1568 [ + + ]: 514 : if (!gave_remaining_to_first) {
1569 : 161 : out.nValue += remainder % addresses_without_amount.size();
1570 : 161 : gave_remaining_to_first = true;
1571 : : }
1572 [ + - + - : 514 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1573 : : // Dynamically generated output amount is dust
1574 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1575 : : }
1576 : : } else {
1577 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1578 : : // Specified output amount is dust
1579 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", EncodeDestination(dest)));
+ - ]
1580 : : }
1581 : : }
1582 : 520 : }
1583 : :
1584 [ + - + + : 320 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1585 [ + + ]: 159 : if (lock_unspents) {
1586 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1587 [ + - ]: 2 : pwallet->LockCoin(txin.prevout, /*persist=*/false);
1588 : : }
1589 : : }
1590 : :
1591 [ + - + - ]: 477 : return FinishTransaction(pwallet, options, rawTx);
1592 [ + - ]: 903 : }
1593 [ + - + - : 17872 : };
+ - + - +
+ + + + +
- - - - -
- ]
1594 [ + - + - : 58084 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - -
- ]
1595 : :
1596 : 1542 : RPCMethod walletprocesspsbt()
1597 : : {
1598 : 1542 : return RPCMethod{
1599 : 1542 : "walletprocesspsbt",
1600 : : "Update a PSBT with input information from our wallet and then sign inputs\n"
1601 : 1542 : "that we can sign for." +
1602 [ + - ]: 1542 : HELP_REQUIRING_PASSPHRASE,
1603 : : {
1604 [ + - + - ]: 3084 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1605 [ + - + - : 4626 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
+ - ]
1606 [ + - + - : 4626 : {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
+ - ]
1607 : : " \"DEFAULT\"\n"
1608 : : " \"ALL\"\n"
1609 : : " \"NONE\"\n"
1610 : : " \"SINGLE\"\n"
1611 : : " \"ALL|ANYONECANPAY\"\n"
1612 : : " \"NONE|ANYONECANPAY\"\n"
1613 : : " \"SINGLE|ANYONECANPAY\""},
1614 [ + - + - : 4626 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
+ - ]
1615 [ + - + - : 4626 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
+ - ]
1616 : : },
1617 [ + - ]: 3084 : RPCResult{
1618 [ + - + - ]: 3084 : RPCResult::Type::OBJ, "", "",
1619 : : {
1620 [ + - + - ]: 3084 : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1621 [ + - + - ]: 3084 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1622 [ + - + - ]: 3084 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1623 : : }
1624 [ + - + - : 12336 : },
+ + - - ]
1625 : 1542 : RPCExamples{
1626 [ + - + - : 3084 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1627 [ + - ]: 1542 : },
1628 : 1542 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1629 : : {
1630 [ - + ]: 641 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1631 [ - + ]: 641 : if (!pwallet) return UniValue::VNULL;
1632 : :
1633 [ + - ]: 641 : const CWallet& wallet{*pwallet};
1634 : : // Make sure the results are valid at least up to the most recent block
1635 : : // the user could have gotten from another RPC command prior to now
1636 [ + - ]: 641 : wallet.BlockUntilSyncedToCurrentChain();
1637 : :
1638 : : // Unserialize the transaction
1639 [ + - + - : 641 : util::Result<PartiallySignedTransaction> psbt_res = DecodeBase64PSBT(request.params[0].get_str());
+ - ]
1640 [ + + ]: 641 : if (!psbt_res) {
1641 [ + - + - : 6 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", util::ErrorString(psbt_res).original));
+ - ]
1642 : : }
1643 [ + - ]: 639 : PartiallySignedTransaction psbtx = *psbt_res;
1644 : :
1645 : : // Get the sighash type
1646 [ + - + + ]: 639 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
1647 : :
1648 : : // Fill transaction with our data and also sign
1649 [ + - + + : 638 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1650 [ + - + + : 638 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1651 [ + - + + : 638 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1652 : 638 : bool complete = true;
1653 : :
1654 [ + + + + ]: 638 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1655 : :
1656 [ + - ]: 637 : const auto err{wallet.FillPSBT(psbtx, {.sign = sign, .sighash_type = nHashType, .finalize = finalize, .bip32_derivs = bip32derivs}, complete)};
1657 [ + + ]: 637 : if (err) {
1658 [ + - ]: 7 : throw JSONRPCPSBTError(*err);
1659 : : }
1660 : :
1661 : 630 : UniValue result(UniValue::VOBJ);
1662 : 630 : DataStream ssTx{};
1663 [ + - ]: 630 : ssTx << psbtx;
1664 [ + - + - : 1890 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1665 [ + - + - : 1260 : result.pushKV("complete", complete);
+ - ]
1666 [ + + ]: 630 : if (complete) {
1667 [ + - ]: 42 : CMutableTransaction mtx;
1668 : : // Returns true if complete, which we already think it is.
1669 [ + - + - ]: 42 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1670 : 42 : DataStream ssTx_final;
1671 [ + - ]: 42 : ssTx_final << TX_WITH_WITNESS(mtx);
1672 [ - + + - : 84 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - +
- ]
1673 : 84 : }
1674 : :
1675 : 630 : return result;
1676 : 1280 : },
1677 [ + - + - : 13878 : };
+ + - - ]
1678 [ + - + - : 24672 : }
+ - + - +
- + - + -
+ - - - -
- ]
1679 : :
1680 : 1137 : RPCMethod walletcreatefundedpsbt()
1681 : : {
1682 : 1137 : return RPCMethod{
1683 : 1137 : "walletcreatefundedpsbt",
1684 [ + - ]: 2274 : "Creates and funds a transaction in the Partially Signed Transaction format.\n"
1685 : : "Implements the Creator and Updater roles.\n"
1686 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1687 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1688 : : {
1689 [ + - + - ]: 2274 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1690 : : {
1691 [ + - + - ]: 2274 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1692 : : {
1693 [ + - + - ]: 2274 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1694 [ + - + - ]: 2274 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1695 [ + - + - : 3411 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
+ - ]
1696 [ + - + - : 3411 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
+ - ]
1697 : : "including the weight of the outpoint and sequence number. "
1698 : : "Note that signature sizes are not guaranteed to be consistent, "
1699 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1700 : : "Remember to convert serialized sizes to weight units when necessary."},
1701 : : },
1702 : : },
1703 : : },
1704 : : },
1705 [ + - + - ]: 2274 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1706 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1707 : : "At least one output of either type must be specified.\n"
1708 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1709 : : "accepted as second parameter.",
1710 [ + - ]: 2274 : OutputsDoc(),
1711 [ + - ]: 2274 : RPCArgOptions{.skip_type_check = true}},
1712 [ + - + - : 3411 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1713 [ + - + - ]: 2274 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1714 [ + - + - : 20466 : Cat<std::vector<RPCArg>>(
+ - + + +
+ - - -
- ]
1715 : : {
1716 [ + - + - : 3411 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
+ - ]
1717 [ + - + - : 3411 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
1718 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1719 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1720 [ + - + - : 3411 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
1721 [ + - + - ]: 2274 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1722 [ + - + - : 3411 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
1723 [ + - + - : 3411 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
1724 [ + - + - : 3411 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
1725 [ + - + - : 3411 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1726 [ + - + - : 3411 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1727 [ + - + - : 3411 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1728 [ + - + - : 3411 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
+ - ]
1729 [ + - + - ]: 2274 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1730 : : "The fee will be equally deducted from the amount of each specified output.\n"
1731 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1732 : : "If no outputs are specified here, the sender pays the fee.",
1733 : : {
1734 [ + - + - ]: 2274 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1735 : : },
1736 : : },
1737 [ + - + - : 3411 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
1738 : : "Transaction building will fail if this can not be satisfied."},
1739 : : },
1740 [ + - ]: 2274 : FundTxDoc()),
1741 [ + - ]: 2274 : RPCArgOptions{.oneline_description="options"}},
1742 [ + - + - : 3411 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
+ - ]
1743 [ + - + - : 3411 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1744 [ + - + - : 3411 : {"psbt_version", RPCArg::Type::NUM, RPCArg::Default(2), "The PSBT version number to use."},
+ - ]
1745 : : },
1746 [ + - ]: 2274 : RPCResult{
1747 [ + - + - ]: 2274 : RPCResult::Type::OBJ, "", "",
1748 : : {
1749 [ + - + - ]: 2274 : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1750 [ + - + - ]: 2274 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1751 [ + - + - ]: 2274 : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1752 : : }
1753 [ + - + - : 9096 : },
+ + - - ]
1754 : 1137 : RPCExamples{
1755 : : "\nCreate a PSBT with automatically picked inputs that sends 0.5 BTC to an address and has a fee rate of 2 sat/vB:\n"
1756 [ + - + - : 3411 : + HelpExampleCli("walletcreatefundedpsbt", "\"[]\" \"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" 0 \"{\\\"add_inputs\\\":true,\\\"fee_rate\\\":2}\"")
+ - + - ]
1757 : 1137 : + "\nCreate the same PSBT as the above one instead using named arguments:\n"
1758 [ + - + - : 5685 : + HelpExampleCli("-named walletcreatefundedpsbt", "outputs=\"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" add_inputs=true fee_rate=2")
+ - + - ]
1759 [ + - ]: 1137 : },
1760 : 1137 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1761 : : {
1762 : 236 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1763 [ - + ]: 236 : if (!pwallet) return UniValue::VNULL;
1764 : :
1765 [ + - ]: 236 : CWallet& wallet{*pwallet};
1766 : : // Make sure the results are valid at least up to the most recent block
1767 : : // the user could have gotten from another RPC command prior to now
1768 [ + - ]: 236 : wallet.BlockUntilSyncedToCurrentChain();
1769 : :
1770 [ + - + + : 236 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1771 : :
1772 [ + - ]: 236 : CCoinControl coin_control;
1773 [ + - ]: 236 : coin_control.m_version = self.Arg<uint32_t>("version");
1774 : :
1775 [ + - + - ]: 236 : const UniValue &replaceable_arg = options["replaceable"];
1776 [ + + + - ]: 236 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1777 [ + - + - : 236 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf, coin_control.m_version);
+ - + - ]
1778 : 236 : UniValue outputs(UniValue::VOBJ);
1779 [ + - + - ]: 236 : outputs = NormalizeOutputs(request.params[1]);
1780 : 236 : std::vector<CRecipient> recipients = CreateRecipients(
1781 [ + - ]: 472 : ParseOutputs(outputs),
1782 [ + - + - : 472 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1783 [ + - ]: 236 : );
1784 : : // Automatically select coins, unless at least one is manually selected. Can
1785 : : // be overridden by options.add_inputs.
1786 [ - + ]: 236 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1787 [ + - + + ]: 236 : SetOptionsInputWeights(request.params[0], options);
1788 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1789 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1790 : 235 : rawTx.vout.clear();
1791 [ + + ]: 235 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1792 : :
1793 : : // Make a blank psbt
1794 : 167 : uint32_t psbt_version = 2;
1795 [ + - + + ]: 167 : if (!request.params[6].isNull()) {
1796 [ + - + - ]: 5 : psbt_version = request.params[6].getInt<int>();
1797 : : }
1798 [ + + ]: 167 : if (psbt_version != 2 && psbt_version != 0) {
1799 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "The PSBT version can only be 2 or 0");
1800 : : }
1801 : :
1802 [ + - + - ]: 166 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx), psbt_version);
1803 : :
1804 : : // Fill transaction with out data but don't sign
1805 [ + - + + : 166 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1806 : 166 : bool complete = true;
1807 [ + - ]: 166 : const auto err{wallet.FillPSBT(psbtx, {.sign = false, .bip32_derivs = bip32derivs}, complete)};
1808 [ - + ]: 166 : if (err) {
1809 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1810 : : }
1811 : :
1812 : : // Serialize the PSBT
1813 : 166 : DataStream ssTx{};
1814 [ + - ]: 166 : ssTx << psbtx;
1815 : :
1816 : 166 : UniValue result(UniValue::VOBJ);
1817 [ + - + - : 498 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1818 [ + - + - : 332 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1819 [ + + + - : 332 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1820 : 166 : return result;
1821 [ + - ]: 944 : },
1822 [ + - + - : 22740 : };
+ - + - +
+ + + + +
- - - - -
- ]
1823 [ + - + - : 63672 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1824 : : } // namespace wallet
|
