Branch data Line data Source code
1 : : // Copyright (c) 2011-present The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <policy/truc_policy.h>
12 : : #include <rpc/rawtransaction_util.h>
13 : : #include <rpc/util.h>
14 : : #include <script/script.h>
15 : : #include <util/rbf.h>
16 : : #include <util/translation.h>
17 : : #include <util/vector.h>
18 : : #include <wallet/coincontrol.h>
19 : : #include <wallet/feebumper.h>
20 : : #include <wallet/fees.h>
21 : : #include <wallet/rpc/util.h>
22 : : #include <wallet/spend.h>
23 : : #include <wallet/wallet.h>
24 : :
25 : : #include <univalue.h>
26 : :
27 : : using common::FeeModeFromString;
28 : : using common::FeeModesDetail;
29 : : using common::InvalidEstimateModeErrorMessage;
30 : : using common::StringForFeeReason;
31 : : using common::TransactionErrorString;
32 : : using node::TransactionError;
33 : :
34 : : namespace wallet {
35 : 1953 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
36 : : {
37 : 1953 : std::vector<CRecipient> recipients;
38 [ - + + + ]: 22986 : for (size_t i = 0; i < outputs.size(); ++i) {
39 [ + - + - ]: 21033 : const auto& [destination, amount] = outputs.at(i);
40 [ + - ]: 42066 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
41 [ + - ]: 21033 : recipients.push_back(recipient);
42 : 21033 : }
43 : 1953 : return recipients;
44 : 0 : }
45 : :
46 : 394 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
47 : : {
48 [ + - + - : 1159 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
49 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
50 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
51 : : }
52 : : } else {
53 [ + - + - ]: 740 : options.pushKV("conf_target", conf_target);
54 [ + - + - ]: 740 : options.pushKV("estimate_mode", estimate_mode);
55 : : }
56 [ + + ]: 782 : if (options.exists("fee_rate")) {
57 [ + + ]: 28 : if (!fee_rate.isNull()) {
58 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
59 : : }
60 : : } else {
61 [ + - + - ]: 726 : options.pushKV("fee_rate", fee_rate);
62 : : }
63 [ + - + - : 838 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
64 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
65 : : }
66 : 390 : }
67 : :
68 : 750 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
69 : : {
70 [ + + ]: 750 : std::set<int> sffo_set;
71 [ + + ]: 750 : if (sffo_instructions.isNull()) return sffo_set;
72 : :
73 [ + - + + ]: 200 : for (const auto& sffo : sffo_instructions.getValues()) {
74 : 105 : int pos{-1};
75 [ + + ]: 105 : if (sffo.isStr()) {
76 [ + - ]: 9 : auto it = find(destinations.begin(), destinations.end(), sffo.get_str());
77 [ + + + - : 10 : if (it == destinations.end()) throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', destination %s not found in tx outputs", sffo.get_str()));
+ - + - ]
78 : 8 : pos = it - destinations.begin();
79 [ + + ]: 96 : } else if (sffo.isNum()) {
80 [ + - ]: 95 : pos = sffo.getInt<int>();
81 : : } else {
82 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', invalid value type: %s", uvTypeName(sffo.type())));
+ - ]
83 : : }
84 : :
85 [ + + ]: 103 : if (sffo_set.contains(pos))
86 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', duplicated position: %d", pos));
87 [ + + ]: 101 : if (pos < 0)
88 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', negative position: %d", pos));
89 [ - + + + ]: 100 : if (pos >= int(destinations.size()))
90 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', position too large: %d", pos));
91 [ + - ]: 99 : sffo_set.insert(pos);
92 : : }
93 : : return sffo_set;
94 : 6 : }
95 : :
96 : 249 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, CMutableTransaction& rawTx)
97 : : {
98 : 498 : bool can_anti_fee_snipe = !options.exists("locktime");
99 : :
100 [ + + ]: 1663 : for (const CTxIn& tx_in : rawTx.vin) {
101 : : // Checks sequence values consistent with DiscourageFeeSniping
102 [ + + + + ]: 1427 : can_anti_fee_snipe = can_anti_fee_snipe && (tx_in.nSequence == CTxIn::MAX_SEQUENCE_NONFINAL || tx_in.nSequence == MAX_BIP125_RBF_SEQUENCE);
103 : : }
104 : :
105 [ + + ]: 249 : if (can_anti_fee_snipe) {
106 : 238 : LOCK(pwallet->cs_wallet);
107 : 238 : FastRandomContext rng_fast;
108 [ + - ]: 238 : DiscourageFeeSniping(rawTx, rng_fast, pwallet->chain(), pwallet->GetLastBlockHash(), pwallet->GetLastBlockHeight());
109 [ + - ]: 476 : }
110 : :
111 : : // Make a blank psbt
112 : 249 : PartiallySignedTransaction psbtx(rawTx, /*version=*/2);
113 : :
114 : : // First fill transaction with our data without signing,
115 : : // so external signers are not asked to sign more than once.
116 : 249 : bool complete;
117 [ + - ]: 249 : pwallet->FillPSBT(psbtx, {.sign = false, .bip32_derivs = true}, complete);
118 [ + - ]: 249 : const auto err{pwallet->FillPSBT(psbtx, {.sign = true, .bip32_derivs = false}, complete)};
119 [ + + ]: 249 : if (err) {
120 [ + - ]: 1 : throw JSONRPCPSBTError(*err);
121 : : }
122 : :
123 [ + - ]: 248 : CMutableTransaction mtx;
124 [ + - ]: 248 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
125 : :
126 : 248 : UniValue result(UniValue::VOBJ);
127 : :
128 [ + - + - : 269 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
129 [ + - + + : 534 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
130 [ + + + + : 248 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
131 : : // Serialize the PSBT
132 : 63 : DataStream ssTx{};
133 [ + - ]: 63 : ssTx << psbtx;
134 [ + - + - : 189 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
135 : 63 : }
136 : :
137 [ + + ]: 248 : if (complete) {
138 [ + - + - ]: 222 : std::string hex{EncodeHexTx(CTransaction(mtx))};
139 [ + - ]: 222 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
140 [ + - + - : 444 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
141 [ + + ]: 222 : if (add_to_wallet && !psbt_opt_in) {
142 [ + - + - ]: 555 : pwallet->CommitTransaction(tx, {}, /*orderForm=*/{});
143 : : } else {
144 [ + - + - : 74 : result.pushKV("hex", hex);
+ - ]
145 : : }
146 : 222 : }
147 [ + - + - : 496 : result.pushKV("complete", complete);
+ - ]
148 : :
149 : 496 : return result;
150 : 249 : }
151 : :
152 : 390 : static void PreventOutdatedOptions(const UniValue& options)
153 : : {
154 [ + + ]: 780 : if (options.exists("feeRate")) {
155 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
156 : : }
157 [ - + ]: 778 : if (options.exists("changeAddress")) {
158 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
159 : : }
160 [ - + ]: 778 : if (options.exists("changePosition")) {
161 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
162 : : }
163 [ - + ]: 778 : if (options.exists("lockUnspents")) {
164 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
165 : : }
166 [ - + ]: 778 : if (options.exists("subtractFeeFromOutputs")) {
167 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
168 : : }
169 : 389 : }
170 : :
171 : 1264 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, mapValue_t map_value, bool verbose)
172 : : {
173 : 1264 : EnsureWalletIsUnlocked(wallet);
174 : :
175 : : // This function is only used by sendtoaddress and sendmany.
176 : : // This should always try to sign, if we don't have (all) private keys, don't
177 : : // try to do anything here.
178 [ + + ]: 1264 : if (wallet.IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
179 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: sendtoaddress and sendmany are not supported for wallets with external signers; use send instead");
180 : : }
181 [ + + ]: 1262 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
182 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
183 : : }
184 : :
185 : : // Shuffle recipient list
186 : 1261 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
187 : :
188 : : // Send
189 : 1261 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
190 [ + + ]: 1261 : if (!res) {
191 [ + - + - ]: 34 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
192 : : }
193 : 1244 : const CTransactionRef& tx = res->tx;
194 [ + - + - ]: 3732 : wallet.CommitTransaction(tx, std::move(map_value), /*orderForm=*/{});
195 [ + + ]: 1244 : if (verbose) {
196 : 6 : UniValue entry(UniValue::VOBJ);
197 [ + - + - : 12 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
198 [ + - + - : 12 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_calc.reason));
+ - + - ]
199 : 6 : return entry;
200 : 0 : }
201 [ + - + - ]: 1238 : return tx->GetHash().GetHex();
202 : 1244 : }
203 : :
204 : :
205 : : /**
206 : : * Update coin control with fee estimation based on the given parameters
207 : : *
208 : : * @param[in] wallet Wallet reference
209 : : * @param[in,out] cc Coin control to be updated
210 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees/block_policy_estimator.h;
211 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
212 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
213 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
214 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
215 : : * verify only that fee_rate is greater than 0
216 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
217 : : */
218 : 2132 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
219 : : {
220 [ + + ]: 2132 : if (!fee_rate.isNull()) {
221 [ + + ]: 548 : if (!conf_target.isNull()) {
222 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
223 : : }
224 [ + + + + ]: 545 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
225 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
226 : : }
227 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
228 [ - + ]: 542 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
229 [ + + ]: 466 : if (override_min_fee) cc.fOverrideFeeRate = true;
230 : : // Default RBF to true for explicit fee_rate, if unset.
231 [ + + ]: 466 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
232 : 466 : return;
233 : : }
234 [ + + - + : 1584 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
+ + ]
235 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
236 : : }
237 [ + + ]: 1557 : if (!conf_target.isNull()) {
238 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().estimateMaxBlocks());
239 : : }
240 : : }
241 : :
242 : 2052 : RPCMethod sendtoaddress()
243 : : {
244 : 2052 : return RPCMethod{
245 : 2052 : "sendtoaddress",
246 : 2052 : "Send an amount to a given address." +
247 [ + - ]: 2052 : HELP_REQUIRING_PASSPHRASE,
248 : : {
249 [ + - + - ]: 4104 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
250 [ + - + - ]: 4104 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
251 [ + - + - ]: 4104 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
252 : : "This is not part of the transaction, just kept in your wallet."},
253 [ + - + - ]: 4104 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
254 : : "to which you're sending the transaction. This is not part of the \n"
255 : : "transaction, just kept in your wallet."},
256 [ + - + - : 6156 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
+ - ]
257 : : "The recipient will receive less bitcoins than you enter in the amount field."},
258 [ + - + - : 6156 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
+ - ]
259 [ + - + - : 6156 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
260 [ + - + - ]: 4104 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
261 [ + - + - : 4104 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
262 [ + - + - : 6156 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
+ - ]
263 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
264 [ + - + - : 6156 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
265 [ + - + - : 6156 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
+ - ]
266 : : },
267 : : {
268 [ + - ]: 2052 : RPCResult{"if verbose is not set or set to false",
269 [ + - + - ]: 4104 : RPCResult::Type::STR_HEX, "txid", "The transaction id."
270 : 2052 : },
271 [ + - ]: 4104 : RPCResult{"if verbose is set to true",
272 [ + - + - ]: 4104 : RPCResult::Type::OBJ, "", "",
273 : : {
274 [ + - + - ]: 4104 : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
275 [ + - + - ]: 4104 : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
276 : : },
277 [ + - + + : 12312 : },
- - ]
278 : : },
279 : 2052 : RPCExamples{
280 : : "\nSend 0.1 BTC\n"
281 [ + - + - : 6156 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
282 : 2052 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
283 [ + - + - : 10260 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
284 [ + - ]: 4104 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
285 [ + - + - : 10260 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
286 : 2052 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
287 [ + - + - : 10260 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
288 [ + - ]: 4104 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
289 [ + - + - : 10260 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
290 [ + - + - : 8208 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
291 [ + - ]: 2052 : },
292 : 2052 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
293 : : {
294 : 1213 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
295 [ - + ]: 1213 : if (!pwallet) return UniValue::VNULL;
296 : :
297 : : // Make sure the results are valid at least up to the most recent block
298 : : // the user could have gotten from another RPC command prior to now
299 [ + - ]: 1213 : pwallet->BlockUntilSyncedToCurrentChain();
300 : :
301 [ + - ]: 1213 : LOCK(pwallet->cs_wallet);
302 : :
303 : : // Wallet comments
304 [ + - ]: 1213 : mapValue_t mapValue;
305 [ + - + + : 1213 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
306 [ + - + - : 2 : mapValue["comment"] = request.params[2].get_str();
+ - + - +
- ]
307 [ + - + + : 1213 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
308 [ + - + - : 2 : mapValue["to"] = request.params[3].get_str();
+ - + - +
- ]
309 : :
310 [ + - ]: 1213 : CCoinControl coin_control;
311 [ + - + + ]: 1213 : if (!request.params[5].isNull()) {
312 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
313 : : }
314 : :
315 [ + - + - ]: 1213 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
316 : : // We also enable partial spend avoidance if reuse avoidance is set.
317 : 1213 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
318 : :
319 [ + - + - : 1213 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
320 : :
321 [ + + ]: 1213 : EnsureWalletIsUnlocked(*pwallet);
322 : :
323 : 1212 : UniValue address_amounts(UniValue::VOBJ);
324 [ + - + - : 1212 : const std::string address = request.params[0].get_str();
- + ]
325 [ + - + - : 3636 : address_amounts.pushKV(address, request.params[1]);
+ - ]
326 : :
327 [ + - ]: 1212 : std::set<int> sffo_set;
328 [ + - + + : 1212 : if (!request.params[4].isNull() && request.params[4].get_bool()) {
+ - + - +
+ ]
329 [ + - ]: 216 : sffo_set.insert(0);
330 : : }
331 : :
332 [ + + + - ]: 1212 : std::vector<CRecipient> recipients{CreateRecipients(ParseOutputs(address_amounts), sffo_set)};
333 [ + - + + : 1210 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
334 : :
335 [ + - + + ]: 1217 : return SendMoney(*pwallet, coin_control, recipients, mapValue, verbose);
336 [ + - ]: 3664 : },
337 [ + - + - : 41040 : };
+ - + - +
+ + + - -
- - ]
338 [ + - + - : 61560 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- - - - -
- - ]
339 : :
340 : 922 : RPCMethod sendmany()
341 : : {
342 : 922 : return RPCMethod{"sendmany",
343 : 922 : "Send multiple times. Amounts are double-precision floating point numbers." +
344 [ + - ]: 922 : HELP_REQUIRING_PASSPHRASE,
345 : : {
346 [ + - + - : 2766 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
+ - ]
347 [ + - ]: 1844 : RPCArgOptions{
348 : : .oneline_description = "\"\"",
349 : : }},
350 [ + - + - ]: 1844 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
351 : : {
352 [ + - + - ]: 1844 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
353 : : },
354 : : },
355 [ + - + - ]: 1844 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value"},
356 [ + - + - ]: 1844 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
357 [ + - + - ]: 1844 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
358 : : "The fee will be equally deducted from the amount of each selected address.\n"
359 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
360 : : "If no addresses are specified here, the sender pays the fee.",
361 : : {
362 [ + - + - ]: 1844 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
363 : : },
364 : : },
365 [ + - + - : 2766 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
+ - ]
366 [ + - + - : 2766 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
367 [ + - + - ]: 1844 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
368 [ + - + - : 1844 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
369 [ + - + - : 2766 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
370 [ + - + - : 2766 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
+ - ]
371 : : },
372 : : {
373 [ + - ]: 922 : RPCResult{"if verbose is not set or set to false",
374 [ + - + - ]: 1844 : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
375 : : "the number of addresses."
376 : 922 : },
377 [ + - ]: 1844 : RPCResult{"if verbose is set to true",
378 [ + - + - ]: 1844 : RPCResult::Type::OBJ, "", "",
379 : : {
380 [ + - + - ]: 1844 : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
381 : : "the number of addresses."},
382 [ + - + - ]: 1844 : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
383 : : },
384 [ + - + + : 5532 : },
- - ]
385 : : },
386 : 922 : RPCExamples{
387 : : "\nSend two amounts to two different addresses:\n"
388 [ + - + - : 3688 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
389 : 922 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
390 [ + - + - : 5532 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
391 : 922 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
392 [ + - + - : 7376 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
393 : 922 : "\nAs a JSON-RPC call\n"
394 [ + - + - : 4610 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
395 [ + - ]: 922 : },
396 : 922 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
397 : : {
398 : 83 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
399 [ - + ]: 83 : if (!pwallet) return UniValue::VNULL;
400 : :
401 : : // Make sure the results are valid at least up to the most recent block
402 : : // the user could have gotten from another RPC command prior to now
403 [ + - ]: 83 : pwallet->BlockUntilSyncedToCurrentChain();
404 : :
405 [ + - ]: 83 : LOCK(pwallet->cs_wallet);
406 : :
407 [ + - + + : 83 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
408 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
409 : : }
410 [ + - + - : 83 : UniValue sendTo = request.params[1].get_obj();
+ - ]
411 : :
412 [ + - ]: 83 : mapValue_t mapValue;
413 [ + - + + : 83 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
414 [ # # # # : 0 : mapValue["comment"] = request.params[3].get_str();
# # # # #
# ]
415 : :
416 [ + - ]: 83 : CCoinControl coin_control;
417 [ + - - + ]: 83 : if (!request.params[5].isNull()) {
418 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
419 : : }
420 : :
421 [ + - + - : 83 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
422 : :
423 : 60 : std::vector<CRecipient> recipients = CreateRecipients(
424 [ + - ]: 108 : ParseOutputs(sendTo),
425 [ + - + - : 60 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ + ]
426 [ + - ]: 54 : );
427 [ + - + + : 54 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
428 : :
429 [ + + ]: 67 : return SendMoney(*pwallet, coin_control, recipients, std::move(mapValue), verbose);
430 [ + - ]: 262 : },
431 [ + - + - : 23050 : };
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
432 [ + - + - : 28582 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - - -
- - - - ]
433 : :
434 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
435 : 4225 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
436 : : {
437 : 4225 : std::vector<RPCArg> args = {
438 [ + - + - : 12675 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
+ - + - ]
439 [ + - + - ]: 8450 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
440 [ + - + - : 8450 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - + - ]
441 : : {
442 [ + - + - : 12675 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
+ - ]
443 : : "Allows this transaction to be replaced by a transaction with higher fees"
444 : : },
445 [ + - + + : 21125 : };
- - ]
446 [ + - ]: 4225 : if (solving_data) {
447 [ + - + - : 71825 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
448 : : "Used for fee estimation during coin selection.",
449 : : {
450 : : {
451 [ + - + - ]: 8450 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
452 : : {
453 [ + - + - ]: 8450 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
454 : : }
455 : : },
456 : : {
457 [ + - + - ]: 8450 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
458 : : {
459 [ + - + - ]: 8450 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
460 : : }
461 : : },
462 : : {
463 [ + - + - ]: 8450 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
464 : : {
465 [ + - + - ]: 8450 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
466 : : }
467 : : },
468 : : }
469 : : });
470 : : }
471 : 4225 : return args;
472 [ + - + - : 71825 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
473 : :
474 : 687 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
475 : : {
476 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
477 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
478 : 687 : CHECK_NONFATAL(tx.vout.empty());
479 : : // Make sure the results are valid at least up to the most recent block
480 : : // the user could have gotten from another RPC command prior to now
481 : 687 : wallet.BlockUntilSyncedToCurrentChain();
482 : :
483 : 687 : std::optional<unsigned int> change_position;
484 : 687 : bool lockUnspents = false;
485 [ + + ]: 687 : if (!options.isNull()) {
486 [ + + ]: 652 : if (options.type() == UniValue::VBOOL) {
487 : : // backward compatibility bool only fallback, does nothing
488 : : } else {
489 [ + + + + : 18902 : RPCTypeCheckObj(options,
+ + ]
490 : : {
491 [ + - ]: 651 : {"add_inputs", UniValueType(UniValue::VBOOL)},
492 [ + - ]: 651 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
493 [ + - ]: 651 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
494 [ + - ]: 651 : {"changeAddress", UniValueType(UniValue::VSTR)},
495 [ + - ]: 651 : {"change_address", UniValueType(UniValue::VSTR)},
496 [ + - ]: 651 : {"changePosition", UniValueType(UniValue::VNUM)},
497 [ + - ]: 651 : {"change_position", UniValueType(UniValue::VNUM)},
498 [ + - ]: 651 : {"change_type", UniValueType(UniValue::VSTR)},
499 [ + - ]: 651 : {"includeWatching", UniValueType(UniValue::VBOOL)},
500 [ + - ]: 651 : {"include_watching", UniValueType(UniValue::VBOOL)},
501 [ + - ]: 651 : {"inputs", UniValueType(UniValue::VARR)},
502 [ + - ]: 651 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
503 [ + - ]: 651 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
504 [ + - ]: 651 : {"locktime", UniValueType(UniValue::VNUM)},
505 [ + - ]: 651 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
506 [ + - ]: 651 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
507 [ + - ]: 651 : {"psbt", UniValueType(UniValue::VBOOL)},
508 [ + - ]: 651 : {"solving_data", UniValueType(UniValue::VOBJ)},
509 [ + - ]: 651 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
510 [ + - ]: 651 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
511 [ + - ]: 651 : {"replaceable", UniValueType(UniValue::VBOOL)},
512 [ + - ]: 651 : {"conf_target", UniValueType(UniValue::VNUM)},
513 [ + - ]: 651 : {"estimate_mode", UniValueType(UniValue::VSTR)},
514 [ + - ]: 651 : {"minconf", UniValueType(UniValue::VNUM)},
515 [ + - ]: 651 : {"maxconf", UniValueType(UniValue::VNUM)},
516 [ + - ]: 651 : {"input_weights", UniValueType(UniValue::VARR)},
517 [ + - ]: 651 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
518 : : },
519 : : true, true);
520 : :
521 [ + + ]: 1256 : if (options.exists("add_inputs")) {
522 [ + - + - ]: 174 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
523 : : }
524 : :
525 [ + - + - : 1875 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
526 [ + + + - : 52 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - - +
+ + + + -
- - - ]
527 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
528 : :
529 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
530 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
531 : : }
532 : :
533 [ + - ]: 22 : coinControl.destChange = dest;
534 : 15 : }
535 : :
536 [ + - + - : 1851 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
537 [ + + + - : 180 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
538 [ + - - + : 60 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
+ + ]
539 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
540 : : }
541 : 59 : change_position = (unsigned int)pos;
542 : : }
543 : :
544 [ + + ]: 1250 : if (options.exists("change_type")) {
545 [ + - + - : 296 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
546 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
547 : : }
548 [ + - + + : 196 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
- + + - +
+ ]
549 [ - + ]: 192 : coinControl.m_change_type.emplace(parsed.value());
550 : : } else {
551 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
552 : : }
553 : : }
554 : :
555 [ + - + - : 1863 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
556 [ + + + - : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + +
+ + - - -
- ]
557 : : }
558 : :
559 [ + + ]: 1244 : if (options.exists("include_unsafe")) {
560 [ + - + - ]: 46 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
561 : : }
562 : :
563 [ + + ]: 1244 : if (options.exists("feeRate")) {
564 [ + + ]: 116 : if (options.exists("fee_rate")) {
565 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
566 : : }
567 [ + + ]: 112 : if (options.exists("conf_target")) {
568 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
569 : : }
570 [ + + ]: 108 : if (options.exists("estimate_mode")) {
571 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
572 : : }
573 [ + - + + : 104 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
- + ]
574 : 36 : coinControl.fOverrideFeeRate = true;
575 : : }
576 : :
577 [ + + ]: 1200 : if (options.exists("replaceable")) {
578 [ + - + - ]: 5 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
579 : : }
580 : :
581 [ + + ]: 1200 : if (options.exists("minconf")) {
582 [ + - + - ]: 9 : coinControl.m_min_depth = options["minconf"].getInt<int>();
583 : :
584 [ + + ]: 9 : if (coinControl.m_min_depth < 0) {
585 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
586 : : }
587 : : }
588 : :
589 [ + + ]: 1198 : if (options.exists("maxconf")) {
590 [ + - + - ]: 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
591 : :
592 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
593 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
594 : : }
595 : : }
596 [ + - + - : 1392 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + + ]
597 : : }
598 : : }
599 : :
600 [ + + ]: 1076 : if (options.exists("solving_data")) {
601 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
602 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
603 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
604 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
605 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
606 : : // Add witness script for pubkeys
607 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
608 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
609 : 3 : }
610 : : }
611 : :
612 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
613 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
614 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
615 [ - + + - : 6 : if (!IsHex(script_str)) {
+ + ]
616 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
617 : : }
618 [ - + + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
619 : 5 : const CScript script(script_data.begin(), script_data.end());
620 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
621 : 5 : }
622 : : }
623 : :
624 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
625 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
626 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
627 : 8 : FlatSigningProvider desc_out;
628 [ - + ]: 8 : std::string error;
629 : 8 : std::vector<CScript> scripts_temp;
630 [ - + + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
631 [ + + ]: 8 : if (descs.empty()) {
632 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
633 : : }
634 [ + + ]: 14 : for (auto& desc : descs) {
635 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
636 : : }
637 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
638 : 10 : }
639 : : }
640 : 14 : }
641 : :
642 [ + + ]: 1068 : if (options.exists("input_weights")) {
643 [ + - + - : 2625 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
644 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
645 : :
646 : 2491 : const UniValue& vout_v = input.find_value("vout");
647 [ + + ]: 2491 : if (!vout_v.isNum()) {
648 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
649 : : }
650 : 2490 : int vout = vout_v.getInt<int>();
651 [ + + ]: 2490 : if (vout < 0) {
652 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
653 : : }
654 : :
655 : 2489 : const UniValue& weight_v = input.find_value("weight");
656 [ + + ]: 2489 : if (!weight_v.isNum()) {
657 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
658 : : }
659 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
660 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
661 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
662 [ + + ]: 2488 : if (weight < min_input_weight) {
663 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
664 : : }
665 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
666 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
667 : : }
668 : :
669 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
670 : : }
671 : : }
672 : :
673 [ + + ]: 1056 : if (options.exists("max_tx_weight")) {
674 [ + - + - ]: 10 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
675 : : }
676 : :
677 [ + + ]: 528 : if (tx.version == TRUC_VERSION) {
678 [ + + - + ]: 36 : if (!coinControl.m_max_tx_weight.has_value() || coinControl.m_max_tx_weight.value() > TRUC_MAX_WEIGHT) {
679 [ - + ]: 34 : coinControl.m_max_tx_weight = TRUC_MAX_WEIGHT;
680 : : }
681 : : }
682 : :
683 [ - + ]: 528 : if (recipients.empty())
684 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
685 : :
686 [ + - ]: 528 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
687 [ + + ]: 528 : if (!txr) {
688 [ + - + - ]: 182 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
689 : : }
690 : 437 : return *txr;
691 [ + - + - : 1111 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
692 : :
693 : 445 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
694 : : {
695 [ + + ]: 890 : if (options.exists("input_weights")) {
696 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
697 : : }
698 [ - + + + ]: 443 : if (inputs.size() == 0) {
699 : : return;
700 : : }
701 : 170 : UniValue weights(UniValue::VARR);
702 [ + - + + ]: 2955 : for (const UniValue& input : inputs.getValues()) {
703 [ + - + + ]: 5570 : if (input.exists("weight")) {
704 [ + - + - ]: 6 : weights.push_back(input);
705 : : }
706 : : }
707 [ + - + - ]: 340 : options.pushKV("input_weights", std::move(weights));
708 : 170 : }
709 : :
710 : 1083 : RPCMethod fundrawtransaction()
711 : : {
712 : 1083 : return RPCMethod{
713 : 1083 : "fundrawtransaction",
714 [ + - ]: 2166 : "If the transaction has no inputs, they will be automatically selected to meet its out value.\n"
715 : : "It will add at most one change output to the outputs.\n"
716 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
717 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
718 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
719 : : "or signrawtransactionwithwallet for that.\n"
720 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
721 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
722 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
723 : : "in the wallet using importdescriptors (to calculate fees).\n"
724 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
725 : : "Note that if specifying an exact fee rate, the resulting transaction may have a higher fee rate\n"
726 : : "if the transaction has unconfirmed inputs. This is because the wallet will attempt to make the\n"
727 : : "entire package have the given fee rate, not the resulting transaction.\n",
728 : : {
729 [ + - + - ]: 2166 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
730 [ + - + - ]: 2166 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
731 [ + - + - : 29241 : Cat<std::vector<RPCArg>>(
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
732 : : {
733 [ + - + - : 3249 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
+ - ]
734 [ + - + - : 3249 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
735 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
736 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
737 [ + - + - : 3249 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
738 [ + - + - ]: 2166 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
739 [ + - + - : 3249 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
740 [ + - + - : 3249 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
741 [ + - + - : 3249 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
742 [ + - + - : 3249 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
743 [ + - + - : 3249 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
744 [ + - + - : 3249 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
745 [ + - + - : 3249 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
+ - ]
746 [ + - + - ]: 2166 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
747 : : "The fee will be equally deducted from the amount of each specified output.\n"
748 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
749 : : "If no outputs are specified here, the sender pays the fee.",
750 : : {
751 [ + - + - ]: 2166 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
752 : : },
753 : : },
754 [ + - + - ]: 2166 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
755 : : {
756 [ + - + - ]: 2166 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
757 : : {
758 [ + - + - ]: 2166 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
759 [ + - + - ]: 2166 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
760 [ + - + - ]: 2166 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
761 : : "including the weight of the outpoint and sequence number. "
762 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
763 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
764 : : "Remember to convert serialized sizes to weight units when necessary."},
765 : : },
766 : : },
767 : : },
768 : : },
769 [ + - + - : 3249 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
770 : : "Transaction building will fail if this can not be satisfied."},
771 : : },
772 [ + - ]: 2166 : FundTxDoc()),
773 [ + - ]: 2166 : RPCArgOptions{
774 : : .skip_type_check = true,
775 : : .oneline_description = "options",
776 : : }},
777 [ + - + - : 3249 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
+ - ]
778 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
779 : : "If true, only witness deserialization will be tried.\n"
780 : : "If false, only non-witness deserialization will be tried.\n"
781 : : "This boolean should reflect whether the transaction has inputs\n"
782 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
783 : : },
784 : : },
785 [ + - ]: 2166 : RPCResult{
786 [ + - + - ]: 2166 : RPCResult::Type::OBJ, "", "",
787 : : {
788 [ + - + - ]: 2166 : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
789 [ + - + - ]: 2166 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
790 [ + - + - ]: 2166 : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
791 : : }
792 [ + - + - : 8664 : },
+ + - - ]
793 : 1083 : RPCExamples{
794 : : "\nCreate a transaction with no inputs\n"
795 [ + - + - : 2166 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
796 : 1083 : "\nAdd sufficient unsigned inputs to meet the output value\n"
797 [ + - + - : 4332 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
798 : 1083 : "\nSign the transaction\n"
799 [ + - + - : 4332 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
800 : 1083 : "\nSend the transaction\n"
801 [ + - + - : 4332 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
802 [ + - ]: 1083 : },
803 : 1083 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
804 : : {
805 : 244 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
806 [ - + ]: 244 : if (!pwallet) return UniValue::VNULL;
807 : :
808 : : // parse hex string from parameter
809 [ + - ]: 244 : CMutableTransaction tx;
810 [ + - - + : 244 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
811 [ + - - + : 244 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
812 [ + - + - : 244 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
813 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
814 : : }
815 [ + - + - ]: 244 : UniValue options = request.params[1];
816 : 244 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
817 [ + + ]: 11711 : for (const auto& tx_out : tx.vout) {
818 : 11467 : CTxDestination dest;
819 [ + - ]: 11467 : ExtractDestination(tx_out.scriptPubKey, dest);
820 [ + - ]: 11467 : destinations.emplace_back(dest, tx_out.nValue);
821 : 11467 : }
822 [ + - + - ]: 488 : std::vector<std::string> dummy(destinations.size(), "dummy");
823 : 244 : std::vector<CRecipient> recipients = CreateRecipients(
824 : : destinations,
825 [ + - + - : 488 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
826 [ + - ]: 244 : );
827 [ + - ]: 244 : CCoinControl coin_control;
828 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
829 : 244 : coin_control.m_allow_other_inputs = true;
830 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
831 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
832 : 244 : tx.vout.clear();
833 [ + + ]: 244 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
834 : :
835 : 145 : UniValue result(UniValue::VOBJ);
836 [ + - + - : 290 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
837 [ + - + - : 290 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
838 [ + + + - : 290 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
839 : :
840 : 145 : return result;
841 [ + - ]: 1174 : },
842 [ + - + - : 7581 : };
+ + - - ]
843 [ + - + - : 53067 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- - - - -
- - - - ]
844 : :
845 : 1170 : RPCMethod signrawtransactionwithwallet()
846 : : {
847 : 1170 : return RPCMethod{
848 : 1170 : "signrawtransactionwithwallet",
849 : : "Sign inputs for raw transaction (serialized, hex-encoded).\n"
850 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
851 : 1170 : "this transaction depends on but may not yet be in the block chain." +
852 [ + - ]: 1170 : HELP_REQUIRING_PASSPHRASE,
853 : : {
854 [ + - + - ]: 2340 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
855 [ + - + - ]: 2340 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
856 : : {
857 [ + - + - ]: 2340 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
858 : : {
859 [ + - + - ]: 2340 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
860 [ + - + - ]: 2340 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
861 [ + - + - ]: 2340 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
862 [ + - + - ]: 2340 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
863 [ + - + - ]: 2340 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
864 [ + - + - ]: 2340 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
865 : : },
866 : : },
867 : : },
868 : : },
869 [ + - + - : 3510 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
+ - ]
870 : : " \"DEFAULT\"\n"
871 : : " \"ALL\"\n"
872 : : " \"NONE\"\n"
873 : : " \"SINGLE\"\n"
874 : : " \"ALL|ANYONECANPAY\"\n"
875 : : " \"NONE|ANYONECANPAY\"\n"
876 : : " \"SINGLE|ANYONECANPAY\""},
877 : : },
878 [ + - ]: 2340 : RPCResult{
879 [ + - + - ]: 2340 : RPCResult::Type::OBJ, "", "",
880 : : {
881 [ + - + - ]: 2340 : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
882 [ + - + - ]: 2340 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
883 [ + - + - ]: 2340 : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
884 : : {
885 [ + - + - ]: 2340 : {RPCResult::Type::OBJ, "", "",
886 : : {
887 [ + - + - ]: 2340 : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
888 [ + - + - ]: 2340 : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
889 [ + - + - ]: 2340 : {RPCResult::Type::ARR, "witness", "",
890 : : {
891 [ + - + - ]: 2340 : {RPCResult::Type::STR_HEX, "witness", ""},
892 : : }},
893 [ + - + - ]: 2340 : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
894 [ + - + - ]: 2340 : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
895 [ + - + - ]: 3510 : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
896 : : }},
897 : : }},
898 : : }
899 [ + - + - : 31590 : },
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
900 : 1170 : RPCExamples{
901 [ + - + - : 2340 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
902 [ + - + - : 4680 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
903 [ + - ]: 1170 : },
904 : 1170 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
905 : : {
906 [ - + ]: 331 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
907 [ - + ]: 331 : if (!pwallet) return UniValue::VNULL;
908 : :
909 [ + - ]: 331 : CMutableTransaction mtx;
910 [ + - + - : 331 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
911 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
912 : : }
913 : :
914 : : // Sign the transaction
915 [ + - ]: 331 : LOCK(pwallet->cs_wallet);
916 [ + + ]: 331 : EnsureWalletIsUnlocked(*pwallet);
917 : :
918 : : // Fetch previous transactions (inputs):
919 : 330 : std::map<COutPoint, Coin> coins;
920 [ + + ]: 1118 : for (const CTxIn& txin : mtx.vin) {
921 [ + - ]: 788 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
922 : : }
923 [ + - ]: 330 : pwallet->chain().findCoins(coins);
924 : :
925 : : // Parse the prevtxs array
926 [ + - + + ]: 330 : ParsePrevouts(request.params[1], nullptr, coins);
927 : :
928 [ + - + + ]: 321 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
929 [ + + ]: 320 : if (!nHashType) {
930 : 317 : nHashType = SIGHASH_DEFAULT;
931 : : }
932 : :
933 : : // Script verification errors
934 [ + - ]: 320 : std::map<int, bilingual_str> input_errors;
935 : :
936 [ + - ]: 320 : bool complete = pwallet->SignTransaction(mtx, coins, *nHashType, input_errors);
937 : 320 : UniValue result(UniValue::VOBJ);
938 [ + + ]: 320 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
939 : 318 : return result;
940 [ + - ]: 1314 : },
941 [ + - + - : 21060 : };
+ - + - +
+ + + + +
- - - - -
- ]
942 [ + - + - : 49140 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - - -
- - - - -
- ]
943 : :
944 : : // Definition of allowed formats of specifying transaction outputs in
945 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
946 : 3968 : static std::vector<RPCArg> OutputsDoc()
947 : : {
948 : 3968 : return
949 : : {
950 [ + - + - ]: 7936 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
951 : : {
952 [ + - ]: 7936 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
953 [ + - ]: 7936 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
954 : : },
955 : : },
956 [ + - + - ]: 7936 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
957 : : {
958 [ + - + - ]: 7936 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data that becomes a part of an OP_RETURN output"},
959 : : },
960 : : },
961 [ + - + - : 43648 : };
+ - + + +
+ + + - -
- - - - ]
962 [ + - + - : 31744 : }
+ - + - -
- ]
963 : :
964 : 1839 : static RPCMethod bumpfee_helper(std::string method_name)
965 : : {
966 : 1839 : const bool want_psbt = method_name == "psbtbumpfee";
967 : 1839 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeRateFormat::SAT_VB)};
968 : :
969 [ - + ]: 1839 : return RPCMethod{method_name,
970 : : "Bumps the fee of a transaction T, replacing it with a new transaction B.\n"
971 [ + - + - ]: 3678 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
972 : : "A transaction with the given txid must be in the wallet.\n"
973 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
974 : : "It may add a new change output if one does not already exist.\n"
975 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
976 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
977 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
978 : : "The user can specify a confirmation target for estimatesmartfee.\n"
979 [ + - ]: 3678 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
980 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
981 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
982 [ + - + - ]: 5517 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
983 : : {
984 [ + - + - ]: 3678 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
985 [ + - + - ]: 3678 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
986 [ + - + - : 14712 : Cat(
+ + - - ]
987 : : {
988 [ + - + - : 5517 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
+ - ]
989 [ + - + - ]: 3678 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
990 [ + - ]: 3678 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
991 [ + - ]: 3678 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
992 [ + - + - ]: 5517 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
993 [ + - + - ]: 3678 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true},
994 [ + - ]: 3678 : "Whether the new transaction should be\n"
995 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
996 : : "be set to 0xfffffffd. If false, any input sequence numbers in the\n"
997 : : "transaction will be set to 0xfffffffe\n"
998 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
999 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
1000 : : "are replaceable).\n"},
1001 [ + - + - ]: 3678 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1002 [ + - + - : 3678 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1003 [ + - + - ]: 3678 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1004 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1005 : : "At least one output of either type must be specified.\n"
1006 : : "Cannot be provided if 'original_change_index' is specified.",
1007 [ + - ]: 3678 : OutputsDoc(),
1008 [ + - ]: 3678 : RPCArgOptions{.skip_type_check = true}},
1009 [ + - + - : 5517 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
+ - ]
1010 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1011 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1012 : : "original change output. The change output’s amount can increase if bumping the transaction "
1013 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1014 : : },
1015 [ + + + - : 9762 : want_psbt ? std::vector<RPCArg>{{"psbt_version", RPCArg::Type::NUM, RPCArg::Default(2), "The PSBT version number to use."}} : std::vector<RPCArg>()
+ - + - +
- + + + +
+ + + + +
+ + + - -
- - - - -
- - - -
- ]
1016 : : ),
1017 [ + - ]: 3678 : RPCArgOptions{.oneline_description="options"}},
1018 : : },
1019 [ + - ]: 3678 : RPCResult{
1020 [ + - + - : 25746 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + + + +
- - - - ]
1021 [ + + + - : 9195 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1022 [ + - + - : 5235 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ + + + +
+ - - - -
- - ]
1023 [ + - + - : 5799 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ + + + +
+ - - - -
- - ]
1024 : : {
1025 [ + - + - ]: 3678 : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1026 [ + - + - ]: 3678 : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1027 [ + - + - ]: 3678 : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1028 : : {
1029 [ + - + - ]: 3678 : {RPCResult::Type::STR, "", ""},
1030 : : }},
1031 : : })
1032 [ + - ]: 3678 : },
1033 : 1839 : RPCExamples{
1034 [ + + + - : 4668 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1035 [ + - + - : 5517 : HelpExampleCli(method_name, "<txid>")
+ - ]
1036 : 1839 : },
1037 [ + - ]: 3678 : [want_psbt](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1038 : : {
1039 : 161 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1040 [ - + ]: 161 : if (!pwallet) return UniValue::VNULL;
1041 : :
1042 [ + - + + : 161 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1043 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1044 : : }
1045 : :
1046 [ + - + - ]: 160 : Txid hash{Txid::FromUint256(ParseHashV(request.params[0], "txid"))};
1047 : :
1048 [ + - ]: 160 : CCoinControl coin_control;
1049 : : // optional parameters
1050 : 160 : coin_control.m_signal_bip125_rbf = true;
1051 : 160 : std::vector<CTxOut> outputs;
1052 : :
1053 : 160 : std::optional<uint32_t> original_change_index;
1054 : :
1055 : 160 : uint32_t psbt_version = 2;
1056 : :
1057 [ + - + + ]: 160 : if (!request.params[1].isNull()) {
1058 [ + - + - ]: 70 : UniValue options = request.params[1];
1059 [ + + + + : 704 : RPCTypeCheckObj(options,
+ + ]
1060 : : {
1061 [ + - ]: 70 : {"confTarget", UniValueType(UniValue::VNUM)},
1062 [ + - ]: 70 : {"conf_target", UniValueType(UniValue::VNUM)},
1063 [ + - ]: 70 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1064 [ + - ]: 70 : {"replaceable", UniValueType(UniValue::VBOOL)},
1065 [ + - ]: 70 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1066 [ + - ]: 70 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1067 [ + - ]: 70 : {"original_change_index", UniValueType(UniValue::VNUM)},
1068 [ + - ]: 70 : {"psbt_version", UniValueType(UniValue::VNUM)},
1069 : : },
1070 : : true, true);
1071 : :
1072 [ + - + - : 133 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1073 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1074 : : }
1075 : :
1076 [ + - - + : 195 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1077 : :
1078 [ + - + + ]: 130 : if (options.exists("replaceable")) {
1079 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1080 : : }
1081 [ + - + - : 149 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1082 : :
1083 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1084 [ + - + - : 46 : if (!options["outputs"].isNull()) {
+ + ]
1085 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- - + + +
+ + - - ]
1086 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1087 : : }
1088 [ + - ]: 10 : CMutableTransaction tempTx;
1089 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1090 [ + - ]: 8 : outputs = tempTx.vout;
1091 : 10 : }
1092 : :
1093 [ + - + + ]: 86 : if (options.exists("original_change_index")) {
1094 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1095 : : }
1096 : :
1097 [ + - + + ]: 84 : if (options.exists("psbt_version")) {
1098 [ + - + - : 3 : psbt_version = options["psbt_version"].getInt<uint32_t>();
+ - ]
1099 : : }
1100 [ + + ]: 42 : if (psbt_version != 2 && psbt_version != 0) {
1101 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "The PSBT version can only be 2 or 0");
1102 : : }
1103 : 94 : }
1104 : :
1105 : : // Make sure the results are valid at least up to the most recent block
1106 : : // the user could have gotten from another RPC command prior to now
1107 [ + - ]: 131 : pwallet->BlockUntilSyncedToCurrentChain();
1108 : :
1109 [ + - ]: 131 : LOCK(pwallet->cs_wallet);
1110 : :
1111 [ + + ]: 131 : EnsureWalletIsUnlocked(*pwallet);
1112 : :
1113 : :
1114 : 130 : std::vector<bilingual_str> errors;
1115 : 130 : CAmount old_fee;
1116 : 130 : CAmount new_fee;
1117 [ + - ]: 130 : CMutableTransaction mtx;
1118 : : // Targeting feerate bump.
1119 : 260 : [&](){
1120 [ - - + + : 130 : switch (feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index)) {
+ - + ]
1121 : 107 : case feebumper::Result::OK:
1122 : 107 : return;
1123 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1124 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1125 : 0 : case feebumper::Result::INVALID_REQUEST:
1126 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1127 : 16 : case feebumper::Result::INVALID_PARAMETER:
1128 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1129 : 6 : case feebumper::Result::WALLET_ERROR:
1130 [ + - ]: 6 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1131 : 1 : case feebumper::Result::MISC_ERROR:
1132 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1133 : : } // no default case, so the compiler can warn about missing cases
1134 [ # # ]: 0 : NONFATAL_UNREACHABLE();
1135 [ + + ]: 130 : }();
1136 : :
1137 : 107 : UniValue result(UniValue::VOBJ);
1138 : :
1139 : : // For bumpfee, return the new transaction id.
1140 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1141 [ + + ]: 107 : if (!want_psbt) {
1142 [ + - - + ]: 98 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1143 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1144 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1145 : : }
1146 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1147 : : }
1148 : :
1149 [ + - ]: 98 : Txid txid;
1150 [ + - - + ]: 98 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1151 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1152 : : }
1153 : :
1154 [ + - + - : 196 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1155 : : } else {
1156 [ + - ]: 9 : PartiallySignedTransaction psbtx(mtx, psbt_version);
1157 : 9 : bool complete = false;
1158 [ + - ]: 9 : const auto err{pwallet->FillPSBT(psbtx, {.sign = false, .bip32_derivs = true}, complete)};
1159 [ + - ]: 9 : CHECK_NONFATAL(!err);
1160 [ + - ]: 9 : CHECK_NONFATAL(!complete);
1161 : 9 : DataStream ssTx{};
1162 [ + - ]: 9 : ssTx << psbtx;
1163 [ + - + - : 27 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1164 : 9 : }
1165 : :
1166 [ + - + - : 214 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1167 [ + - + - : 214 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1168 : 107 : UniValue result_errors(UniValue::VARR);
1169 [ - + ]: 107 : for (const bilingual_str& error : errors) {
1170 [ # # # # ]: 0 : result_errors.push_back(error.original);
1171 : : }
1172 [ + - + - ]: 214 : result.pushKV("errors", std::move(result_errors));
1173 : :
1174 : 107 : return result;
1175 [ + - + - : 631 : },
+ - + - +
- + - + -
+ - + - +
- - + ]
1176 [ + + + - : 12873 : };
+ - + + -
- ]
1177 [ + - + - : 53190 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - - -
- - - - ]
1178 : :
1179 [ + - ]: 1980 : RPCMethod bumpfee() { return bumpfee_helper("bumpfee"); }
1180 [ + - ]: 1698 : RPCMethod psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1181 : :
1182 : 1059 : RPCMethod send()
1183 : : {
1184 : 1059 : return RPCMethod{
1185 : 1059 : "send",
1186 [ + - ]: 2118 : "Send a transaction.\n",
1187 : : {
1188 [ + - + - ]: 2118 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1189 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1190 : : "At least one output of either type must be specified.\n"
1191 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1192 [ + - ]: 2118 : OutputsDoc(),
1193 [ + - ]: 2118 : RPCArgOptions{.skip_type_check = true}},
1194 [ + - + - : 3177 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
1195 [ + - + - ]: 2118 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1196 [ + - + - : 2118 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1197 [ + - + - : 3177 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1198 [ + - + - ]: 2118 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1199 [ + - + - : 31770 : Cat<std::vector<RPCArg>>(
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
1200 : : {
1201 [ + - + - : 3177 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
+ - ]
1202 [ + - + - : 3177 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
1203 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1204 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1205 [ + - + - : 3177 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
1206 [ + - + - ]: 2118 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1207 [ + - + - : 3177 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
+ - ]
1208 [ + - + - : 3177 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
1209 [ + - + - : 3177 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
1210 [ + - + - : 3177 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
1211 [ + - + - : 4236 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - + - ]
1212 [ + - + - : 3177 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{"false"}, "(DEPRECATED) No longer used"},
+ - ]
1213 [ + - + - ]: 2118 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
1214 : : {
1215 [ + - + - ]: 2118 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
1216 [ + - + - ]: 2118 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1217 [ + - + - ]: 2118 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1218 [ + - + - : 3177 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
+ - ]
1219 [ + - + - : 3177 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
+ - ]
1220 : : "including the weight of the outpoint and sequence number. "
1221 : : "Note that signature sizes are not guaranteed to be consistent, "
1222 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1223 : : "Remember to convert serialized sizes to weight units when necessary."},
1224 : : }},
1225 : : },
1226 : : },
1227 [ + - + - : 3177 : {"locktime", RPCArg::Type::NUM, RPCArg::DefaultHint{"locktime close to block height to prevent fee sniping"}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1228 [ + - + - : 3177 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1229 [ + - + - : 3177 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
+ - ]
1230 [ + - + - ]: 2118 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1231 : : "The fee will be equally deducted from the amount of each specified output.\n"
1232 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1233 : : "If no outputs are specified here, the sender pays the fee.",
1234 : : {
1235 [ + - + - ]: 2118 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1236 : : },
1237 : : },
1238 [ + - + - : 3177 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
1239 : : "Transaction building will fail if this can not be satisfied."},
1240 : : },
1241 [ + - ]: 2118 : FundTxDoc()),
1242 [ + - ]: 2118 : RPCArgOptions{.oneline_description="options"}},
1243 [ + - + - : 3177 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1244 : : },
1245 [ + - ]: 2118 : RPCResult{
1246 [ + - + - ]: 2118 : RPCResult::Type::OBJ, "", "",
1247 : : {
1248 [ + - + - ]: 2118 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1249 [ + - + - ]: 2118 : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1250 [ + - + - ]: 2118 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1251 [ + - + - ]: 2118 : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1252 : : }
1253 [ + - + - : 10590 : },
+ + - - ]
1254 : 1059 : RPCExamples{""
1255 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1256 [ + - + - : 3177 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1257 [ + - ]: 2118 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1258 [ + - + - : 5295 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1259 [ + - ]: 2118 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1260 [ + - + - : 5295 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1261 [ + - ]: 2118 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1262 [ + - + - : 5295 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1263 : 1059 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1264 [ + - + - : 5295 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical null '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1265 [ + - ]: 1059 : },
1266 : 1059 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1267 : : {
1268 : 220 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1269 [ - + ]: 220 : if (!pwallet) return UniValue::VNULL;
1270 : :
1271 [ + - + + : 220 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1272 [ + - + - : 220 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1273 [ + + ]: 216 : PreventOutdatedOptions(options);
1274 : :
1275 : :
1276 [ + - - + : 430 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1277 : 215 : UniValue outputs(UniValue::VOBJ);
1278 [ + - + - ]: 215 : outputs = NormalizeOutputs(request.params[0]);
1279 : 215 : std::vector<CRecipient> recipients = CreateRecipients(
1280 [ + + ]: 429 : ParseOutputs(outputs),
1281 [ + - + - : 431 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1282 [ + - ]: 214 : );
1283 [ + - ]: 214 : CCoinControl coin_control;
1284 [ + - ]: 214 : coin_control.m_version = self.Arg<uint32_t>("version");
1285 [ + - + - : 428 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf, coin_control.m_version);
+ - + - +
- + - ]
1286 : : // Automatically select coins, unless at least one is manually selected. Can
1287 : : // be overridden by options.add_inputs.
1288 [ - + ]: 214 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1289 [ + - - + ]: 428 : if (options.exists("max_tx_weight")) {
1290 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1291 : : }
1292 : :
1293 [ + - + - : 215 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1294 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1295 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1296 : 213 : rawTx.vout.clear();
1297 [ + + ]: 213 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1298 : :
1299 [ + - ]: 130 : CMutableTransaction tx = CMutableTransaction(*txr.tx);
1300 [ + - + + ]: 390 : return FinishTransaction(pwallet, options, tx);
1301 [ + - ]: 865 : }
1302 [ + - + - : 10590 : };
+ + - - ]
1303 [ + - + - : 64599 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
1304 : :
1305 : 1013 : RPCMethod sendall()
1306 : : {
1307 : 1013 : return RPCMethod{"sendall",
1308 [ + - ]: 2026 : "Spend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1309 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1310 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1311 : : {
1312 [ + - + - ]: 2026 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1313 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1314 : : {
1315 [ + - + - ]: 2026 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1316 [ + - + - ]: 2026 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1317 : : {
1318 [ + - + - ]: 2026 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1319 : : },
1320 : : },
1321 : : },
1322 : : },
1323 [ + - + - : 3039 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
1324 [ + - + - ]: 2026 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1325 [ + - + - : 2026 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1326 [ + - + - : 3039 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1327 : : {
1328 [ + - + - ]: 2026 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1329 [ + - + - : 21273 : Cat<std::vector<RPCArg>>(
+ - + - +
+ + + + +
- - - - -
- ]
1330 : : {
1331 [ + - + - : 3039 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
+ - ]
1332 [ + - + - : 4052 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - + - ]
1333 [ + - + - : 3039 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1334 [ + - + - ]: 2026 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1335 : : {
1336 [ + - + - ]: 2026 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1337 : : {
1338 [ + - + - ]: 2026 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1339 [ + - + - ]: 2026 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1340 [ + - + - : 3039 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
+ - ]
1341 : : },
1342 : : },
1343 : : },
1344 : : },
1345 [ + - + - : 3039 : {"locktime", RPCArg::Type::NUM, RPCArg::DefaultHint{"locktime close to block height to prevent fee sniping"}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1346 [ + - + - : 3039 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1347 [ + - + - : 3039 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
+ - ]
1348 [ + - + - : 3039 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
+ - ]
1349 [ + - + - : 3039 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
+ - ]
1350 [ + - + - ]: 2026 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1351 [ + - + - : 3039 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1352 : : },
1353 [ + - ]: 2026 : FundTxDoc()
1354 : : ),
1355 [ + - ]: 2026 : RPCArgOptions{.oneline_description="options"}
1356 : : },
1357 : : },
1358 [ + - ]: 2026 : RPCResult{
1359 [ + - + - ]: 2026 : RPCResult::Type::OBJ, "", "",
1360 : : {
1361 [ + - + - ]: 2026 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1362 [ + - + - ]: 2026 : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1363 [ + - + - ]: 2026 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1364 [ + - + - ]: 2026 : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1365 : : }
1366 [ + - + - : 10130 : },
+ + - - ]
1367 : 1013 : RPCExamples{""
1368 [ + - ]: 2026 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1369 [ + - + - : 5065 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1370 [ + - ]: 2026 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1371 [ + - + - : 5065 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1372 [ + - ]: 2026 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1373 [ + - + - : 6078 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1374 [ + - ]: 2026 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1375 [ + - + - : 5065 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1376 [ + - + - ]: 3039 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1377 [ + - + - : 6078 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1378 [ + - ]: 1013 : },
1379 : 1013 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1380 : : {
1381 : 174 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1382 [ - + ]: 174 : if (!pwallet) return UniValue::VNULL;
1383 : : // Make sure the results are valid at least up to the most recent block
1384 : : // the user could have gotten from another RPC command prior to now
1385 [ + - ]: 174 : pwallet->BlockUntilSyncedToCurrentChain();
1386 : :
1387 [ + - + + : 174 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1388 [ + - + - : 174 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1389 [ + - ]: 174 : PreventOutdatedOptions(options);
1390 : :
1391 : :
1392 : 174 : std::set<std::string> addresses_without_amount;
1393 : 174 : UniValue recipient_key_value_pairs(UniValue::VARR);
1394 [ + - ]: 174 : const UniValue& recipients{request.params[0]};
1395 [ - + + + ]: 1057 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1396 [ + - ]: 883 : const UniValue& recipient{recipients[i]};
1397 [ + + ]: 883 : if (recipient.isStr()) {
1398 : 874 : UniValue rkvp(UniValue::VOBJ);
1399 [ + - + - : 2622 : rkvp.pushKV(recipient.get_str(), 0);
- + + - ]
1400 [ + - ]: 874 : recipient_key_value_pairs.push_back(std::move(rkvp));
1401 [ + - + - ]: 874 : addresses_without_amount.insert(recipient.get_str());
1402 : 874 : } else {
1403 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1404 : : }
1405 : : }
1406 : :
1407 [ + + ]: 174 : if (addresses_without_amount.size() == 0) {
1408 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1409 : : }
1410 : :
1411 [ + - ]: 172 : CCoinControl coin_control;
1412 : :
1413 [ + - + - : 344 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1414 : :
1415 [ + - + + ]: 344 : if (options.exists("minconf")) {
1416 [ + - + - : 7 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1417 : : {
1418 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1419 : : }
1420 : :
1421 [ + - + - : 6 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1422 : : }
1423 : :
1424 [ + - + + ]: 342 : if (options.exists("maxconf")) {
1425 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1426 : :
1427 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1428 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1429 : : }
1430 : : }
1431 : :
1432 [ + - + + ]: 342 : if (options.exists("version")) {
1433 [ + - + - : 9 : coin_control.m_version = options["version"].getInt<decltype(coin_control.m_version)>();
+ - ]
1434 : : }
1435 : :
1436 [ + + ]: 171 : if (coin_control.m_version == TRUC_VERSION) {
1437 [ - + ]: 7 : coin_control.m_max_tx_weight = TRUC_MAX_WEIGHT;
1438 : : } else {
1439 : 164 : coin_control.m_max_tx_weight = MAX_STANDARD_TX_WEIGHT;
1440 : : }
1441 : :
1442 [ + - + + : 342 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1443 : :
1444 : 171 : FeeCalculation fee_calc_out;
1445 [ + - ]: 171 : CFeeRate fee_rate{GetMinimumFeeRate(*pwallet, coin_control, &fee_calc_out)};
1446 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1447 : : // provided one
1448 [ + + + + ]: 171 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1449 : 1 : const auto feerate_format = FeeRateFormat::SAT_VB;
1450 : 1 : auto msg{strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s).",
1451 [ + - ]: 2 : coin_control.m_feerate->ToString(feerate_format),
1452 [ + - + - ]: 2 : fee_rate.ToString(feerate_format))};
1453 [ + - ]: 1 : if (fee_calc_out.reason == FeeReason::REQUIRED) {
1454 [ + - ]: 3 : msg += strprintf("\nConsider modifying -mintxfee (%s) or -minrelaytxfee (%s).",
1455 [ + - ]: 2 : pwallet->m_min_fee.ToString(feerate_format),
1456 [ + - + - ]: 3 : pwallet->chain().relayMinFee().ToString(feerate_format));
1457 : : }
1458 [ + - ]: 1 : throw JSONRPCError(RPC_INVALID_PARAMETER, msg);
1459 : 1 : }
1460 [ + + + - ]: 170 : if (fee_calc_out.reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1461 : : // eventually allow a fallback fee
1462 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1463 : : }
1464 : :
1465 [ + - + - : 341 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf, coin_control.m_version)};
+ - + - +
+ ]
1466 [ + - ]: 169 : LOCK(pwallet->cs_wallet);
1467 : :
1468 : 169 : CAmount total_input_value(0);
1469 [ + - + + : 340 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1470 [ + - + - : 355 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1471 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1472 [ + - + - : 367 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1473 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1474 [ + - + + ]: 334 : } else if (options.exists("inputs")) {
1475 [ + + ]: 27 : for (const CTxIn& input : rawTx.vin) {
1476 [ + - + + ]: 16 : if (pwallet->IsSpent(input.prevout)) {
1477 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1478 : : }
1479 [ + - ]: 14 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1480 [ + + - + : 14 : if (!tx || input.prevout.n >= tx->tx->vout.size() || !pwallet->IsMine(tx->tx->vout[input.prevout.n])) {
+ + + - +
- ]
1481 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1482 : : }
1483 [ + - + + ]: 12 : if (pwallet->GetTxDepthInMainChain(*tx) == 0) {
1484 [ - + - - ]: 5 : if (tx->tx->version == TRUC_VERSION && coin_control.m_version != TRUC_VERSION) {
1485 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Can't spend unconfirmed version 3 pre-selected input with a version %d tx", coin_control.m_version));
1486 [ - + - - ]: 5 : } else if (coin_control.m_version == TRUC_VERSION && tx->tx->version != TRUC_VERSION) {
1487 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Can't spend unconfirmed version %d pre-selected input with a version 3 tx", tx->tx->version));
1488 : : }
1489 : : }
1490 : 12 : total_input_value += tx->tx->vout[input.prevout.n].nValue;
1491 : : }
1492 : : } else {
1493 : 152 : CoinFilterParams coins_params;
1494 : 152 : coins_params.min_amount = 0;
1495 [ + - + - : 2978 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1496 [ + + + - : 2826 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1497 : 2 : continue;
1498 : : }
1499 : : // we are spending an unconfirmed TRUC transaction, so lower max weight
1500 [ + + + + ]: 2824 : if (output.depth == 0 && coin_control.m_version == TRUC_VERSION) {
1501 [ + - ]: 4 : coin_control.m_max_tx_weight = TRUC_CHILD_MAX_WEIGHT;
1502 : : }
1503 [ + + + - ]: 2827 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::MAX_SEQUENCE_NONFINAL);
1504 [ + - ]: 2824 : rawTx.vin.push_back(input);
1505 : 2824 : total_input_value += output.txout.nValue;
1506 : 2976 : }
1507 : : }
1508 : :
1509 : 163 : std::vector<COutPoint> outpoints_spent;
1510 [ - + + - ]: 163 : outpoints_spent.reserve(rawTx.vin.size());
1511 : :
1512 [ + + ]: 2999 : for (const CTxIn& tx_in : rawTx.vin) {
1513 [ + - ]: 2836 : outpoints_spent.push_back(tx_in.prevout);
1514 : : }
1515 : :
1516 : : // estimate final size of tx
1517 [ + - + - ]: 163 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1518 [ + + ]: 163 : if (tx_size.vsize == -1) {
1519 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, "Unable to determine the size of the transaction, the wallet contains unsolvable descriptors");
1520 : : }
1521 [ + - ]: 161 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1522 [ + - ]: 161 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1523 [ + - ]: 161 : CAmount effective_value = total_input_value - fee_from_size - total_bump_fees.value_or(0);
1524 : :
1525 [ + + ]: 161 : if (fee_from_size > pwallet->m_default_max_tx_fee) {
1526 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1527 : : }
1528 : :
1529 [ + + ]: 160 : if (effective_value <= 0) {
1530 [ - + ]: 33 : if (send_max) {
1531 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1532 : : } else {
1533 [ + - + - ]: 66 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1534 : : }
1535 : : }
1536 : :
1537 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1538 [ + - ]: 127 : if (tx_size.weight > coin_control.m_max_tx_weight) {
1539 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1540 : : }
1541 : :
1542 : 124 : CAmount output_amounts_claimed{0};
1543 [ + + ]: 609 : for (const CTxOut& out : rawTx.vout) {
1544 : 485 : output_amounts_claimed += out.nValue;
1545 : : }
1546 : :
1547 [ + + ]: 124 : if (output_amounts_claimed > total_input_value) {
1548 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1549 : : }
1550 : :
1551 : 123 : const CAmount remainder{effective_value - output_amounts_claimed};
1552 [ + + ]: 123 : if (remainder < 0) {
1553 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1554 : : }
1555 : :
1556 : 122 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1557 : :
1558 : 122 : bool gave_remaining_to_first{false};
1559 [ + + ]: 599 : for (CTxOut& out : rawTx.vout) {
1560 : 480 : CTxDestination dest;
1561 [ + - ]: 480 : ExtractDestination(out.scriptPubKey, dest);
1562 [ + - ]: 480 : std::string addr{EncodeDestination(dest)};
1563 [ + + ]: 480 : if (addresses_without_amount.contains(addr)) {
1564 : 474 : out.nValue = per_output_without_amount;
1565 [ + + ]: 474 : if (!gave_remaining_to_first) {
1566 : 121 : out.nValue += remainder % addresses_without_amount.size();
1567 : 121 : gave_remaining_to_first = true;
1568 : : }
1569 [ + - + - : 474 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1570 : : // Dynamically generated output amount is dust
1571 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1572 : : }
1573 : : } else {
1574 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1575 : : // Specified output amount is dust
1576 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", addr));
1577 : : }
1578 : : }
1579 : 483 : }
1580 : :
1581 [ + - + + : 240 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1582 [ + + ]: 119 : if (lock_unspents) {
1583 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1584 [ + - ]: 2 : pwallet->LockCoin(txin.prevout, /*persist=*/false);
1585 : : }
1586 : : }
1587 : :
1588 [ + - + - ]: 357 : return FinishTransaction(pwallet, options, rawTx);
1589 [ + - ]: 733 : }
1590 [ + - + - : 16208 : };
+ - + - +
+ + + + +
- - - - -
- ]
1591 [ + - + - : 52676 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - -
- ]
1592 : :
1593 : 1459 : RPCMethod walletprocesspsbt()
1594 : : {
1595 : 1459 : return RPCMethod{
1596 : 1459 : "walletprocesspsbt",
1597 : : "Update a PSBT with input information from our wallet and then sign inputs\n"
1598 : 1459 : "that we can sign for." +
1599 [ + - ]: 1459 : HELP_REQUIRING_PASSPHRASE,
1600 : : {
1601 [ + - + - ]: 2918 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1602 [ + - + - : 4377 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
+ - ]
1603 [ + - + - : 4377 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
+ - ]
1604 : : " \"DEFAULT\"\n"
1605 : : " \"ALL\"\n"
1606 : : " \"NONE\"\n"
1607 : : " \"SINGLE\"\n"
1608 : : " \"ALL|ANYONECANPAY\"\n"
1609 : : " \"NONE|ANYONECANPAY\"\n"
1610 : : " \"SINGLE|ANYONECANPAY\""},
1611 [ + - + - : 4377 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
+ - ]
1612 [ + - + - : 4377 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
+ - ]
1613 : : },
1614 [ + - ]: 2918 : RPCResult{
1615 [ + - + - ]: 2918 : RPCResult::Type::OBJ, "", "",
1616 : : {
1617 [ + - + - ]: 2918 : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1618 [ + - + - ]: 2918 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1619 [ + - + - ]: 2918 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1620 : : }
1621 [ + - + - : 11672 : },
+ + - - ]
1622 : 1459 : RPCExamples{
1623 [ + - + - : 2918 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1624 [ + - ]: 1459 : },
1625 : 1459 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1626 : : {
1627 [ - + ]: 620 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1628 [ - + ]: 620 : if (!pwallet) return UniValue::VNULL;
1629 : :
1630 [ + - ]: 620 : const CWallet& wallet{*pwallet};
1631 : : // Make sure the results are valid at least up to the most recent block
1632 : : // the user could have gotten from another RPC command prior to now
1633 [ + - ]: 620 : wallet.BlockUntilSyncedToCurrentChain();
1634 : :
1635 : : // Unserialize the transaction
1636 [ + - + - : 620 : util::Result<PartiallySignedTransaction> psbt_res = DecodeBase64PSBT(request.params[0].get_str());
+ - ]
1637 [ + + ]: 620 : if (!psbt_res) {
1638 [ + - + - : 6 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", util::ErrorString(psbt_res).original));
+ - ]
1639 : : }
1640 [ + - ]: 618 : PartiallySignedTransaction psbtx = *psbt_res;
1641 : :
1642 : : // Get the sighash type
1643 [ + - + + ]: 618 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
1644 : :
1645 : : // Fill transaction with our data and also sign
1646 [ + - + + : 617 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1647 [ + - + + : 617 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1648 [ + - + + : 617 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1649 : 617 : bool complete = true;
1650 : :
1651 [ + + + + ]: 617 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1652 : :
1653 [ + - ]: 616 : const auto err{wallet.FillPSBT(psbtx, {.sign = sign, .sighash_type = nHashType, .finalize = finalize, .bip32_derivs = bip32derivs}, complete)};
1654 [ + + ]: 616 : if (err) {
1655 [ + - ]: 7 : throw JSONRPCPSBTError(*err);
1656 : : }
1657 : :
1658 : 609 : UniValue result(UniValue::VOBJ);
1659 : 609 : DataStream ssTx{};
1660 [ + - ]: 609 : ssTx << psbtx;
1661 [ + - + - : 1827 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1662 [ + - + - : 1218 : result.pushKV("complete", complete);
+ - ]
1663 [ + + ]: 609 : if (complete) {
1664 [ + - ]: 40 : CMutableTransaction mtx;
1665 : : // Returns true if complete, which we already think it is.
1666 [ + - + - ]: 40 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1667 : 40 : DataStream ssTx_final;
1668 [ + - ]: 40 : ssTx_final << TX_WITH_WITNESS(mtx);
1669 [ - + + - : 80 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - +
- ]
1670 : 80 : }
1671 : :
1672 : 609 : return result;
1673 : 1238 : },
1674 [ + - + - : 13131 : };
+ + - - ]
1675 [ + - + - : 23344 : }
+ - + - +
- + - + -
+ - - - -
- ]
1676 : :
1677 : 1070 : RPCMethod walletcreatefundedpsbt()
1678 : : {
1679 : 1070 : return RPCMethod{
1680 : 1070 : "walletcreatefundedpsbt",
1681 [ + - ]: 2140 : "Creates and funds a transaction in the Partially Signed Transaction format.\n"
1682 : : "Implements the Creator and Updater roles.\n"
1683 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1684 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1685 : : {
1686 [ + - + - ]: 2140 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1687 : : {
1688 [ + - + - ]: 2140 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1689 : : {
1690 [ + - + - ]: 2140 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1691 [ + - + - ]: 2140 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1692 [ + - + - : 3210 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
+ - ]
1693 [ + - + - : 3210 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
+ - ]
1694 : : "including the weight of the outpoint and sequence number. "
1695 : : "Note that signature sizes are not guaranteed to be consistent, "
1696 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1697 : : "Remember to convert serialized sizes to weight units when necessary."},
1698 : : },
1699 : : },
1700 : : },
1701 : : },
1702 [ + - + - ]: 2140 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1703 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1704 : : "At least one output of either type must be specified.\n"
1705 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1706 : : "accepted as second parameter.",
1707 [ + - ]: 2140 : OutputsDoc(),
1708 [ + - ]: 2140 : RPCArgOptions{.skip_type_check = true}},
1709 [ + - + - : 3210 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1710 [ + - + - ]: 2140 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1711 [ + - + - : 19260 : Cat<std::vector<RPCArg>>(
+ - + + +
+ - - -
- ]
1712 : : {
1713 [ + - + - : 3210 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
+ - ]
1714 [ + - + - : 3210 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
1715 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1716 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1717 [ + - + - : 3210 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
1718 [ + - + - ]: 2140 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1719 [ + - + - : 3210 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
1720 [ + - + - : 3210 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
1721 [ + - + - : 3210 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
1722 [ + - + - : 3210 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1723 [ + - + - : 3210 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1724 [ + - + - : 3210 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1725 [ + - + - : 3210 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
+ - ]
1726 [ + - + - ]: 2140 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1727 : : "The fee will be equally deducted from the amount of each specified output.\n"
1728 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1729 : : "If no outputs are specified here, the sender pays the fee.",
1730 : : {
1731 [ + - + - ]: 2140 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1732 : : },
1733 : : },
1734 [ + - + - : 3210 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
1735 : : "Transaction building will fail if this can not be satisfied."},
1736 : : },
1737 [ + - ]: 2140 : FundTxDoc()),
1738 [ + - ]: 2140 : RPCArgOptions{.oneline_description="options"}},
1739 [ + - + - : 3210 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
+ - ]
1740 [ + - + - : 3210 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1741 [ + - + - : 3210 : {"psbt_version", RPCArg::Type::NUM, RPCArg::Default(2), "The PSBT version number to use."},
+ - ]
1742 : : },
1743 [ + - ]: 2140 : RPCResult{
1744 [ + - + - ]: 2140 : RPCResult::Type::OBJ, "", "",
1745 : : {
1746 [ + - + - ]: 2140 : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1747 [ + - + - ]: 2140 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1748 [ + - + - ]: 2140 : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1749 : : }
1750 [ + - + - : 8560 : },
+ + - - ]
1751 : 1070 : RPCExamples{
1752 : : "\nCreate a PSBT with automatically picked inputs that sends 0.5 BTC to an address and has a fee rate of 2 sat/vB:\n"
1753 [ + - + - : 3210 : + HelpExampleCli("walletcreatefundedpsbt", "\"[]\" \"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" 0 \"{\\\"add_inputs\\\":true,\\\"fee_rate\\\":2}\"")
+ - + - ]
1754 : 1070 : + "\nCreate the same PSBT as the above one instead using named arguments:\n"
1755 [ + - + - : 5350 : + HelpExampleCli("-named walletcreatefundedpsbt", "outputs=\"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" add_inputs=true fee_rate=2")
+ - + - ]
1756 [ + - ]: 1070 : },
1757 : 1070 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1758 : : {
1759 : 231 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1760 [ - + ]: 231 : if (!pwallet) return UniValue::VNULL;
1761 : :
1762 [ + - ]: 231 : CWallet& wallet{*pwallet};
1763 : : // Make sure the results are valid at least up to the most recent block
1764 : : // the user could have gotten from another RPC command prior to now
1765 [ + - ]: 231 : wallet.BlockUntilSyncedToCurrentChain();
1766 : :
1767 [ + - + + : 231 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1768 : :
1769 [ + - ]: 231 : CCoinControl coin_control;
1770 [ + - ]: 231 : coin_control.m_version = self.Arg<uint32_t>("version");
1771 : :
1772 [ + - + - ]: 231 : const UniValue &replaceable_arg = options["replaceable"];
1773 [ + + + - ]: 231 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1774 [ + - + - : 231 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf, coin_control.m_version);
+ - + - ]
1775 : 231 : UniValue outputs(UniValue::VOBJ);
1776 [ + - + - ]: 231 : outputs = NormalizeOutputs(request.params[1]);
1777 : 231 : std::vector<CRecipient> recipients = CreateRecipients(
1778 [ + - ]: 462 : ParseOutputs(outputs),
1779 [ + - + - : 462 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1780 [ + - ]: 231 : );
1781 : : // Automatically select coins, unless at least one is manually selected. Can
1782 : : // be overridden by options.add_inputs.
1783 [ - + ]: 231 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1784 [ + - + + ]: 231 : SetOptionsInputWeights(request.params[0], options);
1785 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1786 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1787 : 230 : rawTx.vout.clear();
1788 [ + + ]: 230 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1789 : :
1790 : : // Make a blank psbt
1791 : 162 : uint32_t psbt_version = 2;
1792 [ + - + + ]: 162 : if (!request.params[6].isNull()) {
1793 [ + - + - ]: 5 : psbt_version = request.params[6].getInt<int>();
1794 : : }
1795 [ + + ]: 162 : if (psbt_version != 2 && psbt_version != 0) {
1796 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "The PSBT version can only be 2 or 0");
1797 : : }
1798 : :
1799 [ + - + - ]: 161 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx), psbt_version);
1800 : :
1801 : : // Fill transaction with out data but don't sign
1802 [ + - + + : 161 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1803 : 161 : bool complete = true;
1804 [ + - ]: 161 : const auto err{wallet.FillPSBT(psbtx, {.sign = false, .bip32_derivs = bip32derivs}, complete)};
1805 [ - + ]: 161 : if (err) {
1806 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1807 : : }
1808 : :
1809 : : // Serialize the PSBT
1810 : 161 : DataStream ssTx{};
1811 [ + - ]: 161 : ssTx << psbtx;
1812 : :
1813 : 161 : UniValue result(UniValue::VOBJ);
1814 [ + - + - : 483 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1815 [ + - + - : 322 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1816 [ + + + - : 322 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1817 : 161 : return result;
1818 [ + - ]: 924 : },
1819 [ + - + - : 21400 : };
+ - + - +
+ + + + +
- - - - -
- ]
1820 [ + - + - : 59920 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1821 : : } // namespace wallet
|
