Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <rpc/rawtransaction_util.h>
12 : : #include <rpc/util.h>
13 : : #include <script/script.h>
14 : : #include <util/rbf.h>
15 : : #include <util/translation.h>
16 : : #include <util/vector.h>
17 : : #include <wallet/coincontrol.h>
18 : : #include <wallet/feebumper.h>
19 : : #include <wallet/fees.h>
20 : : #include <wallet/rpc/util.h>
21 : : #include <wallet/spend.h>
22 : : #include <wallet/wallet.h>
23 : :
24 : : #include <univalue.h>
25 : :
26 : : using common::FeeModeFromString;
27 : : using common::FeeModesDetail;
28 : : using common::InvalidEstimateModeErrorMessage;
29 : : using common::StringForFeeReason;
30 : : using common::TransactionErrorString;
31 : : using node::TransactionError;
32 : :
33 : : namespace wallet {
34 : 1809 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
35 : : {
36 : 1809 : std::vector<CRecipient> recipients;
37 [ + + ]: 23484 : for (size_t i = 0; i < outputs.size(); ++i) {
38 [ + - + - ]: 21675 : const auto& [destination, amount] = outputs.at(i);
39 [ + - ]: 43350 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
40 [ + - ]: 21675 : recipients.push_back(recipient);
41 : 21675 : }
42 : 1809 : return recipients;
43 : 0 : }
44 : :
45 : 307 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
46 : : {
47 [ + - + - : 898 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
48 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
49 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
50 : : }
51 : : } else {
52 [ + - + - ]: 566 : options.pushKV("conf_target", conf_target);
53 [ + - + - ]: 566 : options.pushKV("estimate_mode", estimate_mode);
54 : : }
55 [ + + ]: 608 : if (options.exists("fee_rate")) {
56 [ + + ]: 26 : if (!fee_rate.isNull()) {
57 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
58 : : }
59 : : } else {
60 [ + - + - ]: 556 : options.pushKV("fee_rate", fee_rate);
61 : : }
62 [ + - + - : 664 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
63 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
64 : : }
65 : 303 : }
66 : :
67 : 646 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
68 : : {
69 [ + + ]: 646 : std::set<int> sffo_set;
70 [ + + ]: 646 : if (sffo_instructions.isNull()) return sffo_set;
71 : :
72 [ + - + + ]: 194 : for (const auto& sffo : sffo_instructions.getValues()) {
73 : 102 : int pos{-1};
74 [ + + ]: 102 : if (sffo.isStr()) {
75 [ + - + + ]: 9 : auto it = find(destinations.begin(), destinations.end(), sffo.get_str());
76 [ + + + - : 10 : if (it == destinations.end()) throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', destination %s not found in tx outputs", sffo.get_str()));
+ - + - ]
77 : 8 : pos = it - destinations.begin();
78 [ + + ]: 93 : } else if (sffo.isNum()) {
79 [ + - ]: 92 : pos = sffo.getInt<int>();
80 : : } else {
81 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', invalid value type: %s", uvTypeName(sffo.type())));
+ - ]
82 : : }
83 : :
84 [ + + ]: 100 : if (sffo_set.contains(pos))
85 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', duplicated position: %d", pos));
86 [ + + ]: 98 : if (pos < 0)
87 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', negative position: %d", pos));
88 [ + + ]: 97 : if (pos >= int(destinations.size()))
89 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', position too large: %d", pos));
90 [ + - ]: 96 : sffo_set.insert(pos);
91 : : }
92 : : return sffo_set;
93 : 6 : }
94 : :
95 : 198 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, const CMutableTransaction& rawTx)
96 : : {
97 : : // Make a blank psbt
98 : 198 : PartiallySignedTransaction psbtx(rawTx);
99 : :
100 : : // First fill transaction with our data without signing,
101 : : // so external signers are not asked to sign more than once.
102 : 198 : bool complete;
103 [ + - ]: 198 : pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/false, /*bip32derivs=*/true);
104 [ + - ]: 198 : const auto err{pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/true, /*bip32derivs=*/false)};
105 [ - + ]: 198 : if (err) {
106 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
107 : : }
108 : :
109 [ + - ]: 198 : CMutableTransaction mtx;
110 [ + - ]: 198 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
111 : :
112 : 198 : UniValue result(UniValue::VOBJ);
113 : :
114 [ + - + - : 219 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
115 [ + - + + : 396 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
116 [ + + + + : 198 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
117 : : // Serialize the PSBT
118 : 54 : DataStream ssTx{};
119 [ + - ]: 54 : ssTx << psbtx;
120 [ + - + - : 108 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
121 : 54 : }
122 : :
123 [ + + ]: 198 : if (complete) {
124 [ + - + - ]: 172 : std::string hex{EncodeHexTx(CTransaction(mtx))};
125 [ + - ]: 172 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
126 [ + - + - : 344 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
127 [ + + ]: 172 : if (add_to_wallet && !psbt_opt_in) {
128 [ + - + - ]: 432 : pwallet->CommitTransaction(tx, {}, /*orderForm=*/{});
129 : : } else {
130 [ + - + - : 56 : result.pushKV("hex", hex);
+ - ]
131 : : }
132 : 172 : }
133 [ + - + - : 396 : result.pushKV("complete", complete);
+ - ]
134 : :
135 : 396 : return result;
136 : 198 : }
137 : :
138 : 303 : static void PreventOutdatedOptions(const UniValue& options)
139 : : {
140 [ + + ]: 606 : if (options.exists("feeRate")) {
141 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
142 : : }
143 [ - + ]: 604 : if (options.exists("changeAddress")) {
144 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
145 : : }
146 [ - + ]: 604 : if (options.exists("changePosition")) {
147 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
148 : : }
149 [ - + ]: 604 : if (options.exists("includeWatching")) {
150 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use include_watching instead of includeWatching");
151 : : }
152 [ - + ]: 604 : if (options.exists("lockUnspents")) {
153 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
154 : : }
155 [ - + ]: 604 : if (options.exists("subtractFeeFromOutputs")) {
156 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
157 : : }
158 : 302 : }
159 : :
160 : 1221 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, mapValue_t map_value, bool verbose)
161 : : {
162 : 1221 : EnsureWalletIsUnlocked(wallet);
163 : :
164 : : // This function is only used by sendtoaddress and sendmany.
165 : : // This should always try to sign, if we don't have private keys, don't try to do anything here.
166 [ - + ]: 1221 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
167 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
168 : : }
169 : :
170 : : // Shuffle recipient list
171 : 1221 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
172 : :
173 : : // Send
174 : 1221 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
175 [ + + ]: 1221 : if (!res) {
176 [ + - + - ]: 32 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
177 : : }
178 : 1205 : const CTransactionRef& tx = res->tx;
179 [ + - + - ]: 3615 : wallet.CommitTransaction(tx, std::move(map_value), /*orderForm=*/{});
180 [ + + ]: 1205 : if (verbose) {
181 : 2 : UniValue entry(UniValue::VOBJ);
182 [ + - + - : 4 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
183 [ + - + - : 4 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_calc.reason));
+ - + - ]
184 : 2 : return entry;
185 : 0 : }
186 [ + - + - ]: 1203 : return tx->GetHash().GetHex();
187 : 1205 : }
188 : :
189 : :
190 : : /**
191 : : * Update coin control with fee estimation based on the given parameters
192 : : *
193 : : * @param[in] wallet Wallet reference
194 : : * @param[in,out] cc Coin control to be updated
195 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
196 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
197 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
198 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
199 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
200 : : * verify only that fee_rate is greater than 0
201 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
202 : : */
203 : 1888 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
204 : : {
205 [ + + ]: 1888 : if (!fee_rate.isNull()) {
206 [ + + ]: 387 : if (!conf_target.isNull()) {
207 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
208 : : }
209 [ + + + + ]: 384 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
210 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
211 : : }
212 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
213 [ - + ]: 381 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
214 [ + + ]: 305 : if (override_min_fee) cc.fOverrideFeeRate = true;
215 : : // Default RBF to true for explicit fee_rate, if unset.
216 [ + + ]: 305 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
217 : 305 : return;
218 : : }
219 [ + + + + ]: 1501 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
220 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
221 : : }
222 [ + + ]: 1474 : if (!conf_target.isNull()) {
223 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().estimateMaxBlocks());
224 : : }
225 : : }
226 : :
227 : 1949 : RPCHelpMan sendtoaddress()
228 : : {
229 : 1949 : return RPCHelpMan{"sendtoaddress",
230 : 1949 : "\nSend an amount to a given address." +
231 [ + - ]: 1949 : HELP_REQUIRING_PASSPHRASE,
232 : : {
233 [ + - ]: 1949 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
234 [ + - ]: 3898 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
235 [ + - ]: 1949 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
236 : : "This is not part of the transaction, just kept in your wallet."},
237 [ + - ]: 1949 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
238 : : "to which you're sending the transaction. This is not part of the \n"
239 : : "transaction, just kept in your wallet."},
240 [ + - ]: 3898 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
241 : : "The recipient will receive less bitcoins than you enter in the amount field."},
242 [ + - ]: 3898 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
243 [ + - ]: 3898 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
244 [ + - ]: 3898 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
245 [ + - + - ]: 3898 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
246 [ + - ]: 3898 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
247 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
248 [ + - ]: 5847 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
249 [ + - ]: 3898 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
250 : : },
251 : : {
252 : : RPCResult{"if verbose is not set or set to false",
253 : : RPCResult::Type::STR_HEX, "txid", "The transaction id."
254 [ + - + - : 3898 : },
+ - + - ]
255 : : RPCResult{"if verbose is set to true",
256 : : RPCResult::Type::OBJ, "", "",
257 : : {
258 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
259 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
260 : : },
261 [ + - + - : 7796 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
262 : : },
263 : 1949 : RPCExamples{
264 : : "\nSend 0.1 BTC\n"
265 [ + - + - : 5847 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
266 : 1949 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
267 [ + - + - : 9745 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
268 [ + - ]: 3898 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
269 [ + - + - : 9745 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
270 : 1949 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
271 [ + - + - : 9745 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
272 [ + - ]: 3898 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
273 [ + - + - : 9745 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
274 [ + - + - : 7796 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
275 [ + - ]: 1949 : },
276 : 1173 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
277 : : {
278 : 1173 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
279 [ - + ]: 1173 : if (!pwallet) return UniValue::VNULL;
280 : :
281 : : // Make sure the results are valid at least up to the most recent block
282 : : // the user could have gotten from another RPC command prior to now
283 [ + - ]: 1173 : pwallet->BlockUntilSyncedToCurrentChain();
284 : :
285 [ + - ]: 1173 : LOCK(pwallet->cs_wallet);
286 : :
287 : : // Wallet comments
288 [ + - ]: 1173 : mapValue_t mapValue;
289 [ + - + + : 1173 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
290 [ + - + - : 2 : mapValue["comment"] = request.params[2].get_str();
+ - + - +
- ]
291 [ + - + + : 1173 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
292 [ + - + - : 2 : mapValue["to"] = request.params[3].get_str();
+ - + - +
- ]
293 : :
294 [ + - ]: 1173 : CCoinControl coin_control;
295 [ + - + + ]: 1173 : if (!request.params[5].isNull()) {
296 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
297 : : }
298 : :
299 [ + - + - ]: 1173 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
300 : : // We also enable partial spend avoidance if reuse avoidance is set.
301 : 1173 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
302 : :
303 [ + - + - : 1173 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
304 : :
305 [ + + ]: 1173 : EnsureWalletIsUnlocked(*pwallet);
306 : :
307 : 1172 : UniValue address_amounts(UniValue::VOBJ);
308 [ + - + - : 1172 : const std::string address = request.params[0].get_str();
+ - ]
309 [ + - + - : 2344 : address_amounts.pushKV(address, request.params[1]);
+ - + - ]
310 : :
311 [ + - ]: 1172 : std::set<int> sffo_set;
312 [ + - + + : 1172 : if (!request.params[4].isNull() && request.params[4].get_bool()) {
+ - + - +
+ ]
313 [ + - ]: 216 : sffo_set.insert(0);
314 : : }
315 : :
316 [ + + + - ]: 1172 : std::vector<CRecipient> recipients{CreateRecipients(ParseOutputs(address_amounts), sffo_set)};
317 [ + - + + : 1170 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
318 : :
319 [ + - + + ]: 1174 : return SendMoney(*pwallet, coin_control, recipients, mapValue, verbose);
320 [ + - ]: 3535 : },
321 [ + - + - : 113042 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
322 [ + - + - : 54572 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- ]
323 : :
324 : 856 : RPCHelpMan sendmany()
325 : : {
326 : 856 : return RPCHelpMan{"sendmany",
327 : 856 : "Send multiple times. Amounts are double-precision floating point numbers." +
328 [ + - ]: 856 : HELP_REQUIRING_PASSPHRASE,
329 : : {
330 [ + - ]: 1712 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
331 [ + - + - ]: 1712 : RPCArgOptions{
332 : : .oneline_description = "\"\"",
333 : : }},
334 [ + - ]: 856 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
335 : : {
336 [ + - ]: 1712 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
337 : : },
338 : : },
339 [ + - ]: 856 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value"},
340 [ + - ]: 856 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
341 [ + - ]: 856 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
342 : : "The fee will be equally deducted from the amount of each selected address.\n"
343 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
344 : : "If no addresses are specified here, the sender pays the fee.",
345 : : {
346 [ + - ]: 856 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
347 : : },
348 : : },
349 [ + - ]: 1712 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
350 [ + - ]: 1712 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
351 [ + - ]: 1712 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
352 [ + - + - ]: 1712 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
353 [ + - ]: 2568 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
354 [ + - ]: 1712 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
355 : : },
356 : : {
357 : : RPCResult{"if verbose is not set or set to false",
358 : : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
359 : : "the number of addresses."
360 [ + - + - : 1712 : },
+ - + - ]
361 : : RPCResult{"if verbose is set to true",
362 : : RPCResult::Type::OBJ, "", "",
363 : : {
364 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
365 : : "the number of addresses."},
366 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
367 : : },
368 [ + - + - : 3424 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
369 : : },
370 : 856 : RPCExamples{
371 : : "\nSend two amounts to two different addresses:\n"
372 [ + - + - : 3424 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
373 : 856 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
374 [ + - + - : 5136 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
375 : 856 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
376 [ + - + - : 6848 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
377 : 856 : "\nAs a JSON-RPC call\n"
378 [ + - + - : 4280 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
379 [ + - ]: 856 : },
380 : 80 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
381 : : {
382 : 80 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
383 [ - + ]: 80 : if (!pwallet) return UniValue::VNULL;
384 : :
385 : : // Make sure the results are valid at least up to the most recent block
386 : : // the user could have gotten from another RPC command prior to now
387 [ + - ]: 80 : pwallet->BlockUntilSyncedToCurrentChain();
388 : :
389 [ + - ]: 80 : LOCK(pwallet->cs_wallet);
390 : :
391 [ + - + + : 80 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
392 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
393 : : }
394 [ + - + - : 80 : UniValue sendTo = request.params[1].get_obj();
+ - ]
395 : :
396 [ + - ]: 80 : mapValue_t mapValue;
397 [ + - + + : 80 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
398 [ # # # # : 0 : mapValue["comment"] = request.params[3].get_str();
# # # # #
# ]
399 : :
400 [ + - ]: 80 : CCoinControl coin_control;
401 [ + - - + ]: 80 : if (!request.params[5].isNull()) {
402 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
403 : : }
404 : :
405 [ + - + - : 80 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
406 : :
407 : 57 : std::vector<CRecipient> recipients = CreateRecipients(
408 [ + - ]: 102 : ParseOutputs(sendTo),
409 [ + - + - : 57 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ + ]
410 [ + - ]: 51 : );
411 [ + - + + : 51 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
412 : :
413 [ + + ]: 63 : return SendMoney(*pwallet, coin_control, recipients, std::move(mapValue), verbose);
414 [ + - ]: 252 : },
415 [ + - + - : 50504 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
416 [ + - + - : 24824 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
417 : :
418 : 795 : RPCHelpMan settxfee()
419 : : {
420 : 795 : return RPCHelpMan{"settxfee",
421 [ + - ]: 1590 : "\n(DEPRECATED) Set the transaction fee rate in " + CURRENCY_UNIT + "/kvB for this wallet. Overrides the global -paytxfee command line parameter.\n"
422 : 795 : "Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.\n",
423 : : {
424 [ + - ]: 1590 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The transaction fee rate in " + CURRENCY_UNIT + "/kvB"},
425 : : },
426 : 0 : RPCResult{
427 : : RPCResult::Type::BOOL, "", "Returns true if successful"
428 [ + - + - : 1590 : },
+ - ]
429 : 795 : RPCExamples{
430 [ + - + - : 1590 : HelpExampleCli("settxfee", "0.00001")
+ - ]
431 [ + - + - : 3180 : + HelpExampleRpc("settxfee", "0.00001")
+ - + - ]
432 [ + - ]: 795 : },
433 : 19 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
434 : : {
435 : 19 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
436 [ - + ]: 19 : if (!pwallet) return UniValue::VNULL;
437 : :
438 [ + - ]: 19 : LOCK(pwallet->cs_wallet);
439 : :
440 [ + - + - : 19 : if (!pwallet->chain().rpcEnableDeprecated("settxfee")) {
+ + ]
441 [ + - ]: 1 : throw JSONRPCError(RPC_METHOD_DEPRECATED, "settxfee is deprecated and will be fully removed in v31.0."
442 [ + - + - ]: 2 : "\nTo use settxfee restart bitcoind with -deprecatedrpc=settxfee.");
443 : : }
444 : :
445 [ + - + - ]: 18 : CAmount nAmount = AmountFromValue(request.params[0]);
446 [ + - ]: 18 : CFeeRate tx_fee_rate(nAmount, 1000);
447 [ + - ]: 18 : CFeeRate max_tx_fee_rate(pwallet->m_default_max_tx_fee, 1000);
448 [ + + ]: 18 : if (tx_fee_rate == CFeeRate(0)) {
449 : : // automatic selection
450 [ + - + + ]: 16 : } else if (tx_fee_rate < pwallet->chain().relayMinFee()) {
451 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than min relay tx fee (%s)", pwallet->chain().relayMinFee().ToString()));
+ - + - ]
452 [ + + ]: 15 : } else if (tx_fee_rate < pwallet->m_min_fee) {
453 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than wallet min fee (%s)", pwallet->m_min_fee.ToString()));
+ - ]
454 [ + + ]: 14 : } else if (tx_fee_rate > max_tx_fee_rate) {
455 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be more than wallet max tx fee (%s)", max_tx_fee_rate.ToString()));
+ - ]
456 : : }
457 : :
458 [ + - ]: 15 : pwallet->m_pay_tx_fee = tx_fee_rate;
459 [ + - ]: 15 : return true;
460 : 34 : },
461 [ + - + - : 8745 : };
+ - + - +
- + + -
- ]
462 [ + - + - ]: 2385 : }
463 : :
464 : :
465 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
466 : 3798 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
467 : : {
468 : 3798 : std::vector<RPCArg> args = {
469 [ + - + - ]: 15192 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
470 [ + - ]: 7596 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
471 [ + - + - : 7596 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - ]
472 : : {
473 [ + - ]: 7596 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
474 : : "Allows this transaction to be replaced by a transaction with higher fees"
475 : : },
476 [ + - + - : 60768 : };
+ - + - +
- + - + -
+ + - - ]
477 [ + - ]: 3798 : if (solving_data) {
478 [ + - + - : 102546 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + + +
+ + - - -
- - - -
- ]
479 : : "Used for fee estimation during coin selection.",
480 : : {
481 : : {
482 : 7596 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
483 : : {
484 [ + - ]: 3798 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
485 : : }
486 : : },
487 : : {
488 : 7596 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
489 : : {
490 [ + - ]: 3798 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
491 : : }
492 : : },
493 : : {
494 : 7596 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
495 : : {
496 [ + - ]: 3798 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
497 : : }
498 : : },
499 : : }
500 : : });
501 : : }
502 : 3798 : return args;
503 [ + - + - : 72162 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - ]
504 : :
505 : 586 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
506 : : {
507 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
508 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
509 : 586 : CHECK_NONFATAL(tx.vout.empty());
510 : : // Make sure the results are valid at least up to the most recent block
511 : : // the user could have gotten from another RPC command prior to now
512 : 586 : wallet.BlockUntilSyncedToCurrentChain();
513 : :
514 : 586 : std::optional<unsigned int> change_position;
515 : 586 : bool lockUnspents = false;
516 [ + + ]: 586 : if (!options.isNull()) {
517 [ + + ]: 528 : if (options.type() == UniValue::VBOOL) {
518 : : // backward compatibility bool only fallback
519 : 1 : coinControl.fAllowWatchOnly = options.get_bool();
520 : : }
521 : : else {
522 [ + + + + : 15306 : RPCTypeCheckObj(options,
+ + ]
523 : : {
524 [ + - ]: 527 : {"add_inputs", UniValueType(UniValue::VBOOL)},
525 [ + - ]: 527 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
526 [ + - ]: 527 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
527 [ + - ]: 527 : {"changeAddress", UniValueType(UniValue::VSTR)},
528 [ + - ]: 527 : {"change_address", UniValueType(UniValue::VSTR)},
529 [ + - ]: 527 : {"changePosition", UniValueType(UniValue::VNUM)},
530 [ + - ]: 527 : {"change_position", UniValueType(UniValue::VNUM)},
531 [ + - ]: 527 : {"change_type", UniValueType(UniValue::VSTR)},
532 [ + - ]: 527 : {"includeWatching", UniValueType(UniValue::VBOOL)},
533 [ + - ]: 527 : {"include_watching", UniValueType(UniValue::VBOOL)},
534 [ + - ]: 527 : {"inputs", UniValueType(UniValue::VARR)},
535 [ + - ]: 527 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
536 [ + - ]: 527 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
537 [ + - ]: 527 : {"locktime", UniValueType(UniValue::VNUM)},
538 [ + - ]: 527 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
539 [ + - ]: 527 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
540 [ + - ]: 527 : {"psbt", UniValueType(UniValue::VBOOL)},
541 [ + - ]: 527 : {"solving_data", UniValueType(UniValue::VOBJ)},
542 [ + - ]: 527 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
543 [ + - ]: 527 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
544 [ + - ]: 527 : {"replaceable", UniValueType(UniValue::VBOOL)},
545 [ + - ]: 527 : {"conf_target", UniValueType(UniValue::VNUM)},
546 [ + - ]: 527 : {"estimate_mode", UniValueType(UniValue::VSTR)},
547 [ + - ]: 527 : {"minconf", UniValueType(UniValue::VNUM)},
548 [ + - ]: 527 : {"maxconf", UniValueType(UniValue::VNUM)},
549 [ + - ]: 527 : {"input_weights", UniValueType(UniValue::VARR)},
550 [ + - ]: 527 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
551 : : },
552 : : true, true);
553 : :
554 [ + + ]: 1008 : if (options.exists("add_inputs")) {
555 [ + - + - ]: 171 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
556 : : }
557 : :
558 [ + - + - : 1503 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
559 [ + + + - : 39 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - + -
+ + + + -
- - - ]
560 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
561 : :
562 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
563 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
564 : : }
565 : :
566 [ + - ]: 22 : coinControl.destChange = dest;
567 : 15 : }
568 : :
569 [ + - + - : 1502 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
570 [ + + + - : 111 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
571 [ + - + + ]: 37 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
572 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
573 : : }
574 : 36 : change_position = (unsigned int)pos;
575 : : }
576 : :
577 [ + + ]: 1002 : if (options.exists("change_type")) {
578 [ + - + - : 227 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
579 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
580 : : }
581 [ + - + + : 150 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
+ - + + ]
582 [ - + ]: 146 : coinControl.m_change_type.emplace(parsed.value());
583 : : } else {
584 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
585 : : }
586 : : }
587 : :
588 [ + + + - : 1494 : const UniValue include_watching_option = options.exists("include_watching") ? options["include_watching"] : options["includeWatching"];
+ - + - +
- + - + +
+ + - - -
- ]
589 [ + - ]: 498 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(include_watching_option, wallet);
590 : :
591 [ + - + - : 1491 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
592 [ + - + + : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + -
+ + + + -
- - - ]
593 : : }
594 : :
595 [ + - + + ]: 996 : if (options.exists("include_unsafe")) {
596 [ + - + - : 5 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
+ - ]
597 : : }
598 : :
599 [ + - + + ]: 996 : if (options.exists("feeRate")) {
600 [ + - + + ]: 116 : if (options.exists("fee_rate")) {
601 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
602 : : }
603 [ + - + + ]: 112 : if (options.exists("conf_target")) {
604 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
605 : : }
606 [ + - + + ]: 108 : if (options.exists("estimate_mode")) {
607 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
608 : : }
609 [ + - + - : 104 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
+ + - + ]
610 : 36 : coinControl.fOverrideFeeRate = true;
611 : : }
612 : :
613 [ + - + + ]: 952 : if (options.exists("replaceable")) {
614 [ + - + - : 7 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
615 : : }
616 : :
617 [ + - + + ]: 952 : if (options.exists("minconf")) {
618 [ + - + - : 8 : coinControl.m_min_depth = options["minconf"].getInt<int>();
+ - ]
619 : :
620 [ + + ]: 8 : if (coinControl.m_min_depth < 0) {
621 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
622 : : }
623 : : }
624 : :
625 [ + - + + ]: 950 : if (options.exists("maxconf")) {
626 [ + - + - : 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
627 : :
628 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
629 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
630 : : }
631 : : }
632 [ + - + - : 1144 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + - +
+ ]
633 : 498 : }
634 : : } else {
635 : : // if options is null and not a bool
636 : 58 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(NullUniValue, wallet);
637 : : }
638 : :
639 [ + + ]: 874 : if (options.exists("solving_data")) {
640 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
641 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
642 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
643 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
644 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
645 : : // Add witness script for pubkeys
646 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
647 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
648 : 3 : }
649 : : }
650 : :
651 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
652 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
653 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
654 [ + - + + ]: 6 : if (!IsHex(script_str)) {
655 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
656 : : }
657 [ + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
658 : 5 : const CScript script(script_data.begin(), script_data.end());
659 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
660 : 5 : }
661 : : }
662 : :
663 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
664 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
665 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
666 : 8 : FlatSigningProvider desc_out;
667 [ + - ]: 8 : std::string error;
668 : 8 : std::vector<CScript> scripts_temp;
669 [ + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
670 [ + + ]: 8 : if (descs.empty()) {
671 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
672 : : }
673 [ + + ]: 14 : for (auto& desc : descs) {
674 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
675 : : }
676 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
677 : 10 : }
678 : : }
679 : 14 : }
680 : :
681 [ + + ]: 866 : if (options.exists("input_weights")) {
682 [ + - + - : 2594 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
683 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
684 : :
685 : 2491 : const UniValue& vout_v = input.find_value("vout");
686 [ + + ]: 2491 : if (!vout_v.isNum()) {
687 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
688 : : }
689 : 2490 : int vout = vout_v.getInt<int>();
690 [ + + ]: 2490 : if (vout < 0) {
691 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
692 : : }
693 : :
694 : 2489 : const UniValue& weight_v = input.find_value("weight");
695 [ + + ]: 2489 : if (!weight_v.isNum()) {
696 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
697 : : }
698 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
699 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
700 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
701 [ + + ]: 2488 : if (weight < min_input_weight) {
702 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
703 : : }
704 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
705 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
706 : : }
707 : :
708 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
709 : : }
710 : : }
711 : :
712 [ + + ]: 854 : if (options.exists("max_tx_weight")) {
713 [ + - + - ]: 8 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
714 : : }
715 : :
716 [ - + ]: 427 : if (recipients.empty())
717 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
718 : :
719 [ + - ]: 427 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
720 [ + + ]: 427 : if (!txr) {
721 [ + - + - ]: 138 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
722 : : }
723 : 358 : return *txr;
724 [ + - + - : 908 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
725 : :
726 : 402 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
727 : : {
728 [ + + ]: 804 : if (options.exists("input_weights")) {
729 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
730 : : }
731 [ + + ]: 400 : if (inputs.size() == 0) {
732 : : return;
733 : : }
734 : 139 : UniValue weights(UniValue::VARR);
735 [ + - + + ]: 2892 : for (const UniValue& input : inputs.getValues()) {
736 [ + - + + ]: 5506 : if (input.exists("weight")) {
737 [ + - + - ]: 6 : weights.push_back(input);
738 : : }
739 : : }
740 [ + - + - ]: 278 : options.pushKV("input_weights", std::move(weights));
741 : 139 : }
742 : :
743 : 962 : RPCHelpMan fundrawtransaction()
744 : : {
745 : 962 : return RPCHelpMan{"fundrawtransaction",
746 : : "\nIf the transaction has no inputs, they will be automatically selected to meet its out value.\n"
747 : : "It will add at most one change output to the outputs.\n"
748 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
749 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
750 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
751 : : "or signrawtransactionwithwallet for that.\n"
752 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
753 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
754 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
755 : : "in the wallet using importdescriptors (to calculate fees).\n"
756 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
757 : : "Only pay-to-pubkey, multisig, and P2SH versions thereof are currently supported for watch-only\n",
758 : : {
759 [ + - ]: 962 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
760 [ + - ]: 962 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "For backward compatibility: passing in a true instead of an object will result in {\"includeWatching\":true}",
761 [ + - + - : 76960 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
762 : : {
763 [ + - ]: 1924 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
764 [ + - ]: 1924 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
765 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
766 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
767 [ + - ]: 1924 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
768 [ + - ]: 962 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
769 [ + - ]: 1924 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
770 [ + - ]: 1924 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
771 [ + - ]: 1924 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
772 [ + - ]: 1924 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
773 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
774 : : "e.g. with 'importdescriptors'."},
775 [ + - ]: 1924 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
776 [ + - + - ]: 3848 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
777 [ + - + - ]: 3848 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
778 : 1924 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
779 : : "The fee will be equally deducted from the amount of each specified output.\n"
780 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
781 : : "If no outputs are specified here, the sender pays the fee.",
782 : : {
783 [ + - ]: 962 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
784 : : },
785 : : },
786 [ + - ]: 962 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
787 : : {
788 [ + - ]: 962 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
789 : : {
790 [ + - ]: 962 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
791 [ + - ]: 962 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
792 [ + - ]: 962 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
793 : : "including the weight of the outpoint and sequence number. "
794 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
795 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
796 : : "Remember to convert serialized sizes to weight units when necessary."},
797 : : },
798 : : },
799 : : },
800 : : },
801 [ + - ]: 1924 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
802 : : "Transaction building will fail if this can not be satisfied."},
803 : : },
804 [ + - ]: 1924 : FundTxDoc()),
805 [ + - + - ]: 1924 : RPCArgOptions{
806 : : .skip_type_check = true,
807 : : .oneline_description = "options",
808 : : }},
809 [ + - ]: 1924 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
810 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
811 : : "If true, only witness deserialization will be tried.\n"
812 : : "If false, only non-witness deserialization will be tried.\n"
813 : : "This boolean should reflect whether the transaction has inputs\n"
814 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
815 : : },
816 : : },
817 : 0 : RPCResult{
818 : : RPCResult::Type::OBJ, "", "",
819 : : {
820 : : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
821 [ + - ]: 1924 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
822 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
823 : : }
824 [ + - + - : 6734 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
825 : 962 : RPCExamples{
826 : : "\nCreate a transaction with no inputs\n"
827 [ + - + - : 1924 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
828 : 962 : "\nAdd sufficient unsigned inputs to meet the output value\n"
829 [ + - + - : 3848 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
830 : 962 : "\nSign the transaction\n"
831 [ + - + - : 3848 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
832 : 962 : "\nSend the transaction\n"
833 [ + - + - : 3848 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
834 [ + - ]: 962 : },
835 : 186 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
836 : : {
837 : 186 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
838 [ - + ]: 186 : if (!pwallet) return UniValue::VNULL;
839 : :
840 : : // parse hex string from parameter
841 [ + - ]: 186 : CMutableTransaction tx;
842 [ + - - + : 186 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
843 [ + - - + : 186 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
844 [ + - + - : 186 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
845 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
846 : : }
847 [ + - + - ]: 186 : UniValue options = request.params[1];
848 : 186 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
849 [ + + ]: 11986 : for (const auto& tx_out : tx.vout) {
850 : 11800 : CTxDestination dest;
851 [ + - ]: 11800 : ExtractDestination(tx_out.scriptPubKey, dest);
852 [ + - ]: 11800 : destinations.emplace_back(dest, tx_out.nValue);
853 : 11800 : }
854 [ + - + - ]: 186 : std::vector<std::string> dummy(destinations.size(), "dummy");
855 [ + - ]: 186 : std::vector<CRecipient> recipients = CreateRecipients(
856 : : destinations,
857 [ + - + - : 372 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
858 [ + - ]: 186 : );
859 [ + - ]: 186 : CCoinControl coin_control;
860 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
861 : 186 : coin_control.m_allow_other_inputs = true;
862 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
863 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
864 : 186 : tx.vout.clear();
865 [ + + ]: 186 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
866 : :
867 : 107 : UniValue result(UniValue::VOBJ);
868 [ + - + - : 214 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
869 [ + - + - : 214 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
870 [ + + + - : 214 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
871 : :
872 : 107 : return result;
873 [ + - ]: 902 : },
874 [ + - + - : 16354 : };
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
875 [ + - + - : 46176 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
876 : :
877 : 1067 : RPCHelpMan signrawtransactionwithwallet()
878 : : {
879 : 1067 : return RPCHelpMan{"signrawtransactionwithwallet",
880 : : "\nSign inputs for raw transaction (serialized, hex-encoded).\n"
881 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
882 : 1067 : "this transaction depends on but may not yet be in the block chain." +
883 [ + - ]: 1067 : HELP_REQUIRING_PASSPHRASE,
884 : : {
885 [ + - ]: 1067 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
886 [ + - ]: 1067 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
887 : : {
888 [ + - ]: 1067 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
889 : : {
890 [ + - ]: 1067 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
891 [ + - ]: 1067 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
892 [ + - ]: 1067 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
893 [ + - ]: 1067 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
894 [ + - ]: 1067 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
895 [ + - ]: 1067 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
896 : : },
897 : : },
898 : : },
899 : : },
900 [ + - ]: 2134 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
901 : : " \"DEFAULT\"\n"
902 : : " \"ALL\"\n"
903 : : " \"NONE\"\n"
904 : : " \"SINGLE\"\n"
905 : : " \"ALL|ANYONECANPAY\"\n"
906 : : " \"NONE|ANYONECANPAY\"\n"
907 : : " \"SINGLE|ANYONECANPAY\""},
908 : : },
909 : 0 : RPCResult{
910 : : RPCResult::Type::OBJ, "", "",
911 : : {
912 : : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
913 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
914 : : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
915 : : {
916 : : {RPCResult::Type::OBJ, "", "",
917 : : {
918 : : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
919 : : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
920 : : {RPCResult::Type::ARR, "witness", "",
921 : : {
922 : : {RPCResult::Type::STR_HEX, "witness", ""},
923 : : }},
924 : : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
925 : : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
926 : : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
927 : : }},
928 : : }},
929 : : }
930 [ + - + - : 17072 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
931 : 1067 : RPCExamples{
932 [ + - + - : 2134 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
933 [ + - + - : 4268 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
934 [ + - ]: 1067 : },
935 : 291 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
936 : : {
937 [ - + ]: 291 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
938 [ - + ]: 291 : if (!pwallet) return UniValue::VNULL;
939 : :
940 [ + - ]: 291 : CMutableTransaction mtx;
941 [ + - + - : 291 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
942 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
943 : : }
944 : :
945 : : // Sign the transaction
946 [ + - ]: 291 : LOCK(pwallet->cs_wallet);
947 [ + + ]: 291 : EnsureWalletIsUnlocked(*pwallet);
948 : :
949 : : // Fetch previous transactions (inputs):
950 : 290 : std::map<COutPoint, Coin> coins;
951 [ + + ]: 1036 : for (const CTxIn& txin : mtx.vin) {
952 [ + - ]: 746 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
953 : : }
954 [ + - ]: 290 : pwallet->chain().findCoins(coins);
955 : :
956 : : // Parse the prevtxs array
957 [ + - + + ]: 290 : ParsePrevouts(request.params[1], nullptr, coins);
958 : :
959 [ + - + + ]: 281 : int nHashType = ParseSighashString(request.params[2]);
960 : :
961 : : // Script verification errors
962 [ + - ]: 280 : std::map<int, bilingual_str> input_errors;
963 : :
964 [ + - ]: 280 : bool complete = pwallet->SignTransaction(mtx, coins, nHashType, input_errors);
965 : 280 : UniValue result(UniValue::VOBJ);
966 [ + + ]: 280 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
967 : 278 : return result;
968 [ + - ]: 1154 : },
969 [ + - + - : 42680 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - ]
970 [ + - + - : 35211 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
971 : :
972 : : // Definition of allowed formats of specifying transaction outputs in
973 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
974 : 3671 : static std::vector<RPCArg> OutputsDoc()
975 : : {
976 : 3671 : return
977 : : {
978 [ + - ]: 3671 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
979 : : {
980 [ + - ]: 3671 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
981 : 3671 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
982 : : },
983 : : },
984 [ + - ]: 3671 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
985 : : {
986 [ + - ]: 3671 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data that becomes a part of an OP_RETURN output"},
987 : : },
988 : : },
989 [ + - + - : 51394 : };
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
990 [ + - + - : 33039 : }
+ - + - +
- - - ]
991 : :
992 : 1711 : static RPCHelpMan bumpfee_helper(std::string method_name)
993 : : {
994 : 1711 : const bool want_psbt = method_name == "psbtbumpfee";
995 : 1711 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeEstimateMode::SAT_VB)};
996 : :
997 : 1711 : return RPCHelpMan{method_name,
998 : : "Bumps the fee of a transaction T, replacing it with a new transaction B.\n"
999 [ + + + - : 4350 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
+ - ]
1000 : : "A transaction with the given txid must be in the wallet.\n"
1001 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
1002 : : "It may add a new change output if one does not already exist.\n"
1003 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
1004 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
1005 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
1006 : : "The user can specify a confirmation target for estimatesmartfee.\n"
1007 [ + - ]: 3422 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
1008 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
1009 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
1010 [ + - + - ]: 5133 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
1011 : : {
1012 [ + - ]: 1711 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
1013 [ + - ]: 1711 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1014 : : {
1015 [ + - ]: 3422 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
1016 [ + - ]: 3422 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
1017 : 1711 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
1018 [ + - ]: 3422 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
1019 [ + - + - ]: 5133 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
1020 [ + - ]: 3422 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true},
1021 : : "Whether the new transaction should be\n"
1022 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
1023 : : "be set to 0xfffffffd. If false, any input sequence numbers in the\n"
1024 : : "transaction will be set to 0xfffffffe\n"
1025 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
1026 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
1027 : : "are replaceable).\n"},
1028 [ + - ]: 3422 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1029 [ + - + - ]: 3422 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1030 : 3422 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1031 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1032 : : "At least one output of either type must be specified.\n"
1033 : : "Cannot be provided if 'original_change_index' is specified.",
1034 [ + - ]: 3422 : OutputsDoc(),
1035 [ + - ]: 3422 : RPCArgOptions{.skip_type_check = true}},
1036 [ + - ]: 3422 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
1037 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1038 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1039 : : "original change output. The change output’s amount can increase if bumping the transaction "
1040 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1041 : : },
1042 [ + - + - ]: 1711 : RPCArgOptions{.oneline_description="options"}},
1043 : : },
1044 : 0 : RPCResult{
1045 [ + - + - : 15399 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1046 [ + + + - : 8555 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1047 [ + - + - : 4843 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ - + + +
+ + + - -
- - - - ]
1048 [ + - + - : 5423 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ - + + +
+ + + - -
- - - - ]
1049 : : {
1050 : : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1051 : : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1052 : : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1053 : : {
1054 : : {RPCResult::Type::STR, "", ""},
1055 : : }},
1056 : : })
1057 [ + - + - : 5133 : },
+ - ]
1058 : 1711 : RPCExamples{
1059 [ + + + - : 4350 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1060 [ + - + - : 5133 : HelpExampleCli(method_name, "<txid>")
+ - ]
1061 : 1711 : },
1062 [ + - ]: 1711 : [want_psbt](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1063 : : {
1064 : 159 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1065 [ - + ]: 159 : if (!pwallet) return UniValue::VNULL;
1066 : :
1067 [ + - + + : 159 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1068 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1069 : : }
1070 : :
1071 [ + - + - ]: 158 : uint256 hash(ParseHashV(request.params[0], "txid"));
1072 : :
1073 [ + - ]: 158 : CCoinControl coin_control;
1074 [ + - ]: 158 : coin_control.fAllowWatchOnly = pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS);
1075 : : // optional parameters
1076 [ + - ]: 158 : coin_control.m_signal_bip125_rbf = true;
1077 : 158 : std::vector<CTxOut> outputs;
1078 : :
1079 : 158 : std::optional<uint32_t> original_change_index;
1080 : :
1081 [ + - + + ]: 158 : if (!request.params[1].isNull()) {
1082 [ + - + - ]: 67 : UniValue options = request.params[1];
1083 [ + + + + : 607 : RPCTypeCheckObj(options,
+ + ]
1084 : : {
1085 [ + - ]: 67 : {"confTarget", UniValueType(UniValue::VNUM)},
1086 [ + - ]: 67 : {"conf_target", UniValueType(UniValue::VNUM)},
1087 [ + - ]: 67 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1088 [ + - ]: 67 : {"replaceable", UniValueType(UniValue::VBOOL)},
1089 [ + - ]: 67 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1090 [ + - ]: 67 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1091 [ + - ]: 67 : {"original_change_index", UniValueType(UniValue::VNUM)},
1092 : : },
1093 : : true, true);
1094 : :
1095 [ + - + - : 127 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1096 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1097 : : }
1098 : :
1099 [ + - - + : 186 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1100 : :
1101 [ + - + + ]: 124 : if (options.exists("replaceable")) {
1102 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1103 : : }
1104 [ + - + - : 143 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1105 : :
1106 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1107 [ + - + - : 43 : if (!options["outputs"].isNull()) {
+ + ]
1108 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- + + + +
- - ]
1109 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1110 : : }
1111 [ + - ]: 10 : CMutableTransaction tempTx;
1112 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1113 [ + - ]: 8 : outputs = tempTx.vout;
1114 : 10 : }
1115 : :
1116 [ + - + + ]: 80 : if (options.exists("original_change_index")) {
1117 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1118 : : }
1119 : 90 : }
1120 : :
1121 : : // Make sure the results are valid at least up to the most recent block
1122 : : // the user could have gotten from another RPC command prior to now
1123 [ + - ]: 130 : pwallet->BlockUntilSyncedToCurrentChain();
1124 : :
1125 [ + - ]: 130 : LOCK(pwallet->cs_wallet);
1126 : :
1127 [ + + ]: 130 : EnsureWalletIsUnlocked(*pwallet);
1128 : :
1129 : :
1130 : 129 : std::vector<bilingual_str> errors;
1131 : 129 : CAmount old_fee;
1132 : 129 : CAmount new_fee;
1133 [ + - ]: 129 : CMutableTransaction mtx;
1134 : 129 : feebumper::Result res;
1135 : : // Targeting feerate bump.
1136 [ + - ]: 129 : res = feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index);
1137 [ + + ]: 129 : if (res != feebumper::Result::OK) {
1138 [ - - + + : 23 : switch(res) {
+ ]
1139 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1140 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1141 : 0 : break;
1142 : 0 : case feebumper::Result::INVALID_REQUEST:
1143 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1144 : 16 : break;
1145 : 16 : case feebumper::Result::INVALID_PARAMETER:
1146 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1147 : 6 : break;
1148 : 6 : case feebumper::Result::WALLET_ERROR:
1149 [ + - ]: 6 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1150 : 1 : break;
1151 : 1 : default:
1152 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1153 : 106 : break;
1154 : : }
1155 : : }
1156 : :
1157 : 212 : UniValue result(UniValue::VOBJ);
1158 : :
1159 : : // For bumpfee, return the new transaction id.
1160 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1161 [ + + ]: 106 : if (!want_psbt) {
1162 [ + - - + ]: 99 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1163 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1164 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1165 : : }
1166 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1167 : : }
1168 : :
1169 : 99 : uint256 txid;
1170 [ + - - + ]: 99 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1171 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1172 : : }
1173 : :
1174 [ + - + - : 198 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1175 : : } else {
1176 [ + - ]: 7 : PartiallySignedTransaction psbtx(mtx);
1177 : 7 : bool complete = false;
1178 [ + - ]: 7 : const auto err{pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/false, /*bip32derivs=*/true)};
1179 [ + - ]: 7 : CHECK_NONFATAL(!err);
1180 [ + - ]: 7 : CHECK_NONFATAL(!complete);
1181 : 7 : DataStream ssTx{};
1182 [ + - ]: 7 : ssTx << psbtx;
1183 [ + - + - : 14 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1184 : 7 : }
1185 : :
1186 [ + - + - : 212 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1187 [ + - + - : 212 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1188 : 212 : UniValue result_errors(UniValue::VARR);
1189 [ - + ]: 106 : for (const bilingual_str& error : errors) {
1190 [ # # # # ]: 0 : result_errors.push_back(error.original);
1191 : : }
1192 [ + - + - ]: 212 : result.pushKV("errors", std::move(result_errors));
1193 : :
1194 : 106 : return result;
1195 [ + - + - : 516 : },
+ - + - +
- + - + -
+ - + - -
+ ]
1196 [ + - + - : 75284 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
1197 [ + - + - : 39353 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
1198 : :
1199 [ + - ]: 1856 : RPCHelpMan bumpfee() { return bumpfee_helper("bumpfee"); }
1200 [ + - ]: 1566 : RPCHelpMan psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1201 : :
1202 : 983 : RPCHelpMan send()
1203 : : {
1204 : 983 : return RPCHelpMan{"send",
1205 : : "\nEXPERIMENTAL warning: this call may be changed in future releases.\n"
1206 : : "\nSend a transaction.\n",
1207 : : {
1208 [ + - ]: 983 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1209 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1210 : : "At least one output of either type must be specified.\n"
1211 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1212 [ + - ]: 1966 : OutputsDoc(),
1213 [ + - ]: 1966 : RPCArgOptions{.skip_type_check = true}},
1214 [ + - ]: 1966 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1215 [ + - ]: 1966 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1216 [ + - + - ]: 1966 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1217 [ + - ]: 2949 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1218 [ + - ]: 983 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1219 [ + - + - : 98300 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + +
+ + + + +
- - - - -
- - - ]
1220 : : {
1221 [ + - ]: 1966 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
1222 [ + - ]: 1966 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1223 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1224 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1225 [ + - ]: 1966 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1226 [ + - ]: 983 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1227 [ + - ]: 1966 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
1228 [ + - ]: 1966 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1229 [ + - ]: 1966 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1230 [ + - ]: 1966 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\" and \"bech32m\"."},
1231 [ + - + - : 4915 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1232 [ + - ]: 1966 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
1233 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1234 : : "e.g. with 'importdescriptors'."},
1235 : 1966 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
1236 : : {
1237 [ + - ]: 983 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
1238 [ + - ]: 983 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1239 [ + - ]: 983 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1240 [ + - ]: 1966 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1241 [ + - ]: 1966 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1242 : : "including the weight of the outpoint and sequence number. "
1243 : : "Note that signature sizes are not guaranteed to be consistent, "
1244 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1245 : : "Remember to convert serialized sizes to weight units when necessary."},
1246 : : }},
1247 : : },
1248 : : },
1249 [ + - ]: 1966 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1250 [ + - ]: 1966 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1251 [ + - ]: 1966 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1252 : 1966 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1253 : : "The fee will be equally deducted from the amount of each specified output.\n"
1254 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1255 : : "If no outputs are specified here, the sender pays the fee.",
1256 : : {
1257 [ + - ]: 983 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1258 : : },
1259 : : },
1260 [ + - ]: 1966 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1261 : : "Transaction building will fail if this can not be satisfied."},
1262 : : },
1263 [ + - ]: 1966 : FundTxDoc()),
1264 [ + - + - ]: 1966 : RPCArgOptions{.oneline_description="options"}},
1265 : : },
1266 : 0 : RPCResult{
1267 : : RPCResult::Type::OBJ, "", "",
1268 : : {
1269 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1270 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1271 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1272 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1273 : : }
1274 [ + - + - : 5898 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1275 : 983 : RPCExamples{""
1276 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1277 [ + - + - : 2949 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1278 [ + - ]: 1966 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1279 [ + - + - : 4915 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1280 [ + - ]: 1966 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1281 [ + - + - : 4915 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1282 [ + - ]: 1966 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1283 [ + - + - : 4915 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1284 : 983 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1285 [ + - + - : 4915 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1286 [ + - ]: 983 : },
1287 : 207 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1288 : : {
1289 : 207 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1290 [ - + ]: 207 : if (!pwallet) return UniValue::VNULL;
1291 : :
1292 [ + - + + : 207 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1293 [ + - + - : 207 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1294 [ + + ]: 203 : PreventOutdatedOptions(options);
1295 : :
1296 : :
1297 [ + - + + : 404 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1298 : 202 : UniValue outputs(UniValue::VOBJ);
1299 [ + - + - ]: 202 : outputs = NormalizeOutputs(request.params[0]);
1300 : 202 : std::vector<CRecipient> recipients = CreateRecipients(
1301 [ + + ]: 403 : ParseOutputs(outputs),
1302 [ + - + - : 405 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1303 [ + - ]: 201 : );
1304 [ + - + - : 402 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf);
+ - + - +
- + - ]
1305 [ + - ]: 201 : CCoinControl coin_control;
1306 : : // Automatically select coins, unless at least one is manually selected. Can
1307 : : // be overridden by options.add_inputs.
1308 [ + - ]: 201 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1309 [ + - - + ]: 402 : if (options.exists("max_tx_weight")) {
1310 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1311 : : }
1312 [ + - + - : 202 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1313 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1314 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1315 : 200 : rawTx.vout.clear();
1316 [ + + ]: 200 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1317 : :
1318 [ + - + - : 476 : return FinishTransaction(pwallet, options, CMutableTransaction(*txr.tx));
+ - ]
1319 : 692 : }
1320 [ + - + - : 26541 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ - - ]
1321 [ + - + - : 56031 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
1322 : :
1323 : 876 : RPCHelpMan sendall()
1324 : : {
1325 : 876 : return RPCHelpMan{"sendall",
1326 : : "EXPERIMENTAL warning: this call may be changed in future releases.\n"
1327 : : "\nSpend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1328 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1329 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1330 : : {
1331 [ + - ]: 876 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1332 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1333 : : {
1334 [ + - ]: 876 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1335 [ + - ]: 876 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1336 : : {
1337 [ + - ]: 1752 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1338 : : },
1339 : : },
1340 : : },
1341 : : },
1342 [ + - ]: 1752 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1343 [ + - ]: 1752 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1344 [ + - + - ]: 1752 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1345 [ + - ]: 2628 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1346 : : {
1347 [ + - ]: 876 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1348 [ + - + - : 54312 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1349 : : {
1350 [ + - ]: 1752 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
1351 [ + - + - : 4380 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1352 [ + - ]: 1752 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch-only.\n"
1353 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1354 : : "e.g. with 'importdescriptors'."},
1355 : 1752 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1356 : : {
1357 [ + - ]: 876 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1358 : : {
1359 [ + - ]: 876 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1360 [ + - ]: 876 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1361 [ + - ]: 1752 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1362 : : },
1363 : : },
1364 : : },
1365 : : },
1366 [ + - ]: 1752 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1367 [ + - ]: 1752 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1368 [ + - ]: 1752 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1369 [ + - ]: 1752 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
1370 [ + - ]: 1752 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
1371 [ + - ]: 876 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1372 : : },
1373 [ + - ]: 1752 : FundTxDoc()
1374 : : ),
1375 [ + - + - ]: 1752 : RPCArgOptions{.oneline_description="options"}
1376 : : },
1377 : : },
1378 : 0 : RPCResult{
1379 : : RPCResult::Type::OBJ, "", "",
1380 : : {
1381 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1382 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1383 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1384 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1385 : : }
1386 [ + - + - : 5256 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1387 : 876 : RPCExamples{""
1388 [ + - ]: 1752 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1389 [ + - + - : 4380 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1390 [ + - ]: 1752 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1391 [ + - + - : 4380 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1392 [ + - ]: 1752 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1393 [ + - + - : 5256 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1394 [ + - ]: 1752 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1395 [ + - + - : 4380 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1396 [ + - + - ]: 2628 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1397 [ + - + - : 5256 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1398 [ + - ]: 876 : },
1399 : 100 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1400 : : {
1401 : 100 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1402 [ - + ]: 100 : if (!pwallet) return UniValue::VNULL;
1403 : : // Make sure the results are valid at least up to the most recent block
1404 : : // the user could have gotten from another RPC command prior to now
1405 [ + - ]: 100 : pwallet->BlockUntilSyncedToCurrentChain();
1406 : :
1407 [ + - + + : 100 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1408 [ + - + - : 100 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1409 [ + - ]: 100 : PreventOutdatedOptions(options);
1410 : :
1411 : :
1412 : 100 : std::set<std::string> addresses_without_amount;
1413 : 100 : UniValue recipient_key_value_pairs(UniValue::VARR);
1414 [ + - ]: 100 : const UniValue& recipients{request.params[0]};
1415 [ + + ]: 213 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1416 [ + - ]: 113 : const UniValue& recipient{recipients[i]};
1417 [ + + ]: 113 : if (recipient.isStr()) {
1418 : 104 : UniValue rkvp(UniValue::VOBJ);
1419 [ + - + - : 208 : rkvp.pushKV(recipient.get_str(), 0);
+ - + - ]
1420 [ + - ]: 104 : recipient_key_value_pairs.push_back(std::move(rkvp));
1421 [ + - + - ]: 104 : addresses_without_amount.insert(recipient.get_str());
1422 : 104 : } else {
1423 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1424 : : }
1425 : : }
1426 : :
1427 [ + + ]: 100 : if (addresses_without_amount.size() == 0) {
1428 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1429 : : }
1430 : :
1431 [ + - ]: 98 : CCoinControl coin_control;
1432 : :
1433 [ + - + - : 196 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1434 : :
1435 [ + - + - : 98 : coin_control.fAllowWatchOnly = ParseIncludeWatchonly(options["include_watching"], *pwallet);
+ - ]
1436 : :
1437 [ + - + + ]: 196 : if (options.exists("minconf")) {
1438 [ + - + - : 5 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1439 : : {
1440 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1441 : : }
1442 : :
1443 [ + - + - : 4 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1444 : : }
1445 : :
1446 [ + - + + ]: 194 : if (options.exists("maxconf")) {
1447 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1448 : :
1449 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1450 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1451 : : }
1452 : : }
1453 : :
1454 [ + - - + : 194 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1455 : :
1456 : 97 : FeeCalculation fee_calc_out;
1457 [ + - ]: 97 : CFeeRate fee_rate{GetMinimumFeeRate(*pwallet, coin_control, &fee_calc_out)};
1458 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1459 : : // provided one
1460 [ + + + + ]: 97 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1461 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s)", coin_control.m_feerate->ToString(FeeEstimateMode::SAT_VB), fee_rate.ToString(FeeEstimateMode::SAT_VB)));
+ - + - ]
1462 : : }
1463 [ + + + - ]: 96 : if (fee_calc_out.reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1464 : : // eventually allow a fallback fee
1465 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1466 : : }
1467 : :
1468 [ + - + - : 193 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf)};
+ - + - +
+ ]
1469 [ + - ]: 95 : LOCK(pwallet->cs_wallet);
1470 : :
1471 : 95 : CAmount total_input_value(0);
1472 [ + - + + : 190 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1473 [ + - + - : 205 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1474 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1475 [ + - + - : 215 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1476 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1477 [ + - + + ]: 186 : } else if (options.exists("inputs")) {
1478 [ + + ]: 22 : for (const CTxIn& input : rawTx.vin) {
1479 [ + - + + ]: 13 : if (pwallet->IsSpent(input.prevout)) {
1480 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1481 : : }
1482 [ + - ]: 11 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1483 [ + + + + : 19 : if (!tx || input.prevout.n >= tx->tx->vout.size() || !(pwallet->IsMine(tx->tx->vout[input.prevout.n]) & (coin_control.fAllowWatchOnly ? ISMINE_ALL : ISMINE_SPENDABLE))) {
+ - + + +
- ]
1484 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1485 : : }
1486 : 9 : total_input_value += tx->tx->vout[input.prevout.n].nValue;
1487 : : }
1488 : : } else {
1489 : 80 : CoinFilterParams coins_params;
1490 : 80 : coins_params.min_amount = 0;
1491 [ + - + - : 2537 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1492 [ + - ]: 2457 : CHECK_NONFATAL(output.input_bytes > 0);
1493 [ + + + - : 2457 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1494 : 2 : continue;
1495 : : }
1496 [ + + + - ]: 2457 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::SEQUENCE_FINAL);
1497 [ + - ]: 2455 : rawTx.vin.push_back(input);
1498 : 2455 : total_input_value += output.txout.nValue;
1499 : 2535 : }
1500 : : }
1501 : :
1502 : 89 : std::vector<COutPoint> outpoints_spent;
1503 [ + - ]: 89 : outpoints_spent.reserve(rawTx.vin.size());
1504 : :
1505 [ + + ]: 2553 : for (const CTxIn& tx_in : rawTx.vin) {
1506 [ + - ]: 2464 : outpoints_spent.push_back(tx_in.prevout);
1507 : : }
1508 : :
1509 : : // estimate final size of tx
1510 [ + - + - ]: 89 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1511 [ + - ]: 89 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1512 [ + - ]: 89 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1513 [ + - ]: 89 : CAmount effective_value = total_input_value - fee_from_size - total_bump_fees.value_or(0);
1514 : :
1515 [ + + ]: 89 : if (fee_from_size > pwallet->m_default_max_tx_fee) {
1516 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1517 : : }
1518 : :
1519 [ + + ]: 88 : if (effective_value <= 0) {
1520 [ - + ]: 3 : if (send_max) {
1521 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1522 : : } else {
1523 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1524 : : }
1525 : : }
1526 : :
1527 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1528 [ + + ]: 85 : if (tx_size.weight > MAX_STANDARD_TX_WEIGHT) {
1529 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1530 : : }
1531 : :
1532 : 84 : CAmount output_amounts_claimed{0};
1533 [ + + ]: 181 : for (const CTxOut& out : rawTx.vout) {
1534 : 97 : output_amounts_claimed += out.nValue;
1535 : : }
1536 : :
1537 [ + + ]: 84 : if (output_amounts_claimed > total_input_value) {
1538 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1539 : : }
1540 : :
1541 : 83 : const CAmount remainder{effective_value - output_amounts_claimed};
1542 [ + + ]: 83 : if (remainder < 0) {
1543 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1544 : : }
1545 : :
1546 : 82 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1547 : :
1548 : 82 : bool gave_remaining_to_first{false};
1549 [ + + ]: 171 : for (CTxOut& out : rawTx.vout) {
1550 : 92 : CTxDestination dest;
1551 [ + - ]: 92 : ExtractDestination(out.scriptPubKey, dest);
1552 [ + - ]: 92 : std::string addr{EncodeDestination(dest)};
1553 [ + + ]: 92 : if (addresses_without_amount.count(addr) > 0) {
1554 : 86 : out.nValue = per_output_without_amount;
1555 [ + + ]: 86 : if (!gave_remaining_to_first) {
1556 : 81 : out.nValue += remainder % addresses_without_amount.size();
1557 : 81 : gave_remaining_to_first = true;
1558 : : }
1559 [ + - + - : 86 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1560 : : // Dynamically generated output amount is dust
1561 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1562 : : }
1563 : : } else {
1564 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1565 : : // Specified output amount is dust
1566 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", addr));
1567 : : }
1568 : : }
1569 : 95 : }
1570 : :
1571 [ + - + + : 158 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1572 [ + + ]: 79 : if (lock_unspents) {
1573 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1574 [ + - ]: 2 : pwallet->LockCoin(txin.prevout);
1575 : : }
1576 : : }
1577 : :
1578 [ + - + - ]: 237 : return FinishTransaction(pwallet, options, rawTx);
1579 [ + - ]: 403 : }
1580 [ + - + - : 31536 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ - - - -
- - ]
1581 [ + - + - : 42048 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - - -
- - ]
1582 : :
1583 : 1123 : RPCHelpMan walletprocesspsbt()
1584 : : {
1585 : 1123 : return RPCHelpMan{"walletprocesspsbt",
1586 : : "\nUpdate a PSBT with input information from our wallet and then sign inputs\n"
1587 : 1123 : "that we can sign for." +
1588 [ + - ]: 1123 : HELP_REQUIRING_PASSPHRASE,
1589 : : {
1590 [ + - ]: 1123 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1591 [ + - ]: 2246 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
1592 [ + - ]: 2246 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
1593 : : " \"DEFAULT\"\n"
1594 : : " \"ALL\"\n"
1595 : : " \"NONE\"\n"
1596 : : " \"SINGLE\"\n"
1597 : : " \"ALL|ANYONECANPAY\"\n"
1598 : : " \"NONE|ANYONECANPAY\"\n"
1599 : : " \"SINGLE|ANYONECANPAY\""},
1600 [ + - ]: 2246 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1601 [ + - ]: 2246 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
1602 : : },
1603 : 0 : RPCResult{
1604 : : RPCResult::Type::OBJ, "", "",
1605 : : {
1606 : : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1607 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1608 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1609 : : }
1610 [ + - + - : 5615 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1611 : 1123 : RPCExamples{
1612 [ + - + - : 2246 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1613 [ + - ]: 1123 : },
1614 : 347 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1615 : : {
1616 [ - + ]: 347 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1617 [ - + ]: 347 : if (!pwallet) return UniValue::VNULL;
1618 : :
1619 [ + - ]: 347 : const CWallet& wallet{*pwallet};
1620 : : // Make sure the results are valid at least up to the most recent block
1621 : : // the user could have gotten from another RPC command prior to now
1622 [ + - ]: 347 : wallet.BlockUntilSyncedToCurrentChain();
1623 : :
1624 : : // Unserialize the transaction
1625 : 347 : PartiallySignedTransaction psbtx;
1626 [ + - ]: 347 : std::string error;
1627 [ + - + - : 347 : if (!DecodeBase64PSBT(psbtx, request.params[0].get_str(), error)) {
+ - + + ]
1628 [ + - + - ]: 4 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", error));
1629 : : }
1630 : :
1631 : : // Get the sighash type
1632 [ + - + + ]: 345 : int nHashType = ParseSighashString(request.params[2]);
1633 : :
1634 : : // Fill transaction with our data and also sign
1635 [ + - + + : 344 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1636 [ + - + + : 344 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1637 [ + - + + : 344 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1638 : 344 : bool complete = true;
1639 : :
1640 [ + + + + ]: 344 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1641 : :
1642 [ + - ]: 343 : const auto err{wallet.FillPSBT(psbtx, complete, nHashType, sign, bip32derivs, nullptr, finalize)};
1643 [ - + ]: 343 : if (err) {
1644 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1645 : : }
1646 : :
1647 : 343 : UniValue result(UniValue::VOBJ);
1648 : 343 : DataStream ssTx{};
1649 [ + - ]: 343 : ssTx << psbtx;
1650 [ + - + - : 686 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1651 [ + - + - : 686 : result.pushKV("complete", complete);
+ - ]
1652 [ + + ]: 343 : if (complete) {
1653 [ + - ]: 37 : CMutableTransaction mtx;
1654 : : // Returns true if complete, which we already think it is.
1655 [ + - + - ]: 37 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1656 : 37 : DataStream ssTx_final;
1657 [ + - ]: 37 : ssTx_final << TX_WITH_WITNESS(mtx);
1658 [ + - + - : 74 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - ]
1659 : 74 : }
1660 : :
1661 : 343 : return result;
1662 : 690 : },
1663 [ + - + - : 34813 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1664 [ + - + - : 16845 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
1665 : :
1666 : 977 : RPCHelpMan walletcreatefundedpsbt()
1667 : : {
1668 : 977 : return RPCHelpMan{"walletcreatefundedpsbt",
1669 : : "\nCreates and funds a transaction in the Partially Signed Transaction format.\n"
1670 : : "Implements the Creator and Updater roles.\n"
1671 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1672 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1673 : : {
1674 [ + - ]: 977 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1675 : : {
1676 [ + - ]: 977 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1677 : : {
1678 [ + - ]: 977 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1679 [ + - ]: 977 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1680 [ + - ]: 1954 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
1681 [ + - ]: 1954 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1682 : : "including the weight of the outpoint and sequence number. "
1683 : : "Note that signature sizes are not guaranteed to be consistent, "
1684 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1685 : : "Remember to convert serialized sizes to weight units when necessary."},
1686 : : },
1687 : : },
1688 : : },
1689 : : },
1690 [ + - ]: 977 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1691 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1692 : : "At least one output of either type must be specified.\n"
1693 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1694 : : "accepted as second parameter.",
1695 [ + - ]: 1954 : OutputsDoc(),
1696 [ + - ]: 1954 : RPCArgOptions{.skip_type_check = true}},
1697 [ + - ]: 1954 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1698 [ + - ]: 977 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1699 [ + - + - : 63505 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1700 : : {
1701 [ + - ]: 1954 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
1702 [ + - ]: 1954 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1703 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1704 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1705 [ + - ]: 1954 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1706 [ + - ]: 977 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1707 [ + - ]: 1954 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1708 [ + - ]: 1954 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1709 [ + - ]: 1954 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
1710 [ + - ]: 1954 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only"},
1711 [ + - ]: 1954 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1712 [ + - + - ]: 3908 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1713 [ + - + - ]: 3908 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
1714 : 1954 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1715 : : "The fee will be equally deducted from the amount of each specified output.\n"
1716 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1717 : : "If no outputs are specified here, the sender pays the fee.",
1718 : : {
1719 [ + - ]: 977 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1720 : : },
1721 : : },
1722 [ + - ]: 1954 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1723 : : "Transaction building will fail if this can not be satisfied."},
1724 : : },
1725 [ + - ]: 1954 : FundTxDoc()),
1726 [ + - + - ]: 1954 : RPCArgOptions{.oneline_description="options"}},
1727 [ + - ]: 1954 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1728 : : },
1729 : 0 : RPCResult{
1730 : : RPCResult::Type::OBJ, "", "",
1731 : : {
1732 : : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1733 [ + - ]: 1954 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1734 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1735 : : }
1736 [ + - + - : 6839 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
1737 : 977 : RPCExamples{
1738 : : "\nCreate a PSBT with automatically picked inputs that sends 0.5 BTC to an address and has a fee rate of 2 sat/vB:\n"
1739 [ + - + - : 2931 : + HelpExampleCli("walletcreatefundedpsbt", "\"[]\" \"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" 0 \"{\\\"add_inputs\\\":true,\\\"fee_rate\\\":2}\"")
+ - + - ]
1740 : 977 : + "\nCreate the same PSBT as the above one instead using named arguments:\n"
1741 [ + - + - : 4885 : + HelpExampleCli("-named walletcreatefundedpsbt", "outputs=\"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" add_inputs=true fee_rate=2")
+ - + - ]
1742 [ + - ]: 977 : },
1743 : 201 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1744 : : {
1745 : 201 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1746 [ - + ]: 201 : if (!pwallet) return UniValue::VNULL;
1747 : :
1748 [ + - ]: 201 : CWallet& wallet{*pwallet};
1749 : : // Make sure the results are valid at least up to the most recent block
1750 : : // the user could have gotten from another RPC command prior to now
1751 [ + - ]: 201 : wallet.BlockUntilSyncedToCurrentChain();
1752 : :
1753 [ + - + + : 201 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1754 : :
1755 [ + - + - ]: 201 : const UniValue &replaceable_arg = options["replaceable"];
1756 [ + + + - ]: 201 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1757 [ + - + - : 201 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf);
+ - + - ]
1758 : 201 : UniValue outputs(UniValue::VOBJ);
1759 [ + - + - ]: 201 : outputs = NormalizeOutputs(request.params[1]);
1760 : 201 : std::vector<CRecipient> recipients = CreateRecipients(
1761 [ + - ]: 402 : ParseOutputs(outputs),
1762 [ + - + - : 402 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1763 [ + - ]: 201 : );
1764 [ + - ]: 201 : CCoinControl coin_control;
1765 : : // Automatically select coins, unless at least one is manually selected. Can
1766 : : // be overridden by options.add_inputs.
1767 [ + - ]: 201 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1768 [ + - + + ]: 201 : SetOptionsInputWeights(request.params[0], options);
1769 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1770 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1771 : 200 : rawTx.vout.clear();
1772 [ + + ]: 200 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1773 : :
1774 : : // Make a blank psbt
1775 [ + - + - ]: 132 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx));
1776 : :
1777 : : // Fill transaction with out data but don't sign
1778 [ + - + + : 132 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1779 : 132 : bool complete = true;
1780 [ + - ]: 132 : const auto err{wallet.FillPSBT(psbtx, complete, 1, /*sign=*/false, /*bip32derivs=*/bip32derivs)};
1781 [ - + ]: 132 : if (err) {
1782 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1783 : : }
1784 : :
1785 : : // Serialize the PSBT
1786 : 132 : DataStream ssTx{};
1787 [ + - ]: 132 : ssTx << psbtx;
1788 : :
1789 : 132 : UniValue result(UniValue::VOBJ);
1790 [ + - + - : 264 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1791 [ + - + - : 264 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1792 [ + + + - : 264 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1793 : 132 : return result;
1794 [ + - ]: 804 : },
1795 [ + - + - : 42988 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1796 [ + - + - : 49827 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1797 : : } // namespace wallet
|
