Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <rpc/rawtransaction_util.h>
12 : : #include <rpc/util.h>
13 : : #include <script/script.h>
14 : : #include <util/rbf.h>
15 : : #include <util/translation.h>
16 : : #include <util/vector.h>
17 : : #include <wallet/coincontrol.h>
18 : : #include <wallet/feebumper.h>
19 : : #include <wallet/fees.h>
20 : : #include <wallet/rpc/util.h>
21 : : #include <wallet/spend.h>
22 : : #include <wallet/wallet.h>
23 : :
24 : : #include <univalue.h>
25 : :
26 : : using common::FeeModeFromString;
27 : : using common::FeeModesDetail;
28 : : using common::InvalidEstimateModeErrorMessage;
29 : : using common::StringForFeeReason;
30 : : using common::TransactionErrorString;
31 : : using node::TransactionError;
32 : :
33 : : namespace wallet {
34 : 1801 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
35 : : {
36 : 1801 : std::vector<CRecipient> recipients;
37 [ + + ]: 23468 : for (size_t i = 0; i < outputs.size(); ++i) {
38 [ + - + - ]: 21667 : const auto& [destination, amount] = outputs.at(i);
39 [ + - ]: 43334 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
40 [ + - ]: 21667 : recipients.push_back(recipient);
41 : 21667 : }
42 : 1801 : return recipients;
43 : 0 : }
44 : :
45 : 305 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
46 : : {
47 [ + - + - : 892 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
48 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
49 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
50 : : }
51 : : } else {
52 [ + - + - ]: 562 : options.pushKV("conf_target", conf_target);
53 [ + - + - ]: 562 : options.pushKV("estimate_mode", estimate_mode);
54 : : }
55 [ + + ]: 604 : if (options.exists("fee_rate")) {
56 [ + + ]: 26 : if (!fee_rate.isNull()) {
57 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
58 : : }
59 : : } else {
60 [ + - + - ]: 552 : options.pushKV("fee_rate", fee_rate);
61 : : }
62 [ + - + - : 660 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
63 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
64 : : }
65 : 301 : }
66 : :
67 : 644 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
68 : : {
69 [ + + ]: 644 : std::set<int> sffo_set;
70 [ + + ]: 644 : if (sffo_instructions.isNull()) return sffo_set;
71 : :
72 [ + - + + ]: 194 : for (const auto& sffo : sffo_instructions.getValues()) {
73 : 102 : int pos{-1};
74 [ + + ]: 102 : if (sffo.isStr()) {
75 [ + - + + ]: 9 : auto it = find(destinations.begin(), destinations.end(), sffo.get_str());
76 [ + + + - : 10 : if (it == destinations.end()) throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', destination %s not found in tx outputs", sffo.get_str()));
+ - + - ]
77 : 8 : pos = it - destinations.begin();
78 [ + + ]: 93 : } else if (sffo.isNum()) {
79 [ + - ]: 92 : pos = sffo.getInt<int>();
80 : : } else {
81 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', invalid value type: %s", uvTypeName(sffo.type())));
+ - ]
82 : : }
83 : :
84 [ + + ]: 100 : if (sffo_set.contains(pos))
85 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', duplicated position: %d", pos));
86 [ + + ]: 98 : if (pos < 0)
87 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', negative position: %d", pos));
88 [ + + ]: 97 : if (pos >= int(destinations.size()))
89 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', position too large: %d", pos));
90 [ + - ]: 96 : sffo_set.insert(pos);
91 : : }
92 : : return sffo_set;
93 : 6 : }
94 : :
95 : 196 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, const CMutableTransaction& rawTx)
96 : : {
97 : : // Make a blank psbt
98 : 196 : PartiallySignedTransaction psbtx(rawTx);
99 : :
100 : : // First fill transaction with our data without signing,
101 : : // so external signers are not asked to sign more than once.
102 : 196 : bool complete;
103 [ + - ]: 196 : pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/false, /*bip32derivs=*/true);
104 [ + - ]: 196 : const auto err{pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/true, /*bip32derivs=*/false)};
105 [ - + ]: 196 : if (err) {
106 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
107 : : }
108 : :
109 [ + - ]: 196 : CMutableTransaction mtx;
110 [ + - ]: 196 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
111 : :
112 : 196 : UniValue result(UniValue::VOBJ);
113 : :
114 [ + - + - : 217 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
115 [ + - + + : 392 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
116 [ + + + + : 196 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
117 : : // Serialize the PSBT
118 : 52 : DataStream ssTx{};
119 [ + - ]: 52 : ssTx << psbtx;
120 [ + - + - : 104 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
121 : 52 : }
122 : :
123 [ + + ]: 196 : if (complete) {
124 [ + - + - ]: 170 : std::string hex{EncodeHexTx(CTransaction(mtx))};
125 [ + - ]: 170 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
126 [ + - + - : 340 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
127 [ + + ]: 170 : if (add_to_wallet && !psbt_opt_in) {
128 [ + - + - ]: 432 : pwallet->CommitTransaction(tx, {}, /*orderForm=*/{});
129 : : } else {
130 [ + - + - : 52 : result.pushKV("hex", hex);
+ - ]
131 : : }
132 : 170 : }
133 [ + - + - : 392 : result.pushKV("complete", complete);
+ - ]
134 : :
135 : 392 : return result;
136 : 196 : }
137 : :
138 : 301 : static void PreventOutdatedOptions(const UniValue& options)
139 : : {
140 [ + + ]: 602 : if (options.exists("feeRate")) {
141 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
142 : : }
143 [ - + ]: 600 : if (options.exists("changeAddress")) {
144 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
145 : : }
146 [ - + ]: 600 : if (options.exists("changePosition")) {
147 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
148 : : }
149 [ - + ]: 600 : if (options.exists("includeWatching")) {
150 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use include_watching instead of includeWatching");
151 : : }
152 [ - + ]: 600 : if (options.exists("lockUnspents")) {
153 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
154 : : }
155 [ - + ]: 600 : if (options.exists("subtractFeeFromOutputs")) {
156 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
157 : : }
158 : 300 : }
159 : :
160 : 1215 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, mapValue_t map_value, bool verbose)
161 : : {
162 : 1215 : EnsureWalletIsUnlocked(wallet);
163 : :
164 : : // This function is only used by sendtoaddress and sendmany.
165 : : // This should always try to sign, if we don't have private keys, don't try to do anything here.
166 [ - + ]: 1215 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
167 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
168 : : }
169 : :
170 : : // Shuffle recipient list
171 : 1215 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
172 : :
173 : : // Send
174 : 1215 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
175 [ + + ]: 1215 : if (!res) {
176 [ + - + - ]: 32 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
177 : : }
178 : 1199 : const CTransactionRef& tx = res->tx;
179 [ + - + - ]: 3597 : wallet.CommitTransaction(tx, std::move(map_value), /*orderForm=*/{});
180 [ + + ]: 1199 : if (verbose) {
181 : 2 : UniValue entry(UniValue::VOBJ);
182 [ + - + - : 4 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
183 [ + - + - : 4 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_calc.reason));
+ - + - ]
184 : 2 : return entry;
185 : 0 : }
186 [ + - + - ]: 1197 : return tx->GetHash().GetHex();
187 : 1199 : }
188 : :
189 : :
190 : : /**
191 : : * Update coin control with fee estimation based on the given parameters
192 : : *
193 : : * @param[in] wallet Wallet reference
194 : : * @param[in,out] cc Coin control to be updated
195 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
196 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
197 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
198 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
199 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
200 : : * verify only that fee_rate is greater than 0
201 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
202 : : */
203 : 1880 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
204 : : {
205 [ + + ]: 1880 : if (!fee_rate.isNull()) {
206 [ + + ]: 387 : if (!conf_target.isNull()) {
207 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
208 : : }
209 [ + + + + ]: 384 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
210 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
211 : : }
212 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
213 [ - + ]: 381 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
214 [ + + ]: 305 : if (override_min_fee) cc.fOverrideFeeRate = true;
215 : : // Default RBF to true for explicit fee_rate, if unset.
216 [ + + ]: 305 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
217 : 305 : return;
218 : : }
219 [ + + + + ]: 1493 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
220 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
221 : : }
222 [ + + ]: 1466 : if (!conf_target.isNull()) {
223 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().estimateMaxBlocks());
224 : : }
225 : : }
226 : :
227 : 1953 : RPCHelpMan sendtoaddress()
228 : : {
229 : 1953 : return RPCHelpMan{"sendtoaddress",
230 : 1953 : "\nSend an amount to a given address." +
231 [ + - ]: 1953 : HELP_REQUIRING_PASSPHRASE,
232 : : {
233 [ + - ]: 1953 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
234 [ + - ]: 3906 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
235 [ + - ]: 1953 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
236 : : "This is not part of the transaction, just kept in your wallet."},
237 [ + - ]: 1953 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
238 : : "to which you're sending the transaction. This is not part of the \n"
239 : : "transaction, just kept in your wallet."},
240 [ + - ]: 3906 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
241 : : "The recipient will receive less bitcoins than you enter in the amount field."},
242 [ + - ]: 3906 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
243 [ + - ]: 3906 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
244 [ + - ]: 3906 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
245 [ + - + - ]: 3906 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
246 [ + - ]: 3906 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
247 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
248 [ + - ]: 5859 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
249 [ + - ]: 3906 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
250 : : },
251 : : {
252 : : RPCResult{"if verbose is not set or set to false",
253 : : RPCResult::Type::STR_HEX, "txid", "The transaction id."
254 [ + - + - : 3906 : },
+ - + - ]
255 : : RPCResult{"if verbose is set to true",
256 : : RPCResult::Type::OBJ, "", "",
257 : : {
258 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
259 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
260 : : },
261 [ + - + - : 7812 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
262 : : },
263 : 1953 : RPCExamples{
264 : : "\nSend 0.1 BTC\n"
265 [ + - + - : 5859 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
266 : 1953 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
267 [ + - + - : 9765 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
268 [ + - ]: 3906 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
269 [ + - + - : 9765 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
270 : 1953 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
271 [ + - + - : 9765 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
272 [ + - ]: 3906 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
273 [ + - + - : 9765 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
274 [ + - + - : 7812 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
275 [ + - ]: 1953 : },
276 : 1167 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
277 : : {
278 : 1167 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
279 [ - + ]: 1167 : if (!pwallet) return UniValue::VNULL;
280 : :
281 : : // Make sure the results are valid at least up to the most recent block
282 : : // the user could have gotten from another RPC command prior to now
283 [ + - ]: 1167 : pwallet->BlockUntilSyncedToCurrentChain();
284 : :
285 [ + - ]: 1167 : LOCK(pwallet->cs_wallet);
286 : :
287 : : // Wallet comments
288 [ + - ]: 1167 : mapValue_t mapValue;
289 [ + - + + : 1167 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
290 [ + - + - : 2 : mapValue["comment"] = request.params[2].get_str();
+ - + - +
- ]
291 [ + - + + : 1167 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
292 [ + - + - : 2 : mapValue["to"] = request.params[3].get_str();
+ - + - +
- ]
293 : :
294 [ + - ]: 1167 : CCoinControl coin_control;
295 [ + - + + ]: 1167 : if (!request.params[5].isNull()) {
296 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
297 : : }
298 : :
299 [ + - + - ]: 1167 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
300 : : // We also enable partial spend avoidance if reuse avoidance is set.
301 : 1167 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
302 : :
303 [ + - + - : 1167 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
304 : :
305 [ + + ]: 1167 : EnsureWalletIsUnlocked(*pwallet);
306 : :
307 : 1166 : UniValue address_amounts(UniValue::VOBJ);
308 [ + - + - : 1166 : const std::string address = request.params[0].get_str();
+ - ]
309 [ + - + - : 2332 : address_amounts.pushKV(address, request.params[1]);
+ - + - ]
310 : :
311 [ + - ]: 1166 : std::set<int> sffo_set;
312 [ + - + + : 1166 : if (!request.params[4].isNull() && request.params[4].get_bool()) {
+ - + - +
+ ]
313 [ + - ]: 216 : sffo_set.insert(0);
314 : : }
315 : :
316 [ + + + - ]: 1166 : std::vector<CRecipient> recipients{CreateRecipients(ParseOutputs(address_amounts), sffo_set)};
317 [ + - + + : 1164 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
318 : :
319 [ + - + + ]: 1168 : return SendMoney(*pwallet, coin_control, recipients, mapValue, verbose);
320 [ + - ]: 3517 : },
321 [ + - + - : 113274 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
322 [ + - + - : 54684 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- ]
323 : :
324 : 866 : RPCHelpMan sendmany()
325 : : {
326 : 866 : return RPCHelpMan{"sendmany",
327 : 866 : "Send multiple times. Amounts are double-precision floating point numbers." +
328 [ + - ]: 866 : HELP_REQUIRING_PASSPHRASE,
329 : : {
330 [ + - ]: 1732 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
331 [ + - + - ]: 1732 : RPCArgOptions{
332 : : .oneline_description = "\"\"",
333 : : }},
334 [ + - ]: 866 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
335 : : {
336 [ + - ]: 1732 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
337 : : },
338 : : },
339 [ + - ]: 866 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value"},
340 [ + - ]: 866 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
341 [ + - ]: 866 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
342 : : "The fee will be equally deducted from the amount of each selected address.\n"
343 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
344 : : "If no addresses are specified here, the sender pays the fee.",
345 : : {
346 [ + - ]: 866 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
347 : : },
348 : : },
349 [ + - ]: 1732 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
350 [ + - ]: 1732 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
351 [ + - ]: 1732 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
352 [ + - + - ]: 1732 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
353 [ + - ]: 2598 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
354 [ + - ]: 1732 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
355 : : },
356 : : {
357 : : RPCResult{"if verbose is not set or set to false",
358 : : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
359 : : "the number of addresses."
360 [ + - + - : 1732 : },
+ - + - ]
361 : : RPCResult{"if verbose is set to true",
362 : : RPCResult::Type::OBJ, "", "",
363 : : {
364 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
365 : : "the number of addresses."},
366 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
367 : : },
368 [ + - + - : 3464 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
369 : : },
370 : 866 : RPCExamples{
371 : : "\nSend two amounts to two different addresses:\n"
372 [ + - + - : 3464 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
373 : 866 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
374 [ + - + - : 5196 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
375 : 866 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
376 [ + - + - : 6928 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
377 : 866 : "\nAs a JSON-RPC call\n"
378 [ + - + - : 4330 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
379 [ + - ]: 866 : },
380 : 80 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
381 : : {
382 : 80 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
383 [ - + ]: 80 : if (!pwallet) return UniValue::VNULL;
384 : :
385 : : // Make sure the results are valid at least up to the most recent block
386 : : // the user could have gotten from another RPC command prior to now
387 [ + - ]: 80 : pwallet->BlockUntilSyncedToCurrentChain();
388 : :
389 [ + - ]: 80 : LOCK(pwallet->cs_wallet);
390 : :
391 [ + - + + : 80 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
392 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
393 : : }
394 [ + - + - : 80 : UniValue sendTo = request.params[1].get_obj();
+ - ]
395 : :
396 [ + - ]: 80 : mapValue_t mapValue;
397 [ + - + + : 80 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
398 [ # # # # : 0 : mapValue["comment"] = request.params[3].get_str();
# # # # #
# ]
399 : :
400 [ + - ]: 80 : CCoinControl coin_control;
401 [ + - - + ]: 80 : if (!request.params[5].isNull()) {
402 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
403 : : }
404 : :
405 [ + - + - : 80 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
406 : :
407 : 57 : std::vector<CRecipient> recipients = CreateRecipients(
408 [ + - ]: 102 : ParseOutputs(sendTo),
409 [ + - + - : 57 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ + ]
410 [ + - ]: 51 : );
411 [ + - + + : 51 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
412 : :
413 [ + + ]: 63 : return SendMoney(*pwallet, coin_control, recipients, std::move(mapValue), verbose);
414 [ + - ]: 252 : },
415 [ + - + - : 51094 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
416 [ + - + - : 25114 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
417 : :
418 : 804 : RPCHelpMan settxfee()
419 : : {
420 : 804 : return RPCHelpMan{"settxfee",
421 [ + - ]: 1608 : "\nSet the transaction fee rate in " + CURRENCY_UNIT + "/kvB for this wallet. Overrides the global -paytxfee command line parameter.\n"
422 : 804 : "Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.\n",
423 : : {
424 [ + - ]: 1608 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The transaction fee rate in " + CURRENCY_UNIT + "/kvB"},
425 : : },
426 : 0 : RPCResult{
427 : : RPCResult::Type::BOOL, "", "Returns true if successful"
428 [ + - + - : 1608 : },
+ - ]
429 : 804 : RPCExamples{
430 [ + - + - : 1608 : HelpExampleCli("settxfee", "0.00001")
+ - ]
431 [ + - + - : 3216 : + HelpExampleRpc("settxfee", "0.00001")
+ - + - ]
432 [ + - ]: 804 : },
433 : 18 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
434 : : {
435 : 18 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
436 [ - + ]: 18 : if (!pwallet) return UniValue::VNULL;
437 : :
438 [ + - ]: 18 : LOCK(pwallet->cs_wallet);
439 : :
440 [ + - + - ]: 18 : CAmount nAmount = AmountFromValue(request.params[0]);
441 [ + - ]: 18 : CFeeRate tx_fee_rate(nAmount, 1000);
442 [ + - ]: 18 : CFeeRate max_tx_fee_rate(pwallet->m_default_max_tx_fee, 1000);
443 [ + + ]: 18 : if (tx_fee_rate == CFeeRate(0)) {
444 : : // automatic selection
445 [ + - + + ]: 16 : } else if (tx_fee_rate < pwallet->chain().relayMinFee()) {
446 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than min relay tx fee (%s)", pwallet->chain().relayMinFee().ToString()));
+ - + - ]
447 [ + + ]: 15 : } else if (tx_fee_rate < pwallet->m_min_fee) {
448 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than wallet min fee (%s)", pwallet->m_min_fee.ToString()));
+ - ]
449 [ + + ]: 14 : } else if (tx_fee_rate > max_tx_fee_rate) {
450 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be more than wallet max tx fee (%s)", max_tx_fee_rate.ToString()));
+ - ]
451 : : }
452 : :
453 [ + - ]: 15 : pwallet->m_pay_tx_fee = tx_fee_rate;
454 [ + - ]: 15 : return true;
455 : 33 : },
456 [ + - + - : 8844 : };
+ - + - +
- + + -
- ]
457 [ + - + - ]: 2412 : }
458 : :
459 : :
460 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
461 : 3836 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
462 : : {
463 : 3836 : std::vector<RPCArg> args = {
464 [ + - + - ]: 15344 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
465 [ + - ]: 7672 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
466 [ + - + - : 7672 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - ]
467 : : {
468 [ + - ]: 7672 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
469 : : "Allows this transaction to be replaced by a transaction with higher fees"
470 : : },
471 [ + - + - : 61376 : };
+ - + - +
- + - + -
+ + - - ]
472 [ + - ]: 3836 : if (solving_data) {
473 [ + - + - : 103572 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + + +
+ + - - -
- - - -
- ]
474 : : "Used for fee estimation during coin selection.",
475 : : {
476 : : {
477 : 7672 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
478 : : {
479 [ + - ]: 3836 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
480 : : }
481 : : },
482 : : {
483 : 7672 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
484 : : {
485 [ + - ]: 3836 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
486 : : }
487 : : },
488 : : {
489 : 7672 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
490 : : {
491 [ + - ]: 3836 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
492 : : }
493 : : },
494 : : }
495 : : });
496 : : }
497 : 3836 : return args;
498 [ + - + - : 72884 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - ]
499 : :
500 : 584 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
501 : : {
502 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
503 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
504 : 584 : CHECK_NONFATAL(tx.vout.empty());
505 : : // Make sure the results are valid at least up to the most recent block
506 : : // the user could have gotten from another RPC command prior to now
507 : 584 : wallet.BlockUntilSyncedToCurrentChain();
508 : :
509 : 584 : std::optional<unsigned int> change_position;
510 : 584 : bool lockUnspents = false;
511 [ + + ]: 584 : if (!options.isNull()) {
512 [ + + ]: 526 : if (options.type() == UniValue::VBOOL) {
513 : : // backward compatibility bool only fallback
514 : 1 : coinControl.fAllowWatchOnly = options.get_bool();
515 : : }
516 : : else {
517 [ + + + + : 15248 : RPCTypeCheckObj(options,
+ + ]
518 : : {
519 [ + - ]: 525 : {"add_inputs", UniValueType(UniValue::VBOOL)},
520 [ + - ]: 525 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
521 [ + - ]: 525 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
522 [ + - ]: 525 : {"changeAddress", UniValueType(UniValue::VSTR)},
523 [ + - ]: 525 : {"change_address", UniValueType(UniValue::VSTR)},
524 [ + - ]: 525 : {"changePosition", UniValueType(UniValue::VNUM)},
525 [ + - ]: 525 : {"change_position", UniValueType(UniValue::VNUM)},
526 [ + - ]: 525 : {"change_type", UniValueType(UniValue::VSTR)},
527 [ + - ]: 525 : {"includeWatching", UniValueType(UniValue::VBOOL)},
528 [ + - ]: 525 : {"include_watching", UniValueType(UniValue::VBOOL)},
529 [ + - ]: 525 : {"inputs", UniValueType(UniValue::VARR)},
530 [ + - ]: 525 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
531 [ + - ]: 525 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
532 [ + - ]: 525 : {"locktime", UniValueType(UniValue::VNUM)},
533 [ + - ]: 525 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
534 [ + - ]: 525 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
535 [ + - ]: 525 : {"psbt", UniValueType(UniValue::VBOOL)},
536 [ + - ]: 525 : {"solving_data", UniValueType(UniValue::VOBJ)},
537 [ + - ]: 525 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
538 [ + - ]: 525 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
539 [ + - ]: 525 : {"replaceable", UniValueType(UniValue::VBOOL)},
540 [ + - ]: 525 : {"conf_target", UniValueType(UniValue::VNUM)},
541 [ + - ]: 525 : {"estimate_mode", UniValueType(UniValue::VSTR)},
542 [ + - ]: 525 : {"minconf", UniValueType(UniValue::VNUM)},
543 [ + - ]: 525 : {"maxconf", UniValueType(UniValue::VNUM)},
544 [ + - ]: 525 : {"input_weights", UniValueType(UniValue::VARR)},
545 [ + - ]: 525 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
546 : : },
547 : : true, true);
548 : :
549 [ + + ]: 1004 : if (options.exists("add_inputs")) {
550 [ + - + - ]: 171 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
551 : : }
552 : :
553 [ + - + - : 1497 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
554 [ + + + - : 39 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - + -
+ + + + -
- - - ]
555 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
556 : :
557 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
558 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
559 : : }
560 : :
561 [ + - ]: 22 : coinControl.destChange = dest;
562 : 15 : }
563 : :
564 [ + - + - : 1496 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
565 [ + + + - : 111 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
566 [ + - + + ]: 37 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
567 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
568 : : }
569 : 36 : change_position = (unsigned int)pos;
570 : : }
571 : :
572 [ + + ]: 998 : if (options.exists("change_type")) {
573 [ + - + - : 227 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
574 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
575 : : }
576 [ + - + + : 150 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
+ - + + ]
577 [ - + ]: 146 : coinControl.m_change_type.emplace(parsed.value());
578 : : } else {
579 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
580 : : }
581 : : }
582 : :
583 [ + + + - : 1488 : const UniValue include_watching_option = options.exists("include_watching") ? options["include_watching"] : options["includeWatching"];
+ - + - +
- + - + +
+ + - - -
- ]
584 [ + - ]: 496 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(include_watching_option, wallet);
585 : :
586 [ + - + - : 1485 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
587 [ + - + + : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + -
+ + + + -
- - - ]
588 : : }
589 : :
590 [ + - + + ]: 992 : if (options.exists("include_unsafe")) {
591 [ + - + - : 5 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
+ - ]
592 : : }
593 : :
594 [ + - + + ]: 992 : if (options.exists("feeRate")) {
595 [ + - + + ]: 116 : if (options.exists("fee_rate")) {
596 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
597 : : }
598 [ + - + + ]: 112 : if (options.exists("conf_target")) {
599 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
600 : : }
601 [ + - + + ]: 108 : if (options.exists("estimate_mode")) {
602 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
603 : : }
604 [ + - + - : 104 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
+ + - + ]
605 : 36 : coinControl.fOverrideFeeRate = true;
606 : : }
607 : :
608 [ + - + + ]: 948 : if (options.exists("replaceable")) {
609 [ + - + - : 7 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
610 : : }
611 : :
612 [ + - + + ]: 948 : if (options.exists("minconf")) {
613 [ + - + - : 8 : coinControl.m_min_depth = options["minconf"].getInt<int>();
+ - ]
614 : :
615 [ + + ]: 8 : if (coinControl.m_min_depth < 0) {
616 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
617 : : }
618 : : }
619 : :
620 [ + - + + ]: 946 : if (options.exists("maxconf")) {
621 [ + - + - : 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
622 : :
623 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
624 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
625 : : }
626 : : }
627 [ + - + - : 1140 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + - +
+ ]
628 : 496 : }
629 : : } else {
630 : : // if options is null and not a bool
631 : 58 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(NullUniValue, wallet);
632 : : }
633 : :
634 [ + + ]: 870 : if (options.exists("solving_data")) {
635 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
636 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
637 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
638 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
639 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
640 : : // Add witness script for pubkeys
641 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
642 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
643 : 3 : }
644 : : }
645 : :
646 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
647 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
648 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
649 [ + - + + ]: 6 : if (!IsHex(script_str)) {
650 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
651 : : }
652 [ + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
653 : 5 : const CScript script(script_data.begin(), script_data.end());
654 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
655 : 5 : }
656 : : }
657 : :
658 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
659 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
660 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
661 : 8 : FlatSigningProvider desc_out;
662 [ + - ]: 8 : std::string error;
663 : 8 : std::vector<CScript> scripts_temp;
664 [ + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
665 [ + + ]: 8 : if (descs.empty()) {
666 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
667 : : }
668 [ + + ]: 14 : for (auto& desc : descs) {
669 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
670 : : }
671 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
672 : 10 : }
673 : : }
674 : 14 : }
675 : :
676 [ + + ]: 862 : if (options.exists("input_weights")) {
677 [ + - + - : 2594 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
678 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
679 : :
680 : 2491 : const UniValue& vout_v = input.find_value("vout");
681 [ + + ]: 2491 : if (!vout_v.isNum()) {
682 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
683 : : }
684 : 2490 : int vout = vout_v.getInt<int>();
685 [ + + ]: 2490 : if (vout < 0) {
686 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
687 : : }
688 : :
689 : 2489 : const UniValue& weight_v = input.find_value("weight");
690 [ + + ]: 2489 : if (!weight_v.isNum()) {
691 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
692 : : }
693 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
694 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
695 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
696 [ + + ]: 2488 : if (weight < min_input_weight) {
697 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
698 : : }
699 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
700 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
701 : : }
702 : :
703 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
704 : : }
705 : : }
706 : :
707 [ + + ]: 850 : if (options.exists("max_tx_weight")) {
708 [ + - + - ]: 8 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
709 : : }
710 : :
711 [ - + ]: 425 : if (recipients.empty())
712 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
713 : :
714 [ + - ]: 425 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
715 [ + + ]: 425 : if (!txr) {
716 [ + - + - ]: 138 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
717 : : }
718 : 356 : return *txr;
719 [ + - + - : 904 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
720 : :
721 : 400 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
722 : : {
723 [ + + ]: 800 : if (options.exists("input_weights")) {
724 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
725 : : }
726 [ + + ]: 398 : if (inputs.size() == 0) {
727 : : return;
728 : : }
729 : 139 : UniValue weights(UniValue::VARR);
730 [ + - + + ]: 2892 : for (const UniValue& input : inputs.getValues()) {
731 [ + - + + ]: 5506 : if (input.exists("weight")) {
732 [ + - + - ]: 6 : weights.push_back(input);
733 : : }
734 : : }
735 [ + - + - ]: 278 : options.pushKV("input_weights", std::move(weights));
736 : 139 : }
737 : :
738 : 972 : RPCHelpMan fundrawtransaction()
739 : : {
740 : 972 : return RPCHelpMan{"fundrawtransaction",
741 : : "\nIf the transaction has no inputs, they will be automatically selected to meet its out value.\n"
742 : : "It will add at most one change output to the outputs.\n"
743 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
744 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
745 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
746 : : "or signrawtransactionwithwallet for that.\n"
747 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
748 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
749 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
750 : : "in the wallet using importaddress or addmultisigaddress (to calculate fees).\n"
751 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
752 : : "Only pay-to-pubkey, multisig, and P2SH versions thereof are currently supported for watch-only\n",
753 : : {
754 [ + - ]: 972 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
755 [ + - ]: 972 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "For backward compatibility: passing in a true instead of an object will result in {\"includeWatching\":true}",
756 [ + - + - : 77760 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
757 : : {
758 [ + - ]: 1944 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
759 [ + - ]: 1944 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
760 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
761 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
762 [ + - ]: 1944 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
763 [ + - ]: 972 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
764 [ + - ]: 1944 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
765 [ + - ]: 1944 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
766 [ + - ]: 1944 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
767 [ + - ]: 1944 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
768 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
769 : : "e.g. with 'importpubkey' or 'importmulti' with the 'pubkeys' or 'desc' field."},
770 [ + - ]: 1944 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
771 [ + - + - ]: 3888 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
772 [ + - + - ]: 3888 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
773 : 1944 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
774 : : "The fee will be equally deducted from the amount of each specified output.\n"
775 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
776 : : "If no outputs are specified here, the sender pays the fee.",
777 : : {
778 [ + - ]: 972 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
779 : : },
780 : : },
781 [ + - ]: 972 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
782 : : {
783 [ + - ]: 972 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
784 : : {
785 [ + - ]: 972 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
786 [ + - ]: 972 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
787 [ + - ]: 972 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
788 : : "including the weight of the outpoint and sequence number. "
789 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
790 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
791 : : "Remember to convert serialized sizes to weight units when necessary."},
792 : : },
793 : : },
794 : : },
795 : : },
796 [ + - ]: 1944 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
797 : : "Transaction building will fail if this can not be satisfied."},
798 : : },
799 [ + - ]: 1944 : FundTxDoc()),
800 [ + - + - ]: 1944 : RPCArgOptions{
801 : : .skip_type_check = true,
802 : : .oneline_description = "options",
803 : : }},
804 [ + - ]: 1944 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
805 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
806 : : "If true, only witness deserialization will be tried.\n"
807 : : "If false, only non-witness deserialization will be tried.\n"
808 : : "This boolean should reflect whether the transaction has inputs\n"
809 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
810 : : },
811 : : },
812 : 0 : RPCResult{
813 : : RPCResult::Type::OBJ, "", "",
814 : : {
815 : : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
816 [ + - ]: 1944 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
817 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
818 : : }
819 [ + - + - : 6804 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
820 : 972 : RPCExamples{
821 : : "\nCreate a transaction with no inputs\n"
822 [ + - + - : 1944 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
823 : 972 : "\nAdd sufficient unsigned inputs to meet the output value\n"
824 [ + - + - : 3888 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
825 : 972 : "\nSign the transaction\n"
826 [ + - + - : 3888 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
827 : 972 : "\nSend the transaction\n"
828 [ + - + - : 3888 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
829 [ + - ]: 972 : },
830 : 186 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
831 : : {
832 : 186 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
833 [ - + ]: 186 : if (!pwallet) return UniValue::VNULL;
834 : :
835 : : // parse hex string from parameter
836 [ + - ]: 186 : CMutableTransaction tx;
837 [ + - - + : 186 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
838 [ + - - + : 186 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
839 [ + - + - : 186 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
840 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
841 : : }
842 [ + - + - ]: 186 : UniValue options = request.params[1];
843 : 186 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
844 [ + + ]: 11986 : for (const auto& tx_out : tx.vout) {
845 : 11800 : CTxDestination dest;
846 [ + - ]: 11800 : ExtractDestination(tx_out.scriptPubKey, dest);
847 [ + - ]: 11800 : destinations.emplace_back(dest, tx_out.nValue);
848 : 11800 : }
849 [ + - + - ]: 186 : std::vector<std::string> dummy(destinations.size(), "dummy");
850 [ + - ]: 186 : std::vector<CRecipient> recipients = CreateRecipients(
851 : : destinations,
852 [ + - + - : 372 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
853 [ + - ]: 186 : );
854 [ + - ]: 186 : CCoinControl coin_control;
855 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
856 : 186 : coin_control.m_allow_other_inputs = true;
857 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
858 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
859 : 186 : tx.vout.clear();
860 [ + + ]: 186 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
861 : :
862 : 107 : UniValue result(UniValue::VOBJ);
863 [ + - + - : 214 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
864 [ + - + - : 214 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
865 [ + + + - : 214 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
866 : :
867 : 107 : return result;
868 [ + - ]: 902 : },
869 [ + - + - : 16524 : };
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
870 [ + - + - : 46656 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
871 : :
872 : 1080 : RPCHelpMan signrawtransactionwithwallet()
873 : : {
874 : 1080 : return RPCHelpMan{"signrawtransactionwithwallet",
875 : : "\nSign inputs for raw transaction (serialized, hex-encoded).\n"
876 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
877 : 1080 : "this transaction depends on but may not yet be in the block chain." +
878 [ + - ]: 1080 : HELP_REQUIRING_PASSPHRASE,
879 : : {
880 [ + - ]: 1080 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
881 [ + - ]: 1080 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
882 : : {
883 [ + - ]: 1080 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
884 : : {
885 [ + - ]: 1080 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
886 [ + - ]: 1080 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
887 [ + - ]: 1080 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
888 [ + - ]: 1080 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
889 [ + - ]: 1080 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
890 [ + - ]: 1080 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
891 : : },
892 : : },
893 : : },
894 : : },
895 [ + - ]: 2160 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
896 : : " \"DEFAULT\"\n"
897 : : " \"ALL\"\n"
898 : : " \"NONE\"\n"
899 : : " \"SINGLE\"\n"
900 : : " \"ALL|ANYONECANPAY\"\n"
901 : : " \"NONE|ANYONECANPAY\"\n"
902 : : " \"SINGLE|ANYONECANPAY\""},
903 : : },
904 : 0 : RPCResult{
905 : : RPCResult::Type::OBJ, "", "",
906 : : {
907 : : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
908 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
909 : : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
910 : : {
911 : : {RPCResult::Type::OBJ, "", "",
912 : : {
913 : : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
914 : : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
915 : : {RPCResult::Type::ARR, "witness", "",
916 : : {
917 : : {RPCResult::Type::STR_HEX, "witness", ""},
918 : : }},
919 : : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
920 : : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
921 : : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
922 : : }},
923 : : }},
924 : : }
925 [ + - + - : 17280 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
926 : 1080 : RPCExamples{
927 [ + - + - : 2160 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
928 [ + - + - : 4320 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
929 [ + - ]: 1080 : },
930 : 294 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
931 : : {
932 [ - + ]: 294 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
933 [ - + ]: 294 : if (!pwallet) return UniValue::VNULL;
934 : :
935 [ + - ]: 294 : CMutableTransaction mtx;
936 [ + - + - : 294 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
937 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
938 : : }
939 : :
940 : : // Sign the transaction
941 [ + - ]: 294 : LOCK(pwallet->cs_wallet);
942 [ + + ]: 294 : EnsureWalletIsUnlocked(*pwallet);
943 : :
944 : : // Fetch previous transactions (inputs):
945 : 293 : std::map<COutPoint, Coin> coins;
946 [ + + ]: 1043 : for (const CTxIn& txin : mtx.vin) {
947 [ + - ]: 750 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
948 : : }
949 [ + - ]: 293 : pwallet->chain().findCoins(coins);
950 : :
951 : : // Parse the prevtxs array
952 [ + - + + ]: 293 : ParsePrevouts(request.params[1], nullptr, coins);
953 : :
954 [ + - + + ]: 284 : int nHashType = ParseSighashString(request.params[2]);
955 : :
956 : : // Script verification errors
957 [ + - ]: 283 : std::map<int, bilingual_str> input_errors;
958 : :
959 [ + - ]: 283 : bool complete = pwallet->SignTransaction(mtx, coins, nHashType, input_errors);
960 : 283 : UniValue result(UniValue::VOBJ);
961 [ + + ]: 283 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
962 : 281 : return result;
963 [ + - ]: 1166 : },
964 [ + - + - : 43200 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - ]
965 [ + - + - : 35640 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
966 : :
967 : : // Definition of allowed formats of specifying transaction outputs in
968 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
969 : 3709 : static std::vector<RPCArg> OutputsDoc()
970 : : {
971 : 3709 : return
972 : : {
973 [ + - ]: 3709 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
974 : : {
975 [ + - ]: 3709 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
976 : 3709 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
977 : : },
978 : : },
979 [ + - ]: 3709 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
980 : : {
981 [ + - ]: 3709 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data"},
982 : : },
983 : : },
984 [ + - + - : 51926 : };
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
985 [ + - + - : 33381 : }
+ - + - +
- - - ]
986 : :
987 : 1731 : static RPCHelpMan bumpfee_helper(std::string method_name)
988 : : {
989 : 1731 : const bool want_psbt = method_name == "psbtbumpfee";
990 : 1731 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeEstimateMode::SAT_VB)};
991 : :
992 : 1731 : return RPCHelpMan{method_name,
993 : : "\nBumps the fee of an opt-in-RBF transaction T, replacing it with a new transaction B.\n"
994 [ + + + - : 4400 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
+ - ]
995 : : "An opt-in RBF transaction with the given txid must be in the wallet.\n"
996 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
997 : : "It may add a new change output if one does not already exist.\n"
998 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
999 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
1000 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
1001 : : "The user can specify a confirmation target for estimatesmartfee.\n"
1002 [ + - ]: 3462 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
1003 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
1004 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
1005 [ + - + - ]: 5193 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
1006 : : {
1007 [ + - ]: 1731 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
1008 [ + - ]: 1731 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1009 : : {
1010 [ + - ]: 3462 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
1011 [ + - ]: 3462 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
1012 : 1731 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
1013 [ + - ]: 3462 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
1014 [ + - + - ]: 5193 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
1015 [ + - ]: 3462 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true}, "Whether the new transaction should still be\n"
1016 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
1017 : : "be left unchanged from the original. If false, any input sequence numbers in the\n"
1018 : : "original transaction that were less than 0xfffffffe will be increased to 0xfffffffe\n"
1019 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
1020 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
1021 : : "are replaceable).\n"},
1022 [ + - ]: 3462 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1023 [ + - + - ]: 3462 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1024 : 3462 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1025 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1026 : : "At least one output of either type must be specified.\n"
1027 : : "Cannot be provided if 'original_change_index' is specified.",
1028 [ + - ]: 3462 : OutputsDoc(),
1029 [ + - ]: 3462 : RPCArgOptions{.skip_type_check = true}},
1030 [ + - ]: 3462 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
1031 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1032 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1033 : : "original change output. The change output’s amount can increase if bumping the transaction "
1034 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1035 : : },
1036 [ + - + - ]: 1731 : RPCArgOptions{.oneline_description="options"}},
1037 : : },
1038 : 0 : RPCResult{
1039 [ + - + - : 15579 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1040 [ + + + - : 8655 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1041 [ + - + - : 4903 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ - + + +
+ + + - -
- - - - ]
1042 [ + - + - : 5483 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ - + + +
+ + + - -
- - - - ]
1043 : : {
1044 : : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1045 : : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1046 : : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1047 : : {
1048 : : {RPCResult::Type::STR, "", ""},
1049 : : }},
1050 : : })
1051 [ + - + - : 5193 : },
+ - ]
1052 : 1731 : RPCExamples{
1053 [ + + + - : 4400 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1054 [ + - + - : 5193 : HelpExampleCli(method_name, "<txid>")
+ - ]
1055 : 1731 : },
1056 [ + - ]: 1731 : [want_psbt](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1057 : : {
1058 : 159 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1059 [ - + ]: 159 : if (!pwallet) return UniValue::VNULL;
1060 : :
1061 [ + - + + : 159 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1062 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1063 : : }
1064 : :
1065 [ + - + - ]: 158 : uint256 hash(ParseHashV(request.params[0], "txid"));
1066 : :
1067 [ + - ]: 158 : CCoinControl coin_control;
1068 [ + - ]: 158 : coin_control.fAllowWatchOnly = pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS);
1069 : : // optional parameters
1070 [ + - ]: 158 : coin_control.m_signal_bip125_rbf = true;
1071 : 158 : std::vector<CTxOut> outputs;
1072 : :
1073 : 158 : std::optional<uint32_t> original_change_index;
1074 : :
1075 [ + - + + ]: 158 : if (!request.params[1].isNull()) {
1076 [ + - + - ]: 67 : UniValue options = request.params[1];
1077 [ + + + + : 607 : RPCTypeCheckObj(options,
+ + ]
1078 : : {
1079 [ + - ]: 67 : {"confTarget", UniValueType(UniValue::VNUM)},
1080 [ + - ]: 67 : {"conf_target", UniValueType(UniValue::VNUM)},
1081 [ + - ]: 67 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1082 [ + - ]: 67 : {"replaceable", UniValueType(UniValue::VBOOL)},
1083 [ + - ]: 67 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1084 [ + - ]: 67 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1085 [ + - ]: 67 : {"original_change_index", UniValueType(UniValue::VNUM)},
1086 : : },
1087 : : true, true);
1088 : :
1089 [ + - + - : 127 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1090 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1091 : : }
1092 : :
1093 [ + - - + : 186 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1094 : :
1095 [ + - + + ]: 124 : if (options.exists("replaceable")) {
1096 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1097 : : }
1098 [ + - + - : 143 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1099 : :
1100 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1101 [ + - + - : 43 : if (!options["outputs"].isNull()) {
+ + ]
1102 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- + + + +
- - ]
1103 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1104 : : }
1105 [ + - ]: 10 : CMutableTransaction tempTx;
1106 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1107 [ + - ]: 8 : outputs = tempTx.vout;
1108 : 10 : }
1109 : :
1110 [ + - + + ]: 80 : if (options.exists("original_change_index")) {
1111 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1112 : : }
1113 : 90 : }
1114 : :
1115 : : // Make sure the results are valid at least up to the most recent block
1116 : : // the user could have gotten from another RPC command prior to now
1117 [ + - ]: 130 : pwallet->BlockUntilSyncedToCurrentChain();
1118 : :
1119 [ + - ]: 130 : LOCK(pwallet->cs_wallet);
1120 : :
1121 [ + + ]: 130 : EnsureWalletIsUnlocked(*pwallet);
1122 : :
1123 : :
1124 : 129 : std::vector<bilingual_str> errors;
1125 : 129 : CAmount old_fee;
1126 : 129 : CAmount new_fee;
1127 [ + - ]: 129 : CMutableTransaction mtx;
1128 : 129 : feebumper::Result res;
1129 : : // Targeting feerate bump.
1130 [ + - ]: 129 : res = feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index);
1131 [ + + ]: 129 : if (res != feebumper::Result::OK) {
1132 [ - - + + : 25 : switch(res) {
+ ]
1133 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1134 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1135 : 0 : break;
1136 : 0 : case feebumper::Result::INVALID_REQUEST:
1137 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1138 : 16 : break;
1139 : 16 : case feebumper::Result::INVALID_PARAMETER:
1140 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1141 : 8 : break;
1142 : 8 : case feebumper::Result::WALLET_ERROR:
1143 [ + - ]: 8 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1144 : 1 : break;
1145 : 1 : default:
1146 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1147 : 104 : break;
1148 : : }
1149 : : }
1150 : :
1151 : 208 : UniValue result(UniValue::VOBJ);
1152 : :
1153 : : // For bumpfee, return the new transaction id.
1154 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1155 [ + + ]: 104 : if (!want_psbt) {
1156 [ + - - + ]: 97 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1157 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1158 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1159 : : }
1160 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1161 : : }
1162 : :
1163 : 97 : uint256 txid;
1164 [ + - - + ]: 97 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1165 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1166 : : }
1167 : :
1168 [ + - + - : 194 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1169 : : } else {
1170 [ + - ]: 7 : PartiallySignedTransaction psbtx(mtx);
1171 : 7 : bool complete = false;
1172 [ + - ]: 7 : const auto err{pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/false, /*bip32derivs=*/true)};
1173 [ + - ]: 7 : CHECK_NONFATAL(!err);
1174 [ + - ]: 7 : CHECK_NONFATAL(!complete);
1175 : 7 : DataStream ssTx{};
1176 [ + - ]: 7 : ssTx << psbtx;
1177 [ + - + - : 14 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1178 : 7 : }
1179 : :
1180 [ + - + - : 208 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1181 [ + - + - : 208 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1182 : 208 : UniValue result_errors(UniValue::VARR);
1183 [ - + ]: 104 : for (const bilingual_str& error : errors) {
1184 [ # # # # ]: 0 : result_errors.push_back(error.original);
1185 : : }
1186 [ + - + - ]: 208 : result.pushKV("errors", std::move(result_errors));
1187 : :
1188 : 104 : return result;
1189 [ + - + - : 516 : },
+ - + - +
- + - + -
+ - + - -
+ ]
1190 [ + - + - : 76164 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
1191 [ + - + - : 39813 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
1192 : :
1193 [ + - ]: 1876 : RPCHelpMan bumpfee() { return bumpfee_helper("bumpfee"); }
1194 [ + - ]: 1586 : RPCHelpMan psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1195 : :
1196 : 991 : RPCHelpMan send()
1197 : : {
1198 : 991 : return RPCHelpMan{"send",
1199 : : "\nEXPERIMENTAL warning: this call may be changed in future releases.\n"
1200 : : "\nSend a transaction.\n",
1201 : : {
1202 [ + - ]: 991 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1203 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1204 : : "At least one output of either type must be specified.\n"
1205 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1206 [ + - ]: 1982 : OutputsDoc(),
1207 [ + - ]: 1982 : RPCArgOptions{.skip_type_check = true}},
1208 [ + - ]: 1982 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1209 [ + - ]: 1982 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1210 [ + - + - ]: 1982 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1211 [ + - ]: 2973 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1212 [ + - ]: 991 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1213 [ + - + - : 99100 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + +
+ + + + +
- - - - -
- - - ]
1214 : : {
1215 [ + - ]: 1982 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
1216 [ + - ]: 1982 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1217 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1218 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1219 [ + - ]: 1982 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1220 [ + - ]: 991 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1221 [ + - ]: 1982 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
1222 [ + - ]: 1982 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1223 [ + - ]: 1982 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1224 [ + - ]: 1982 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\" and \"bech32m\"."},
1225 [ + - + - : 4955 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1226 [ + - ]: 1982 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
1227 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1228 : : "e.g. with 'importpubkey' or 'importmulti' with the 'pubkeys' or 'desc' field."},
1229 : 1982 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
1230 : : {
1231 [ + - ]: 991 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
1232 [ + - ]: 991 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1233 [ + - ]: 991 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1234 [ + - ]: 1982 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1235 [ + - ]: 1982 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1236 : : "including the weight of the outpoint and sequence number. "
1237 : : "Note that signature sizes are not guaranteed to be consistent, "
1238 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1239 : : "Remember to convert serialized sizes to weight units when necessary."},
1240 : : }},
1241 : : },
1242 : : },
1243 [ + - ]: 1982 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1244 [ + - ]: 1982 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1245 [ + - ]: 1982 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1246 : 1982 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1247 : : "The fee will be equally deducted from the amount of each specified output.\n"
1248 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1249 : : "If no outputs are specified here, the sender pays the fee.",
1250 : : {
1251 [ + - ]: 991 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1252 : : },
1253 : : },
1254 [ + - ]: 1982 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1255 : : "Transaction building will fail if this can not be satisfied."},
1256 : : },
1257 [ + - ]: 1982 : FundTxDoc()),
1258 [ + - + - ]: 1982 : RPCArgOptions{.oneline_description="options"}},
1259 : : },
1260 : 0 : RPCResult{
1261 : : RPCResult::Type::OBJ, "", "",
1262 : : {
1263 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1264 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1265 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1266 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1267 : : }
1268 [ + - + - : 5946 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1269 : 991 : RPCExamples{""
1270 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1271 [ + - + - : 2973 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1272 [ + - ]: 1982 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1273 [ + - + - : 4955 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1274 [ + - ]: 1982 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1275 [ + - + - : 4955 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1276 [ + - ]: 1982 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1277 [ + - + - : 4955 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1278 : 991 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1279 [ + - + - : 4955 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1280 [ + - ]: 991 : },
1281 : 205 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1282 : : {
1283 : 205 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1284 [ - + ]: 205 : if (!pwallet) return UniValue::VNULL;
1285 : :
1286 [ + - + + : 205 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1287 [ + - + - : 205 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1288 [ + + ]: 201 : PreventOutdatedOptions(options);
1289 : :
1290 : :
1291 [ + - + + : 400 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1292 : 200 : UniValue outputs(UniValue::VOBJ);
1293 [ + - + - ]: 200 : outputs = NormalizeOutputs(request.params[0]);
1294 : 200 : std::vector<CRecipient> recipients = CreateRecipients(
1295 [ + + ]: 399 : ParseOutputs(outputs),
1296 [ + - + - : 401 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1297 [ + - ]: 199 : );
1298 [ + - + - : 398 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf);
+ - + - +
- + - ]
1299 [ + - ]: 199 : CCoinControl coin_control;
1300 : : // Automatically select coins, unless at least one is manually selected. Can
1301 : : // be overridden by options.add_inputs.
1302 [ + - ]: 199 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1303 [ + - - + ]: 398 : if (options.exists("max_tx_weight")) {
1304 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1305 : : }
1306 [ + - + - : 200 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1307 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1308 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1309 : 198 : rawTx.vout.clear();
1310 [ + + ]: 198 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1311 : :
1312 [ + - + - : 468 : return FinishTransaction(pwallet, options, CMutableTransaction(*txr.tx));
+ - ]
1313 : 686 : }
1314 [ + - + - : 26757 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ - - ]
1315 [ + - + - : 56487 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
1316 : :
1317 : 886 : RPCHelpMan sendall()
1318 : : {
1319 : 886 : return RPCHelpMan{"sendall",
1320 : : "EXPERIMENTAL warning: this call may be changed in future releases.\n"
1321 : : "\nSpend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1322 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1323 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1324 : : {
1325 [ + - ]: 886 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1326 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1327 : : {
1328 [ + - ]: 886 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1329 [ + - ]: 886 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1330 : : {
1331 [ + - ]: 1772 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1332 : : },
1333 : : },
1334 : : },
1335 : : },
1336 [ + - ]: 1772 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1337 [ + - ]: 1772 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1338 [ + - + - ]: 1772 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1339 [ + - ]: 2658 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1340 : : {
1341 [ + - ]: 886 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1342 [ + - + - : 54932 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1343 : : {
1344 [ + - ]: 1772 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
1345 [ + - + - : 4430 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1346 [ + - ]: 1772 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch-only.\n"
1347 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1348 : : "e.g. with 'importpubkey' or 'importmulti' with the 'pubkeys' or 'desc' field."},
1349 : 1772 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1350 : : {
1351 [ + - ]: 886 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1352 : : {
1353 [ + - ]: 886 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1354 [ + - ]: 886 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1355 [ + - ]: 1772 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1356 : : },
1357 : : },
1358 : : },
1359 : : },
1360 [ + - ]: 1772 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1361 [ + - ]: 1772 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1362 [ + - ]: 1772 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1363 [ + - ]: 1772 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
1364 [ + - ]: 1772 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
1365 [ + - ]: 886 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1366 : : },
1367 [ + - ]: 1772 : FundTxDoc()
1368 : : ),
1369 [ + - + - ]: 1772 : RPCArgOptions{.oneline_description="options"}
1370 : : },
1371 : : },
1372 : 0 : RPCResult{
1373 : : RPCResult::Type::OBJ, "", "",
1374 : : {
1375 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1376 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1377 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1378 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1379 : : }
1380 [ + - + - : 5316 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1381 : 886 : RPCExamples{""
1382 [ + - ]: 1772 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1383 [ + - + - : 4430 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1384 [ + - ]: 1772 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1385 [ + - + - : 4430 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1386 [ + - ]: 1772 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1387 [ + - + - : 5316 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1388 [ + - ]: 1772 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1389 [ + - + - : 4430 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1390 [ + - + - ]: 2658 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1391 [ + - + - : 5316 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1392 [ + - ]: 886 : },
1393 : 100 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1394 : : {
1395 : 100 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1396 [ - + ]: 100 : if (!pwallet) return UniValue::VNULL;
1397 : : // Make sure the results are valid at least up to the most recent block
1398 : : // the user could have gotten from another RPC command prior to now
1399 [ + - ]: 100 : pwallet->BlockUntilSyncedToCurrentChain();
1400 : :
1401 [ + - + + : 100 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1402 [ + - + - : 100 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1403 [ + - ]: 100 : PreventOutdatedOptions(options);
1404 : :
1405 : :
1406 : 100 : std::set<std::string> addresses_without_amount;
1407 : 100 : UniValue recipient_key_value_pairs(UniValue::VARR);
1408 [ + - ]: 100 : const UniValue& recipients{request.params[0]};
1409 [ + + ]: 213 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1410 [ + - ]: 113 : const UniValue& recipient{recipients[i]};
1411 [ + + ]: 113 : if (recipient.isStr()) {
1412 : 104 : UniValue rkvp(UniValue::VOBJ);
1413 [ + - + - : 208 : rkvp.pushKV(recipient.get_str(), 0);
+ - + - ]
1414 [ + - ]: 104 : recipient_key_value_pairs.push_back(std::move(rkvp));
1415 [ + - + - ]: 104 : addresses_without_amount.insert(recipient.get_str());
1416 : 104 : } else {
1417 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1418 : : }
1419 : : }
1420 : :
1421 [ + + ]: 100 : if (addresses_without_amount.size() == 0) {
1422 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1423 : : }
1424 : :
1425 [ + - ]: 98 : CCoinControl coin_control;
1426 : :
1427 [ + - + - : 196 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1428 : :
1429 [ + - + - : 98 : coin_control.fAllowWatchOnly = ParseIncludeWatchonly(options["include_watching"], *pwallet);
+ - ]
1430 : :
1431 [ + - + + ]: 196 : if (options.exists("minconf")) {
1432 [ + - + - : 5 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1433 : : {
1434 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1435 : : }
1436 : :
1437 [ + - + - : 4 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1438 : : }
1439 : :
1440 [ + - + + ]: 194 : if (options.exists("maxconf")) {
1441 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1442 : :
1443 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1444 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1445 : : }
1446 : : }
1447 : :
1448 [ + - - + : 194 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1449 : :
1450 : 97 : FeeCalculation fee_calc_out;
1451 [ + - ]: 97 : CFeeRate fee_rate{GetMinimumFeeRate(*pwallet, coin_control, &fee_calc_out)};
1452 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1453 : : // provided one
1454 [ + + + + ]: 97 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1455 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s)", coin_control.m_feerate->ToString(FeeEstimateMode::SAT_VB), fee_rate.ToString(FeeEstimateMode::SAT_VB)));
+ - + - ]
1456 : : }
1457 [ + + + - ]: 96 : if (fee_calc_out.reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1458 : : // eventually allow a fallback fee
1459 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1460 : : }
1461 : :
1462 [ + - + - : 193 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf)};
+ - + - +
+ ]
1463 [ + - ]: 95 : LOCK(pwallet->cs_wallet);
1464 : :
1465 : 95 : CAmount total_input_value(0);
1466 [ + - + + : 190 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1467 [ + - + - : 205 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1468 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1469 [ + - + - : 215 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1470 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1471 [ + - + + ]: 186 : } else if (options.exists("inputs")) {
1472 [ + + ]: 22 : for (const CTxIn& input : rawTx.vin) {
1473 [ + - + + ]: 13 : if (pwallet->IsSpent(input.prevout)) {
1474 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1475 : : }
1476 [ + - ]: 11 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1477 [ + + + + : 19 : if (!tx || input.prevout.n >= tx->tx->vout.size() || !(pwallet->IsMine(tx->tx->vout[input.prevout.n]) & (coin_control.fAllowWatchOnly ? ISMINE_ALL : ISMINE_SPENDABLE))) {
+ - + + +
- ]
1478 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1479 : : }
1480 : 9 : total_input_value += tx->tx->vout[input.prevout.n].nValue;
1481 : : }
1482 : : } else {
1483 : 80 : CoinFilterParams coins_params;
1484 : 80 : coins_params.min_amount = 0;
1485 [ + - + - : 2537 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1486 [ + - ]: 2457 : CHECK_NONFATAL(output.input_bytes > 0);
1487 [ + + + - : 2457 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1488 : 2 : continue;
1489 : : }
1490 [ + + + - ]: 2457 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::SEQUENCE_FINAL);
1491 [ + - ]: 2455 : rawTx.vin.push_back(input);
1492 : 2455 : total_input_value += output.txout.nValue;
1493 : 2535 : }
1494 : : }
1495 : :
1496 : 89 : std::vector<COutPoint> outpoints_spent;
1497 [ + - ]: 89 : outpoints_spent.reserve(rawTx.vin.size());
1498 : :
1499 [ + + ]: 2553 : for (const CTxIn& tx_in : rawTx.vin) {
1500 [ + - ]: 2464 : outpoints_spent.push_back(tx_in.prevout);
1501 : : }
1502 : :
1503 : : // estimate final size of tx
1504 [ + - + - ]: 89 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1505 [ + - ]: 89 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1506 [ + - ]: 89 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1507 [ + - ]: 89 : CAmount effective_value = total_input_value - fee_from_size - total_bump_fees.value_or(0);
1508 : :
1509 [ + + ]: 89 : if (fee_from_size > pwallet->m_default_max_tx_fee) {
1510 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1511 : : }
1512 : :
1513 [ + + ]: 88 : if (effective_value <= 0) {
1514 [ - + ]: 3 : if (send_max) {
1515 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1516 : : } else {
1517 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1518 : : }
1519 : : }
1520 : :
1521 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1522 [ + + ]: 85 : if (tx_size.weight > MAX_STANDARD_TX_WEIGHT) {
1523 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1524 : : }
1525 : :
1526 : 84 : CAmount output_amounts_claimed{0};
1527 [ + + ]: 181 : for (const CTxOut& out : rawTx.vout) {
1528 : 97 : output_amounts_claimed += out.nValue;
1529 : : }
1530 : :
1531 [ + + ]: 84 : if (output_amounts_claimed > total_input_value) {
1532 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1533 : : }
1534 : :
1535 : 83 : const CAmount remainder{effective_value - output_amounts_claimed};
1536 [ + + ]: 83 : if (remainder < 0) {
1537 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1538 : : }
1539 : :
1540 : 82 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1541 : :
1542 : 82 : bool gave_remaining_to_first{false};
1543 [ + + ]: 171 : for (CTxOut& out : rawTx.vout) {
1544 : 92 : CTxDestination dest;
1545 [ + - ]: 92 : ExtractDestination(out.scriptPubKey, dest);
1546 [ + - ]: 92 : std::string addr{EncodeDestination(dest)};
1547 [ + + ]: 92 : if (addresses_without_amount.count(addr) > 0) {
1548 : 86 : out.nValue = per_output_without_amount;
1549 [ + + ]: 86 : if (!gave_remaining_to_first) {
1550 : 81 : out.nValue += remainder % addresses_without_amount.size();
1551 : 81 : gave_remaining_to_first = true;
1552 : : }
1553 [ + - + - : 86 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1554 : : // Dynamically generated output amount is dust
1555 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1556 : : }
1557 : : } else {
1558 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1559 : : // Specified output amount is dust
1560 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", addr));
1561 : : }
1562 : : }
1563 : 95 : }
1564 : :
1565 [ + - + + : 158 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1566 [ + + ]: 79 : if (lock_unspents) {
1567 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1568 [ + - ]: 2 : pwallet->LockCoin(txin.prevout);
1569 : : }
1570 : : }
1571 : :
1572 [ + - + - ]: 237 : return FinishTransaction(pwallet, options, rawTx);
1573 [ + - ]: 403 : }
1574 [ + - + - : 31896 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ - - - -
- - ]
1575 [ + - + - : 42528 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - - -
- - ]
1576 : :
1577 : 1133 : RPCHelpMan walletprocesspsbt()
1578 : : {
1579 : 1133 : return RPCHelpMan{"walletprocesspsbt",
1580 : : "\nUpdate a PSBT with input information from our wallet and then sign inputs\n"
1581 : 1133 : "that we can sign for." +
1582 [ + - ]: 1133 : HELP_REQUIRING_PASSPHRASE,
1583 : : {
1584 [ + - ]: 1133 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1585 [ + - ]: 2266 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
1586 [ + - ]: 2266 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
1587 : : " \"DEFAULT\"\n"
1588 : : " \"ALL\"\n"
1589 : : " \"NONE\"\n"
1590 : : " \"SINGLE\"\n"
1591 : : " \"ALL|ANYONECANPAY\"\n"
1592 : : " \"NONE|ANYONECANPAY\"\n"
1593 : : " \"SINGLE|ANYONECANPAY\""},
1594 [ + - ]: 2266 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1595 [ + - ]: 2266 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
1596 : : },
1597 : 0 : RPCResult{
1598 : : RPCResult::Type::OBJ, "", "",
1599 : : {
1600 : : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1601 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1602 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1603 : : }
1604 [ + - + - : 5665 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1605 : 1133 : RPCExamples{
1606 [ + - + - : 2266 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1607 [ + - ]: 1133 : },
1608 : 347 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1609 : : {
1610 [ - + ]: 347 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1611 [ - + ]: 347 : if (!pwallet) return UniValue::VNULL;
1612 : :
1613 [ + - ]: 347 : const CWallet& wallet{*pwallet};
1614 : : // Make sure the results are valid at least up to the most recent block
1615 : : // the user could have gotten from another RPC command prior to now
1616 [ + - ]: 347 : wallet.BlockUntilSyncedToCurrentChain();
1617 : :
1618 : : // Unserialize the transaction
1619 : 347 : PartiallySignedTransaction psbtx;
1620 [ + - ]: 347 : std::string error;
1621 [ + - + - : 347 : if (!DecodeBase64PSBT(psbtx, request.params[0].get_str(), error)) {
+ - + + ]
1622 [ + - + - ]: 4 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", error));
1623 : : }
1624 : :
1625 : : // Get the sighash type
1626 [ + - + + ]: 345 : int nHashType = ParseSighashString(request.params[2]);
1627 : :
1628 : : // Fill transaction with our data and also sign
1629 [ + - + + : 344 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1630 [ + - + + : 344 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1631 [ + - + + : 344 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1632 : 344 : bool complete = true;
1633 : :
1634 [ + + + + ]: 344 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1635 : :
1636 [ + - ]: 343 : const auto err{wallet.FillPSBT(psbtx, complete, nHashType, sign, bip32derivs, nullptr, finalize)};
1637 [ - + ]: 343 : if (err) {
1638 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1639 : : }
1640 : :
1641 : 343 : UniValue result(UniValue::VOBJ);
1642 : 343 : DataStream ssTx{};
1643 [ + - ]: 343 : ssTx << psbtx;
1644 [ + - + - : 686 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1645 [ + - + - : 686 : result.pushKV("complete", complete);
+ - ]
1646 [ + + ]: 343 : if (complete) {
1647 [ + - ]: 37 : CMutableTransaction mtx;
1648 : : // Returns true if complete, which we already think it is.
1649 [ + - + - ]: 37 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1650 : 37 : DataStream ssTx_final;
1651 [ + - ]: 37 : ssTx_final << TX_WITH_WITNESS(mtx);
1652 [ + - + - : 74 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - ]
1653 : 74 : }
1654 : :
1655 : 343 : return result;
1656 : 690 : },
1657 [ + - + - : 35123 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1658 [ + - + - : 16995 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
1659 : :
1660 : 987 : RPCHelpMan walletcreatefundedpsbt()
1661 : : {
1662 : 987 : return RPCHelpMan{"walletcreatefundedpsbt",
1663 : : "\nCreates and funds a transaction in the Partially Signed Transaction format.\n"
1664 : : "Implements the Creator and Updater roles.\n"
1665 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1666 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1667 : : {
1668 [ + - ]: 987 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1669 : : {
1670 [ + - ]: 987 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1671 : : {
1672 [ + - ]: 987 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1673 [ + - ]: 987 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1674 [ + - ]: 1974 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
1675 [ + - ]: 1974 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1676 : : "including the weight of the outpoint and sequence number. "
1677 : : "Note that signature sizes are not guaranteed to be consistent, "
1678 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1679 : : "Remember to convert serialized sizes to weight units when necessary."},
1680 : : },
1681 : : },
1682 : : },
1683 : : },
1684 [ + - ]: 987 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1685 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1686 : : "At least one output of either type must be specified.\n"
1687 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1688 : : "accepted as second parameter.",
1689 [ + - ]: 1974 : OutputsDoc(),
1690 [ + - ]: 1974 : RPCArgOptions{.skip_type_check = true}},
1691 [ + - ]: 1974 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1692 [ + - ]: 987 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1693 [ + - + - : 64155 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1694 : : {
1695 [ + - ]: 1974 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
1696 [ + - ]: 1974 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1697 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1698 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1699 [ + - ]: 1974 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1700 [ + - ]: 987 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1701 [ + - ]: 1974 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1702 [ + - ]: 1974 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1703 [ + - ]: 1974 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
1704 [ + - ]: 1974 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only"},
1705 [ + - ]: 1974 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1706 [ + - + - ]: 3948 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1707 [ + - + - ]: 3948 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
1708 : 1974 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1709 : : "The fee will be equally deducted from the amount of each specified output.\n"
1710 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1711 : : "If no outputs are specified here, the sender pays the fee.",
1712 : : {
1713 [ + - ]: 987 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1714 : : },
1715 : : },
1716 [ + - ]: 1974 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1717 : : "Transaction building will fail if this can not be satisfied."},
1718 : : },
1719 [ + - ]: 1974 : FundTxDoc()),
1720 [ + - + - ]: 1974 : RPCArgOptions{.oneline_description="options"}},
1721 [ + - ]: 1974 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1722 : : },
1723 : 0 : RPCResult{
1724 : : RPCResult::Type::OBJ, "", "",
1725 : : {
1726 : : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1727 [ + - ]: 1974 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1728 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1729 : : }
1730 [ + - + - : 6909 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
1731 : 987 : RPCExamples{
1732 : : "\nCreate a transaction with no inputs\n"
1733 [ + - + - : 1974 : + HelpExampleCli("walletcreatefundedpsbt", "\"[{\\\"txid\\\":\\\"myid\\\",\\\"vout\\\":0}]\" \"[{\\\"data\\\":\\\"00010203\\\"}]\"")
+ - + - ]
1734 [ + - ]: 987 : },
1735 : 201 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1736 : : {
1737 : 201 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1738 [ - + ]: 201 : if (!pwallet) return UniValue::VNULL;
1739 : :
1740 [ + - ]: 201 : CWallet& wallet{*pwallet};
1741 : : // Make sure the results are valid at least up to the most recent block
1742 : : // the user could have gotten from another RPC command prior to now
1743 [ + - ]: 201 : wallet.BlockUntilSyncedToCurrentChain();
1744 : :
1745 [ + - + + : 201 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1746 : :
1747 [ + - + - ]: 201 : const UniValue &replaceable_arg = options["replaceable"];
1748 [ + + + - ]: 201 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1749 [ + - + - : 201 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf);
+ - + - ]
1750 : 201 : UniValue outputs(UniValue::VOBJ);
1751 [ + - + - ]: 201 : outputs = NormalizeOutputs(request.params[1]);
1752 : 201 : std::vector<CRecipient> recipients = CreateRecipients(
1753 [ + - ]: 402 : ParseOutputs(outputs),
1754 [ + - + - : 402 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1755 [ + - ]: 201 : );
1756 [ + - ]: 201 : CCoinControl coin_control;
1757 : : // Automatically select coins, unless at least one is manually selected. Can
1758 : : // be overridden by options.add_inputs.
1759 [ + - ]: 201 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1760 [ + - + + ]: 201 : SetOptionsInputWeights(request.params[0], options);
1761 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1762 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1763 : 200 : rawTx.vout.clear();
1764 [ + + ]: 200 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1765 : :
1766 : : // Make a blank psbt
1767 [ + - + - ]: 132 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx));
1768 : :
1769 : : // Fill transaction with out data but don't sign
1770 [ + - + + : 132 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1771 : 132 : bool complete = true;
1772 [ + - ]: 132 : const auto err{wallet.FillPSBT(psbtx, complete, 1, /*sign=*/false, /*bip32derivs=*/bip32derivs)};
1773 [ - + ]: 132 : if (err) {
1774 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1775 : : }
1776 : :
1777 : : // Serialize the PSBT
1778 : 132 : DataStream ssTx{};
1779 [ + - ]: 132 : ssTx << psbtx;
1780 : :
1781 : 132 : UniValue result(UniValue::VOBJ);
1782 [ + - + - : 264 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1783 [ + - + - : 264 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1784 [ + + + - : 264 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1785 : 132 : return result;
1786 [ + - ]: 804 : },
1787 [ + - + - : 43428 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1788 [ + - + - : 50337 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1789 : : } // namespace wallet
|
