Branch data Line data Source code
1 : : // Copyright (c) 2011-present The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <policy/truc_policy.h>
12 : : #include <rpc/rawtransaction_util.h>
13 : : #include <rpc/util.h>
14 : : #include <script/script.h>
15 : : #include <util/rbf.h>
16 : : #include <util/translation.h>
17 : : #include <util/vector.h>
18 : : #include <wallet/coincontrol.h>
19 : : #include <wallet/feebumper.h>
20 : : #include <wallet/fees.h>
21 : : #include <wallet/rpc/util.h>
22 : : #include <wallet/spend.h>
23 : : #include <wallet/wallet.h>
24 : :
25 : : #include <univalue.h>
26 : :
27 : : using common::FeeModeFromString;
28 : : using common::FeeModesDetail;
29 : : using common::InvalidEstimateModeErrorMessage;
30 : : using common::StringForFeeReason;
31 : : using common::TransactionErrorString;
32 : : using node::TransactionError;
33 : :
34 : : namespace wallet {
35 : 2077 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
36 : : {
37 : 2077 : std::vector<CRecipient> recipients;
38 [ - + + + ]: 23234 : for (size_t i = 0; i < outputs.size(); ++i) {
39 [ + - + - ]: 21157 : const auto& [destination, amount] = outputs.at(i);
40 [ + - ]: 42314 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
41 [ + - ]: 21157 : recipients.push_back(recipient);
42 : 21157 : }
43 : 2077 : return recipients;
44 : 0 : }
45 : :
46 : 486 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
47 : : {
48 [ + - + - : 1435 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
49 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
50 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
51 : : }
52 : : } else {
53 [ + - + - ]: 924 : options.pushKV("conf_target", conf_target);
54 [ + - + - ]: 924 : options.pushKV("estimate_mode", estimate_mode);
55 : : }
56 [ + + ]: 966 : if (options.exists("fee_rate")) {
57 [ + + ]: 28 : if (!fee_rate.isNull()) {
58 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
59 : : }
60 : : } else {
61 [ + - + - ]: 910 : options.pushKV("fee_rate", fee_rate);
62 : : }
63 [ + - + - : 1022 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
64 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
65 : : }
66 : 482 : }
67 : :
68 : 805 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
69 : : {
70 [ + + ]: 805 : std::set<int> sffo_set;
71 [ + + ]: 805 : if (sffo_instructions.isNull()) return sffo_set;
72 : :
73 [ + - + + ]: 200 : for (const auto& sffo : sffo_instructions.getValues()) {
74 : 105 : int pos{-1};
75 [ + + ]: 105 : if (sffo.isStr()) {
76 [ + - ]: 9 : auto it = find(destinations.begin(), destinations.end(), sffo.get_str());
77 [ + + + - : 10 : if (it == destinations.end()) throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', destination %s not found in tx outputs", sffo.get_str()));
+ - + - ]
78 : 8 : pos = it - destinations.begin();
79 [ + + ]: 96 : } else if (sffo.isNum()) {
80 [ + - ]: 95 : pos = sffo.getInt<int>();
81 : : } else {
82 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', invalid value type: %s", uvTypeName(sffo.type())));
+ - ]
83 : : }
84 : :
85 [ + + ]: 103 : if (sffo_set.contains(pos))
86 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', duplicated position: %d", pos));
87 [ + + ]: 101 : if (pos < 0)
88 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', negative position: %d", pos));
89 [ - + + + ]: 100 : if (pos >= int(destinations.size()))
90 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter 'subtract fee from output', position too large: %d", pos));
91 [ + - ]: 99 : sffo_set.insert(pos);
92 : : }
93 : : return sffo_set;
94 : 6 : }
95 : :
96 : 339 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, CMutableTransaction& rawTx)
97 : : {
98 : 678 : bool can_anti_fee_snipe = !options.exists("locktime");
99 : :
100 [ + + ]: 1835 : for (const CTxIn& tx_in : rawTx.vin) {
101 : : // Checks sequence values consistent with DiscourageFeeSniping
102 [ + + + + ]: 1536 : can_anti_fee_snipe = can_anti_fee_snipe && (tx_in.nSequence == CTxIn::MAX_SEQUENCE_NONFINAL || tx_in.nSequence == MAX_BIP125_RBF_SEQUENCE);
103 : : }
104 : :
105 [ + + ]: 339 : if (can_anti_fee_snipe) {
106 : 301 : LOCK(pwallet->cs_wallet);
107 : 301 : FastRandomContext rng_fast;
108 [ + - ]: 301 : DiscourageFeeSniping(rawTx, rng_fast, pwallet->chain(), pwallet->GetLastBlockHash(), pwallet->GetLastBlockHeight());
109 [ + - ]: 602 : }
110 : :
111 : : // Make a blank psbt
112 : 339 : PartiallySignedTransaction psbtx(rawTx, /*version=*/2);
113 : :
114 : : // First fill transaction with our data without signing,
115 : : // so external signers are not asked to sign more than once.
116 : 339 : bool complete;
117 [ + - ]: 339 : pwallet->FillPSBT(psbtx, {.sign = false, .bip32_derivs = true}, complete);
118 [ + - ]: 339 : const auto err{pwallet->FillPSBT(psbtx, {.sign = true, .bip32_derivs = false}, complete)};
119 [ + + ]: 339 : if (err) {
120 [ + - ]: 1 : throw JSONRPCPSBTError(*err);
121 : : }
122 : :
123 [ + - ]: 338 : CMutableTransaction mtx;
124 [ + - ]: 338 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
125 : :
126 : 338 : UniValue result(UniValue::VOBJ);
127 : :
128 [ + - + - : 359 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
129 [ + - + + : 741 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
130 [ + + + + : 338 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
131 : : // Serialize the PSBT
132 : 92 : DataStream ssTx{};
133 [ + - ]: 92 : ssTx << psbtx;
134 [ + - + - : 276 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
135 : 92 : }
136 : :
137 [ + + ]: 338 : if (complete) {
138 [ + - + - ]: 310 : std::string hex{EncodeHexTx(CTransaction(mtx))};
139 [ + - ]: 310 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
140 [ + - + - : 620 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
141 [ + + ]: 310 : if (add_to_wallet && !psbt_opt_in) {
142 [ + - + - ]: 984 : pwallet->CommitTransaction(tx);
143 : : } else {
144 [ + - + - : 128 : result.pushKV("hex", hex);
+ - ]
145 : : }
146 : 310 : }
147 [ + - + - : 676 : result.pushKV("complete", complete);
+ - ]
148 : :
149 : 676 : return result;
150 : 339 : }
151 : :
152 : 482 : static void PreventOutdatedOptions(const UniValue& options)
153 : : {
154 [ + + ]: 964 : if (options.exists("feeRate")) {
155 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
156 : : }
157 [ - + ]: 962 : if (options.exists("changeAddress")) {
158 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
159 : : }
160 [ - + ]: 962 : if (options.exists("changePosition")) {
161 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
162 : : }
163 [ - + ]: 962 : if (options.exists("lockUnspents")) {
164 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
165 : : }
166 [ - + ]: 962 : if (options.exists("subtractFeeFromOutputs")) {
167 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
168 : : }
169 : 481 : }
170 : :
171 : 1333 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, std::optional<std::string> comment, std::optional<std::string> comment_to, bool verbose)
172 : : {
173 : 1333 : EnsureWalletIsUnlocked(wallet);
174 : :
175 : : // This function is only used by sendtoaddress and sendmany.
176 : : // This should always try to sign, if we don't have (all) private keys, don't
177 : : // try to do anything here.
178 [ + + ]: 1333 : if (wallet.IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
179 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: sendtoaddress and sendmany are not supported for wallets with external signers; use send instead");
180 : : }
181 [ + + ]: 1331 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
182 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
183 : : }
184 : :
185 : : // Shuffle recipient list
186 : 1330 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
187 : :
188 : : // Send
189 : 1330 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
190 [ + + ]: 1330 : if (!res) {
191 [ + - + - ]: 38 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
192 : : }
193 : 1311 : const CTransactionRef& tx = res->tx;
194 [ + - + - : 6555 : wallet.CommitTransaction(tx, /*replaces_txid=*/std::nullopt, comment, comment_to);
+ - + - ]
195 [ + + ]: 1311 : if (verbose) {
196 : 6 : UniValue entry(UniValue::VOBJ);
197 [ + - + - : 12 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
198 [ + - + - : 12 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_reason));
+ - + - ]
199 : 6 : return entry;
200 : 0 : }
201 [ + - + - ]: 1305 : return tx->GetHash().GetHex();
202 : 1311 : }
203 : :
204 : :
205 : : /**
206 : : * Update coin control with fee estimation based on the given parameters
207 : : *
208 : : * @param[in] wallet Wallet reference
209 : : * @param[in,out] cc Coin control to be updated
210 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees/block_policy_estimator.h;
211 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
212 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
213 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
214 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
215 : : * verify only that fee_rate is greater than 0
216 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
217 : : */
218 : 2315 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
219 : : {
220 [ + + ]: 2315 : if (!fee_rate.isNull()) {
221 [ + + ]: 612 : if (!conf_target.isNull()) {
222 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
223 : : }
224 [ + + + + ]: 609 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
225 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
226 : : }
227 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
228 [ - + ]: 606 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
229 [ + + ]: 530 : if (override_min_fee) cc.fOverrideFeeRate = true;
230 : : // Default RBF to true for explicit fee_rate, if unset.
231 [ + + ]: 530 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
232 : 530 : return;
233 : : }
234 [ + + - + : 1703 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
+ + ]
235 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
236 : : }
237 [ + + ]: 1676 : if (!conf_target.isNull()) {
238 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().maximumFeeEstimationTargetBlocks());
239 : : }
240 : : }
241 : :
242 : 2179 : RPCMethod sendtoaddress()
243 : : {
244 : 2179 : return RPCMethod{
245 : 2179 : "sendtoaddress",
246 : 2179 : "Send an amount to a given address." +
247 [ + - ]: 2179 : HELP_REQUIRING_PASSPHRASE,
248 : : {
249 [ + - + - ]: 4358 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
250 [ + - + - ]: 4358 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
251 [ + - + - ]: 4358 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
252 : : "This is not part of the transaction, just kept in your wallet."},
253 [ + - + - ]: 4358 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
254 : : "to which you're sending the transaction. This is not part of the \n"
255 : : "transaction, just kept in your wallet."},
256 [ + - + - : 6537 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
+ - ]
257 : : "The recipient will receive less bitcoins than you enter in the amount field."},
258 [ + - + - : 6537 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
+ - ]
259 [ + - + - : 6537 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
260 [ + - + - ]: 4358 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
261 [ + - + - : 4358 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
262 [ + - + - : 6537 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
+ - ]
263 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
264 [ + - + - : 6537 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
265 [ + - + - : 6537 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
+ - ]
266 : : },
267 : : {
268 [ + - ]: 2179 : RPCResult{"if verbose is not set or set to false",
269 [ + - + - ]: 4358 : RPCResult::Type::STR_HEX, "txid", "The transaction id."
270 : 2179 : },
271 [ + - ]: 4358 : RPCResult{"if verbose is set to true",
272 [ + - + - ]: 4358 : RPCResult::Type::OBJ, "", "",
273 : : {
274 [ + - + - ]: 4358 : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
275 [ + - + - ]: 4358 : {RPCResult::Type::STR, "fee_reason", "The reason the wallet selected this fee rate (e.g. fee rate estimator, mempool minimum, fallback, or minimum required)."}
276 : : },
277 [ + - + + : 13074 : },
- - ]
278 : : },
279 : 2179 : RPCExamples{
280 : : "\nSend 0.1 BTC\n"
281 [ + - + - : 6537 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
282 : 2179 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
283 [ + - + - : 10895 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
284 [ + - ]: 4358 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
285 [ + - + - : 10895 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
286 : 2179 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
287 [ + - + - : 10895 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
288 [ + - ]: 4358 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
289 [ + - + - : 10895 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
290 [ + - + - : 8716 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
291 [ + - ]: 2179 : },
292 : 2179 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
293 : : {
294 : 1284 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
295 [ - + ]: 1284 : if (!pwallet) return UniValue::VNULL;
296 : :
297 : : // Make sure the results are valid at least up to the most recent block
298 : : // the user could have gotten from another RPC command prior to now
299 [ + - ]: 1284 : pwallet->BlockUntilSyncedToCurrentChain();
300 : :
301 [ + - ]: 1284 : LOCK(pwallet->cs_wallet);
302 : :
303 : : // Wallet comments
304 : 1284 : std::optional<std::string> comment;
305 : 1284 : std::optional<std::string> comment_to;
306 [ + - + + : 1284 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
307 [ + - + - : 7 : comment = request.params[2].get_str();
+ - ]
308 [ + - + + : 1284 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
309 [ + - + - : 1 : comment_to = request.params[3].get_str();
+ - ]
310 : :
311 [ + - ]: 1284 : CCoinControl coin_control;
312 [ + - + + ]: 1284 : if (!request.params[5].isNull()) {
313 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
314 : : }
315 : :
316 [ + - + - ]: 1284 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
317 : : // We also enable partial spend avoidance if reuse avoidance is set.
318 : 1284 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
319 : :
320 [ + - + - : 1284 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
321 : :
322 [ + + ]: 1284 : EnsureWalletIsUnlocked(*pwallet);
323 : :
324 : 1281 : UniValue address_amounts(UniValue::VOBJ);
325 [ + - + - : 1281 : const std::string address = request.params[0].get_str();
- + ]
326 [ + - + - : 3843 : address_amounts.pushKV(address, request.params[1]);
+ - ]
327 : :
328 [ + - ]: 1281 : std::set<int> sffo_set;
329 [ + - + + : 1281 : if (!request.params[4].isNull() && request.params[4].get_bool()) {
+ - + - +
+ ]
330 [ + - ]: 216 : sffo_set.insert(0);
331 : : }
332 : :
333 [ + + + - ]: 1281 : std::vector<CRecipient> recipients{CreateRecipients(ParseOutputs(address_amounts), sffo_set)};
334 [ + - + + : 1279 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
335 : :
336 [ + - + - : 5125 : return SendMoney(*pwallet, coin_control, recipients, comment, comment_to, verbose);
+ + ]
337 [ + - ]: 3897 : },
338 [ + - + - : 43580 : };
+ - + - +
+ + + - -
- - ]
339 [ + - + - : 65370 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- - - - -
- - ]
340 : :
341 : 978 : RPCMethod sendmany()
342 : : {
343 : 978 : return RPCMethod{"sendmany",
344 : 978 : "Send multiple times. Amounts are double-precision floating point numbers." +
345 [ + - ]: 978 : HELP_REQUIRING_PASSPHRASE,
346 : : {
347 [ + - + - : 2934 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
+ - ]
348 [ + - ]: 1956 : RPCArgOptions{
349 : : .oneline_description = "\"\"",
350 : : .placeholder = true,
351 : : }},
352 [ + - + - ]: 1956 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
353 : : {
354 [ + - + - ]: 1956 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
355 : : },
356 : : },
357 [ + - + - ]: 1956 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value",
358 [ + - ]: 1956 : RPCArgOptions{.placeholder = true}},
359 [ + - + - ]: 1956 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
360 [ + - + - ]: 1956 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
361 : : "The fee will be equally deducted from the amount of each selected address.\n"
362 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
363 : : "If no addresses are specified here, the sender pays the fee.",
364 : : {
365 [ + - + - ]: 1956 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
366 : : },
367 : : },
368 [ + - + - : 2934 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
+ - ]
369 [ + - + - : 2934 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
370 [ + - + - ]: 1956 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
371 [ + - + - : 1956 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
372 [ + - + - : 2934 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
373 [ + - + - : 2934 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
+ - ]
374 : : },
375 : : {
376 [ + - ]: 978 : RPCResult{"if verbose is not set or set to false",
377 [ + - + - ]: 1956 : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
378 : : "the number of addresses."
379 : 978 : },
380 [ + - ]: 1956 : RPCResult{"if verbose is set to true",
381 [ + - + - ]: 1956 : RPCResult::Type::OBJ, "", "",
382 : : {
383 [ + - + - ]: 1956 : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
384 : : "the number of addresses."},
385 [ + - + - ]: 1956 : {RPCResult::Type::STR, "fee_reason", "The reason the wallet selected this fee rate (e.g. fee rate estimator, mempool minimum, fallback, or minimum required)."}
386 : : },
387 [ + - + + : 5868 : },
- - ]
388 : : },
389 : 978 : RPCExamples{
390 : : "\nSend two amounts to two different addresses:\n"
391 [ + - + - : 3912 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
392 : 978 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
393 [ + - + - : 5868 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
394 : 978 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
395 [ + - + - : 7824 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
396 : 978 : "\nAs a JSON-RPC call\n"
397 [ + - + - : 4890 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
398 [ + - ]: 978 : },
399 : 978 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
400 : : {
401 : 83 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
402 [ - + ]: 83 : if (!pwallet) return UniValue::VNULL;
403 : :
404 : : // Make sure the results are valid at least up to the most recent block
405 : : // the user could have gotten from another RPC command prior to now
406 [ + - ]: 83 : pwallet->BlockUntilSyncedToCurrentChain();
407 : :
408 [ + - ]: 83 : LOCK(pwallet->cs_wallet);
409 : :
410 [ + - + + : 83 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
411 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
412 : : }
413 [ + - + - : 83 : UniValue sendTo = request.params[1].get_obj();
+ - ]
414 : :
415 : 83 : std::optional<std::string> comment;
416 [ + - + + : 83 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
417 [ # # # # : 0 : comment = request.params[3].get_str();
# # ]
418 : :
419 [ + - ]: 83 : CCoinControl coin_control;
420 [ + - - + ]: 83 : if (!request.params[5].isNull()) {
421 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
422 : : }
423 : :
424 [ + - + - : 83 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
425 : :
426 : 60 : std::vector<CRecipient> recipients = CreateRecipients(
427 [ + - ]: 108 : ParseOutputs(sendTo),
428 [ + - + - : 60 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ + ]
429 [ + - ]: 54 : );
430 [ + - + + : 54 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
431 : :
432 [ + - + + ]: 175 : return SendMoney(*pwallet, coin_control, recipients, comment, /*comment_to=*/std::nullopt, verbose);
433 [ + - ]: 262 : },
434 [ + - + - : 24450 : };
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
435 [ + - + - : 29340 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - - -
- - - - ]
436 : :
437 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
438 : 4547 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
439 : : {
440 : 4547 : std::vector<RPCArg> args = {
441 [ + - + - : 13641 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
+ - + - ]
442 [ + - + - ]: 9094 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
443 [ + - + - : 9094 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - + - ]
444 : : {
445 [ + - + - : 13641 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
+ - ]
446 : : "Allows this transaction to be replaced by a transaction with higher fees"
447 : : },
448 [ + - + + : 22735 : };
- - ]
449 [ + - ]: 4547 : if (solving_data) {
450 [ + - + - : 77299 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
451 : : "Used for fee estimation during coin selection.",
452 : : {
453 : : {
454 [ + - + - ]: 9094 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
455 : : {
456 [ + - + - ]: 9094 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
457 : : }
458 : : },
459 : : {
460 [ + - + - ]: 9094 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
461 : : {
462 [ + - + - ]: 9094 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
463 : : }
464 : : },
465 : : {
466 [ + - + - ]: 9094 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
467 : : {
468 [ + - + - ]: 9094 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
469 : : }
470 : : },
471 : : }
472 : : });
473 : : }
474 : 4547 : return args;
475 [ + - + - : 77299 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
476 : :
477 : 742 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
478 : : {
479 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
480 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
481 : 742 : CHECK_NONFATAL(tx.vout.empty());
482 : : // Make sure the results are valid at least up to the most recent block
483 : : // the user could have gotten from another RPC command prior to now
484 : 742 : wallet.BlockUntilSyncedToCurrentChain();
485 : :
486 : 742 : std::optional<unsigned int> change_position;
487 : 742 : bool lockUnspents = false;
488 [ + + ]: 742 : if (!options.isNull()) {
489 [ + + + + : 20497 : RPCTypeCheckObj(options,
+ + ]
490 : : {
491 [ + - ]: 706 : {"add_inputs", UniValueType(UniValue::VBOOL)},
492 [ + - ]: 706 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
493 [ + - ]: 706 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
494 [ + - ]: 706 : {"changeAddress", UniValueType(UniValue::VSTR)},
495 [ + - ]: 706 : {"change_address", UniValueType(UniValue::VSTR)},
496 [ + - ]: 706 : {"changePosition", UniValueType(UniValue::VNUM)},
497 [ + - ]: 706 : {"change_position", UniValueType(UniValue::VNUM)},
498 [ + - ]: 706 : {"change_type", UniValueType(UniValue::VSTR)},
499 [ + - ]: 706 : {"includeWatching", UniValueType(UniValue::VBOOL)},
500 [ + - ]: 706 : {"include_watching", UniValueType(UniValue::VBOOL)},
501 [ + - ]: 706 : {"inputs", UniValueType(UniValue::VARR)},
502 [ + - ]: 706 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
503 [ + - ]: 706 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
504 [ + - ]: 706 : {"locktime", UniValueType(UniValue::VNUM)},
505 [ + - ]: 706 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
506 [ + - ]: 706 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
507 [ + - ]: 706 : {"psbt", UniValueType(UniValue::VBOOL)},
508 [ + - ]: 706 : {"solving_data", UniValueType(UniValue::VOBJ)},
509 [ + - ]: 706 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
510 [ + - ]: 706 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
511 [ + - ]: 706 : {"replaceable", UniValueType(UniValue::VBOOL)},
512 [ + - ]: 706 : {"conf_target", UniValueType(UniValue::VNUM)},
513 [ + - ]: 706 : {"estimate_mode", UniValueType(UniValue::VSTR)},
514 [ + - ]: 706 : {"minconf", UniValueType(UniValue::VNUM)},
515 [ + - ]: 706 : {"maxconf", UniValueType(UniValue::VNUM)},
516 [ + - ]: 706 : {"input_weights", UniValueType(UniValue::VARR)},
517 [ + - ]: 706 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
518 : : },
519 : : true, true);
520 : :
521 [ + + ]: 1366 : if (options.exists("add_inputs")) {
522 [ + - + - ]: 174 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
523 : : }
524 : :
525 [ + - + - : 2040 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
526 [ + + + - : 52 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - - +
+ + + + -
- - - ]
527 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
528 : :
529 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
530 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
531 : : }
532 : :
533 [ + - ]: 22 : coinControl.destChange = dest;
534 : 15 : }
535 : :
536 [ + - + - : 2015 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
537 [ + + + - : 183 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
538 [ + - - + : 61 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
+ + ]
539 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
540 : : }
541 : 60 : change_position = (unsigned int)pos;
542 : : }
543 : :
544 [ + + ]: 1360 : if (options.exists("change_type")) {
545 [ + - + - : 299 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
546 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
547 : : }
548 [ + - + + : 198 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
- + + - +
+ ]
549 [ - + ]: 194 : coinControl.m_change_type.emplace(parsed.value());
550 : : } else {
551 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
552 : : }
553 : : }
554 : :
555 [ + - + - : 2028 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
556 [ + + + - : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + +
+ + - - -
- ]
557 : : }
558 : :
559 [ + + ]: 1354 : if (options.exists("include_unsafe")) {
560 [ + - + - ]: 46 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
561 : : }
562 : :
563 [ + + ]: 1354 : if (options.exists("feeRate")) {
564 [ + + ]: 116 : if (options.exists("fee_rate")) {
565 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
566 : : }
567 [ + + ]: 112 : if (options.exists("conf_target")) {
568 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
569 : : }
570 [ + + ]: 108 : if (options.exists("estimate_mode")) {
571 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
572 : : }
573 [ + - + + : 104 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
- + ]
574 : 36 : coinControl.fOverrideFeeRate = true;
575 : : }
576 : :
577 [ + + ]: 1310 : if (options.exists("replaceable")) {
578 [ + - + - ]: 5 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
579 : : }
580 : :
581 [ + + ]: 1310 : if (options.exists("minconf")) {
582 [ + - + - ]: 9 : coinControl.m_min_depth = options["minconf"].getInt<int>();
583 : :
584 [ + + ]: 9 : if (coinControl.m_min_depth < 0) {
585 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
586 : : }
587 : : }
588 : :
589 [ + + ]: 1308 : if (options.exists("maxconf")) {
590 [ + - + - ]: 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
591 : :
592 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
593 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
594 : : }
595 : : }
596 [ + - + - : 1502 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + + ]
597 : : }
598 : :
599 [ + + ]: 1186 : if (options.exists("solving_data")) {
600 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
601 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
602 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
603 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
604 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
605 : : // Add witness script for pubkeys
606 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
607 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
608 : 3 : }
609 : : }
610 : :
611 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
612 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
613 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
614 [ - + + - : 6 : if (!IsHex(script_str)) {
+ + ]
615 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
616 : : }
617 [ - + + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
618 : 5 : const CScript script(script_data.begin(), script_data.end());
619 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
620 : 5 : }
621 : : }
622 : :
623 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
624 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
625 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
626 : 8 : FlatSigningProvider desc_out;
627 [ - + ]: 8 : std::string error;
628 : 8 : std::vector<CScript> scripts_temp;
629 [ - + + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
630 [ + + ]: 8 : if (descs.empty()) {
631 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
632 : : }
633 [ + + ]: 14 : for (auto& desc : descs) {
634 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
635 : : }
636 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
637 : 10 : }
638 : : }
639 : 14 : }
640 : :
641 [ + + ]: 1178 : if (options.exists("input_weights")) {
642 [ + - + - : 2647 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
643 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
644 : :
645 : 2491 : const UniValue& vout_v = input.find_value("vout");
646 [ + + ]: 2491 : if (!vout_v.isNum()) {
647 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
648 : : }
649 : 2490 : int vout = vout_v.getInt<int>();
650 [ + + ]: 2490 : if (vout < 0) {
651 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
652 : : }
653 : :
654 : 2489 : const UniValue& weight_v = input.find_value("weight");
655 [ + + ]: 2489 : if (!weight_v.isNum()) {
656 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
657 : : }
658 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
659 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
660 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
661 [ + + ]: 2488 : if (weight < min_input_weight) {
662 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
663 : : }
664 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
665 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
666 : : }
667 : :
668 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
669 : : }
670 : : }
671 : :
672 [ + + ]: 1166 : if (options.exists("max_tx_weight")) {
673 [ + - + - ]: 10 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
674 : : }
675 : :
676 [ + + ]: 583 : if (tx.version == TRUC_VERSION) {
677 [ + + - + ]: 36 : if (!coinControl.m_max_tx_weight.has_value() || coinControl.m_max_tx_weight.value() > TRUC_MAX_WEIGHT) {
678 [ - + ]: 34 : coinControl.m_max_tx_weight = TRUC_MAX_WEIGHT;
679 : : }
680 : : }
681 : :
682 [ - + ]: 583 : if (recipients.empty())
683 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
684 : :
685 [ + - ]: 583 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
686 [ + + ]: 583 : if (!txr) {
687 [ + - + - ]: 182 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
688 : : }
689 : 492 : return *txr;
690 [ + - + - : 1221 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
691 : :
692 : 500 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
693 : : {
694 [ + + ]: 1000 : if (options.exists("input_weights")) {
695 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
696 : : }
697 [ - + + + ]: 498 : if (inputs.size() == 0) {
698 : : return;
699 : : }
700 : 192 : UniValue weights(UniValue::VARR);
701 [ + - + + ]: 3003 : for (const UniValue& input : inputs.getValues()) {
702 [ + - + + ]: 5622 : if (input.exists("weight")) {
703 [ + - + - ]: 6 : weights.push_back(input);
704 : : }
705 : : }
706 [ + - + - ]: 384 : options.pushKV("input_weights", std::move(weights));
707 : 192 : }
708 : :
709 : 1140 : RPCMethod fundrawtransaction()
710 : : {
711 : 1140 : return RPCMethod{
712 : 1140 : "fundrawtransaction",
713 [ + - ]: 2280 : "If the transaction has no inputs, they will be automatically selected to meet its out value.\n"
714 : : "It will add at most one change output to the outputs.\n"
715 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
716 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
717 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
718 : : "or signrawtransactionwithwallet for that.\n"
719 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
720 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
721 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
722 : : "in the wallet using importdescriptors (to calculate fees).\n"
723 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
724 : : "Note that if specifying an exact fee rate, the resulting transaction may have a higher fee rate\n"
725 : : "if the transaction has unconfirmed inputs. This is because the wallet will attempt to make the\n"
726 : : "entire package have the given fee rate, not the resulting transaction.\n",
727 : : {
728 [ + - + - ]: 2280 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
729 [ + - + - ]: 2280 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
730 [ + - + - : 30780 : Cat<std::vector<RPCArg>>(
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
731 : : {
732 [ + - + - : 3420 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
+ - ]
733 [ + - + - : 3420 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
734 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
735 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
736 [ + - + - : 3420 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
737 [ + - + - ]: 2280 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
738 [ + - + - : 3420 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
739 [ + - + - : 3420 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
740 [ + - + - : 3420 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
741 [ + - + - : 3420 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
742 [ + - + - : 3420 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
743 [ + - + - : 3420 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
744 [ + - + - : 3420 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
+ - ]
745 [ + - + - ]: 2280 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
746 : : "The fee will be equally deducted from the amount of each specified output.\n"
747 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
748 : : "If no outputs are specified here, the sender pays the fee.",
749 : : {
750 [ + - + - ]: 2280 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
751 : : },
752 : : },
753 [ + - + - ]: 2280 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
754 : : {
755 [ + - + - ]: 2280 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
756 : : {
757 [ + - + - ]: 2280 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
758 [ + - + - ]: 2280 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
759 [ + - + - ]: 2280 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
760 : : "including the weight of the outpoint and sequence number. "
761 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
762 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
763 : : "Remember to convert serialized sizes to weight units when necessary."},
764 : : },
765 : : },
766 : : },
767 : : },
768 [ + - + - : 3420 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
769 : : "Transaction building will fail if this can not be satisfied."},
770 : : },
771 [ + - ]: 2280 : FundTxDoc()),
772 [ + - ]: 2280 : RPCArgOptions{
773 : : .oneline_description = "options",
774 : : }},
775 [ + - + - : 3420 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
+ - ]
776 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
777 : : "If true, only witness deserialization will be tried.\n"
778 : : "If false, only non-witness deserialization will be tried.\n"
779 : : "This boolean should reflect whether the transaction has inputs\n"
780 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
781 : : },
782 : : },
783 [ + - ]: 2280 : RPCResult{
784 [ + - + - ]: 2280 : RPCResult::Type::OBJ, "", "",
785 : : {
786 [ + - + - ]: 2280 : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
787 [ + - + - ]: 2280 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
788 [ + - + - ]: 2280 : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
789 : : }
790 [ + - + - : 9120 : },
+ + - - ]
791 : 1140 : RPCExamples{
792 : : "\nCreate a transaction with no inputs\n"
793 [ + - + - : 2280 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
794 : 1140 : "\nAdd sufficient unsigned inputs to meet the output value\n"
795 [ + - + - : 4560 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
796 : 1140 : "\nSign the transaction\n"
797 [ + - + - : 4560 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
798 : 1140 : "\nSend the transaction\n"
799 [ + - + - : 4560 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
800 [ + - ]: 1140 : },
801 : 1140 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
802 : : {
803 : 244 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
804 [ - + ]: 244 : if (!pwallet) return UniValue::VNULL;
805 : :
806 : : // parse hex string from parameter
807 [ + - ]: 244 : CMutableTransaction tx;
808 [ + - - + : 244 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
809 [ + - - + : 244 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
810 [ + - + - : 244 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
811 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
812 : : }
813 [ + - + - ]: 244 : UniValue options = request.params[1];
814 : 244 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
815 [ + + ]: 11711 : for (const auto& tx_out : tx.vout) {
816 : 11467 : CTxDestination dest;
817 [ + - ]: 11467 : ExtractDestination(tx_out.scriptPubKey, dest);
818 [ + - ]: 11467 : destinations.emplace_back(dest, tx_out.nValue);
819 : 11467 : }
820 [ + - + - ]: 488 : std::vector<std::string> dummy(destinations.size(), "dummy");
821 : 244 : std::vector<CRecipient> recipients = CreateRecipients(
822 : : destinations,
823 [ + - + - : 488 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
824 [ + - ]: 244 : );
825 [ + - ]: 244 : CCoinControl coin_control;
826 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
827 : 244 : coin_control.m_allow_other_inputs = true;
828 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
829 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
830 : 244 : tx.vout.clear();
831 [ + + ]: 244 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
832 : :
833 : 145 : UniValue result(UniValue::VOBJ);
834 [ + - + - : 290 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
835 [ + - + - : 290 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
836 [ + + + - : 290 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
837 : :
838 : 145 : return result;
839 [ + - ]: 1174 : },
840 [ + - + - : 7980 : };
+ + - - ]
841 [ + - + - : 55860 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- - - - -
- - - - ]
842 : :
843 : 1219 : RPCMethod signrawtransactionwithwallet()
844 : : {
845 : 1219 : return RPCMethod{
846 : 1219 : "signrawtransactionwithwallet",
847 : : "Sign inputs for raw transaction (serialized, hex-encoded).\n"
848 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
849 : 1219 : "this transaction depends on but may not yet be in the block chain." +
850 [ + - ]: 1219 : HELP_REQUIRING_PASSPHRASE,
851 : : {
852 [ + - + - ]: 2438 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
853 [ + - + - ]: 2438 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
854 : : {
855 [ + - + - ]: 2438 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
856 : : {
857 [ + - + - ]: 2438 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
858 [ + - + - ]: 2438 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
859 [ + - + - ]: 2438 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
860 [ + - + - ]: 2438 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
861 [ + - + - ]: 2438 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
862 [ + - + - ]: 2438 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
863 : : },
864 : : },
865 : : },
866 : : },
867 [ + - + - : 3657 : {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
+ - ]
868 : : " \"DEFAULT\"\n"
869 : : " \"ALL\"\n"
870 : : " \"NONE\"\n"
871 : : " \"SINGLE\"\n"
872 : : " \"ALL|ANYONECANPAY\"\n"
873 : : " \"NONE|ANYONECANPAY\"\n"
874 : : " \"SINGLE|ANYONECANPAY\""},
875 : : },
876 [ + - ]: 2438 : RPCResult{
877 [ + - + - ]: 2438 : RPCResult::Type::OBJ, "", "",
878 : : {
879 [ + - + - ]: 2438 : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
880 [ + - + - ]: 2438 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
881 [ + - + - ]: 2438 : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
882 : : {
883 [ + - + - ]: 2438 : {RPCResult::Type::OBJ, "", "",
884 : : {
885 [ + - + - ]: 2438 : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
886 [ + - + - ]: 2438 : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
887 [ + - + - ]: 2438 : {RPCResult::Type::ARR, "witness", "",
888 : : {
889 [ + - + - ]: 2438 : {RPCResult::Type::STR_HEX, "witness", ""},
890 : : }},
891 [ + - + - ]: 2438 : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
892 [ + - + - ]: 2438 : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
893 [ + - + - ]: 2438 : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
894 : : }},
895 : : }},
896 : : }
897 [ + - + - : 32913 : },
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
898 : 1219 : RPCExamples{
899 [ + - + - : 2438 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
900 [ + - + - : 4876 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
901 [ + - ]: 1219 : },
902 : 1219 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
903 : : {
904 [ - + ]: 324 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
905 [ - + ]: 324 : if (!pwallet) return UniValue::VNULL;
906 : :
907 [ + - ]: 324 : CMutableTransaction mtx;
908 [ + - + - : 324 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
909 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
910 : : }
911 : :
912 : : // Sign the transaction
913 [ + - ]: 324 : LOCK(pwallet->cs_wallet);
914 [ + + ]: 324 : EnsureWalletIsUnlocked(*pwallet);
915 : :
916 : : // Fetch previous transactions (inputs):
917 : 323 : std::map<COutPoint, Coin> coins;
918 [ + + ]: 732 : for (const CTxIn& txin : mtx.vin) {
919 [ + - ]: 409 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
920 : : }
921 [ + - ]: 323 : pwallet->chain().findCoins(coins);
922 : :
923 : : // Parse the prevtxs array
924 [ + - + + ]: 323 : ParsePrevouts(request.params[1], nullptr, coins);
925 : :
926 [ + - + + ]: 314 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
927 [ + + ]: 313 : if (!nHashType) {
928 : 304 : nHashType = SIGHASH_DEFAULT;
929 : : }
930 : :
931 : : // Script verification errors
932 [ + - ]: 313 : std::map<int, bilingual_str> input_errors;
933 : :
934 [ + - ]: 313 : bool complete = pwallet->SignTransaction(mtx, coins, *nHashType, input_errors);
935 : 313 : UniValue result(UniValue::VOBJ);
936 [ + + ]: 313 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
937 : 311 : return result;
938 [ + - ]: 1286 : },
939 [ + - + - : 21942 : };
+ - + - +
+ + + + +
- - - - -
- ]
940 [ + - + - : 51198 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - - -
- - - - -
- ]
941 : :
942 : : // Definition of allowed formats of specifying transaction outputs in
943 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
944 : 4263 : static std::vector<RPCArg> OutputsDoc()
945 : : {
946 : 4263 : return
947 : : {
948 [ + - + - ]: 8526 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
949 : : {
950 [ + - ]: 8526 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
951 [ + - ]: 8526 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
952 : : },
953 : : },
954 [ + - + - ]: 8526 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
955 : : {
956 [ + - + - ]: 8526 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data that becomes a part of an OP_RETURN output"},
957 : : },
958 : : },
959 [ + - + - : 46893 : };
+ - + + +
+ + + - -
- - - - ]
960 [ + - + - : 34104 : }
+ - + - -
- ]
961 : :
962 : 1967 : static RPCMethod bumpfee_helper(std::string method_name)
963 : : {
964 : 1967 : const bool want_psbt = method_name == "psbtbumpfee";
965 : 1967 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeRateFormat::SAT_VB)};
966 : :
967 [ - + ]: 1967 : return RPCMethod{method_name,
968 : : "Bumps the fee of a transaction T, replacing it with a new transaction B.\n"
969 [ + - + - ]: 3934 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
970 : : "A transaction with the given txid must be in the wallet.\n"
971 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
972 : : "It may add a new change output if one does not already exist.\n"
973 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
974 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
975 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
976 : : "The user can specify a confirmation target for estimatesmartfee.\n"
977 [ + - ]: 3934 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
978 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
979 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
980 [ + - + - ]: 5901 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
981 : : {
982 [ + - + - ]: 3934 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
983 [ + - + - ]: 3934 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
984 [ + - + - : 15736 : Cat(
+ + - - ]
985 : : {
986 [ + - + - : 5901 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
+ - ]
987 [ + - + - ]: 3934 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
988 [ + - ]: 3934 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
989 [ + - ]: 3934 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
990 [ + - + - ]: 5901 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
991 [ + - + - ]: 3934 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true},
992 [ + - ]: 3934 : "Whether the new transaction should be\n"
993 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
994 : : "be set to 0xfffffffd. If false, any input sequence numbers in the\n"
995 : : "transaction will be set to 0xfffffffe\n"
996 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
997 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
998 : : "are replaceable).\n"},
999 [ + - + - ]: 3934 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1000 [ + - + - : 3934 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1001 [ + - + - ]: 3934 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1002 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1003 : : "At least one output of either type must be specified.\n"
1004 : : "Cannot be provided if 'original_change_index' is specified.",
1005 [ + - ]: 3934 : OutputsDoc(),
1006 [ + - ]: 3934 : RPCArgOptions{.skip_type_check = true}},
1007 [ + - + - : 5901 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
+ - ]
1008 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1009 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1010 : : "original change output. The change output’s amount can increase if bumping the transaction "
1011 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1012 : : },
1013 [ + + + - : 10426 : want_psbt ? std::vector<RPCArg>{{"psbt_version", RPCArg::Type::NUM, RPCArg::Default(2), "The PSBT version number to use."}} : std::vector<RPCArg>()
+ - + - +
- + + + +
+ + + + +
+ + + - -
- - - - -
- - - -
- ]
1014 : : ),
1015 [ + - ]: 3934 : RPCArgOptions{.oneline_description="options"}},
1016 : : },
1017 [ + - ]: 3934 : RPCResult{
1018 [ + - + - : 27538 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + + + +
- - - - ]
1019 [ + + + - : 9835 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1020 [ + - + - : 5587 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ + + + +
+ - - - -
- - ]
1021 [ + - + - : 6215 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ + + + +
+ - - - -
- - ]
1022 : : {
1023 [ + - + - ]: 3934 : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1024 [ + - + - ]: 3934 : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1025 [ + - + - ]: 3934 : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1026 : : {
1027 [ + - + - ]: 3934 : {RPCResult::Type::STR, "", ""},
1028 : : }},
1029 : : })
1030 [ + - ]: 3934 : },
1031 : 1967 : RPCExamples{
1032 [ + + + - : 4996 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1033 [ + - + - : 5901 : HelpExampleCli(method_name, "<txid>")
+ - ]
1034 : 1967 : },
1035 [ + - ]: 3934 : [want_psbt](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1036 : : {
1037 : 177 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1038 [ - + ]: 177 : if (!pwallet) return UniValue::VNULL;
1039 : :
1040 [ + - + + : 177 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1041 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1042 : : }
1043 : :
1044 [ + - + - ]: 176 : Txid hash{Txid::FromUint256(ParseHashV(request.params[0], "txid"))};
1045 : :
1046 [ + - ]: 176 : CCoinControl coin_control;
1047 : : // optional parameters
1048 : 176 : coin_control.m_signal_bip125_rbf = true;
1049 : 176 : std::vector<CTxOut> outputs;
1050 : :
1051 : 176 : std::optional<uint32_t> original_change_index;
1052 : :
1053 : 176 : uint32_t psbt_version = 2;
1054 : :
1055 [ + - + + ]: 176 : if (!request.params[1].isNull()) {
1056 [ + - + - ]: 85 : UniValue options = request.params[1];
1057 [ + + + + : 854 : RPCTypeCheckObj(options,
+ + ]
1058 : : {
1059 [ + - ]: 85 : {"confTarget", UniValueType(UniValue::VNUM)},
1060 [ + - ]: 85 : {"conf_target", UniValueType(UniValue::VNUM)},
1061 [ + - ]: 85 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1062 [ + - ]: 85 : {"replaceable", UniValueType(UniValue::VBOOL)},
1063 [ + - ]: 85 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1064 [ + - ]: 85 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1065 [ + - ]: 85 : {"original_change_index", UniValueType(UniValue::VNUM)},
1066 [ + - ]: 85 : {"psbt_version", UniValueType(UniValue::VNUM)},
1067 : : },
1068 : : true, true);
1069 : :
1070 [ + - + - : 163 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1071 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1072 : : }
1073 : :
1074 [ + - - + : 240 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1075 : :
1076 [ + - + + ]: 160 : if (options.exists("replaceable")) {
1077 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1078 : : }
1079 [ + - + - : 179 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1080 : :
1081 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1082 [ + - + - : 61 : if (!options["outputs"].isNull()) {
+ + ]
1083 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- - + + +
+ + - - ]
1084 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1085 : : }
1086 [ + - ]: 10 : CMutableTransaction tempTx;
1087 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1088 [ + - ]: 8 : outputs = tempTx.vout;
1089 : 10 : }
1090 : :
1091 [ + - + + ]: 116 : if (options.exists("original_change_index")) {
1092 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1093 : : }
1094 : :
1095 [ + - + + ]: 114 : if (options.exists("psbt_version")) {
1096 [ + - + - : 3 : psbt_version = options["psbt_version"].getInt<uint32_t>();
+ - ]
1097 : : }
1098 [ + + ]: 57 : if (psbt_version != 2 && psbt_version != 0) {
1099 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "The PSBT version can only be 2 or 0");
1100 : : }
1101 : 109 : }
1102 : :
1103 : : // Make sure the results are valid at least up to the most recent block
1104 : : // the user could have gotten from another RPC command prior to now
1105 [ + - ]: 147 : pwallet->BlockUntilSyncedToCurrentChain();
1106 : :
1107 [ + - ]: 147 : LOCK(pwallet->cs_wallet);
1108 : :
1109 [ + + ]: 147 : EnsureWalletIsUnlocked(*pwallet);
1110 : :
1111 : :
1112 : 146 : std::vector<bilingual_str> errors;
1113 : 146 : CAmount old_fee;
1114 : 146 : CAmount new_fee;
1115 [ + - ]: 146 : CMutableTransaction mtx;
1116 : : // Targeting feerate bump.
1117 : 292 : [&](){
1118 [ - - + + : 146 : switch (feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index)) {
+ - + ]
1119 : 113 : case feebumper::Result::OK:
1120 : 113 : return;
1121 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1122 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1123 : 0 : case feebumper::Result::INVALID_REQUEST:
1124 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1125 : 16 : case feebumper::Result::INVALID_PARAMETER:
1126 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1127 : 16 : case feebumper::Result::WALLET_ERROR:
1128 [ + - ]: 16 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1129 : 1 : case feebumper::Result::MISC_ERROR:
1130 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1131 : : } // no default case, so the compiler can warn about missing cases
1132 [ # # ]: 0 : NONFATAL_UNREACHABLE();
1133 [ + + ]: 146 : }();
1134 : :
1135 : 113 : UniValue result(UniValue::VOBJ);
1136 : :
1137 : : // For bumpfee, return the new transaction id.
1138 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1139 [ + + ]: 113 : if (!want_psbt) {
1140 [ + - - + ]: 104 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1141 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1142 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1143 : : }
1144 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1145 : : }
1146 : :
1147 [ + - ]: 104 : Txid txid;
1148 [ + - - + ]: 104 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1149 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1150 : : }
1151 : :
1152 [ + - + - : 208 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1153 : : } else {
1154 [ + - ]: 9 : PartiallySignedTransaction psbtx(mtx, psbt_version);
1155 : 9 : bool complete = false;
1156 [ + - ]: 9 : const auto err{pwallet->FillPSBT(psbtx, {.sign = false, .bip32_derivs = true}, complete)};
1157 [ + - ]: 9 : CHECK_NONFATAL(!err);
1158 [ + - ]: 9 : CHECK_NONFATAL(!complete);
1159 : 9 : DataStream ssTx{};
1160 [ + - ]: 9 : ssTx << psbtx;
1161 [ + - + - : 27 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1162 : 9 : }
1163 : :
1164 [ + - + - : 226 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1165 [ + - + - : 226 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1166 : 113 : UniValue result_errors(UniValue::VARR);
1167 [ - + ]: 113 : for (const bilingual_str& error : errors) {
1168 [ # # # # ]: 0 : result_errors.push_back(error.original);
1169 : : }
1170 [ + - + - ]: 226 : result.pushKV("errors", std::move(result_errors));
1171 : :
1172 : 113 : return result;
1173 [ + - + - : 700 : },
+ - + - +
- + - + -
+ - + - +
- - + ]
1174 [ + + + - : 13769 : };
+ - + + -
- ]
1175 [ + - + - : 56886 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - - -
- - - - ]
1176 : :
1177 [ + - ]: 2124 : RPCMethod bumpfee() { return bumpfee_helper("bumpfee"); }
1178 [ + - ]: 1810 : RPCMethod psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1179 : :
1180 : 1165 : RPCMethod send()
1181 : : {
1182 : 1165 : return RPCMethod{
1183 : 1165 : "send",
1184 [ + - ]: 2330 : "Send a transaction.\n",
1185 : : {
1186 [ + - + - ]: 2330 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1187 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1188 : : "At least one output of either type must be specified.\n"
1189 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1190 [ + - ]: 2330 : OutputsDoc(),
1191 [ + - ]: 2330 : RPCArgOptions{.skip_type_check = true}},
1192 [ + - + - : 3495 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
1193 [ + - + - ]: 2330 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1194 [ + - + - : 2330 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1195 [ + - + - : 3495 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1196 [ + - + - ]: 2330 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1197 [ + - + - : 34950 : Cat<std::vector<RPCArg>>(
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
1198 : : {
1199 [ + - + - : 3495 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
+ - ]
1200 [ + - + - : 3495 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
1201 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1202 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1203 [ + - + - : 3495 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
1204 [ + - + - ]: 2330 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1205 [ + - + - : 3495 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
+ - ]
1206 [ + - + - : 3495 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
1207 [ + - + - : 3495 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
1208 [ + - + - : 3495 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
1209 [ + - + - : 4660 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - + - ]
1210 [ + - + - : 3495 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1211 [ + - + - ]: 2330 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
1212 : : {
1213 [ + - + - ]: 2330 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
1214 [ + - + - ]: 2330 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1215 [ + - + - ]: 2330 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1216 [ + - + - : 3495 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
+ - ]
1217 [ + - + - : 3495 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
+ - ]
1218 : : "including the weight of the outpoint and sequence number. "
1219 : : "Note that signature sizes are not guaranteed to be consistent, "
1220 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1221 : : "Remember to convert serialized sizes to weight units when necessary."},
1222 : : }},
1223 : : },
1224 : : },
1225 [ + - + - : 3495 : {"locktime", RPCArg::Type::NUM, RPCArg::DefaultHint{"locktime close to block height to prevent fee sniping"}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1226 [ + - + - : 3495 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1227 [ + - + - : 3495 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
+ - ]
1228 [ + - + - ]: 2330 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1229 : : "The fee will be equally deducted from the amount of each specified output.\n"
1230 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1231 : : "If no outputs are specified here, the sender pays the fee.",
1232 : : {
1233 [ + - + - ]: 2330 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1234 : : },
1235 : : },
1236 [ + - + - : 3495 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
1237 : : "Transaction building will fail if this can not be satisfied."},
1238 : : },
1239 [ + - ]: 2330 : FundTxDoc()),
1240 [ + - ]: 2330 : RPCArgOptions{.oneline_description="options"}},
1241 [ + - + - : 3495 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1242 : : },
1243 [ + - ]: 2330 : RPCResult{
1244 [ + - + - ]: 2330 : RPCResult::Type::OBJ, "", "",
1245 : : {
1246 [ + - + - ]: 2330 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1247 [ + - + - ]: 2330 : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1248 [ + - + - ]: 2330 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1249 [ + - + - ]: 2330 : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1250 : : }
1251 [ + - + - : 11650 : },
+ + - - ]
1252 : 1165 : RPCExamples{""
1253 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1254 [ + - + - : 3495 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1255 [ + - ]: 2330 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1256 [ + - + - : 5825 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1257 [ + - ]: 2330 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1258 [ + - + - : 5825 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1259 [ + - ]: 2330 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1260 [ + - + - : 5825 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1261 : 1165 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1262 [ + - + - : 5825 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical null '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1263 [ + - ]: 1165 : },
1264 : 1165 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1265 : : {
1266 : 270 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1267 [ - + ]: 270 : if (!pwallet) return UniValue::VNULL;
1268 : :
1269 [ + - + + : 270 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1270 [ + - + - : 270 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1271 [ + + ]: 266 : PreventOutdatedOptions(options);
1272 : :
1273 : :
1274 [ + - - + : 530 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1275 : 265 : UniValue outputs(UniValue::VOBJ);
1276 [ + - + - ]: 265 : outputs = NormalizeOutputs(request.params[0]);
1277 : 265 : std::vector<CRecipient> recipients = CreateRecipients(
1278 [ + + ]: 529 : ParseOutputs(outputs),
1279 [ + - + - : 531 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1280 [ + - ]: 264 : );
1281 [ + - ]: 264 : CCoinControl coin_control;
1282 [ + - ]: 264 : coin_control.m_version = self.Arg<uint32_t>("version");
1283 [ + - + - : 528 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf, coin_control.m_version);
+ - + - +
- + - ]
1284 : : // Automatically select coins, unless at least one is manually selected. Can
1285 : : // be overridden by options.add_inputs.
1286 [ - + ]: 264 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1287 [ + - - + ]: 528 : if (options.exists("max_tx_weight")) {
1288 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1289 : : }
1290 : :
1291 [ + - + - : 265 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1292 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1293 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1294 : 263 : rawTx.vout.clear();
1295 [ + + ]: 263 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1296 : :
1297 [ + - ]: 180 : CMutableTransaction tx = CMutableTransaction(*txr.tx);
1298 [ + - + + ]: 540 : return FinishTransaction(pwallet, options, tx);
1299 [ + - ]: 1065 : }
1300 [ + - + - : 11650 : };
+ + - - ]
1301 [ + - + - : 71065 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
1302 : :
1303 : 1111 : RPCMethod sendall()
1304 : : {
1305 : 1111 : return RPCMethod{"sendall",
1306 [ + - ]: 2222 : "Spend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1307 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1308 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1309 : : {
1310 [ + - + - ]: 2222 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1311 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1312 : : {
1313 [ + - + - ]: 2222 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1314 [ + - + - ]: 2222 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1315 : : {
1316 [ + - + - ]: 2222 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1317 : : },
1318 : : },
1319 : : },
1320 : : },
1321 [ + - + - : 3333 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
+ - ]
1322 [ + - + - ]: 2222 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1323 [ + - + - : 2222 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
+ - ]
1324 [ + - + - : 3333 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1325 : : {
1326 [ + - + - ]: 2222 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1327 [ + - + - : 23331 : Cat<std::vector<RPCArg>>(
+ - + - +
+ + + + +
- - - - -
- ]
1328 : : {
1329 [ + - + - : 3333 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
+ - ]
1330 [ + - + - : 4444 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - + - ]
1331 [ + - + - : 3333 : {"include_watching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1332 [ + - + - ]: 2222 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1333 : : {
1334 [ + - + - ]: 2222 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1335 : : {
1336 [ + - + - ]: 2222 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1337 [ + - + - ]: 2222 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1338 [ + - + - : 3333 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
+ - ]
1339 : : },
1340 : : },
1341 : : },
1342 : : },
1343 [ + - + - : 3333 : {"locktime", RPCArg::Type::NUM, RPCArg::DefaultHint{"locktime close to block height to prevent fee sniping"}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1344 [ + - + - : 3333 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1345 [ + - + - : 3333 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
+ - ]
1346 [ + - + - : 3333 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
+ - ]
1347 [ + - + - : 3333 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
+ - ]
1348 [ + - + - ]: 2222 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1349 [ + - + - : 3333 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1350 : : },
1351 [ + - ]: 2222 : FundTxDoc()
1352 : : ),
1353 [ + - ]: 2222 : RPCArgOptions{.oneline_description="options"}
1354 : : },
1355 : : },
1356 [ + - ]: 2222 : RPCResult{
1357 [ + - + - ]: 2222 : RPCResult::Type::OBJ, "", "",
1358 : : {
1359 [ + - + - ]: 2222 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1360 [ + - + - ]: 2222 : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1361 [ + - + - ]: 2222 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1362 [ + - + - ]: 2222 : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1363 : : }
1364 [ + - + - : 11110 : },
+ + - - ]
1365 : 1111 : RPCExamples{""
1366 [ + - ]: 2222 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1367 [ + - + - : 5555 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1368 [ + - ]: 2222 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1369 [ + - + - : 5555 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1370 [ + - ]: 2222 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1371 [ + - + - : 6666 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1372 [ + - ]: 2222 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1373 [ + - + - : 5555 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1374 [ + - + - ]: 3333 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1375 [ + - + - : 6666 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1376 [ + - ]: 1111 : },
1377 : 1111 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1378 : : {
1379 : 216 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1380 [ - + ]: 216 : if (!pwallet) return UniValue::VNULL;
1381 : : // Make sure the results are valid at least up to the most recent block
1382 : : // the user could have gotten from another RPC command prior to now
1383 [ + - ]: 216 : pwallet->BlockUntilSyncedToCurrentChain();
1384 : :
1385 [ + - + + : 216 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1386 [ + - + - : 216 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1387 [ + - ]: 216 : PreventOutdatedOptions(options);
1388 : :
1389 : :
1390 : 216 : std::set<CTxDestination> addresses_without_amount;
1391 : 216 : UniValue recipient_key_value_pairs(UniValue::VARR);
1392 [ + - ]: 216 : const UniValue& recipients{request.params[0]};
1393 [ - + + + ]: 1141 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1394 [ + - ]: 925 : const UniValue& recipient{recipients[i]};
1395 [ + + ]: 925 : if (recipient.isStr()) {
1396 : 916 : UniValue rkvp(UniValue::VOBJ);
1397 [ + - + - : 2748 : rkvp.pushKV(recipient.get_str(), 0);
- + + - ]
1398 [ + - ]: 916 : recipient_key_value_pairs.push_back(std::move(rkvp));
1399 : : // Store the decoded destination, so it matches the outputs below
1400 : : // also when the address was given in another case (e.g. uppercase bech32)
1401 [ + - + - : 916 : addresses_without_amount.insert(DecodeDestination(recipient.get_str()));
+ - ]
1402 : 916 : } else {
1403 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1404 : : }
1405 : : }
1406 : :
1407 [ + + ]: 216 : if (addresses_without_amount.size() == 0) {
1408 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1409 : : }
1410 : :
1411 [ + - ]: 214 : CCoinControl coin_control;
1412 : :
1413 [ + - + - : 428 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1414 : :
1415 [ + - + + ]: 428 : if (options.exists("minconf")) {
1416 [ + - + - : 7 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1417 : : {
1418 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1419 : : }
1420 : :
1421 [ + - + - : 6 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1422 : : }
1423 : :
1424 [ + - + + ]: 426 : if (options.exists("maxconf")) {
1425 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1426 : :
1427 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1428 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1429 : : }
1430 : : }
1431 : :
1432 [ + - + + ]: 426 : if (options.exists("version")) {
1433 [ + - + - : 9 : coin_control.m_version = options["version"].getInt<decltype(coin_control.m_version)>();
+ - ]
1434 : : }
1435 : :
1436 [ + + ]: 213 : if (coin_control.m_version == TRUC_VERSION) {
1437 [ - + ]: 7 : coin_control.m_max_tx_weight = TRUC_MAX_WEIGHT;
1438 : : } else {
1439 : 206 : coin_control.m_max_tx_weight = MAX_STANDARD_TX_WEIGHT;
1440 : : }
1441 : :
1442 [ + - + + : 426 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1443 : :
1444 [ + - ]: 213 : auto [fee_rate, fee_reason, returned_target] = GetMinimumFeeRate(*pwallet, coin_control);
1445 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1446 : : // provided one
1447 [ + + + + ]: 213 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1448 : 1 : const auto feerate_format = FeeRateFormat::SAT_VB;
1449 : 1 : auto msg{strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s).",
1450 [ + - ]: 2 : coin_control.m_feerate->ToString(feerate_format),
1451 [ + - + - ]: 2 : fee_rate.ToString(feerate_format))};
1452 [ + - ]: 1 : if (fee_reason == FeeReason::REQUIRED) {
1453 [ + - ]: 3 : msg += strprintf("\nConsider modifying -mintxfee (%s) or -minrelaytxfee (%s).",
1454 [ + - ]: 2 : pwallet->m_min_fee.ToString(feerate_format),
1455 [ + - + - ]: 3 : pwallet->chain().relayMinFee().ToString(feerate_format));
1456 : : }
1457 [ + - ]: 1 : throw JSONRPCError(RPC_INVALID_PARAMETER, msg);
1458 : 1 : }
1459 [ + + + - ]: 212 : if (fee_reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1460 : : // eventually allow a fallback fee
1461 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1462 : : }
1463 : :
1464 [ + - + - : 425 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf, coin_control.m_version)};
+ - + - +
+ ]
1465 [ + - ]: 211 : LOCK(pwallet->cs_wallet);
1466 : :
1467 : 211 : CAmount total_input_value(0);
1468 [ + - + + : 424 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1469 [ + - + - : 451 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1470 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1471 [ + - + - : 475 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1472 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1473 [ + - + + ]: 418 : } else if (options.exists("inputs")) {
1474 [ + + ]: 51 : for (const CTxIn& input : rawTx.vin) {
1475 [ + - + + ]: 28 : if (pwallet->IsSpent(input.prevout)) {
1476 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1477 : : }
1478 [ + - ]: 26 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1479 [ + + + - : 75 : if (!tx || input.prevout.n >= tx->GetTx()->vout.size() || !pwallet->IsMine(tx->GetTx()->vout[input.prevout.n])) {
- + + + +
- + - + -
+ + + + -
- - - ]
1480 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1481 : : }
1482 [ + - + + ]: 24 : if (pwallet->GetTxDepthInMainChain(*tx) == 0) {
1483 [ + - - + : 32 : if (tx->GetTx()->version == TRUC_VERSION && coin_control.m_version != TRUC_VERSION) {
- - - + ]
1484 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Can't spend unconfirmed version 3 pre-selected input with a version %d tx", coin_control.m_version));
1485 [ - + - - : 16 : } else if (coin_control.m_version == TRUC_VERSION && tx->GetTx()->version != TRUC_VERSION) {
- - - + ]
1486 [ # # # # : 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Can't spend unconfirmed version %d pre-selected input with a version 3 tx", tx->GetTx()->version));
# # # # ]
1487 : : }
1488 : : }
1489 [ + - + - ]: 48 : total_input_value += tx->GetTx()->vout[input.prevout.n].nValue;
1490 : : }
1491 : : } else {
1492 : 182 : CoinFilterParams coins_params;
1493 : 182 : coins_params.min_amount = 0;
1494 [ + - + - : 3027 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1495 [ + + + - : 2845 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1496 : 2 : continue;
1497 : : }
1498 : : // we are spending an unconfirmed TRUC transaction, so lower max weight
1499 [ + + + + ]: 2843 : if (output.depth == 0 && coin_control.m_version == TRUC_VERSION) {
1500 [ + - ]: 4 : coin_control.m_max_tx_weight = TRUC_CHILD_MAX_WEIGHT;
1501 : : }
1502 [ + + + - ]: 2846 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::MAX_SEQUENCE_NONFINAL);
1503 [ + - ]: 2843 : rawTx.vin.push_back(input);
1504 : 2843 : total_input_value += output.txout.nValue;
1505 : 3025 : }
1506 : : }
1507 : :
1508 : 205 : std::vector<COutPoint> outpoints_spent;
1509 [ - + + - ]: 205 : outpoints_spent.reserve(rawTx.vin.size());
1510 : :
1511 [ + + ]: 3072 : for (const CTxIn& tx_in : rawTx.vin) {
1512 [ + - ]: 2867 : outpoints_spent.push_back(tx_in.prevout);
1513 : : }
1514 : :
1515 : : // estimate final size of tx
1516 [ + - + - ]: 205 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1517 [ + + ]: 205 : if (tx_size.vsize == -1) {
1518 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, "Unable to determine the size of the transaction, the wallet contains unsolvable descriptors");
1519 : : }
1520 [ + - ]: 203 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1521 [ + - ]: 203 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1522 [ + - ]: 203 : const CAmount actual_fee{fee_from_size + total_bump_fees.value_or(0)};
1523 : 203 : CAmount effective_value = total_input_value - actual_fee;
1524 : :
1525 [ + + ]: 203 : if (actual_fee > pwallet->m_max_tx_fee) {
1526 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1527 : : }
1528 [ + - + + ]: 201 : if (actual_fee > pwallet->m_max_tx_fee_rate.GetFee(tx_size.vsize)) {
1529 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_RATE_EXCEEDED).original);
1530 : : }
1531 : :
1532 [ + + ]: 200 : if (effective_value <= 0) {
1533 [ - + ]: 33 : if (send_max) {
1534 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1535 : : } else {
1536 [ + - + - ]: 66 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1537 : : }
1538 : : }
1539 : :
1540 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1541 [ + - ]: 167 : if (tx_size.weight > coin_control.m_max_tx_weight) {
1542 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1543 : : }
1544 : :
1545 : 164 : CAmount output_amounts_claimed{0};
1546 [ + + ]: 689 : for (const CTxOut& out : rawTx.vout) {
1547 : 525 : output_amounts_claimed += out.nValue;
1548 : : }
1549 : :
1550 [ + + ]: 164 : if (output_amounts_claimed > total_input_value) {
1551 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1552 : : }
1553 : :
1554 : 163 : const CAmount remainder{effective_value - output_amounts_claimed};
1555 [ + + ]: 163 : if (remainder < 0) {
1556 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1557 : : }
1558 : :
1559 : 162 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1560 : :
1561 : 162 : bool gave_remaining_to_first{false};
1562 [ + + ]: 679 : for (CTxOut& out : rawTx.vout) {
1563 : 520 : CTxDestination dest;
1564 [ + - ]: 520 : ExtractDestination(out.scriptPubKey, dest);
1565 [ + + ]: 520 : if (addresses_without_amount.contains(dest)) {
1566 : 514 : out.nValue = per_output_without_amount;
1567 [ + + ]: 514 : if (!gave_remaining_to_first) {
1568 : 161 : out.nValue += remainder % addresses_without_amount.size();
1569 : 161 : gave_remaining_to_first = true;
1570 : : }
1571 [ + - + - : 514 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1572 : : // Dynamically generated output amount is dust
1573 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1574 : : }
1575 : : } else {
1576 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1577 : : // Specified output amount is dust
1578 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", EncodeDestination(dest)));
+ - ]
1579 : : }
1580 : : }
1581 : 520 : }
1582 : :
1583 [ + - + + : 320 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1584 [ + + ]: 159 : if (lock_unspents) {
1585 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1586 [ + - ]: 2 : pwallet->LockCoin(txin.prevout, /*persist=*/false);
1587 : : }
1588 : : }
1589 : :
1590 [ + - + - ]: 477 : return FinishTransaction(pwallet, options, rawTx);
1591 [ + - ]: 903 : }
1592 [ + - + - : 17776 : };
+ - + - +
+ + + + +
- - - - -
- ]
1593 [ + - + - : 57772 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - -
- ]
1594 : :
1595 : 1536 : RPCMethod walletprocesspsbt()
1596 : : {
1597 : 1536 : return RPCMethod{
1598 : 1536 : "walletprocesspsbt",
1599 : : "Update a PSBT with input information from our wallet and then sign inputs\n"
1600 : 1536 : "that we can sign for." +
1601 [ + - ]: 1536 : HELP_REQUIRING_PASSPHRASE,
1602 : : {
1603 [ + - + - ]: 3072 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1604 [ + - + - : 4608 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
+ - ]
1605 [ + - + - : 4608 : {"sighashtype", RPCArg::Type::STR, RPCArg::DefaultHint{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
+ - ]
1606 : : " \"DEFAULT\"\n"
1607 : : " \"ALL\"\n"
1608 : : " \"NONE\"\n"
1609 : : " \"SINGLE\"\n"
1610 : : " \"ALL|ANYONECANPAY\"\n"
1611 : : " \"NONE|ANYONECANPAY\"\n"
1612 : : " \"SINGLE|ANYONECANPAY\""},
1613 [ + - + - : 4608 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
+ - ]
1614 [ + - + - : 4608 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
+ - ]
1615 : : },
1616 [ + - ]: 3072 : RPCResult{
1617 [ + - + - ]: 3072 : RPCResult::Type::OBJ, "", "",
1618 : : {
1619 [ + - + - ]: 3072 : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1620 [ + - + - ]: 3072 : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1621 [ + - + - ]: 3072 : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1622 : : }
1623 [ + - + - : 12288 : },
+ + - - ]
1624 : 1536 : RPCExamples{
1625 [ + - + - : 3072 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1626 [ + - ]: 1536 : },
1627 : 1536 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1628 : : {
1629 [ - + ]: 641 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1630 [ - + ]: 641 : if (!pwallet) return UniValue::VNULL;
1631 : :
1632 [ + - ]: 641 : const CWallet& wallet{*pwallet};
1633 : : // Make sure the results are valid at least up to the most recent block
1634 : : // the user could have gotten from another RPC command prior to now
1635 [ + - ]: 641 : wallet.BlockUntilSyncedToCurrentChain();
1636 : :
1637 : : // Unserialize the transaction
1638 [ + - + - : 641 : util::Result<PartiallySignedTransaction> psbt_res = DecodeBase64PSBT(request.params[0].get_str());
+ - ]
1639 [ + + ]: 641 : if (!psbt_res) {
1640 [ + - + - : 6 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", util::ErrorString(psbt_res).original));
+ - ]
1641 : : }
1642 [ + - ]: 639 : PartiallySignedTransaction psbtx = *psbt_res;
1643 : :
1644 : : // Get the sighash type
1645 [ + - + + ]: 639 : std::optional<int> nHashType = ParseSighashString(request.params[2]);
1646 : :
1647 : : // Fill transaction with our data and also sign
1648 [ + - + + : 638 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1649 [ + - + + : 638 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1650 [ + - + + : 638 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1651 : 638 : bool complete = true;
1652 : :
1653 [ + + + + ]: 638 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1654 : :
1655 [ + - ]: 637 : const auto err{wallet.FillPSBT(psbtx, {.sign = sign, .sighash_type = nHashType, .finalize = finalize, .bip32_derivs = bip32derivs}, complete)};
1656 [ + + ]: 637 : if (err) {
1657 [ + - ]: 7 : throw JSONRPCPSBTError(*err);
1658 : : }
1659 : :
1660 : 630 : UniValue result(UniValue::VOBJ);
1661 : 630 : DataStream ssTx{};
1662 [ + - ]: 630 : ssTx << psbtx;
1663 [ + - + - : 1890 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1664 [ + - + - : 1260 : result.pushKV("complete", complete);
+ - ]
1665 [ + + ]: 630 : if (complete) {
1666 [ + - ]: 42 : CMutableTransaction mtx;
1667 : : // Returns true if complete, which we already think it is.
1668 [ + - + - ]: 42 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1669 : 42 : DataStream ssTx_final;
1670 [ + - ]: 42 : ssTx_final << TX_WITH_WITNESS(mtx);
1671 [ - + + - : 84 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - +
- ]
1672 : 84 : }
1673 : :
1674 : 630 : return result;
1675 : 1280 : },
1676 [ + - + - : 13824 : };
+ + - - ]
1677 [ + - + - : 24576 : }
+ - + - +
- + - + -
+ - - - -
- ]
1678 : :
1679 : 1131 : RPCMethod walletcreatefundedpsbt()
1680 : : {
1681 : 1131 : return RPCMethod{
1682 : 1131 : "walletcreatefundedpsbt",
1683 [ + - ]: 2262 : "Creates and funds a transaction in the Partially Signed Transaction format.\n"
1684 : : "Implements the Creator and Updater roles.\n"
1685 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1686 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1687 : : {
1688 [ + - + - ]: 2262 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1689 : : {
1690 [ + - + - ]: 2262 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1691 : : {
1692 [ + - + - ]: 2262 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1693 [ + - + - ]: 2262 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1694 [ + - + - : 3393 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
+ - ]
1695 [ + - + - : 3393 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
+ - ]
1696 : : "including the weight of the outpoint and sequence number. "
1697 : : "Note that signature sizes are not guaranteed to be consistent, "
1698 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1699 : : "Remember to convert serialized sizes to weight units when necessary."},
1700 : : },
1701 : : },
1702 : : },
1703 : : },
1704 [ + - + - ]: 2262 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1705 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1706 : : "At least one output of either type must be specified.\n"
1707 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1708 : : "accepted as second parameter.",
1709 [ + - ]: 2262 : OutputsDoc(),
1710 [ + - ]: 2262 : RPCArgOptions{.skip_type_check = true}},
1711 [ + - + - : 3393 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
+ - ]
1712 [ + - + - ]: 2262 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1713 [ + - + - : 20358 : Cat<std::vector<RPCArg>>(
+ - + + +
+ - - -
- ]
1714 : : {
1715 [ + - + - : 3393 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
+ - ]
1716 [ + - + - : 3393 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
+ - ]
1717 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1718 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1719 [ + - + - : 3393 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
+ - ]
1720 [ + - + - ]: 2262 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1721 [ + - + - : 3393 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
+ - ]
1722 [ + - + - : 3393 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
+ - ]
1723 [ + - + - : 3393 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are " + FormatAllOutputTypes() + "."},
+ - + - ]
1724 [ + - + - : 3393 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::Default{false}, "(DEPRECATED) No longer used"},
+ - ]
1725 [ + - + - : 3393 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
+ - ]
1726 [ + - + - : 3393 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
+ - ]
1727 [ + - + - : 3393 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
+ - ]
1728 [ + - + - ]: 2262 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1729 : : "The fee will be equally deducted from the amount of each specified output.\n"
1730 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1731 : : "If no outputs are specified here, the sender pays the fee.",
1732 : : {
1733 [ + - + - ]: 2262 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1734 : : },
1735 : : },
1736 [ + - + - : 3393 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
+ - ]
1737 : : "Transaction building will fail if this can not be satisfied."},
1738 : : },
1739 [ + - ]: 2262 : FundTxDoc()),
1740 [ + - ]: 2262 : RPCArgOptions{.oneline_description="options"}},
1741 [ + - + - : 3393 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
+ - ]
1742 [ + - + - : 3393 : {"version", RPCArg::Type::NUM, RPCArg::Default{DEFAULT_WALLET_TX_VERSION}, "Transaction version"},
+ - ]
1743 [ + - + - : 3393 : {"psbt_version", RPCArg::Type::NUM, RPCArg::Default(2), "The PSBT version number to use."},
+ - ]
1744 : : },
1745 [ + - ]: 2262 : RPCResult{
1746 [ + - + - ]: 2262 : RPCResult::Type::OBJ, "", "",
1747 : : {
1748 [ + - + - ]: 2262 : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1749 [ + - + - ]: 2262 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1750 [ + - + - ]: 2262 : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1751 : : }
1752 [ + - + - : 9048 : },
+ + - - ]
1753 : 1131 : RPCExamples{
1754 : : "\nCreate a PSBT with automatically picked inputs that sends 0.5 BTC to an address and has a fee rate of 2 sat/vB:\n"
1755 [ + - + - : 3393 : + HelpExampleCli("walletcreatefundedpsbt", "\"[]\" \"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" 0 \"{\\\"add_inputs\\\":true,\\\"fee_rate\\\":2}\"")
+ - + - ]
1756 : 1131 : + "\nCreate the same PSBT as the above one instead using named arguments:\n"
1757 [ + - + - : 5655 : + HelpExampleCli("-named walletcreatefundedpsbt", "outputs=\"[{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.5}]\" add_inputs=true fee_rate=2")
+ - + - ]
1758 [ + - ]: 1131 : },
1759 : 1131 : [](const RPCMethod& self, const JSONRPCRequest& request) -> UniValue
1760 : : {
1761 : 236 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1762 [ - + ]: 236 : if (!pwallet) return UniValue::VNULL;
1763 : :
1764 [ + - ]: 236 : CWallet& wallet{*pwallet};
1765 : : // Make sure the results are valid at least up to the most recent block
1766 : : // the user could have gotten from another RPC command prior to now
1767 [ + - ]: 236 : wallet.BlockUntilSyncedToCurrentChain();
1768 : :
1769 [ + - + + : 236 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1770 : :
1771 [ + - ]: 236 : CCoinControl coin_control;
1772 [ + - ]: 236 : coin_control.m_version = self.Arg<uint32_t>("version");
1773 : :
1774 [ + - + - ]: 236 : const UniValue &replaceable_arg = options["replaceable"];
1775 [ + + + - ]: 236 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1776 [ + - + - : 236 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf, coin_control.m_version);
+ - + - ]
1777 : 236 : UniValue outputs(UniValue::VOBJ);
1778 [ + - + - ]: 236 : outputs = NormalizeOutputs(request.params[1]);
1779 : 236 : std::vector<CRecipient> recipients = CreateRecipients(
1780 [ + - ]: 472 : ParseOutputs(outputs),
1781 [ + - + - : 472 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1782 [ + - ]: 236 : );
1783 : : // Automatically select coins, unless at least one is manually selected. Can
1784 : : // be overridden by options.add_inputs.
1785 [ - + ]: 236 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1786 [ + - + + ]: 236 : SetOptionsInputWeights(request.params[0], options);
1787 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1788 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1789 : 235 : rawTx.vout.clear();
1790 [ + + ]: 235 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1791 : :
1792 : : // Make a blank psbt
1793 : 167 : uint32_t psbt_version = 2;
1794 [ + - + + ]: 167 : if (!request.params[6].isNull()) {
1795 [ + - + - ]: 5 : psbt_version = request.params[6].getInt<int>();
1796 : : }
1797 [ + + ]: 167 : if (psbt_version != 2 && psbt_version != 0) {
1798 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "The PSBT version can only be 2 or 0");
1799 : : }
1800 : :
1801 [ + - + - ]: 166 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx), psbt_version);
1802 : :
1803 : : // Fill transaction with out data but don't sign
1804 [ + - + + : 166 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1805 : 166 : bool complete = true;
1806 [ + - ]: 166 : const auto err{wallet.FillPSBT(psbtx, {.sign = false, .bip32_derivs = bip32derivs}, complete)};
1807 [ - + ]: 166 : if (err) {
1808 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1809 : : }
1810 : :
1811 : : // Serialize the PSBT
1812 : 166 : DataStream ssTx{};
1813 [ + - ]: 166 : ssTx << psbtx;
1814 : :
1815 : 166 : UniValue result(UniValue::VOBJ);
1816 [ + - + - : 498 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1817 [ + - + - : 332 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1818 [ + + + - : 332 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1819 : 166 : return result;
1820 [ + - ]: 944 : },
1821 [ + - + - : 22620 : };
+ - + - +
+ + + + +
- - - - -
- ]
1822 [ + - + - : 63336 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1823 : : } // namespace wallet
|
