Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <common/messages.h>
6 : : #include <consensus/validation.h>
7 : : #include <core_io.h>
8 : : #include <key_io.h>
9 : : #include <node/types.h>
10 : : #include <policy/policy.h>
11 : : #include <rpc/rawtransaction_util.h>
12 : : #include <rpc/util.h>
13 : : #include <script/script.h>
14 : : #include <util/rbf.h>
15 : : #include <util/translation.h>
16 : : #include <util/vector.h>
17 : : #include <wallet/coincontrol.h>
18 : : #include <wallet/feebumper.h>
19 : : #include <wallet/fees.h>
20 : : #include <wallet/rpc/util.h>
21 : : #include <wallet/spend.h>
22 : : #include <wallet/wallet.h>
23 : :
24 : : #include <univalue.h>
25 : :
26 : : using common::FeeModeFromString;
27 : : using common::FeeModesDetail;
28 : : using common::InvalidEstimateModeErrorMessage;
29 : : using common::StringForFeeReason;
30 : : using common::TransactionErrorString;
31 : : using node::TransactionError;
32 : :
33 : : namespace wallet {
34 : 1761 : std::vector<CRecipient> CreateRecipients(const std::vector<std::pair<CTxDestination, CAmount>>& outputs, const std::set<int>& subtract_fee_outputs)
35 : : {
36 : 1761 : std::vector<CRecipient> recipients;
37 [ + + ]: 23383 : for (size_t i = 0; i < outputs.size(); ++i) {
38 [ + - + - ]: 21622 : const auto& [destination, amount] = outputs.at(i);
39 [ + - ]: 43244 : CRecipient recipient{destination, amount, subtract_fee_outputs.contains(i)};
40 [ + - ]: 21622 : recipients.push_back(recipient);
41 : 21622 : }
42 : 1761 : return recipients;
43 : 0 : }
44 : :
45 : 300 : static void InterpretFeeEstimationInstructions(const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, UniValue& options)
46 : : {
47 [ + - + - : 877 : if (options.exists("conf_target") || options.exists("estimate_mode")) {
+ + + - +
- + + + +
- - ]
48 [ + + - + ]: 24 : if (!conf_target.isNull() || !estimate_mode.isNull()) {
49 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass conf_target and estimate_mode either as arguments or in the options object, but not both");
50 : : }
51 : : } else {
52 [ + - + - ]: 552 : options.pushKV("conf_target", conf_target);
53 [ + - + - ]: 552 : options.pushKV("estimate_mode", estimate_mode);
54 : : }
55 [ + + ]: 594 : if (options.exists("fee_rate")) {
56 [ + + ]: 26 : if (!fee_rate.isNull()) {
57 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Pass the fee_rate either as an argument, or in the options object, but not both");
58 : : }
59 : : } else {
60 [ + - + - ]: 542 : options.pushKV("fee_rate", fee_rate);
61 : : }
62 [ + - + - : 650 : if (!options["conf_target"].isNull() && (options["estimate_mode"].isNull() || (options["estimate_mode"].get_str() == "unset"))) {
+ + + - +
- + - + -
+ - + - -
+ + + - +
- - - - ]
63 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Specify estimate_mode");
64 : : }
65 : 296 : }
66 : :
67 : 1764 : std::set<int> InterpretSubtractFeeFromOutputInstructions(const UniValue& sffo_instructions, const std::vector<std::string>& destinations)
68 : : {
69 [ + + ]: 1764 : std::set<int> sffo_set;
70 [ + + ]: 1764 : if (sffo_instructions.isNull()) return sffo_set;
71 [ + + ]: 310 : if (sffo_instructions.isBool()) {
72 [ + - + + : 217 : if (sffo_instructions.get_bool()) sffo_set.insert(0);
+ - ]
73 : : return sffo_set;
74 : : }
75 [ + - + + ]: 189 : for (const auto& sffo : sffo_instructions.getValues()) {
76 [ + + ]: 96 : if (sffo.isStr()) {
77 [ + + ]: 11 : for (size_t i = 0; i < destinations.size(); ++i) {
78 [ + - + - : 10 : if (sffo.get_str() == destinations.at(i)) {
+ + ]
79 [ + - ]: 7 : sffo_set.insert(i);
80 : : break;
81 : : }
82 : : }
83 : : }
84 [ + + + + ]: 192 : if (sffo.isNum()) {
85 [ + - ]: 88 : int pos = sffo.getInt<int>();
86 [ - + ]: 88 : if (sffo_set.contains(pos))
87 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, duplicated position: %d", pos));
88 [ - + ]: 88 : if (pos < 0)
89 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, negative position: %d", pos));
90 [ - + ]: 88 : if (pos >= int(destinations.size()))
91 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, position too large: %d", pos));
92 [ + - ]: 88 : sffo_set.insert(pos);
93 : : }
94 : : }
95 : : return sffo_set;
96 : 0 : }
97 : :
98 : 191 : static UniValue FinishTransaction(const std::shared_ptr<CWallet> pwallet, const UniValue& options, const CMutableTransaction& rawTx)
99 : : {
100 : : // Make a blank psbt
101 : 191 : PartiallySignedTransaction psbtx(rawTx);
102 : :
103 : : // First fill transaction with our data without signing,
104 : : // so external signers are not asked to sign more than once.
105 : 191 : bool complete;
106 [ + - ]: 191 : pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/false, /*bip32derivs=*/true);
107 [ + - ]: 191 : const auto err{pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/true, /*bip32derivs=*/false)};
108 [ - + ]: 191 : if (err) {
109 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
110 : : }
111 : :
112 [ + - ]: 191 : CMutableTransaction mtx;
113 [ + - ]: 191 : complete = FinalizeAndExtractPSBT(psbtx, mtx);
114 : :
115 : 191 : UniValue result(UniValue::VOBJ);
116 : :
117 [ + - + - : 212 : const bool psbt_opt_in{options.exists("psbt") && options["psbt"].get_bool()};
+ + + - +
- + - + -
- - ]
118 [ + - + + : 382 : bool add_to_wallet{options.exists("add_to_wallet") ? options["add_to_wallet"].get_bool() : true};
+ - + - +
- ]
119 [ + + + + : 191 : if (psbt_opt_in || !complete || !add_to_wallet) {
+ + ]
120 : : // Serialize the PSBT
121 : 54 : DataStream ssTx{};
122 [ + - ]: 54 : ssTx << psbtx;
123 [ + - + - : 108 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
124 : 54 : }
125 : :
126 [ + + ]: 191 : if (complete) {
127 [ + - + - ]: 165 : std::string hex{EncodeHexTx(CTransaction(mtx))};
128 [ + - ]: 165 : CTransactionRef tx(MakeTransactionRef(std::move(mtx)));
129 [ + - + - : 330 : result.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
130 [ + + ]: 165 : if (add_to_wallet && !psbt_opt_in) {
131 [ + - + - ]: 411 : pwallet->CommitTransaction(tx, {}, /*orderForm=*/{});
132 : : } else {
133 [ + - + - : 56 : result.pushKV("hex", hex);
+ - ]
134 : : }
135 : 165 : }
136 [ + - + - : 382 : result.pushKV("complete", complete);
+ - ]
137 : :
138 : 382 : return result;
139 : 191 : }
140 : :
141 : 296 : static void PreventOutdatedOptions(const UniValue& options)
142 : : {
143 [ + + ]: 592 : if (options.exists("feeRate")) {
144 [ + - + - ]: 3 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use fee_rate (" + CURRENCY_ATOM + "/vB) instead of feeRate");
145 : : }
146 [ - + ]: 590 : if (options.exists("changeAddress")) {
147 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_address instead of changeAddress");
148 : : }
149 [ - + ]: 590 : if (options.exists("changePosition")) {
150 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use change_position instead of changePosition");
151 : : }
152 [ - + ]: 590 : if (options.exists("includeWatching")) {
153 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use include_watching instead of includeWatching");
154 : : }
155 [ - + ]: 590 : if (options.exists("lockUnspents")) {
156 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use lock_unspents instead of lockUnspents");
157 : : }
158 [ - + ]: 590 : if (options.exists("subtractFeeFromOutputs")) {
159 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Use subtract_fee_from_outputs instead of subtractFeeFromOutputs");
160 : : }
161 : 295 : }
162 : :
163 : 1184 : UniValue SendMoney(CWallet& wallet, const CCoinControl &coin_control, std::vector<CRecipient> &recipients, mapValue_t map_value, bool verbose)
164 : : {
165 : 1184 : EnsureWalletIsUnlocked(wallet);
166 : :
167 : : // This function is only used by sendtoaddress and sendmany.
168 : : // This should always try to sign, if we don't have private keys, don't try to do anything here.
169 [ - + ]: 1184 : if (wallet.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) {
170 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Error: Private keys are disabled for this wallet");
171 : : }
172 : :
173 : : // Shuffle recipient list
174 : 1184 : std::shuffle(recipients.begin(), recipients.end(), FastRandomContext());
175 : :
176 : : // Send
177 : 1184 : auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, coin_control, true);
178 [ + + ]: 1184 : if (!res) {
179 [ + - + - ]: 32 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, util::ErrorString(res).original);
180 : : }
181 : 1168 : const CTransactionRef& tx = res->tx;
182 [ + - + - ]: 3504 : wallet.CommitTransaction(tx, std::move(map_value), /*orderForm=*/{});
183 [ + + ]: 1168 : if (verbose) {
184 : 2 : UniValue entry(UniValue::VOBJ);
185 [ + - + - : 4 : entry.pushKV("txid", tx->GetHash().GetHex());
+ - + - ]
186 [ + - + - : 4 : entry.pushKV("fee_reason", StringForFeeReason(res->fee_calc.reason));
+ - + - ]
187 : 2 : return entry;
188 : 0 : }
189 [ + - + - ]: 1166 : return tx->GetHash().GetHex();
190 : 1168 : }
191 : :
192 : :
193 : : /**
194 : : * Update coin control with fee estimation based on the given parameters
195 : : *
196 : : * @param[in] wallet Wallet reference
197 : : * @param[in,out] cc Coin control to be updated
198 : : * @param[in] conf_target UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
199 : : * @param[in] estimate_mode UniValue string; fee estimation mode, valid values are "unset", "economical" or "conservative";
200 : : * @param[in] fee_rate UniValue real; fee rate in sat/vB;
201 : : * if present, both conf_target and estimate_mode must either be null, or "unset"
202 : : * @param[in] override_min_fee bool; whether to set fOverrideFeeRate to true to disable minimum fee rate checks and instead
203 : : * verify only that fee_rate is greater than 0
204 : : * @throws a JSONRPCError if conf_target, estimate_mode, or fee_rate contain invalid values or are in conflict
205 : : */
206 : 1834 : static void SetFeeEstimateMode(const CWallet& wallet, CCoinControl& cc, const UniValue& conf_target, const UniValue& estimate_mode, const UniValue& fee_rate, bool override_min_fee)
207 : : {
208 [ + + ]: 1834 : if (!fee_rate.isNull()) {
209 [ + + ]: 387 : if (!conf_target.isNull()) {
210 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
211 : : }
212 [ + + + + ]: 384 : if (!estimate_mode.isNull() && estimate_mode.get_str() != "unset") {
213 [ + - + - ]: 6 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and fee_rate");
214 : : }
215 : : // Fee rates in sat/vB cannot represent more than 3 significant digits.
216 [ - + ]: 381 : cc.m_feerate = CFeeRate{AmountFromValue(fee_rate, /*decimals=*/3)};
217 [ + + ]: 305 : if (override_min_fee) cc.fOverrideFeeRate = true;
218 : : // Default RBF to true for explicit fee_rate, if unset.
219 [ + + ]: 305 : if (!cc.m_signal_bip125_rbf) cc.m_signal_bip125_rbf = true;
220 : 305 : return;
221 : : }
222 [ + + + + ]: 1447 : if (!estimate_mode.isNull() && !FeeModeFromString(estimate_mode.get_str(), cc.m_fee_mode)) {
223 [ + - + - ]: 54 : throw JSONRPCError(RPC_INVALID_PARAMETER, InvalidEstimateModeErrorMessage());
224 : : }
225 [ + + ]: 1420 : if (!conf_target.isNull()) {
226 : 32 : cc.m_confirm_target = ParseConfirmTarget(conf_target, wallet.chain().estimateMaxBlocks());
227 : : }
228 : : }
229 : :
230 : 1901 : RPCHelpMan sendtoaddress()
231 : : {
232 : 1901 : return RPCHelpMan{"sendtoaddress",
233 : 1901 : "\nSend an amount to a given address." +
234 [ + - ]: 1901 : HELP_REQUIRING_PASSPHRASE,
235 : : {
236 [ + - ]: 1901 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "The bitcoin address to send to."},
237 [ + - ]: 3802 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The amount in " + CURRENCY_UNIT + " to send. eg 0.1"},
238 [ + - ]: 1901 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment used to store what the transaction is for.\n"
239 : : "This is not part of the transaction, just kept in your wallet."},
240 [ + - ]: 1901 : {"comment_to", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment to store the name of the person or organization\n"
241 : : "to which you're sending the transaction. This is not part of the \n"
242 : : "transaction, just kept in your wallet."},
243 [ + - ]: 3802 : {"subtractfeefromamount", RPCArg::Type::BOOL, RPCArg::Default{false}, "The fee will be deducted from the amount being sent.\n"
244 : : "The recipient will receive less bitcoins than you enter in the amount field."},
245 [ + - ]: 3802 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
246 [ + - ]: 3802 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
247 [ + - ]: 3802 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
248 [ + - + - ]: 3802 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
249 [ + - ]: 3802 : {"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
250 : : "dirty if they have previously been used in a transaction. If true, this also activates avoidpartialspends, grouping outputs by their addresses."},
251 [ + - ]: 5703 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
252 [ + - ]: 3802 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
253 : : },
254 : : {
255 : : RPCResult{"if verbose is not set or set to false",
256 : : RPCResult::Type::STR_HEX, "txid", "The transaction id."
257 [ + - + - : 3802 : },
+ - + - ]
258 : : RPCResult{"if verbose is set to true",
259 : : RPCResult::Type::OBJ, "", "",
260 : : {
261 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
262 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
263 : : },
264 [ + - + - : 7604 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
265 : : },
266 : 1901 : RPCExamples{
267 : : "\nSend 0.1 BTC\n"
268 [ + - + - : 5703 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1") +
+ - + - ]
269 : 1901 : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode using positional arguments\n"
270 [ + - + - : 9505 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"donation\" \"sean's outpost\" false true 6 economical") +
+ - + - ]
271 [ + - ]: 3802 : "\nSend 0.1 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB, subtract fee from amount, BIP125-replaceable, using positional arguments\n"
272 [ + - + - : 9505 : + HelpExampleCli("sendtoaddress", "\"" + EXAMPLE_ADDRESS[0] + "\" 0.1 \"drinks\" \"room77\" true true null \"unset\" null 1.1") +
+ - + - ]
273 : 1901 : "\nSend 0.2 BTC with a confirmation target of 6 blocks in economical fee estimate mode using named arguments\n"
274 [ + - + - : 9505 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.2 conf_target=6 estimate_mode=\"economical\"") +
+ - + - ]
275 [ + - ]: 3802 : "\nSend 0.5 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
276 [ + - + - : 9505 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25")
+ - + - ]
277 [ + - + - : 7604 : + HelpExampleCli("-named sendtoaddress", "address=\"" + EXAMPLE_ADDRESS[0] + "\" amount=0.5 fee_rate=25 subtractfeefromamount=false replaceable=true avoid_reuse=true comment=\"2 pizzas\" comment_to=\"jeremy\" verbose=true")
+ - ]
278 [ + - ]: 1901 : },
279 : 1135 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
280 : : {
281 : 1135 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
282 [ - + ]: 1135 : if (!pwallet) return UniValue::VNULL;
283 : :
284 : : // Make sure the results are valid at least up to the most recent block
285 : : // the user could have gotten from another RPC command prior to now
286 [ + - ]: 1135 : pwallet->BlockUntilSyncedToCurrentChain();
287 : :
288 [ + - ]: 1135 : LOCK(pwallet->cs_wallet);
289 : :
290 : : // Wallet comments
291 [ + - ]: 1135 : mapValue_t mapValue;
292 [ + - + + : 1135 : if (!request.params[2].isNull() && !request.params[2].get_str().empty())
+ - + - +
+ ]
293 [ + - + - : 2 : mapValue["comment"] = request.params[2].get_str();
+ - + - +
- ]
294 [ + - + + : 1135 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - +
+ ]
295 [ + - + - : 2 : mapValue["to"] = request.params[3].get_str();
+ - + - +
- ]
296 : :
297 [ + - ]: 1135 : CCoinControl coin_control;
298 [ + - + + ]: 1135 : if (!request.params[5].isNull()) {
299 [ + - + - ]: 2 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
300 : : }
301 : :
302 [ + - + - ]: 1135 : coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(*pwallet, request.params[8]);
303 : : // We also enable partial spend avoidance if reuse avoidance is set.
304 : 1135 : coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
305 : :
306 [ + - + - : 1135 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[9], /*override_min_fee=*/false);
+ - + - ]
307 : :
308 [ + + ]: 1135 : EnsureWalletIsUnlocked(*pwallet);
309 : :
310 : 1134 : UniValue address_amounts(UniValue::VOBJ);
311 [ + - + - : 1134 : const std::string address = request.params[0].get_str();
+ - ]
312 [ + - + - : 2268 : address_amounts.pushKV(address, request.params[1]);
+ - + - ]
313 : 1134 : std::vector<CRecipient> recipients = CreateRecipients(
314 [ + + ]: 2266 : ParseOutputs(address_amounts),
315 [ + - + - : 1136 : InterpretSubtractFeeFromOutputInstructions(request.params[4], address_amounts.getKeys())
+ - ]
316 [ + - ]: 1132 : );
317 [ + - + + : 1132 : const bool verbose{request.params[10].isNull() ? false : request.params[10].get_bool()};
+ - + - ]
318 : :
319 [ + - + + ]: 1136 : return SendMoney(*pwallet, coin_control, recipients, mapValue, verbose);
320 [ + - ]: 3415 : },
321 [ + - + - : 110258 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
322 [ + - + - : 53228 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- ]
323 : :
324 : 841 : RPCHelpMan sendmany()
325 : : {
326 : 841 : return RPCHelpMan{"sendmany",
327 : 841 : "Send multiple times. Amounts are double-precision floating point numbers." +
328 [ + - ]: 841 : HELP_REQUIRING_PASSPHRASE,
329 : : {
330 [ + - ]: 1682 : {"dummy", RPCArg::Type::STR, RPCArg::Default{"\"\""}, "Must be set to \"\" for backwards compatibility.",
331 [ + - + - ]: 1682 : RPCArgOptions{
332 : : .oneline_description = "\"\"",
333 : : }},
334 [ + - ]: 841 : {"amounts", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::NO, "The addresses and amounts",
335 : : {
336 [ + - ]: 1682 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The bitcoin address is the key, the numeric amount (can be string) in " + CURRENCY_UNIT + " is the value"},
337 : : },
338 : : },
339 [ + - ]: 841 : {"minconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Ignored dummy value"},
340 [ + - ]: 841 : {"comment", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A comment"},
341 [ + - ]: 841 : {"subtractfeefrom", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The addresses.\n"
342 : : "The fee will be equally deducted from the amount of each selected address.\n"
343 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
344 : : "If no addresses are specified here, the sender pays the fee.",
345 : : {
346 [ + - ]: 841 : {"address", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "Subtract fee from this address"},
347 : : },
348 : : },
349 [ + - ]: 1682 : {"replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Signal that this transaction can be replaced by a transaction (BIP 125)"},
350 [ + - ]: 1682 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
351 [ + - ]: 1682 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
352 [ + - + - ]: 1682 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
353 [ + - ]: 2523 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
354 [ + - ]: 1682 : {"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
355 : : },
356 : : {
357 : : RPCResult{"if verbose is not set or set to false",
358 : : RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
359 : : "the number of addresses."
360 [ + - + - : 1682 : },
+ - + - ]
361 : : RPCResult{"if verbose is set to true",
362 : : RPCResult::Type::OBJ, "", "",
363 : : {
364 : : {RPCResult::Type::STR_HEX, "txid", "The transaction id for the send. Only 1 transaction is created regardless of\n"
365 : : "the number of addresses."},
366 : : {RPCResult::Type::STR, "fee_reason", "The transaction fee reason."}
367 : : },
368 [ + - + - : 3364 : },
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
369 : : },
370 : 841 : RPCExamples{
371 : : "\nSend two amounts to two different addresses:\n"
372 [ + - + - : 3364 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\"") +
+ - + - +
- ]
373 : 841 : "\nSend two amounts to two different addresses setting the confirmation and comment:\n"
374 [ + - + - : 5046 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 6 \"testing\"") +
+ - + - +
- ]
375 : 841 : "\nSend two amounts to two different addresses, subtract fee from amount:\n"
376 [ + - + - : 6728 : + HelpExampleCli("sendmany", "\"\" \"{\\\"" + EXAMPLE_ADDRESS[0] + "\\\":0.01,\\\"" + EXAMPLE_ADDRESS[1] + "\\\":0.02}\" 1 \"\" \"[\\\"" + EXAMPLE_ADDRESS[0] + "\\\",\\\"" + EXAMPLE_ADDRESS[1] + "\\\"]\"") +
+ - + - +
- + - +
- ]
377 : 841 : "\nAs a JSON-RPC call\n"
378 [ + - + - : 4205 : + HelpExampleRpc("sendmany", "\"\", {\"" + EXAMPLE_ADDRESS[0] + "\":0.01,\"" + EXAMPLE_ADDRESS[1] + "\":0.02}, 6, \"testing\"")
+ - + - ]
379 [ + - ]: 841 : },
380 : 75 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
381 : : {
382 : 75 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
383 [ - + ]: 75 : if (!pwallet) return UniValue::VNULL;
384 : :
385 : : // Make sure the results are valid at least up to the most recent block
386 : : // the user could have gotten from another RPC command prior to now
387 [ + - ]: 75 : pwallet->BlockUntilSyncedToCurrentChain();
388 : :
389 [ + - ]: 75 : LOCK(pwallet->cs_wallet);
390 : :
391 [ + - + + : 75 : if (!request.params[0].isNull() && !request.params[0].get_str().empty()) {
+ - + - -
+ ]
392 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Dummy value must be set to \"\"");
393 : : }
394 [ + - + - : 75 : UniValue sendTo = request.params[1].get_obj();
+ - ]
395 : :
396 [ + - ]: 75 : mapValue_t mapValue;
397 [ + - + + : 75 : if (!request.params[3].isNull() && !request.params[3].get_str().empty())
+ - + - -
+ ]
398 [ # # # # : 0 : mapValue["comment"] = request.params[3].get_str();
# # # # #
# ]
399 : :
400 [ + - ]: 75 : CCoinControl coin_control;
401 [ + - - + ]: 75 : if (!request.params[5].isNull()) {
402 [ # # # # ]: 0 : coin_control.m_signal_bip125_rbf = request.params[5].get_bool();
403 : : }
404 : :
405 [ + - + - : 75 : SetFeeEstimateMode(*pwallet, coin_control, /*conf_target=*/request.params[6], /*estimate_mode=*/request.params[7], /*fee_rate=*/request.params[8], /*override_min_fee=*/false);
+ - + + ]
406 : :
407 : 52 : std::vector<CRecipient> recipients = CreateRecipients(
408 [ + - ]: 104 : ParseOutputs(sendTo),
409 [ + - + - : 52 : InterpretSubtractFeeFromOutputInstructions(request.params[4], sendTo.getKeys())
+ - ]
410 [ + - ]: 52 : );
411 [ + - + + : 52 : const bool verbose{request.params[9].isNull() ? false : request.params[9].get_bool()};
+ - + - ]
412 : :
413 [ + + ]: 64 : return SendMoney(*pwallet, coin_control, recipients, std::move(mapValue), verbose);
414 [ + - ]: 237 : },
415 [ + - + - : 49619 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + + + -
- - - - -
- - ]
416 [ + - + - : 24389 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
417 : :
418 : 784 : RPCHelpMan settxfee()
419 : : {
420 : 784 : return RPCHelpMan{"settxfee",
421 [ + - ]: 1568 : "\nSet the transaction fee rate in " + CURRENCY_UNIT + "/kvB for this wallet. Overrides the global -paytxfee command line parameter.\n"
422 : 784 : "Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.\n",
423 : : {
424 [ + - ]: 1568 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The transaction fee rate in " + CURRENCY_UNIT + "/kvB"},
425 : : },
426 : 0 : RPCResult{
427 : : RPCResult::Type::BOOL, "", "Returns true if successful"
428 [ + - + - : 1568 : },
+ - ]
429 : 784 : RPCExamples{
430 [ + - + - : 1568 : HelpExampleCli("settxfee", "0.00001")
+ - ]
431 [ + - + - : 3136 : + HelpExampleRpc("settxfee", "0.00001")
+ - + - ]
432 [ + - ]: 784 : },
433 : 18 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
434 : : {
435 : 18 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
436 [ - + ]: 18 : if (!pwallet) return UniValue::VNULL;
437 : :
438 [ + - ]: 18 : LOCK(pwallet->cs_wallet);
439 : :
440 [ + - + - ]: 18 : CAmount nAmount = AmountFromValue(request.params[0]);
441 [ + - ]: 18 : CFeeRate tx_fee_rate(nAmount, 1000);
442 [ + - ]: 18 : CFeeRate max_tx_fee_rate(pwallet->m_default_max_tx_fee, 1000);
443 [ + + ]: 18 : if (tx_fee_rate == CFeeRate(0)) {
444 : : // automatic selection
445 [ + - + + ]: 16 : } else if (tx_fee_rate < pwallet->chain().relayMinFee()) {
446 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than min relay tx fee (%s)", pwallet->chain().relayMinFee().ToString()));
+ - + - ]
447 [ + + ]: 15 : } else if (tx_fee_rate < pwallet->m_min_fee) {
448 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be less than wallet min fee (%s)", pwallet->m_min_fee.ToString()));
+ - ]
449 [ + + ]: 14 : } else if (tx_fee_rate > max_tx_fee_rate) {
450 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("txfee cannot be more than wallet max tx fee (%s)", max_tx_fee_rate.ToString()));
+ - ]
451 : : }
452 : :
453 [ + - ]: 15 : pwallet->m_pay_tx_fee = tx_fee_rate;
454 [ + - ]: 15 : return true;
455 : 33 : },
456 [ + - + - : 8624 : };
+ - + - +
- + + -
- ]
457 [ + - + - ]: 2352 : }
458 : :
459 : :
460 : : // Only includes key documentation where the key is snake_case in all RPC methods. MixedCase keys can be added later.
461 : 3745 : static std::vector<RPCArg> FundTxDoc(bool solving_data = true)
462 : : {
463 : 3745 : std::vector<RPCArg> args = {
464 [ + - + - ]: 14980 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks", RPCArgOptions{.also_positional = true}},
465 [ + - ]: 7490 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
466 [ + - + - : 7490 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used")), RPCArgOptions{.also_positional = true}},
+ - ]
467 : : {
468 [ + - ]: 7490 : "replaceable", RPCArg::Type::BOOL, RPCArg::DefaultHint{"wallet default"}, "Marks this transaction as BIP125-replaceable.\n"
469 : : "Allows this transaction to be replaced by a transaction with higher fees"
470 : : },
471 [ + - + - : 59920 : };
+ - + - +
- + - + -
+ + - - ]
472 [ + - ]: 3745 : if (solving_data) {
473 [ + - + - : 101115 : args.push_back({"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + + +
+ + - - -
- - - -
- ]
474 : : "Used for fee estimation during coin selection.",
475 : : {
476 : : {
477 : 7490 : "pubkeys", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Public keys involved in this transaction.",
478 : : {
479 [ + - ]: 3745 : {"pubkey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A public key"},
480 : : }
481 : : },
482 : : {
483 : 7490 : "scripts", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Scripts involved in this transaction.",
484 : : {
485 [ + - ]: 3745 : {"script", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "A script"},
486 : : }
487 : : },
488 : : {
489 : 7490 : "descriptors", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Descriptors that provide solving data for this transaction.",
490 : : {
491 [ + - ]: 3745 : {"descriptor", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "A descriptor"},
492 : : }
493 : : },
494 : : }
495 : : });
496 : : }
497 : 3745 : return args;
498 [ + - + - : 71155 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - ]
499 : :
500 : 575 : CreatedTransactionResult FundTransaction(CWallet& wallet, const CMutableTransaction& tx, const std::vector<CRecipient>& recipients, const UniValue& options, CCoinControl& coinControl, bool override_min_fee)
501 : : {
502 : : // We want to make sure tx.vout is not used now that we are passing outputs as a vector of recipients.
503 : : // This sets us up to remove tx completely in a future PR in favor of passing the inputs directly.
504 : 575 : CHECK_NONFATAL(tx.vout.empty());
505 : : // Make sure the results are valid at least up to the most recent block
506 : : // the user could have gotten from another RPC command prior to now
507 : 575 : wallet.BlockUntilSyncedToCurrentChain();
508 : :
509 : 575 : std::optional<unsigned int> change_position;
510 : 575 : bool lockUnspents = false;
511 [ + + ]: 575 : if (!options.isNull()) {
512 [ + + ]: 519 : if (options.type() == UniValue::VBOOL) {
513 : : // backward compatibility bool only fallback
514 : 1 : coinControl.fAllowWatchOnly = options.get_bool();
515 : : }
516 : : else {
517 [ + + + + : 15045 : RPCTypeCheckObj(options,
+ + ]
518 : : {
519 [ + - ]: 518 : {"add_inputs", UniValueType(UniValue::VBOOL)},
520 [ + - ]: 518 : {"include_unsafe", UniValueType(UniValue::VBOOL)},
521 [ + - ]: 518 : {"add_to_wallet", UniValueType(UniValue::VBOOL)},
522 [ + - ]: 518 : {"changeAddress", UniValueType(UniValue::VSTR)},
523 [ + - ]: 518 : {"change_address", UniValueType(UniValue::VSTR)},
524 [ + - ]: 518 : {"changePosition", UniValueType(UniValue::VNUM)},
525 [ + - ]: 518 : {"change_position", UniValueType(UniValue::VNUM)},
526 [ + - ]: 518 : {"change_type", UniValueType(UniValue::VSTR)},
527 [ + - ]: 518 : {"includeWatching", UniValueType(UniValue::VBOOL)},
528 [ + - ]: 518 : {"include_watching", UniValueType(UniValue::VBOOL)},
529 [ + - ]: 518 : {"inputs", UniValueType(UniValue::VARR)},
530 [ + - ]: 518 : {"lockUnspents", UniValueType(UniValue::VBOOL)},
531 [ + - ]: 518 : {"lock_unspents", UniValueType(UniValue::VBOOL)},
532 [ + - ]: 518 : {"locktime", UniValueType(UniValue::VNUM)},
533 [ + - ]: 518 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
534 [ + - ]: 518 : {"feeRate", UniValueType()}, // will be checked by AmountFromValue() below
535 [ + - ]: 518 : {"psbt", UniValueType(UniValue::VBOOL)},
536 [ + - ]: 518 : {"solving_data", UniValueType(UniValue::VOBJ)},
537 [ + - ]: 518 : {"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
538 [ + - ]: 518 : {"subtract_fee_from_outputs", UniValueType(UniValue::VARR)},
539 [ + - ]: 518 : {"replaceable", UniValueType(UniValue::VBOOL)},
540 [ + - ]: 518 : {"conf_target", UniValueType(UniValue::VNUM)},
541 [ + - ]: 518 : {"estimate_mode", UniValueType(UniValue::VSTR)},
542 [ + - ]: 518 : {"minconf", UniValueType(UniValue::VNUM)},
543 [ + - ]: 518 : {"maxconf", UniValueType(UniValue::VNUM)},
544 [ + - ]: 518 : {"input_weights", UniValueType(UniValue::VARR)},
545 [ + - ]: 518 : {"max_tx_weight", UniValueType(UniValue::VNUM)},
546 : : },
547 : : true, true);
548 : :
549 [ + + ]: 990 : if (options.exists("add_inputs")) {
550 [ + - + - ]: 171 : coinControl.m_allow_other_inputs = options["add_inputs"].get_bool();
551 : : }
552 : :
553 [ + - + - : 1476 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + + + +
- - ]
554 [ + + + - : 39 : const std::string change_address_str = (options.exists("change_address") ? options["change_address"] : options["changeAddress"]).get_str();
+ - + - +
- + - + -
+ + + + -
- - - ]
555 [ + - ]: 13 : CTxDestination dest = DecodeDestination(change_address_str);
556 : :
557 [ + - + + ]: 13 : if (!IsValidDestination(dest)) {
558 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Change address must be a valid bitcoin address");
559 : : }
560 : :
561 [ + - ]: 22 : coinControl.destChange = dest;
562 : 15 : }
563 : :
564 [ + - + - : 1475 : if (options.exists("changePosition") || options.exists("change_position")) {
+ + + - +
- + + + +
- - ]
565 [ + + + - : 111 : int pos = (options.exists("change_position") ? options["change_position"] : options["changePosition"]).getInt<int>();
+ - + - +
- + - + +
+ + - - -
- ]
566 [ + - + + ]: 37 : if (pos < 0 || (unsigned int)pos > recipients.size()) {
567 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "changePosition out of bounds");
568 : : }
569 : 36 : change_position = (unsigned int)pos;
570 : : }
571 : :
572 [ + + ]: 984 : if (options.exists("change_type")) {
573 [ + - + - : 227 : if (options.exists("changeAddress") || options.exists("change_address")) {
+ + + - +
- + - + +
- - ]
574 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both change address and address type options");
575 : : }
576 [ + - + + : 150 : if (std::optional<OutputType> parsed = ParseOutputType(options["change_type"].get_str())) {
+ - + + ]
577 [ - + ]: 146 : coinControl.m_change_type.emplace(parsed.value());
578 : : } else {
579 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Unknown change type '%s'", options["change_type"].get_str()));
+ - + - +
- ]
580 : : }
581 : : }
582 : :
583 [ + + + - : 1467 : const UniValue include_watching_option = options.exists("include_watching") ? options["include_watching"] : options["includeWatching"];
+ - + - +
- + - + +
+ + - - -
- ]
584 [ + - ]: 489 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(include_watching_option, wallet);
585 : :
586 [ + - + - : 1464 : if (options.exists("lockUnspents") || options.exists("lock_unspents")) {
+ + + - +
- + + + +
- - ]
587 [ + - + + : 16 : lockUnspents = (options.exists("lock_unspents") ? options["lock_unspents"] : options["lockUnspents"]).get_bool();
+ - + - +
- + - + -
+ + + + -
- - - ]
588 : : }
589 : :
590 [ + - + + ]: 978 : if (options.exists("include_unsafe")) {
591 [ + - + - : 5 : coinControl.m_include_unsafe_inputs = options["include_unsafe"].get_bool();
+ - ]
592 : : }
593 : :
594 [ + - + + ]: 978 : if (options.exists("feeRate")) {
595 [ + - + + ]: 108 : if (options.exists("fee_rate")) {
596 [ + - + - : 8 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both fee_rate (" + CURRENCY_ATOM + "/vB) and feeRate (" + CURRENCY_UNIT + "/kvB)");
+ - ]
597 : : }
598 [ + - + + ]: 104 : if (options.exists("conf_target")) {
599 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both conf_target and feeRate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.");
600 : : }
601 [ + - + + ]: 100 : if (options.exists("estimate_mode")) {
602 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot specify both estimate_mode and feeRate");
603 : : }
604 [ + - + - : 96 : coinControl.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
+ + - + ]
605 : 32 : coinControl.fOverrideFeeRate = true;
606 : : }
607 : :
608 [ + - + + ]: 934 : if (options.exists("replaceable")) {
609 [ + - + - : 7 : coinControl.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
610 : : }
611 : :
612 [ + - + + ]: 934 : if (options.exists("minconf")) {
613 [ + - + - : 8 : coinControl.m_min_depth = options["minconf"].getInt<int>();
+ - ]
614 : :
615 [ + + ]: 8 : if (coinControl.m_min_depth < 0) {
616 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative minconf");
617 : : }
618 : : }
619 : :
620 [ + - + + ]: 932 : if (options.exists("maxconf")) {
621 [ + - + - : 4 : coinControl.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
622 : :
623 [ - + ]: 4 : if (coinControl.m_max_depth < coinControl.m_min_depth) {
624 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coinControl.m_max_depth, coinControl.m_min_depth));
625 : : }
626 : : }
627 [ + - + - : 1126 : SetFeeEstimateMode(wallet, coinControl, options["conf_target"], options["estimate_mode"], options["fee_rate"], override_min_fee);
+ - + - +
- + - +
+ ]
628 : 489 : }
629 : : } else {
630 : : // if options is null and not a bool
631 : 56 : coinControl.fAllowWatchOnly = ParseIncludeWatchonly(NullUniValue, wallet);
632 : : }
633 : :
634 [ + + ]: 852 : if (options.exists("solving_data")) {
635 [ + - + - : 14 : const UniValue solving_data = options["solving_data"].get_obj();
+ - ]
636 [ + - + + ]: 28 : if (solving_data.exists("pubkeys")) {
637 [ + - + - : 8 : for (const UniValue& pk_univ : solving_data["pubkeys"].get_array().getValues()) {
+ - + - +
+ ]
638 [ + - + + ]: 5 : const CPubKey pubkey = HexToPubKey(pk_univ.get_str());
639 [ + - + - ]: 3 : coinControl.m_external_provider.pubkeys.emplace(pubkey.GetID(), pubkey);
640 : : // Add witness script for pubkeys
641 [ + - + - ]: 3 : const CScript wit_script = GetScriptForDestination(WitnessV0KeyHash(pubkey));
642 [ + - + - ]: 3 : coinControl.m_external_provider.scripts.emplace(CScriptID(wit_script), wit_script);
643 : 3 : }
644 : : }
645 : :
646 [ + - + + ]: 24 : if (solving_data.exists("scripts")) {
647 [ + - + - : 9 : for (const UniValue& script_univ : solving_data["scripts"].get_array().getValues()) {
+ - + - +
+ ]
648 [ + - ]: 6 : const std::string& script_str = script_univ.get_str();
649 [ + - + + ]: 6 : if (!IsHex(script_str)) {
650 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("'%s' is not hex", script_str));
651 : : }
652 [ + - ]: 5 : std::vector<unsigned char> script_data(ParseHex(script_str));
653 : 5 : const CScript script(script_data.begin(), script_data.end());
654 [ + - + - ]: 5 : coinControl.m_external_provider.scripts.emplace(CScriptID(script), script);
655 : 5 : }
656 : : }
657 : :
658 [ + - + + ]: 22 : if (solving_data.exists("descriptors")) {
659 [ + - + - : 15 : for (const UniValue& desc_univ : solving_data["descriptors"].get_array().getValues()) {
+ - + - +
+ ]
660 [ + - ]: 8 : const std::string& desc_str = desc_univ.get_str();
661 : 8 : FlatSigningProvider desc_out;
662 [ + - ]: 8 : std::string error;
663 : 8 : std::vector<CScript> scripts_temp;
664 [ + - ]: 8 : auto descs = Parse(desc_str, desc_out, error, true);
665 [ + + ]: 8 : if (descs.empty()) {
666 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Unable to parse descriptor '%s': %s", desc_str, error));
667 : : }
668 [ + + ]: 14 : for (auto& desc : descs) {
669 [ + - ]: 7 : desc->Expand(0, desc_out, scripts_temp, desc_out);
670 : : }
671 [ + - ]: 7 : coinControl.m_external_provider.Merge(std::move(desc_out));
672 : 10 : }
673 : : }
674 : 14 : }
675 : :
676 [ + + ]: 844 : if (options.exists("input_weights")) {
677 [ + - + - : 2594 : for (const UniValue& input : options["input_weights"].get_array().getValues()) {
+ - + + ]
678 : 2491 : Txid txid = Txid::FromUint256(ParseHashO(input, "txid"));
679 : :
680 : 2491 : const UniValue& vout_v = input.find_value("vout");
681 [ + + ]: 2491 : if (!vout_v.isNum()) {
682 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
683 : : }
684 : 2490 : int vout = vout_v.getInt<int>();
685 [ + + ]: 2490 : if (vout < 0) {
686 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
687 : : }
688 : :
689 : 2489 : const UniValue& weight_v = input.find_value("weight");
690 [ + + ]: 2489 : if (!weight_v.isNum()) {
691 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing weight key");
692 : : }
693 : 2488 : int64_t weight = weight_v.getInt<int64_t>();
694 : 2488 : const int64_t min_input_weight = GetTransactionInputWeight(CTxIn());
695 : 2488 : CHECK_NONFATAL(min_input_weight == 165);
696 [ + + ]: 2488 : if (weight < min_input_weight) {
697 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, weight cannot be less than 165 (41 bytes (size of outpoint + sequence + empty scriptSig) * 4 (witness scaling factor)) + 1 (empty witness)");
698 : : }
699 [ + + ]: 2486 : if (weight > MAX_STANDARD_TX_WEIGHT) {
700 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid parameter, weight cannot be greater than the maximum standard tx weight of %d", MAX_STANDARD_TX_WEIGHT));
701 : : }
702 : :
703 : 2485 : coinControl.SetInputWeight(COutPoint(txid, vout), weight);
704 : : }
705 : : }
706 : :
707 [ + + ]: 832 : if (options.exists("max_tx_weight")) {
708 [ + - + - ]: 8 : coinControl.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
709 : : }
710 : :
711 [ - + ]: 416 : if (recipients.empty())
712 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
713 : :
714 [ + - ]: 416 : auto txr = FundTransaction(wallet, tx, recipients, change_position, lockUnspents, coinControl);
715 [ + + ]: 416 : if (!txr) {
716 [ + - + - ]: 138 : throw JSONRPCError(RPC_WALLET_ERROR, ErrorString(txr).original);
717 : : }
718 : 347 : return *txr;
719 [ + - + - : 888 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - + ]
720 : :
721 : 393 : static void SetOptionsInputWeights(const UniValue& inputs, UniValue& options)
722 : : {
723 [ + + ]: 786 : if (options.exists("input_weights")) {
724 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Input weights should be specified in inputs rather than in options.");
725 : : }
726 [ + + ]: 391 : if (inputs.size() == 0) {
727 : : return;
728 : : }
729 : 139 : UniValue weights(UniValue::VARR);
730 [ + - + + ]: 2892 : for (const UniValue& input : inputs.getValues()) {
731 [ + - + + ]: 5506 : if (input.exists("weight")) {
732 [ + - + - ]: 6 : weights.push_back(input);
733 : : }
734 : : }
735 [ + - + - ]: 278 : options.pushKV("input_weights", std::move(weights));
736 : 139 : }
737 : :
738 : 950 : RPCHelpMan fundrawtransaction()
739 : : {
740 : 950 : return RPCHelpMan{"fundrawtransaction",
741 : : "\nIf the transaction has no inputs, they will be automatically selected to meet its out value.\n"
742 : : "It will add at most one change output to the outputs.\n"
743 : : "No existing outputs will be modified unless \"subtractFeeFromOutputs\" is specified.\n"
744 : : "Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.\n"
745 : : "The inputs added will not be signed, use signrawtransactionwithkey\n"
746 : : "or signrawtransactionwithwallet for that.\n"
747 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
748 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n"
749 : : "Note that all inputs selected must be of standard form and P2SH scripts must be\n"
750 : : "in the wallet using importaddress or addmultisigaddress (to calculate fees).\n"
751 : : "You can see whether this is the case by checking the \"solvable\" field in the listunspent output.\n"
752 : : "Only pay-to-pubkey, multisig, and P2SH versions thereof are currently supported for watch-only\n",
753 : : {
754 [ + - ]: 950 : {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"},
755 [ + - ]: 950 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "For backward compatibility: passing in a true instead of an object will result in {\"includeWatching\":true}",
756 [ + - + - : 76000 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + +
+ - - - -
- - - - ]
757 : : {
758 [ + - ]: 1900 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::Default{true}, "For a transaction with existing inputs, automatically include more if they are not enough."},
759 [ + - ]: 1900 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
760 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
761 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
762 [ + - ]: 1900 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
763 [ + - ]: 950 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
764 [ + - ]: 1900 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
765 [ + - ]: 1900 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
766 [ + - ]: 1900 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
767 [ + - ]: 1900 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
768 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
769 : : "e.g. with 'importpubkey' or 'importmulti' with the 'pubkeys' or 'desc' field."},
770 [ + - ]: 1900 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
771 [ + - + - ]: 3800 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
772 [ + - + - ]: 3800 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
773 : 1900 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The integers.\n"
774 : : "The fee will be equally deducted from the amount of each specified output.\n"
775 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
776 : : "If no outputs are specified here, the sender pays the fee.",
777 : : {
778 [ + - ]: 950 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
779 : : },
780 : : },
781 [ + - ]: 950 : {"input_weights", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Inputs and their corresponding weights",
782 : : {
783 [ + - ]: 950 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
784 : : {
785 [ + - ]: 950 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
786 [ + - ]: 950 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output index"},
787 [ + - ]: 950 : {"weight", RPCArg::Type::NUM, RPCArg::Optional::NO, "The maximum weight for this input, "
788 : : "including the weight of the outpoint and sequence number. "
789 : : "Note that serialized signature sizes are not guaranteed to be consistent, "
790 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
791 : : "Remember to convert serialized sizes to weight units when necessary."},
792 : : },
793 : : },
794 : : },
795 : : },
796 [ + - ]: 1900 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
797 : : "Transaction building will fail if this can not be satisfied."},
798 : : },
799 [ + - ]: 1900 : FundTxDoc()),
800 [ + - + - ]: 1900 : RPCArgOptions{
801 : : .skip_type_check = true,
802 : : .oneline_description = "options",
803 : : }},
804 [ + - ]: 1900 : {"iswitness", RPCArg::Type::BOOL, RPCArg::DefaultHint{"depends on heuristic tests"}, "Whether the transaction hex is a serialized witness transaction.\n"
805 : : "If iswitness is not present, heuristic tests will be used in decoding.\n"
806 : : "If true, only witness deserialization will be tried.\n"
807 : : "If false, only non-witness deserialization will be tried.\n"
808 : : "This boolean should reflect whether the transaction has inputs\n"
809 : : "(e.g. fully valid, or on-chain transactions), if known by the caller."
810 : : },
811 : : },
812 : 0 : RPCResult{
813 : : RPCResult::Type::OBJ, "", "",
814 : : {
815 : : {RPCResult::Type::STR_HEX, "hex", "The resulting raw transaction (hex-encoded string)"},
816 [ + - ]: 1900 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
817 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
818 : : }
819 [ + - + - : 6650 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
820 : 950 : RPCExamples{
821 : : "\nCreate a transaction with no inputs\n"
822 [ + - + - : 1900 : + HelpExampleCli("createrawtransaction", "\"[]\" \"{\\\"myaddress\\\":0.01}\"") +
+ - + - ]
823 : 950 : "\nAdd sufficient unsigned inputs to meet the output value\n"
824 [ + - + - : 3800 : + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
+ - + - ]
825 : 950 : "\nSign the transaction\n"
826 [ + - + - : 3800 : + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
+ - + - ]
827 : 950 : "\nSend the transaction\n"
828 [ + - + - : 3800 : + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ - + - ]
829 [ + - ]: 950 : },
830 : 184 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
831 : : {
832 : 184 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
833 [ - + ]: 184 : if (!pwallet) return UniValue::VNULL;
834 : :
835 : : // parse hex string from parameter
836 [ + - ]: 184 : CMutableTransaction tx;
837 [ + - - + : 184 : bool try_witness = request.params[2].isNull() ? true : request.params[2].get_bool();
- - - - ]
838 [ + - - + : 184 : bool try_no_witness = request.params[2].isNull() ? true : !request.params[2].get_bool();
- - - - ]
839 [ + - + - : 184 : if (!DecodeHexTx(tx, request.params[0].get_str(), try_no_witness, try_witness)) {
+ - - + ]
840 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
841 : : }
842 [ + - + - ]: 184 : UniValue options = request.params[1];
843 : 184 : std::vector<std::pair<CTxDestination, CAmount>> destinations;
844 [ + + ]: 11982 : for (const auto& tx_out : tx.vout) {
845 : 11798 : CTxDestination dest;
846 [ + - ]: 11798 : ExtractDestination(tx_out.scriptPubKey, dest);
847 [ + - ]: 11798 : destinations.emplace_back(dest, tx_out.nValue);
848 : 11798 : }
849 [ + - + - ]: 184 : std::vector<std::string> dummy(destinations.size(), "dummy");
850 [ + - ]: 184 : std::vector<CRecipient> recipients = CreateRecipients(
851 : : destinations,
852 [ + - + - : 368 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], dummy)
+ - ]
853 [ + - ]: 184 : );
854 [ + - ]: 184 : CCoinControl coin_control;
855 : : // Automatically select (additional) coins. Can be overridden by options.add_inputs.
856 : 184 : coin_control.m_allow_other_inputs = true;
857 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
858 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
859 : 184 : tx.vout.clear();
860 [ + + ]: 184 : auto txr = FundTransaction(*pwallet, tx, recipients, options, coin_control, /*override_min_fee=*/true);
861 : :
862 : 105 : UniValue result(UniValue::VOBJ);
863 [ + - + - : 210 : result.pushKV("hex", EncodeHexTx(*txr.tx));
+ - + - ]
864 [ + - + - : 210 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
865 [ + + + - : 210 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
866 : :
867 : 105 : return result;
868 [ + - ]: 894 : },
869 [ + - + - : 16150 : };
+ - + - +
- + - + -
+ - + - +
- + + -
- ]
870 [ + - + - : 45600 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
871 : :
872 : 1056 : RPCHelpMan signrawtransactionwithwallet()
873 : : {
874 : 1056 : return RPCHelpMan{"signrawtransactionwithwallet",
875 : : "\nSign inputs for raw transaction (serialized, hex-encoded).\n"
876 : : "The second optional argument (may be null) is an array of previous transaction outputs that\n"
877 : 1056 : "this transaction depends on but may not yet be in the block chain." +
878 [ + - ]: 1056 : HELP_REQUIRING_PASSPHRASE,
879 : : {
880 [ + - ]: 1056 : {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"},
881 [ + - ]: 1056 : {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",
882 : : {
883 [ + - ]: 1056 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
884 : : {
885 [ + - ]: 1056 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
886 [ + - ]: 1056 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
887 [ + - ]: 1056 : {"scriptPubKey", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The output script"},
888 [ + - ]: 1056 : {"redeemScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2SH) redeem script"},
889 [ + - ]: 1056 : {"witnessScript", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "(required for P2WSH or P2SH-P2WSH) witness script"},
890 [ + - ]: 1056 : {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::OMITTED, "(required for Segwit inputs) the amount spent"},
891 : : },
892 : : },
893 : : },
894 : : },
895 [ + - ]: 2112 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type. Must be one of\n"
896 : : " \"DEFAULT\"\n"
897 : : " \"ALL\"\n"
898 : : " \"NONE\"\n"
899 : : " \"SINGLE\"\n"
900 : : " \"ALL|ANYONECANPAY\"\n"
901 : : " \"NONE|ANYONECANPAY\"\n"
902 : : " \"SINGLE|ANYONECANPAY\""},
903 : : },
904 : 0 : RPCResult{
905 : : RPCResult::Type::OBJ, "", "",
906 : : {
907 : : {RPCResult::Type::STR_HEX, "hex", "The hex-encoded raw transaction with signature(s)"},
908 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
909 : : {RPCResult::Type::ARR, "errors", /*optional=*/true, "Script verification errors (if there are any)",
910 : : {
911 : : {RPCResult::Type::OBJ, "", "",
912 : : {
913 : : {RPCResult::Type::STR_HEX, "txid", "The hash of the referenced, previous transaction"},
914 : : {RPCResult::Type::NUM, "vout", "The index of the output to spent and used as input"},
915 : : {RPCResult::Type::ARR, "witness", "",
916 : : {
917 : : {RPCResult::Type::STR_HEX, "witness", ""},
918 : : }},
919 : : {RPCResult::Type::STR_HEX, "scriptSig", "The hex-encoded signature script"},
920 : : {RPCResult::Type::NUM, "sequence", "Script sequence number"},
921 : : {RPCResult::Type::STR, "error", "Verification or signing error related to the input"},
922 : : }},
923 : : }},
924 : : }
925 [ + - + - : 16896 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ + + - -
- - - - -
- ]
926 : 1056 : RPCExamples{
927 [ + - + - : 2112 : HelpExampleCli("signrawtransactionwithwallet", "\"myhex\"")
+ - ]
928 [ + - + - : 4224 : + HelpExampleRpc("signrawtransactionwithwallet", "\"myhex\"")
+ - + - ]
929 [ + - ]: 1056 : },
930 : 290 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
931 : : {
932 [ - + ]: 290 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
933 [ - + ]: 290 : if (!pwallet) return UniValue::VNULL;
934 : :
935 [ + - ]: 290 : CMutableTransaction mtx;
936 [ + - + - : 290 : if (!DecodeHexTx(mtx, request.params[0].get_str())) {
+ - - + ]
937 [ # # # # ]: 0 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed. Make sure the tx has at least one input.");
938 : : }
939 : :
940 : : // Sign the transaction
941 [ + - ]: 290 : LOCK(pwallet->cs_wallet);
942 [ + + ]: 290 : EnsureWalletIsUnlocked(*pwallet);
943 : :
944 : : // Fetch previous transactions (inputs):
945 : 289 : std::map<COutPoint, Coin> coins;
946 [ + + ]: 1034 : for (const CTxIn& txin : mtx.vin) {
947 [ + - ]: 745 : coins[txin.prevout]; // Create empty map entry keyed by prevout.
948 : : }
949 [ + - ]: 289 : pwallet->chain().findCoins(coins);
950 : :
951 : : // Parse the prevtxs array
952 [ + - + + ]: 289 : ParsePrevouts(request.params[1], nullptr, coins);
953 : :
954 [ + - + + ]: 280 : int nHashType = ParseSighashString(request.params[2]);
955 : :
956 : : // Script verification errors
957 [ + - ]: 279 : std::map<int, bilingual_str> input_errors;
958 : :
959 [ + - ]: 279 : bool complete = pwallet->SignTransaction(mtx, coins, nHashType, input_errors);
960 : 279 : UniValue result(UniValue::VOBJ);
961 [ + + ]: 279 : SignTransactionResultToJSON(mtx, complete, coins, input_errors, result);
962 : 277 : return result;
963 [ + - ]: 1150 : },
964 [ + - + - : 42240 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - ]
965 [ + - + - : 34848 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - -
- ]
966 : :
967 : : // Definition of allowed formats of specifying transaction outputs in
968 : : // `bumpfee`, `psbtbumpfee`, `send` and `walletcreatefundedpsbt` RPCs.
969 : 3622 : static std::vector<RPCArg> OutputsDoc()
970 : : {
971 : 3622 : return
972 : : {
973 [ + - ]: 3622 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
974 : : {
975 [ + - ]: 3622 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address,\n"
976 : 3622 : "the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
977 : : },
978 : : },
979 [ + - ]: 3622 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
980 : : {
981 [ + - ]: 3622 : {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A key-value pair. The key must be \"data\", the value is hex-encoded data"},
982 : : },
983 : : },
984 [ + - + - : 50708 : };
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
985 [ + - + - : 32598 : }
+ - + - +
- - - ]
986 : :
987 : 1691 : static RPCHelpMan bumpfee_helper(std::string method_name)
988 : : {
989 : 1691 : const bool want_psbt = method_name == "psbtbumpfee";
990 : 1691 : const std::string incremental_fee{CFeeRate(DEFAULT_INCREMENTAL_RELAY_FEE).ToString(FeeEstimateMode::SAT_VB)};
991 : :
992 : 1691 : return RPCHelpMan{method_name,
993 : : "\nBumps the fee of an opt-in-RBF transaction T, replacing it with a new transaction B.\n"
994 [ + + + - : 4300 : + std::string(want_psbt ? "Returns a PSBT instead of creating and signing a new transaction.\n" : "") +
+ - ]
995 : : "An opt-in RBF transaction with the given txid must be in the wallet.\n"
996 : : "The command will pay the additional fee by reducing change outputs or adding inputs when necessary.\n"
997 : : "It may add a new change output if one does not already exist.\n"
998 : : "All inputs in the original transaction will be included in the replacement transaction.\n"
999 : : "The command will fail if the wallet or mempool contains a transaction that spends one of T's outputs.\n"
1000 : : "By default, the new fee will be calculated automatically using the estimatesmartfee RPC.\n"
1001 : : "The user can specify a confirmation target for estimatesmartfee.\n"
1002 [ + - ]: 3382 : "Alternatively, the user can specify a fee rate in " + CURRENCY_ATOM + "/vB for the new transaction.\n"
1003 : : "At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee\n"
1004 : : "returned by getnetworkinfo) to enter the node's mempool.\n"
1005 [ + - + - ]: 5073 : "* WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB. *\n",
1006 : : {
1007 [ + - ]: 1691 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The txid to be bumped"},
1008 [ + - ]: 1691 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1009 : : {
1010 [ + - ]: 3382 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks\n"},
1011 [ + - ]: 3382 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"},
1012 : 1691 : "\nSpecify a fee rate in " + CURRENCY_ATOM + "/vB instead of relying on the built-in fee estimator.\n"
1013 [ + - ]: 3382 : "Must be at least " + incremental_fee + " higher than the current transaction fee rate.\n"
1014 [ + - + - ]: 5073 : "WARNING: before version 0.21, fee_rate was in " + CURRENCY_UNIT + "/kvB. As of 0.21, fee_rate is in " + CURRENCY_ATOM + "/vB.\n"},
1015 [ + - ]: 3382 : {"replaceable", RPCArg::Type::BOOL, RPCArg::Default{true}, "Whether the new transaction should still be\n"
1016 : : "marked bip-125 replaceable. If true, the sequence numbers in the transaction will\n"
1017 : : "be left unchanged from the original. If false, any input sequence numbers in the\n"
1018 : : "original transaction that were less than 0xfffffffe will be increased to 0xfffffffe\n"
1019 : : "so the new transaction will not be explicitly bip-125 replaceable (though it may\n"
1020 : : "still be replaceable in practice, for example if it has unconfirmed ancestors which\n"
1021 : : "are replaceable).\n"},
1022 [ + - ]: 3382 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1023 [ + - + - ]: 3382 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1024 : 3382 : {"outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs specified as key-value pairs.\n"
1025 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1026 : : "At least one output of either type must be specified.\n"
1027 : : "Cannot be provided if 'original_change_index' is specified.",
1028 [ + - ]: 3382 : OutputsDoc(),
1029 [ + - ]: 3382 : RPCArgOptions{.skip_type_check = true}},
1030 [ + - ]: 3382 : {"original_change_index", RPCArg::Type::NUM, RPCArg::DefaultHint{"not set, detect change automatically"}, "The 0-based index of the change output on the original transaction. "
1031 : : "The indicated output will be recycled into the new change output on the bumped transaction. "
1032 : : "The remainder after paying the recipients and fees will be sent to the output script of the "
1033 : : "original change output. The change output’s amount can increase if bumping the transaction "
1034 : : "adds new inputs, otherwise it will decrease. Cannot be used in combination with the 'outputs' option."},
1035 : : },
1036 [ + - + - ]: 1691 : RPCArgOptions{.oneline_description="options"}},
1037 : : },
1038 : 0 : RPCResult{
1039 [ + - + - : 15219 : RPCResult::Type::OBJ, "", "", Cat(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1040 [ + + + - : 8455 : want_psbt ?
+ - + + +
+ + + + +
- - - - -
- - - ]
1041 [ + - + - : 4783 : std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
+ - + + +
+ + + - -
- - - - ]
1042 [ + - + - : 5363 : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
+ - + + +
+ + + - -
- - - - ]
1043 : : {
1044 : : {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
1045 : : {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
1046 : : {RPCResult::Type::ARR, "errors", "Errors encountered during processing (may be empty).",
1047 : : {
1048 : : {RPCResult::Type::STR, "", ""},
1049 : : }},
1050 : : })
1051 [ + - + - : 5073 : },
+ - ]
1052 : 1691 : RPCExamples{
1053 [ + + + - : 4300 : "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
+ - ]
1054 [ + - + - : 5073 : HelpExampleCli(method_name, "<txid>")
+ - ]
1055 : 1691 : },
1056 [ + - ]: 1691 : [want_psbt](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1057 : : {
1058 : 159 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1059 [ - + ]: 159 : if (!pwallet) return UniValue::VNULL;
1060 : :
1061 [ + - + + : 159 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS) && !pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER) && !want_psbt) {
+ - + + +
+ ]
1062 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "bumpfee is not available with wallets that have private keys disabled. Use psbtbumpfee instead.");
1063 : : }
1064 : :
1065 [ + - + - ]: 158 : uint256 hash(ParseHashV(request.params[0], "txid"));
1066 : :
1067 [ + - ]: 158 : CCoinControl coin_control;
1068 [ + - ]: 158 : coin_control.fAllowWatchOnly = pwallet->IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS);
1069 : : // optional parameters
1070 [ + - ]: 158 : coin_control.m_signal_bip125_rbf = true;
1071 : 158 : std::vector<CTxOut> outputs;
1072 : :
1073 : 158 : std::optional<uint32_t> original_change_index;
1074 : :
1075 [ + - + + ]: 158 : if (!request.params[1].isNull()) {
1076 [ + - + - ]: 67 : UniValue options = request.params[1];
1077 [ + + + + : 607 : RPCTypeCheckObj(options,
+ + ]
1078 : : {
1079 [ + - ]: 67 : {"confTarget", UniValueType(UniValue::VNUM)},
1080 [ + - ]: 67 : {"conf_target", UniValueType(UniValue::VNUM)},
1081 [ + - ]: 67 : {"fee_rate", UniValueType()}, // will be checked by AmountFromValue() in SetFeeEstimateMode()
1082 [ + - ]: 67 : {"replaceable", UniValueType(UniValue::VBOOL)},
1083 [ + - ]: 67 : {"estimate_mode", UniValueType(UniValue::VSTR)},
1084 [ + - ]: 67 : {"outputs", UniValueType()}, // will be checked by AddOutputs()
1085 [ + - ]: 67 : {"original_change_index", UniValueType(UniValue::VNUM)},
1086 : : },
1087 : : true, true);
1088 : :
1089 [ + - + - : 127 : if (options.exists("confTarget") && options.exists("conf_target")) {
+ + + - +
- + - + +
- - ]
1090 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "confTarget and conf_target options should not both be set. Use conf_target (confTarget is deprecated).");
1091 : : }
1092 : :
1093 [ + - - + : 186 : auto conf_target = options.exists("confTarget") ? options["confTarget"] : options["conf_target"];
- - - - +
- + - + -
+ - - + -
- - - ]
1094 : :
1095 [ + - + + ]: 124 : if (options.exists("replaceable")) {
1096 [ + - + - : 1 : coin_control.m_signal_bip125_rbf = options["replaceable"].get_bool();
+ - ]
1097 : : }
1098 [ + - + - : 143 : SetFeeEstimateMode(*pwallet, coin_control, conf_target, options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
+ ]
1099 : :
1100 : : // Prepare new outputs by creating a temporary tx and calling AddOutputs().
1101 [ + - + - : 43 : if (!options["outputs"].isNull()) {
+ + ]
1102 [ + - + - : 31 : if (options["outputs"].isArray() && options["outputs"].empty()) {
+ + + - +
- + + + +
- - ]
1103 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, output argument cannot be an empty array");
1104 : : }
1105 [ + - ]: 10 : CMutableTransaction tempTx;
1106 [ + - + - : 12 : AddOutputs(tempTx, options["outputs"]);
+ + ]
1107 [ + - ]: 8 : outputs = tempTx.vout;
1108 : 10 : }
1109 : :
1110 [ + - + + ]: 80 : if (options.exists("original_change_index")) {
1111 [ + - + - : 7 : original_change_index = options["original_change_index"].getInt<uint32_t>();
+ + ]
1112 : : }
1113 : 90 : }
1114 : :
1115 : : // Make sure the results are valid at least up to the most recent block
1116 : : // the user could have gotten from another RPC command prior to now
1117 [ + - ]: 130 : pwallet->BlockUntilSyncedToCurrentChain();
1118 : :
1119 [ + - ]: 130 : LOCK(pwallet->cs_wallet);
1120 : :
1121 [ + + ]: 130 : EnsureWalletIsUnlocked(*pwallet);
1122 : :
1123 : :
1124 : 129 : std::vector<bilingual_str> errors;
1125 : 129 : CAmount old_fee;
1126 : 129 : CAmount new_fee;
1127 [ + - ]: 129 : CMutableTransaction mtx;
1128 : 129 : feebumper::Result res;
1129 : : // Targeting feerate bump.
1130 [ + - ]: 129 : res = feebumper::CreateRateBumpTransaction(*pwallet, hash, coin_control, errors, old_fee, new_fee, mtx, /*require_mine=*/ !want_psbt, outputs, original_change_index);
1131 [ + + ]: 129 : if (res != feebumper::Result::OK) {
1132 [ - - + + : 25 : switch(res) {
+ ]
1133 : 0 : case feebumper::Result::INVALID_ADDRESS_OR_KEY:
1134 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, errors[0].original);
1135 : 0 : break;
1136 : 0 : case feebumper::Result::INVALID_REQUEST:
1137 [ # # ]: 0 : throw JSONRPCError(RPC_INVALID_REQUEST, errors[0].original);
1138 : 16 : break;
1139 : 16 : case feebumper::Result::INVALID_PARAMETER:
1140 [ + - ]: 16 : throw JSONRPCError(RPC_INVALID_PARAMETER, errors[0].original);
1141 : 8 : break;
1142 : 8 : case feebumper::Result::WALLET_ERROR:
1143 [ + - ]: 8 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1144 : 1 : break;
1145 : 1 : default:
1146 [ + - ]: 1 : throw JSONRPCError(RPC_MISC_ERROR, errors[0].original);
1147 : 104 : break;
1148 : : }
1149 : : }
1150 : :
1151 : 208 : UniValue result(UniValue::VOBJ);
1152 : :
1153 : : // For bumpfee, return the new transaction id.
1154 : : // For psbtbumpfee, return the base64-encoded unsigned PSBT of the new transaction.
1155 [ + + ]: 104 : if (!want_psbt) {
1156 [ + - - + ]: 97 : if (!feebumper::SignTransaction(*pwallet, mtx)) {
1157 [ # # # # ]: 0 : if (pwallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) {
1158 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction incomplete. Try psbtbumpfee instead.");
1159 : : }
1160 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Can't sign transaction.");
1161 : : }
1162 : :
1163 : 97 : uint256 txid;
1164 [ + - - + ]: 97 : if (feebumper::CommitTransaction(*pwallet, hash, std::move(mtx), errors, txid) != feebumper::Result::OK) {
1165 [ # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, errors[0].original);
1166 : : }
1167 : :
1168 [ + - + - : 194 : result.pushKV("txid", txid.GetHex());
+ - + - ]
1169 : : } else {
1170 [ + - ]: 7 : PartiallySignedTransaction psbtx(mtx);
1171 : 7 : bool complete = false;
1172 [ + - ]: 7 : const auto err{pwallet->FillPSBT(psbtx, complete, SIGHASH_DEFAULT, /*sign=*/false, /*bip32derivs=*/true)};
1173 [ + - ]: 7 : CHECK_NONFATAL(!err);
1174 [ + - ]: 7 : CHECK_NONFATAL(!complete);
1175 : 7 : DataStream ssTx{};
1176 [ + - ]: 7 : ssTx << psbtx;
1177 [ + - + - : 14 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1178 : 7 : }
1179 : :
1180 [ + - + - : 208 : result.pushKV("origfee", ValueFromAmount(old_fee));
+ - ]
1181 [ + - + - : 208 : result.pushKV("fee", ValueFromAmount(new_fee));
+ - ]
1182 : 208 : UniValue result_errors(UniValue::VARR);
1183 [ - + ]: 104 : for (const bilingual_str& error : errors) {
1184 [ # # # # ]: 0 : result_errors.push_back(error.original);
1185 : : }
1186 [ + - + - ]: 208 : result.pushKV("errors", std::move(result_errors));
1187 : :
1188 : 104 : return result;
1189 [ + - + - : 516 : },
+ - + - +
- + - + -
+ - + - -
+ ]
1190 [ + - + - : 74404 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + - - -
- ]
1191 [ + - + - : 38893 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - ]
1192 : :
1193 [ + - ]: 1836 : RPCHelpMan bumpfee() { return bumpfee_helper("bumpfee"); }
1194 [ + - ]: 1546 : RPCHelpMan psbtbumpfee() { return bumpfee_helper("psbtbumpfee"); }
1195 : :
1196 : 968 : RPCHelpMan send()
1197 : : {
1198 : 968 : return RPCHelpMan{"send",
1199 : : "\nEXPERIMENTAL warning: this call may be changed in future releases.\n"
1200 : : "\nSend a transaction.\n",
1201 : : {
1202 [ + - ]: 968 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1203 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1204 : : "At least one output of either type must be specified.\n"
1205 : : "For convenience, a dictionary, which holds the key-value pairs directly, is also accepted.",
1206 [ + - ]: 1936 : OutputsDoc(),
1207 [ + - ]: 1936 : RPCArgOptions{.skip_type_check = true}},
1208 [ + - ]: 1936 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1209 [ + - ]: 1936 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1210 [ + - + - ]: 1936 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1211 [ + - ]: 2904 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1212 [ + - ]: 968 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1213 [ + - + - : 91960 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + + + +
+ + - - -
- - - ]
1214 : : {
1215 [ + - ]: 1936 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"},"Automatically include coins from the wallet to cover the target amount.\n"},
1216 [ + - ]: 1936 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1217 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1218 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1219 [ + - ]: 1936 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1220 [ + - ]: 968 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1221 [ + - ]: 1936 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns a serialized transaction which will not be added to the wallet or broadcast"},
1222 [ + - ]: 1936 : {"change_address", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1223 [ + - ]: 1936 : {"change_position", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1224 [ + - ]: 1936 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if change_address is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\" and \"bech32m\"."},
1225 [ + - + - : 4840 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1226 [ + - ]: 1936 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
1227 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1228 : : "e.g. with 'importpubkey' or 'importmulti' with the 'pubkeys' or 'desc' field."},
1229 : 1936 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically. A JSON array of JSON objects",
1230 : : {
1231 [ + - ]: 968 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1232 [ + - ]: 968 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1233 [ + - ]: 968 : {"sequence", RPCArg::Type::NUM, RPCArg::Optional::NO, "The sequence number"},
1234 [ + - ]: 1936 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1235 : : "including the weight of the outpoint and sequence number. "
1236 : : "Note that signature sizes are not guaranteed to be consistent, "
1237 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1238 : : "Remember to convert serialized sizes to weight units when necessary."},
1239 : : },
1240 : : },
1241 [ + - ]: 1936 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1242 [ + - ]: 1936 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1243 [ + - ]: 1936 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1244 : 1936 : {"subtract_fee_from_outputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Outputs to subtract the fee from, specified as integer indices.\n"
1245 : : "The fee will be equally deducted from the amount of each specified output.\n"
1246 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1247 : : "If no outputs are specified here, the sender pays the fee.",
1248 : : {
1249 [ + - ]: 968 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1250 : : },
1251 : : },
1252 [ + - ]: 1936 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1253 : : "Transaction building will fail if this can not be satisfied."},
1254 : : },
1255 [ + - ]: 1936 : FundTxDoc()),
1256 [ + - + - ]: 1936 : RPCArgOptions{.oneline_description="options"}},
1257 : : },
1258 : 0 : RPCResult{
1259 : : RPCResult::Type::OBJ, "", "",
1260 : : {
1261 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1262 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1263 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1264 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1265 : : }
1266 [ + - + - : 5808 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1267 : 968 : RPCExamples{""
1268 : : "\nSend 0.1 BTC with a confirmation target of 6 blocks in economical fee estimate mode\n"
1269 [ + - + - : 2904 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 6 economical\n") +
+ - + - ]
1270 [ + - ]: 1936 : "Send 0.2 BTC with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1271 [ + - + - : 4840 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" 1.1\n") +
+ - + - ]
1272 [ + - ]: 1936 : "Send 0.2 BTC with a fee rate of 1 " + CURRENCY_ATOM + "/vB using the options argument\n"
1273 [ + - + - : 4840 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.2}' null \"unset\" null '{\"fee_rate\": 1}'\n") +
+ - + - ]
1274 [ + - ]: 1936 : "Send 0.3 BTC with a fee rate of 25 " + CURRENCY_ATOM + "/vB using named arguments\n"
1275 [ + - + - : 4840 : + HelpExampleCli("-named send", "outputs='{\"" + EXAMPLE_ADDRESS[0] + "\": 0.3}' fee_rate=25\n") +
+ - + - ]
1276 : 968 : "Create a transaction that should confirm the next block, with a specific input, and return result without adding to wallet or broadcasting to the network\n"
1277 [ + - + - : 4840 : + HelpExampleCli("send", "'{\"" + EXAMPLE_ADDRESS[0] + "\": 0.1}' 1 economical '{\"add_to_wallet\": false, \"inputs\": [{\"txid\":\"a08e6907dbbd3d809776dbfc5d82e371b764ed838b5655e72f463568df1aadf0\", \"vout\":1}]}'")
+ - + - ]
1278 [ + - ]: 968 : },
1279 : 202 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1280 : : {
1281 : 202 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1282 [ - + ]: 202 : if (!pwallet) return UniValue::VNULL;
1283 : :
1284 [ + - + + : 202 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1285 [ + - + - : 202 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + + ]
1286 [ + + ]: 198 : PreventOutdatedOptions(options);
1287 : :
1288 : :
1289 [ + - + + : 394 : bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
+ - + - +
- ]
1290 : 197 : UniValue outputs(UniValue::VOBJ);
1291 [ + - + - ]: 197 : outputs = NormalizeOutputs(request.params[0]);
1292 : 197 : std::vector<CRecipient> recipients = CreateRecipients(
1293 [ + + ]: 393 : ParseOutputs(outputs),
1294 [ + - + - : 395 : InterpretSubtractFeeFromOutputInstructions(options["subtract_fee_from_outputs"], outputs.getKeys())
+ - + - ]
1295 [ + - ]: 196 : );
1296 [ + - + - : 392 : CMutableTransaction rawTx = ConstructTransaction(options["inputs"], request.params[0], options["locktime"], rbf);
+ - + - +
- + - ]
1297 [ + - ]: 196 : CCoinControl coin_control;
1298 : : // Automatically select coins, unless at least one is manually selected. Can
1299 : : // be overridden by options.add_inputs.
1300 [ + - ]: 196 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1301 [ + - - + ]: 392 : if (options.exists("max_tx_weight")) {
1302 [ # # # # : 0 : coin_control.m_max_tx_weight = options["max_tx_weight"].getInt<int>();
# # ]
1303 : : }
1304 [ + - + - : 197 : SetOptionsInputWeights(options["inputs"], options);
+ + ]
1305 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1306 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1307 : 195 : rawTx.vout.clear();
1308 [ + + ]: 195 : auto txr = FundTransaction(*pwallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/false);
1309 : :
1310 [ + - + - : 456 : return FinishTransaction(pwallet, options, CMutableTransaction(*txr.tx));
+ - ]
1311 : 677 : }
1312 [ + - + - : 26136 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ - - ]
1313 [ + - + - : 53240 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
- - - - -
- - - ]
1314 : :
1315 : 864 : RPCHelpMan sendall()
1316 : : {
1317 : 864 : return RPCHelpMan{"sendall",
1318 : : "EXPERIMENTAL warning: this call may be changed in future releases.\n"
1319 : : "\nSpend the value of all (or specific) confirmed UTXOs and unconfirmed change in the wallet to one or more recipients.\n"
1320 : : "Unconfirmed inbound UTXOs and locked UTXOs will not be spent. Sendall will respect the avoid_reuse wallet flag.\n"
1321 : : "If your wallet contains many small inputs, either because it received tiny payments or as a result of accumulating change, consider using `send_max` to exclude inputs that are worth less than the fees needed to spend them.\n",
1322 : : {
1323 [ + - ]: 864 : {"recipients", RPCArg::Type::ARR, RPCArg::Optional::NO, "The sendall destinations. Each address may only appear once.\n"
1324 : : "Optionally some recipients can be specified with an amount to perform payments, but at least one address must appear without a specified amount.\n",
1325 : : {
1326 [ + - ]: 864 : {"address", RPCArg::Type::STR, RPCArg::Optional::NO, "A bitcoin address which receives an equal share of the unspecified amount."},
1327 [ + - ]: 864 : {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
1328 : : {
1329 [ + - ]: 1728 : {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT + ""},
1330 : : },
1331 : : },
1332 : : },
1333 : : },
1334 [ + - ]: 1728 : {"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
1335 [ + - ]: 1728 : {"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
1336 [ + - + - ]: 1728 : + FeeModesDetail(std::string("economical mode is used if the transaction is replaceable;\notherwise, conservative mode is used"))},
1337 [ + - ]: 2592 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1338 : : {
1339 [ + - ]: 864 : "options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1340 [ + - + - : 53568 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1341 : : {
1342 [ + - ]: 1728 : {"add_to_wallet", RPCArg::Type::BOOL, RPCArg::Default{true}, "When false, returns the serialized transaction without broadcasting or adding it to the wallet"},
1343 [ + - + - : 4320 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB.", RPCArgOptions{.also_positional = true}},
+ - ]
1344 [ + - ]: 1728 : {"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch-only.\n"
1345 : : "Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
1346 : : "e.g. with 'importpubkey' or 'importmulti' with the 'pubkeys' or 'desc' field."},
1347 : 1728 : {"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Use exactly the specified inputs to build the transaction. Specifying inputs is incompatible with the send_max, minconf, and maxconf options.",
1348 : : {
1349 [ + - ]: 864 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1350 : : {
1351 [ + - ]: 864 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1352 [ + - ]: 864 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1353 [ + - ]: 1728 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
1354 : : },
1355 : : },
1356 : : },
1357 : : },
1358 [ + - ]: 1728 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1359 [ + - ]: 1728 : {"lock_unspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1360 [ + - ]: 1728 : {"psbt", RPCArg::Type::BOOL, RPCArg::DefaultHint{"automatic"}, "Always return a PSBT, implies add_to_wallet=false."},
1361 [ + - ]: 1728 : {"send_max", RPCArg::Type::BOOL, RPCArg::Default{false}, "When true, only use UTXOs that can pay for their own fees to maximize the output amount. When 'false' (default), no UTXO is left behind. send_max is incompatible with providing specific inputs."},
1362 [ + - ]: 1728 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "Require inputs with at least this many confirmations."},
1363 [ + - ]: 864 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "Require inputs with at most this many confirmations."},
1364 : : },
1365 [ + - ]: 1728 : FundTxDoc()
1366 : : ),
1367 [ + - + - ]: 1728 : RPCArgOptions{.oneline_description="options"}
1368 : : },
1369 : : },
1370 : 0 : RPCResult{
1371 : : RPCResult::Type::OBJ, "", "",
1372 : : {
1373 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1374 : : {RPCResult::Type::STR_HEX, "txid", /*optional=*/true, "The transaction id for the send. Only 1 transaction is created regardless of the number of addresses."},
1375 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "If add_to_wallet is false, the hex-encoded raw transaction with signature(s)"},
1376 : : {RPCResult::Type::STR, "psbt", /*optional=*/true, "If more signatures are needed, or if add_to_wallet is false, the base64-encoded (partially) signed transaction"}
1377 : : }
1378 [ + - + - : 5184 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
- - ]
1379 : 864 : RPCExamples{""
1380 [ + - ]: 1728 : "\nSpend all UTXOs from the wallet with a fee rate of 1Â " + CURRENCY_ATOM + "/vB using named arguments\n"
1381 [ + - + - : 4320 : + HelpExampleCli("-named sendall", "recipients='[\"" + EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1\n") +
+ - + - ]
1382 [ + - ]: 1728 : "Spend all UTXOs with a fee rate of 1.1 " + CURRENCY_ATOM + "/vB using positional arguments\n"
1383 [ + - + - : 4320 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" 1.1\n") +
+ - + - ]
1384 [ + - ]: 1728 : "Spend all UTXOs split into equal amounts to two addresses with a fee rate of 1.5 " + CURRENCY_ATOM + "/vB using the options argument\n"
1385 [ + - + - : 5184 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\", \"" + EXAMPLE_ADDRESS[1] + "\"]' null \"unset\" null '{\"fee_rate\": 1.5}'\n") +
+ - + - +
- ]
1386 [ + - ]: 1728 : "Leave dust UTXOs in wallet, spend only UTXOs with positive effective value with a fee rate of 10 " + CURRENCY_ATOM + "/vB using the options argument\n"
1387 [ + - + - : 4320 : + HelpExampleCli("sendall", "'[\"" + EXAMPLE_ADDRESS[0] + "\"]' null \"unset\" null '{\"fee_rate\": 10, \"send_max\": true}'\n") +
+ - + - ]
1388 [ + - + - ]: 2592 : "Spend all UTXOs with a fee rate of 1.3 " + CURRENCY_ATOM + "/vB using named arguments and sending a 0.25 " + CURRENCY_UNIT + " to another recipient\n"
1389 [ + - + - : 5184 : + HelpExampleCli("-named sendall", "recipients='[{\"" + EXAMPLE_ADDRESS[1] + "\": 0.25}, \""+ EXAMPLE_ADDRESS[0] + "\"]' fee_rate=1.3\n")
+ - + - +
- ]
1390 [ + - ]: 864 : },
1391 : 98 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1392 : : {
1393 : 98 : std::shared_ptr<CWallet> const pwallet{GetWalletForJSONRPCRequest(request)};
1394 [ - + ]: 98 : if (!pwallet) return UniValue::VNULL;
1395 : : // Make sure the results are valid at least up to the most recent block
1396 : : // the user could have gotten from another RPC command prior to now
1397 [ + - ]: 98 : pwallet->BlockUntilSyncedToCurrentChain();
1398 : :
1399 [ + - + + : 98 : UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+ - + - ]
1400 [ + - + - : 98 : InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
+ - + - ]
1401 [ + - ]: 98 : PreventOutdatedOptions(options);
1402 : :
1403 : :
1404 : 98 : std::set<std::string> addresses_without_amount;
1405 : 98 : UniValue recipient_key_value_pairs(UniValue::VARR);
1406 [ + - ]: 98 : const UniValue& recipients{request.params[0]};
1407 [ + + ]: 209 : for (unsigned int i = 0; i < recipients.size(); ++i) {
1408 [ + - ]: 111 : const UniValue& recipient{recipients[i]};
1409 [ + + ]: 111 : if (recipient.isStr()) {
1410 : 102 : UniValue rkvp(UniValue::VOBJ);
1411 [ + - + - : 204 : rkvp.pushKV(recipient.get_str(), 0);
+ - + - ]
1412 [ + - ]: 102 : recipient_key_value_pairs.push_back(std::move(rkvp));
1413 [ + - + - ]: 102 : addresses_without_amount.insert(recipient.get_str());
1414 : 102 : } else {
1415 [ + - + - ]: 9 : recipient_key_value_pairs.push_back(recipient);
1416 : : }
1417 : : }
1418 : :
1419 [ + + ]: 98 : if (addresses_without_amount.size() == 0) {
1420 [ + - + - ]: 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Must provide at least one address without a specified amount");
1421 : : }
1422 : :
1423 [ + - ]: 96 : CCoinControl coin_control;
1424 : :
1425 [ + - + - : 192 : SetFeeEstimateMode(*pwallet, coin_control, options["conf_target"], options["estimate_mode"], options["fee_rate"], /*override_min_fee=*/false);
+ - + - +
- + - +
- ]
1426 : :
1427 [ + - + - : 96 : coin_control.fAllowWatchOnly = ParseIncludeWatchonly(options["include_watching"], *pwallet);
+ - ]
1428 : :
1429 [ + - + + ]: 192 : if (options.exists("minconf")) {
1430 [ + - + - : 5 : if (options["minconf"].getInt<int>() < 0)
+ - + + ]
1431 : : {
1432 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid minconf (minconf cannot be negative): %s", options["minconf"].getInt<int>()));
+ - + - +
- ]
1433 : : }
1434 : :
1435 [ + - + - : 4 : coin_control.m_min_depth = options["minconf"].getInt<int>();
+ - ]
1436 : : }
1437 : :
1438 [ + - + + ]: 190 : if (options.exists("maxconf")) {
1439 [ + - + - : 2 : coin_control.m_max_depth = options["maxconf"].getInt<int>();
+ - ]
1440 : :
1441 [ - + ]: 2 : if (coin_control.m_max_depth < coin_control.m_min_depth) {
1442 [ # # # # ]: 0 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("maxconf can't be lower than minconf: %d < %d", coin_control.m_max_depth, coin_control.m_min_depth));
1443 : : }
1444 : : }
1445 : :
1446 [ + - - + : 190 : const bool rbf{options.exists("replaceable") ? options["replaceable"].get_bool() : pwallet->m_signal_rbf};
- - - - -
- ]
1447 : :
1448 : 95 : FeeCalculation fee_calc_out;
1449 [ + - ]: 95 : CFeeRate fee_rate{GetMinimumFeeRate(*pwallet, coin_control, &fee_calc_out)};
1450 : : // Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
1451 : : // provided one
1452 [ + + + + ]: 95 : if (coin_control.m_feerate && fee_rate > *coin_control.m_feerate) {
1453 [ + - + - : 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Fee rate (%s) is lower than the minimum fee rate setting (%s)", coin_control.m_feerate->ToString(FeeEstimateMode::SAT_VB), fee_rate.ToString(FeeEstimateMode::SAT_VB)));
+ - + - ]
1454 : : }
1455 [ + + + - ]: 94 : if (fee_calc_out.reason == FeeReason::FALLBACK && !pwallet->m_allow_fallback_fee) {
1456 : : // eventually allow a fallback fee
1457 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_ERROR, "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
1458 : : }
1459 : :
1460 [ + - + - : 189 : CMutableTransaction rawTx{ConstructTransaction(options["inputs"], recipient_key_value_pairs, options["locktime"], rbf)};
+ - + - +
+ ]
1461 [ + - ]: 93 : LOCK(pwallet->cs_wallet);
1462 : :
1463 : 93 : CAmount total_input_value(0);
1464 [ + - + + : 186 : bool send_max{options.exists("send_max") ? options["send_max"].get_bool() : false};
+ - + - +
- ]
1465 [ + - + - : 199 : if (options.exists("inputs") && options.exists("send_max")) {
+ + + - +
- + + + +
- - ]
1466 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine send_max with specific inputs.");
1467 [ + - + - : 207 : } else if (options.exists("inputs") && (options.exists("minconf") || options.exists("maxconf"))) {
+ + + - +
- + + + -
+ - - + +
+ + + - -
- - ]
1468 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, "Cannot combine minconf or maxconf with specific inputs.");
1469 [ + - + + ]: 182 : } else if (options.exists("inputs")) {
1470 [ + + ]: 18 : for (const CTxIn& input : rawTx.vin) {
1471 [ + - + + ]: 11 : if (pwallet->IsSpent(input.prevout)) {
1472 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not available. UTXO (%s:%d) was already spent.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1473 : : }
1474 [ + - ]: 9 : const CWalletTx* tx{pwallet->GetWalletTx(input.prevout.hash)};
1475 [ + + + + : 15 : if (!tx || input.prevout.n >= tx->tx->vout.size() || !(pwallet->IsMine(tx->tx->vout[input.prevout.n]) & (coin_control.fAllowWatchOnly ? ISMINE_ALL : ISMINE_SPENDABLE))) {
+ - + + +
- ]
1476 [ + - + - : 4 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Input not found. UTXO (%s:%d) is not part of wallet.", input.prevout.hash.ToString(), input.prevout.n));
+ - ]
1477 : : }
1478 : 7 : total_input_value += tx->tx->vout[input.prevout.n].nValue;
1479 : : }
1480 : : } else {
1481 : 80 : CoinFilterParams coins_params;
1482 : 80 : coins_params.min_amount = 0;
1483 [ + - + - : 2547 : for (const COutput& output : AvailableCoins(*pwallet, &coin_control, fee_rate, coins_params).All()) {
+ + ]
1484 [ + - ]: 2467 : CHECK_NONFATAL(output.input_bytes > 0);
1485 [ + + + - : 2467 : if (send_max && fee_rate.GetFee(output.input_bytes) > output.txout.nValue) {
+ + ]
1486 : 2 : continue;
1487 : : }
1488 [ + + + - ]: 2467 : CTxIn input(output.outpoint.hash, output.outpoint.n, CScript(), rbf ? MAX_BIP125_RBF_SEQUENCE : CTxIn::SEQUENCE_FINAL);
1489 [ + - ]: 2465 : rawTx.vin.push_back(input);
1490 : 2465 : total_input_value += output.txout.nValue;
1491 : 2545 : }
1492 : : }
1493 : :
1494 : 87 : std::vector<COutPoint> outpoints_spent;
1495 [ + - ]: 87 : outpoints_spent.reserve(rawTx.vin.size());
1496 : :
1497 [ + + ]: 2559 : for (const CTxIn& tx_in : rawTx.vin) {
1498 [ + - ]: 2472 : outpoints_spent.push_back(tx_in.prevout);
1499 : : }
1500 : :
1501 : : // estimate final size of tx
1502 [ + - + - ]: 87 : const TxSize tx_size{CalculateMaximumSignedTxSize(CTransaction(rawTx), pwallet.get())};
1503 [ + - ]: 87 : const CAmount fee_from_size{fee_rate.GetFee(tx_size.vsize)};
1504 [ + - ]: 87 : const std::optional<CAmount> total_bump_fees{pwallet->chain().calculateCombinedBumpFee(outpoints_spent, fee_rate)};
1505 [ + - ]: 87 : CAmount effective_value = total_input_value - fee_from_size - total_bump_fees.value_or(0);
1506 : :
1507 [ + + ]: 87 : if (fee_from_size > pwallet->m_default_max_tx_fee) {
1508 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, TransactionErrorString(TransactionError::MAX_FEE_EXCEEDED).original);
1509 : : }
1510 : :
1511 [ + + ]: 86 : if (effective_value <= 0) {
1512 [ - + ]: 3 : if (send_max) {
1513 [ # # # # ]: 0 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction, try using lower feerate.");
1514 : : } else {
1515 [ + - + - ]: 6 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Total value of UTXO pool too low to pay for transaction. Try using lower feerate or excluding uneconomic UTXOs with 'send_max' option.");
1516 : : }
1517 : : }
1518 : :
1519 : : // If this transaction is too large, e.g. because the wallet has many UTXOs, it will be rejected by the node's mempool.
1520 [ + + ]: 83 : if (tx_size.weight > MAX_STANDARD_TX_WEIGHT) {
1521 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_ERROR, "Transaction too large.");
1522 : : }
1523 : :
1524 : 82 : CAmount output_amounts_claimed{0};
1525 [ + + ]: 177 : for (const CTxOut& out : rawTx.vout) {
1526 : 95 : output_amounts_claimed += out.nValue;
1527 : : }
1528 : :
1529 [ + + ]: 82 : if (output_amounts_claimed > total_input_value) {
1530 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Assigned more value to outputs than available funds.");
1531 : : }
1532 : :
1533 : 81 : const CAmount remainder{effective_value - output_amounts_claimed};
1534 [ + + ]: 81 : if (remainder < 0) {
1535 [ + - + - ]: 2 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Insufficient funds for fees after creating specified outputs.");
1536 : : }
1537 : :
1538 : 80 : const CAmount per_output_without_amount{remainder / (long)addresses_without_amount.size()};
1539 : :
1540 : 80 : bool gave_remaining_to_first{false};
1541 [ + + ]: 167 : for (CTxOut& out : rawTx.vout) {
1542 : 90 : CTxDestination dest;
1543 [ + - ]: 90 : ExtractDestination(out.scriptPubKey, dest);
1544 [ + - ]: 90 : std::string addr{EncodeDestination(dest)};
1545 [ + + ]: 90 : if (addresses_without_amount.count(addr) > 0) {
1546 : 84 : out.nValue = per_output_without_amount;
1547 [ + + ]: 84 : if (!gave_remaining_to_first) {
1548 : 79 : out.nValue += remainder % addresses_without_amount.size();
1549 : 79 : gave_remaining_to_first = true;
1550 : : }
1551 [ + - + - : 84 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1552 : : // Dynamically generated output amount is dust
1553 [ + - + - ]: 4 : throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, "Dynamically assigned remainder results in dust output.");
1554 : : }
1555 : : } else {
1556 [ + - + - : 6 : if (IsDust(out, pwallet->chain().relayDustFee())) {
+ + ]
1557 : : // Specified output amount is dust
1558 [ + - + - ]: 2 : throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", addr));
1559 : : }
1560 : : }
1561 : 93 : }
1562 : :
1563 [ + - + + : 154 : const bool lock_unspents{options.exists("lock_unspents") ? options["lock_unspents"].get_bool() : false};
+ - + - +
- ]
1564 [ + + ]: 77 : if (lock_unspents) {
1565 [ + + ]: 4 : for (const CTxIn& txin : rawTx.vin) {
1566 [ + - ]: 2 : pwallet->LockCoin(txin.prevout);
1567 : : }
1568 : : }
1569 : :
1570 [ + - + - ]: 231 : return FinishTransaction(pwallet, options, rawTx);
1571 [ + - ]: 395 : }
1572 [ + - + - : 31104 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + + + +
+ - - - -
- - ]
1573 [ + - + - : 41472 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - - - -
- - - - -
- - ]
1574 : :
1575 : 1103 : RPCHelpMan walletprocesspsbt()
1576 : : {
1577 : 1103 : return RPCHelpMan{"walletprocesspsbt",
1578 : : "\nUpdate a PSBT with input information from our wallet and then sign inputs\n"
1579 : 1103 : "that we can sign for." +
1580 [ + - ]: 1103 : HELP_REQUIRING_PASSPHRASE,
1581 : : {
1582 [ + - ]: 1103 : {"psbt", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction base64 string"},
1583 [ + - ]: 2206 : {"sign", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also sign the transaction when updating (requires wallet to be unlocked)"},
1584 [ + - ]: 2206 : {"sighashtype", RPCArg::Type::STR, RPCArg::Default{"DEFAULT for Taproot, ALL otherwise"}, "The signature hash type to sign with if not specified by the PSBT. Must be one of\n"
1585 : : " \"DEFAULT\"\n"
1586 : : " \"ALL\"\n"
1587 : : " \"NONE\"\n"
1588 : : " \"SINGLE\"\n"
1589 : : " \"ALL|ANYONECANPAY\"\n"
1590 : : " \"NONE|ANYONECANPAY\"\n"
1591 : : " \"SINGLE|ANYONECANPAY\""},
1592 [ + - ]: 2206 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1593 [ + - ]: 2206 : {"finalize", RPCArg::Type::BOOL, RPCArg::Default{true}, "Also finalize inputs if possible"},
1594 : : },
1595 : 0 : RPCResult{
1596 : : RPCResult::Type::OBJ, "", "",
1597 : : {
1598 : : {RPCResult::Type::STR, "psbt", "The base64-encoded partially signed transaction"},
1599 : : {RPCResult::Type::BOOL, "complete", "If the transaction has a complete set of signatures"},
1600 : : {RPCResult::Type::STR_HEX, "hex", /*optional=*/true, "The hex-encoded network transaction if complete"},
1601 : : }
1602 [ + - + - : 5515 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1603 : 1103 : RPCExamples{
1604 [ + - + - : 2206 : HelpExampleCli("walletprocesspsbt", "\"psbt\"")
+ - ]
1605 [ + - ]: 1103 : },
1606 : 337 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1607 : : {
1608 [ - + ]: 337 : const std::shared_ptr<const CWallet> pwallet = GetWalletForJSONRPCRequest(request);
1609 [ - + ]: 337 : if (!pwallet) return UniValue::VNULL;
1610 : :
1611 [ + - ]: 337 : const CWallet& wallet{*pwallet};
1612 : : // Make sure the results are valid at least up to the most recent block
1613 : : // the user could have gotten from another RPC command prior to now
1614 [ + - ]: 337 : wallet.BlockUntilSyncedToCurrentChain();
1615 : :
1616 : : // Unserialize the transaction
1617 : 337 : PartiallySignedTransaction psbtx;
1618 [ + - ]: 337 : std::string error;
1619 [ + - + - : 337 : if (!DecodeBase64PSBT(psbtx, request.params[0].get_str(), error)) {
+ - + + ]
1620 [ + - + - ]: 4 : throw JSONRPCError(RPC_DESERIALIZATION_ERROR, strprintf("TX decode failed %s", error));
1621 : : }
1622 : :
1623 : : // Get the sighash type
1624 [ + - + + ]: 335 : int nHashType = ParseSighashString(request.params[2]);
1625 : :
1626 : : // Fill transaction with our data and also sign
1627 [ + - + + : 334 : bool sign = request.params[1].isNull() ? true : request.params[1].get_bool();
+ - + - ]
1628 [ + - + + : 334 : bool bip32derivs = request.params[3].isNull() ? true : request.params[3].get_bool();
+ - + - ]
1629 [ + - + + : 334 : bool finalize = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1630 : 334 : bool complete = true;
1631 : :
1632 [ + + + + ]: 334 : if (sign) EnsureWalletIsUnlocked(*pwallet);
1633 : :
1634 [ + - ]: 333 : const auto err{wallet.FillPSBT(psbtx, complete, nHashType, sign, bip32derivs, nullptr, finalize)};
1635 [ - + ]: 333 : if (err) {
1636 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1637 : : }
1638 : :
1639 : 333 : UniValue result(UniValue::VOBJ);
1640 : 333 : DataStream ssTx{};
1641 [ + - ]: 333 : ssTx << psbtx;
1642 [ + - + - : 666 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1643 [ + - + - : 666 : result.pushKV("complete", complete);
+ - ]
1644 [ + + ]: 333 : if (complete) {
1645 [ + - ]: 33 : CMutableTransaction mtx;
1646 : : // Returns true if complete, which we already think it is.
1647 [ + - + - ]: 33 : CHECK_NONFATAL(FinalizeAndExtractPSBT(psbtx, mtx));
1648 : 33 : DataStream ssTx_final;
1649 [ + - ]: 33 : ssTx_final << TX_WITH_WITNESS(mtx);
1650 [ + - + - : 66 : result.pushKV("hex", HexStr(ssTx_final));
+ - + - ]
1651 : 66 : }
1652 : :
1653 : 333 : return result;
1654 : 670 : },
1655 [ + - + - : 34193 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + + -
- ]
1656 [ + - + - : 16545 : }
+ - + - +
- + - + -
+ - + - +
- - - -
- ]
1657 : :
1658 : 963 : RPCHelpMan walletcreatefundedpsbt()
1659 : : {
1660 : 963 : return RPCHelpMan{"walletcreatefundedpsbt",
1661 : : "\nCreates and funds a transaction in the Partially Signed Transaction format.\n"
1662 : : "Implements the Creator and Updater roles.\n"
1663 : : "All existing inputs must either have their previous output transaction be in the wallet\n"
1664 : : "or be in the UTXO set. Solving data must be provided for non-wallet inputs.\n",
1665 : : {
1666 [ + - ]: 963 : {"inputs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "Leave empty to add inputs automatically. See add_inputs option.",
1667 : : {
1668 [ + - ]: 963 : {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
1669 : : {
1670 [ + - ]: 963 : {"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
1671 [ + - ]: 963 : {"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1672 [ + - ]: 1926 : {"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'locktime' and 'options.replaceable' arguments"}, "The sequence number"},
1673 [ + - ]: 1926 : {"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
1674 : : "including the weight of the outpoint and sequence number. "
1675 : : "Note that signature sizes are not guaranteed to be consistent, "
1676 : : "so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
1677 : : "Remember to convert serialized sizes to weight units when necessary."},
1678 : : },
1679 : : },
1680 : : },
1681 : : },
1682 [ + - ]: 963 : {"outputs", RPCArg::Type::ARR, RPCArg::Optional::NO, "The outputs specified as key-value pairs.\n"
1683 : : "Each key may only appear once, i.e. there can only be one 'data' output, and no address may be duplicated.\n"
1684 : : "At least one output of either type must be specified.\n"
1685 : : "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
1686 : : "accepted as second parameter.",
1687 [ + - ]: 1926 : OutputsDoc(),
1688 [ + - ]: 1926 : RPCArgOptions{.skip_type_check = true}},
1689 [ + - ]: 1926 : {"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},
1690 [ + - ]: 963 : {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "",
1691 [ + - + - : 62595 : Cat<std::vector<RPCArg>>(
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
+ + + - -
- - ]
1692 : : {
1693 [ + - ]: 1926 : {"add_inputs", RPCArg::Type::BOOL, RPCArg::DefaultHint{"false when \"inputs\" are specified, true otherwise"}, "Automatically include coins from the wallet to cover the target amount.\n"},
1694 [ + - ]: 1926 : {"include_unsafe", RPCArg::Type::BOOL, RPCArg::Default{false}, "Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).\n"
1695 : : "Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.\n"
1696 : : "If that happens, you will need to fund the transaction with different inputs and republish it."},
1697 [ + - ]: 1926 : {"minconf", RPCArg::Type::NUM, RPCArg::Default{0}, "If add_inputs is specified, require inputs with at least this many confirmations."},
1698 [ + - ]: 963 : {"maxconf", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "If add_inputs is specified, require inputs with at most this many confirmations."},
1699 [ + - ]: 1926 : {"changeAddress", RPCArg::Type::STR, RPCArg::DefaultHint{"automatic"}, "The bitcoin address to receive the change"},
1700 [ + - ]: 1926 : {"changePosition", RPCArg::Type::NUM, RPCArg::DefaultHint{"random"}, "The index of the change output"},
1701 [ + - ]: 1926 : {"change_type", RPCArg::Type::STR, RPCArg::DefaultHint{"set by -changetype"}, "The output type to use. Only valid if changeAddress is not specified. Options are \"legacy\", \"p2sh-segwit\", \"bech32\", and \"bech32m\"."},
1702 [ + - ]: 1926 : {"includeWatching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only"},
1703 [ + - ]: 1926 : {"lockUnspents", RPCArg::Type::BOOL, RPCArg::Default{false}, "Lock selected unspent outputs"},
1704 [ + - + - ]: 3852 : {"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
1705 [ + - + - ]: 3852 : {"feeRate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_UNIT + "/kvB."},
1706 : 1926 : {"subtractFeeFromOutputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "The outputs to subtract the fee from.\n"
1707 : : "The fee will be equally deducted from the amount of each specified output.\n"
1708 : : "Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
1709 : : "If no outputs are specified here, the sender pays the fee.",
1710 : : {
1711 [ + - ]: 963 : {"vout_index", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "The zero-based output index, before a change output is added."},
1712 : : },
1713 : : },
1714 [ + - ]: 1926 : {"max_tx_weight", RPCArg::Type::NUM, RPCArg::Default{MAX_STANDARD_TX_WEIGHT}, "The maximum acceptable transaction weight.\n"
1715 : : "Transaction building will fail if this can not be satisfied."},
1716 : : },
1717 [ + - ]: 1926 : FundTxDoc()),
1718 [ + - + - ]: 1926 : RPCArgOptions{.oneline_description="options"}},
1719 [ + - ]: 1926 : {"bip32derivs", RPCArg::Type::BOOL, RPCArg::Default{true}, "Include BIP 32 derivation paths for public keys if we know them"},
1720 : : },
1721 : 0 : RPCResult{
1722 : : RPCResult::Type::OBJ, "", "",
1723 : : {
1724 : : {RPCResult::Type::STR, "psbt", "The resulting raw transaction (base64-encoded string)"},
1725 [ + - ]: 1926 : {RPCResult::Type::STR_AMOUNT, "fee", "Fee in " + CURRENCY_UNIT + " the resulting transaction pays"},
1726 : : {RPCResult::Type::NUM, "changepos", "The position of the added change output, or -1"},
1727 : : }
1728 [ + - + - : 6741 : },
+ - + - +
- + - + -
+ - + - +
- + - + -
+ + - - ]
1729 : 963 : RPCExamples{
1730 : : "\nCreate a transaction with no inputs\n"
1731 [ + - + - : 1926 : + HelpExampleCli("walletcreatefundedpsbt", "\"[{\\\"txid\\\":\\\"myid\\\",\\\"vout\\\":0}]\" \"[{\\\"data\\\":\\\"00010203\\\"}]\"")
+ - + - ]
1732 [ + - ]: 963 : },
1733 : 197 : [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
1734 : : {
1735 : 197 : std::shared_ptr<CWallet> const pwallet = GetWalletForJSONRPCRequest(request);
1736 [ - + ]: 197 : if (!pwallet) return UniValue::VNULL;
1737 : :
1738 [ + - ]: 197 : CWallet& wallet{*pwallet};
1739 : : // Make sure the results are valid at least up to the most recent block
1740 : : // the user could have gotten from another RPC command prior to now
1741 [ + - ]: 197 : wallet.BlockUntilSyncedToCurrentChain();
1742 : :
1743 [ + - + + : 197 : UniValue options{request.params[3].isNull() ? UniValue::VOBJ : request.params[3]};
+ - + - ]
1744 : :
1745 [ + - + - ]: 197 : const UniValue &replaceable_arg = options["replaceable"];
1746 [ + + + - ]: 197 : const bool rbf{replaceable_arg.isNull() ? wallet.m_signal_rbf : replaceable_arg.get_bool()};
1747 [ + - + - : 197 : CMutableTransaction rawTx = ConstructTransaction(request.params[0], request.params[1], request.params[2], rbf);
+ - + - ]
1748 : 197 : UniValue outputs(UniValue::VOBJ);
1749 [ + - + - ]: 197 : outputs = NormalizeOutputs(request.params[1]);
1750 : 197 : std::vector<CRecipient> recipients = CreateRecipients(
1751 [ + - ]: 394 : ParseOutputs(outputs),
1752 [ + - + - : 394 : InterpretSubtractFeeFromOutputInstructions(options["subtractFeeFromOutputs"], outputs.getKeys())
+ - + - ]
1753 [ + - ]: 197 : );
1754 [ + - ]: 197 : CCoinControl coin_control;
1755 : : // Automatically select coins, unless at least one is manually selected. Can
1756 : : // be overridden by options.add_inputs.
1757 [ + - ]: 197 : coin_control.m_allow_other_inputs = rawTx.vin.size() == 0;
1758 [ + - + + ]: 197 : SetOptionsInputWeights(request.params[0], options);
1759 : : // Clear tx.vout since it is not meant to be used now that we are passing outputs directly.
1760 : : // This sets us up for a future PR to completely remove tx from the function signature in favor of passing inputs directly
1761 : 196 : rawTx.vout.clear();
1762 [ + + ]: 196 : auto txr = FundTransaction(wallet, rawTx, recipients, options, coin_control, /*override_min_fee=*/true);
1763 : :
1764 : : // Make a blank psbt
1765 [ + - + - ]: 128 : PartiallySignedTransaction psbtx(CMutableTransaction(*txr.tx));
1766 : :
1767 : : // Fill transaction with out data but don't sign
1768 [ + - + + : 128 : bool bip32derivs = request.params[4].isNull() ? true : request.params[4].get_bool();
+ - + - ]
1769 : 128 : bool complete = true;
1770 [ + - ]: 128 : const auto err{wallet.FillPSBT(psbtx, complete, 1, /*sign=*/false, /*bip32derivs=*/bip32derivs)};
1771 [ - + ]: 128 : if (err) {
1772 [ # # ]: 0 : throw JSONRPCPSBTError(*err);
1773 : : }
1774 : :
1775 : : // Serialize the PSBT
1776 : 128 : DataStream ssTx{};
1777 [ + - ]: 128 : ssTx << psbtx;
1778 : :
1779 : 128 : UniValue result(UniValue::VOBJ);
1780 [ + - + - : 256 : result.pushKV("psbt", EncodeBase64(ssTx.str()));
+ - + - +
- ]
1781 [ + - + - : 256 : result.pushKV("fee", ValueFromAmount(txr.fee));
+ - ]
1782 [ + + + - : 256 : result.pushKV("changepos", txr.change_pos ? (int)*txr.change_pos : -1);
+ - + - ]
1783 : 128 : return result;
1784 [ + - ]: 788 : },
1785 [ + - + - : 42372 : };
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + +
+ + + + -
- - - -
- ]
1786 [ + - + - : 49113 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - -
- - - - -
- - ]
1787 : : } // namespace wallet
|
