LCOV - code coverage report
Current view: top level - src/test - addrman_tests.cpp (source / functions) Coverage Total Hit
Test: total_coverage.info Lines: 99.5 % 768 764
Test Date: 2026-02-01 05:10:21 Functions: 100.0 % 54 54
Branches: 50.4 % 4902 2472

             Branch data     Line data    Source code
       1                 :             : // Copyright (c) 2012-present The Bitcoin Core developers
       2                 :             : // Distributed under the MIT software license, see the accompanying
       3                 :             : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
       4                 :             : 
       5                 :             : #include <addrdb.h>
       6                 :             : #include <addrman.h>
       7                 :             : #include <addrman_impl.h>
       8                 :             : #include <chainparams.h>
       9                 :             : #include <clientversion.h>
      10                 :             : #include <hash.h>
      11                 :             : #include <netbase.h>
      12                 :             : #include <random.h>
      13                 :             : #include <test/data/asmap.raw.h>
      14                 :             : #include <test/util/setup_common.h>
      15                 :             : #include <util/asmap.h>
      16                 :             : #include <util/string.h>
      17                 :             : 
      18                 :             : #include <boost/test/unit_test.hpp>
      19                 :             : 
      20                 :             : #include <cstdint>
      21                 :             : #include <optional>
      22                 :             : #include <string>
      23                 :             : 
      24                 :             : using namespace std::literals;
      25                 :             : using node::NodeContext;
      26                 :             : using util::ToString;
      27                 :             : 
      28                 :             : static NetGroupManager EMPTY_NETGROUPMAN{std::vector<bool>()};
      29                 :             : static const bool DETERMINISTIC{true};
      30                 :             : 
      31                 :          25 : static int32_t GetCheckRatio(const NodeContext& node_ctx)
      32                 :             : {
      33   [ +  -  +  - ]:          50 :     return std::clamp<int32_t>(node_ctx.args->GetIntArg("-checkaddrman", 100), 0, 1000000);
      34                 :             : }
      35                 :             : 
      36                 :        6821 : static CNetAddr ResolveIP(const std::string& ip)
      37                 :             : {
      38         [ +  - ]:        6821 :     const std::optional<CNetAddr> addr{LookupHost(ip, false)};
      39   [ +  -  +  -  :        6821 :     BOOST_CHECK_MESSAGE(addr.has_value(), strprintf("failed to resolve: %s", ip));
                   +  - ]
      40         [ +  - ]:        6821 :     return addr.value_or(CNetAddr{});
      41                 :        6821 : }
      42                 :             : 
      43                 :        6633 : static CService ResolveService(const std::string& ip, uint16_t port = 0)
      44                 :             : {
      45         [ +  - ]:        6633 :     const std::optional<CService> serv{Lookup(ip, port, false)};
      46   [ +  -  +  -  :       13266 :     BOOST_CHECK_MESSAGE(serv.has_value(), strprintf("failed to resolve: %s:%i", ip, port));
                   +  - ]
      47         [ +  - ]:        6633 :     return serv.value_or(CService{});
      48                 :        6633 : }
      49                 :             : 
      50                 :             : 
      51                 :           3 : static std::vector<bool> FromBytes(std::span<const std::byte> source)
      52                 :             : {
      53                 :           3 :     int vector_size(source.size() * 8);
      54                 :           3 :     std::vector<bool> result(vector_size);
      55         [ +  + ]:         180 :     for (int byte_i = 0; byte_i < vector_size / 8; ++byte_i) {
      56                 :         177 :         uint8_t cur_byte{std::to_integer<uint8_t>(source[byte_i])};
      57         [ +  + ]:        1593 :         for (int bit_i = 0; bit_i < 8; ++bit_i) {
      58                 :        1416 :             result[byte_i * 8 + bit_i] = (cur_byte >> bit_i) & 1;
      59                 :             :         }
      60                 :             :     }
      61                 :           3 :     return result;
      62                 :             : }
      63                 :             : 
      64                 :             : BOOST_FIXTURE_TEST_SUITE(addrman_tests, BasicTestingSetup)
      65                 :             : 
      66   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_simple)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
      67                 :             : {
      68                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
      69                 :             : 
      70   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
      71                 :             : 
      72                 :             :     // Test: Does Addrman respond correctly when empty.
      73   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 0U);
                   +  - ]
      74         [ +  - ]:           1 :     auto addr_null = addrman->Select().first;
      75   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addr_null.ToStringAddrPort(), "[::]:0");
                   +  - ]
      76                 :             : 
      77                 :             :     // Test: Does Addrman::Add work as expected.
      78   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
      79   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
      80   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
      81         [ +  - ]:           1 :     auto addr_ret1 = addrman->Select().first;
      82   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addr_ret1.ToStringAddrPort(), "250.1.1.1:8333");
                   +  - ]
      83                 :             : 
      84                 :             :     // Test: Does IP address deduplication work correctly.
      85                 :             :     //  Expected dup IP should not be added.
      86   [ +  -  +  - ]:           1 :     CService addr1_dup = ResolveService("250.1.1.1", 8333);
      87   [ +  -  +  -  :           5 :     BOOST_CHECK(!addrman->Add({CAddress(addr1_dup, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
      88   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
      89                 :             : 
      90                 :             : 
      91                 :             :     // Test: New table has one addr and we add a diff addr we should
      92                 :             :     //  have at least one addr.
      93                 :             :     // Note that addrman's size cannot be tested reliably after insertion, as
      94                 :             :     // hash collisions may occur. But we can always be sure of at least one
      95                 :             :     // success.
      96                 :             : 
      97   [ +  -  +  - ]:           1 :     CService addr2 = ResolveService("250.1.1.2", 8333);
      98   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
      99   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() >= 1);
             +  -  +  - ]
     100                 :             : 
     101                 :             :     // Test: reset addrman and test AddrMan::Add multiple addresses works as expected
     102   [ +  -  +  - ]:           2 :     addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     103                 :           1 :     std::vector<CAddress> vAddr;
     104   [ +  -  +  -  :           2 :     vAddr.emplace_back(ResolveService("250.1.1.3", 8333), NODE_NONE);
                   +  - ]
     105   [ +  -  +  -  :           2 :     vAddr.emplace_back(ResolveService("250.1.1.4", 8333), NODE_NONE);
                   +  - ]
     106   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Add(vAddr, source));
             +  -  +  - ]
     107   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() >= 1);
                   +  - ]
     108   [ +  -  +  -  :           7 : }
                   +  - ]
     109                 :             : 
     110   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_penalty_self_announcement)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     111                 :             : {
     112                 :           1 :     SetMockTime(Now<NodeSeconds>());
     113                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     114                 :             : 
     115                 :           1 :     const auto base_time{Now<NodeSeconds>() - 10000s};
     116   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     117   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.1.1"); // Same as addr1 - self announcement
     118                 :             : 
     119                 :           1 :     CAddress caddr1(addr1, NODE_NONE);
     120                 :           1 :     caddr1.nTime = base_time;
     121                 :             : 
     122                 :           1 :     const auto time_penalty{3600s};
     123                 :             : 
     124   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({caddr1}, source1, time_penalty));
          +  -  +  -  +  
                +  -  - ]
     125                 :             : 
     126         [ +  - ]:           1 :     auto addr_pos1{addrman->FindAddressEntry(caddr1)};
     127   [ +  -  +  -  :           2 :     BOOST_REQUIRE(addr_pos1.has_value());
                   +  - ]
     128                 :             : 
     129         [ +  - ]:           1 :     std::vector<CAddress> addresses{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
     130   [ +  -  -  +  :           1 :     BOOST_REQUIRE_EQUAL(addresses.size(), 1U);
                   +  - ]
     131                 :             : 
     132   [ +  -  +  -  :           2 :     BOOST_CHECK(addresses[0].nTime == base_time);
                   +  - ]
     133                 :             : 
     134   [ +  -  +  - ]:           1 :     CService addr2{ResolveService("250.1.1.2", 8333)};
     135   [ +  -  +  - ]:           1 :     CNetAddr source2{ResolveIP("250.1.1.3")}; // Different from addr2 - not self announcement
     136                 :             : 
     137                 :           1 :     CAddress caddr2(addr2, NODE_NONE);
     138                 :           1 :     caddr2.nTime = base_time;
     139                 :             : 
     140   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({caddr2}, source2, time_penalty));
          +  -  +  -  +  
                +  -  - ]
     141                 :             : 
     142         [ +  - ]:           2 :     addresses = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
     143   [ +  -  -  +  :           1 :     BOOST_REQUIRE_EQUAL(addresses.size(), 2U);
                   +  - ]
     144                 :             : 
     145                 :           1 :     CAddress retrieved_addr2{addresses[0]};
     146   [ +  -  +  - ]:           2 :     BOOST_CHECK(retrieved_addr2.nTime == base_time - time_penalty);
     147                 :           3 : }
     148                 :             : 
     149   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_ports)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     150                 :             : {
     151                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     152                 :             : 
     153   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     154                 :             : 
     155   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 0U);
                   +  - ]
     156                 :             : 
     157                 :             :     // Test 7; Addr with same IP but diff port does not replace existing addr.
     158   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     159   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     160   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     161                 :             : 
     162   [ +  -  +  - ]:           1 :     CService addr1_port = ResolveService("250.1.1.1", 8334);
     163   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1_port, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     164   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2U);
                   +  - ]
     165         [ +  - ]:           1 :     auto addr_ret2 = addrman->Select().first;
     166   [ +  -  +  -  :           3 :     BOOST_CHECK(addr_ret2.ToStringAddrPort() == "250.1.1.1:8333" || addr_ret2.ToStringAddrPort() == "250.1.1.1:8334");
          -  +  -  -  -  
          -  +  -  -  +  
             -  -  -  - ]
     167                 :             : 
     168                 :             :     // Test: Add same IP but diff port to tried table; this converts the entry with
     169                 :             :     // the specified port to tried, but not the other.
     170         [ +  - ]:           2 :     addrman->Good(CAddress(addr1_port, NODE_NONE));
     171   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2U);
                   +  - ]
     172                 :           1 :     bool new_only = true;
     173         [ +  - ]:           1 :     auto addr_ret3 = addrman->Select(new_only).first;
     174   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addr_ret3.ToStringAddrPort(), "250.1.1.1:8333");
                   +  - ]
     175   [ +  -  +  - ]:           5 : }
     176                 :             : 
     177   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_select)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     178                 :             : {
     179                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     180   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(false).first.IsValid());
          +  -  +  -  +  
                      - ]
     181   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(true).first.IsValid());
          +  -  +  -  +  
                      - ]
     182                 :             : 
     183   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     184                 :             : 
     185                 :             :     // Add 1 address to the new table
     186   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     187   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     188   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     189                 :             : 
     190   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/true).first == addr1);
          +  -  +  -  +  
                      - ]
     191   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/false).first == addr1);
          +  -  +  -  +  
                      - ]
     192                 :             : 
     193                 :             :     // Move address to the tried table
     194   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr1, NODE_NONE)));
             +  -  +  - ]
     195                 :             : 
     196   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     197   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true).first.IsValid());
          +  -  +  -  +  
                      - ]
     198   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select().first == addr1);
          +  -  +  -  +  
                      - ]
     199   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     200                 :             : 
     201                 :             :     // Add one address to the new table
     202   [ +  -  +  - ]:           1 :     CService addr2 = ResolveService("250.3.1.1", 8333);
     203   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, addr2));
          +  -  +  +  +  
                -  -  - ]
     204   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/true).first == addr2);
          +  -  +  -  +  
                      - ]
     205                 :             : 
     206                 :             :     // Add two more addresses to the new table
     207   [ +  -  +  - ]:           1 :     CService addr3 = ResolveService("250.3.2.2", 9999);
     208   [ +  -  +  - ]:           1 :     CService addr4 = ResolveService("250.3.3.3", 9999);
     209                 :             : 
     210   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr3, NODE_NONE)}, addr2));
          +  -  +  +  +  
                -  -  - ]
     211   [ +  -  +  -  :           6 :     BOOST_CHECK(addrman->Add({CAddress(addr4, NODE_NONE)}, ResolveService("250.4.1.1", 8333)));
          +  -  +  -  +  
          -  +  +  +  -  
                   -  - ]
     212                 :             : 
     213                 :             :     // Add three addresses to tried table.
     214   [ +  -  +  - ]:           1 :     CService addr5 = ResolveService("250.4.4.4", 8333);
     215   [ +  -  +  - ]:           1 :     CService addr6 = ResolveService("250.4.5.5", 7777);
     216   [ +  -  +  - ]:           1 :     CService addr7 = ResolveService("250.4.6.6", 8333);
     217                 :             : 
     218   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr5, NODE_NONE)}, addr3));
          +  -  +  +  +  
                -  -  - ]
     219   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr5, NODE_NONE)));
             +  -  +  - ]
     220   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr6, NODE_NONE)}, addr3));
          +  -  +  +  +  
                -  -  - ]
     221   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr6, NODE_NONE)));
             +  -  +  - ]
     222   [ +  -  +  -  :           6 :     BOOST_CHECK(addrman->Add({CAddress(addr7, NODE_NONE)}, ResolveService("250.1.1.3", 8333)));
          +  -  +  -  +  
          -  +  +  +  -  
                   -  - ]
     223   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr7, NODE_NONE)));
             +  -  +  - ]
     224                 :             : 
     225                 :             :     // 6 addrs + 1 addr from last test = 7.
     226   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 7U);
                   +  - ]
     227                 :             : 
     228                 :             :     // Select pulls from new and tried regardless of port number.
     229                 :           1 :     std::set<uint16_t> ports;
     230         [ +  + ]:          21 :     for (int i = 0; i < 20; ++i) {
     231   [ +  -  +  -  :          40 :         ports.insert(addrman->Select().first.GetPort());
                   +  - ]
     232                 :             :     }
     233   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(ports.size(), 3U);
     234   [ +  -  +  -  :          15 : }
          +  -  +  -  +  
             -  +  -  +  
                      - ]
     235                 :             : 
     236   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_select_by_network)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     237                 :             : {
     238                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     239   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_IPV4}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     240   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV4}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     241                 :             : 
     242                 :             :     // add ipv4 address to the new table
     243   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     244   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     245   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     246                 :             : 
     247   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                -  +  - ]
     248   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                -  +  - ]
     249   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV6}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     250   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_ONION}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     251   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_I2P}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     252   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_CJDNS}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     253   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_CJDNS}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     254   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/false).first == addr1);
          +  -  +  -  +  
                      - ]
     255                 :             : 
     256                 :             :     // add I2P address to the new table
     257         [ +  - ]:           1 :     CAddress i2p_addr;
     258         [ +  - ]:           1 :     i2p_addr.SetSpecial("udhdrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.i2p");
     259   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({i2p_addr}, source));
          +  -  +  -  +  
                +  -  - ]
     260                 :             : 
     261   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_I2P}).first == i2p_addr);
          +  -  +  -  +  
                -  +  - ]
     262   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_I2P}).first == i2p_addr);
          +  -  +  -  +  
                -  +  - ]
     263   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                -  +  - ]
     264   [ +  -  +  - ]:           2 :     std::unordered_set<Network> nets_with_entries = {NET_IPV4, NET_I2P};
     265   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, nets_with_entries).first.IsValid());
          +  -  +  -  +  
                      - ]
     266   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV6}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     267   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_ONION}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     268   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_CJDNS}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     269   [ +  -  +  - ]:           2 :     std::unordered_set<Network> nets_without_entries = {NET_IPV6, NET_ONION, NET_CJDNS};
     270   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, nets_without_entries).first.IsValid());
          +  -  +  -  +  
                      - ]
     271                 :             : 
     272                 :             :     // bump I2P address to tried table
     273   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(i2p_addr));
             +  -  +  - ]
     274                 :             : 
     275   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_I2P}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     276   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_I2P}).first == i2p_addr);
          +  -  +  -  +  
                -  +  - ]
     277                 :             : 
     278                 :             :     // add another I2P address to the new table
     279         [ +  - ]:           1 :     CAddress i2p_addr2;
     280         [ +  - ]:           1 :     i2p_addr2.SetSpecial("c4gfnttsuwqomiygupdqqqyy5y5emnk5c73hrfvatri67prd7vyq.b32.i2p");
     281   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({i2p_addr2}, source));
          +  -  +  -  +  
                +  -  - ]
     282                 :             : 
     283   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_I2P}).first == i2p_addr2);
          +  -  +  -  +  
                      - ]
     284                 :             : 
     285                 :             :     // ensure that both new and tried table are selected from
     286                 :           1 :     bool new_selected{false};
     287                 :           1 :     bool tried_selected{false};
     288                 :           1 :     int counter = 256;
     289                 :             : 
     290   [ +  -  +  + ]:           3 :     while (--counter > 0 && (!new_selected || !tried_selected)) {
     291   [ +  -  +  -  :           4 :         const CAddress selected{addrman->Select(/*new_only=*/false, {NET_I2P}).first};
                   +  - ]
     292   [ +  -  +  -  :           5 :         BOOST_REQUIRE(selected == i2p_addr || selected == i2p_addr2);
          +  +  +  -  +  
             -  +  -  +  
                      - ]
     293   [ +  -  +  + ]:           2 :         if (selected == i2p_addr) {
     294                 :             :             tried_selected = true;
     295                 :             :         } else {
     296                 :           1 :             new_selected = true;
     297                 :             :         }
     298                 :           2 :     }
     299                 :             : 
     300   [ +  -  +  -  :           2 :     BOOST_CHECK(new_selected);
                   +  - ]
     301   [ +  -  +  - ]:           2 :     BOOST_CHECK(tried_selected);
     302         [ +  - ]:           5 : }
     303                 :             : 
     304   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_select_special)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     305                 :             : {
     306                 :             :     // use a non-deterministic addrman to ensure a passing test isn't due to setup
     307                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, /*deterministic=*/false, GetCheckRatio(m_node));
     308                 :             : 
     309   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     310                 :             : 
     311                 :             :     // add I2P address to the tried table
     312         [ +  - ]:           1 :     CAddress i2p_addr;
     313         [ +  - ]:           1 :     i2p_addr.SetSpecial("udhdrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.i2p");
     314   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({i2p_addr}, source));
          +  -  +  -  +  
                +  -  - ]
     315   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(i2p_addr));
             +  -  +  - ]
     316                 :             : 
     317                 :             :     // add ipv4 address to the new table
     318   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.3", 8333);
     319   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     320                 :             : 
     321                 :             :     // since the only ipv4 address is on the new table, ensure that the new
     322                 :             :     // table gets selected even if new_only is false. if the table was being
     323                 :             :     // selected at random, this test will sporadically fail
     324   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                      - ]
     325         [ +  - ]:           4 : }
     326                 :             : 
     327   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_new_collisions)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     328                 :             : {
     329                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     330                 :             : 
     331   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     332                 :             : 
     333                 :           1 :     uint32_t num_addrs{0};
     334                 :             : 
     335   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
                   +  - ]
     336                 :             : 
     337         [ +  + ]:          23 :     while (num_addrs < 22) { // Magic number! 250.1.1.1 - 250.1.1.22 do not collide with deterministic key = 1
     338   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     339   [ +  -  +  -  :         110 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     340                 :             : 
     341                 :             :         // Test: No collision in new table yet.
     342   [ +  -  +  -  :          22 :         BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
                   +  - ]
     343                 :          22 :     }
     344                 :             : 
     345                 :             :     // Test: new table collision!
     346   [ +  -  +  -  :           2 :     CService addr1 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     347                 :           1 :     uint32_t collisions{1};
     348   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     349   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs - collisions);
                   +  - ]
     350                 :             : 
     351   [ +  -  +  -  :           2 :     CService addr2 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     352   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     353   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs - collisions);
                   +  - ]
     354   [ +  -  +  -  :          49 : }
                   +  - ]
     355                 :             : 
     356   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_new_multiplicity)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     357                 :             : {
     358                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     359   [ +  -  +  - ]:           2 :     CAddress addr{CAddress(ResolveService("253.3.3.3", 8333), NODE_NONE)};
     360                 :           1 :     const auto start_time{Now<NodeSeconds>()};
     361                 :           1 :     addr.nTime = start_time;
     362                 :             : 
     363                 :             :     // test that multiplicity stays at 1 if nTime doesn't increase
     364         [ +  + ]:          20 :     for (unsigned int i = 1; i < 20; ++i) {
     365   [ +  -  +  -  :          57 :         std::string addr_ip{ToString(i % 256) + "." + ToString(i >> 8 % 256) + ".1.1"};
                   +  - ]
     366         [ +  - ]:          19 :         CNetAddr source{ResolveIP(addr_ip)};
     367   [ +  -  +  -  :          38 :         addrman->Add({addr}, source);
             +  +  -  - ]
     368                 :          19 :     }
     369         [ +  - ]:           1 :     AddressPosition addr_pos = addrman->FindAddressEntry(addr).value();
     370   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(addr_pos.multiplicity, 1U);
     371   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     372                 :             : 
     373                 :             :     // if nTime increases, an addr can occur in up to 8 buckets
     374                 :             :     // The acceptance probability decreases exponentially with existing multiplicity -
     375                 :             :     // choose number of iterations such that it gets to 8 with deterministic addrman.
     376         [ +  + ]:         400 :     for (unsigned int i = 1; i < 400; ++i) {
     377   [ +  -  +  -  :        1197 :         std::string addr_ip{ToString(i % 256) + "." + ToString(i >> 8 % 256) + ".1.1"};
                   +  - ]
     378         [ +  - ]:         399 :         CNetAddr source{ResolveIP(addr_ip)};
     379                 :         399 :         addr.nTime = start_time + std::chrono::seconds{i};
     380   [ +  -  +  -  :         798 :         addrman->Add({addr}, source);
             +  +  -  - ]
     381                 :         399 :     }
     382         [ +  - ]:           1 :     AddressPosition addr_pos_multi = addrman->FindAddressEntry(addr).value();
     383   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(addr_pos_multi.multiplicity, 8U);
     384                 :             :     // multiplicity doesn't affect size
     385   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     386                 :         419 : }
     387                 :             : 
     388   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_tried_collisions)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     389                 :             : {
     390                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     391                 :             : 
     392   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     393                 :             : 
     394                 :           1 :     uint32_t num_addrs{0};
     395                 :             : 
     396   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
                   +  - ]
     397                 :             : 
     398         [ +  + ]:          36 :     while (num_addrs < 35) { // Magic number! 250.1.1.1 - 250.1.1.35 do not collide in tried with deterministic key = 1
     399   [ +  -  +  -  :          70 :         CService addr = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     400   [ +  -  +  -  :         175 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     401                 :             : 
     402                 :             :         // Test: Add to tried without collision
     403   [ +  -  +  -  :          70 :         BOOST_CHECK(addrman->Good(CAddress(addr, NODE_NONE)));
                   +  - ]
     404                 :             : 
     405                 :          35 :     }
     406                 :             : 
     407                 :             :     // Test: Unable to add to tried table due to collision!
     408   [ +  -  +  -  :           2 :     CService addr1 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     409   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     410   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(CAddress(addr1, NODE_NONE)));
             +  -  +  - ]
     411                 :             : 
     412                 :             :     // Test: Add the next address to tried without collision
     413   [ +  -  +  -  :           2 :     CService addr2 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     414   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     415   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr2, NODE_NONE)));
                   +  - ]
     416   [ +  -  +  -  :          75 : }
                   +  - ]
     417                 :             : 
     418                 :             : 
     419   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_getaddr)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     420                 :             : {
     421                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     422                 :             : 
     423                 :             :     // Test: Sanity check, GetAddr should never return anything if addrman
     424                 :             :     //  is empty.
     425   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 0U);
                   +  - ]
     426         [ +  - ]:           1 :     std::vector<CAddress> vAddr1 = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
     427   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr1.size(), 0U);
                   +  - ]
     428                 :             : 
     429   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.250.2.1", 8333), NODE_NONE);
     430                 :           1 :     addr1.nTime = Now<NodeSeconds>(); // Set time so isTerrible = false
     431   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.251.2.2", 9999), NODE_NONE);
     432                 :           1 :     addr2.nTime = Now<NodeSeconds>();
     433   [ +  -  +  - ]:           2 :     CAddress addr3 = CAddress(ResolveService("251.252.2.3", 8333), NODE_NONE);
     434                 :           1 :     addr3.nTime = Now<NodeSeconds>();
     435   [ +  -  +  - ]:           2 :     CAddress addr4 = CAddress(ResolveService("252.253.3.4", 8333), NODE_NONE);
     436                 :           1 :     addr4.nTime = Now<NodeSeconds>();
     437   [ +  -  +  - ]:           2 :     CAddress addr5 = CAddress(ResolveService("252.254.4.5", 8333), NODE_NONE);
     438                 :           1 :     addr5.nTime = Now<NodeSeconds>();
     439   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.2.1");
     440   [ +  -  +  - ]:           1 :     CNetAddr source2 = ResolveIP("250.2.3.3");
     441                 :             : 
     442                 :             :     // Test: Ensure GetAddr works with new addresses.
     443   [ +  -  +  -  :           6 :     BOOST_CHECK(addrman->Add({addr1, addr3, addr5}, source1));
          +  -  +  -  +  
                +  -  - ]
     444   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({addr2, addr4}, source2));
          +  -  +  -  +  
                +  -  - ]
     445                 :             : 
     446   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 5U);
                   +  - ]
     447                 :             :     // Net processing asks for 23% of addresses. 23% of 5 is 1 rounded down.
     448   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt).size(), 1U);
                   +  - ]
     449                 :             : 
     450                 :             :     // Test: Ensure GetAddr works with new and tried addresses.
     451   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr1, NODE_NONE)));
             +  -  +  - ]
     452   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr2, NODE_NONE)));
             +  -  +  - ]
     453   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 5U);
                   +  - ]
     454   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt).size(), 1U);
                   +  - ]
     455                 :             : 
     456                 :             :     // Test: Ensure GetAddr still returns 23% when addrman has many addrs.
     457         [ +  + ]:        2048 :     for (unsigned int i = 1; i < (8 * 256); i++) {
     458                 :        2047 :         int octet1 = i % 256;
     459                 :        2047 :         int octet2 = i >> 8 % 256;
     460   [ +  -  +  -  :        6141 :         std::string strAddr = ToString(octet1) + "." + ToString(octet2) + ".1.23";
                   +  - ]
     461         [ +  - ]:        4094 :         CAddress addr = CAddress(ResolveService(strAddr), NODE_NONE);
     462                 :             : 
     463                 :             :         // Ensure that for all addrs in addrman, isTerrible == false.
     464                 :        2047 :         addr.nTime = Now<NodeSeconds>();
     465   [ +  -  +  -  :        6141 :         addrman->Add({addr}, ResolveIP(strAddr));
          +  -  +  +  -  
                      - ]
     466         [ +  + ]:        2047 :         if (i % 8 == 0)
     467         [ +  - ]:         255 :             addrman->Good(addr);
     468                 :        2047 :     }
     469         [ +  - ]:           1 :     std::vector<CAddress> vAddr = addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt);
     470                 :             : 
     471         [ +  - ]:           1 :     size_t percent23 = (addrman->Size() * 23) / 100;
     472   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr.size(), percent23);
                   +  - ]
     473   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr.size(), 461U);
                   +  - ]
     474                 :             :     // (addrman.Size() < number of addresses added) due to address collisions.
     475   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2006U);
                   +  - ]
     476                 :        2050 : }
     477                 :             : 
     478   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(getaddr_unfiltered)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     479                 :             : {
     480                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     481                 :             : 
     482                 :             :     // Set time on this addr so isTerrible = false
     483   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.250.2.1", 8333), NODE_NONE);
     484                 :           1 :     addr1.nTime = Now<NodeSeconds>();
     485                 :             :     // Not setting time so this addr should be isTerrible = true
     486   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.251.2.2", 9999), NODE_NONE);
     487                 :             : 
     488   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("250.1.2.1");
     489   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({addr1, addr2}, source));
          +  -  +  -  +  
                +  -  - ]
     490                 :             : 
     491                 :             :     // Set time on this addr so isTerrible = false
     492   [ +  -  +  - ]:           2 :     CAddress addr3 = CAddress(ResolveService("250.251.2.3", 9998), NODE_NONE);
     493                 :           1 :     addr3.nTime = Now<NodeSeconds>();
     494         [ +  - ]:           1 :     addrman->Good(addr3, /*time=*/Now<NodeSeconds>());
     495   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr3}, source));
          +  -  +  -  +  
                +  -  - ]
     496                 :             :     // The time is set, but after ADDRMAN_RETRIES unsuccessful attempts not
     497                 :             :     // retried in the last minute, this addr should be isTerrible = true
     498         [ +  + ]:           4 :     for (size_t i = 0; i < 3; ++i) {
     499         [ +  - ]:           3 :         addrman->Attempt(addr3, /*fCountFailure=*/true, /*time=*/Now<NodeSeconds>() - 61s);
     500                 :             :     }
     501                 :             : 
     502                 :             :     // Set time more than 10 minutes in the future (flying DeLorean), so this
     503                 :             :     // addr should be isTerrible = true
     504   [ +  -  +  - ]:           2 :     CAddress addr4 = CAddress(ResolveService("250.252.2.4", 9997), NODE_NONE);
     505                 :           1 :     addr4.nTime = Now<NodeSeconds>() + 11min;
     506   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr4}, source));
          +  -  +  -  +  
                +  -  - ]
     507                 :             : 
     508                 :             :     // GetAddr filtered by quality (i.e. not IsTerrible) should only return addr1
     509   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 1U);
                   +  - ]
     510                 :             :     // Unfiltered GetAddr should return all addrs
     511   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt, /*filtered=*/false).size(), 4U);
                   +  - ]
     512                 :           4 : }
     513                 :             : 
     514   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket_legacy)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     515                 :             : {
     516         [ +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE);
     517   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.1.1", 9999), NODE_NONE);
     518                 :             : 
     519   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.1.1");
     520                 :             : 
     521                 :             : 
     522                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     523                 :             : 
     524   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     525   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     526                 :             : 
     527   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN), 40);
                   +  - ]
     528                 :             : 
     529                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     530                 :             :     //  this test could be a security issue.
     531   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN) != info1.GetTriedBucket(nKey2, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     532                 :             : 
     533                 :             :     // Test: Two addresses with same IP but different ports can map to
     534                 :             :     //  different buckets because they have different keys.
     535                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     536                 :             : 
     537   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     538   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN) != info2.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     539                 :             : 
     540                 :           1 :     std::set<int> buckets;
     541         [ +  + ]:         256 :     for (int i = 0; i < 255; i++) {
     542                 :         255 :         AddrInfo infoi = AddrInfo(
     543   [ +  -  +  -  :         510 :             CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
                   +  - ]
     544   [ +  -  +  -  :         765 :             ResolveIP("250.1.1." + ToString(i)));
                   +  - ]
     545         [ +  - ]:         255 :         int bucket = infoi.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN);
     546         [ +  - ]:         255 :         buckets.insert(bucket);
     547                 :         255 :     }
     548                 :             :     // Test: IP addresses in the same /16 prefix should
     549                 :             :     // never get more than 8 buckets with legacy grouping
     550   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 8U);
     551                 :             : 
     552                 :           1 :     buckets.clear();
     553         [ +  + ]:         256 :     for (int j = 0; j < 255; j++) {
     554                 :         255 :         AddrInfo infoj = AddrInfo(
     555   [ +  -  +  -  :         765 :             CAddress(ResolveService("250." + ToString(j) + ".1.1"), NODE_NONE),
                   +  - ]
     556   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(j) + ".1.1"));
                   +  - ]
     557         [ +  - ]:         255 :         int bucket = infoj.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN);
     558         [ +  - ]:         255 :         buckets.insert(bucket);
     559                 :         255 :     }
     560                 :             :     // Test: IP addresses in the different /16 prefix should map to more than
     561                 :             :     // 8 buckets with legacy grouping
     562   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 160U);
     563                 :           3 : }
     564                 :             : 
     565   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket_legacy)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     566                 :             : {
     567         [ +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
     568   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
     569                 :             : 
     570   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.2.1");
     571                 :             : 
     572                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     573                 :             : 
     574   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     575   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     576                 :             : 
     577                 :             :     // Test: Make sure the buckets are what we expect
     578   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN), 786);
                   +  - ]
     579   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, source1, EMPTY_NETGROUPMAN), 786);
                   +  - ]
     580                 :             : 
     581                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     582                 :             :     //  this test could be a security issue.
     583   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN) != info1.GetNewBucket(nKey2, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     584                 :             : 
     585                 :             :     // Test: Ports should not affect bucket placement in the addr
     586                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     587   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     588   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN), info2.GetNewBucket(nKey1, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     589                 :             : 
     590                 :           1 :     std::set<int> buckets;
     591         [ +  + ]:         256 :     for (int i = 0; i < 255; i++) {
     592                 :         255 :         AddrInfo infoi = AddrInfo(
     593   [ +  -  +  -  :         510 :             CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
                   +  - ]
     594   [ +  -  +  -  :         765 :             ResolveIP("250.1.1." + ToString(i)));
                   +  - ]
     595         [ +  - ]:         255 :         int bucket = infoi.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
     596         [ +  - ]:         255 :         buckets.insert(bucket);
     597                 :         255 :     }
     598                 :             :     // Test: IP addresses in the same group (\16 prefix for IPv4) should
     599                 :             :     //  always map to the same bucket.
     600   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 1U);
     601                 :             : 
     602                 :           1 :     buckets.clear();
     603         [ +  + ]:        1021 :     for (int j = 0; j < 4 * 255; j++) {
     604                 :        1020 :         AddrInfo infoj = AddrInfo(CAddress(
     605                 :        1020 :                                         ResolveService(
     606   [ +  -  +  -  :        4080 :                                             ToString(250 + (j / 255)) + "." + ToString(j % 256) + ".1.1"), NODE_NONE),
             +  -  +  - ]
     607   [ +  -  +  - ]:        3060 :             ResolveIP("251.4.1.1"));
     608         [ +  - ]:        1020 :         int bucket = infoj.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
     609         [ +  - ]:        1020 :         buckets.insert(bucket);
     610                 :        1020 :     }
     611                 :             :     // Test: IP addresses in the same source groups should map to NO MORE
     612                 :             :     //  than 64 buckets.
     613   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() <= 64);
     614                 :             : 
     615                 :           1 :     buckets.clear();
     616         [ +  + ]:         256 :     for (int p = 0; p < 255; p++) {
     617                 :         255 :         AddrInfo infoj = AddrInfo(
     618   [ +  -  +  - ]:         510 :             CAddress(ResolveService("250.1.1.1"), NODE_NONE),
     619   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(p) + ".1.1"));
                   +  - ]
     620         [ +  - ]:         255 :         int bucket = infoj.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
     621         [ +  - ]:         255 :         buckets.insert(bucket);
     622                 :         255 :     }
     623                 :             :     // Test: IP addresses in the different source groups should map to MORE
     624                 :             :     //  than 64 buckets.
     625   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() > 64);
     626                 :           3 : }
     627                 :             : 
     628                 :             : // The following three test cases use asmap.raw
     629                 :             : // We use an artificial minimal mock mapping
     630                 :             : // 250.0.0.0/8 AS1000
     631                 :             : // 101.1.0.0/16 AS1
     632                 :             : // 101.2.0.0/16 AS2
     633                 :             : // 101.3.0.0/16 AS3
     634                 :             : // 101.4.0.0/16 AS4
     635                 :             : // 101.5.0.0/16 AS5
     636                 :             : // 101.6.0.0/16 AS6
     637                 :             : // 101.7.0.0/16 AS7
     638                 :             : // 101.8.0.0/16 AS8
     639   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     640                 :             : {
     641                 :           1 :     std::vector<bool> asmap = FromBytes(test::data::asmap);
     642         [ +  - ]:           1 :     NetGroupManager ngm_asmap{asmap};
     643                 :             : 
     644   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE);
     645   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.1.1", 9999), NODE_NONE);
     646                 :             : 
     647   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.1.1");
     648                 :             : 
     649                 :             : 
     650                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     651                 :             : 
     652   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     653   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     654                 :             : 
     655   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetTriedBucket(nKey1, ngm_asmap), 236);
                   +  - ]
     656                 :             : 
     657                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     658                 :             :     //  this test could be a security issue.
     659   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, ngm_asmap) != info1.GetTriedBucket(nKey2, ngm_asmap));
             +  -  +  - ]
     660                 :             : 
     661                 :             :     // Test: Two addresses with same IP but different ports can map to
     662                 :             :     //  different buckets because they have different keys.
     663                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     664                 :             : 
     665   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     666   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, ngm_asmap) != info2.GetTriedBucket(nKey1, ngm_asmap));
             +  -  +  - ]
     667                 :             : 
     668                 :           1 :     std::set<int> buckets;
     669         [ +  + ]:         256 :     for (int j = 0; j < 255; j++) {
     670                 :         255 :         AddrInfo infoj = AddrInfo(
     671   [ +  -  +  -  :         765 :             CAddress(ResolveService("101." + ToString(j) + ".1.1"), NODE_NONE),
                   +  - ]
     672   [ +  -  +  -  :        1020 :             ResolveIP("101." + ToString(j) + ".1.1"));
                   +  - ]
     673         [ +  - ]:         255 :         int bucket = infoj.GetTriedBucket(nKey1, ngm_asmap);
     674         [ +  - ]:         255 :         buckets.insert(bucket);
     675                 :         255 :     }
     676                 :             :     // Test: IP addresses in the different /16 prefix MAY map to more than
     677                 :             :     // 8 buckets.
     678   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() > 8);
     679                 :             : 
     680                 :           1 :     buckets.clear();
     681         [ +  + ]:         256 :     for (int j = 0; j < 255; j++) {
     682                 :         255 :         AddrInfo infoj = AddrInfo(
     683   [ +  -  +  -  :         765 :             CAddress(ResolveService("250." + ToString(j) + ".1.1"), NODE_NONE),
                   +  - ]
     684   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(j) + ".1.1"));
                   +  - ]
     685         [ +  - ]:         255 :         int bucket = infoj.GetTriedBucket(nKey1, ngm_asmap);
     686         [ +  - ]:         255 :         buckets.insert(bucket);
     687                 :         255 :     }
     688                 :             :     // Test: IP addresses in the different /16 prefix MAY NOT map to more than
     689                 :             :     // 8 buckets.
     690   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() == 8);
     691                 :           3 : }
     692                 :             : 
     693   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     694                 :             : {
     695                 :           1 :     std::vector<bool> asmap = FromBytes(test::data::asmap);
     696         [ +  - ]:           1 :     NetGroupManager ngm_asmap{asmap};
     697                 :             : 
     698   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
     699   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
     700                 :             : 
     701   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.2.1");
     702                 :             : 
     703                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     704                 :             : 
     705   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     706   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     707                 :             : 
     708                 :             :     // Test: Make sure the buckets are what we expect
     709   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, ngm_asmap), 795);
                   +  - ]
     710   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, source1, ngm_asmap), 795);
                   +  - ]
     711                 :             : 
     712                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     713                 :             :     //  this test could be a security issue.
     714   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetNewBucket(nKey1, ngm_asmap) != info1.GetNewBucket(nKey2, ngm_asmap));
             +  -  +  - ]
     715                 :             : 
     716                 :             :     // Test: Ports should not affect bucket placement in the addr
     717                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     718   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     719   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, ngm_asmap), info2.GetNewBucket(nKey1, ngm_asmap));
             +  -  +  - ]
     720                 :             : 
     721                 :           1 :     std::set<int> buckets;
     722         [ +  + ]:         256 :     for (int i = 0; i < 255; i++) {
     723                 :         255 :         AddrInfo infoi = AddrInfo(
     724   [ +  -  +  -  :         510 :             CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
                   +  - ]
     725   [ +  -  +  -  :         765 :             ResolveIP("250.1.1." + ToString(i)));
                   +  - ]
     726         [ +  - ]:         255 :         int bucket = infoi.GetNewBucket(nKey1, ngm_asmap);
     727         [ +  - ]:         255 :         buckets.insert(bucket);
     728                 :         255 :     }
     729                 :             :     // Test: IP addresses in the same /16 prefix
     730                 :             :     // usually map to the same bucket.
     731   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 1U);
     732                 :             : 
     733                 :           1 :     buckets.clear();
     734         [ +  + ]:        1021 :     for (int j = 0; j < 4 * 255; j++) {
     735                 :        1020 :         AddrInfo infoj = AddrInfo(CAddress(
     736                 :        1020 :                                         ResolveService(
     737   [ +  -  +  -  :        4080 :                                             ToString(250 + (j / 255)) + "." + ToString(j % 256) + ".1.1"), NODE_NONE),
             +  -  +  - ]
     738   [ +  -  +  - ]:        3060 :             ResolveIP("251.4.1.1"));
     739         [ +  - ]:        1020 :         int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
     740         [ +  - ]:        1020 :         buckets.insert(bucket);
     741                 :        1020 :     }
     742                 :             :     // Test: IP addresses in the same source /16 prefix should not map to more
     743                 :             :     // than 64 buckets.
     744   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() <= 64);
     745                 :             : 
     746                 :           1 :     buckets.clear();
     747         [ +  + ]:         256 :     for (int p = 0; p < 255; p++) {
     748                 :         255 :         AddrInfo infoj = AddrInfo(
     749   [ +  -  +  - ]:         510 :             CAddress(ResolveService("250.1.1.1"), NODE_NONE),
     750   [ +  -  +  -  :        1020 :             ResolveIP("101." + ToString(p) + ".1.1"));
                   +  - ]
     751         [ +  - ]:         255 :         int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
     752         [ +  - ]:         255 :         buckets.insert(bucket);
     753                 :         255 :     }
     754                 :             :     // Test: IP addresses in the different source /16 prefixes usually map to MORE
     755                 :             :     // than 1 bucket.
     756   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() > 1);
     757                 :             : 
     758                 :           1 :     buckets.clear();
     759         [ +  + ]:         256 :     for (int p = 0; p < 255; p++) {
     760                 :         255 :         AddrInfo infoj = AddrInfo(
     761   [ +  -  +  - ]:         510 :             CAddress(ResolveService("250.1.1.1"), NODE_NONE),
     762   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(p) + ".1.1"));
                   +  - ]
     763         [ +  - ]:         255 :         int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
     764         [ +  - ]:         255 :         buckets.insert(bucket);
     765                 :         255 :     }
     766                 :             :     // Test: IP addresses in the different source /16 prefixes sometimes map to NO MORE
     767                 :             :     // than 1 bucket.
     768   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() == 1);
     769                 :           3 : }
     770                 :             : 
     771   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_serialization)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     772                 :             : {
     773                 :           1 :     std::vector<bool> asmap1 = FromBytes(test::data::asmap);
     774         [ +  - ]:           1 :     NetGroupManager netgroupman{asmap1};
     775                 :             : 
     776         [ +  - ]:           1 :     const auto ratio = GetCheckRatio(m_node);
     777         [ +  - ]:           1 :     auto addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     778         [ +  - ]:           1 :     auto addrman_asmap1_dup = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     779         [ +  - ]:           1 :     auto addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
     780                 :             : 
     781                 :           1 :     DataStream stream{};
     782                 :             : 
     783   [ +  -  +  - ]:           2 :     CAddress addr = CAddress(ResolveService("250.1.1.1"), NODE_NONE);
     784         [ +  - ]:           1 :     CNetAddr default_source;
     785                 :             : 
     786   [ +  -  +  -  :           2 :     addrman_asmap1->Add({addr}, default_source);
             +  +  -  - ]
     787                 :             : 
     788         [ +  - ]:           1 :     stream << *addrman_asmap1;
     789                 :             :     // serizalizing/deserializing addrman with the same asmap
     790         [ +  - ]:           1 :     stream >> *addrman_asmap1_dup;
     791                 :             : 
     792         [ +  - ]:           1 :     AddressPosition addr_pos1 = addrman_asmap1->FindAddressEntry(addr).value();
     793         [ +  - ]:           1 :     AddressPosition addr_pos2 = addrman_asmap1_dup->FindAddressEntry(addr).value();
     794   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1.multiplicity != 0);
                   +  - ]
     795   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos2.multiplicity != 0);
                   +  - ]
     796                 :             : 
     797   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1 == addr_pos2);
                   +  - ]
     798                 :             : 
     799                 :             :     // deserializing asmaped peers.dat to non-asmaped addrman
     800         [ +  - ]:           1 :     stream << *addrman_asmap1;
     801         [ +  - ]:           1 :     stream >> *addrman_noasmap;
     802         [ +  - ]:           1 :     AddressPosition addr_pos3 = addrman_noasmap->FindAddressEntry(addr).value();
     803   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos3.multiplicity != 0);
                   +  - ]
     804   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1.bucket != addr_pos3.bucket);
                   +  - ]
     805   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1.position != addr_pos3.position);
                   +  - ]
     806                 :             : 
     807                 :             :     // deserializing non-asmaped peers.dat to asmaped addrman
     808         [ +  - ]:           2 :     addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     809         [ +  - ]:           2 :     addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
     810   [ +  -  +  -  :           2 :     addrman_noasmap->Add({addr}, default_source);
             +  +  -  - ]
     811         [ +  - ]:           1 :     stream << *addrman_noasmap;
     812         [ +  - ]:           1 :     stream >> *addrman_asmap1;
     813                 :             : 
     814         [ +  - ]:           1 :     AddressPosition addr_pos4 = addrman_asmap1->FindAddressEntry(addr).value();
     815   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos4.multiplicity != 0);
                   +  - ]
     816   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos4.bucket != addr_pos3.bucket);
                   +  - ]
     817   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos4 == addr_pos2);
                   +  - ]
     818                 :             : 
     819                 :             :     // used to map to different buckets, now maps to the same bucket.
     820         [ +  - ]:           2 :     addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     821         [ +  - ]:           2 :     addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
     822   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.1.1"), NODE_NONE);
     823   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.2.1.1"), NODE_NONE);
     824   [ +  -  +  -  :           4 :     addrman_noasmap->Add({addr, addr2}, default_source);
             +  +  -  - ]
     825         [ +  - ]:           1 :     AddressPosition addr_pos5 = addrman_noasmap->FindAddressEntry(addr1).value();
     826         [ +  - ]:           1 :     AddressPosition addr_pos6 = addrman_noasmap->FindAddressEntry(addr2).value();
     827   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos5.bucket != addr_pos6.bucket);
                   +  - ]
     828         [ +  - ]:           1 :     stream << *addrman_noasmap;
     829         [ +  - ]:           1 :     stream >> *addrman_asmap1;
     830         [ +  - ]:           1 :     AddressPosition addr_pos7 = addrman_asmap1->FindAddressEntry(addr1).value();
     831         [ +  - ]:           1 :     AddressPosition addr_pos8 = addrman_asmap1->FindAddressEntry(addr2).value();
     832   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos7.bucket == addr_pos8.bucket);
                   +  - ]
     833   [ +  -  +  - ]:           2 :     BOOST_CHECK(addr_pos7.position != addr_pos8.position);
     834                 :           4 : }
     835                 :             : 
     836   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(remove_invalid)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     837                 :             : {
     838                 :             :     // Confirm that invalid addresses are ignored in unserialization.
     839                 :             : 
     840                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     841                 :           1 :     DataStream stream{};
     842                 :             : 
     843   [ +  -  +  - ]:           2 :     const CAddress new1{ResolveService("5.5.5.5"), NODE_NONE};
     844   [ +  -  +  - ]:           2 :     const CAddress new2{ResolveService("6.6.6.6"), NODE_NONE};
     845   [ +  -  +  - ]:           2 :     const CAddress tried1{ResolveService("7.7.7.7"), NODE_NONE};
     846   [ +  -  +  - ]:           2 :     const CAddress tried2{ResolveService("8.8.8.8"), NODE_NONE};
     847                 :             : 
     848   [ +  -  +  -  :           6 :     addrman->Add({new1, tried1, new2, tried2}, CNetAddr{});
          +  -  +  +  -  
                      - ]
     849         [ +  - ]:           1 :     addrman->Good(tried1);
     850         [ +  - ]:           1 :     addrman->Good(tried2);
     851   [ +  -  +  -  :           1 :     BOOST_REQUIRE_EQUAL(addrman->Size(), 4);
                   +  - ]
     852                 :             : 
     853         [ +  - ]:           1 :     stream << *addrman;
     854                 :             : 
     855         [ +  - ]:           1 :     const std::string str{stream.str()};
     856                 :           1 :     size_t pos;
     857                 :             : 
     858                 :           1 :     const char new2_raw[]{6, 6, 6, 6};
     859                 :           1 :     const uint8_t new2_raw_replacement[]{0, 0, 0, 0}; // 0.0.0.0 is !IsValid()
     860                 :           1 :     pos = str.find(new2_raw, 0, sizeof(new2_raw));
     861   [ +  -  +  -  :           2 :     BOOST_REQUIRE(pos != std::string::npos);
                   +  - ]
     862   [ +  -  -  +  :           2 :     BOOST_REQUIRE(pos + sizeof(new2_raw_replacement) <= stream.size());
                   +  - ]
     863                 :           1 :     memcpy(stream.data() + pos, new2_raw_replacement, sizeof(new2_raw_replacement));
     864                 :             : 
     865                 :           1 :     const char tried2_raw[]{8, 8, 8, 8};
     866                 :           1 :     const uint8_t tried2_raw_replacement[]{255, 255, 255, 255}; // 255.255.255.255 is !IsValid()
     867                 :           1 :     pos = str.find(tried2_raw, 0, sizeof(tried2_raw));
     868   [ +  -  +  -  :           2 :     BOOST_REQUIRE(pos != std::string::npos);
                   +  - ]
     869   [ +  -  -  +  :           2 :     BOOST_REQUIRE(pos + sizeof(tried2_raw_replacement) <= stream.size());
             +  -  +  - ]
     870         [ +  - ]:           1 :     memcpy(stream.data() + pos, tried2_raw_replacement, sizeof(tried2_raw_replacement));
     871                 :             : 
     872   [ +  -  +  - ]:           2 :     addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     873         [ +  - ]:           1 :     stream >> *addrman;
     874   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2);
                   +  - ]
     875                 :           2 : }
     876                 :             : 
     877   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_selecttriedcollision)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     878                 :             : {
     879                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     880                 :             : 
     881   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() == 0);
             +  -  +  - ]
     882                 :             : 
     883                 :             :     // Empty addrman should return blank addrman info.
     884   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
          +  -  +  -  +  
                      - ]
     885                 :             : 
     886                 :             :     // Add twenty two addresses.
     887   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     888         [ +  + ]:          23 :     for (unsigned int i = 1; i < 23; i++) {
     889   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     890   [ +  -  +  -  :         110 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     891                 :             : 
     892                 :             :         // No collisions in tried.
     893   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->Good(addr));
             +  -  +  - ]
     894   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     895                 :          22 :     }
     896                 :             : 
     897                 :             :     // Ensure Good handles duplicates well.
     898                 :             :     // If an address is a duplicate, Good will return false but will not count it as a collision.
     899         [ +  + ]:          23 :     for (unsigned int i = 1; i < 23; i++) {
     900   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     901                 :             : 
     902                 :             :         // Unable to add duplicate address to tried table.
     903   [ +  -  +  -  :          44 :         BOOST_CHECK(!addrman->Good(addr));
             +  -  +  - ]
     904                 :             : 
     905                 :             :         // Verify duplicate address not marked as a collision.
     906   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     907                 :          22 :     }
     908         [ +  - ]:          45 : }
     909                 :             : 
     910   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_noevict)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     911                 :             : {
     912                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     913                 :             : 
     914                 :             :     // Add 35 addresses.
     915   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     916         [ +  + ]:          36 :     for (unsigned int i = 1; i < 36; i++) {
     917   [ +  -  +  -  :          70 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     918   [ +  -  +  -  :         175 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     919                 :             : 
     920                 :             :         // No collision yet.
     921   [ +  -  +  -  :          70 :         BOOST_CHECK(addrman->Good(addr));
                   +  - ]
     922                 :          35 :     }
     923                 :             : 
     924                 :             :     // Collision in tried table between 36 and 19.
     925   [ +  -  +  - ]:           1 :     CService addr36 = ResolveService("250.1.1.36");
     926   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr36, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     927   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr36));
             +  -  +  - ]
     928   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.19:0");
             +  -  +  - ]
     929                 :             : 
     930                 :             :     // 36 should be discarded and 19 not evicted.
     931                 :             :     // This means we keep 19 in the tried table and
     932                 :             :     // 36 stays in the new table.
     933         [ +  - ]:           1 :     addrman->ResolveCollisions();
     934   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     935                 :             : 
     936                 :             :     // Lets create two collisions.
     937         [ +  + ]:          23 :     for (unsigned int i = 37; i < 59; i++) {
     938   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     939   [ +  -  +  -  :         110 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     940   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->Good(addr));
                   +  - ]
     941                 :          22 :     }
     942                 :             : 
     943                 :             :     // Cause a collision in the tried table.
     944   [ +  -  +  - ]:           1 :     CService addr59 = ResolveService("250.1.1.59");
     945   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr59, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     946   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr59));
             +  -  +  - ]
     947                 :             : 
     948   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.10:0");
             +  -  +  - ]
     949                 :             : 
     950                 :             :     // Cause a second collision in the new table.
     951   [ +  -  +  -  :           5 :     BOOST_CHECK(!addrman->Add({CAddress(addr36, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     952                 :             : 
     953                 :             :     // 36 still cannot be moved from new to tried due to colliding with 19
     954   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr36));
             +  -  +  - ]
     955   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() != "[::]:0");
          +  -  +  -  +  
                      - ]
     956                 :             : 
     957                 :             :     // Resolve all collisions.
     958         [ +  - ]:           1 :     addrman->ResolveCollisions();
     959   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     960   [ +  -  +  -  :         121 : }
          +  -  +  -  +  
                      - ]
     961                 :             : 
     962   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_evictionworks)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     963                 :             : {
     964                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     965                 :             : 
     966   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() == 0);
             +  -  +  - ]
     967                 :             : 
     968                 :             :     // Empty addrman should return blank addrman info.
     969   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
          +  -  +  -  +  
                      - ]
     970                 :             : 
     971                 :             :     // Add 35 addresses
     972   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     973         [ +  + ]:          36 :     for (unsigned int i = 1; i < 36; i++) {
     974   [ +  -  +  -  :          70 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     975   [ +  -  +  -  :         175 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     976                 :             : 
     977                 :             :         // No collision yet.
     978   [ +  -  +  -  :          70 :         BOOST_CHECK(addrman->Good(addr));
                   +  - ]
     979                 :          35 :     }
     980                 :             : 
     981                 :             :     // Collision between 36 and 19.
     982   [ +  -  +  - ]:           1 :     CService addr = ResolveService("250.1.1.36");
     983   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     984   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr));
             +  -  +  - ]
     985                 :             : 
     986         [ +  - ]:           1 :     auto info = addrman->SelectTriedCollision().first;
     987   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info.ToStringAddrPort(), "250.1.1.19:0");
                   +  - ]
     988                 :             : 
     989                 :             :     // Ensure test of address fails, so that it is evicted.
     990                 :             :     // Update entry in tried by setting last good connection in the deep past.
     991   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(info, NodeSeconds{1s}));
                   +  - ]
     992         [ +  - ]:           1 :     addrman->Attempt(info, /*fCountFailure=*/false, Now<NodeSeconds>() - 61s);
     993                 :             : 
     994                 :             :     // Should swap 36 for 19.
     995         [ +  - ]:           1 :     addrman->ResolveCollisions();
     996   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     997         [ +  - ]:           2 :     AddressPosition addr_pos{addrman->FindAddressEntry(CAddress(addr, NODE_NONE)).value()};
     998   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos.tried);
                   +  - ]
     999                 :             : 
    1000                 :             :     // If 36 was swapped for 19, then adding 36 to tried should fail because we
    1001                 :             :     // are attempting to add a duplicate.
    1002                 :             :     // We check this by verifying Good() returns false and also verifying that
    1003                 :             :     // we have no collisions.
    1004   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr));
             +  -  +  - ]
    1005   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
          +  -  +  -  +  
                      - ]
    1006                 :             : 
    1007                 :             :     // 19 should fail as a collision (not a duplicate) if we now attempt to move
    1008                 :             :     // it to the tried table.
    1009   [ +  -  +  - ]:           1 :     CService addr19 = ResolveService("250.1.1.19");
    1010   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr19));
             +  -  +  - ]
    1011   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.36:0");
             +  -  +  - ]
    1012                 :             : 
    1013                 :             :     // Eviction is also successful if too much time has passed since last try
    1014   [ +  -  +  - ]:           1 :     SetMockTime(GetTime() + 4 * 60 *60);
    1015         [ +  - ]:           1 :     addrman->ResolveCollisions();
    1016   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
    1017                 :             :     //Now 19 is in tried again, and 36 back to new
    1018         [ +  - ]:           2 :     AddressPosition addr_pos19{addrman->FindAddressEntry(CAddress(addr19, NODE_NONE)).value()};
    1019   [ +  -  +  - ]:           2 :     BOOST_CHECK(addr_pos19.tried);
    1020         [ +  - ]:           2 :     AddressPosition addr_pos36{addrman->FindAddressEntry(CAddress(addr, NODE_NONE)).value()};
    1021   [ +  -  +  - ]:           2 :     BOOST_CHECK(!addr_pos36.tried);
    1022   [ +  -  +  - ]:          73 : }
    1023                 :             : 
    1024                 :           2 : static auto AddrmanToStream(const AddrMan& addrman)
    1025                 :             : {
    1026                 :           2 :     DataStream ssPeersIn{};
    1027   [ +  -  +  - ]:           2 :     ssPeersIn << Params().MessageStart();
    1028         [ +  - ]:           2 :     ssPeersIn << addrman;
    1029                 :           2 :     return ssPeersIn;
    1030                 :           0 : }
    1031                 :             : 
    1032   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(load_addrman)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1033                 :             : {
    1034                 :           1 :     AddrMan addrman{EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node)};
    1035                 :             : 
    1036                 :           1 :     std::optional<CService> addr1, addr2, addr3, addr4;
    1037   [ +  -  +  -  :           2 :     addr1 = Lookup("250.7.1.1", 8333, false);
                   +  - ]
    1038   [ +  -  +  -  :           2 :     BOOST_CHECK(addr1.has_value());
                   +  - ]
    1039   [ +  -  +  -  :           2 :     addr2 = Lookup("250.7.2.2", 9999, false);
                   +  - ]
    1040   [ +  -  +  -  :           2 :     BOOST_CHECK(addr2.has_value());
                   +  - ]
    1041   [ +  -  +  -  :           2 :     addr3 = Lookup("250.7.3.3", 9999, false);
                   +  - ]
    1042   [ +  -  +  -  :           2 :     BOOST_CHECK(addr3.has_value());
                   +  - ]
    1043   [ +  -  +  - ]:           3 :     addr3 = Lookup("250.7.3.3"s, 9999, false);
    1044   [ +  -  +  -  :           2 :     BOOST_CHECK(addr3.has_value());
                   +  - ]
    1045   [ +  -  +  - ]:           3 :     addr4 = Lookup("250.7.3.3\0example.com"s, 9999, false);
    1046   [ +  -  +  -  :           2 :     BOOST_CHECK(!addr4.has_value());
                   +  - ]
    1047                 :             : 
    1048                 :             :     // Add three addresses to new table.
    1049   [ +  -  +  -  :           2 :     const std::optional<CService> source{Lookup("252.5.1.1", 8333, false)};
                   +  - ]
    1050   [ +  -  +  -  :           2 :     BOOST_CHECK(source.has_value());
                   +  - ]
    1051   [ +  +  -  - ]:           8 :     std::vector<CAddress> addresses{CAddress(addr1.value(), NODE_NONE), CAddress(addr2.value(), NODE_NONE), CAddress(addr3.value(), NODE_NONE)};
    1052   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman.Add(addresses, source.value()));
          +  -  +  -  +  
                      - ]
    1053   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman.Size() == 3);
             +  -  +  - ]
    1054                 :             : 
    1055                 :             :     // Test that the de-serialization does not throw an exception.
    1056         [ +  - ]:           1 :     auto ssPeers1{AddrmanToStream(addrman)};
    1057                 :           1 :     bool exceptionThrown = false;
    1058   [ +  -  +  - ]:           1 :     AddrMan addrman1{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1059                 :             : 
    1060   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman1.Size() == 0);
             +  -  +  - ]
    1061                 :           1 :     try {
    1062                 :           1 :         unsigned char pchMsgTmp[4];
    1063         [ +  - ]:           1 :         ssPeers1 >> pchMsgTmp;
    1064         [ +  - ]:           1 :         ssPeers1 >> addrman1;
    1065         [ -  - ]:           0 :     } catch (const std::exception&) {
    1066                 :           0 :         exceptionThrown = true;
    1067                 :           0 :     }
    1068                 :             : 
    1069   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman1.Size() == 3);
             +  -  +  - ]
    1070   [ +  -  +  -  :           2 :     BOOST_CHECK(exceptionThrown == false);
                   +  - ]
    1071                 :             : 
    1072                 :             :     // Test that ReadFromStream creates an addrman with the correct number of addrs.
    1073         [ +  - ]:           1 :     DataStream ssPeers2 = AddrmanToStream(addrman);
    1074                 :             : 
    1075   [ +  -  +  - ]:           1 :     AddrMan addrman2{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1076   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman2.Size() == 0);
             +  -  +  - ]
    1077         [ +  - ]:           1 :     ReadFromStream(addrman2, ssPeers2);
    1078   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman2.Size() == 3);
                   +  - ]
    1079   [ +  -  +  -  :           5 : }
          +  -  -  +  -  
                      - ]
    1080                 :             : 
    1081                 :             : // Produce a corrupt peers.dat that claims 20 addrs when it only has one addr.
    1082                 :           2 : static auto MakeCorruptPeersDat()
    1083                 :             : {
    1084                 :           2 :     DataStream s{};
    1085   [ +  -  +  - ]:           2 :     s << ::Params().MessageStart();
    1086                 :             : 
    1087                 :           2 :     unsigned char nVersion = 1;
    1088         [ +  - ]:           2 :     s << nVersion;
    1089         [ +  - ]:           2 :     s << ((unsigned char)32);
    1090         [ +  - ]:           2 :     s << uint256::ONE;
    1091         [ +  - ]:           2 :     s << 10; // nNew
    1092         [ +  - ]:           2 :     s << 10; // nTried
    1093                 :             : 
    1094                 :           2 :     int nUBuckets = ADDRMAN_NEW_BUCKET_COUNT ^ (1 << 30);
    1095         [ +  - ]:           2 :     s << nUBuckets;
    1096                 :             : 
    1097   [ +  -  +  -  :           4 :     const std::optional<CService> serv{Lookup("252.1.1.1", 7777, false)};
                   +  - ]
    1098   [ +  -  +  -  :           4 :     BOOST_REQUIRE(serv.has_value());
                   +  - ]
    1099         [ +  - ]:           2 :     CAddress addr = CAddress(serv.value(), NODE_NONE);
    1100   [ +  -  +  -  :           4 :     std::optional<CNetAddr> resolved{LookupHost("252.2.2.2", false)};
                   +  - ]
    1101   [ +  -  +  -  :           4 :     BOOST_REQUIRE(resolved.has_value());
                   +  - ]
    1102         [ +  - ]:           2 :     AddrInfo info = AddrInfo(addr, resolved.value());
    1103         [ +  - ]:           2 :     s << CAddress::V1_DISK(info);
    1104                 :             : 
    1105                 :           2 :     return s;
    1106                 :           2 : }
    1107                 :             : 
    1108   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(load_addrman_corrupted)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1109                 :             : {
    1110                 :             :     // Test that the de-serialization of corrupted peers.dat throws an exception.
    1111                 :           1 :     auto ssPeers1{MakeCorruptPeersDat()};
    1112                 :           1 :     bool exceptionThrown = false;
    1113   [ +  -  +  - ]:           1 :     AddrMan addrman1{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1114   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman1.Size() == 0);
             +  -  +  - ]
    1115                 :           1 :     try {
    1116                 :           1 :         unsigned char pchMsgTmp[4];
    1117         [ +  - ]:           1 :         ssPeers1 >> pchMsgTmp;
    1118         [ -  + ]:           1 :         ssPeers1 >> addrman1;
    1119         [ -  + ]:           1 :     } catch (const std::exception&) {
    1120                 :           1 :         exceptionThrown = true;
    1121                 :           1 :     }
    1122   [ +  -  +  -  :           2 :     BOOST_CHECK(exceptionThrown);
                   +  - ]
    1123                 :             : 
    1124                 :             :     // Test that ReadFromStream fails if peers.dat is corrupt
    1125         [ +  - ]:           1 :     auto ssPeers2{MakeCorruptPeersDat()};
    1126                 :             : 
    1127   [ +  -  +  - ]:           1 :     AddrMan addrman2{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1128   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman2.Size() == 0);
             +  -  +  - ]
    1129   [ +  -  -  +  :           2 :     BOOST_CHECK_THROW(ReadFromStream(addrman2, ssPeers2), std::ios_base::failure);
          -  -  -  -  -  
             +  +  -  +  
                      - ]
    1130                 :           1 : }
    1131                 :             : 
    1132   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_update_address)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1133                 :             : {
    1134                 :             :     // Tests updating nTime via Connected() and nServices via SetServices() and Add()
    1135                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
    1136   [ +  -  +  - ]:           1 :     CNetAddr source{ResolveIP("252.2.2.2")};
    1137   [ +  -  +  - ]:           2 :     CAddress addr{CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE)};
    1138                 :             : 
    1139                 :           1 :     const auto start_time{Now<NodeSeconds>() - 10000s};
    1140                 :           1 :     addr.nTime = start_time;
    1141   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr}, source));
          +  -  +  -  +  
                +  -  - ]
    1142   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
    1143                 :             : 
    1144                 :             :     // Updating an addrman entry with a different port doesn't change it
    1145   [ +  -  +  - ]:           2 :     CAddress addr_diff_port{CAddress(ResolveService("250.1.1.1", 8334), NODE_NONE)};
    1146                 :           1 :     addr_diff_port.nTime = start_time;
    1147         [ +  - ]:           1 :     addrman->Connected(addr_diff_port);
    1148         [ +  - ]:           1 :     addrman->SetServices(addr_diff_port, NODE_NETWORK_LIMITED);
    1149         [ +  - ]:           1 :     std::vector<CAddress> vAddr1{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1150   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr1.size(), 1U);
                   +  - ]
    1151   [ +  -  +  -  :           2 :     BOOST_CHECK(vAddr1.at(0).nTime == start_time);
             +  -  +  - ]
    1152   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr1.at(0).nServices, NODE_NONE);
                   +  - ]
    1153                 :             : 
    1154                 :             :     // Updating an addrman entry with the correct port is successful
    1155         [ +  - ]:           1 :     addrman->Connected(addr);
    1156         [ +  - ]:           1 :     addrman->SetServices(addr, NODE_NETWORK_LIMITED);
    1157         [ +  - ]:           1 :     std::vector<CAddress> vAddr2 = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
    1158   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr2.size(), 1U);
                   +  - ]
    1159   [ +  -  +  -  :           2 :     BOOST_CHECK(vAddr2.at(0).nTime >= start_time + 10000s);
             +  -  +  - ]
    1160   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr2.at(0).nServices, NODE_NETWORK_LIMITED);
                   +  - ]
    1161                 :             : 
    1162                 :             :     // Updating an existing addr through Add() (used in gossip relay) can add additional services but can't remove existing ones.
    1163   [ +  -  +  - ]:           2 :     CAddress addr_v2{CAddress(ResolveService("250.1.1.1", 8333), NODE_P2P_V2)};
    1164                 :           1 :     addr_v2.nTime = start_time;
    1165   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Add({addr_v2}, source));
          +  -  +  -  +  
                +  -  - ]
    1166         [ +  - ]:           1 :     std::vector<CAddress> vAddr3{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1167   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr3.size(), 1U);
                   +  - ]
    1168   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr3.at(0).nServices, NODE_P2P_V2 | NODE_NETWORK_LIMITED);
                   +  - ]
    1169                 :             : 
    1170                 :             :     // SetServices() (used when we connected to them) overwrites existing service flags
    1171         [ +  - ]:           1 :     addrman->SetServices(addr, NODE_NETWORK);
    1172         [ +  - ]:           1 :     std::vector<CAddress> vAddr4{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1173   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr4.size(), 1U);
                   +  - ]
    1174   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr4.at(0).nServices, NODE_NETWORK);
                   +  - ]
    1175                 :             : 
    1176                 :             :     // Promoting to Tried does not affect the service flags
    1177   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(addr)); // addr has NODE_NONE
             +  -  +  - ]
    1178         [ +  - ]:           1 :     std::vector<CAddress> vAddr5{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1179   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr5.size(), 1U);
                   +  - ]
    1180   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr5.at(0).nServices, NODE_NETWORK);
                   +  - ]
    1181                 :             : 
    1182                 :             :     // Adding service flags even works when the addr is in Tried
    1183   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Add({addr_v2}, source));
          +  -  +  -  +  
                +  -  - ]
    1184         [ +  - ]:           1 :     std::vector<CAddress> vAddr6{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1185   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr6.size(), 1U);
                   +  - ]
    1186   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr6.at(0).nServices, NODE_NETWORK | NODE_P2P_V2);
                   +  - ]
    1187                 :           4 : }
    1188                 :             : 
    1189   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_size)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1190                 :             : {
    1191                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
    1192   [ +  -  +  - ]:           1 :     const CNetAddr source = ResolveIP("252.2.2.2");
    1193                 :             : 
    1194                 :             :     // empty addrman
    1195   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 0U);
                   +  - ]
    1196   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 0U);
                   +  - ]
    1197   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 0U);
                   +  - ]
    1198   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/false), 0U);
                   +  - ]
    1199                 :             : 
    1200                 :             :     // add two ipv4 addresses, one to tried and new
    1201   [ +  -  +  - ]:           2 :     const CAddress addr1{ResolveService("250.1.1.1", 8333), NODE_NONE};
    1202   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr1}, source));
          +  -  +  -  +  
                +  -  - ]
    1203   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(addr1));
             +  -  +  - ]
    1204   [ +  -  +  - ]:           2 :     const CAddress addr2{ResolveService("250.1.1.2", 8333), NODE_NONE};
    1205   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr2}, source));
          +  -  +  -  +  
                +  -  - ]
    1206                 :             : 
    1207   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 2U);
                   +  - ]
    1208   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 2U);
                   +  - ]
    1209   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 1U);
                   +  - ]
    1210   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/false), 1U);
                   +  - ]
    1211   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/true), 1U);
                   +  - ]
    1212   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/false), 1U);
                   +  - ]
    1213                 :             : 
    1214                 :             :     // add one i2p address to new
    1215         [ +  - ]:           1 :     CService i2p_addr;
    1216         [ +  - ]:           1 :     i2p_addr.SetSpecial("UDHDrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.I2P");
    1217                 :           1 :     const CAddress addr3{i2p_addr, NODE_NONE};
    1218   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr3}, source));
          +  -  +  -  +  
                +  -  - ]
    1219   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 3U);
                   +  - ]
    1220   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 2U);
                   +  - ]
    1221   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_I2P, /*in_new=*/std::nullopt), 1U);
                   +  - ]
    1222   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_I2P, /*in_new=*/true), 1U);
                   +  - ]
    1223   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 2U);
                   +  - ]
    1224   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/false), 1U);
                   +  - ]
    1225                 :           4 : }
    1226                 :             : 
    1227                 :             : BOOST_AUTO_TEST_SUITE_END()
        

Generated by: LCOV version 2.0-1