LCOV - code coverage report
Current view: top level - src/test - addrman_tests.cpp (source / functions) Coverage Total Hit
Test: total_coverage.info Lines: 99.5 % 757 753
Test Date: 2026-02-25 05:45:00 Functions: 100.0 % 53 53
Branches: 50.4 % 4890 2464

             Branch data     Line data    Source code
       1                 :             : // Copyright (c) 2012-present The Bitcoin Core developers
       2                 :             : // Distributed under the MIT software license, see the accompanying
       3                 :             : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
       4                 :             : 
       5                 :             : #include <addrdb.h>
       6                 :             : #include <addrman.h>
       7                 :             : #include <addrman_impl.h>
       8                 :             : #include <chainparams.h>
       9                 :             : #include <clientversion.h>
      10                 :             : #include <hash.h>
      11                 :             : #include <netbase.h>
      12                 :             : #include <random.h>
      13                 :             : #include <test/data/asmap.raw.h>
      14                 :             : #include <test/util/setup_common.h>
      15                 :             : #include <util/asmap.h>
      16                 :             : #include <util/string.h>
      17                 :             : 
      18                 :             : #include <boost/test/unit_test.hpp>
      19                 :             : 
      20                 :             : #include <cstdint>
      21                 :             : #include <optional>
      22                 :             : #include <string>
      23                 :             : 
      24                 :             : using namespace std::literals;
      25                 :             : using node::NodeContext;
      26                 :             : using util::ToString;
      27                 :             : 
      28                 :             : static auto EMPTY_NETGROUPMAN{NetGroupManager::NoAsmap()};
      29                 :             : static const bool DETERMINISTIC{true};
      30                 :             : 
      31                 :          25 : static int32_t GetCheckRatio(const NodeContext& node_ctx)
      32                 :             : {
      33         [ +  - ]:          75 :     return std::clamp<int32_t>(node_ctx.args->GetIntArg("-checkaddrman", 100), 0, 1000000);
      34                 :             : }
      35                 :             : 
      36                 :        6821 : static CNetAddr ResolveIP(const std::string& ip)
      37                 :             : {
      38         [ +  - ]:        6821 :     const std::optional<CNetAddr> addr{LookupHost(ip, false)};
      39   [ +  -  +  -  :        6821 :     BOOST_CHECK_MESSAGE(addr.has_value(), strprintf("failed to resolve: %s", ip));
                   +  - ]
      40         [ +  - ]:        6821 :     return addr.value_or(CNetAddr{});
      41                 :        6821 : }
      42                 :             : 
      43                 :        6633 : static CService ResolveService(const std::string& ip, uint16_t port = 0)
      44                 :             : {
      45         [ +  - ]:        6633 :     const std::optional<CService> serv{Lookup(ip, port, false)};
      46   [ +  -  +  -  :       13266 :     BOOST_CHECK_MESSAGE(serv.has_value(), strprintf("failed to resolve: %s:%i", ip, port));
                   +  - ]
      47         [ +  - ]:        6633 :     return serv.value_or(CService{});
      48                 :        6633 : }
      49                 :             : 
      50                 :             : BOOST_FIXTURE_TEST_SUITE(addrman_tests, BasicTestingSetup)
      51                 :             : 
      52   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_simple)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
      53                 :             : {
      54                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
      55                 :             : 
      56   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
      57                 :             : 
      58                 :             :     // Test: Does Addrman respond correctly when empty.
      59   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 0U);
                   +  - ]
      60         [ +  - ]:           1 :     auto addr_null = addrman->Select().first;
      61   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addr_null.ToStringAddrPort(), "[::]:0");
                   +  - ]
      62                 :             : 
      63                 :             :     // Test: Does Addrman::Add work as expected.
      64   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
      65   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
      66   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
      67         [ +  - ]:           1 :     auto addr_ret1 = addrman->Select().first;
      68   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addr_ret1.ToStringAddrPort(), "250.1.1.1:8333");
                   +  - ]
      69                 :             : 
      70                 :             :     // Test: Does IP address deduplication work correctly.
      71                 :             :     //  Expected dup IP should not be added.
      72   [ +  -  +  - ]:           1 :     CService addr1_dup = ResolveService("250.1.1.1", 8333);
      73   [ +  -  +  -  :           5 :     BOOST_CHECK(!addrman->Add({CAddress(addr1_dup, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
      74   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
      75                 :             : 
      76                 :             : 
      77                 :             :     // Test: New table has one addr and we add a diff addr we should
      78                 :             :     //  have at least one addr.
      79                 :             :     // Note that addrman's size cannot be tested reliably after insertion, as
      80                 :             :     // hash collisions may occur. But we can always be sure of at least one
      81                 :             :     // success.
      82                 :             : 
      83   [ +  -  +  - ]:           1 :     CService addr2 = ResolveService("250.1.1.2", 8333);
      84   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
      85   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() >= 1);
             +  -  +  - ]
      86                 :             : 
      87                 :             :     // Test: reset addrman and test AddrMan::Add multiple addresses works as expected
      88   [ +  -  +  - ]:           2 :     addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
      89                 :           1 :     std::vector<CAddress> vAddr;
      90   [ +  -  +  -  :           2 :     vAddr.emplace_back(ResolveService("250.1.1.3", 8333), NODE_NONE);
                   +  - ]
      91   [ +  -  +  -  :           2 :     vAddr.emplace_back(ResolveService("250.1.1.4", 8333), NODE_NONE);
                   +  - ]
      92   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Add(vAddr, source));
             +  -  +  - ]
      93   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() >= 1);
                   +  - ]
      94   [ +  -  +  -  :           7 : }
                   +  - ]
      95                 :             : 
      96   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_penalty_self_announcement)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
      97                 :             : {
      98                 :           1 :     SetMockTime(Now<NodeSeconds>());
      99                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     100                 :             : 
     101                 :           1 :     const auto base_time{Now<NodeSeconds>() - 10000s};
     102   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     103   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.1.1"); // Same as addr1 - self announcement
     104                 :             : 
     105                 :           1 :     CAddress caddr1(addr1, NODE_NONE);
     106                 :           1 :     caddr1.nTime = base_time;
     107                 :             : 
     108                 :           1 :     const auto time_penalty{3600s};
     109                 :             : 
     110   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({caddr1}, source1, time_penalty));
          +  -  +  -  +  
                +  -  - ]
     111                 :             : 
     112         [ +  - ]:           1 :     auto addr_pos1{addrman->FindAddressEntry(caddr1)};
     113   [ +  -  +  -  :           2 :     BOOST_REQUIRE(addr_pos1.has_value());
                   +  - ]
     114                 :             : 
     115         [ +  - ]:           1 :     std::vector<CAddress> addresses{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
     116   [ +  -  -  +  :           1 :     BOOST_REQUIRE_EQUAL(addresses.size(), 1U);
                   +  - ]
     117                 :             : 
     118   [ +  -  +  -  :           2 :     BOOST_CHECK(addresses[0].nTime == base_time);
                   +  - ]
     119                 :             : 
     120   [ +  -  +  - ]:           1 :     CService addr2{ResolveService("250.1.1.2", 8333)};
     121   [ +  -  +  - ]:           1 :     CNetAddr source2{ResolveIP("250.1.1.3")}; // Different from addr2 - not self announcement
     122                 :             : 
     123                 :           1 :     CAddress caddr2(addr2, NODE_NONE);
     124                 :           1 :     caddr2.nTime = base_time;
     125                 :             : 
     126   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({caddr2}, source2, time_penalty));
          +  -  +  -  +  
                +  -  - ]
     127                 :             : 
     128         [ +  - ]:           2 :     addresses = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
     129   [ +  -  -  +  :           1 :     BOOST_REQUIRE_EQUAL(addresses.size(), 2U);
                   +  - ]
     130                 :             : 
     131                 :           1 :     CAddress retrieved_addr2{addresses[0]};
     132   [ +  -  +  - ]:           2 :     BOOST_CHECK(retrieved_addr2.nTime == base_time - time_penalty);
     133                 :           3 : }
     134                 :             : 
     135   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_ports)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     136                 :             : {
     137                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     138                 :             : 
     139   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     140                 :             : 
     141   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 0U);
                   +  - ]
     142                 :             : 
     143                 :             :     // Test 7; Addr with same IP but diff port does not replace existing addr.
     144   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     145   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     146   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     147                 :             : 
     148   [ +  -  +  - ]:           1 :     CService addr1_port = ResolveService("250.1.1.1", 8334);
     149   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1_port, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     150   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2U);
                   +  - ]
     151         [ +  - ]:           1 :     auto addr_ret2 = addrman->Select().first;
     152   [ +  -  +  -  :           3 :     BOOST_CHECK(addr_ret2.ToStringAddrPort() == "250.1.1.1:8333" || addr_ret2.ToStringAddrPort() == "250.1.1.1:8334");
          -  +  -  -  -  
          -  +  -  -  +  
             -  -  -  - ]
     153                 :             : 
     154                 :             :     // Test: Add same IP but diff port to tried table; this converts the entry with
     155                 :             :     // the specified port to tried, but not the other.
     156         [ +  - ]:           2 :     addrman->Good(CAddress(addr1_port, NODE_NONE));
     157   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2U);
                   +  - ]
     158                 :           1 :     bool new_only = true;
     159         [ +  - ]:           1 :     auto addr_ret3 = addrman->Select(new_only).first;
     160   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addr_ret3.ToStringAddrPort(), "250.1.1.1:8333");
                   +  - ]
     161   [ +  -  +  - ]:           5 : }
     162                 :             : 
     163   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_select)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     164                 :             : {
     165                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     166   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(false).first.IsValid());
          +  -  +  -  +  
                      - ]
     167   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(true).first.IsValid());
          +  -  +  -  +  
                      - ]
     168                 :             : 
     169   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     170                 :             : 
     171                 :             :     // Add 1 address to the new table
     172   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     173   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     174   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     175                 :             : 
     176   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/true).first == addr1);
          +  -  +  -  +  
                      - ]
     177   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/false).first == addr1);
          +  -  +  -  +  
                      - ]
     178                 :             : 
     179                 :             :     // Move address to the tried table
     180   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr1, NODE_NONE)));
             +  -  +  - ]
     181                 :             : 
     182   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     183   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true).first.IsValid());
          +  -  +  -  +  
                      - ]
     184   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select().first == addr1);
          +  -  +  -  +  
                      - ]
     185   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     186                 :             : 
     187                 :             :     // Add one address to the new table
     188   [ +  -  +  - ]:           1 :     CService addr2 = ResolveService("250.3.1.1", 8333);
     189   [ +  -  +  -  :           6 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, addr2));
          +  -  +  +  +  
                -  -  - ]
     190   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/true).first == addr2);
          +  -  +  -  +  
                      - ]
     191                 :             : 
     192                 :             :     // Add two more addresses to the new table
     193   [ +  -  +  - ]:           1 :     CService addr3 = ResolveService("250.3.2.2", 9999);
     194   [ +  -  +  - ]:           1 :     CService addr4 = ResolveService("250.3.3.3", 9999);
     195                 :             : 
     196   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr3, NODE_NONE)}, addr2));
          +  -  +  +  +  
                -  -  - ]
     197   [ +  -  +  -  :           6 :     BOOST_CHECK(addrman->Add({CAddress(addr4, NODE_NONE)}, ResolveService("250.4.1.1", 8333)));
          +  -  +  -  +  
          -  +  +  +  -  
                   -  - ]
     198                 :             : 
     199                 :             :     // Add three addresses to tried table.
     200   [ +  -  +  - ]:           1 :     CService addr5 = ResolveService("250.4.4.4", 8333);
     201   [ +  -  +  - ]:           1 :     CService addr6 = ResolveService("250.4.5.5", 7777);
     202   [ +  -  +  - ]:           1 :     CService addr7 = ResolveService("250.4.6.6", 8333);
     203                 :             : 
     204   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr5, NODE_NONE)}, addr3));
          +  -  +  +  +  
                -  -  - ]
     205   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr5, NODE_NONE)));
             +  -  +  - ]
     206   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr6, NODE_NONE)}, addr3));
          +  -  +  +  +  
                -  -  - ]
     207   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr6, NODE_NONE)));
             +  -  +  - ]
     208   [ +  -  +  -  :           6 :     BOOST_CHECK(addrman->Add({CAddress(addr7, NODE_NONE)}, ResolveService("250.1.1.3", 8333)));
          +  -  +  -  +  
          -  +  +  +  -  
                   -  - ]
     209   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr7, NODE_NONE)));
             +  -  +  - ]
     210                 :             : 
     211                 :             :     // 6 addrs + 1 addr from last test = 7.
     212   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 7U);
                   +  - ]
     213                 :             : 
     214                 :             :     // Select pulls from new and tried regardless of port number.
     215                 :           1 :     std::set<uint16_t> ports;
     216         [ +  + ]:          21 :     for (int i = 0; i < 20; ++i) {
     217   [ +  -  +  -  :          40 :         ports.insert(addrman->Select().first.GetPort());
                   +  - ]
     218                 :             :     }
     219   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(ports.size(), 3U);
     220   [ +  -  +  -  :          15 : }
          +  -  +  -  +  
             -  +  -  +  
                      - ]
     221                 :             : 
     222   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_select_by_network)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     223                 :             : {
     224                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     225   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_IPV4}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     226   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV4}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     227                 :             : 
     228                 :             :     // add ipv4 address to the new table
     229   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     230   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.1", 8333);
     231   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     232                 :             : 
     233   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                -  +  - ]
     234   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                -  +  - ]
     235   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV6}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     236   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_ONION}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     237   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_I2P}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     238   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_CJDNS}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     239   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_CJDNS}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     240   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/false).first == addr1);
          +  -  +  -  +  
                      - ]
     241                 :             : 
     242                 :             :     // add I2P address to the new table
     243         [ +  - ]:           1 :     CAddress i2p_addr;
     244         [ +  - ]:           1 :     i2p_addr.SetSpecial("udhdrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.i2p");
     245   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({i2p_addr}, source));
          +  -  +  -  +  
                +  -  - ]
     246                 :             : 
     247   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_I2P}).first == i2p_addr);
          +  -  +  -  +  
                -  +  - ]
     248   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_I2P}).first == i2p_addr);
          +  -  +  -  +  
                -  +  - ]
     249   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                -  +  - ]
     250   [ +  -  +  - ]:           2 :     std::unordered_set<Network> nets_with_entries = {NET_IPV4, NET_I2P};
     251   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, nets_with_entries).first.IsValid());
          +  -  +  -  +  
                      - ]
     252   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV6}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     253   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_ONION}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     254   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_CJDNS}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     255   [ +  -  +  - ]:           2 :     std::unordered_set<Network> nets_without_entries = {NET_IPV6, NET_ONION, NET_CJDNS};
     256   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Select(/*new_only=*/false, nets_without_entries).first.IsValid());
          +  -  +  -  +  
                      - ]
     257                 :             : 
     258                 :             :     // bump I2P address to tried table
     259   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(i2p_addr));
             +  -  +  - ]
     260                 :             : 
     261   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_I2P}).first.IsValid());
          +  -  +  -  +  
                -  +  - ]
     262   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_I2P}).first == i2p_addr);
          +  -  +  -  +  
                -  +  - ]
     263                 :             : 
     264                 :             :     // add another I2P address to the new table
     265         [ +  - ]:           1 :     CAddress i2p_addr2;
     266         [ +  - ]:           1 :     i2p_addr2.SetSpecial("c4gfnttsuwqomiygupdqqqyy5y5emnk5c73hrfvatri67prd7vyq.b32.i2p");
     267   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({i2p_addr2}, source));
          +  -  +  -  +  
                +  -  - ]
     268                 :             : 
     269   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_I2P}).first == i2p_addr2);
          +  -  +  -  +  
                      - ]
     270                 :             : 
     271                 :             :     // ensure that both new and tried table are selected from
     272                 :           1 :     bool new_selected{false};
     273                 :           1 :     bool tried_selected{false};
     274                 :           1 :     int counter = 256;
     275                 :             : 
     276   [ +  -  +  + ]:           3 :     while (--counter > 0 && (!new_selected || !tried_selected)) {
     277   [ +  -  +  -  :           4 :         const CAddress selected{addrman->Select(/*new_only=*/false, {NET_I2P}).first};
                   +  - ]
     278   [ +  -  +  -  :           5 :         BOOST_REQUIRE(selected == i2p_addr || selected == i2p_addr2);
          +  +  +  -  +  
             -  +  -  +  
                      - ]
     279   [ +  -  +  + ]:           2 :         if (selected == i2p_addr) {
     280                 :             :             tried_selected = true;
     281                 :             :         } else {
     282                 :           1 :             new_selected = true;
     283                 :             :         }
     284                 :           2 :     }
     285                 :             : 
     286   [ +  -  +  -  :           2 :     BOOST_CHECK(new_selected);
                   +  - ]
     287   [ +  -  +  - ]:           2 :     BOOST_CHECK(tried_selected);
     288         [ +  - ]:           5 : }
     289                 :             : 
     290   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_select_special)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     291                 :             : {
     292                 :             :     // use a non-deterministic addrman to ensure a passing test isn't due to setup
     293                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, /*deterministic=*/false, GetCheckRatio(m_node));
     294                 :             : 
     295   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     296                 :             : 
     297                 :             :     // add I2P address to the tried table
     298         [ +  - ]:           1 :     CAddress i2p_addr;
     299         [ +  - ]:           1 :     i2p_addr.SetSpecial("udhdrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.i2p");
     300   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({i2p_addr}, source));
          +  -  +  -  +  
                +  -  - ]
     301   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(i2p_addr));
             +  -  +  - ]
     302                 :             : 
     303                 :             :     // add ipv4 address to the new table
     304   [ +  -  +  - ]:           1 :     CService addr1 = ResolveService("250.1.1.3", 8333);
     305   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     306                 :             : 
     307                 :             :     // since the only ipv4 address is on the new table, ensure that the new
     308                 :             :     // table gets selected even if new_only is false. if the table was being
     309                 :             :     // selected at random, this test will sporadically fail
     310   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
          +  -  +  -  +  
                      - ]
     311         [ +  - ]:           4 : }
     312                 :             : 
     313   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_new_collisions)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     314                 :             : {
     315                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     316                 :             : 
     317   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     318                 :             : 
     319                 :           1 :     uint32_t num_addrs{0};
     320                 :             : 
     321   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
                   +  - ]
     322                 :             : 
     323         [ +  + ]:          23 :     while (num_addrs < 22) { // Magic number! 250.1.1.1 - 250.1.1.22 do not collide with deterministic key = 1
     324   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     325   [ +  -  +  -  :         110 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     326                 :             : 
     327                 :             :         // Test: No collision in new table yet.
     328   [ +  -  +  -  :          22 :         BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
                   +  - ]
     329                 :          22 :     }
     330                 :             : 
     331                 :             :     // Test: new table collision!
     332   [ +  -  +  -  :           2 :     CService addr1 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     333                 :           1 :     uint32_t collisions{1};
     334   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     335   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs - collisions);
                   +  - ]
     336                 :             : 
     337   [ +  -  +  -  :           2 :     CService addr2 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     338   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     339   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs - collisions);
                   +  - ]
     340   [ +  -  +  -  :          49 : }
                   +  - ]
     341                 :             : 
     342   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_new_multiplicity)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     343                 :             : {
     344                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     345   [ +  -  +  - ]:           2 :     CAddress addr{CAddress(ResolveService("253.3.3.3", 8333), NODE_NONE)};
     346                 :           1 :     const auto start_time{Now<NodeSeconds>()};
     347                 :           1 :     addr.nTime = start_time;
     348                 :             : 
     349                 :             :     // test that multiplicity stays at 1 if nTime doesn't increase
     350         [ +  + ]:          20 :     for (unsigned int i = 1; i < 20; ++i) {
     351   [ +  -  +  -  :          57 :         std::string addr_ip{ToString(i % 256) + "." + ToString(i >> 8 % 256) + ".1.1"};
                   +  - ]
     352         [ +  - ]:          19 :         CNetAddr source{ResolveIP(addr_ip)};
     353   [ +  -  +  -  :          38 :         addrman->Add({addr}, source);
             +  +  -  - ]
     354                 :          19 :     }
     355         [ +  - ]:           1 :     AddressPosition addr_pos = addrman->FindAddressEntry(addr).value();
     356   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(addr_pos.multiplicity, 1U);
     357   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     358                 :             : 
     359                 :             :     // if nTime increases, an addr can occur in up to 8 buckets
     360                 :             :     // The acceptance probability decreases exponentially with existing multiplicity -
     361                 :             :     // choose number of iterations such that it gets to 8 with deterministic addrman.
     362         [ +  + ]:         400 :     for (unsigned int i = 1; i < 400; ++i) {
     363   [ +  -  +  -  :        1197 :         std::string addr_ip{ToString(i % 256) + "." + ToString(i >> 8 % 256) + ".1.1"};
                   +  - ]
     364         [ +  - ]:         399 :         CNetAddr source{ResolveIP(addr_ip)};
     365                 :         399 :         addr.nTime = start_time + std::chrono::seconds{i};
     366   [ +  -  +  -  :         798 :         addrman->Add({addr}, source);
             +  +  -  - ]
     367                 :         399 :     }
     368         [ +  - ]:           1 :     AddressPosition addr_pos_multi = addrman->FindAddressEntry(addr).value();
     369   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(addr_pos_multi.multiplicity, 8U);
     370                 :             :     // multiplicity doesn't affect size
     371   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
     372                 :         419 : }
     373                 :             : 
     374   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_tried_collisions)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     375                 :             : {
     376                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     377                 :             : 
     378   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     379                 :             : 
     380                 :           1 :     uint32_t num_addrs{0};
     381                 :             : 
     382   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
                   +  - ]
     383                 :             : 
     384         [ +  + ]:          36 :     while (num_addrs < 35) { // Magic number! 250.1.1.1 - 250.1.1.35 do not collide in tried with deterministic key = 1
     385   [ +  -  +  -  :          70 :         CService addr = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     386   [ +  -  +  -  :         175 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     387                 :             : 
     388                 :             :         // Test: Add to tried without collision
     389   [ +  -  +  -  :          70 :         BOOST_CHECK(addrman->Good(CAddress(addr, NODE_NONE)));
                   +  - ]
     390                 :             : 
     391                 :          35 :     }
     392                 :             : 
     393                 :             :     // Test: Unable to add to tried table due to collision!
     394   [ +  -  +  -  :           2 :     CService addr1 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     395   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     396   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(CAddress(addr1, NODE_NONE)));
             +  -  +  - ]
     397                 :             : 
     398                 :             :     // Test: Add the next address to tried without collision
     399   [ +  -  +  -  :           2 :     CService addr2 = ResolveService("250.1.1." + ToString(++num_addrs));
                   +  - ]
     400   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     401   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr2, NODE_NONE)));
                   +  - ]
     402   [ +  -  +  -  :          75 : }
                   +  - ]
     403                 :             : 
     404                 :             : 
     405   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_getaddr)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     406                 :             : {
     407                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     408                 :             : 
     409                 :             :     // Test: Sanity check, GetAddr should never return anything if addrman
     410                 :             :     //  is empty.
     411   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 0U);
                   +  - ]
     412         [ +  - ]:           1 :     std::vector<CAddress> vAddr1 = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
     413   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr1.size(), 0U);
                   +  - ]
     414                 :             : 
     415   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.250.2.1", 8333), NODE_NONE);
     416                 :           1 :     addr1.nTime = Now<NodeSeconds>(); // Set time so isTerrible = false
     417   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.251.2.2", 9999), NODE_NONE);
     418                 :           1 :     addr2.nTime = Now<NodeSeconds>();
     419   [ +  -  +  - ]:           2 :     CAddress addr3 = CAddress(ResolveService("251.252.2.3", 8333), NODE_NONE);
     420                 :           1 :     addr3.nTime = Now<NodeSeconds>();
     421   [ +  -  +  - ]:           2 :     CAddress addr4 = CAddress(ResolveService("252.253.3.4", 8333), NODE_NONE);
     422                 :           1 :     addr4.nTime = Now<NodeSeconds>();
     423   [ +  -  +  - ]:           2 :     CAddress addr5 = CAddress(ResolveService("252.254.4.5", 8333), NODE_NONE);
     424                 :           1 :     addr5.nTime = Now<NodeSeconds>();
     425   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.2.1");
     426   [ +  -  +  - ]:           1 :     CNetAddr source2 = ResolveIP("250.2.3.3");
     427                 :             : 
     428                 :             :     // Test: Ensure GetAddr works with new addresses.
     429   [ +  -  +  -  :           6 :     BOOST_CHECK(addrman->Add({addr1, addr3, addr5}, source1));
          +  -  +  -  +  
                +  -  - ]
     430   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({addr2, addr4}, source2));
          +  -  +  -  +  
                +  -  - ]
     431                 :             : 
     432   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 5U);
                   +  - ]
     433                 :             :     // Net processing asks for 23% of addresses. 23% of 5 is 1 rounded down.
     434   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt).size(), 1U);
                   +  - ]
     435                 :             : 
     436                 :             :     // Test: Ensure GetAddr works with new and tried addresses.
     437   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr1, NODE_NONE)));
             +  -  +  - ]
     438   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(CAddress(addr2, NODE_NONE)));
             +  -  +  - ]
     439   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 5U);
                   +  - ]
     440   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt).size(), 1U);
                   +  - ]
     441                 :             : 
     442                 :             :     // Test: Ensure GetAddr still returns 23% when addrman has many addrs.
     443         [ +  + ]:        2048 :     for (unsigned int i = 1; i < (8 * 256); i++) {
     444                 :        2047 :         int octet1 = i % 256;
     445                 :        2047 :         int octet2 = i >> 8 % 256;
     446   [ +  -  +  -  :        6141 :         std::string strAddr = ToString(octet1) + "." + ToString(octet2) + ".1.23";
                   +  - ]
     447         [ +  - ]:        4094 :         CAddress addr = CAddress(ResolveService(strAddr), NODE_NONE);
     448                 :             : 
     449                 :             :         // Ensure that for all addrs in addrman, isTerrible == false.
     450                 :        2047 :         addr.nTime = Now<NodeSeconds>();
     451   [ +  -  +  -  :        6141 :         addrman->Add({addr}, ResolveIP(strAddr));
          +  -  +  +  -  
                      - ]
     452         [ +  + ]:        2047 :         if (i % 8 == 0)
     453         [ +  - ]:         255 :             addrman->Good(addr);
     454                 :        2047 :     }
     455         [ +  - ]:           1 :     std::vector<CAddress> vAddr = addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt);
     456                 :             : 
     457         [ +  - ]:           1 :     size_t percent23 = (addrman->Size() * 23) / 100;
     458   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr.size(), percent23);
                   +  - ]
     459   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr.size(), 461U);
                   +  - ]
     460                 :             :     // (addrman.Size() < number of addresses added) due to address collisions.
     461   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2006U);
                   +  - ]
     462                 :        2050 : }
     463                 :             : 
     464   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(getaddr_unfiltered)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     465                 :             : {
     466                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     467                 :             : 
     468                 :             :     // Set time on this addr so isTerrible = false
     469   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.250.2.1", 8333), NODE_NONE);
     470                 :           1 :     addr1.nTime = Now<NodeSeconds>();
     471                 :             :     // Not setting time so this addr should be isTerrible = true
     472   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.251.2.2", 9999), NODE_NONE);
     473                 :             : 
     474   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("250.1.2.1");
     475   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({addr1, addr2}, source));
          +  -  +  -  +  
                +  -  - ]
     476                 :             : 
     477                 :             :     // Set time on this addr so isTerrible = false
     478   [ +  -  +  - ]:           2 :     CAddress addr3 = CAddress(ResolveService("250.251.2.3", 9998), NODE_NONE);
     479                 :           1 :     addr3.nTime = Now<NodeSeconds>();
     480         [ +  - ]:           1 :     addrman->Good(addr3, /*time=*/Now<NodeSeconds>());
     481   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr3}, source));
          +  -  +  -  +  
                +  -  - ]
     482                 :             :     // The time is set, but after ADDRMAN_RETRIES unsuccessful attempts not
     483                 :             :     // retried in the last minute, this addr should be isTerrible = true
     484         [ +  + ]:           4 :     for (size_t i = 0; i < 3; ++i) {
     485         [ +  - ]:           3 :         addrman->Attempt(addr3, /*fCountFailure=*/true, /*time=*/Now<NodeSeconds>() - 61s);
     486                 :             :     }
     487                 :             : 
     488                 :             :     // Set time more than 10 minutes in the future (flying DeLorean), so this
     489                 :             :     // addr should be isTerrible = true
     490   [ +  -  +  - ]:           2 :     CAddress addr4 = CAddress(ResolveService("250.252.2.4", 9997), NODE_NONE);
     491                 :           1 :     addr4.nTime = Now<NodeSeconds>() + 11min;
     492   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr4}, source));
          +  -  +  -  +  
                +  -  - ]
     493                 :             : 
     494                 :             :     // GetAddr filtered by quality (i.e. not IsTerrible) should only return addr1
     495   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 1U);
                   +  - ]
     496                 :             :     // Unfiltered GetAddr should return all addrs
     497   [ +  -  +  -  :           2 :     BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt, /*filtered=*/false).size(), 4U);
                   +  - ]
     498                 :           4 : }
     499                 :             : 
     500   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket_legacy)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     501                 :             : {
     502         [ +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE);
     503   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.1.1", 9999), NODE_NONE);
     504                 :             : 
     505   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.1.1");
     506                 :             : 
     507                 :             : 
     508                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     509                 :             : 
     510   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     511   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     512                 :             : 
     513   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN), 40);
                   +  - ]
     514                 :             : 
     515                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     516                 :             :     //  this test could be a security issue.
     517   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN) != info1.GetTriedBucket(nKey2, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     518                 :             : 
     519                 :             :     // Test: Two addresses with same IP but different ports can map to
     520                 :             :     //  different buckets because they have different keys.
     521                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     522                 :             : 
     523   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     524   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN) != info2.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     525                 :             : 
     526                 :           1 :     std::set<int> buckets;
     527         [ +  + ]:         256 :     for (int i = 0; i < 255; i++) {
     528                 :         255 :         AddrInfo infoi = AddrInfo(
     529   [ +  -  +  -  :         765 :             CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
                   +  - ]
     530   [ +  -  +  -  :         765 :             ResolveIP("250.1.1." + ToString(i)));
                   +  - ]
     531         [ +  - ]:         255 :         int bucket = infoi.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN);
     532         [ +  - ]:         255 :         buckets.insert(bucket);
     533                 :         255 :     }
     534                 :             :     // Test: IP addresses in the same /16 prefix should
     535                 :             :     // never get more than 8 buckets with legacy grouping
     536   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 8U);
     537                 :             : 
     538                 :           1 :     buckets.clear();
     539         [ +  + ]:         256 :     for (int j = 0; j < 255; j++) {
     540                 :         255 :         AddrInfo infoj = AddrInfo(
     541   [ +  -  +  -  :         765 :             CAddress(ResolveService("250." + ToString(j) + ".1.1"), NODE_NONE),
                   +  - ]
     542   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(j) + ".1.1"));
                   +  - ]
     543         [ +  - ]:         255 :         int bucket = infoj.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN);
     544         [ +  - ]:         255 :         buckets.insert(bucket);
     545                 :         255 :     }
     546                 :             :     // Test: IP addresses in the different /16 prefix should map to more than
     547                 :             :     // 8 buckets with legacy grouping
     548   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 160U);
     549                 :           3 : }
     550                 :             : 
     551   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket_legacy)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     552                 :             : {
     553         [ +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
     554   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
     555                 :             : 
     556   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.2.1");
     557                 :             : 
     558                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     559                 :             : 
     560   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     561   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     562                 :             : 
     563                 :             :     // Test: Make sure the buckets are what we expect
     564   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN), 786);
                   +  - ]
     565   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, source1, EMPTY_NETGROUPMAN), 786);
                   +  - ]
     566                 :             : 
     567                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     568                 :             :     //  this test could be a security issue.
     569   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN) != info1.GetNewBucket(nKey2, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     570                 :             : 
     571                 :             :     // Test: Ports should not affect bucket placement in the addr
     572                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     573   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     574   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN), info2.GetNewBucket(nKey1, EMPTY_NETGROUPMAN));
             +  -  +  - ]
     575                 :             : 
     576                 :           1 :     std::set<int> buckets;
     577         [ +  + ]:         256 :     for (int i = 0; i < 255; i++) {
     578                 :         255 :         AddrInfo infoi = AddrInfo(
     579   [ +  -  +  -  :         510 :             CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
                   +  - ]
     580   [ +  -  +  -  :         765 :             ResolveIP("250.1.1." + ToString(i)));
                   +  - ]
     581         [ +  - ]:         255 :         int bucket = infoi.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
     582         [ +  - ]:         255 :         buckets.insert(bucket);
     583                 :         255 :     }
     584                 :             :     // Test: IP addresses in the same group (\16 prefix for IPv4) should
     585                 :             :     //  always map to the same bucket.
     586   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 1U);
     587                 :             : 
     588                 :           1 :     buckets.clear();
     589         [ +  + ]:        1021 :     for (int j = 0; j < 4 * 255; j++) {
     590                 :        1020 :         AddrInfo infoj = AddrInfo(CAddress(
     591                 :        1020 :                                         ResolveService(
     592   [ +  -  +  -  :        4080 :                                             ToString(250 + (j / 255)) + "." + ToString(j % 256) + ".1.1"), NODE_NONE),
             +  -  +  - ]
     593   [ +  -  +  - ]:        3060 :             ResolveIP("251.4.1.1"));
     594         [ +  - ]:        1020 :         int bucket = infoj.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
     595         [ +  - ]:        1020 :         buckets.insert(bucket);
     596                 :        1020 :     }
     597                 :             :     // Test: IP addresses in the same source groups should map to NO MORE
     598                 :             :     //  than 64 buckets.
     599   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() <= 64);
     600                 :             : 
     601                 :           1 :     buckets.clear();
     602         [ +  + ]:         256 :     for (int p = 0; p < 255; p++) {
     603                 :         255 :         AddrInfo infoj = AddrInfo(
     604   [ +  -  +  - ]:         510 :             CAddress(ResolveService("250.1.1.1"), NODE_NONE),
     605   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(p) + ".1.1"));
                   +  - ]
     606         [ +  - ]:         255 :         int bucket = infoj.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
     607         [ +  - ]:         255 :         buckets.insert(bucket);
     608                 :         255 :     }
     609                 :             :     // Test: IP addresses in the different source groups should map to MORE
     610                 :             :     //  than 64 buckets.
     611   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() > 64);
     612                 :           3 : }
     613                 :             : 
     614                 :             : // The following three test cases use asmap.raw
     615                 :             : // We use an artificial minimal mock mapping
     616                 :             : // 250.0.0.0/8 AS1000
     617                 :             : // 101.1.0.0/16 AS1
     618                 :             : // 101.2.0.0/16 AS2
     619                 :             : // 101.3.0.0/16 AS3
     620                 :             : // 101.4.0.0/16 AS4
     621                 :             : // 101.5.0.0/16 AS5
     622                 :             : // 101.6.0.0/16 AS6
     623                 :             : // 101.7.0.0/16 AS7
     624                 :             : // 101.8.0.0/16 AS8
     625   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     626                 :             : {
     627                 :           1 :     auto ngm_asmap{NetGroupManager::WithEmbeddedAsmap(test::data::asmap)};
     628                 :             : 
     629   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE);
     630   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.1.1", 9999), NODE_NONE);
     631                 :             : 
     632   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.1.1");
     633                 :             : 
     634                 :             : 
     635                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     636                 :             : 
     637   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     638   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     639                 :             : 
     640   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetTriedBucket(nKey1, ngm_asmap), 236);
                   +  - ]
     641                 :             : 
     642                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     643                 :             :     //  this test could be a security issue.
     644   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, ngm_asmap) != info1.GetTriedBucket(nKey2, ngm_asmap));
             +  -  +  - ]
     645                 :             : 
     646                 :             :     // Test: Two addresses with same IP but different ports can map to
     647                 :             :     //  different buckets because they have different keys.
     648                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     649                 :             : 
     650   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     651   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetTriedBucket(nKey1, ngm_asmap) != info2.GetTriedBucket(nKey1, ngm_asmap));
             +  -  +  - ]
     652                 :             : 
     653                 :           1 :     std::set<int> buckets;
     654         [ +  + ]:         256 :     for (int j = 0; j < 255; j++) {
     655                 :         255 :         AddrInfo infoj = AddrInfo(
     656   [ +  -  +  -  :         765 :             CAddress(ResolveService("101." + ToString(j) + ".1.1"), NODE_NONE),
                   +  - ]
     657   [ +  -  +  -  :        1020 :             ResolveIP("101." + ToString(j) + ".1.1"));
                   +  - ]
     658         [ +  - ]:         255 :         int bucket = infoj.GetTriedBucket(nKey1, ngm_asmap);
     659         [ +  - ]:         255 :         buckets.insert(bucket);
     660                 :         255 :     }
     661                 :             :     // Test: IP addresses in the different /16 prefix MAY map to more than
     662                 :             :     // 8 buckets.
     663   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() > 8);
     664                 :             : 
     665                 :           1 :     buckets.clear();
     666         [ +  + ]:         256 :     for (int j = 0; j < 255; j++) {
     667                 :         255 :         AddrInfo infoj = AddrInfo(
     668   [ +  -  +  -  :         765 :             CAddress(ResolveService("250." + ToString(j) + ".1.1"), NODE_NONE),
                   +  - ]
     669   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(j) + ".1.1"));
                   +  - ]
     670         [ +  - ]:         255 :         int bucket = infoj.GetTriedBucket(nKey1, ngm_asmap);
     671         [ +  - ]:         255 :         buckets.insert(bucket);
     672                 :         255 :     }
     673                 :             :     // Test: IP addresses in the different /16 prefix MAY NOT map to more than
     674                 :             :     // 8 buckets.
     675   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() == 8);
     676                 :           3 : }
     677                 :             : 
     678   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     679                 :             : {
     680                 :           1 :     auto ngm_asmap{NetGroupManager::WithEmbeddedAsmap(test::data::asmap)};
     681                 :             : 
     682   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
     683   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
     684                 :             : 
     685   [ +  -  +  - ]:           1 :     CNetAddr source1 = ResolveIP("250.1.2.1");
     686                 :             : 
     687                 :           1 :     AddrInfo info1 = AddrInfo(addr1, source1);
     688                 :             : 
     689   [ +  -  +  -  :           1 :     uint256 nKey1 = (HashWriter{} << 1).GetHash();
                   +  - ]
     690   [ +  -  +  -  :           1 :     uint256 nKey2 = (HashWriter{} << 2).GetHash();
                   +  - ]
     691                 :             : 
     692                 :             :     // Test: Make sure the buckets are what we expect
     693   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, ngm_asmap), 795);
                   +  - ]
     694   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, source1, ngm_asmap), 795);
                   +  - ]
     695                 :             : 
     696                 :             :     // Test: Make sure key actually randomizes bucket placement. A fail on
     697                 :             :     //  this test could be a security issue.
     698   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetNewBucket(nKey1, ngm_asmap) != info1.GetNewBucket(nKey2, ngm_asmap));
             +  -  +  - ]
     699                 :             : 
     700                 :             :     // Test: Ports should not affect bucket placement in the addr
     701                 :           1 :     AddrInfo info2 = AddrInfo(addr2, source1);
     702   [ +  -  +  -  :           2 :     BOOST_CHECK(info1.GetKey() != info2.GetKey());
          +  -  +  -  +  
                      - ]
     703   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, ngm_asmap), info2.GetNewBucket(nKey1, ngm_asmap));
             +  -  +  - ]
     704                 :             : 
     705                 :           1 :     std::set<int> buckets;
     706         [ +  + ]:         256 :     for (int i = 0; i < 255; i++) {
     707                 :         255 :         AddrInfo infoi = AddrInfo(
     708   [ +  -  +  -  :         510 :             CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
                   +  - ]
     709   [ +  -  +  -  :         765 :             ResolveIP("250.1.1." + ToString(i)));
                   +  - ]
     710         [ +  - ]:         255 :         int bucket = infoi.GetNewBucket(nKey1, ngm_asmap);
     711         [ +  - ]:         255 :         buckets.insert(bucket);
     712                 :         255 :     }
     713                 :             :     // Test: IP addresses in the same /16 prefix
     714                 :             :     // usually map to the same bucket.
     715   [ +  -  +  - ]:           1 :     BOOST_CHECK_EQUAL(buckets.size(), 1U);
     716                 :             : 
     717                 :           1 :     buckets.clear();
     718         [ +  + ]:        1021 :     for (int j = 0; j < 4 * 255; j++) {
     719                 :        1020 :         AddrInfo infoj = AddrInfo(CAddress(
     720                 :        1020 :                                         ResolveService(
     721   [ +  -  +  -  :        4080 :                                             ToString(250 + (j / 255)) + "." + ToString(j % 256) + ".1.1"), NODE_NONE),
             +  -  +  - ]
     722   [ +  -  +  - ]:        3060 :             ResolveIP("251.4.1.1"));
     723         [ +  - ]:        1020 :         int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
     724         [ +  - ]:        1020 :         buckets.insert(bucket);
     725                 :        1020 :     }
     726                 :             :     // Test: IP addresses in the same source /16 prefix should not map to more
     727                 :             :     // than 64 buckets.
     728   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() <= 64);
     729                 :             : 
     730                 :           1 :     buckets.clear();
     731         [ +  + ]:         256 :     for (int p = 0; p < 255; p++) {
     732                 :         255 :         AddrInfo infoj = AddrInfo(
     733   [ +  -  +  - ]:         510 :             CAddress(ResolveService("250.1.1.1"), NODE_NONE),
     734   [ +  -  +  -  :        1020 :             ResolveIP("101." + ToString(p) + ".1.1"));
                   +  - ]
     735         [ +  - ]:         255 :         int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
     736         [ +  - ]:         255 :         buckets.insert(bucket);
     737                 :         255 :     }
     738                 :             :     // Test: IP addresses in the different source /16 prefixes usually map to MORE
     739                 :             :     // than 1 bucket.
     740   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() > 1);
     741                 :             : 
     742                 :           1 :     buckets.clear();
     743         [ +  + ]:         256 :     for (int p = 0; p < 255; p++) {
     744                 :         255 :         AddrInfo infoj = AddrInfo(
     745   [ +  -  +  - ]:         510 :             CAddress(ResolveService("250.1.1.1"), NODE_NONE),
     746   [ +  -  +  -  :        1020 :             ResolveIP("250." + ToString(p) + ".1.1"));
                   +  - ]
     747         [ +  - ]:         255 :         int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
     748         [ +  - ]:         255 :         buckets.insert(bucket);
     749                 :         255 :     }
     750                 :             :     // Test: IP addresses in the different source /16 prefixes sometimes map to NO MORE
     751                 :             :     // than 1 bucket.
     752   [ +  -  +  - ]:           2 :     BOOST_CHECK(buckets.size() == 1);
     753                 :           3 : }
     754                 :             : 
     755   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_serialization)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     756                 :             : {
     757                 :           1 :     auto netgroupman{NetGroupManager::WithEmbeddedAsmap(test::data::asmap)};
     758                 :             : 
     759         [ +  - ]:           1 :     const auto ratio = GetCheckRatio(m_node);
     760         [ +  - ]:           1 :     auto addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     761         [ +  - ]:           1 :     auto addrman_asmap1_dup = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     762         [ +  - ]:           1 :     auto addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
     763                 :             : 
     764                 :           1 :     DataStream stream{};
     765                 :             : 
     766   [ +  -  +  - ]:           2 :     CAddress addr = CAddress(ResolveService("250.1.1.1"), NODE_NONE);
     767         [ +  - ]:           1 :     CNetAddr default_source;
     768                 :             : 
     769   [ +  -  +  -  :           2 :     addrman_asmap1->Add({addr}, default_source);
             +  +  -  - ]
     770                 :             : 
     771         [ +  - ]:           1 :     stream << *addrman_asmap1;
     772                 :             :     // serizalizing/deserializing addrman with the same asmap
     773         [ +  - ]:           1 :     stream >> *addrman_asmap1_dup;
     774                 :             : 
     775         [ +  - ]:           1 :     AddressPosition addr_pos1 = addrman_asmap1->FindAddressEntry(addr).value();
     776         [ +  - ]:           1 :     AddressPosition addr_pos2 = addrman_asmap1_dup->FindAddressEntry(addr).value();
     777   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1.multiplicity != 0);
                   +  - ]
     778   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos2.multiplicity != 0);
                   +  - ]
     779                 :             : 
     780   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1 == addr_pos2);
                   +  - ]
     781                 :             : 
     782                 :             :     // deserializing asmaped peers.dat to non-asmaped addrman
     783         [ +  - ]:           1 :     stream << *addrman_asmap1;
     784         [ +  - ]:           1 :     stream >> *addrman_noasmap;
     785         [ +  - ]:           1 :     AddressPosition addr_pos3 = addrman_noasmap->FindAddressEntry(addr).value();
     786   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos3.multiplicity != 0);
                   +  - ]
     787   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1.bucket != addr_pos3.bucket);
                   +  - ]
     788   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos1.position != addr_pos3.position);
                   +  - ]
     789                 :             : 
     790                 :             :     // deserializing non-asmaped peers.dat to asmaped addrman
     791         [ +  - ]:           2 :     addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     792         [ +  - ]:           2 :     addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
     793   [ +  -  +  -  :           2 :     addrman_noasmap->Add({addr}, default_source);
             +  +  -  - ]
     794         [ +  - ]:           1 :     stream << *addrman_noasmap;
     795         [ +  - ]:           1 :     stream >> *addrman_asmap1;
     796                 :             : 
     797         [ +  - ]:           1 :     AddressPosition addr_pos4 = addrman_asmap1->FindAddressEntry(addr).value();
     798   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos4.multiplicity != 0);
                   +  - ]
     799   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos4.bucket != addr_pos3.bucket);
                   +  - ]
     800   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos4 == addr_pos2);
                   +  - ]
     801                 :             : 
     802                 :             :     // used to map to different buckets, now maps to the same bucket.
     803         [ +  - ]:           2 :     addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
     804         [ +  - ]:           2 :     addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
     805   [ +  -  +  - ]:           2 :     CAddress addr1 = CAddress(ResolveService("250.1.1.1"), NODE_NONE);
     806   [ +  -  +  - ]:           2 :     CAddress addr2 = CAddress(ResolveService("250.2.1.1"), NODE_NONE);
     807   [ +  -  +  -  :           4 :     addrman_noasmap->Add({addr, addr2}, default_source);
             +  +  -  - ]
     808         [ +  - ]:           1 :     AddressPosition addr_pos5 = addrman_noasmap->FindAddressEntry(addr1).value();
     809         [ +  - ]:           1 :     AddressPosition addr_pos6 = addrman_noasmap->FindAddressEntry(addr2).value();
     810   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos5.bucket != addr_pos6.bucket);
                   +  - ]
     811         [ +  - ]:           1 :     stream << *addrman_noasmap;
     812         [ +  - ]:           1 :     stream >> *addrman_asmap1;
     813         [ +  - ]:           1 :     AddressPosition addr_pos7 = addrman_asmap1->FindAddressEntry(addr1).value();
     814         [ +  - ]:           1 :     AddressPosition addr_pos8 = addrman_asmap1->FindAddressEntry(addr2).value();
     815   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos7.bucket == addr_pos8.bucket);
                   +  - ]
     816   [ +  -  +  - ]:           2 :     BOOST_CHECK(addr_pos7.position != addr_pos8.position);
     817                 :           4 : }
     818                 :             : 
     819   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(remove_invalid)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     820                 :             : {
     821                 :             :     // Confirm that invalid addresses are ignored in unserialization.
     822                 :             : 
     823                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     824                 :           1 :     DataStream stream{};
     825                 :             : 
     826   [ +  -  +  - ]:           2 :     const CAddress new1{ResolveService("5.5.5.5"), NODE_NONE};
     827   [ +  -  +  - ]:           2 :     const CAddress new2{ResolveService("6.6.6.6"), NODE_NONE};
     828   [ +  -  +  - ]:           2 :     const CAddress tried1{ResolveService("7.7.7.7"), NODE_NONE};
     829   [ +  -  +  - ]:           2 :     const CAddress tried2{ResolveService("8.8.8.8"), NODE_NONE};
     830                 :             : 
     831   [ +  -  +  -  :           6 :     addrman->Add({new1, tried1, new2, tried2}, CNetAddr{});
          +  -  +  +  -  
                      - ]
     832         [ +  - ]:           1 :     addrman->Good(tried1);
     833         [ +  - ]:           1 :     addrman->Good(tried2);
     834   [ +  -  +  -  :           1 :     BOOST_REQUIRE_EQUAL(addrman->Size(), 4);
                   +  - ]
     835                 :             : 
     836         [ +  - ]:           1 :     stream << *addrman;
     837                 :             : 
     838         [ +  - ]:           1 :     const std::string str{stream.str()};
     839                 :           1 :     size_t pos;
     840                 :             : 
     841                 :           1 :     const char new2_raw[]{6, 6, 6, 6};
     842                 :           1 :     const uint8_t new2_raw_replacement[]{0, 0, 0, 0}; // 0.0.0.0 is !IsValid()
     843                 :           1 :     pos = str.find(new2_raw, 0, sizeof(new2_raw));
     844   [ +  -  +  -  :           2 :     BOOST_REQUIRE(pos != std::string::npos);
                   +  - ]
     845   [ +  -  -  +  :           2 :     BOOST_REQUIRE(pos + sizeof(new2_raw_replacement) <= stream.size());
                   +  - ]
     846                 :           1 :     memcpy(stream.data() + pos, new2_raw_replacement, sizeof(new2_raw_replacement));
     847                 :             : 
     848                 :           1 :     const char tried2_raw[]{8, 8, 8, 8};
     849                 :           1 :     const uint8_t tried2_raw_replacement[]{255, 255, 255, 255}; // 255.255.255.255 is !IsValid()
     850                 :           1 :     pos = str.find(tried2_raw, 0, sizeof(tried2_raw));
     851   [ +  -  +  -  :           2 :     BOOST_REQUIRE(pos != std::string::npos);
                   +  - ]
     852   [ +  -  -  +  :           2 :     BOOST_REQUIRE(pos + sizeof(tried2_raw_replacement) <= stream.size());
             +  -  +  - ]
     853         [ +  - ]:           1 :     memcpy(stream.data() + pos, tried2_raw_replacement, sizeof(tried2_raw_replacement));
     854                 :             : 
     855   [ +  -  +  - ]:           2 :     addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     856         [ +  - ]:           1 :     stream >> *addrman;
     857   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 2);
                   +  - ]
     858                 :           2 : }
     859                 :             : 
     860   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_selecttriedcollision)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     861                 :             : {
     862                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     863                 :             : 
     864   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() == 0);
             +  -  +  - ]
     865                 :             : 
     866                 :             :     // Empty addrman should return blank addrman info.
     867   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
          +  -  +  -  +  
                      - ]
     868                 :             : 
     869                 :             :     // Add twenty two addresses.
     870   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     871         [ +  + ]:          23 :     for (unsigned int i = 1; i < 23; i++) {
     872   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     873   [ +  -  +  -  :         110 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     874                 :             : 
     875                 :             :         // No collisions in tried.
     876   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->Good(addr));
             +  -  +  - ]
     877   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     878                 :          22 :     }
     879                 :             : 
     880                 :             :     // Ensure Good handles duplicates well.
     881                 :             :     // If an address is a duplicate, Good will return false but will not count it as a collision.
     882         [ +  + ]:          23 :     for (unsigned int i = 1; i < 23; i++) {
     883   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     884                 :             : 
     885                 :             :         // Unable to add duplicate address to tried table.
     886   [ +  -  +  -  :          44 :         BOOST_CHECK(!addrman->Good(addr));
             +  -  +  - ]
     887                 :             : 
     888                 :             :         // Verify duplicate address not marked as a collision.
     889   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     890                 :          22 :     }
     891         [ +  - ]:          45 : }
     892                 :             : 
     893   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_noevict)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     894                 :             : {
     895                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     896                 :             : 
     897                 :             :     // Add 35 addresses.
     898   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     899         [ +  + ]:          36 :     for (unsigned int i = 1; i < 36; i++) {
     900   [ +  -  +  -  :          70 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     901   [ +  -  +  -  :         175 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     902                 :             : 
     903                 :             :         // No collision yet.
     904   [ +  -  +  -  :          70 :         BOOST_CHECK(addrman->Good(addr));
                   +  - ]
     905                 :          35 :     }
     906                 :             : 
     907                 :             :     // Collision in tried table between 36 and 19.
     908   [ +  -  +  - ]:           1 :     CService addr36 = ResolveService("250.1.1.36");
     909   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr36, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     910   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr36));
             +  -  +  - ]
     911   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.19:0");
             +  -  +  - ]
     912                 :             : 
     913                 :             :     // 36 should be discarded and 19 not evicted.
     914                 :             :     // This means we keep 19 in the tried table and
     915                 :             :     // 36 stays in the new table.
     916         [ +  - ]:           1 :     addrman->ResolveCollisions();
     917   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     918                 :             : 
     919                 :             :     // Lets create two collisions.
     920         [ +  + ]:          23 :     for (unsigned int i = 37; i < 59; i++) {
     921   [ +  -  +  -  :          44 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     922   [ +  -  +  -  :         110 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     923   [ +  -  +  -  :          44 :         BOOST_CHECK(addrman->Good(addr));
                   +  - ]
     924                 :          22 :     }
     925                 :             : 
     926                 :             :     // Cause a collision in the tried table.
     927   [ +  -  +  - ]:           1 :     CService addr59 = ResolveService("250.1.1.59");
     928   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr59, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     929   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr59));
             +  -  +  - ]
     930                 :             : 
     931   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.10:0");
             +  -  +  - ]
     932                 :             : 
     933                 :             :     // Cause a second collision in the new table.
     934   [ +  -  +  -  :           5 :     BOOST_CHECK(!addrman->Add({CAddress(addr36, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     935                 :             : 
     936                 :             :     // 36 still cannot be moved from new to tried due to colliding with 19
     937   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr36));
             +  -  +  - ]
     938   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() != "[::]:0");
          +  -  +  -  +  
                      - ]
     939                 :             : 
     940                 :             :     // Resolve all collisions.
     941         [ +  - ]:           1 :     addrman->ResolveCollisions();
     942   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     943   [ +  -  +  -  :         121 : }
          +  -  +  -  +  
                      - ]
     944                 :             : 
     945   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_evictionworks)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
     946                 :             : {
     947                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
     948                 :             : 
     949   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Size() == 0);
             +  -  +  - ]
     950                 :             : 
     951                 :             :     // Empty addrman should return blank addrman info.
     952   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
          +  -  +  -  +  
                      - ]
     953                 :             : 
     954                 :             :     // Add 35 addresses
     955   [ +  -  +  - ]:           1 :     CNetAddr source = ResolveIP("252.2.2.2");
     956         [ +  + ]:          36 :     for (unsigned int i = 1; i < 36; i++) {
     957   [ +  -  +  -  :          70 :         CService addr = ResolveService("250.1.1." + ToString(i));
                   +  - ]
     958   [ +  -  +  -  :         175 :         BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     959                 :             : 
     960                 :             :         // No collision yet.
     961   [ +  -  +  -  :          70 :         BOOST_CHECK(addrman->Good(addr));
                   +  - ]
     962                 :          35 :     }
     963                 :             : 
     964                 :             :     // Collision between 36 and 19.
     965   [ +  -  +  - ]:           1 :     CService addr = ResolveService("250.1.1.36");
     966   [ +  -  +  -  :           5 :     BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
          +  -  +  +  +  
                -  -  - ]
     967   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr));
             +  -  +  - ]
     968                 :             : 
     969         [ +  - ]:           1 :     auto info = addrman->SelectTriedCollision().first;
     970   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(info.ToStringAddrPort(), "250.1.1.19:0");
                   +  - ]
     971                 :             : 
     972                 :             :     // Ensure test of address fails, so that it is evicted.
     973                 :             :     // Update entry in tried by setting last good connection in the deep past.
     974   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(info, NodeSeconds{1s}));
                   +  - ]
     975         [ +  - ]:           1 :     addrman->Attempt(info, /*fCountFailure=*/false, Now<NodeSeconds>() - 61s);
     976                 :             : 
     977                 :             :     // Should swap 36 for 19.
     978         [ +  - ]:           1 :     addrman->ResolveCollisions();
     979   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
     980         [ +  - ]:           2 :     AddressPosition addr_pos{addrman->FindAddressEntry(CAddress(addr, NODE_NONE)).value()};
     981   [ +  -  +  -  :           2 :     BOOST_CHECK(addr_pos.tried);
                   +  - ]
     982                 :             : 
     983                 :             :     // If 36 was swapped for 19, then adding 36 to tried should fail because we
     984                 :             :     // are attempting to add a duplicate.
     985                 :             :     // We check this by verifying Good() returns false and also verifying that
     986                 :             :     // we have no collisions.
     987   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr));
             +  -  +  - ]
     988   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
          +  -  +  -  +  
                      - ]
     989                 :             : 
     990                 :             :     // 19 should fail as a collision (not a duplicate) if we now attempt to move
     991                 :             :     // it to the tried table.
     992   [ +  -  +  - ]:           1 :     CService addr19 = ResolveService("250.1.1.19");
     993   [ +  -  +  -  :           2 :     BOOST_CHECK(!addrman->Good(addr19));
             +  -  +  - ]
     994   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.36:0");
             +  -  +  - ]
     995                 :             : 
     996                 :             :     // Eviction is also successful if too much time has passed since last try
     997   [ +  -  +  - ]:           1 :     SetMockTime(GetTime() + 4 * 60 *60);
     998         [ +  - ]:           1 :     addrman->ResolveCollisions();
     999   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
             +  -  +  - ]
    1000                 :             :     //Now 19 is in tried again, and 36 back to new
    1001         [ +  - ]:           2 :     AddressPosition addr_pos19{addrman->FindAddressEntry(CAddress(addr19, NODE_NONE)).value()};
    1002   [ +  -  +  - ]:           2 :     BOOST_CHECK(addr_pos19.tried);
    1003         [ +  - ]:           2 :     AddressPosition addr_pos36{addrman->FindAddressEntry(CAddress(addr, NODE_NONE)).value()};
    1004   [ +  -  +  - ]:           2 :     BOOST_CHECK(!addr_pos36.tried);
    1005   [ +  -  +  - ]:          73 : }
    1006                 :             : 
    1007                 :           2 : static auto AddrmanToStream(const AddrMan& addrman)
    1008                 :             : {
    1009                 :           2 :     DataStream ssPeersIn{};
    1010   [ +  -  +  - ]:           2 :     ssPeersIn << Params().MessageStart();
    1011         [ +  - ]:           2 :     ssPeersIn << addrman;
    1012                 :           2 :     return ssPeersIn;
    1013                 :           0 : }
    1014                 :             : 
    1015   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(load_addrman)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1016                 :             : {
    1017                 :           1 :     AddrMan addrman{EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node)};
    1018                 :             : 
    1019                 :           1 :     std::optional<CService> addr1, addr2, addr3, addr4;
    1020   [ +  -  +  -  :           2 :     addr1 = Lookup("250.7.1.1", 8333, false);
                   +  - ]
    1021   [ +  -  +  -  :           2 :     BOOST_CHECK(addr1.has_value());
                   +  - ]
    1022   [ +  -  +  -  :           2 :     addr2 = Lookup("250.7.2.2", 9999, false);
                   +  - ]
    1023   [ +  -  +  -  :           2 :     BOOST_CHECK(addr2.has_value());
                   +  - ]
    1024   [ +  -  +  -  :           2 :     addr3 = Lookup("250.7.3.3", 9999, false);
                   +  - ]
    1025   [ +  -  +  -  :           2 :     BOOST_CHECK(addr3.has_value());
                   +  - ]
    1026   [ +  -  +  - ]:           3 :     addr3 = Lookup("250.7.3.3"s, 9999, false);
    1027   [ +  -  +  -  :           2 :     BOOST_CHECK(addr3.has_value());
                   +  - ]
    1028   [ +  -  +  - ]:           3 :     addr4 = Lookup("250.7.3.3\0example.com"s, 9999, false);
    1029   [ +  -  +  -  :           2 :     BOOST_CHECK(!addr4.has_value());
                   +  - ]
    1030                 :             : 
    1031                 :             :     // Add three addresses to new table.
    1032   [ +  -  +  -  :           2 :     const std::optional<CService> source{Lookup("252.5.1.1", 8333, false)};
                   +  - ]
    1033   [ +  -  +  -  :           2 :     BOOST_CHECK(source.has_value());
                   +  - ]
    1034   [ +  +  -  - ]:           8 :     std::vector<CAddress> addresses{CAddress(addr1.value(), NODE_NONE), CAddress(addr2.value(), NODE_NONE), CAddress(addr3.value(), NODE_NONE)};
    1035   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman.Add(addresses, source.value()));
          +  -  +  -  +  
                      - ]
    1036   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman.Size() == 3);
             +  -  +  - ]
    1037                 :             : 
    1038                 :             :     // Test that the de-serialization does not throw an exception.
    1039         [ +  - ]:           1 :     auto ssPeers1{AddrmanToStream(addrman)};
    1040                 :           1 :     bool exceptionThrown = false;
    1041   [ +  -  +  - ]:           1 :     AddrMan addrman1{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1042                 :             : 
    1043   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman1.Size() == 0);
             +  -  +  - ]
    1044                 :           1 :     try {
    1045                 :           1 :         unsigned char pchMsgTmp[4];
    1046         [ +  - ]:           1 :         ssPeers1 >> pchMsgTmp;
    1047         [ +  - ]:           1 :         ssPeers1 >> addrman1;
    1048         [ -  - ]:           0 :     } catch (const std::exception&) {
    1049                 :           0 :         exceptionThrown = true;
    1050                 :           0 :     }
    1051                 :             : 
    1052   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman1.Size() == 3);
             +  -  +  - ]
    1053   [ +  -  +  -  :           2 :     BOOST_CHECK(exceptionThrown == false);
                   +  - ]
    1054                 :             : 
    1055                 :             :     // Test that ReadFromStream creates an addrman with the correct number of addrs.
    1056         [ +  - ]:           1 :     DataStream ssPeers2 = AddrmanToStream(addrman);
    1057                 :             : 
    1058   [ +  -  +  - ]:           1 :     AddrMan addrman2{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1059   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman2.Size() == 0);
             +  -  +  - ]
    1060         [ +  - ]:           1 :     ReadFromStream(addrman2, ssPeers2);
    1061   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman2.Size() == 3);
                   +  - ]
    1062   [ +  -  +  -  :           5 : }
          +  -  -  +  -  
                      - ]
    1063                 :             : 
    1064                 :             : // Produce a corrupt peers.dat that claims 20 addrs when it only has one addr.
    1065                 :           2 : static auto MakeCorruptPeersDat()
    1066                 :             : {
    1067                 :           2 :     DataStream s{};
    1068   [ +  -  +  - ]:           2 :     s << ::Params().MessageStart();
    1069                 :             : 
    1070                 :           2 :     unsigned char nVersion = 1;
    1071         [ +  - ]:           2 :     s << nVersion;
    1072         [ +  - ]:           2 :     s << ((unsigned char)32);
    1073         [ +  - ]:           2 :     s << uint256::ONE;
    1074         [ +  - ]:           2 :     s << 10; // nNew
    1075         [ +  - ]:           2 :     s << 10; // nTried
    1076                 :             : 
    1077                 :           2 :     int nUBuckets = ADDRMAN_NEW_BUCKET_COUNT ^ (1 << 30);
    1078         [ +  - ]:           2 :     s << nUBuckets;
    1079                 :             : 
    1080   [ +  -  +  -  :           4 :     const std::optional<CService> serv{Lookup("252.1.1.1", 7777, false)};
                   +  - ]
    1081   [ +  -  +  -  :           4 :     BOOST_REQUIRE(serv.has_value());
                   +  - ]
    1082         [ +  - ]:           2 :     CAddress addr = CAddress(serv.value(), NODE_NONE);
    1083   [ +  -  +  -  :           4 :     std::optional<CNetAddr> resolved{LookupHost("252.2.2.2", false)};
                   +  - ]
    1084   [ +  -  +  -  :           4 :     BOOST_REQUIRE(resolved.has_value());
                   +  - ]
    1085         [ +  - ]:           2 :     AddrInfo info = AddrInfo(addr, resolved.value());
    1086         [ +  - ]:           2 :     s << CAddress::V1_DISK(info);
    1087                 :             : 
    1088                 :           2 :     return s;
    1089                 :           2 : }
    1090                 :             : 
    1091   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(load_addrman_corrupted)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1092                 :             : {
    1093                 :             :     // Test that the de-serialization of corrupted peers.dat throws an exception.
    1094                 :           1 :     auto ssPeers1{MakeCorruptPeersDat()};
    1095                 :           1 :     bool exceptionThrown = false;
    1096   [ +  -  +  - ]:           1 :     AddrMan addrman1{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1097   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman1.Size() == 0);
             +  -  +  - ]
    1098                 :           1 :     try {
    1099                 :           1 :         unsigned char pchMsgTmp[4];
    1100         [ +  - ]:           1 :         ssPeers1 >> pchMsgTmp;
    1101         [ -  + ]:           1 :         ssPeers1 >> addrman1;
    1102         [ -  + ]:           1 :     } catch (const std::exception&) {
    1103                 :           1 :         exceptionThrown = true;
    1104                 :           1 :     }
    1105   [ +  -  +  -  :           2 :     BOOST_CHECK(exceptionThrown);
                   +  - ]
    1106                 :             : 
    1107                 :             :     // Test that ReadFromStream fails if peers.dat is corrupt
    1108         [ +  - ]:           1 :     auto ssPeers2{MakeCorruptPeersDat()};
    1109                 :             : 
    1110   [ +  -  +  - ]:           1 :     AddrMan addrman2{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
    1111   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman2.Size() == 0);
             +  -  +  - ]
    1112   [ +  -  -  +  :           2 :     BOOST_CHECK_THROW(ReadFromStream(addrman2, ssPeers2), std::ios_base::failure);
          -  -  -  -  -  
             +  +  -  +  
                      - ]
    1113                 :           1 : }
    1114                 :             : 
    1115   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_update_address)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1116                 :             : {
    1117                 :             :     // Tests updating nTime via Connected() and nServices via SetServices() and Add()
    1118                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
    1119   [ +  -  +  - ]:           1 :     CNetAddr source{ResolveIP("252.2.2.2")};
    1120   [ +  -  +  - ]:           2 :     CAddress addr{CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE)};
    1121                 :             : 
    1122                 :           1 :     const auto start_time{Now<NodeSeconds>() - 10000s};
    1123                 :           1 :     addr.nTime = start_time;
    1124   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr}, source));
          +  -  +  -  +  
                +  -  - ]
    1125   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(), 1U);
                   +  - ]
    1126                 :             : 
    1127                 :             :     // Updating an addrman entry with a different port doesn't change it
    1128   [ +  -  +  - ]:           2 :     CAddress addr_diff_port{CAddress(ResolveService("250.1.1.1", 8334), NODE_NONE)};
    1129                 :           1 :     addr_diff_port.nTime = start_time;
    1130         [ +  - ]:           1 :     addrman->Connected(addr_diff_port);
    1131         [ +  - ]:           1 :     addrman->SetServices(addr_diff_port, NODE_NETWORK_LIMITED);
    1132         [ +  - ]:           1 :     std::vector<CAddress> vAddr1{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1133   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr1.size(), 1U);
                   +  - ]
    1134   [ +  -  +  -  :           2 :     BOOST_CHECK(vAddr1.at(0).nTime == start_time);
             +  -  +  - ]
    1135   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr1.at(0).nServices, NODE_NONE);
                   +  - ]
    1136                 :             : 
    1137                 :             :     // Updating an addrman entry with the correct port is successful
    1138         [ +  - ]:           1 :     addrman->Connected(addr);
    1139         [ +  - ]:           1 :     addrman->SetServices(addr, NODE_NETWORK_LIMITED);
    1140         [ +  - ]:           1 :     std::vector<CAddress> vAddr2 = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
    1141   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr2.size(), 1U);
                   +  - ]
    1142   [ +  -  +  -  :           2 :     BOOST_CHECK(vAddr2.at(0).nTime >= start_time + 10000s);
             +  -  +  - ]
    1143   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr2.at(0).nServices, NODE_NETWORK_LIMITED);
                   +  - ]
    1144                 :             : 
    1145                 :             :     // Updating an existing addr through Add() (used in gossip relay) can add additional services but can't remove existing ones.
    1146   [ +  -  +  - ]:           2 :     CAddress addr_v2{CAddress(ResolveService("250.1.1.1", 8333), NODE_P2P_V2)};
    1147                 :           1 :     addr_v2.nTime = start_time;
    1148   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Add({addr_v2}, source));
          +  -  +  -  +  
                +  -  - ]
    1149         [ +  - ]:           1 :     std::vector<CAddress> vAddr3{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1150   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr3.size(), 1U);
                   +  - ]
    1151   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr3.at(0).nServices, NODE_P2P_V2 | NODE_NETWORK_LIMITED);
                   +  - ]
    1152                 :             : 
    1153                 :             :     // SetServices() (used when we connected to them) overwrites existing service flags
    1154         [ +  - ]:           1 :     addrman->SetServices(addr, NODE_NETWORK);
    1155         [ +  - ]:           1 :     std::vector<CAddress> vAddr4{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1156   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr4.size(), 1U);
                   +  - ]
    1157   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr4.at(0).nServices, NODE_NETWORK);
                   +  - ]
    1158                 :             : 
    1159                 :             :     // Promoting to Tried does not affect the service flags
    1160   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(addr)); // addr has NODE_NONE
             +  -  +  - ]
    1161         [ +  - ]:           1 :     std::vector<CAddress> vAddr5{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1162   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr5.size(), 1U);
                   +  - ]
    1163   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr5.at(0).nServices, NODE_NETWORK);
                   +  - ]
    1164                 :             : 
    1165                 :             :     // Adding service flags even works when the addr is in Tried
    1166   [ +  -  +  -  :           3 :     BOOST_CHECK(!addrman->Add({addr_v2}, source));
          +  -  +  -  +  
                +  -  - ]
    1167         [ +  - ]:           1 :     std::vector<CAddress> vAddr6{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
    1168   [ +  -  -  +  :           1 :     BOOST_CHECK_EQUAL(vAddr6.size(), 1U);
                   +  - ]
    1169   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(vAddr6.at(0).nServices, NODE_NETWORK | NODE_P2P_V2);
                   +  - ]
    1170                 :           4 : }
    1171                 :             : 
    1172   [ +  -  +  -  :           7 : BOOST_AUTO_TEST_CASE(addrman_size)
          +  -  +  -  -  
          +  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
          -  +  -  +  -  
          +  -  +  -  +  
          -  +  -  -  +  
          +  -  +  -  +  
          -  +  -  +  -  
          +  -  -  +  +  
                      - ]
    1173                 :             : {
    1174                 :           1 :     auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
    1175   [ +  -  +  - ]:           1 :     const CNetAddr source = ResolveIP("252.2.2.2");
    1176                 :             : 
    1177                 :             :     // empty addrman
    1178   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 0U);
                   +  - ]
    1179   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 0U);
                   +  - ]
    1180   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 0U);
                   +  - ]
    1181   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/false), 0U);
                   +  - ]
    1182                 :             : 
    1183                 :             :     // add two ipv4 addresses, one to tried and new
    1184   [ +  -  +  - ]:           2 :     const CAddress addr1{ResolveService("250.1.1.1", 8333), NODE_NONE};
    1185   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr1}, source));
          +  -  +  -  +  
                +  -  - ]
    1186   [ +  -  +  -  :           2 :     BOOST_CHECK(addrman->Good(addr1));
             +  -  +  - ]
    1187   [ +  -  +  - ]:           2 :     const CAddress addr2{ResolveService("250.1.1.2", 8333), NODE_NONE};
    1188   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr2}, source));
          +  -  +  -  +  
                +  -  - ]
    1189                 :             : 
    1190   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 2U);
                   +  - ]
    1191   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 2U);
                   +  - ]
    1192   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 1U);
                   +  - ]
    1193   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/false), 1U);
                   +  - ]
    1194   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/true), 1U);
                   +  - ]
    1195   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/false), 1U);
                   +  - ]
    1196                 :             : 
    1197                 :             :     // add one i2p address to new
    1198         [ +  - ]:           1 :     CService i2p_addr;
    1199         [ +  - ]:           1 :     i2p_addr.SetSpecial("UDHDrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.I2P");
    1200                 :           1 :     const CAddress addr3{i2p_addr, NODE_NONE};
    1201   [ +  -  +  -  :           3 :     BOOST_CHECK(addrman->Add({addr3}, source));
          +  -  +  -  +  
                +  -  - ]
    1202   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 3U);
                   +  - ]
    1203   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 2U);
                   +  - ]
    1204   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_I2P, /*in_new=*/std::nullopt), 1U);
                   +  - ]
    1205   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_I2P, /*in_new=*/true), 1U);
                   +  - ]
    1206   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 2U);
                   +  - ]
    1207   [ +  -  +  -  :           1 :     BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/false), 1U);
                   +  - ]
    1208                 :           4 : }
    1209                 :             : 
    1210                 :             : BOOST_AUTO_TEST_SUITE_END()
        

Generated by: LCOV version 2.0-1