Branch data Line data Source code
1 : : // Copyright (c) 2024
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <node/txdownloadman_impl.h>
6 : : #include <node/txdownloadman.h>
7 : :
8 : : #include <chain.h>
9 : : #include <consensus/validation.h>
10 : : #include <logging.h>
11 : : #include <txmempool.h>
12 : : #include <validation.h>
13 : : #include <validationinterface.h>
14 : :
15 : : namespace node {
16 : : // TxDownloadManager wrappers
17 : 1114 : TxDownloadManager::TxDownloadManager(const TxDownloadOptions& options) :
18 : 1114 : m_impl{std::make_unique<TxDownloadManagerImpl>(options)}
19 : 1114 : {}
20 : 1114 : TxDownloadManager::~TxDownloadManager() = default;
21 : :
22 : 97167 : void TxDownloadManager::ActiveTipChange()
23 : : {
24 : 97167 : m_impl->ActiveTipChange();
25 : 97167 : }
26 : 119995 : void TxDownloadManager::BlockConnected(const std::shared_ptr<const CBlock>& pblock)
27 : : {
28 : 119995 : m_impl->BlockConnected(pblock);
29 : 119995 : }
30 : 12191 : void TxDownloadManager::BlockDisconnected()
31 : : {
32 : 12191 : m_impl->BlockDisconnected();
33 : 12191 : }
34 : 1475 : void TxDownloadManager::ConnectedPeer(NodeId nodeid, const TxDownloadConnectionInfo& info)
35 : : {
36 : 1475 : m_impl->ConnectedPeer(nodeid, info);
37 : 1475 : }
38 : 1579 : void TxDownloadManager::DisconnectedPeer(NodeId nodeid)
39 : : {
40 : 1579 : m_impl->DisconnectedPeer(nodeid);
41 : 1579 : }
42 : 26091 : bool TxDownloadManager::AddTxAnnouncement(NodeId peer, const GenTxid& gtxid, std::chrono::microseconds now)
43 : : {
44 : 26091 : return m_impl->AddTxAnnouncement(peer, gtxid, now);
45 : : }
46 : 399175 : std::vector<GenTxid> TxDownloadManager::GetRequestsToSend(NodeId nodeid, std::chrono::microseconds current_time)
47 : : {
48 : 399175 : return m_impl->GetRequestsToSend(nodeid, current_time);
49 : : }
50 : 7 : void TxDownloadManager::ReceivedNotFound(NodeId nodeid, const std::vector<uint256>& txhashes)
51 : : {
52 : 7 : m_impl->ReceivedNotFound(nodeid, txhashes);
53 : 7 : }
54 : 11563 : void TxDownloadManager::MempoolAcceptedTx(const CTransactionRef& tx)
55 : : {
56 : 11563 : m_impl->MempoolAcceptedTx(tx);
57 : 11563 : }
58 : 587 : RejectedTxTodo TxDownloadManager::MempoolRejectedTx(const CTransactionRef& ptx, const TxValidationState& state, NodeId nodeid, bool first_time_failure)
59 : : {
60 : 587 : return m_impl->MempoolRejectedTx(ptx, state, nodeid, first_time_failure);
61 : : }
62 : 4 : void TxDownloadManager::MempoolRejectedPackage(const Package& package)
63 : : {
64 : 4 : m_impl->MempoolRejectedPackage(package);
65 : 4 : }
66 : 12010 : std::pair<bool, std::optional<PackageToValidate>> TxDownloadManager::ReceivedTx(NodeId nodeid, const CTransactionRef& ptx)
67 : : {
68 : 12010 : return m_impl->ReceivedTx(nodeid, ptx);
69 : : }
70 : 157184 : bool TxDownloadManager::HaveMoreWork(NodeId nodeid) const
71 : : {
72 : 157184 : return m_impl->HaveMoreWork(nodeid);
73 : : }
74 : 403634 : CTransactionRef TxDownloadManager::GetTxToReconsider(NodeId nodeid)
75 : : {
76 : 403634 : return m_impl->GetTxToReconsider(nodeid);
77 : : }
78 : 888 : void TxDownloadManager::CheckIsEmpty() const
79 : : {
80 : 888 : m_impl->CheckIsEmpty();
81 : 888 : }
82 : 1580 : void TxDownloadManager::CheckIsEmpty(NodeId nodeid) const
83 : : {
84 : 1580 : m_impl->CheckIsEmpty(nodeid);
85 : 1580 : }
86 : 161 : std::vector<TxOrphanage::OrphanTxBase> TxDownloadManager::GetOrphanTransactions() const
87 : : {
88 : 161 : return m_impl->GetOrphanTransactions();
89 : : }
90 : :
91 : : // TxDownloadManagerImpl
92 : 97167 : void TxDownloadManagerImpl::ActiveTipChange()
93 : : {
94 : 97167 : RecentRejectsFilter().reset();
95 : 97167 : RecentRejectsReconsiderableFilter().reset();
96 : 97167 : }
97 : :
98 : 119995 : void TxDownloadManagerImpl::BlockConnected(const std::shared_ptr<const CBlock>& pblock)
99 : : {
100 : 119995 : m_orphanage.EraseForBlock(*pblock);
101 : :
102 [ + + ]: 281996 : for (const auto& ptx : pblock->vtx) {
103 : 162001 : RecentConfirmedTransactionsFilter().insert(ptx->GetHash().ToUint256());
104 [ + + ]: 162001 : if (ptx->HasWitness()) {
105 : 121580 : RecentConfirmedTransactionsFilter().insert(ptx->GetWitnessHash().ToUint256());
106 : : }
107 : 162001 : m_txrequest.ForgetTxHash(ptx->GetHash());
108 : 162001 : m_txrequest.ForgetTxHash(ptx->GetWitnessHash());
109 : : }
110 : 119995 : }
111 : :
112 : 12191 : void TxDownloadManagerImpl::BlockDisconnected()
113 : : {
114 : : // To avoid relay problems with transactions that were previously
115 : : // confirmed, clear our filter of recently confirmed transactions whenever
116 : : // there's a reorg.
117 : : // This means that in a 1-block reorg (where 1 block is disconnected and
118 : : // then another block reconnected), our filter will drop to having only one
119 : : // block's worth of transactions in it, but that should be fine, since
120 : : // presumably the most common case of relaying a confirmed transaction
121 : : // should be just after a new block containing it is found.
122 : 12191 : RecentConfirmedTransactionsFilter().reset();
123 : 12191 : }
124 : :
125 : 60227 : bool TxDownloadManagerImpl::AlreadyHaveTx(const GenTxid& gtxid, bool include_reconsiderable)
126 : : {
127 [ + + ]: 60227 : const uint256& hash = gtxid.GetHash();
128 : :
129 [ + + ]: 60227 : if (gtxid.IsWtxid()) {
130 : : // Normal query by wtxid.
131 [ + - ]: 59596 : if (m_orphanage.HaveTx(Wtxid::FromUint256(hash))) return true;
132 : : } else {
133 : : // Never query by txid: it is possible that the transaction in the orphanage has the same
134 : : // txid but a different witness, which would give us a false positive result. If we decided
135 : : // not to request the transaction based on this result, an attacker could prevent us from
136 : : // downloading a transaction by intentionally creating a malleated version of it. While
137 : : // only one (or none!) of these transactions can ultimately be confirmed, we have no way of
138 : : // discerning which one that is, so the orphanage can store multiple transactions with the
139 : : // same txid.
140 : : //
141 : : // While we won't query by txid, we can try to "guess" what the wtxid is based on the txid.
142 : : // A non-segwit transaction's txid == wtxid. Query this txid "casted" to a wtxid. This will
143 : : // help us find non-segwit transactions, saving bandwidth, and should have no false positives.
144 [ + + ]: 631 : if (m_orphanage.HaveTx(Wtxid::FromUint256(hash))) return true;
145 : : }
146 : :
147 [ + + + + ]: 60216 : if (include_reconsiderable && RecentRejectsReconsiderableFilter().contains(hash)) return true;
148 : :
149 [ + + ]: 60200 : if (RecentConfirmedTransactionsFilter().contains(hash)) return true;
150 : :
151 [ + + + + ]: 60166 : return RecentRejectsFilter().contains(hash) || m_opts.m_mempool.exists(gtxid);
152 : : }
153 : :
154 : 1544 : void TxDownloadManagerImpl::ConnectedPeer(NodeId nodeid, const TxDownloadConnectionInfo& info)
155 : : {
156 : : // If already connected (shouldn't happen in practice), exit early.
157 [ + - ]: 1544 : if (m_peer_info.contains(nodeid)) return;
158 : :
159 : 1544 : m_peer_info.try_emplace(nodeid, info);
160 [ + + ]: 1544 : if (info.m_wtxid_relay) m_num_wtxid_peers += 1;
161 : : }
162 : :
163 : 1579 : void TxDownloadManagerImpl::DisconnectedPeer(NodeId nodeid)
164 : : {
165 : 1579 : m_orphanage.EraseForPeer(nodeid);
166 : 1579 : m_txrequest.DisconnectedPeer(nodeid);
167 : :
168 [ + + ]: 1579 : if (auto it = m_peer_info.find(nodeid); it != m_peer_info.end()) {
169 [ + + ]: 1474 : if (it->second.m_connection_info.m_wtxid_relay) m_num_wtxid_peers -= 1;
170 : 1474 : m_peer_info.erase(it);
171 : : }
172 : :
173 : 1579 : }
174 : :
175 : 26187 : bool TxDownloadManagerImpl::AddTxAnnouncement(NodeId peer, const GenTxid& gtxid, std::chrono::microseconds now)
176 : : {
177 : : // If this is an orphan we are trying to resolve, consider this peer as a orphan resolution candidate instead.
178 : : // - is wtxid matching something in orphanage
179 : : // - exists in orphanage
180 : : // - peer can be an orphan resolution candidate
181 [ + + ]: 26187 : if (gtxid.IsWtxid()) {
182 : 26125 : const auto wtxid{Wtxid::FromUint256(gtxid.GetHash())};
183 [ + + ]: 26125 : if (auto orphan_tx{m_orphanage.GetTx(wtxid)}) {
184 [ + - ]: 7 : auto unique_parents{GetUniqueParents(*orphan_tx)};
185 [ + - ]: 7 : std::erase_if(unique_parents, [&](const auto& txid){
186 : 8 : return AlreadyHaveTx(GenTxid::Txid(txid), /*include_reconsiderable=*/false);
187 : : });
188 : :
189 : : // The missing parents may have all been rejected or accepted since the orphan was added to the orphanage.
190 : : // Do not delete from the orphanage, as it may be queued for processing.
191 [ + - ]: 7 : if (unique_parents.empty()) {
192 : : return true;
193 : : }
194 : :
195 [ + - + + ]: 7 : if (MaybeAddOrphanResolutionCandidate(unique_parents, wtxid, peer, now)) {
196 [ + - ]: 3 : m_orphanage.AddAnnouncer(orphan_tx->GetWitnessHash(), peer);
197 : : }
198 : :
199 : : // Return even if the peer isn't an orphan resolution candidate. This would be caught by AlreadyHaveTx.
200 : 7 : return true;
201 [ + - ]: 26132 : }
202 : : }
203 : :
204 : : // If this is an inv received from a peer and we already have it, we can drop it.
205 [ + + ]: 26180 : if (AlreadyHaveTx(gtxid, /*include_reconsiderable=*/true)) return true;
206 : :
207 : 24095 : auto it = m_peer_info.find(peer);
208 [ + - ]: 24095 : if (it == m_peer_info.end()) return false;
209 [ + + ]: 24095 : const auto& info = it->second.m_connection_info;
210 [ + + + + ]: 24095 : if (!info.m_relay_permissions && m_txrequest.Count(peer) >= MAX_PEER_TX_ANNOUNCEMENTS) {
211 : : // Too many queued announcements for this peer
212 : : return false;
213 : : }
214 : : // Decide the TxRequestTracker parameters for this announcement:
215 : : // - "preferred": if fPreferredDownload is set (= outbound, or NetPermissionFlags::NoBan permission)
216 : : // - "reqtime": current time plus delays for:
217 : : // - NONPREF_PEER_TX_DELAY for announcements from non-preferred connections
218 : : // - TXID_RELAY_DELAY for txid announcements while wtxid peers are available
219 : : // - OVERLOADED_PEER_TX_DELAY for announcements from peers which have at least
220 : : // MAX_PEER_TX_REQUEST_IN_FLIGHT requests in flight (and don't have NetPermissionFlags::Relay).
221 : 24094 : auto delay{0us};
222 [ + + ]: 24094 : if (!info.m_preferred) delay += NONPREF_PEER_TX_DELAY;
223 [ + + + + ]: 24094 : if (!gtxid.IsWtxid() && m_num_wtxid_peers > 0) delay += TXID_RELAY_DELAY;
224 [ + + + + ]: 24094 : const bool overloaded = !info.m_relay_permissions && m_txrequest.CountInFlight(peer) >= MAX_PEER_TX_REQUEST_IN_FLIGHT;
225 : 2 : if (overloaded) delay += OVERLOADED_PEER_TX_DELAY;
226 : :
227 : 24094 : m_txrequest.ReceivedInv(peer, gtxid, info.m_preferred, now + delay);
228 : :
229 : 24094 : return false;
230 : : }
231 : :
232 : 444 : bool TxDownloadManagerImpl::MaybeAddOrphanResolutionCandidate(const std::vector<Txid>& unique_parents, const Wtxid& wtxid, NodeId nodeid, std::chrono::microseconds now)
233 : : {
234 : 444 : auto it_peer = m_peer_info.find(nodeid);
235 [ + - ]: 444 : if (it_peer == m_peer_info.end()) return false;
236 [ + + ]: 444 : if (m_orphanage.HaveTxFromPeer(wtxid, nodeid)) return false;
237 : :
238 : 440 : const auto& peer_entry = m_peer_info.at(nodeid);
239 : 440 : const auto& info = peer_entry.m_connection_info;
240 : :
241 : : // TODO: add delays and limits based on the amount of orphan resolution we are already doing
242 : : // with this peer, how much they are using the orphanage, etc.
243 [ + - ]: 440 : if (!info.m_relay_permissions) {
244 : : // This mirrors the delaying and dropping behavior in AddTxAnnouncement in order to preserve
245 : : // existing behavior: drop if we are tracking too many invs for this peer already. Each
246 : : // orphan resolution involves at least 1 transaction request which may or may not be
247 : : // currently tracked in m_txrequest, so we include that in the count.
248 [ + - ]: 440 : if (m_txrequest.Count(nodeid) + unique_parents.size() > MAX_PEER_TX_ANNOUNCEMENTS) return false;
249 : : }
250 : :
251 : 440 : std::chrono::seconds delay{0s};
252 [ + + ]: 440 : if (!info.m_preferred) delay += NONPREF_PEER_TX_DELAY;
253 : : // The orphan wtxid is used, but resolution entails requesting the parents by txid. Sometimes
254 : : // parent and child are announced and thus requested around the same time, and we happen to
255 : : // receive child sooner. Waiting a few seconds may allow us to cancel the orphan resolution
256 : : // request if the parent arrives in that time.
257 [ + - ]: 440 : if (m_num_wtxid_peers > 0) delay += TXID_RELAY_DELAY;
258 [ + - - + ]: 440 : const bool overloaded = !info.m_relay_permissions && m_txrequest.CountInFlight(nodeid) >= MAX_PEER_TX_REQUEST_IN_FLIGHT;
259 : 0 : if (overloaded) delay += OVERLOADED_PEER_TX_DELAY;
260 : :
261 : : // Treat finding orphan resolution candidate as equivalent to the peer announcing all missing parents.
262 : : // In the future, orphan resolution may include more explicit steps
263 [ + + ]: 896 : for (const auto& parent_txid : unique_parents) {
264 : 456 : m_txrequest.ReceivedInv(nodeid, GenTxid::Txid(parent_txid), info.m_preferred, now + delay);
265 : : }
266 [ + - + - ]: 880 : LogDebug(BCLog::TXPACKAGES, "added peer=%d as a candidate for resolving orphan %s\n", nodeid, wtxid.ToString());
267 : : return true;
268 : : }
269 : :
270 : 399175 : std::vector<GenTxid> TxDownloadManagerImpl::GetRequestsToSend(NodeId nodeid, std::chrono::microseconds current_time)
271 : : {
272 : 399175 : std::vector<GenTxid> requests;
273 : 399175 : std::vector<std::pair<NodeId, GenTxid>> expired;
274 [ + - ]: 399175 : auto requestable = m_txrequest.GetRequestable(nodeid, current_time, &expired);
275 [ + + ]: 399197 : for (const auto& entry : expired) {
276 [ + - + - : 54 : LogDebug(BCLog::NET, "timeout of inflight %s %s from peer=%d\n", entry.second.IsWtxid() ? "wtx" : "tx",
+ - + + +
- ]
277 : : entry.second.GetHash().ToString(), entry.first);
278 : : }
279 [ + + ]: 420708 : for (const GenTxid& gtxid : requestable) {
280 [ + - + + ]: 21533 : if (!AlreadyHaveTx(gtxid, /*include_reconsiderable=*/false)) {
281 [ + - + - : 43129 : LogDebug(BCLog::NET, "Requesting %s %s peer=%d\n", gtxid.IsWtxid() ? "wtx" : "tx",
+ - + + +
- ]
282 : : gtxid.GetHash().ToString(), nodeid);
283 [ + - ]: 21532 : requests.emplace_back(gtxid);
284 [ + - ]: 21532 : m_txrequest.RequestedTx(nodeid, gtxid.GetHash(), current_time + GETDATA_TX_INTERVAL);
285 : : } else {
286 : : // We have already seen this transaction, no need to download. This is just a belt-and-suspenders, as
287 : : // this should already be called whenever a transaction becomes AlreadyHaveTx().
288 [ + - ]: 1 : m_txrequest.ForgetTxHash(gtxid.GetHash());
289 : : }
290 : : }
291 : 399175 : return requests;
292 : 399175 : }
293 : :
294 : 7 : void TxDownloadManagerImpl::ReceivedNotFound(NodeId nodeid, const std::vector<uint256>& txhashes)
295 : : {
296 [ + + ]: 14 : for (const auto& txhash : txhashes) {
297 : : // If we receive a NOTFOUND message for a tx we requested, mark the announcement for it as
298 : : // completed in TxRequestTracker.
299 : 7 : m_txrequest.ReceivedResponse(nodeid, txhash);
300 : : }
301 : 7 : }
302 : :
303 : 53 : std::optional<PackageToValidate> TxDownloadManagerImpl::Find1P1CPackage(const CTransactionRef& ptx, NodeId nodeid)
304 : : {
305 : 53 : const auto& parent_wtxid{ptx->GetWitnessHash()};
306 : :
307 : 53 : Assume(RecentRejectsReconsiderableFilter().contains(parent_wtxid.ToUint256()));
308 : :
309 : : // Only consider children from this peer. This helps prevent censorship attempts in which an attacker
310 : : // sends lots of fake children for the parent, and we (unluckily) keep selecting the fake
311 : : // children instead of the real one provided by the honest peer. Since we track all announcers
312 : : // of an orphan, this does not exclude parent + orphan pairs that we happened to request from
313 : : // different peers.
314 : 53 : const auto cpfp_candidates_same_peer{m_orphanage.GetChildrenFromSamePeer(ptx, nodeid)};
315 : :
316 : : // These children should be sorted from newest to oldest. In the (probably uncommon) case
317 : : // of children that replace each other, this helps us accept the highest feerate (probably the
318 : : // most recent) one efficiently.
319 [ + + ]: 53 : for (const auto& child : cpfp_candidates_same_peer) {
320 [ + + + - : 75 : Package maybe_cpfp_package{ptx, child};
- - - - ]
321 [ + - + - : 50 : if (!RecentRejectsReconsiderableFilter().contains(GetPackageHash(maybe_cpfp_package)) &&
+ - + - +
- ]
322 [ + - + - ]: 25 : !RecentRejectsFilter().contains(child->GetHash().ToUint256())) {
323 [ + - ]: 25 : return PackageToValidate{ptx, child, nodeid, nodeid};
324 : : }
325 : 25 : }
326 : 28 : return std::nullopt;
327 [ + - + - : 128 : }
+ - ]
328 : :
329 : 11563 : void TxDownloadManagerImpl::MempoolAcceptedTx(const CTransactionRef& tx)
330 : : {
331 : : // As this version of the transaction was acceptable, we can forget about any requests for it.
332 : : // No-op if the tx is not in txrequest.
333 : 11563 : m_txrequest.ForgetTxHash(tx->GetHash());
334 : 11563 : m_txrequest.ForgetTxHash(tx->GetWitnessHash());
335 : :
336 : 11563 : m_orphanage.AddChildrenToWorkSet(*tx, m_opts.m_rng);
337 : : // If it came from the orphanage, remove it. No-op if the tx is not in txorphanage.
338 : 11563 : m_orphanage.EraseTx(tx->GetWitnessHash());
339 : 11563 : }
340 : :
341 : 479 : std::vector<Txid> TxDownloadManagerImpl::GetUniqueParents(const CTransaction& tx)
342 : : {
343 : 479 : std::vector<Txid> unique_parents;
344 [ + - ]: 479 : unique_parents.reserve(tx.vin.size());
345 [ + + ]: 1078 : for (const CTxIn& txin : tx.vin) {
346 : : // We start with all parents, and then remove duplicates below.
347 [ + - ]: 599 : unique_parents.push_back(txin.prevout.hash);
348 : : }
349 : :
350 : 479 : std::sort(unique_parents.begin(), unique_parents.end());
351 : 479 : unique_parents.erase(std::unique(unique_parents.begin(), unique_parents.end()), unique_parents.end());
352 : :
353 : 479 : return unique_parents;
354 : 0 : }
355 : :
356 : 704 : node::RejectedTxTodo TxDownloadManagerImpl::MempoolRejectedTx(const CTransactionRef& ptx, const TxValidationState& state, NodeId nodeid, bool first_time_failure)
357 : : {
358 [ + + ]: 704 : const CTransaction& tx{*ptx};
359 : : // Results returned to caller
360 : : // Whether we should call AddToCompactExtraTransactions at the end
361 : 704 : bool add_extra_compact_tx{first_time_failure};
362 : : // Hashes to pass to AddKnownTx later
363 : 704 : std::vector<Txid> unique_parents;
364 : : // Populated if failure is reconsiderable and eligible package is found.
365 : 704 : std::optional<node::PackageToValidate> package_to_validate;
366 : :
367 [ + + ]: 704 : if (state.GetResult() == TxValidationResult::TX_MISSING_INPUTS) {
368 : : // Only process a new orphan if this is a first time failure, as otherwise it must be either
369 : : // already in orphanage or from 1p1c processing.
370 [ + - + - : 472 : if (first_time_failure && !RecentRejectsFilter().contains(ptx->GetWitnessHash().ToUint256())) {
+ - + - ]
371 : 472 : bool fRejectedParents = false; // It may be the case that the orphans parents have all been rejected
372 : :
373 : : // Deduplicate parent txids, so that we don't have to loop over
374 : : // the same parent txid more than once down below.
375 [ + - ]: 944 : unique_parents = GetUniqueParents(tx);
376 : :
377 : : // Distinguish between parents in m_lazy_recent_rejects and m_lazy_recent_rejects_reconsiderable.
378 : : // We can tolerate having up to 1 parent in m_lazy_recent_rejects_reconsiderable since we
379 : : // submit 1p1c packages. However, fail immediately if any are in m_lazy_recent_rejects.
380 : 472 : std::optional<uint256> rejected_parent_reconsiderable;
381 [ + - + + ]: 988 : for (const uint256& parent_txid : unique_parents) {
382 [ + - + - : 554 : if (RecentRejectsFilter().contains(parent_txid)) {
+ + ]
383 : : fRejectedParents = true;
384 : : break;
385 [ + - + - : 537 : } else if (RecentRejectsReconsiderableFilter().contains(parent_txid) &&
+ + + + ]
386 [ + - ]: 19 : !m_opts.m_mempool.exists(GenTxid::Txid(parent_txid))) {
387 : : // More than 1 parent in m_lazy_recent_rejects_reconsiderable: 1p1c will not be
388 : : // sufficient to accept this package, so just give up here.
389 [ + + ]: 17 : if (rejected_parent_reconsiderable.has_value()) {
390 : : fRejectedParents = true;
391 : : break;
392 : : }
393 : 15 : rejected_parent_reconsiderable = parent_txid;
394 : : }
395 : : }
396 [ + + ]: 472 : if (!fRejectedParents) {
397 : : // Filter parents that we already have.
398 : : // Exclude m_lazy_recent_rejects_reconsiderable: the missing parent may have been
399 : : // previously rejected for being too low feerate. This orphan might CPFP it.
400 [ + - ]: 434 : std::erase_if(unique_parents, [&](const auto& txid){
401 : 496 : return AlreadyHaveTx(GenTxid::Txid(txid), /*include_reconsiderable=*/false);
402 : : });
403 : 434 : const auto now{GetTime<std::chrono::microseconds>()};
404 [ + - ]: 434 : const auto& wtxid = ptx->GetWitnessHash();
405 : : // Potentially flip add_extra_compact_tx to false if tx is already in orphanage, which
406 : : // means it was already added to vExtraTxnForCompact.
407 [ + - ]: 434 : add_extra_compact_tx &= !m_orphanage.HaveTx(wtxid);
408 : :
409 : : // If there is no candidate for orphan resolution, AddTx will not be called. This means
410 : : // that if a peer is overloading us with invs and orphans, they will eventually not be
411 : : // able to add any more transactions to the orphanage.
412 : : //
413 : : // Search by txid and, if the tx has a witness, wtxid
414 [ + - ]: 434 : std::vector<NodeId> orphan_resolution_candidates{nodeid};
415 [ + - ]: 434 : m_txrequest.GetCandidatePeers(ptx->GetHash().ToUint256(), orphan_resolution_candidates);
416 [ + + + - ]: 434 : if (ptx->HasWitness()) m_txrequest.GetCandidatePeers(ptx->GetWitnessHash().ToUint256(), orphan_resolution_candidates);
417 : :
418 [ + + ]: 871 : for (const auto& nodeid : orphan_resolution_candidates) {
419 [ + - + - ]: 437 : if (MaybeAddOrphanResolutionCandidate(unique_parents, ptx->GetWitnessHash(), nodeid, now)) {
420 [ + - ]: 437 : m_orphanage.AddTx(ptx, nodeid);
421 : : }
422 : : }
423 : :
424 : : // Once added to the orphan pool, a tx is considered AlreadyHave, and we shouldn't request it anymore.
425 [ + - ]: 434 : m_txrequest.ForgetTxHash(tx.GetHash());
426 [ + - ]: 434 : m_txrequest.ForgetTxHash(tx.GetWitnessHash());
427 : :
428 : : // DoS prevention: do not allow m_orphanage to grow unbounded (see CVE-2012-3789)
429 : : // Note that, if the orphanage reaches capacity, it's possible that we immediately evict
430 : : // the transaction we just added.
431 [ + - ]: 434 : m_orphanage.LimitOrphans(m_opts.m_max_orphan_txs, m_opts.m_rng);
432 : 434 : } else {
433 [ + - ]: 38 : unique_parents.clear();
434 [ + - + - : 76 : LogDebug(BCLog::MEMPOOL, "not keeping orphan with rejected parents %s (wtxid=%s)\n",
+ - + - +
- ]
435 : : tx.GetHash().ToString(),
436 : : tx.GetWitnessHash().ToString());
437 : : // We will continue to reject this tx since it has rejected
438 : : // parents so avoid re-requesting it from other peers.
439 : : // Here we add both the txid and the wtxid, as we know that
440 : : // regardless of what witness is provided, we will not accept
441 : : // this, so we don't need to allow for redownload of this txid
442 : : // from any of our non-wtxidrelay peers.
443 [ + - + - ]: 38 : RecentRejectsFilter().insert(tx.GetHash().ToUint256());
444 [ + - + - ]: 38 : RecentRejectsFilter().insert(tx.GetWitnessHash().ToUint256());
445 [ + - ]: 38 : m_txrequest.ForgetTxHash(tx.GetHash());
446 [ + - ]: 38 : m_txrequest.ForgetTxHash(tx.GetWitnessHash());
447 : : }
448 : : }
449 [ + + ]: 232 : } else if (state.GetResult() == TxValidationResult::TX_WITNESS_STRIPPED) {
450 : : add_extra_compact_tx = false;
451 : : } else {
452 : : // We can add the wtxid of this transaction to our reject filter.
453 : : // Do not add txids of witness transactions or witness-stripped
454 : : // transactions to the filter, as they can have been malleated;
455 : : // adding such txids to the reject filter would potentially
456 : : // interfere with relay of valid transactions from peers that
457 : : // do not support wtxid-based relay. See
458 : : // https://github.com/bitcoin/bitcoin/issues/8279 for details.
459 : : // We can remove this restriction (and always add wtxids to
460 : : // the filter even for witness stripped transactions) once
461 : : // wtxid-based relay is broadly deployed.
462 : : // See also comments in https://github.com/bitcoin/bitcoin/pull/18044#discussion_r443419034
463 : : // for concerns around weakening security of unupgraded nodes
464 : : // if we start doing this too early.
465 [ + + ]: 226 : if (state.GetResult() == TxValidationResult::TX_RECONSIDERABLE) {
466 : : // If the result is TX_RECONSIDERABLE, add it to m_lazy_recent_rejects_reconsiderable
467 : : // because we should not download or submit this transaction by itself again, but may
468 : : // submit it as part of a package later.
469 [ + - + - ]: 37 : RecentRejectsReconsiderableFilter().insert(ptx->GetWitnessHash().ToUint256());
470 : :
471 [ + + ]: 37 : if (first_time_failure) {
472 : : // When a transaction fails for TX_RECONSIDERABLE, look for a matching child in the
473 : : // orphanage, as it is possible that they succeed as a package.
474 [ + - + - : 64 : LogDebug(BCLog::TXPACKAGES, "tx %s (wtxid=%s) failed but reconsiderable, looking for child in orphanage\n",
+ - + - +
- ]
475 : : ptx->GetHash().ToString(), ptx->GetWitnessHash().ToString());
476 [ + - + + ]: 96 : package_to_validate = Find1P1CPackage(ptx, nodeid);
477 : : }
478 : : } else {
479 [ + - + - ]: 189 : RecentRejectsFilter().insert(ptx->GetWitnessHash().ToUint256());
480 : : }
481 [ + - ]: 226 : m_txrequest.ForgetTxHash(ptx->GetWitnessHash());
482 : : // If the transaction failed for TX_INPUTS_NOT_STANDARD,
483 : : // then we know that the witness was irrelevant to the policy
484 : : // failure, since this check depends only on the txid
485 : : // (the scriptPubKey being spent is covered by the txid).
486 : : // Add the txid to the reject filter to prevent repeated
487 : : // processing of this transaction in the event that child
488 : : // transactions are later received (resulting in
489 : : // parent-fetching by txid via the orphan-handling logic).
490 : : // We only add the txid if it differs from the wtxid, to avoid wasting entries in the
491 : : // rolling bloom filter.
492 [ + + + + ]: 226 : if (state.GetResult() == TxValidationResult::TX_INPUTS_NOT_STANDARD && ptx->HasWitness()) {
493 [ + - + - ]: 3 : RecentRejectsFilter().insert(ptx->GetHash().ToUint256());
494 [ + - ]: 3 : m_txrequest.ForgetTxHash(ptx->GetHash());
495 : : }
496 : : }
497 : :
498 : : // If the tx failed in ProcessOrphanTx, it should be removed from the orphanage unless the
499 : : // tx was still missing inputs. If the tx was not in the orphanage, EraseTx does nothing and returns 0.
500 [ + + + - : 704 : if (state.GetResult() != TxValidationResult::TX_MISSING_INPUTS && m_orphanage.EraseTx(ptx->GetWitnessHash()) > 0) {
+ + ]
501 [ + - + - : 20 : LogDebug(BCLog::TXPACKAGES, " removed orphan tx %s (wtxid=%s)\n", ptx->GetHash().ToString(), ptx->GetWitnessHash().ToString());
+ - + - +
- ]
502 : : }
503 : :
504 [ + + + + ]: 712 : return RejectedTxTodo{
505 : : .m_should_add_extra_compact_tx = add_extra_compact_tx,
506 : : .m_unique_parents = std::move(unique_parents),
507 : : .m_package_to_validate = std::move(package_to_validate)
508 : 704 : };
509 : 704 : }
510 : :
511 : 4 : void TxDownloadManagerImpl::MempoolRejectedPackage(const Package& package)
512 : : {
513 : 4 : RecentRejectsReconsiderableFilter().insert(GetPackageHash(package));
514 : 4 : }
515 : :
516 : 12010 : std::pair<bool, std::optional<PackageToValidate>> TxDownloadManagerImpl::ReceivedTx(NodeId nodeid, const CTransactionRef& ptx)
517 : : {
518 : 12010 : const uint256& txid = ptx->GetHash();
519 : 12010 : const uint256& wtxid = ptx->GetWitnessHash();
520 : :
521 : : // Mark that we have received a response
522 : 12010 : m_txrequest.ReceivedResponse(nodeid, txid);
523 [ + + ]: 12010 : if (ptx->HasWitness()) m_txrequest.ReceivedResponse(nodeid, wtxid);
524 : :
525 : : // First check if we should drop this tx.
526 : : // We do the AlreadyHaveTx() check using wtxid, rather than txid - in the
527 : : // absence of witness malleation, this is strictly better, because the
528 : : // recent rejects filter may contain the wtxid but rarely contains
529 : : // the txid of a segwit transaction that has been rejected.
530 : : // In the presence of witness malleation, it's possible that by only
531 : : // doing the check with wtxid, we could overlook a transaction which
532 : : // was confirmed with a different witness, or exists in our mempool
533 : : // with a different witness, but this has limited downside:
534 : : // mempool validation does its own lookup of whether we have the txid
535 : : // already; and an adversary can already relay us old transactions
536 : : // (older than our recency filter) if trying to DoS us, without any need
537 : : // for witness malleation.
538 [ + + ]: 12010 : if (AlreadyHaveTx(GenTxid::Wtxid(wtxid), /*include_reconsiderable=*/false)) {
539 : : // If a tx is detected by m_lazy_recent_rejects it is ignored. Because we haven't
540 : : // submitted the tx to our mempool, we won't have computed a DoS
541 : : // score for it or determined exactly why we consider it invalid.
542 : : //
543 : : // This means we won't penalize any peer subsequently relaying a DoSy
544 : : // tx (even if we penalized the first peer who gave it to us) because
545 : : // we have to account for m_lazy_recent_rejects showing false positives. In
546 : : // other words, we shouldn't penalize a peer if we aren't *sure* they
547 : : // submitted a DoSy tx.
548 : : //
549 : : // Note that m_lazy_recent_rejects doesn't just record DoSy or invalid
550 : : // transactions, but any tx not accepted by the mempool, which may be
551 : : // due to node policy (vs. consensus). So we can't blanket penalize a
552 : : // peer simply for relaying a tx that our m_lazy_recent_rejects has caught,
553 : : // regardless of false positives.
554 : 9 : return {false, std::nullopt};
555 [ + + ]: 12001 : } else if (RecentRejectsReconsiderableFilter().contains(wtxid)) {
556 : : // When a transaction is already in m_lazy_recent_rejects_reconsiderable, we shouldn't submit
557 : : // it by itself again. However, look for a matching child in the orphanage, as it is
558 : : // possible that they succeed as a package.
559 [ + - + - : 42 : LogDebug(BCLog::TXPACKAGES, "found tx %s (wtxid=%s) in reconsiderable rejects, looking for child in orphanage\n",
+ - ]
560 : : txid.ToString(), wtxid.ToString());
561 [ + + + + ]: 59 : return {false, Find1P1CPackage(ptx, nodeid)};
562 : : }
563 : :
564 : :
565 : 11980 : return {true, std::nullopt};
566 : : }
567 : :
568 : 157184 : bool TxDownloadManagerImpl::HaveMoreWork(NodeId nodeid)
569 : : {
570 : 157184 : return m_orphanage.HaveTxToReconsider(nodeid);
571 : : }
572 : :
573 : 403634 : CTransactionRef TxDownloadManagerImpl::GetTxToReconsider(NodeId nodeid)
574 : : {
575 : 403634 : return m_orphanage.GetTxToReconsider(nodeid);
576 : : }
577 : :
578 : 1580 : void TxDownloadManagerImpl::CheckIsEmpty(NodeId nodeid)
579 : : {
580 [ - + ]: 1580 : assert(m_txrequest.Count(nodeid) == 0);
581 [ - + ]: 1580 : assert(m_orphanage.UsageByPeer(nodeid) == 0);
582 : 1580 : }
583 : 888 : void TxDownloadManagerImpl::CheckIsEmpty()
584 : : {
585 [ - + ]: 888 : assert(m_orphanage.TotalOrphanUsage() == 0);
586 [ - + ]: 888 : assert(m_orphanage.Size() == 0);
587 [ - + ]: 888 : assert(m_txrequest.Size() == 0);
588 [ - + ]: 888 : assert(m_num_wtxid_peers == 0);
589 : 888 : }
590 : 161 : std::vector<TxOrphanage::OrphanTxBase> TxDownloadManagerImpl::GetOrphanTransactions() const
591 : : {
592 : 161 : return m_orphanage.GetOrphanTransactions();
593 : : }
594 : : } // namespace node
|
