Branch data Line data Source code
1 : : // Copyright (c) 2009-2010 Satoshi Nakamoto
2 : : // Copyright (c) 2009-2022 The Bitcoin Core developers
3 : : // Distributed under the MIT software license, see the accompanying
4 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
5 : :
6 : : #include <node/miner.h>
7 : :
8 : : #include <chain.h>
9 : : #include <chainparams.h>
10 : : #include <coins.h>
11 : : #include <common/args.h>
12 : : #include <consensus/amount.h>
13 : : #include <consensus/consensus.h>
14 : : #include <consensus/merkle.h>
15 : : #include <consensus/tx_verify.h>
16 : : #include <consensus/validation.h>
17 : : #include <deploymentstatus.h>
18 : : #include <logging.h>
19 : : #include <policy/feerate.h>
20 : : #include <policy/policy.h>
21 : : #include <pow.h>
22 : : #include <primitives/transaction.h>
23 : : #include <util/moneystr.h>
24 : : #include <util/time.h>
25 : : #include <validation.h>
26 : :
27 : : #include <algorithm>
28 : : #include <utility>
29 : :
30 : : namespace node {
31 : :
32 : 49968 : int64_t GetMinimumTime(const CBlockIndex* pindexPrev, const int64_t difficulty_adjustment_interval)
33 : : {
34 : 49968 : int64_t min_time{pindexPrev->GetMedianTimePast() + 1};
35 : : // Height of block to be mined.
36 : 49968 : const int height{pindexPrev->nHeight + 1};
37 : : // Account for BIP94 timewarp rule on all networks. This makes future
38 : : // activation safer.
39 [ + + ]: 49968 : if (height % difficulty_adjustment_interval == 0) {
40 [ + + ]: 439 : min_time = std::max<int64_t>(min_time, pindexPrev->GetBlockTime() - MAX_TIMEWARP);
41 : : }
42 : 49968 : return min_time;
43 : : }
44 : :
45 : 47898 : int64_t UpdateTime(CBlockHeader* pblock, const Consensus::Params& consensusParams, const CBlockIndex* pindexPrev)
46 : : {
47 : 47898 : int64_t nOldTime = pblock->nTime;
48 [ + + ]: 47898 : int64_t nNewTime{std::max<int64_t>(GetMinimumTime(pindexPrev, consensusParams.DifficultyAdjustmentInterval()),
49 : 47898 : TicksSinceEpoch<std::chrono::seconds>(NodeClock::now()))};
50 : :
51 [ + + ]: 47898 : if (nOldTime < nNewTime) {
52 : 36405 : pblock->nTime = nNewTime;
53 : : }
54 : :
55 : : // Updating time can change work required on testnet:
56 [ + + ]: 47898 : if (consensusParams.fPowAllowMinDifficultyBlocks) {
57 : 47761 : pblock->nBits = GetNextWorkRequired(pindexPrev, pblock, consensusParams);
58 : : }
59 : :
60 : 47898 : return nNewTime - nOldTime;
61 : : }
62 : :
63 : 6649 : void RegenerateCommitments(CBlock& block, ChainstateManager& chainman)
64 : : {
65 : 6649 : CMutableTransaction tx{*block.vtx.at(0)};
66 : 6649 : tx.vout.erase(tx.vout.begin() + GetWitnessCommitmentIndex(block));
67 [ + - + - : 13298 : block.vtx.at(0) = MakeTransactionRef(tx);
- + ]
68 : :
69 [ + - + - : 19947 : const CBlockIndex* prev_block = WITH_LOCK(::cs_main, return chainman.m_blockman.LookupBlockIndex(block.hashPrevBlock));
+ - ]
70 [ + - ]: 6649 : chainman.GenerateCoinbaseCommitment(block, prev_block);
71 : :
72 [ + - ]: 6649 : block.hashMerkleRoot = BlockMerkleRoot(block);
73 : 6649 : }
74 : :
75 : 45818 : static BlockAssembler::Options ClampOptions(BlockAssembler::Options options)
76 : : {
77 : 45818 : Assert(options.block_reserved_weight <= MAX_BLOCK_WEIGHT);
78 : 45818 : Assert(options.block_reserved_weight >= MINIMUM_BLOCK_RESERVED_WEIGHT);
79 : 45818 : Assert(options.coinbase_output_max_additional_sigops <= MAX_BLOCK_SIGOPS_COST);
80 : : // Limit weight to between block_reserved_weight and MAX_BLOCK_WEIGHT for sanity:
81 : : // block_reserved_weight can safely exceed -blockmaxweight, but the rest of the block template will be empty.
82 [ + - ]: 45818 : options.nBlockMaxWeight = std::clamp<size_t>(options.nBlockMaxWeight, options.block_reserved_weight, MAX_BLOCK_WEIGHT);
83 : 45818 : return options;
84 : : }
85 : :
86 : 45818 : BlockAssembler::BlockAssembler(Chainstate& chainstate, const CTxMemPool* mempool, const Options& options)
87 : 45818 : : chainparams{chainstate.m_chainman.GetParams()},
88 [ + + ]: 45818 : m_mempool{options.use_mempool ? mempool : nullptr},
89 : 45818 : m_chainstate{chainstate},
90 [ + - + + : 46156 : m_options{ClampOptions(options)}
+ - ]
91 : : {
92 : 45818 : }
93 : :
94 : 38413 : void ApplyArgsManOptions(const ArgsManager& args, BlockAssembler::Options& options)
95 : : {
96 : : // Block resource limits
97 [ + - ]: 38413 : options.nBlockMaxWeight = args.GetIntArg("-blockmaxweight", options.nBlockMaxWeight);
98 [ + - + + ]: 76826 : if (const auto blockmintxfee{args.GetArg("-blockmintxfee")}) {
99 [ + - + - ]: 18 : if (const auto parsed{ParseMoney(*blockmintxfee)}) options.blockMinFeeRate = CFeeRate{*parsed};
100 : 0 : }
101 [ + - ]: 38413 : options.print_modified_fee = args.GetBoolArg("-printpriority", options.print_modified_fee);
102 [ + - ]: 38413 : options.block_reserved_weight = args.GetIntArg("-blockreservedweight", options.block_reserved_weight);
103 : 38413 : }
104 : :
105 : 45818 : void BlockAssembler::resetBlock()
106 : : {
107 : 45818 : inBlock.clear();
108 : :
109 : : // Reserve space for fixed-size block header, txs count, and coinbase tx.
110 : 45818 : nBlockWeight = m_options.block_reserved_weight;
111 : 45818 : nBlockSigOpsCost = m_options.coinbase_output_max_additional_sigops;
112 : :
113 : : // These counters do not include coinbase tx
114 : 45818 : nBlockTx = 0;
115 : 45818 : nFees = 0;
116 : 45818 : }
117 : :
118 : 45818 : std::unique_ptr<CBlockTemplate> BlockAssembler::CreateNewBlock()
119 : : {
120 : 45818 : const auto time_start{SteadyClock::now()};
121 : :
122 : 45818 : resetBlock();
123 : :
124 [ - + ]: 45818 : pblocktemplate.reset(new CBlockTemplate());
125 : 45818 : CBlock* const pblock = &pblocktemplate->block; // pointer for convenience
126 : :
127 : : // Add dummy coinbase tx as first transaction. It is skipped by the
128 : : // getblocktemplate RPC and mining interface consumers must not use it.
129 : 45818 : pblock->vtx.emplace_back();
130 : :
131 : 45818 : LOCK(::cs_main);
132 [ + - ]: 45818 : CBlockIndex* pindexPrev = m_chainstate.m_chain.Tip();
133 [ - + ]: 45818 : assert(pindexPrev != nullptr);
134 : 45818 : nHeight = pindexPrev->nHeight + 1;
135 : :
136 [ + - ]: 45818 : pblock->nVersion = m_chainstate.m_chainman.m_versionbitscache.ComputeBlockVersion(pindexPrev, chainparams.GetConsensus());
137 : : // -regtest only: allow overriding block.nVersion with
138 : : // -blockversion=N to test forking scenarios
139 [ + + ]: 45818 : if (chainparams.MineBlocksOnDemand()) {
140 [ + - + - ]: 45682 : pblock->nVersion = gArgs.GetIntArg("-blockversion", pblock->nVersion);
141 : : }
142 : :
143 : 45818 : pblock->nTime = TicksSinceEpoch<std::chrono::seconds>(NodeClock::now());
144 : 45818 : m_lock_time_cutoff = pindexPrev->GetMedianTimePast();
145 : :
146 : 45818 : int nPackagesSelected = 0;
147 : 45818 : int nDescendantsUpdated = 0;
148 [ + + ]: 45818 : if (m_mempool) {
149 [ + - ]: 39167 : addPackageTxs(nPackagesSelected, nDescendantsUpdated);
150 : : }
151 : :
152 : 45818 : const auto time_1{SteadyClock::now()};
153 : :
154 [ + + ]: 45818 : m_last_block_num_txs = nBlockTx;
155 [ + + ]: 45818 : m_last_block_weight = nBlockWeight;
156 : :
157 : : // Create coinbase transaction.
158 [ + - ]: 45818 : CMutableTransaction coinbaseTx;
159 [ + - ]: 45818 : coinbaseTx.vin.resize(1);
160 : 45818 : coinbaseTx.vin[0].prevout.SetNull();
161 [ + - ]: 45818 : coinbaseTx.vout.resize(1);
162 : 45818 : coinbaseTx.vout[0].scriptPubKey = m_options.coinbase_output_script;
163 [ + - + - ]: 45818 : coinbaseTx.vout[0].nValue = nFees + GetBlockSubsidy(nHeight, chainparams.GetConsensus());
164 [ + - + - ]: 45818 : coinbaseTx.vin[0].scriptSig = CScript() << nHeight << OP_0;
165 [ + - - + ]: 91636 : pblock->vtx[0] = MakeTransactionRef(std::move(coinbaseTx));
166 [ + - ]: 45818 : pblocktemplate->vchCoinbaseCommitment = m_chainstate.m_chainman.GenerateCoinbaseCommitment(*pblock, pindexPrev);
167 : :
168 [ + - ]: 45818 : LogPrintf("CreateNewBlock(): block weight: %u txs: %u fees: %ld sigops %d\n", GetBlockWeight(*pblock), nBlockTx, nFees, nBlockSigOpsCost);
169 : :
170 : : // Fill in header
171 : 45818 : pblock->hashPrevBlock = pindexPrev->GetBlockHash();
172 [ + - ]: 45818 : UpdateTime(pblock, chainparams.GetConsensus(), pindexPrev);
173 [ + - ]: 45818 : pblock->nBits = GetNextWorkRequired(pindexPrev, pblock, chainparams.GetConsensus());
174 : 45818 : pblock->nNonce = 0;
175 : :
176 [ + - ]: 45818 : BlockValidationState state;
177 [ + - + - : 45818 : if (m_options.test_block_validity && !TestBlockValidity(state, chainparams, m_chainstate, *pblock, pindexPrev,
+ + ]
178 : : /*fCheckPOW=*/false, /*fCheckMerkleRoot=*/false)) {
179 [ + - + - : 10 : throw std::runtime_error(strprintf("%s: TestBlockValidity failed: %s", __func__, state.ToString()));
+ - ]
180 : : }
181 : 45813 : const auto time_2{SteadyClock::now()};
182 : :
183 [ + - + - : 45813 : LogDebug(BCLog::BENCH, "CreateNewBlock() packages: %.2fms (%d packages, %d updated descendants), validity: %.2fms (total %.2fms)\n",
+ - ]
184 : : Ticks<MillisecondsDouble>(time_1 - time_start), nPackagesSelected, nDescendantsUpdated,
185 : : Ticks<MillisecondsDouble>(time_2 - time_1),
186 : : Ticks<MillisecondsDouble>(time_2 - time_start));
187 : :
188 : 45813 : return std::move(pblocktemplate);
189 [ + - ]: 137449 : }
190 : :
191 : 7890 : void BlockAssembler::onlyUnconfirmed(CTxMemPool::setEntries& testSet)
192 : : {
193 [ + + ]: 19542 : for (CTxMemPool::setEntries::iterator iit = testSet.begin(); iit != testSet.end(); ) {
194 : : // Only test txs not already in the block
195 [ + - + - : 34956 : if (inBlock.count((*iit)->GetSharedTx()->GetHash())) {
+ - + + ]
196 : 8779 : testSet.erase(iit++);
197 : : } else {
198 : 2873 : iit++;
199 : : }
200 : : }
201 : 7890 : }
202 : :
203 : 43090 : bool BlockAssembler::TestPackage(uint64_t packageSize, int64_t packageSigOpsCost) const
204 : : {
205 : : // TODO: switch to weight-based accounting for packages instead of vsize-based accounting.
206 [ + + ]: 43090 : if (nBlockWeight + WITNESS_SCALE_FACTOR * packageSize >= m_options.nBlockMaxWeight) {
207 : : return false;
208 : : }
209 [ + + ]: 7904 : if (nBlockSigOpsCost + packageSigOpsCost >= MAX_BLOCK_SIGOPS_COST) {
210 : 14 : return false;
211 : : }
212 : : return true;
213 : : }
214 : :
215 : : // Perform transaction-level checks before adding to block:
216 : : // - transaction finality (locktime)
217 : 7890 : bool BlockAssembler::TestPackageTransactions(const CTxMemPool::setEntries& package) const
218 : : {
219 [ + + ]: 18651 : for (CTxMemPool::txiter it : package) {
220 [ + + ]: 10763 : if (!IsFinalTx(it->GetTx(), nHeight, m_lock_time_cutoff)) {
221 : : return false;
222 : : }
223 : : }
224 : : return true;
225 : : }
226 : :
227 : 10761 : void BlockAssembler::AddToBlock(CTxMemPool::txiter iter)
228 : : {
229 [ + - + - ]: 21522 : pblocktemplate->block.vtx.emplace_back(iter->GetSharedTx());
230 : 10761 : pblocktemplate->vTxFees.push_back(iter->GetFee());
231 : 10761 : pblocktemplate->vTxSigOpsCost.push_back(iter->GetSigOpCost());
232 [ + - ]: 10761 : nBlockWeight += iter->GetTxWeight();
233 : 10761 : ++nBlockTx;
234 [ + - ]: 10761 : nBlockSigOpsCost += iter->GetSigOpCost();
235 : 10761 : nFees += iter->GetFee();
236 [ + - + - : 21522 : inBlock.insert(iter->GetSharedTx()->GetHash());
+ - ]
237 : :
238 [ + + ]: 10761 : if (m_options.print_modified_fee) {
239 [ + - + - : 174 : LogPrintf("fee rate %s txid %s\n",
+ - + - ]
240 : : CFeeRate(iter->GetModifiedFee(), iter->GetTxSize()).ToString(),
241 : : iter->GetTx().GetHash().ToString());
242 : : }
243 : 10761 : }
244 : :
245 : : /** Add descendants of given transactions to mapModifiedTx with ancestor
246 : : * state updated assuming given transactions are inBlock. Returns number
247 : : * of updated descendants. */
248 : 7888 : static int UpdatePackagesForAdded(const CTxMemPool& mempool,
249 : : const CTxMemPool::setEntries& alreadyAdded,
250 : : indexed_modified_transaction_set& mapModifiedTx) EXCLUSIVE_LOCKS_REQUIRED(mempool.cs)
251 : : {
252 : 7888 : AssertLockHeld(mempool.cs);
253 : :
254 : 7888 : int nDescendantsUpdated = 0;
255 [ + + ]: 18649 : for (CTxMemPool::txiter it : alreadyAdded) {
256 [ + - ]: 10761 : CTxMemPool::setEntries descendants;
257 [ + - ]: 10761 : mempool.CalculateDescendants(it, descendants);
258 : : // Insert all descendants (not yet in block) into the modified set
259 [ + + ]: 1037646 : for (CTxMemPool::txiter desc : descendants) {
260 [ + + ]: 1026885 : if (alreadyAdded.count(desc)) {
261 : 775113 : continue;
262 : : }
263 : 251772 : ++nDescendantsUpdated;
264 : 251772 : modtxiter mit = mapModifiedTx.find(desc);
265 [ + + ]: 251772 : if (mit == mapModifiedTx.end()) {
266 [ + - ]: 1818 : CTxMemPoolModifiedEntry modEntry(desc);
267 [ + - ]: 1818 : mit = mapModifiedTx.insert(modEntry).first;
268 : : }
269 [ + - ]: 1278657 : mapModifiedTx.modify(mit, update_for_parent_inclusion(it));
270 : : }
271 : 10761 : }
272 : 7888 : return nDescendantsUpdated;
273 : : }
274 : :
275 : 7888 : void BlockAssembler::SortForBlock(const CTxMemPool::setEntries& package, std::vector<CTxMemPool::txiter>& sortedEntries)
276 : : {
277 : : // Sort package by ancestor count
278 : : // If a transaction A depends on transaction B, then A's ancestor count
279 : : // must be greater than B's. So this is sufficient to validly order the
280 : : // transactions for block inclusion.
281 [ - + ]: 7888 : sortedEntries.clear();
282 : 7888 : sortedEntries.insert(sortedEntries.begin(), package.begin(), package.end());
283 : 7888 : std::sort(sortedEntries.begin(), sortedEntries.end(), CompareTxIterByAncestorCount());
284 : 7888 : }
285 : :
286 : : // This transaction selection algorithm orders the mempool based
287 : : // on feerate of a transaction including all unconfirmed ancestors.
288 : : // Since we don't remove transactions from the mempool as we select them
289 : : // for block inclusion, we need an alternate method of updating the feerate
290 : : // of a transaction with its not-yet-selected ancestors as we go.
291 : : // This is accomplished by walking the in-mempool descendants of selected
292 : : // transactions and storing a temporary modified state in mapModifiedTxs.
293 : : // Each time through the loop, we compare the best transaction in
294 : : // mapModifiedTxs with the next transaction in the mempool to decide what
295 : : // transaction package to work on next.
296 : 39167 : void BlockAssembler::addPackageTxs(int& nPackagesSelected, int& nDescendantsUpdated)
297 : : {
298 : 39167 : const auto& mempool{*Assert(m_mempool)};
299 : 39167 : LOCK(mempool.cs);
300 : :
301 : : // mapModifiedTx will store sorted packages after they are modified
302 : : // because some of their txs are already in the block
303 [ + - ]: 39167 : indexed_modified_transaction_set mapModifiedTx;
304 : : // Keep track of entries that failed inclusion, to avoid duplicate work
305 : 39167 : std::set<Txid> failedTx;
306 : :
307 : 39167 : CTxMemPool::indexed_transaction_set::index<ancestor_score>::type::iterator mi = mempool.mapTx.get<ancestor_score>().begin();
308 : 39167 : CTxMemPool::txiter iter;
309 : :
310 : : // Limit the number of attempts to add transactions to the block when it is
311 : : // close to full; this is just a simple heuristic to finish quickly if the
312 : : // mempool has a lot of entries.
313 : 39167 : const int64_t MAX_CONSECUTIVE_FAILURES = 1000;
314 : 39167 : int64_t nConsecutiveFailed = 0;
315 : :
316 [ + + + + ]: 85873 : while (mi != mempool.mapTx.get<ancestor_score>().end() || !mapModifiedTx.empty()) {
317 : : // First try to find a new transaction in mapTx to evaluate.
318 : : //
319 : : // Skip entries in mapTx that are already in a block or are present
320 : : // in mapModifiedTx (which implies that the mapTx ancestor state is
321 : : // stale due to ancestor inclusion in the block)
322 : : // Also skip transactions that we've already failed to add. This can happen if
323 : : // we consider a transaction in mapModifiedTx and it fails: we can then
324 : : // potentially consider it again while walking mapTx. It's currently
325 : : // guaranteed to fail again, but as a belt-and-suspenders check we put it in
326 : : // failedTx and avoid re-evaluation, since the re-evaluation would be using
327 : : // cached size/sigops/fee values that are not actually correct.
328 : : /** Return true if given transaction from mapTx has already been evaluated,
329 : : * or if the transaction's cached data in mapTx is incorrect. */
330 [ + + ]: 46762 : if (mi != mempool.mapTx.get<ancestor_score>().end()) {
331 [ - + ]: 46228 : auto it = mempool.mapTx.project<0>(mi);
332 [ - + ]: 46228 : assert(it != mempool.mapTx.end());
333 [ + + + - : 220522 : if (mapModifiedTx.count(it) || inBlock.count(it->GetSharedTx()->GetHash()) || failedTx.count(it->GetSharedTx()->GetHash())) {
+ - + + +
- + - + +
+ + ]
334 : 3632 : ++mi;
335 : 3632 : continue;
336 : : }
337 : : }
338 : :
339 : : // Now that mi is not stale, determine which transaction to evaluate:
340 : : // the next entry from mapTx, or the best from mapModifiedTx?
341 : 43130 : bool fUsingModified = false;
342 : :
343 : 43130 : modtxscoreiter modit = mapModifiedTx.get<ancestor_score>().begin();
344 [ + + ]: 43130 : if (mi == mempool.mapTx.get<ancestor_score>().end()) {
345 : : // We're out of entries in mapTx; use the entry from mapModifiedTx
346 : 534 : iter = modit->iter;
347 : 534 : fUsingModified = true;
348 : : } else {
349 : : // Try to compare the mapTx entry to the mapModifiedTx entry
350 [ + + ]: 42596 : iter = mempool.mapTx.project<0>(mi);
351 [ + + + + ]: 43530 : if (modit != mapModifiedTx.get<ancestor_score>().end() &&
352 [ + - ]: 934 : CompareTxMemPoolEntryByAncestorFee()(*modit, CTxMemPoolModifiedEntry(iter))) {
353 : : // The best entry in mapModifiedTx has higher score
354 : : // than the one from mapTx.
355 : : // Switch which transaction (package) to consider
356 : 264 : iter = modit->iter;
357 : 264 : fUsingModified = true;
358 : : } else {
359 : : // Either no entry in mapModifiedTx, or it's worse than mapTx.
360 : : // Increment mi for the next loop iteration.
361 : 42332 : ++mi;
362 : : }
363 : : }
364 : :
365 : : // We skip mapTx entries that are inBlock, and mapModifiedTx shouldn't
366 : : // contain anything that is inBlock.
367 [ + - + - : 86260 : assert(!inBlock.count(iter->GetSharedTx()->GetHash()));
- + ]
368 : :
369 [ + + ]: 43130 : uint64_t packageSize = iter->GetSizeWithAncestors();
370 [ + + ]: 43130 : CAmount packageFees = iter->GetModFeesWithAncestors();
371 [ + + ]: 43130 : int64_t packageSigOpsCost = iter->GetSigOpCostWithAncestors();
372 [ + + ]: 43130 : if (fUsingModified) {
373 : 798 : packageSize = modit->nSizeWithAncestors;
374 : 798 : packageFees = modit->nModFeesWithAncestors;
375 : 798 : packageSigOpsCost = modit->nSigOpCostWithAncestors;
376 : : }
377 : :
378 [ + - + + ]: 43130 : if (packageFees < m_options.blockMinFeeRate.GetFee(packageSize)) {
379 : : // Everything else we might consider has a lower fee rate
380 : 40 : return;
381 : : }
382 : :
383 [ + - + + ]: 43090 : if (!TestPackage(packageSize, packageSigOpsCost)) {
384 [ + + ]: 35200 : if (fUsingModified) {
385 : : // Since we always look at the best entry in mapModifiedTx,
386 : : // we must erase failed entries so that we can consider the
387 : : // next best entry on the next loop iteration
388 : 66 : mapModifiedTx.get<ancestor_score>().erase(modit);
389 [ + - + - ]: 198 : failedTx.insert(iter->GetSharedTx()->GetHash());
390 : : }
391 : :
392 : 35200 : ++nConsecutiveFailed;
393 : :
394 [ + + ]: 35200 : if (nConsecutiveFailed > MAX_CONSECUTIVE_FAILURES && nBlockWeight >
395 [ - + ]: 16 : m_options.nBlockMaxWeight - m_options.block_reserved_weight) {
396 : : // Give up if we're close to full and haven't succeeded in a while
397 : : break;
398 : : }
399 : 35184 : continue;
400 : : }
401 : :
402 [ + - ]: 7890 : auto ancestors{mempool.AssumeCalculateMemPoolAncestors(__func__, *iter, CTxMemPool::Limits::NoLimits(), /*fSearchForParents=*/false)};
403 : :
404 [ + - ]: 7890 : onlyUnconfirmed(ancestors);
405 [ + - ]: 7890 : ancestors.insert(iter);
406 : :
407 : : // Test if all tx's are Final
408 [ + - + + ]: 7890 : if (!TestPackageTransactions(ancestors)) {
409 [ - + ]: 2 : if (fUsingModified) {
410 : 0 : mapModifiedTx.get<ancestor_score>().erase(modit);
411 [ # # # # ]: 0 : failedTx.insert(iter->GetSharedTx()->GetHash());
412 : : }
413 : 2 : continue;
414 : : }
415 : :
416 : : // This transaction will make it in; reset the failed counter.
417 : 7888 : nConsecutiveFailed = 0;
418 : :
419 : : // Package can be added. Sort the entries in a valid order.
420 : 7888 : std::vector<CTxMemPool::txiter> sortedEntries;
421 [ + - ]: 7888 : SortForBlock(ancestors, sortedEntries);
422 : :
423 [ + + ]: 18649 : for (size_t i = 0; i < sortedEntries.size(); ++i) {
424 [ + - ]: 10761 : AddToBlock(sortedEntries[i]);
425 : : // Erase from the modified set, if present
426 : 10761 : mapModifiedTx.erase(sortedEntries[i]);
427 : : }
428 : :
429 : 7888 : ++nPackagesSelected;
430 [ + - ]: 7888 : pblocktemplate->m_package_feerates.emplace_back(packageFees, static_cast<int32_t>(packageSize));
431 : :
432 : : // Update transactions that depend on each of these
433 [ + - ]: 7888 : nDescendantsUpdated += UpdatePackagesForAdded(mempool, ancestors, mapModifiedTx);
434 : 7890 : }
435 [ + - + - ]: 78334 : }
436 : : } // namespace node
|
