Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <test/data/tx_invalid.json.h>
6 : : #include <test/data/tx_valid.json.h>
7 : : #include <test/util/setup_common.h>
8 : :
9 : : #include <checkqueue.h>
10 : : #include <clientversion.h>
11 : : #include <consensus/amount.h>
12 : : #include <consensus/tx_check.h>
13 : : #include <consensus/validation.h>
14 : : #include <core_io.h>
15 : : #include <key.h>
16 : : #include <policy/policy.h>
17 : : #include <policy/settings.h>
18 : : #include <script/script.h>
19 : : #include <script/script_error.h>
20 : : #include <script/sigcache.h>
21 : : #include <script/sign.h>
22 : : #include <script/signingprovider.h>
23 : : #include <script/solver.h>
24 : : #include <streams.h>
25 : : #include <test/util/json.h>
26 : : #include <test/util/random.h>
27 : : #include <test/util/script.h>
28 : : #include <test/util/transaction_utils.h>
29 : : #include <util/strencodings.h>
30 : : #include <util/string.h>
31 : : #include <util/transaction_identifier.h>
32 : : #include <validation.h>
33 : :
34 : : #include <functional>
35 : : #include <map>
36 : : #include <string>
37 : :
38 : : #include <boost/test/unit_test.hpp>
39 : :
40 : : #include <univalue.h>
41 : :
42 : : using util::SplitString;
43 : : using util::ToString;
44 : :
45 : : typedef std::vector<unsigned char> valtype;
46 : :
47 : : static CFeeRate g_dust{DUST_RELAY_TX_FEE};
48 : : static bool g_bare_multi{DEFAULT_PERMIT_BAREMULTISIG};
49 : :
50 : : static std::map<std::string, unsigned int> mapFlagNames = {
51 : : {std::string("P2SH"), (unsigned int)SCRIPT_VERIFY_P2SH},
52 : : {std::string("STRICTENC"), (unsigned int)SCRIPT_VERIFY_STRICTENC},
53 : : {std::string("DERSIG"), (unsigned int)SCRIPT_VERIFY_DERSIG},
54 : : {std::string("LOW_S"), (unsigned int)SCRIPT_VERIFY_LOW_S},
55 : : {std::string("SIGPUSHONLY"), (unsigned int)SCRIPT_VERIFY_SIGPUSHONLY},
56 : : {std::string("MINIMALDATA"), (unsigned int)SCRIPT_VERIFY_MINIMALDATA},
57 : : {std::string("NULLDUMMY"), (unsigned int)SCRIPT_VERIFY_NULLDUMMY},
58 : : {std::string("DISCOURAGE_UPGRADABLE_NOPS"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS},
59 : : {std::string("CLEANSTACK"), (unsigned int)SCRIPT_VERIFY_CLEANSTACK},
60 : : {std::string("MINIMALIF"), (unsigned int)SCRIPT_VERIFY_MINIMALIF},
61 : : {std::string("NULLFAIL"), (unsigned int)SCRIPT_VERIFY_NULLFAIL},
62 : : {std::string("CHECKLOCKTIMEVERIFY"), (unsigned int)SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY},
63 : : {std::string("CHECKSEQUENCEVERIFY"), (unsigned int)SCRIPT_VERIFY_CHECKSEQUENCEVERIFY},
64 : : {std::string("WITNESS"), (unsigned int)SCRIPT_VERIFY_WITNESS},
65 : : {std::string("DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM},
66 : : {std::string("WITNESS_PUBKEYTYPE"), (unsigned int)SCRIPT_VERIFY_WITNESS_PUBKEYTYPE},
67 : : {std::string("CONST_SCRIPTCODE"), (unsigned int)SCRIPT_VERIFY_CONST_SCRIPTCODE},
68 : : {std::string("TAPROOT"), (unsigned int)SCRIPT_VERIFY_TAPROOT},
69 : : {std::string("DISCOURAGE_UPGRADABLE_PUBKEYTYPE"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_PUBKEYTYPE},
70 : : {std::string("DISCOURAGE_OP_SUCCESS"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_OP_SUCCESS},
71 : : {std::string("DISCOURAGE_UPGRADABLE_TAPROOT_VERSION"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_TAPROOT_VERSION},
72 : : };
73 : :
74 : 1411 : unsigned int ParseScriptFlags(std::string strFlags)
75 : : {
76 : 1411 : unsigned int flags = SCRIPT_VERIFY_NONE;
77 [ + + + + ]: 1411 : if (strFlags.empty() || strFlags == "NONE") return flags;
78 : :
79 : 1211 : std::vector<std::string> words = SplitString(strFlags, ',');
80 [ + + ]: 3454 : for (const std::string& word : words)
81 : : {
82 [ - + ]: 2243 : if (!mapFlagNames.count(word))
83 [ # # # # : 0 : BOOST_ERROR("Bad test: unknown verification flag '" << word << "'");
# # ]
84 [ + - ]: 2243 : flags |= mapFlagNames[word];
85 : : }
86 : 1211 : return flags;
87 : 1211 : }
88 : :
89 : : // Check that all flags in STANDARD_SCRIPT_VERIFY_FLAGS are present in mapFlagNames.
90 : 1 : bool CheckMapFlagNames()
91 : : {
92 : 1 : unsigned int standard_flags_missing{STANDARD_SCRIPT_VERIFY_FLAGS};
93 [ + + ]: 22 : for (const auto& pair : mapFlagNames) {
94 : 21 : standard_flags_missing &= ~(pair.second);
95 : : }
96 : 1 : return standard_flags_missing == 0;
97 : : }
98 : :
99 : 134 : std::string FormatScriptFlags(unsigned int flags)
100 : : {
101 [ + + ]: 134 : if (flags == SCRIPT_VERIFY_NONE) {
102 : 39 : return "";
103 : : }
104 : 95 : std::string ret;
105 : 95 : std::map<std::string, unsigned int>::const_iterator it = mapFlagNames.begin();
106 [ + + ]: 2090 : while (it != mapFlagNames.end()) {
107 [ + + ]: 1995 : if (flags & it->second) {
108 [ + - ]: 334 : ret += it->first + ",";
109 : : }
110 : 1995 : it++;
111 : : }
112 [ + - ]: 95 : return ret.substr(0, ret.size() - 1);
113 : 95 : }
114 : :
115 : : /*
116 : : * Check that the input scripts of a transaction are valid/invalid as expected.
117 : : */
118 : 8962 : bool CheckTxScripts(const CTransaction& tx, const std::map<COutPoint, CScript>& map_prevout_scriptPubKeys,
119 : : const std::map<COutPoint, int64_t>& map_prevout_values, unsigned int flags,
120 : : const PrecomputedTransactionData& txdata, const std::string& strTest, bool expect_valid)
121 : : {
122 : 8962 : bool tx_valid = true;
123 [ + + ]: 8962 : ScriptError err = expect_valid ? SCRIPT_ERR_UNKNOWN_ERROR : SCRIPT_ERR_OK;
124 [ + + + + ]: 20623 : for (unsigned int i = 0; i < tx.vin.size() && tx_valid; ++i) {
125 : 11661 : const CTxIn input = tx.vin[i];
126 [ + - + + ]: 11661 : const CAmount amount = map_prevout_values.count(input.prevout) ? map_prevout_values.at(input.prevout) : 0;
127 : 11661 : try {
128 [ + - + - : 11661 : tx_valid = VerifyScript(input.scriptSig, map_prevout_scriptPubKeys.at(input.prevout),
+ + ]
129 [ + - ]: 11661 : &input.scriptWitness, flags, TransactionSignatureChecker(&tx, i, amount, txdata, MissingDataBehavior::ASSERT_FAIL), &err);
130 : 0 : } catch (...) {
131 [ - - - - : 0 : BOOST_ERROR("Bad test: " << strTest);
- - ]
132 : 0 : return true; // The test format is bad and an error is thrown. Return true to silence further error.
133 [ - - ]: 0 : }
134 [ + + ]: 11661 : if (expect_valid) {
135 [ + - + - : 15280 : BOOST_CHECK_MESSAGE(tx_valid, strTest);
+ - ]
136 [ + - + - : 15280 : BOOST_CHECK_MESSAGE((err == SCRIPT_ERR_OK), ScriptErrorString(err));
+ - ]
137 : 7640 : err = SCRIPT_ERR_UNKNOWN_ERROR;
138 : : }
139 : 11661 : }
140 [ + + ]: 8962 : if (!expect_valid) {
141 [ + - ]: 7426 : BOOST_CHECK_MESSAGE(!tx_valid, strTest);
142 [ + - ]: 7426 : BOOST_CHECK_MESSAGE((err != SCRIPT_ERR_OK), ScriptErrorString(err));
143 : : }
144 : 8962 : return (tx_valid == expect_valid);
145 : : }
146 : :
147 : : /*
148 : : * Trim or fill flags to make the combination valid:
149 : : * WITNESS must be used with P2SH
150 : : * CLEANSTACK must be used WITNESS and P2SH
151 : : */
152 : :
153 : 9324 : unsigned int TrimFlags(unsigned int flags)
154 : : {
155 : : // WITNESS requires P2SH
156 [ + + ]: 9324 : if (!(flags & SCRIPT_VERIFY_P2SH)) flags &= ~(unsigned int)SCRIPT_VERIFY_WITNESS;
157 : :
158 : : // CLEANSTACK requires WITNESS (and transitively CLEANSTACK requires P2SH)
159 [ + + ]: 9324 : if (!(flags & SCRIPT_VERIFY_WITNESS)) flags &= ~(unsigned int)SCRIPT_VERIFY_CLEANSTACK;
160 : 9324 : Assert(IsValidFlagCombination(flags));
161 : 9324 : return flags;
162 : : }
163 : :
164 : 3732 : unsigned int FillFlags(unsigned int flags)
165 : : {
166 : : // CLEANSTACK implies WITNESS
167 [ + + ]: 3732 : if (flags & SCRIPT_VERIFY_CLEANSTACK) flags |= SCRIPT_VERIFY_WITNESS;
168 : :
169 : : // WITNESS implies P2SH (and transitively CLEANSTACK implies P2SH)
170 [ + + ]: 3732 : if (flags & SCRIPT_VERIFY_WITNESS) flags |= SCRIPT_VERIFY_P2SH;
171 : 3732 : Assert(IsValidFlagCombination(flags));
172 : 3732 : return flags;
173 : : }
174 : :
175 : : // Exclude each possible script verify flag from flags. Returns a set of these flag combinations
176 : : // that are valid and without duplicates. For example: if flags=1111 and the 4 possible flags are
177 : : // 0001, 0010, 0100, and 1000, this should return the set {0111, 1011, 1101, 1110}.
178 : : // Assumes that mapFlagNames contains all script verify flags.
179 : 204 : std::set<unsigned int> ExcludeIndividualFlags(unsigned int flags)
180 : : {
181 : 204 : std::set<unsigned int> flags_combos;
182 [ + + ]: 4488 : for (const auto& pair : mapFlagNames) {
183 [ + - ]: 4284 : const unsigned int flags_excluding_one = TrimFlags(flags & ~(pair.second));
184 [ + + ]: 4284 : if (flags != flags_excluding_one) {
185 [ + - ]: 611 : flags_combos.insert(flags_excluding_one);
186 : : }
187 : : }
188 : 204 : return flags_combos;
189 : 0 : }
190 : :
191 : : BOOST_FIXTURE_TEST_SUITE(transaction_tests, BasicTestingSetup)
192 : :
193 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_valid)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
194 : : {
195 [ + - ]: 2 : BOOST_CHECK_MESSAGE(CheckMapFlagNames(), "mapFlagNames is missing a script verification flag");
196 : : // Read tests from test/data/tx_valid.json
197 : 1 : UniValue tests = read_json(json_tests::tx_valid);
198 : :
199 [ + + ]: 248 : for (unsigned int idx = 0; idx < tests.size(); idx++) {
200 [ + - ]: 247 : const UniValue& test = tests[idx];
201 [ + - ]: 247 : std::string strTest = test.write();
202 [ + - + + ]: 247 : if (test[0].isArray())
203 : : {
204 [ + - + - : 120 : if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
+ - + - -
+ ]
205 : : {
206 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
207 : 0 : continue;
208 : : }
209 : :
210 [ + - ]: 120 : std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
211 : 120 : std::map<COutPoint, int64_t> mapprevOutValues;
212 [ + - + - : 120 : UniValue inputs = test[0].get_array();
+ - ]
213 : 295 : bool fValid = true;
214 [ + + ]: 295 : for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
215 [ + - ]: 175 : const UniValue& input = inputs[inpIdx];
216 [ + - ]: 175 : if (!input.isArray()) {
217 : : fValid = false;
218 : : break;
219 : : }
220 [ + - ]: 175 : const UniValue& vinput = input.get_array();
221 [ + - + - ]: 175 : if (vinput.size() < 3 || vinput.size() > 4)
222 : : {
223 : : fValid = false;
224 : : break;
225 : : }
226 [ + - + - : 350 : COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
+ - + - +
- + - ]
227 [ + - + - : 175 : mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
+ - + - ]
228 [ + + ]: 175 : if (vinput.size() >= 4)
229 : : {
230 [ + - + - : 81 : mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
+ - ]
231 : : }
232 : : }
233 [ - + ]: 120 : if (!fValid)
234 : : {
235 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
236 : 0 : continue;
237 : : }
238 : :
239 [ + - + - : 120 : std::string transaction = test[1].get_str();
+ - ]
240 [ + - + - ]: 120 : DataStream stream(ParseHex(transaction));
241 [ + - ]: 120 : CTransaction tx(deserialize, TX_WITH_WITNESS, stream);
242 : :
243 [ + - ]: 120 : TxValidationState state;
244 [ + - + - : 240 : BOOST_CHECK_MESSAGE(CheckTransaction(tx, state), strTest);
+ - + - ]
245 [ + - + - : 240 : BOOST_CHECK(state.IsValid());
+ - ]
246 : :
247 [ + - ]: 120 : PrecomputedTransactionData txdata(tx);
248 [ + - + - : 120 : unsigned int verify_flags = ParseScriptFlags(test[2].get_str());
+ - + - ]
249 : :
250 : : // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
251 [ + - - + ]: 120 : if (~verify_flags != FillFlags(~verify_flags)) {
252 [ # # # # ]: 0 : BOOST_ERROR("Bad test flags: " << strTest);
253 : : }
254 : :
255 [ + - + - : 240 : BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~verify_flags, txdata, strTest, /*expect_valid=*/true),
+ - ]
256 : : "Tx unexpectedly failed: " << strTest);
257 : :
258 : : // Backwards compatibility of script verification flags: Removing any flag(s) should not invalidate a valid transaction
259 [ + - + + ]: 2640 : for (const auto& [name, flag] : mapFlagNames) {
260 : : // Removing individual flags
261 [ + - ]: 2520 : unsigned int flags = TrimFlags(~(verify_flags | flag));
262 [ + - - + ]: 2520 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
263 [ # # # # ]: 0 : BOOST_ERROR("Tx unexpectedly failed with flag " << name << " unset: " << strTest);
264 : : }
265 : : // Removing random combinations of flags
266 [ + - ]: 2520 : flags = TrimFlags(~(verify_flags | (unsigned int)InsecureRandBits(mapFlagNames.size())));
267 [ + - - + ]: 2520 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
268 [ # # # # : 0 : BOOST_ERROR("Tx unexpectedly failed with random flags " << ToString(flags) << ": " << strTest);
# # ]
269 : : }
270 : : }
271 : :
272 : : // Check that flags are maximal: transaction should fail if any unset flags are set.
273 [ + - + + ]: 221 : for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
274 [ + - - + ]: 101 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~flags_excluding_one, txdata, strTest, /*expect_valid=*/false)) {
275 [ # # # # ]: 0 : BOOST_ERROR("Too many flags unset: " << strTest);
276 : : }
277 : 120 : }
278 : 360 : }
279 : 247 : }
280 : 1 : }
281 : :
282 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_invalid)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
283 : : {
284 : : // Read tests from test/data/tx_invalid.json
285 : 1 : UniValue tests = read_json(json_tests::tx_invalid);
286 : :
287 [ + + ]: 202 : for (unsigned int idx = 0; idx < tests.size(); idx++) {
288 [ + - ]: 201 : const UniValue& test = tests[idx];
289 [ + - ]: 201 : std::string strTest = test.write();
290 [ + - + + ]: 201 : if (test[0].isArray())
291 : : {
292 [ + - + - : 93 : if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
+ - + - -
+ ]
293 : : {
294 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
295 : 0 : continue;
296 : : }
297 : :
298 [ + - ]: 93 : std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
299 : 93 : std::map<COutPoint, int64_t> mapprevOutValues;
300 [ + - + - : 93 : UniValue inputs = test[0].get_array();
+ - ]
301 : 203 : bool fValid = true;
302 [ + + ]: 203 : for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
303 [ + - ]: 110 : const UniValue& input = inputs[inpIdx];
304 [ + - ]: 110 : if (!input.isArray()) {
305 : : fValid = false;
306 : : break;
307 : : }
308 [ + - ]: 110 : const UniValue& vinput = input.get_array();
309 [ + - + - ]: 110 : if (vinput.size() < 3 || vinput.size() > 4)
310 : : {
311 : : fValid = false;
312 : : break;
313 : : }
314 [ + - + - : 220 : COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
+ - + - +
- + - ]
315 [ + - + - : 110 : mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
+ - + - ]
316 [ + + ]: 110 : if (vinput.size() >= 4)
317 : : {
318 [ + - + - : 29 : mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
+ - ]
319 : : }
320 : : }
321 [ - + ]: 93 : if (!fValid)
322 : : {
323 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
324 : 0 : continue;
325 : : }
326 : :
327 [ + - + - : 93 : std::string transaction = test[1].get_str();
+ - ]
328 [ + - + - ]: 93 : DataStream stream(ParseHex(transaction));
329 [ + - ]: 93 : CTransaction tx(deserialize, TX_WITH_WITNESS, stream);
330 : :
331 [ + - ]: 93 : TxValidationState state;
332 [ + - + + : 93 : if (!CheckTransaction(tx, state) || state.IsInvalid()) {
+ - ]
333 [ + - + - : 18 : BOOST_CHECK_MESSAGE(test[2].get_str() == "BADTX", strTest);
+ - + - ]
334 : 9 : continue;
335 : : }
336 : :
337 [ + - ]: 84 : PrecomputedTransactionData txdata(tx);
338 [ + - + - : 84 : unsigned int verify_flags = ParseScriptFlags(test[2].get_str());
+ - + - ]
339 : :
340 : : // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
341 [ + - - + ]: 84 : if (verify_flags != FillFlags(verify_flags)) {
342 [ # # # # ]: 0 : BOOST_ERROR("Bad test flags: " << strTest);
343 : : }
344 : :
345 : : // Not using FillFlags() in the main test, in order to detect invalid verifyFlags combination
346 [ + - + - : 168 : BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, verify_flags, txdata, strTest, /*expect_valid=*/false),
+ - ]
347 : : "Tx unexpectedly passed: " << strTest);
348 : :
349 : : // Backwards compatibility of script verification flags: Adding any flag(s) should not validate an invalid transaction
350 [ + - + + ]: 1848 : for (const auto& [name, flag] : mapFlagNames) {
351 [ + - ]: 1764 : unsigned int flags = FillFlags(verify_flags | flag);
352 : : // Adding individual flags
353 [ + - - + ]: 1764 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
354 [ # # # # ]: 0 : BOOST_ERROR("Tx unexpectedly passed with flag " << name << " set: " << strTest);
355 : : }
356 : : // Adding random combinations of flags
357 [ + - ]: 1764 : flags = FillFlags(verify_flags | (unsigned int)InsecureRandBits(mapFlagNames.size()));
358 [ + - - + ]: 1764 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
359 [ # # # # ]: 0 : BOOST_ERROR("Tx unexpectedly passed with random flags " << name << ": " << strTest);
360 : : }
361 : : }
362 : :
363 : : // Check that flags are minimal: transaction should succeed if any set flags are unset.
364 [ + - + + ]: 173 : for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
365 [ + - - + ]: 89 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags_excluding_one, txdata, strTest, /*expect_valid=*/true)) {
366 [ # # # # ]: 0 : BOOST_ERROR("Too many flags set: " << strTest);
367 : : }
368 : 84 : }
369 : 270 : }
370 : 201 : }
371 : 1 : }
372 : :
373 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_no_inputs)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
374 : : {
375 : 1 : CMutableTransaction empty;
376 : :
377 [ + - ]: 1 : TxValidationState state;
378 [ + - + - : 3 : BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(empty), state), "Transaction with no inputs should be invalid.");
+ - + - +
- ]
379 [ + - + - : 2 : BOOST_CHECK(state.GetRejectReason() == "bad-txns-vin-empty");
+ - ]
380 : 2 : }
381 : :
382 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_oversized)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
383 : : {
384 : 4 : auto createTransaction =[](size_t payloadSize) {
385 : 3 : CMutableTransaction tx;
386 [ + - ]: 3 : tx.vin.resize(1);
387 [ + - + - : 6 : tx.vout.emplace_back(1, CScript() << OP_RETURN << std::vector<unsigned char>(payloadSize));
+ - ]
388 [ + - ]: 3 : return CTransaction(tx);
389 : 3 : };
390 : 1 : const auto maxTransactionSize = MAX_BLOCK_WEIGHT / WITNESS_SCALE_FACTOR;
391 : 1 : const auto oversizedTransactionBaseSize = ::GetSerializeSize(TX_NO_WITNESS(createTransaction(maxTransactionSize))) - maxTransactionSize;
392 : :
393 : 1 : auto maxPayloadSize = maxTransactionSize - oversizedTransactionBaseSize;
394 : 1 : {
395 [ + - ]: 1 : TxValidationState state;
396 [ + - + - ]: 1 : CheckTransaction(createTransaction(maxPayloadSize), state);
397 [ + - + - : 2 : BOOST_CHECK(state.GetRejectReason() != "bad-txns-oversize");
+ - ]
398 : 0 : }
399 : :
400 : 1 : maxPayloadSize += 1;
401 : 1 : {
402 [ + - ]: 1 : TxValidationState state;
403 [ + - + - : 3 : BOOST_CHECK_MESSAGE(!CheckTransaction(createTransaction(maxPayloadSize), state), "Oversized transaction should be invalid");
+ - + - +
- ]
404 [ + - + - : 2 : BOOST_CHECK(state.GetRejectReason() == "bad-txns-oversize");
+ - ]
405 : 1 : }
406 : 1 : }
407 : :
408 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(basic_transaction_tests)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
409 : : {
410 : : // Random real transaction (e2769b09e784f32f62ef849763d4f45b98e07ba658647343b915ff832b110436)
411 : 1 : unsigned char ch[] = {0x01, 0x00, 0x00, 0x00, 0x01, 0x6b, 0xff, 0x7f, 0xcd, 0x4f, 0x85, 0x65, 0xef, 0x40, 0x6d, 0xd5, 0xd6, 0x3d, 0x4f, 0xf9, 0x4f, 0x31, 0x8f, 0xe8, 0x20, 0x27, 0xfd, 0x4d, 0xc4, 0x51, 0xb0, 0x44, 0x74, 0x01, 0x9f, 0x74, 0xb4, 0x00, 0x00, 0x00, 0x00, 0x8c, 0x49, 0x30, 0x46, 0x02, 0x21, 0x00, 0xda, 0x0d, 0xc6, 0xae, 0xce, 0xfe, 0x1e, 0x06, 0xef, 0xdf, 0x05, 0x77, 0x37, 0x57, 0xde, 0xb1, 0x68, 0x82, 0x09, 0x30, 0xe3, 0xb0, 0xd0, 0x3f, 0x46, 0xf5, 0xfc, 0xf1, 0x50, 0xbf, 0x99, 0x0c, 0x02, 0x21, 0x00, 0xd2, 0x5b, 0x5c, 0x87, 0x04, 0x00, 0x76, 0xe4, 0xf2, 0x53, 0xf8, 0x26, 0x2e, 0x76, 0x3e, 0x2d, 0xd5, 0x1e, 0x7f, 0xf0, 0xbe, 0x15, 0x77, 0x27, 0xc4, 0xbc, 0x42, 0x80, 0x7f, 0x17, 0xbd, 0x39, 0x01, 0x41, 0x04, 0xe6, 0xc2, 0x6e, 0xf6, 0x7d, 0xc6, 0x10, 0xd2, 0xcd, 0x19, 0x24, 0x84, 0x78, 0x9a, 0x6c, 0xf9, 0xae, 0xa9, 0x93, 0x0b, 0x94, 0x4b, 0x7e, 0x2d, 0xb5, 0x34, 0x2b, 0x9d, 0x9e, 0x5b, 0x9f, 0xf7, 0x9a, 0xff, 0x9a, 0x2e, 0xe1, 0x97, 0x8d, 0xd7, 0xfd, 0x01, 0xdf, 0xc5, 0x22, 0xee, 0x02, 0x28, 0x3d, 0x3b, 0x06, 0xa9, 0xd0, 0x3a, 0xcf, 0x80, 0x96, 0x96, 0x8d, 0x7d, 0xbb, 0x0f, 0x91, 0x78, 0xff, 0xff, 0xff, 0xff, 0x02, 0x8b, 0xa7, 0x94, 0x0e, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xba, 0xde, 0xec, 0xfd, 0xef, 0x05, 0x07, 0x24, 0x7f, 0xc8, 0xf7, 0x42, 0x41, 0xd7, 0x3b, 0xc0, 0x39, 0x97, 0x2d, 0x7b, 0x88, 0xac, 0x40, 0x94, 0xa8, 0x02, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xc1, 0x09, 0x32, 0x48, 0x3f, 0xec, 0x93, 0xed, 0x51, 0xf5, 0xfe, 0x95, 0xe7, 0x25, 0x59, 0xf2, 0xcc, 0x70, 0x43, 0xf9, 0x88, 0xac, 0x00, 0x00, 0x00, 0x00, 0x00};
412 : 1 : std::vector<unsigned char> vch(ch, ch + sizeof(ch) -1);
413 [ + - ]: 1 : DataStream stream(vch);
414 [ + - ]: 1 : CMutableTransaction tx;
415 [ + - ]: 1 : stream >> TX_WITH_WITNESS(tx);
416 [ + - ]: 1 : TxValidationState state;
417 [ + - + - : 3 : BOOST_CHECK_MESSAGE(CheckTransaction(CTransaction(tx), state) && state.IsValid(), "Simple deserialized transaction should be valid.");
+ - + - -
+ + - +
- ]
418 : :
419 : : // Check that duplicate txins fail
420 [ + - ]: 1 : tx.vin.push_back(tx.vin[0]);
421 [ + - + - : 3 : BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(tx), state) || !state.IsValid(), "Transaction with duplicate txins should be invalid.");
+ - - + -
- + - ]
422 : 2 : }
423 : :
424 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_Get)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
425 : : {
426 : 1 : FillableSigningProvider keystore;
427 : 1 : CCoinsView coinsDummy;
428 [ + - ]: 1 : CCoinsViewCache coins(&coinsDummy);
429 : 1 : std::vector<CMutableTransaction> dummyTransactions =
430 [ + - ]: 1 : SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
431 : :
432 [ + - ]: 1 : CMutableTransaction t1;
433 [ + - ]: 1 : t1.vin.resize(3);
434 [ + - ]: 1 : t1.vin[0].prevout.hash = dummyTransactions[0].GetHash();
435 : 1 : t1.vin[0].prevout.n = 1;
436 [ + - + - ]: 1 : t1.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
437 [ + - ]: 1 : t1.vin[1].prevout.hash = dummyTransactions[1].GetHash();
438 : 1 : t1.vin[1].prevout.n = 0;
439 [ + - + - : 1 : t1.vin[1].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
+ - ]
440 [ + - ]: 1 : t1.vin[2].prevout.hash = dummyTransactions[1].GetHash();
441 : 1 : t1.vin[2].prevout.n = 1;
442 [ + - + - : 1 : t1.vin[2].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
+ - ]
443 [ + - ]: 1 : t1.vout.resize(2);
444 [ + - ]: 1 : t1.vout[0].nValue = 90*CENT;
445 [ + - ]: 1 : t1.vout[0].scriptPubKey << OP_1;
446 : :
447 [ + - + - : 3 : BOOST_CHECK(AreInputsStandard(CTransaction(t1), coins));
+ - + - ]
448 : 1 : }
449 : :
450 : 24 : static void CreateCreditAndSpend(const FillableSigningProvider& keystore, const CScript& outscript, CTransactionRef& output, CMutableTransaction& input, bool success = true)
451 : : {
452 : 24 : CMutableTransaction outputm;
453 : 24 : outputm.version = 1;
454 [ + - ]: 24 : outputm.vin.resize(1);
455 : 24 : outputm.vin[0].prevout.SetNull();
456 : 24 : outputm.vin[0].scriptSig = CScript();
457 [ + - ]: 24 : outputm.vout.resize(1);
458 : 24 : outputm.vout[0].nValue = 1;
459 : 24 : outputm.vout[0].scriptPubKey = outscript;
460 : 24 : DataStream ssout;
461 [ + - ]: 24 : ssout << TX_WITH_WITNESS(outputm);
462 [ + - ]: 24 : ssout >> TX_WITH_WITNESS(output);
463 [ - + ]: 24 : assert(output->vin.size() == 1);
464 [ - + ]: 24 : assert(output->vin[0] == outputm.vin[0]);
465 [ - + ]: 24 : assert(output->vout.size() == 1);
466 [ - + ]: 24 : assert(output->vout[0] == outputm.vout[0]);
467 : :
468 [ + - ]: 24 : CMutableTransaction inputm;
469 : 24 : inputm.version = 1;
470 [ + - ]: 24 : inputm.vin.resize(1);
471 [ + - ]: 24 : inputm.vin[0].prevout.hash = output->GetHash();
472 : 24 : inputm.vin[0].prevout.n = 0;
473 [ + - ]: 24 : inputm.vout.resize(1);
474 : 24 : inputm.vout[0].nValue = 1;
475 : 24 : inputm.vout[0].scriptPubKey = CScript();
476 : 24 : SignatureData empty;
477 [ + - ]: 24 : bool ret = SignSignature(keystore, *output, inputm, 0, SIGHASH_ALL, empty);
478 [ - + ]: 24 : assert(ret == success);
479 : 24 : DataStream ssin;
480 [ + - ]: 24 : ssin << TX_WITH_WITNESS(inputm);
481 [ + - ]: 24 : ssin >> TX_WITH_WITNESS(input);
482 [ - + ]: 24 : assert(input.vin.size() == 1);
483 [ - + ]: 24 : assert(input.vin[0] == inputm.vin[0]);
484 [ - + ]: 24 : assert(input.vout.size() == 1);
485 [ - + ]: 24 : assert(input.vout[0] == inputm.vout[0]);
486 [ - + ]: 24 : assert(input.vin[0].scriptWitness.stack == inputm.vin[0].scriptWitness.stack);
487 : 72 : }
488 : :
489 : 69 : static void CheckWithFlag(const CTransactionRef& output, const CMutableTransaction& input, uint32_t flags, bool success)
490 : : {
491 : 69 : ScriptError error;
492 : 69 : CTransaction inputi(input);
493 [ + - - + ]: 69 : bool ret = VerifyScript(inputi.vin[0].scriptSig, output->vout[0].scriptPubKey, &inputi.vin[0].scriptWitness, flags, TransactionSignatureChecker(&inputi, 0, output->vout[0].nValue, MissingDataBehavior::ASSERT_FAIL), &error);
494 [ - + ]: 69 : assert(ret == success);
495 : 69 : }
496 : :
497 : 3 : static CScript PushAll(const std::vector<valtype>& values)
498 : : {
499 : 3 : CScript result;
500 [ + + ]: 8 : for (const valtype& v : values) {
501 [ - + ]: 5 : if (v.size() == 0) {
502 [ # # ]: 0 : result << OP_0;
503 [ - + - - : 5 : } else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {
- - ]
504 [ # # ]: 0 : result << CScript::EncodeOP_N(v[0]);
505 [ - + - - ]: 5 : } else if (v.size() == 1 && v[0] == 0x81) {
506 [ # # ]: 0 : result << OP_1NEGATE;
507 : : } else {
508 : 5 : result << v;
509 : : }
510 : : }
511 : 3 : return result;
512 : 0 : }
513 : :
514 : 3 : static void ReplaceRedeemScript(CScript& script, const CScript& redeemScript)
515 : : {
516 : 3 : std::vector<valtype> stack;
517 [ + - ]: 3 : EvalScript(stack, script, SCRIPT_VERIFY_STRICTENC, BaseSignatureChecker(), SigVersion::BASE);
518 [ - + ]: 3 : assert(stack.size() > 0);
519 [ + + + - : 6 : stack.back() = std::vector<unsigned char>(redeemScript.begin(), redeemScript.end());
+ - ]
520 [ + - ]: 6 : script = PushAll(stack);
521 : 3 : }
522 : :
523 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_big_witness_transaction)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
524 : : {
525 : 1 : CMutableTransaction mtx;
526 : 1 : mtx.version = 1;
527 : :
528 : 1 : CKey key = GenerateRandomKey(); // Need to use compressed keys in segwit or the signing will fail
529 : 1 : FillableSigningProvider keystore;
530 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key, key.GetPubKey()));
+ - + - +
- ]
531 [ + - + - ]: 1 : CKeyID hash = key.GetPubKey().GetID();
532 [ + - + - ]: 1 : CScript scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(hash.begin(), hash.end());
533 : :
534 : 1 : std::vector<int> sigHashes;
535 [ + - ]: 1 : sigHashes.push_back(SIGHASH_NONE | SIGHASH_ANYONECANPAY);
536 [ + - ]: 1 : sigHashes.push_back(SIGHASH_SINGLE | SIGHASH_ANYONECANPAY);
537 [ + - ]: 1 : sigHashes.push_back(SIGHASH_ALL | SIGHASH_ANYONECANPAY);
538 [ + - ]: 1 : sigHashes.push_back(SIGHASH_NONE);
539 [ + - ]: 1 : sigHashes.push_back(SIGHASH_SINGLE);
540 [ + - ]: 1 : sigHashes.push_back(SIGHASH_ALL);
541 : :
542 : : // create a big transaction of 4500 inputs signed by the same key
543 [ + + ]: 4501 : for(uint32_t ij = 0; ij < 4500; ij++) {
544 [ + - ]: 4500 : uint32_t i = mtx.vin.size();
545 [ + - + - ]: 9000 : COutPoint outpoint(Txid::FromHex("0000000000000000000000000000000000000000000000000000000000000100").value(), i);
546 : :
547 [ + - ]: 4500 : mtx.vin.resize(mtx.vin.size() + 1);
548 : 4500 : mtx.vin[i].prevout = outpoint;
549 : 4500 : mtx.vin[i].scriptSig = CScript();
550 : :
551 [ + - ]: 4500 : mtx.vout.resize(mtx.vout.size() + 1);
552 [ + - ]: 4500 : mtx.vout[i].nValue = 1000;
553 [ + - ]: 4500 : mtx.vout[i].scriptPubKey = CScript() << OP_1;
554 : : }
555 : :
556 : : // sign all inputs
557 [ + + ]: 4501 : for(uint32_t i = 0; i < mtx.vin.size(); i++) {
558 : 4500 : SignatureData empty;
559 [ + - + - ]: 4500 : bool hashSigned = SignSignature(keystore, scriptPubKey, mtx, i, 1000, sigHashes.at(i % sigHashes.size()), empty);
560 [ - + ]: 4500 : assert(hashSigned);
561 : 4500 : }
562 : :
563 : 1 : DataStream ssout;
564 [ + - ]: 1 : ssout << TX_WITH_WITNESS(mtx);
565 [ + - ]: 1 : CTransaction tx(deserialize, TX_WITH_WITNESS, ssout);
566 : :
567 : : // check all inputs concurrently, with the cache
568 [ + - ]: 1 : PrecomputedTransactionData txdata(tx);
569 [ + - ]: 1 : CCheckQueue<CScriptCheck> scriptcheckqueue(/*batch_size=*/128, /*worker_threads_num=*/20);
570 [ + - ]: 1 : CCheckQueueControl<CScriptCheck> control(&scriptcheckqueue);
571 : :
572 : 1 : std::vector<Coin> coins;
573 [ + + ]: 4501 : for(uint32_t i = 0; i < mtx.vin.size(); i++) {
574 : 4500 : Coin coin;
575 : 4500 : coin.nHeight = 1;
576 : 4500 : coin.fCoinBase = false;
577 : 4500 : coin.out.nValue = 1000;
578 : 4500 : coin.out.scriptPubKey = scriptPubKey;
579 [ + - ]: 4500 : coins.emplace_back(std::move(coin));
580 : 4500 : }
581 : :
582 [ + - ]: 1 : SignatureCache signature_cache{DEFAULT_SIGNATURE_CACHE_BYTES};
583 : :
584 [ + + ]: 4501 : for(uint32_t i = 0; i < mtx.vin.size(); i++) {
585 : 4500 : std::vector<CScriptCheck> vChecks;
586 [ + - ]: 4500 : vChecks.emplace_back(coins[tx.vin[i].prevout.n].out, tx, signature_cache, i, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false, &txdata);
587 [ + - ]: 4500 : control.Add(std::move(vChecks));
588 : 4500 : }
589 : :
590 [ + - ]: 1 : bool controlCheck = control.Wait();
591 [ - + ]: 1 : assert(controlCheck);
592 : 3 : }
593 : :
594 : 4 : SignatureData CombineSignatures(const CMutableTransaction& input1, const CMutableTransaction& input2, const CTransactionRef tx)
595 : : {
596 : 4 : SignatureData sigdata;
597 [ + - ]: 4 : sigdata = DataFromTransaction(input1, 0, tx->vout[0]);
598 [ + - + - ]: 4 : sigdata.MergeSignatureData(DataFromTransaction(input2, 0, tx->vout[0]));
599 [ + - + - ]: 4 : ProduceSignature(DUMMY_SIGNING_PROVIDER, MutableTransactionSignatureCreator(input1, 0, tx->vout[0].nValue, SIGHASH_ALL), tx->vout[0].scriptPubKey, sigdata);
600 : 4 : return sigdata;
601 : 0 : }
602 : :
603 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_witness)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
604 : : {
605 : 1 : FillableSigningProvider keystore, keystore2;
606 : 1 : CKey key1 = GenerateRandomKey();
607 : 1 : CKey key2 = GenerateRandomKey();
608 : 1 : CKey key3 = GenerateRandomKey();
609 : 1 : CKey key1L = GenerateRandomKey(/*compressed=*/false);
610 : 1 : CKey key2L = GenerateRandomKey(/*compressed=*/false);
611 [ + - ]: 1 : CPubKey pubkey1 = key1.GetPubKey();
612 [ + - ]: 1 : CPubKey pubkey2 = key2.GetPubKey();
613 [ + - ]: 1 : CPubKey pubkey3 = key3.GetPubKey();
614 [ + - ]: 1 : CPubKey pubkey1L = key1L.GetPubKey();
615 [ + - ]: 1 : CPubKey pubkey2L = key2L.GetPubKey();
616 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key1, pubkey1));
+ - + - ]
617 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key2, pubkey2));
+ - + - ]
618 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key1L, pubkey1L));
+ - + - ]
619 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key2L, pubkey2L));
+ - + - ]
620 : 1 : CScript scriptPubkey1, scriptPubkey2, scriptPubkey1L, scriptPubkey2L, scriptMulti;
621 [ + - + - ]: 1 : scriptPubkey1 << ToByteVector(pubkey1) << OP_CHECKSIG;
622 [ + - + - ]: 1 : scriptPubkey2 << ToByteVector(pubkey2) << OP_CHECKSIG;
623 [ + - + - ]: 1 : scriptPubkey1L << ToByteVector(pubkey1L) << OP_CHECKSIG;
624 [ + - + - ]: 1 : scriptPubkey2L << ToByteVector(pubkey2L) << OP_CHECKSIG;
625 : 1 : std::vector<CPubKey> oneandthree;
626 [ + - ]: 1 : oneandthree.push_back(pubkey1);
627 [ + - ]: 1 : oneandthree.push_back(pubkey3);
628 [ + - ]: 2 : scriptMulti = GetScriptForMultisig(2, oneandthree);
629 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey1));
+ - + - ]
630 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey2));
+ - + - ]
631 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey1L));
+ - + - ]
632 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey2L));
+ - + - ]
633 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptMulti));
+ - + - ]
634 : 1 : CScript destination_script_1, destination_script_2, destination_script_1L, destination_script_2L, destination_script_multi;
635 [ + - + - ]: 2 : destination_script_1 = GetScriptForDestination(WitnessV0KeyHash(pubkey1));
636 [ + - + - ]: 2 : destination_script_2 = GetScriptForDestination(WitnessV0KeyHash(pubkey2));
637 [ + - + - ]: 2 : destination_script_1L = GetScriptForDestination(WitnessV0KeyHash(pubkey1L));
638 [ + - + - ]: 2 : destination_script_2L = GetScriptForDestination(WitnessV0KeyHash(pubkey2L));
639 [ + - + - ]: 2 : destination_script_multi = GetScriptForDestination(WitnessV0ScriptHash(scriptMulti));
640 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_1));
+ - + - ]
641 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_2));
+ - + - ]
642 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_1L));
+ - + - ]
643 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_2L));
+ - + - ]
644 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_multi));
+ - + - ]
645 [ + - + - : 2 : BOOST_CHECK(keystore2.AddCScript(scriptMulti));
+ - + - ]
646 [ + - + - : 2 : BOOST_CHECK(keystore2.AddCScript(destination_script_multi));
+ - + - ]
647 [ + - + - : 2 : BOOST_CHECK(keystore2.AddKeyPubKey(key3, pubkey3));
+ - + - ]
648 : :
649 : 1 : CTransactionRef output1, output2;
650 [ + - + - ]: 1 : CMutableTransaction input1, input2;
651 : :
652 : : // Normal pay-to-compressed-pubkey.
653 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey1, output1, input1);
654 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey2, output2, input2);
655 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
656 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
657 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
658 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
659 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
660 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
661 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
662 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
663 : :
664 : : // P2SH pay-to-compressed-pubkey.
665 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1)), output1, input1);
+ - ]
666 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2)), output2, input2);
+ - ]
667 [ + - ]: 1 : ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1);
668 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
669 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
670 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
671 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
672 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
673 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
674 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
675 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
676 : :
677 : : // Witness pay-to-compressed-pubkey (v0).
678 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_1, output1, input1);
679 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_2, output2, input2);
680 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
681 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
682 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
683 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
684 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
685 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
686 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
687 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
688 : :
689 : : // P2SH witness pay-to-compressed-pubkey (v0).
690 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1)), output1, input1);
+ - ]
691 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2)), output2, input2);
+ - ]
692 [ + - ]: 1 : ReplaceRedeemScript(input2.vin[0].scriptSig, destination_script_1);
693 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
694 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
695 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
696 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
697 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
698 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
699 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
700 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
701 : :
702 : : // Normal pay-to-uncompressed-pubkey.
703 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey1L, output1, input1);
704 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey2L, output2, input2);
705 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
706 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
707 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
708 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
709 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
710 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
711 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
712 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
713 : :
714 : : // P2SH pay-to-uncompressed-pubkey.
715 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1L)), output1, input1);
+ - ]
716 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2L)), output2, input2);
+ - ]
717 [ + - ]: 1 : ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1L);
718 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
719 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
720 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
721 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
722 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
723 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
724 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
725 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
726 : :
727 : : // Signing disabled for witness pay-to-uncompressed-pubkey (v1).
728 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_1L, output1, input1, false);
729 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_2L, output2, input2, false);
730 : :
731 : : // Signing disabled for P2SH witness pay-to-uncompressed-pubkey (v1).
732 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1L)), output1, input1, false);
+ - ]
733 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2L)), output2, input2, false);
+ - ]
734 : :
735 : : // Normal 2-of-2 multisig
736 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptMulti, output1, input1, false);
737 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, false);
738 [ + - ]: 1 : CreateCreditAndSpend(keystore2, scriptMulti, output2, input2, false);
739 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, false);
740 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
741 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
742 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
743 : :
744 : : // P2SH 2-of-2 multisig
745 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptMulti)), output1, input1, false);
+ - ]
746 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
747 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, false);
748 [ + - + - : 2 : CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(scriptMulti)), output2, input2, false);
+ - ]
749 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
750 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, false);
751 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
752 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
753 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
754 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
755 : :
756 : : // Witness 2-of-2 multisig
757 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_multi, output1, input1, false);
758 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
759 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
760 [ + - ]: 1 : CreateCreditAndSpend(keystore2, destination_script_multi, output2, input2, false);
761 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
762 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
763 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
764 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
765 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, true);
766 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
767 : :
768 : : // P2SH witness 2-of-2 multisig
769 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_multi)), output1, input1, false);
+ - ]
770 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
771 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
772 [ + - + - : 2 : CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(destination_script_multi)), output2, input2, false);
+ - ]
773 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, true);
774 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
775 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
776 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
777 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, true);
778 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
779 [ + - + - ]: 4 : }
780 : :
781 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_IsStandard)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
782 : : {
783 : 1 : FillableSigningProvider keystore;
784 : 1 : CCoinsView coinsDummy;
785 [ + - ]: 1 : CCoinsViewCache coins(&coinsDummy);
786 : 1 : std::vector<CMutableTransaction> dummyTransactions =
787 [ + - ]: 1 : SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
788 : :
789 [ + - ]: 1 : CMutableTransaction t;
790 [ + - ]: 1 : t.vin.resize(1);
791 [ + - ]: 1 : t.vin[0].prevout.hash = dummyTransactions[0].GetHash();
792 : 1 : t.vin[0].prevout.n = 1;
793 [ + - + - ]: 1 : t.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
794 [ + - ]: 1 : t.vout.resize(1);
795 : 1 : t.vout[0].nValue = 90*CENT;
796 : 1 : CKey key = GenerateRandomKey();
797 [ + - + - : 1 : t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
+ - ]
798 : :
799 [ + - ]: 45 : constexpr auto CheckIsStandard = [](const auto& t) {
800 : 44 : std::string reason;
801 [ + - + - : 132 : BOOST_CHECK(IsStandardTx(CTransaction{t}, MAX_OP_RETURN_RELAY, g_bare_multi, g_dust, reason));
+ - + - +
- ]
802 [ + - + - ]: 88 : BOOST_CHECK(reason.empty());
803 : 44 : };
804 [ + - ]: 104 : constexpr auto CheckIsNotStandard = [](const auto& t, const std::string& reason_in) {
805 : 103 : std::string reason;
806 [ + - + - : 309 : BOOST_CHECK(!IsStandardTx(CTransaction{t}, MAX_OP_RETURN_RELAY, g_bare_multi, g_dust, reason));
+ - + - +
- ]
807 [ + - + - ]: 103 : BOOST_CHECK_EQUAL(reason_in, reason);
808 : 103 : };
809 : :
810 [ + - ]: 1 : CheckIsStandard(t);
811 : :
812 : : // Check dust with default relay fee:
813 [ + - ]: 1 : CAmount nDustThreshold = 182 * g_dust.GetFeePerK() / 1000;
814 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(nDustThreshold, 546);
815 : : // dust:
816 [ + - ]: 1 : t.vout[0].nValue = nDustThreshold - 1;
817 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
818 : : // not dust:
819 [ + - ]: 1 : t.vout[0].nValue = nDustThreshold;
820 [ + - ]: 1 : CheckIsStandard(t);
821 : :
822 : : // Disallowed version
823 : 1 : t.version = std::numeric_limits<uint32_t>::max();
824 [ + - + - ]: 1 : CheckIsNotStandard(t, "version");
825 : :
826 : 1 : t.version = 0;
827 [ + - + - ]: 1 : CheckIsNotStandard(t, "version");
828 : :
829 : 1 : t.version = TX_MAX_STANDARD_VERSION + 1;
830 [ + - + - ]: 1 : CheckIsNotStandard(t, "version");
831 : :
832 : : // Allowed version
833 : 1 : t.version = 1;
834 [ + - ]: 1 : CheckIsStandard(t);
835 : :
836 : 1 : t.version = 2;
837 [ + - ]: 1 : CheckIsStandard(t);
838 : :
839 : : // Check dust with odd relay fee to verify rounding:
840 : : // nDustThreshold = 182 * 3702 / 1000
841 [ + - ]: 1 : g_dust = CFeeRate(3702);
842 : : // dust:
843 [ + - ]: 1 : t.vout[0].nValue = 674 - 1;
844 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
845 : : // not dust:
846 [ + - ]: 1 : t.vout[0].nValue = 674;
847 [ + - ]: 1 : CheckIsStandard(t);
848 [ + - ]: 1 : g_dust = CFeeRate{DUST_RELAY_TX_FEE};
849 : :
850 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_1;
851 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptpubkey");
852 : :
853 : : // MAX_OP_RETURN_RELAY-byte TxoutType::NULL_DATA (standard)
854 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38");
855 [ + - + - : 2 : BOOST_CHECK_EQUAL(MAX_OP_RETURN_RELAY, t.vout[0].scriptPubKey.size());
+ - ]
856 [ + - ]: 1 : CheckIsStandard(t);
857 : :
858 : : // MAX_OP_RETURN_RELAY+1-byte TxoutType::NULL_DATA (non-standard)
859 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3800");
860 [ + - + - : 2 : BOOST_CHECK_EQUAL(MAX_OP_RETURN_RELAY + 1, t.vout[0].scriptPubKey.size());
+ - ]
861 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptpubkey");
862 : :
863 : : // Data payload can be encoded in any way...
864 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << ParseHex("");
865 [ + - ]: 1 : CheckIsStandard(t);
866 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << ParseHex("00") << ParseHex("01");
+ - ]
867 [ + - ]: 1 : CheckIsStandard(t);
868 : : // OP_RESERVED *is* considered to be a PUSHDATA type opcode by IsPushOnly()!
869 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RESERVED << -1 << 0 << ParseHex("01") << 2 << 3 << 4 << 5 << 6 << 7 << 8 << 9 << 10 << 11 << 12 << 13 << 14 << 15 << 16;
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
870 [ + - ]: 1 : CheckIsStandard(t);
871 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << 0 << ParseHex("01") << 2 << ParseHex("ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff");
+ - + - +
- ]
872 [ + - ]: 1 : CheckIsStandard(t);
873 : :
874 : : // ...so long as it only contains PUSHDATA's
875 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RETURN;
876 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptpubkey");
877 : :
878 : : // TxoutType::NULL_DATA w/o PUSHDATA
879 [ + - ]: 1 : t.vout.resize(1);
880 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN;
881 [ + - ]: 1 : CheckIsStandard(t);
882 : :
883 : : // Only one TxoutType::NULL_DATA permitted in all cases
884 [ + - ]: 1 : t.vout.resize(2);
885 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38");
886 [ + - ]: 1 : t.vout[0].nValue = 0;
887 [ + - + - ]: 1 : t.vout[1].scriptPubKey = CScript() << OP_RETURN << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38");
888 [ + - ]: 1 : t.vout[1].nValue = 0;
889 [ + - + - ]: 1 : CheckIsNotStandard(t, "multi-op-return");
890 : :
891 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38");
892 [ + - ]: 1 : t.vout[1].scriptPubKey = CScript() << OP_RETURN;
893 [ + - + - ]: 1 : CheckIsNotStandard(t, "multi-op-return");
894 : :
895 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN;
896 [ + - ]: 1 : t.vout[1].scriptPubKey = CScript() << OP_RETURN;
897 [ + - + - ]: 1 : CheckIsNotStandard(t, "multi-op-return");
898 : :
899 : : // Check large scriptSig (non-standard if size is >1650 bytes)
900 [ + - ]: 1 : t.vout.resize(1);
901 [ + - ]: 1 : t.vout[0].nValue = MAX_MONEY;
902 [ + - + - : 1 : t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
+ - ]
903 : : // OP_PUSHDATA2 with len (3 bytes) + data (1647 bytes) = 1650 bytes
904 [ + - ]: 1 : t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1647, 0); // 1650
905 [ + - ]: 1 : CheckIsStandard(t);
906 : :
907 [ + - ]: 1 : t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1648, 0); // 1651
908 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptsig-size");
909 : :
910 : : // Check scriptSig format (non-standard if there are any other ops than just PUSHs)
911 [ + - ]: 2 : t.vin[0].scriptSig = CScript()
912 [ + - + - : 1 : << OP_TRUE << OP_0 << OP_1NEGATE << OP_16 // OP_n (single byte pushes: n = 1, 0, -1, 16)
+ - + - +
- ]
913 [ + - + - ]: 2 : << std::vector<unsigned char>(75, 0) // OP_PUSHx [...x bytes...]
914 [ + - + - ]: 2 : << std::vector<unsigned char>(235, 0) // OP_PUSHDATA1 x [...x bytes...]
915 [ + - ]: 2 : << std::vector<unsigned char>(1234, 0) // OP_PUSHDATA2 x [...x bytes...]
916 [ + - ]: 1 : << OP_9;
917 [ + - ]: 1 : CheckIsStandard(t);
918 : :
919 : 1 : const std::vector<unsigned char> non_push_ops = { // arbitrary set of non-push operations
920 : : OP_NOP, OP_VERIFY, OP_IF, OP_ROT, OP_3DUP, OP_SIZE, OP_EQUAL, OP_ADD, OP_SUB,
921 [ + - ]: 1 : OP_HASH256, OP_CODESEPARATOR, OP_CHECKSIG, OP_CHECKLOCKTIMEVERIFY };
922 : :
923 [ - + ]: 2 : CScript::const_iterator pc = t.vin[0].scriptSig.begin();
924 [ + + ]: 9 : while (pc < t.vin[0].scriptSig.end()) {
925 : 8 : opcodetype opcode;
926 : 8 : CScript::const_iterator prev_pc = pc;
927 [ + - ]: 8 : t.vin[0].scriptSig.GetOp(pc, opcode); // advance to next op
928 : : // for the sake of simplicity, we only replace single-byte push operations
929 [ + + ]: 8 : if (opcode >= 1 && opcode <= OP_PUSHDATA4)
930 : 3 : continue;
931 : :
932 [ - + ]: 10 : int index = prev_pc - t.vin[0].scriptSig.begin();
933 : 5 : unsigned char orig_op = *prev_pc; // save op
934 : : // replace current push-op with each non-push-op
935 [ + + ]: 70 : for (auto op : non_push_ops) {
936 [ - + ]: 65 : t.vin[0].scriptSig[index] = op;
937 [ + - + - ]: 130 : CheckIsNotStandard(t, "scriptsig-not-pushonly");
938 : : }
939 [ - + ]: 5 : t.vin[0].scriptSig[index] = orig_op; // restore op
940 [ + - ]: 5 : CheckIsStandard(t);
941 : : }
942 : :
943 : : // Check tx-size (non-standard if transaction weight is > MAX_STANDARD_TX_WEIGHT)
944 : 1 : t.vin.clear();
945 [ + - ]: 1 : t.vin.resize(2438); // size per input (empty scriptSig): 41 bytes
946 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(19, 0); // output size: 30 bytes
947 : : // tx header: 12 bytes => 48 weight units
948 : : // 2438 inputs: 2438*41 = 99958 bytes => 399832 weight units
949 : : // 1 output: 30 bytes => 120 weight units
950 : : // ======================================
951 : : // total: 400000 weight units
952 [ + - + - : 1 : BOOST_CHECK_EQUAL(GetTransactionWeight(CTransaction(t)), 400000);
+ - ]
953 [ + - ]: 1 : CheckIsStandard(t);
954 : :
955 : : // increase output size by one byte, so we end up with 400004 weight units
956 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(20, 0); // output size: 31 bytes
957 [ + - + - : 1 : BOOST_CHECK_EQUAL(GetTransactionWeight(CTransaction(t)), 400004);
+ - ]
958 [ + - + - ]: 1 : CheckIsNotStandard(t, "tx-size");
959 : :
960 : : // Check bare multisig (standard if policy flag g_bare_multi is set)
961 : 1 : g_bare_multi = true;
962 [ + - + - : 1 : t.vout[0].scriptPubKey = GetScriptForMultisig(1, {key.GetPubKey()}); // simple 1-of-1
+ - + - ]
963 [ + - ]: 1 : t.vin.resize(1);
964 [ + - ]: 1 : t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(65, 0);
965 [ + - ]: 1 : CheckIsStandard(t);
966 : :
967 : 1 : g_bare_multi = false;
968 [ + - + - ]: 1 : CheckIsNotStandard(t, "bare-multisig");
969 : 1 : g_bare_multi = DEFAULT_PERMIT_BAREMULTISIG;
970 : :
971 : : // Check compressed P2PK outputs dust threshold (must have leading 02 or 03)
972 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(33, 0x02) << OP_CHECKSIG;
973 [ + - ]: 1 : t.vout[0].nValue = 576;
974 [ + - ]: 1 : CheckIsStandard(t);
975 [ + - ]: 1 : t.vout[0].nValue = 575;
976 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
977 : :
978 : : // Check uncompressed P2PK outputs dust threshold (must have leading 04/06/07)
979 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(65, 0x04) << OP_CHECKSIG;
980 [ + - ]: 1 : t.vout[0].nValue = 672;
981 [ + - ]: 1 : CheckIsStandard(t);
982 [ + - ]: 1 : t.vout[0].nValue = 671;
983 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
984 : :
985 : : // Check P2PKH outputs dust threshold
986 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_DUP << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUALVERIFY << OP_CHECKSIG;
+ - + - +
- ]
987 [ + - ]: 1 : t.vout[0].nValue = 546;
988 [ + - ]: 1 : CheckIsStandard(t);
989 [ + - ]: 1 : t.vout[0].nValue = 545;
990 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
991 : :
992 : : // Check P2SH outputs dust threshold
993 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUAL;
+ - ]
994 [ + - ]: 1 : t.vout[0].nValue = 540;
995 [ + - ]: 1 : CheckIsStandard(t);
996 [ + - ]: 1 : t.vout[0].nValue = 539;
997 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
998 : :
999 : : // Check P2WPKH outputs dust threshold
1000 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(20, 0);
1001 [ + - ]: 1 : t.vout[0].nValue = 294;
1002 [ + - ]: 1 : CheckIsStandard(t);
1003 [ + - ]: 1 : t.vout[0].nValue = 293;
1004 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
1005 : :
1006 : : // Check P2WSH outputs dust threshold
1007 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(32, 0);
1008 [ + - ]: 1 : t.vout[0].nValue = 330;
1009 [ + - ]: 1 : CheckIsStandard(t);
1010 [ + - ]: 1 : t.vout[0].nValue = 329;
1011 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
1012 : :
1013 : : // Check P2TR outputs dust threshold (Invalid xonly key ok!)
1014 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_1 << std::vector<unsigned char>(32, 0);
1015 [ + - ]: 1 : t.vout[0].nValue = 330;
1016 [ + - ]: 1 : CheckIsStandard(t);
1017 [ + - ]: 1 : t.vout[0].nValue = 329;
1018 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
1019 : :
1020 : : // Check future Witness Program versions dust threshold (non-32-byte pushes are undefined for version 1)
1021 [ + + ]: 17 : for (int op = OP_1; op <= OP_16; op += 1) {
1022 [ + - + - ]: 16 : t.vout[0].scriptPubKey = CScript() << (opcodetype)op << std::vector<unsigned char>(2, 0);
1023 [ + - ]: 16 : t.vout[0].nValue = 240;
1024 [ + - ]: 16 : CheckIsStandard(t);
1025 : :
1026 [ + - ]: 16 : t.vout[0].nValue = 239;
1027 [ + - + - ]: 32 : CheckIsNotStandard(t, "dust");
1028 : : }
1029 : :
1030 : : // Check anchor outputs
1031 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_1 << std::vector<unsigned char>{0x4e, 0x73};
1032 [ + - + - : 2 : BOOST_CHECK(t.vout[0].scriptPubKey.IsPayToAnchor());
+ - + - ]
1033 [ + - ]: 1 : t.vout[0].nValue = 240;
1034 [ + - ]: 1 : CheckIsStandard(t);
1035 [ + - ]: 1 : t.vout[0].nValue = 239;
1036 [ + - + - ]: 2 : CheckIsNotStandard(t, "dust");
1037 : 2 : }
1038 : :
1039 : : BOOST_AUTO_TEST_SUITE_END()
|