Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <test/data/tx_invalid.json.h>
6 : : #include <test/data/tx_valid.json.h>
7 : : #include <test/util/setup_common.h>
8 : :
9 : : #include <checkqueue.h>
10 : : #include <clientversion.h>
11 : : #include <consensus/amount.h>
12 : : #include <consensus/tx_check.h>
13 : : #include <consensus/validation.h>
14 : : #include <core_io.h>
15 : : #include <key.h>
16 : : #include <policy/policy.h>
17 : : #include <policy/settings.h>
18 : : #include <script/script.h>
19 : : #include <script/script_error.h>
20 : : #include <script/sigcache.h>
21 : : #include <script/sign.h>
22 : : #include <script/signingprovider.h>
23 : : #include <script/solver.h>
24 : : #include <streams.h>
25 : : #include <test/util/json.h>
26 : : #include <test/util/random.h>
27 : : #include <test/util/script.h>
28 : : #include <test/util/transaction_utils.h>
29 : : #include <util/strencodings.h>
30 : : #include <util/string.h>
31 : : #include <util/transaction_identifier.h>
32 : : #include <validation.h>
33 : :
34 : : #include <functional>
35 : : #include <map>
36 : : #include <string>
37 : :
38 : : #include <boost/test/unit_test.hpp>
39 : :
40 : : #include <univalue.h>
41 : :
42 : : using namespace util::hex_literals;
43 : : using util::SplitString;
44 : : using util::ToString;
45 : :
46 : : typedef std::vector<unsigned char> valtype;
47 : :
48 : : static CFeeRate g_dust{DUST_RELAY_TX_FEE};
49 : : static bool g_bare_multi{DEFAULT_PERMIT_BAREMULTISIG};
50 : :
51 : : static std::map<std::string, unsigned int> mapFlagNames = {
52 : : {std::string("P2SH"), (unsigned int)SCRIPT_VERIFY_P2SH},
53 : : {std::string("STRICTENC"), (unsigned int)SCRIPT_VERIFY_STRICTENC},
54 : : {std::string("DERSIG"), (unsigned int)SCRIPT_VERIFY_DERSIG},
55 : : {std::string("LOW_S"), (unsigned int)SCRIPT_VERIFY_LOW_S},
56 : : {std::string("SIGPUSHONLY"), (unsigned int)SCRIPT_VERIFY_SIGPUSHONLY},
57 : : {std::string("MINIMALDATA"), (unsigned int)SCRIPT_VERIFY_MINIMALDATA},
58 : : {std::string("NULLDUMMY"), (unsigned int)SCRIPT_VERIFY_NULLDUMMY},
59 : : {std::string("DISCOURAGE_UPGRADABLE_NOPS"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS},
60 : : {std::string("CLEANSTACK"), (unsigned int)SCRIPT_VERIFY_CLEANSTACK},
61 : : {std::string("MINIMALIF"), (unsigned int)SCRIPT_VERIFY_MINIMALIF},
62 : : {std::string("NULLFAIL"), (unsigned int)SCRIPT_VERIFY_NULLFAIL},
63 : : {std::string("CHECKLOCKTIMEVERIFY"), (unsigned int)SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY},
64 : : {std::string("CHECKSEQUENCEVERIFY"), (unsigned int)SCRIPT_VERIFY_CHECKSEQUENCEVERIFY},
65 : : {std::string("WITNESS"), (unsigned int)SCRIPT_VERIFY_WITNESS},
66 : : {std::string("DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM},
67 : : {std::string("WITNESS_PUBKEYTYPE"), (unsigned int)SCRIPT_VERIFY_WITNESS_PUBKEYTYPE},
68 : : {std::string("CONST_SCRIPTCODE"), (unsigned int)SCRIPT_VERIFY_CONST_SCRIPTCODE},
69 : : {std::string("TAPROOT"), (unsigned int)SCRIPT_VERIFY_TAPROOT},
70 : : {std::string("DISCOURAGE_UPGRADABLE_PUBKEYTYPE"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_PUBKEYTYPE},
71 : : {std::string("DISCOURAGE_OP_SUCCESS"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_OP_SUCCESS},
72 : : {std::string("DISCOURAGE_UPGRADABLE_TAPROOT_VERSION"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_TAPROOT_VERSION},
73 : : };
74 : :
75 : 1411 : unsigned int ParseScriptFlags(std::string strFlags)
76 : : {
77 : 1411 : unsigned int flags = SCRIPT_VERIFY_NONE;
78 [ + + + + ]: 1411 : if (strFlags.empty() || strFlags == "NONE") return flags;
79 : :
80 : 1211 : std::vector<std::string> words = SplitString(strFlags, ',');
81 [ + + ]: 3454 : for (const std::string& word : words)
82 : : {
83 [ - + ]: 2243 : if (!mapFlagNames.count(word))
84 [ # # # # ]: 0 : BOOST_ERROR("Bad test: unknown verification flag '" << word << "'");
85 [ + - ]: 2243 : flags |= mapFlagNames[word];
86 : : }
87 : 1211 : return flags;
88 : 1211 : }
89 : :
90 : : // Check that all flags in STANDARD_SCRIPT_VERIFY_FLAGS are present in mapFlagNames.
91 : 1 : bool CheckMapFlagNames()
92 : : {
93 : 1 : unsigned int standard_flags_missing{STANDARD_SCRIPT_VERIFY_FLAGS};
94 [ + + ]: 22 : for (const auto& pair : mapFlagNames) {
95 : 21 : standard_flags_missing &= ~(pair.second);
96 : : }
97 : 1 : return standard_flags_missing == 0;
98 : : }
99 : :
100 : 134 : std::string FormatScriptFlags(unsigned int flags)
101 : : {
102 [ + + ]: 134 : if (flags == SCRIPT_VERIFY_NONE) {
103 : 39 : return "";
104 : : }
105 : 95 : std::string ret;
106 : 95 : std::map<std::string, unsigned int>::const_iterator it = mapFlagNames.begin();
107 [ + + ]: 2090 : while (it != mapFlagNames.end()) {
108 [ + + ]: 1995 : if (flags & it->second) {
109 [ + - ]: 334 : ret += it->first + ",";
110 : : }
111 : 1995 : it++;
112 : : }
113 [ + - ]: 95 : return ret.substr(0, ret.size() - 1);
114 : 95 : }
115 : :
116 : : /*
117 : : * Check that the input scripts of a transaction are valid/invalid as expected.
118 : : */
119 : 8962 : bool CheckTxScripts(const CTransaction& tx, const std::map<COutPoint, CScript>& map_prevout_scriptPubKeys,
120 : : const std::map<COutPoint, int64_t>& map_prevout_values, unsigned int flags,
121 : : const PrecomputedTransactionData& txdata, const std::string& strTest, bool expect_valid)
122 : : {
123 : 8962 : bool tx_valid = true;
124 [ + + ]: 8962 : ScriptError err = expect_valid ? SCRIPT_ERR_UNKNOWN_ERROR : SCRIPT_ERR_OK;
125 [ + + + + ]: 20623 : for (unsigned int i = 0; i < tx.vin.size() && tx_valid; ++i) {
126 : 11661 : const CTxIn input = tx.vin[i];
127 [ + - + + ]: 11661 : const CAmount amount = map_prevout_values.count(input.prevout) ? map_prevout_values.at(input.prevout) : 0;
128 : 11661 : try {
129 [ + - + - : 11661 : tx_valid = VerifyScript(input.scriptSig, map_prevout_scriptPubKeys.at(input.prevout),
+ + ]
130 [ + - ]: 11661 : &input.scriptWitness, flags, TransactionSignatureChecker(&tx, i, amount, txdata, MissingDataBehavior::ASSERT_FAIL), &err);
131 : 0 : } catch (...) {
132 [ - - - - : 0 : BOOST_ERROR("Bad test: " << strTest);
- - ]
133 : 0 : return true; // The test format is bad and an error is thrown. Return true to silence further error.
134 [ - - ]: 0 : }
135 [ + + ]: 11661 : if (expect_valid) {
136 [ + - + - : 15280 : BOOST_CHECK_MESSAGE(tx_valid, strTest);
+ - ]
137 [ + - + - : 15280 : BOOST_CHECK_MESSAGE((err == SCRIPT_ERR_OK), ScriptErrorString(err));
+ - ]
138 : 7640 : err = SCRIPT_ERR_UNKNOWN_ERROR;
139 : : }
140 : 11661 : }
141 [ + + ]: 8962 : if (!expect_valid) {
142 [ + - ]: 7426 : BOOST_CHECK_MESSAGE(!tx_valid, strTest);
143 [ + - ]: 7426 : BOOST_CHECK_MESSAGE((err != SCRIPT_ERR_OK), ScriptErrorString(err));
144 : : }
145 : 8962 : return (tx_valid == expect_valid);
146 : : }
147 : :
148 : : /*
149 : : * Trim or fill flags to make the combination valid:
150 : : * WITNESS must be used with P2SH
151 : : * CLEANSTACK must be used WITNESS and P2SH
152 : : */
153 : :
154 : 9324 : unsigned int TrimFlags(unsigned int flags)
155 : : {
156 : : // WITNESS requires P2SH
157 [ + + ]: 9324 : if (!(flags & SCRIPT_VERIFY_P2SH)) flags &= ~(unsigned int)SCRIPT_VERIFY_WITNESS;
158 : :
159 : : // CLEANSTACK requires WITNESS (and transitively CLEANSTACK requires P2SH)
160 [ + + ]: 9324 : if (!(flags & SCRIPT_VERIFY_WITNESS)) flags &= ~(unsigned int)SCRIPT_VERIFY_CLEANSTACK;
161 : 9324 : Assert(IsValidFlagCombination(flags));
162 : 9324 : return flags;
163 : : }
164 : :
165 : 3732 : unsigned int FillFlags(unsigned int flags)
166 : : {
167 : : // CLEANSTACK implies WITNESS
168 [ + + ]: 3732 : if (flags & SCRIPT_VERIFY_CLEANSTACK) flags |= SCRIPT_VERIFY_WITNESS;
169 : :
170 : : // WITNESS implies P2SH (and transitively CLEANSTACK implies P2SH)
171 [ + + ]: 3732 : if (flags & SCRIPT_VERIFY_WITNESS) flags |= SCRIPT_VERIFY_P2SH;
172 : 3732 : Assert(IsValidFlagCombination(flags));
173 : 3732 : return flags;
174 : : }
175 : :
176 : : // Exclude each possible script verify flag from flags. Returns a set of these flag combinations
177 : : // that are valid and without duplicates. For example: if flags=1111 and the 4 possible flags are
178 : : // 0001, 0010, 0100, and 1000, this should return the set {0111, 1011, 1101, 1110}.
179 : : // Assumes that mapFlagNames contains all script verify flags.
180 : 204 : std::set<unsigned int> ExcludeIndividualFlags(unsigned int flags)
181 : : {
182 : 204 : std::set<unsigned int> flags_combos;
183 [ + + ]: 4488 : for (const auto& pair : mapFlagNames) {
184 [ + - ]: 4284 : const unsigned int flags_excluding_one = TrimFlags(flags & ~(pair.second));
185 [ + + ]: 4284 : if (flags != flags_excluding_one) {
186 [ + - ]: 611 : flags_combos.insert(flags_excluding_one);
187 : : }
188 : : }
189 : 204 : return flags_combos;
190 : 0 : }
191 : :
192 : : BOOST_FIXTURE_TEST_SUITE(transaction_tests, BasicTestingSetup)
193 : :
194 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_valid)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
195 : : {
196 [ + - ]: 2 : BOOST_CHECK_MESSAGE(CheckMapFlagNames(), "mapFlagNames is missing a script verification flag");
197 : : // Read tests from test/data/tx_valid.json
198 : 1 : UniValue tests = read_json(json_tests::tx_valid);
199 : :
200 [ + + ]: 248 : for (unsigned int idx = 0; idx < tests.size(); idx++) {
201 [ + - ]: 247 : const UniValue& test = tests[idx];
202 [ + - ]: 247 : std::string strTest = test.write();
203 [ + - + + ]: 247 : if (test[0].isArray())
204 : : {
205 [ + - + - : 120 : if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
+ - + - -
+ ]
206 : : {
207 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
208 : 0 : continue;
209 : : }
210 : :
211 [ + - ]: 120 : std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
212 : 120 : std::map<COutPoint, int64_t> mapprevOutValues;
213 [ + - + - : 120 : UniValue inputs = test[0].get_array();
+ - ]
214 : 295 : bool fValid = true;
215 [ + + ]: 295 : for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
216 [ + - ]: 175 : const UniValue& input = inputs[inpIdx];
217 [ + - ]: 175 : if (!input.isArray()) {
218 : : fValid = false;
219 : : break;
220 : : }
221 [ + - ]: 175 : const UniValue& vinput = input.get_array();
222 [ + - + - ]: 175 : if (vinput.size() < 3 || vinput.size() > 4)
223 : : {
224 : : fValid = false;
225 : : break;
226 : : }
227 [ + - + - : 350 : COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
+ - + - +
- + - ]
228 [ + - + - : 175 : mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
+ - + - ]
229 [ + + ]: 175 : if (vinput.size() >= 4)
230 : : {
231 [ + - + - : 81 : mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
+ - ]
232 : : }
233 : : }
234 [ - + ]: 120 : if (!fValid)
235 : : {
236 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
237 : 0 : continue;
238 : : }
239 : :
240 [ + - + - : 120 : std::string transaction = test[1].get_str();
+ - ]
241 [ + - + - ]: 120 : DataStream stream(ParseHex(transaction));
242 [ + - ]: 120 : CTransaction tx(deserialize, TX_WITH_WITNESS, stream);
243 : :
244 [ + - ]: 120 : TxValidationState state;
245 [ + - + - : 240 : BOOST_CHECK_MESSAGE(CheckTransaction(tx, state), strTest);
+ - + - ]
246 [ + - + - : 240 : BOOST_CHECK(state.IsValid());
+ - ]
247 : :
248 [ + - ]: 120 : PrecomputedTransactionData txdata(tx);
249 [ + - + - : 120 : unsigned int verify_flags = ParseScriptFlags(test[2].get_str());
+ - + - ]
250 : :
251 : : // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
252 [ + - - + ]: 120 : if (~verify_flags != FillFlags(~verify_flags)) {
253 [ # # # # ]: 0 : BOOST_ERROR("Bad test flags: " << strTest);
254 : : }
255 : :
256 [ + - + - : 240 : BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~verify_flags, txdata, strTest, /*expect_valid=*/true),
+ - ]
257 : : "Tx unexpectedly failed: " << strTest);
258 : :
259 : : // Backwards compatibility of script verification flags: Removing any flag(s) should not invalidate a valid transaction
260 [ + - + + ]: 2640 : for (const auto& [name, flag] : mapFlagNames) {
261 : : // Removing individual flags
262 [ + - ]: 2520 : unsigned int flags = TrimFlags(~(verify_flags | flag));
263 [ + - - + ]: 2520 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
264 [ # # # # ]: 0 : BOOST_ERROR("Tx unexpectedly failed with flag " << name << " unset: " << strTest);
265 : : }
266 : : // Removing random combinations of flags
267 [ + - ]: 2520 : flags = TrimFlags(~(verify_flags | (unsigned int)m_rng.randbits(mapFlagNames.size())));
268 [ + - - + ]: 2520 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
269 [ # # # # : 0 : BOOST_ERROR("Tx unexpectedly failed with random flags " << ToString(flags) << ": " << strTest);
# # ]
270 : : }
271 : : }
272 : :
273 : : // Check that flags are maximal: transaction should fail if any unset flags are set.
274 [ + - + + ]: 221 : for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
275 [ + - - + ]: 101 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~flags_excluding_one, txdata, strTest, /*expect_valid=*/false)) {
276 [ # # # # ]: 0 : BOOST_ERROR("Too many flags unset: " << strTest);
277 : : }
278 : 120 : }
279 : 360 : }
280 : 247 : }
281 : 1 : }
282 : :
283 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_invalid)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
284 : : {
285 : : // Read tests from test/data/tx_invalid.json
286 : 1 : UniValue tests = read_json(json_tests::tx_invalid);
287 : :
288 [ + + ]: 202 : for (unsigned int idx = 0; idx < tests.size(); idx++) {
289 [ + - ]: 201 : const UniValue& test = tests[idx];
290 [ + - ]: 201 : std::string strTest = test.write();
291 [ + - + + ]: 201 : if (test[0].isArray())
292 : : {
293 [ + - + - : 93 : if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
+ - + - -
+ ]
294 : : {
295 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
296 : 0 : continue;
297 : : }
298 : :
299 [ + - ]: 93 : std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
300 : 93 : std::map<COutPoint, int64_t> mapprevOutValues;
301 [ + - + - : 93 : UniValue inputs = test[0].get_array();
+ - ]
302 : 203 : bool fValid = true;
303 [ + + ]: 203 : for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
304 [ + - ]: 110 : const UniValue& input = inputs[inpIdx];
305 [ + - ]: 110 : if (!input.isArray()) {
306 : : fValid = false;
307 : : break;
308 : : }
309 [ + - ]: 110 : const UniValue& vinput = input.get_array();
310 [ + - + - ]: 110 : if (vinput.size() < 3 || vinput.size() > 4)
311 : : {
312 : : fValid = false;
313 : : break;
314 : : }
315 [ + - + - : 220 : COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
+ - + - +
- + - ]
316 [ + - + - : 110 : mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
+ - + - ]
317 [ + + ]: 110 : if (vinput.size() >= 4)
318 : : {
319 [ + - + - : 29 : mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
+ - ]
320 : : }
321 : : }
322 [ - + ]: 93 : if (!fValid)
323 : : {
324 [ # # # # ]: 0 : BOOST_ERROR("Bad test: " << strTest);
325 : 0 : continue;
326 : : }
327 : :
328 [ + - + - : 93 : std::string transaction = test[1].get_str();
+ - ]
329 [ + - + - ]: 93 : DataStream stream(ParseHex(transaction));
330 [ + - ]: 93 : CTransaction tx(deserialize, TX_WITH_WITNESS, stream);
331 : :
332 [ + - ]: 93 : TxValidationState state;
333 [ + - + + : 93 : if (!CheckTransaction(tx, state) || state.IsInvalid()) {
+ - ]
334 [ + - + - : 18 : BOOST_CHECK_MESSAGE(test[2].get_str() == "BADTX", strTest);
+ - + - ]
335 : 9 : continue;
336 : : }
337 : :
338 [ + - ]: 84 : PrecomputedTransactionData txdata(tx);
339 [ + - + - : 84 : unsigned int verify_flags = ParseScriptFlags(test[2].get_str());
+ - + - ]
340 : :
341 : : // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
342 [ + - - + ]: 84 : if (verify_flags != FillFlags(verify_flags)) {
343 [ # # # # ]: 0 : BOOST_ERROR("Bad test flags: " << strTest);
344 : : }
345 : :
346 : : // Not using FillFlags() in the main test, in order to detect invalid verifyFlags combination
347 [ + - + - : 168 : BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, verify_flags, txdata, strTest, /*expect_valid=*/false),
+ - ]
348 : : "Tx unexpectedly passed: " << strTest);
349 : :
350 : : // Backwards compatibility of script verification flags: Adding any flag(s) should not validate an invalid transaction
351 [ + - + + ]: 1848 : for (const auto& [name, flag] : mapFlagNames) {
352 [ + - ]: 1764 : unsigned int flags = FillFlags(verify_flags | flag);
353 : : // Adding individual flags
354 [ + - - + ]: 1764 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
355 [ # # # # ]: 0 : BOOST_ERROR("Tx unexpectedly passed with flag " << name << " set: " << strTest);
356 : : }
357 : : // Adding random combinations of flags
358 [ + - ]: 1764 : flags = FillFlags(verify_flags | (unsigned int)m_rng.randbits(mapFlagNames.size()));
359 [ + - - + ]: 1764 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
360 [ # # # # ]: 0 : BOOST_ERROR("Tx unexpectedly passed with random flags " << name << ": " << strTest);
361 : : }
362 : : }
363 : :
364 : : // Check that flags are minimal: transaction should succeed if any set flags are unset.
365 [ + - + + ]: 173 : for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
366 [ + - - + ]: 89 : if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags_excluding_one, txdata, strTest, /*expect_valid=*/true)) {
367 [ # # # # ]: 0 : BOOST_ERROR("Too many flags set: " << strTest);
368 : : }
369 : 84 : }
370 : 270 : }
371 : 201 : }
372 : 1 : }
373 : :
374 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_no_inputs)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
375 : : {
376 : 1 : CMutableTransaction empty;
377 : :
378 [ + - ]: 1 : TxValidationState state;
379 [ + - + - : 3 : BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(empty), state), "Transaction with no inputs should be invalid.");
+ - + - +
- ]
380 [ + - + - : 2 : BOOST_CHECK(state.GetRejectReason() == "bad-txns-vin-empty");
+ - ]
381 : 2 : }
382 : :
383 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(tx_oversized)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
384 : : {
385 : 4 : auto createTransaction =[](size_t payloadSize) {
386 : 3 : CMutableTransaction tx;
387 [ + - ]: 3 : tx.vin.resize(1);
388 [ + - + - : 6 : tx.vout.emplace_back(1, CScript() << OP_RETURN << std::vector<unsigned char>(payloadSize));
+ - ]
389 [ + - ]: 3 : return CTransaction(tx);
390 : 3 : };
391 : 1 : const auto maxTransactionSize = MAX_BLOCK_WEIGHT / WITNESS_SCALE_FACTOR;
392 : 1 : const auto oversizedTransactionBaseSize = ::GetSerializeSize(TX_NO_WITNESS(createTransaction(maxTransactionSize))) - maxTransactionSize;
393 : :
394 : 1 : auto maxPayloadSize = maxTransactionSize - oversizedTransactionBaseSize;
395 : 1 : {
396 [ + - ]: 1 : TxValidationState state;
397 [ + - + - ]: 1 : CheckTransaction(createTransaction(maxPayloadSize), state);
398 [ + - + - : 2 : BOOST_CHECK(state.GetRejectReason() != "bad-txns-oversize");
+ - ]
399 : 0 : }
400 : :
401 : 1 : maxPayloadSize += 1;
402 : 1 : {
403 [ + - ]: 1 : TxValidationState state;
404 [ + - + - : 3 : BOOST_CHECK_MESSAGE(!CheckTransaction(createTransaction(maxPayloadSize), state), "Oversized transaction should be invalid");
+ - + - +
- ]
405 [ + - + - : 2 : BOOST_CHECK(state.GetRejectReason() == "bad-txns-oversize");
+ - ]
406 : 1 : }
407 : 1 : }
408 : :
409 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(basic_transaction_tests)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
410 : : {
411 : : // Random real transaction (e2769b09e784f32f62ef849763d4f45b98e07ba658647343b915ff832b110436)
412 : 1 : unsigned char ch[] = {0x01, 0x00, 0x00, 0x00, 0x01, 0x6b, 0xff, 0x7f, 0xcd, 0x4f, 0x85, 0x65, 0xef, 0x40, 0x6d, 0xd5, 0xd6, 0x3d, 0x4f, 0xf9, 0x4f, 0x31, 0x8f, 0xe8, 0x20, 0x27, 0xfd, 0x4d, 0xc4, 0x51, 0xb0, 0x44, 0x74, 0x01, 0x9f, 0x74, 0xb4, 0x00, 0x00, 0x00, 0x00, 0x8c, 0x49, 0x30, 0x46, 0x02, 0x21, 0x00, 0xda, 0x0d, 0xc6, 0xae, 0xce, 0xfe, 0x1e, 0x06, 0xef, 0xdf, 0x05, 0x77, 0x37, 0x57, 0xde, 0xb1, 0x68, 0x82, 0x09, 0x30, 0xe3, 0xb0, 0xd0, 0x3f, 0x46, 0xf5, 0xfc, 0xf1, 0x50, 0xbf, 0x99, 0x0c, 0x02, 0x21, 0x00, 0xd2, 0x5b, 0x5c, 0x87, 0x04, 0x00, 0x76, 0xe4, 0xf2, 0x53, 0xf8, 0x26, 0x2e, 0x76, 0x3e, 0x2d, 0xd5, 0x1e, 0x7f, 0xf0, 0xbe, 0x15, 0x77, 0x27, 0xc4, 0xbc, 0x42, 0x80, 0x7f, 0x17, 0xbd, 0x39, 0x01, 0x41, 0x04, 0xe6, 0xc2, 0x6e, 0xf6, 0x7d, 0xc6, 0x10, 0xd2, 0xcd, 0x19, 0x24, 0x84, 0x78, 0x9a, 0x6c, 0xf9, 0xae, 0xa9, 0x93, 0x0b, 0x94, 0x4b, 0x7e, 0x2d, 0xb5, 0x34, 0x2b, 0x9d, 0x9e, 0x5b, 0x9f, 0xf7, 0x9a, 0xff, 0x9a, 0x2e, 0xe1, 0x97, 0x8d, 0xd7, 0xfd, 0x01, 0xdf, 0xc5, 0x22, 0xee, 0x02, 0x28, 0x3d, 0x3b, 0x06, 0xa9, 0xd0, 0x3a, 0xcf, 0x80, 0x96, 0x96, 0x8d, 0x7d, 0xbb, 0x0f, 0x91, 0x78, 0xff, 0xff, 0xff, 0xff, 0x02, 0x8b, 0xa7, 0x94, 0x0e, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xba, 0xde, 0xec, 0xfd, 0xef, 0x05, 0x07, 0x24, 0x7f, 0xc8, 0xf7, 0x42, 0x41, 0xd7, 0x3b, 0xc0, 0x39, 0x97, 0x2d, 0x7b, 0x88, 0xac, 0x40, 0x94, 0xa8, 0x02, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xc1, 0x09, 0x32, 0x48, 0x3f, 0xec, 0x93, 0xed, 0x51, 0xf5, 0xfe, 0x95, 0xe7, 0x25, 0x59, 0xf2, 0xcc, 0x70, 0x43, 0xf9, 0x88, 0xac, 0x00, 0x00, 0x00, 0x00, 0x00};
413 : 1 : std::vector<unsigned char> vch(ch, ch + sizeof(ch) -1);
414 [ + - ]: 1 : DataStream stream(vch);
415 [ + - ]: 1 : CMutableTransaction tx;
416 [ + - ]: 1 : stream >> TX_WITH_WITNESS(tx);
417 [ + - ]: 1 : TxValidationState state;
418 [ + - + - : 3 : BOOST_CHECK_MESSAGE(CheckTransaction(CTransaction(tx), state) && state.IsValid(), "Simple deserialized transaction should be valid.");
+ - + - -
+ + - +
- ]
419 : :
420 : : // Check that duplicate txins fail
421 [ + - ]: 1 : tx.vin.push_back(tx.vin[0]);
422 [ + - + - : 3 : BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(tx), state) || !state.IsValid(), "Transaction with duplicate txins should be invalid.");
+ - - + -
- + - ]
423 : 2 : }
424 : :
425 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_Get)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
426 : : {
427 : 1 : FillableSigningProvider keystore;
428 : 1 : CCoinsView coinsDummy;
429 [ + - ]: 1 : CCoinsViewCache coins(&coinsDummy);
430 : 1 : std::vector<CMutableTransaction> dummyTransactions =
431 [ + - ]: 1 : SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
432 : :
433 [ + - ]: 1 : CMutableTransaction t1;
434 [ + - ]: 1 : t1.vin.resize(3);
435 [ + - ]: 1 : t1.vin[0].prevout.hash = dummyTransactions[0].GetHash();
436 : 1 : t1.vin[0].prevout.n = 1;
437 [ + - + - ]: 1 : t1.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
438 [ + - ]: 1 : t1.vin[1].prevout.hash = dummyTransactions[1].GetHash();
439 : 1 : t1.vin[1].prevout.n = 0;
440 [ + - + - : 1 : t1.vin[1].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
+ - ]
441 [ + - ]: 1 : t1.vin[2].prevout.hash = dummyTransactions[1].GetHash();
442 : 1 : t1.vin[2].prevout.n = 1;
443 [ + - + - : 1 : t1.vin[2].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
+ - ]
444 [ + - ]: 1 : t1.vout.resize(2);
445 [ + - ]: 1 : t1.vout[0].nValue = 90*CENT;
446 [ + - ]: 1 : t1.vout[0].scriptPubKey << OP_1;
447 : :
448 [ + - + - : 3 : BOOST_CHECK(AreInputsStandard(CTransaction(t1), coins));
+ - + - ]
449 : 1 : }
450 : :
451 : 24 : static void CreateCreditAndSpend(const FillableSigningProvider& keystore, const CScript& outscript, CTransactionRef& output, CMutableTransaction& input, bool success = true)
452 : : {
453 : 24 : CMutableTransaction outputm;
454 : 24 : outputm.version = 1;
455 [ + - ]: 24 : outputm.vin.resize(1);
456 : 24 : outputm.vin[0].prevout.SetNull();
457 : 24 : outputm.vin[0].scriptSig = CScript();
458 [ + - ]: 24 : outputm.vout.resize(1);
459 : 24 : outputm.vout[0].nValue = 1;
460 : 24 : outputm.vout[0].scriptPubKey = outscript;
461 : 24 : DataStream ssout;
462 [ + - ]: 24 : ssout << TX_WITH_WITNESS(outputm);
463 [ + - ]: 24 : ssout >> TX_WITH_WITNESS(output);
464 [ - + ]: 24 : assert(output->vin.size() == 1);
465 [ - + ]: 24 : assert(output->vin[0] == outputm.vin[0]);
466 [ - + ]: 24 : assert(output->vout.size() == 1);
467 [ - + ]: 24 : assert(output->vout[0] == outputm.vout[0]);
468 : :
469 [ + - ]: 24 : CMutableTransaction inputm;
470 : 24 : inputm.version = 1;
471 [ + - ]: 24 : inputm.vin.resize(1);
472 [ + - ]: 24 : inputm.vin[0].prevout.hash = output->GetHash();
473 : 24 : inputm.vin[0].prevout.n = 0;
474 [ + - ]: 24 : inputm.vout.resize(1);
475 : 24 : inputm.vout[0].nValue = 1;
476 : 24 : inputm.vout[0].scriptPubKey = CScript();
477 : 24 : SignatureData empty;
478 [ + - ]: 24 : bool ret = SignSignature(keystore, *output, inputm, 0, SIGHASH_ALL, empty);
479 [ - + ]: 24 : assert(ret == success);
480 : 24 : DataStream ssin;
481 [ + - ]: 24 : ssin << TX_WITH_WITNESS(inputm);
482 [ + - ]: 24 : ssin >> TX_WITH_WITNESS(input);
483 [ - + ]: 24 : assert(input.vin.size() == 1);
484 [ - + ]: 24 : assert(input.vin[0] == inputm.vin[0]);
485 [ - + ]: 24 : assert(input.vout.size() == 1);
486 [ - + ]: 24 : assert(input.vout[0] == inputm.vout[0]);
487 [ - + ]: 24 : assert(input.vin[0].scriptWitness.stack == inputm.vin[0].scriptWitness.stack);
488 : 72 : }
489 : :
490 : 69 : static void CheckWithFlag(const CTransactionRef& output, const CMutableTransaction& input, uint32_t flags, bool success)
491 : : {
492 : 69 : ScriptError error;
493 : 69 : CTransaction inputi(input);
494 [ + - - + ]: 69 : bool ret = VerifyScript(inputi.vin[0].scriptSig, output->vout[0].scriptPubKey, &inputi.vin[0].scriptWitness, flags, TransactionSignatureChecker(&inputi, 0, output->vout[0].nValue, MissingDataBehavior::ASSERT_FAIL), &error);
495 [ - + ]: 69 : assert(ret == success);
496 : 69 : }
497 : :
498 : 3 : static CScript PushAll(const std::vector<valtype>& values)
499 : : {
500 : 3 : CScript result;
501 [ + + ]: 8 : for (const valtype& v : values) {
502 [ - + ]: 5 : if (v.size() == 0) {
503 [ # # ]: 0 : result << OP_0;
504 [ - + - - : 5 : } else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {
- - ]
505 [ # # ]: 0 : result << CScript::EncodeOP_N(v[0]);
506 [ - + - - ]: 5 : } else if (v.size() == 1 && v[0] == 0x81) {
507 [ # # ]: 0 : result << OP_1NEGATE;
508 : : } else {
509 : 5 : result << v;
510 : : }
511 : : }
512 : 3 : return result;
513 : 0 : }
514 : :
515 : 3 : static void ReplaceRedeemScript(CScript& script, const CScript& redeemScript)
516 : : {
517 : 3 : std::vector<valtype> stack;
518 [ + - ]: 3 : EvalScript(stack, script, SCRIPT_VERIFY_STRICTENC, BaseSignatureChecker(), SigVersion::BASE);
519 [ - + ]: 3 : assert(stack.size() > 0);
520 [ + + + - : 6 : stack.back() = std::vector<unsigned char>(redeemScript.begin(), redeemScript.end());
+ - ]
521 [ + - ]: 6 : script = PushAll(stack);
522 : 3 : }
523 : :
524 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_big_witness_transaction)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
525 : : {
526 : 1 : CMutableTransaction mtx;
527 : 1 : mtx.version = 1;
528 : :
529 : 1 : CKey key = GenerateRandomKey(); // Need to use compressed keys in segwit or the signing will fail
530 : 1 : FillableSigningProvider keystore;
531 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key, key.GetPubKey()));
+ - + - +
- ]
532 [ + - + - ]: 1 : CKeyID hash = key.GetPubKey().GetID();
533 [ + - + - ]: 1 : CScript scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(hash.begin(), hash.end());
534 : :
535 : 1 : std::vector<int> sigHashes;
536 [ + - ]: 1 : sigHashes.push_back(SIGHASH_NONE | SIGHASH_ANYONECANPAY);
537 [ + - ]: 1 : sigHashes.push_back(SIGHASH_SINGLE | SIGHASH_ANYONECANPAY);
538 [ + - ]: 1 : sigHashes.push_back(SIGHASH_ALL | SIGHASH_ANYONECANPAY);
539 [ + - ]: 1 : sigHashes.push_back(SIGHASH_NONE);
540 [ + - ]: 1 : sigHashes.push_back(SIGHASH_SINGLE);
541 [ + - ]: 1 : sigHashes.push_back(SIGHASH_ALL);
542 : :
543 : : // create a big transaction of 4500 inputs signed by the same key
544 [ + + ]: 4501 : for(uint32_t ij = 0; ij < 4500; ij++) {
545 [ + - ]: 4500 : uint32_t i = mtx.vin.size();
546 [ + - + - ]: 9000 : COutPoint outpoint(Txid::FromHex("0000000000000000000000000000000000000000000000000000000000000100").value(), i);
547 : :
548 [ + - ]: 4500 : mtx.vin.resize(mtx.vin.size() + 1);
549 : 4500 : mtx.vin[i].prevout = outpoint;
550 : 4500 : mtx.vin[i].scriptSig = CScript();
551 : :
552 [ + - ]: 4500 : mtx.vout.resize(mtx.vout.size() + 1);
553 [ + - ]: 4500 : mtx.vout[i].nValue = 1000;
554 [ + - ]: 4500 : mtx.vout[i].scriptPubKey = CScript() << OP_1;
555 : : }
556 : :
557 : : // sign all inputs
558 [ + + ]: 4501 : for(uint32_t i = 0; i < mtx.vin.size(); i++) {
559 : 4500 : SignatureData empty;
560 [ + - + - ]: 4500 : bool hashSigned = SignSignature(keystore, scriptPubKey, mtx, i, 1000, sigHashes.at(i % sigHashes.size()), empty);
561 [ - + ]: 4500 : assert(hashSigned);
562 : 4500 : }
563 : :
564 : 1 : DataStream ssout;
565 [ + - ]: 1 : ssout << TX_WITH_WITNESS(mtx);
566 [ + - ]: 1 : CTransaction tx(deserialize, TX_WITH_WITNESS, ssout);
567 : :
568 : : // check all inputs concurrently, with the cache
569 [ + - ]: 1 : PrecomputedTransactionData txdata(tx);
570 [ + - ]: 1 : CCheckQueue<CScriptCheck> scriptcheckqueue(/*batch_size=*/128, /*worker_threads_num=*/20);
571 [ + - ]: 1 : CCheckQueueControl<CScriptCheck> control(&scriptcheckqueue);
572 : :
573 : 1 : std::vector<Coin> coins;
574 [ + + ]: 4501 : for(uint32_t i = 0; i < mtx.vin.size(); i++) {
575 : 4500 : Coin coin;
576 : 4500 : coin.nHeight = 1;
577 : 4500 : coin.fCoinBase = false;
578 : 4500 : coin.out.nValue = 1000;
579 : 4500 : coin.out.scriptPubKey = scriptPubKey;
580 [ + - ]: 4500 : coins.emplace_back(std::move(coin));
581 : 4500 : }
582 : :
583 [ + - ]: 1 : SignatureCache signature_cache{DEFAULT_SIGNATURE_CACHE_BYTES};
584 : :
585 [ + + ]: 4501 : for(uint32_t i = 0; i < mtx.vin.size(); i++) {
586 : 4500 : std::vector<CScriptCheck> vChecks;
587 [ + - ]: 4500 : vChecks.emplace_back(coins[tx.vin[i].prevout.n].out, tx, signature_cache, i, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false, &txdata);
588 [ + - ]: 4500 : control.Add(std::move(vChecks));
589 : 4500 : }
590 : :
591 [ + - ]: 1 : bool controlCheck = control.Wait();
592 [ - + ]: 1 : assert(controlCheck);
593 : 3 : }
594 : :
595 : 4 : SignatureData CombineSignatures(const CMutableTransaction& input1, const CMutableTransaction& input2, const CTransactionRef tx)
596 : : {
597 : 4 : SignatureData sigdata;
598 [ + - ]: 4 : sigdata = DataFromTransaction(input1, 0, tx->vout[0]);
599 [ + - + - ]: 4 : sigdata.MergeSignatureData(DataFromTransaction(input2, 0, tx->vout[0]));
600 [ + - + - ]: 4 : ProduceSignature(DUMMY_SIGNING_PROVIDER, MutableTransactionSignatureCreator(input1, 0, tx->vout[0].nValue, SIGHASH_ALL), tx->vout[0].scriptPubKey, sigdata);
601 : 4 : return sigdata;
602 : 0 : }
603 : :
604 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_witness)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
605 : : {
606 : 1 : FillableSigningProvider keystore, keystore2;
607 : 1 : CKey key1 = GenerateRandomKey();
608 : 1 : CKey key2 = GenerateRandomKey();
609 : 1 : CKey key3 = GenerateRandomKey();
610 : 1 : CKey key1L = GenerateRandomKey(/*compressed=*/false);
611 : 1 : CKey key2L = GenerateRandomKey(/*compressed=*/false);
612 [ + - ]: 1 : CPubKey pubkey1 = key1.GetPubKey();
613 [ + - ]: 1 : CPubKey pubkey2 = key2.GetPubKey();
614 [ + - ]: 1 : CPubKey pubkey3 = key3.GetPubKey();
615 [ + - ]: 1 : CPubKey pubkey1L = key1L.GetPubKey();
616 [ + - ]: 1 : CPubKey pubkey2L = key2L.GetPubKey();
617 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key1, pubkey1));
+ - + - ]
618 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key2, pubkey2));
+ - + - ]
619 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key1L, pubkey1L));
+ - + - ]
620 [ + - + - : 2 : BOOST_CHECK(keystore.AddKeyPubKey(key2L, pubkey2L));
+ - + - ]
621 : 1 : CScript scriptPubkey1, scriptPubkey2, scriptPubkey1L, scriptPubkey2L, scriptMulti;
622 [ + - + - ]: 1 : scriptPubkey1 << ToByteVector(pubkey1) << OP_CHECKSIG;
623 [ + - + - ]: 1 : scriptPubkey2 << ToByteVector(pubkey2) << OP_CHECKSIG;
624 [ + - + - ]: 1 : scriptPubkey1L << ToByteVector(pubkey1L) << OP_CHECKSIG;
625 [ + - + - ]: 1 : scriptPubkey2L << ToByteVector(pubkey2L) << OP_CHECKSIG;
626 : 1 : std::vector<CPubKey> oneandthree;
627 [ + - ]: 1 : oneandthree.push_back(pubkey1);
628 [ + - ]: 1 : oneandthree.push_back(pubkey3);
629 [ + - ]: 2 : scriptMulti = GetScriptForMultisig(2, oneandthree);
630 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey1));
+ - + - ]
631 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey2));
+ - + - ]
632 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey1L));
+ - + - ]
633 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptPubkey2L));
+ - + - ]
634 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(scriptMulti));
+ - + - ]
635 : 1 : CScript destination_script_1, destination_script_2, destination_script_1L, destination_script_2L, destination_script_multi;
636 [ + - + - ]: 2 : destination_script_1 = GetScriptForDestination(WitnessV0KeyHash(pubkey1));
637 [ + - + - ]: 2 : destination_script_2 = GetScriptForDestination(WitnessV0KeyHash(pubkey2));
638 [ + - + - ]: 2 : destination_script_1L = GetScriptForDestination(WitnessV0KeyHash(pubkey1L));
639 [ + - + - ]: 2 : destination_script_2L = GetScriptForDestination(WitnessV0KeyHash(pubkey2L));
640 [ + - + - ]: 2 : destination_script_multi = GetScriptForDestination(WitnessV0ScriptHash(scriptMulti));
641 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_1));
+ - + - ]
642 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_2));
+ - + - ]
643 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_1L));
+ - + - ]
644 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_2L));
+ - + - ]
645 [ + - + - : 2 : BOOST_CHECK(keystore.AddCScript(destination_script_multi));
+ - + - ]
646 [ + - + - : 2 : BOOST_CHECK(keystore2.AddCScript(scriptMulti));
+ - + - ]
647 [ + - + - : 2 : BOOST_CHECK(keystore2.AddCScript(destination_script_multi));
+ - + - ]
648 [ + - + - : 2 : BOOST_CHECK(keystore2.AddKeyPubKey(key3, pubkey3));
+ - + - ]
649 : :
650 : 1 : CTransactionRef output1, output2;
651 [ + - + - ]: 1 : CMutableTransaction input1, input2;
652 : :
653 : : // Normal pay-to-compressed-pubkey.
654 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey1, output1, input1);
655 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey2, output2, input2);
656 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
657 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
658 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
659 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
660 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
661 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
662 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
663 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
664 : :
665 : : // P2SH pay-to-compressed-pubkey.
666 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1)), output1, input1);
+ - ]
667 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2)), output2, input2);
+ - ]
668 [ + - ]: 1 : ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1);
669 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
670 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
671 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
672 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
673 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
674 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
675 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
676 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
677 : :
678 : : // Witness pay-to-compressed-pubkey (v0).
679 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_1, output1, input1);
680 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_2, output2, input2);
681 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
682 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
683 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
684 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
685 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
686 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
687 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
688 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
689 : :
690 : : // P2SH witness pay-to-compressed-pubkey (v0).
691 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1)), output1, input1);
+ - ]
692 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2)), output2, input2);
+ - ]
693 [ + - ]: 1 : ReplaceRedeemScript(input2.vin[0].scriptSig, destination_script_1);
694 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
695 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
696 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
697 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
698 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
699 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
700 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
701 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
702 : :
703 : : // Normal pay-to-uncompressed-pubkey.
704 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey1L, output1, input1);
705 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptPubkey2L, output2, input2);
706 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
707 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
708 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
709 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
710 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
711 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
712 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
713 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
714 : :
715 : : // P2SH pay-to-uncompressed-pubkey.
716 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1L)), output1, input1);
+ - ]
717 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2L)), output2, input2);
+ - ]
718 [ + - ]: 1 : ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1L);
719 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
720 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
721 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true);
722 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
723 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
724 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
725 [ + - ]: 1 : CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
726 [ + - ]: 1 : CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
727 : :
728 : : // Signing disabled for witness pay-to-uncompressed-pubkey (v1).
729 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_1L, output1, input1, false);
730 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_2L, output2, input2, false);
731 : :
732 : : // Signing disabled for P2SH witness pay-to-uncompressed-pubkey (v1).
733 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1L)), output1, input1, false);
+ - ]
734 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2L)), output2, input2, false);
+ - ]
735 : :
736 : : // Normal 2-of-2 multisig
737 [ + - ]: 1 : CreateCreditAndSpend(keystore, scriptMulti, output1, input1, false);
738 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, false);
739 [ + - ]: 1 : CreateCreditAndSpend(keystore2, scriptMulti, output2, input2, false);
740 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, false);
741 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
742 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
743 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
744 : :
745 : : // P2SH 2-of-2 multisig
746 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptMulti)), output1, input1, false);
+ - ]
747 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
748 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, false);
749 [ + - + - : 2 : CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(scriptMulti)), output2, input2, false);
+ - ]
750 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
751 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, false);
752 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
753 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
754 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
755 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
756 : :
757 : : // Witness 2-of-2 multisig
758 [ + - ]: 1 : CreateCreditAndSpend(keystore, destination_script_multi, output1, input1, false);
759 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
760 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
761 [ + - ]: 1 : CreateCreditAndSpend(keystore2, destination_script_multi, output2, input2, false);
762 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
763 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
764 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
765 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
766 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, true);
767 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
768 : :
769 : : // P2SH witness 2-of-2 multisig
770 [ + - + - : 2 : CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_multi)), output1, input1, false);
+ - ]
771 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
772 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
773 [ + - + - : 2 : CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(destination_script_multi)), output2, input2, false);
+ - ]
774 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, true);
775 [ + - ]: 1 : CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
776 [ + - + - : 2 : BOOST_CHECK(*output1 == *output2);
+ - ]
777 [ + - + - : 2 : UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
+ - + - ]
778 [ + - ]: 1 : CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, true);
779 [ + - ]: 1 : CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
780 [ + - + - ]: 4 : }
781 : :
782 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(test_IsStandard)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
783 : : {
784 : 1 : FillableSigningProvider keystore;
785 : 1 : CCoinsView coinsDummy;
786 [ + - ]: 1 : CCoinsViewCache coins(&coinsDummy);
787 : 1 : std::vector<CMutableTransaction> dummyTransactions =
788 [ + - ]: 1 : SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
789 : :
790 [ + - ]: 1 : CMutableTransaction t;
791 [ + - ]: 1 : t.vin.resize(1);
792 [ + - ]: 1 : t.vin[0].prevout.hash = dummyTransactions[0].GetHash();
793 : 1 : t.vin[0].prevout.n = 1;
794 [ + - + - ]: 1 : t.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
795 [ + - ]: 1 : t.vout.resize(1);
796 : 1 : t.vout[0].nValue = 90*CENT;
797 : 1 : CKey key = GenerateRandomKey();
798 [ + - + - : 1 : t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
+ - ]
799 : :
800 [ + - ]: 45 : constexpr auto CheckIsStandard = [](const auto& t) {
801 : 44 : std::string reason;
802 [ + - + - : 132 : BOOST_CHECK(IsStandardTx(CTransaction{t}, MAX_OP_RETURN_RELAY, g_bare_multi, g_dust, reason));
+ - + - +
- ]
803 [ + - + - ]: 88 : BOOST_CHECK(reason.empty());
804 : 44 : };
805 [ + - ]: 104 : constexpr auto CheckIsNotStandard = [](const auto& t, const std::string& reason_in) {
806 : 103 : std::string reason;
807 [ + - + - : 309 : BOOST_CHECK(!IsStandardTx(CTransaction{t}, MAX_OP_RETURN_RELAY, g_bare_multi, g_dust, reason));
+ - + - +
- ]
808 [ + - + - ]: 103 : BOOST_CHECK_EQUAL(reason_in, reason);
809 : 103 : };
810 : :
811 [ + - ]: 1 : CheckIsStandard(t);
812 : :
813 : : // Check dust with default relay fee:
814 [ + - ]: 1 : CAmount nDustThreshold = 182 * g_dust.GetFeePerK() / 1000;
815 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(nDustThreshold, 546);
816 : : // dust:
817 [ + - ]: 1 : t.vout[0].nValue = nDustThreshold - 1;
818 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
819 : : // not dust:
820 [ + - ]: 1 : t.vout[0].nValue = nDustThreshold;
821 [ + - ]: 1 : CheckIsStandard(t);
822 : :
823 : : // Disallowed version
824 : 1 : t.version = std::numeric_limits<uint32_t>::max();
825 [ + - + - ]: 1 : CheckIsNotStandard(t, "version");
826 : :
827 : 1 : t.version = 0;
828 [ + - + - ]: 1 : CheckIsNotStandard(t, "version");
829 : :
830 : 1 : t.version = TX_MAX_STANDARD_VERSION + 1;
831 [ + - + - ]: 1 : CheckIsNotStandard(t, "version");
832 : :
833 : : // Allowed version
834 : 1 : t.version = 1;
835 [ + - ]: 1 : CheckIsStandard(t);
836 : :
837 : 1 : t.version = 2;
838 [ + - ]: 1 : CheckIsStandard(t);
839 : :
840 : : // Check dust with odd relay fee to verify rounding:
841 : : // nDustThreshold = 182 * 3702 / 1000
842 [ + - ]: 1 : g_dust = CFeeRate(3702);
843 : : // dust:
844 [ + - ]: 1 : t.vout[0].nValue = 674 - 1;
845 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
846 : : // not dust:
847 [ + - ]: 1 : t.vout[0].nValue = 674;
848 [ + - ]: 1 : CheckIsStandard(t);
849 [ + - ]: 1 : g_dust = CFeeRate{DUST_RELAY_TX_FEE};
850 : :
851 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_1;
852 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptpubkey");
853 : :
854 : : // MAX_OP_RETURN_RELAY-byte TxoutType::NULL_DATA (standard)
855 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
856 [ + - + - : 2 : BOOST_CHECK_EQUAL(MAX_OP_RETURN_RELAY, t.vout[0].scriptPubKey.size());
+ - ]
857 [ + - ]: 1 : CheckIsStandard(t);
858 : :
859 : : // MAX_OP_RETURN_RELAY+1-byte TxoutType::NULL_DATA (non-standard)
860 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3800"_hex;
861 [ + - + - : 2 : BOOST_CHECK_EQUAL(MAX_OP_RETURN_RELAY + 1, t.vout[0].scriptPubKey.size());
+ - ]
862 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptpubkey");
863 : :
864 : : // Data payload can be encoded in any way...
865 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << ""_hex;
866 [ + - ]: 1 : CheckIsStandard(t);
867 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << "00"_hex << "01"_hex;
868 [ + - ]: 1 : CheckIsStandard(t);
869 : : // OP_RESERVED *is* considered to be a PUSHDATA type opcode by IsPushOnly()!
870 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RESERVED << -1 << 0 << "01"_hex << 2 << 3 << 4 << 5 << 6 << 7 << 8 << 9 << 10 << 11 << 12 << 13 << 14 << 15 << 16;
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - ]
871 [ + - ]: 1 : CheckIsStandard(t);
872 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << 0 << "01"_hex << 2 << "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"_hex;
+ - ]
873 [ + - ]: 1 : CheckIsStandard(t);
874 : :
875 : : // ...so long as it only contains PUSHDATA's
876 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RETURN;
877 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptpubkey");
878 : :
879 : : // TxoutType::NULL_DATA w/o PUSHDATA
880 [ + - ]: 1 : t.vout.resize(1);
881 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN;
882 [ + - ]: 1 : CheckIsStandard(t);
883 : :
884 : : // Only one TxoutType::NULL_DATA permitted in all cases
885 [ + - ]: 1 : t.vout.resize(2);
886 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
887 [ + - ]: 1 : t.vout[0].nValue = 0;
888 [ + - ]: 1 : t.vout[1].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
889 [ + - ]: 1 : t.vout[1].nValue = 0;
890 [ + - + - ]: 1 : CheckIsNotStandard(t, "multi-op-return");
891 : :
892 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
893 [ + - ]: 1 : t.vout[1].scriptPubKey = CScript() << OP_RETURN;
894 [ + - + - ]: 1 : CheckIsNotStandard(t, "multi-op-return");
895 : :
896 [ + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN;
897 [ + - ]: 1 : t.vout[1].scriptPubKey = CScript() << OP_RETURN;
898 [ + - + - ]: 1 : CheckIsNotStandard(t, "multi-op-return");
899 : :
900 : : // Check large scriptSig (non-standard if size is >1650 bytes)
901 [ + - ]: 1 : t.vout.resize(1);
902 [ + - ]: 1 : t.vout[0].nValue = MAX_MONEY;
903 [ + - + - : 1 : t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
+ - ]
904 : : // OP_PUSHDATA2 with len (3 bytes) + data (1647 bytes) = 1650 bytes
905 [ + - ]: 1 : t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1647, 0); // 1650
906 [ + - ]: 1 : CheckIsStandard(t);
907 : :
908 [ + - ]: 1 : t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1648, 0); // 1651
909 [ + - + - ]: 1 : CheckIsNotStandard(t, "scriptsig-size");
910 : :
911 : : // Check scriptSig format (non-standard if there are any other ops than just PUSHs)
912 [ + - ]: 2 : t.vin[0].scriptSig = CScript()
913 [ + - + - : 1 : << OP_TRUE << OP_0 << OP_1NEGATE << OP_16 // OP_n (single byte pushes: n = 1, 0, -1, 16)
+ - + - +
- ]
914 [ + - + - ]: 2 : << std::vector<unsigned char>(75, 0) // OP_PUSHx [...x bytes...]
915 [ + - + - ]: 2 : << std::vector<unsigned char>(235, 0) // OP_PUSHDATA1 x [...x bytes...]
916 [ + - ]: 2 : << std::vector<unsigned char>(1234, 0) // OP_PUSHDATA2 x [...x bytes...]
917 [ + - ]: 1 : << OP_9;
918 [ + - ]: 1 : CheckIsStandard(t);
919 : :
920 : 1 : const std::vector<unsigned char> non_push_ops = { // arbitrary set of non-push operations
921 : : OP_NOP, OP_VERIFY, OP_IF, OP_ROT, OP_3DUP, OP_SIZE, OP_EQUAL, OP_ADD, OP_SUB,
922 [ + - ]: 1 : OP_HASH256, OP_CODESEPARATOR, OP_CHECKSIG, OP_CHECKLOCKTIMEVERIFY };
923 : :
924 [ - + ]: 2 : CScript::const_iterator pc = t.vin[0].scriptSig.begin();
925 [ + + ]: 9 : while (pc < t.vin[0].scriptSig.end()) {
926 : 8 : opcodetype opcode;
927 : 8 : CScript::const_iterator prev_pc = pc;
928 [ + - ]: 8 : t.vin[0].scriptSig.GetOp(pc, opcode); // advance to next op
929 : : // for the sake of simplicity, we only replace single-byte push operations
930 [ + + ]: 8 : if (opcode >= 1 && opcode <= OP_PUSHDATA4)
931 : 3 : continue;
932 : :
933 [ - + ]: 10 : int index = prev_pc - t.vin[0].scriptSig.begin();
934 : 5 : unsigned char orig_op = *prev_pc; // save op
935 : : // replace current push-op with each non-push-op
936 [ + + ]: 70 : for (auto op : non_push_ops) {
937 [ - + ]: 65 : t.vin[0].scriptSig[index] = op;
938 [ + - + - ]: 130 : CheckIsNotStandard(t, "scriptsig-not-pushonly");
939 : : }
940 [ - + ]: 5 : t.vin[0].scriptSig[index] = orig_op; // restore op
941 [ + - ]: 5 : CheckIsStandard(t);
942 : : }
943 : :
944 : : // Check tx-size (non-standard if transaction weight is > MAX_STANDARD_TX_WEIGHT)
945 : 1 : t.vin.clear();
946 [ + - ]: 1 : t.vin.resize(2438); // size per input (empty scriptSig): 41 bytes
947 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(19, 0); // output size: 30 bytes
948 : : // tx header: 12 bytes => 48 weight units
949 : : // 2438 inputs: 2438*41 = 99958 bytes => 399832 weight units
950 : : // 1 output: 30 bytes => 120 weight units
951 : : // ======================================
952 : : // total: 400000 weight units
953 [ + - + - : 1 : BOOST_CHECK_EQUAL(GetTransactionWeight(CTransaction(t)), 400000);
+ - ]
954 [ + - ]: 1 : CheckIsStandard(t);
955 : :
956 : : // increase output size by one byte, so we end up with 400004 weight units
957 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(20, 0); // output size: 31 bytes
958 [ + - + - : 1 : BOOST_CHECK_EQUAL(GetTransactionWeight(CTransaction(t)), 400004);
+ - ]
959 [ + - + - ]: 1 : CheckIsNotStandard(t, "tx-size");
960 : :
961 : : // Check bare multisig (standard if policy flag g_bare_multi is set)
962 : 1 : g_bare_multi = true;
963 [ + - + - : 1 : t.vout[0].scriptPubKey = GetScriptForMultisig(1, {key.GetPubKey()}); // simple 1-of-1
+ - + - ]
964 [ + - ]: 1 : t.vin.resize(1);
965 [ + - ]: 1 : t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(65, 0);
966 [ + - ]: 1 : CheckIsStandard(t);
967 : :
968 : 1 : g_bare_multi = false;
969 [ + - + - ]: 1 : CheckIsNotStandard(t, "bare-multisig");
970 : 1 : g_bare_multi = DEFAULT_PERMIT_BAREMULTISIG;
971 : :
972 : : // Check compressed P2PK outputs dust threshold (must have leading 02 or 03)
973 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(33, 0x02) << OP_CHECKSIG;
974 [ + - ]: 1 : t.vout[0].nValue = 576;
975 [ + - ]: 1 : CheckIsStandard(t);
976 [ + - ]: 1 : t.vout[0].nValue = 575;
977 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
978 : :
979 : : // Check uncompressed P2PK outputs dust threshold (must have leading 04/06/07)
980 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(65, 0x04) << OP_CHECKSIG;
981 [ + - ]: 1 : t.vout[0].nValue = 672;
982 [ + - ]: 1 : CheckIsStandard(t);
983 [ + - ]: 1 : t.vout[0].nValue = 671;
984 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
985 : :
986 : : // Check P2PKH outputs dust threshold
987 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_DUP << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUALVERIFY << OP_CHECKSIG;
+ - + - +
- ]
988 [ + - ]: 1 : t.vout[0].nValue = 546;
989 [ + - ]: 1 : CheckIsStandard(t);
990 [ + - ]: 1 : t.vout[0].nValue = 545;
991 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
992 : :
993 : : // Check P2SH outputs dust threshold
994 [ + - + - : 1 : t.vout[0].scriptPubKey = CScript() << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUAL;
+ - ]
995 [ + - ]: 1 : t.vout[0].nValue = 540;
996 [ + - ]: 1 : CheckIsStandard(t);
997 [ + - ]: 1 : t.vout[0].nValue = 539;
998 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
999 : :
1000 : : // Check P2WPKH outputs dust threshold
1001 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(20, 0);
1002 [ + - ]: 1 : t.vout[0].nValue = 294;
1003 [ + - ]: 1 : CheckIsStandard(t);
1004 [ + - ]: 1 : t.vout[0].nValue = 293;
1005 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
1006 : :
1007 : : // Check P2WSH outputs dust threshold
1008 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(32, 0);
1009 [ + - ]: 1 : t.vout[0].nValue = 330;
1010 [ + - ]: 1 : CheckIsStandard(t);
1011 [ + - ]: 1 : t.vout[0].nValue = 329;
1012 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
1013 : :
1014 : : // Check P2TR outputs dust threshold (Invalid xonly key ok!)
1015 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_1 << std::vector<unsigned char>(32, 0);
1016 [ + - ]: 1 : t.vout[0].nValue = 330;
1017 [ + - ]: 1 : CheckIsStandard(t);
1018 [ + - ]: 1 : t.vout[0].nValue = 329;
1019 [ + - + - ]: 1 : CheckIsNotStandard(t, "dust");
1020 : :
1021 : : // Check future Witness Program versions dust threshold (non-32-byte pushes are undefined for version 1)
1022 [ + + ]: 17 : for (int op = OP_1; op <= OP_16; op += 1) {
1023 [ + - + - ]: 16 : t.vout[0].scriptPubKey = CScript() << (opcodetype)op << std::vector<unsigned char>(2, 0);
1024 [ + - ]: 16 : t.vout[0].nValue = 240;
1025 [ + - ]: 16 : CheckIsStandard(t);
1026 : :
1027 [ + - ]: 16 : t.vout[0].nValue = 239;
1028 [ + - + - ]: 32 : CheckIsNotStandard(t, "dust");
1029 : : }
1030 : :
1031 : : // Check anchor outputs
1032 [ + - + - ]: 1 : t.vout[0].scriptPubKey = CScript() << OP_1 << std::vector<unsigned char>{0x4e, 0x73};
1033 [ + - + - : 2 : BOOST_CHECK(t.vout[0].scriptPubKey.IsPayToAnchor());
+ - + - ]
1034 [ + - ]: 1 : t.vout[0].nValue = 240;
1035 [ + - ]: 1 : CheckIsStandard(t);
1036 [ + - ]: 1 : t.vout[0].nValue = 239;
1037 [ + - + - ]: 2 : CheckIsNotStandard(t, "dust");
1038 : 2 : }
1039 : :
1040 : : BOOST_AUTO_TEST_SUITE_END()
|
