Branch data Line data Source code
1 : : // Copyright (c) 2021-present The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : : #include <common/system.h>
5 : : #include <policy/rbf.h>
6 : : #include <random.h>
7 : : #include <test/util/txmempool.h>
8 : : #include <txmempool.h>
9 : : #include <util/time.h>
10 : :
11 : : #include <test/util/setup_common.h>
12 : :
13 : : #include <boost/test/unit_test.hpp>
14 : : #include <optional>
15 : : #include <vector>
16 : :
17 : : BOOST_FIXTURE_TEST_SUITE(rbf_tests, BasicTestingSetup)
18 : :
19 : 1150 : static inline CTransactionRef make_tx(const std::vector<CTransactionRef>& inputs,
20 : : const std::vector<CAmount>& output_values)
21 : : {
22 : 1150 : CMutableTransaction tx = CMutableTransaction();
23 [ - + + - ]: 1150 : tx.vin.resize(inputs.size());
24 [ - + + - ]: 1150 : tx.vout.resize(output_values.size());
25 [ - + + + ]: 2303 : for (size_t i = 0; i < inputs.size(); ++i) {
26 [ + - ]: 1153 : tx.vin[i].prevout.hash = inputs[i]->GetHash();
27 : 1153 : tx.vin[i].prevout.n = 0;
28 : : // Add a witness so wtxid != txid
29 : 1153 : CScriptWitness witness;
30 [ + - ]: 1153 : witness.stack.emplace_back(i + 10);
31 [ + - ]: 1153 : tx.vin[i].scriptWitness = witness;
32 : 1153 : }
33 [ - + + + ]: 2401 : for (size_t i = 0; i < output_values.size(); ++i) {
34 [ + - + - ]: 1251 : tx.vout[i].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
35 : 1251 : tx.vout[i].nValue = output_values[i];
36 : : }
37 [ + - ]: 2300 : return MakeTransactionRef(tx);
38 : 1150 : }
39 : :
40 : 102 : static CTransactionRef add_descendants(const CTransactionRef& tx, int32_t num_descendants, CTxMemPool& pool)
41 : : EXCLUSIVE_LOCKS_REQUIRED(::cs_main, pool.cs)
42 : : {
43 : 102 : AssertLockHeld(::cs_main);
44 : 102 : AssertLockHeld(pool.cs);
45 : 102 : TestMemPoolEntryHelper entry;
46 : : // Assumes this isn't already spent in mempool
47 [ + - ]: 102 : auto tx_to_spend = tx;
48 [ + + ]: 1122 : for (int32_t i{0}; i < num_descendants; ++i) {
49 [ + - + - : 4080 : auto next_tx = make_tx(/*inputs=*/{tx_to_spend}, /*output_values=*/{(50 - i) * CENT});
+ + + - +
- - - -
- ]
50 [ + - + - ]: 1020 : TryAddToMempool(pool, entry.FromTx(next_tx));
51 [ + - + - : 2040 : BOOST_CHECK(pool.GetIter(next_tx->GetHash()).has_value());
+ - ]
52 [ + - ]: 1020 : tx_to_spend = next_tx;
53 : 1020 : }
54 : : // Return last created tx
55 : 102 : return tx_to_spend;
56 [ + - + - ]: 2040 : }
57 : :
58 [ + - + - : 7 : BOOST_FIXTURE_TEST_CASE(rbf_helper_functions, TestChain100Setup)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
59 : : {
60 [ - + ]: 1 : CTxMemPool& pool = *Assert(m_node.mempool);
61 [ + - ]: 1 : LOCK2(::cs_main, pool.cs);
62 : 1 : TestMemPoolEntryHelper entry;
63 : :
64 : 1 : const CAmount low_fee{CENT/100};
65 : 1 : const CAmount normal_fee{CENT/10};
66 : 1 : const CAmount high_fee{CENT};
67 : :
68 : : // Create a parent tx1 and child tx2 with normal fees:
69 [ + - + - : 4 : const auto tx1 = make_tx(/*inputs=*/ {m_coinbase_txns[0]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
70 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx1));
71 [ + - + - : 4 : const auto tx2 = make_tx(/*inputs=*/ {tx1}, /*output_values=*/ {995 * CENT});
+ + + - +
- - - -
- ]
72 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx2));
73 : :
74 : : // Create a low-feerate parent tx3 and high-feerate child tx4 (cpfp)
75 [ + - + - : 4 : const auto tx3 = make_tx(/*inputs=*/ {m_coinbase_txns[1]}, /*output_values=*/ {1099 * CENT});
+ - + + +
- + - - -
- - ]
76 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(tx3));
77 [ + - + - : 4 : const auto tx4 = make_tx(/*inputs=*/ {tx3}, /*output_values=*/ {999 * CENT});
+ + + - +
- - - -
- ]
78 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(high_fee).FromTx(tx4));
79 : :
80 : : // Create a parent tx5 and child tx6 where both have very low fees
81 [ + - + - : 4 : const auto tx5 = make_tx(/*inputs=*/ {m_coinbase_txns[2]}, /*output_values=*/ {1099 * CENT});
+ - + + +
- + - - -
- - ]
82 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(tx5));
83 [ + - + - : 4 : const auto tx6 = make_tx(/*inputs=*/ {tx5}, /*output_values=*/ {1098 * CENT});
+ + + - +
- - - -
- ]
84 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(tx6));
85 : : // Make tx6's modified fee much higher than its base fee. This should cause it to pass
86 : : // the fee-related checks despite being low-feerate.
87 [ + - ]: 1 : pool.PrioritiseTransaction(tx6->GetHash(), 1 * COIN);
88 : :
89 : : // Two independent high-feerate transactions, tx7 and tx8
90 [ + - + - : 4 : const auto tx7 = make_tx(/*inputs=*/ {m_coinbase_txns[3]}, /*output_values=*/ {999 * CENT});
+ - + + +
- + - - -
- - ]
91 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(high_fee).FromTx(tx7));
92 [ + - + - : 4 : const auto tx8 = make_tx(/*inputs=*/ {m_coinbase_txns[4]}, /*output_values=*/ {999 * CENT});
+ - + + +
- + - - -
- - ]
93 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(high_fee).FromTx(tx8));
94 : :
95 : : // Will make these two parents of single child
96 [ + - + - : 4 : const auto tx11 = make_tx(/*inputs=*/ {m_coinbase_txns[7]}, /*output_values=*/ {995 * CENT});
+ - + + +
- + - - -
- - ]
97 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx11));
98 [ + - + - : 4 : const auto tx12 = make_tx(/*inputs=*/ {m_coinbase_txns[8]}, /*output_values=*/ {995 * CENT});
+ - + + +
- + - - -
- - ]
99 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx12));
100 : :
101 : : // Will make two children of this single parent
102 [ + - + - : 4 : const auto tx13 = make_tx(/*inputs=*/ {m_coinbase_txns[9]}, /*output_values=*/ {995 * CENT, 995 * CENT});
+ - + + +
- + - - -
- - ]
103 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx13));
104 : :
105 [ + - ]: 1 : const auto entry1_normal = pool.GetIter(tx1->GetHash()).value();
106 [ + - ]: 1 : const auto entry2_normal = pool.GetIter(tx2->GetHash()).value();
107 [ + - ]: 1 : const auto entry3_low = pool.GetIter(tx3->GetHash()).value();
108 [ + - ]: 1 : const auto entry4_high = pool.GetIter(tx4->GetHash()).value();
109 [ + - ]: 1 : const auto entry5_low = pool.GetIter(tx5->GetHash()).value();
110 [ + - ]: 1 : const auto entry6_low_prioritised = pool.GetIter(tx6->GetHash()).value();
111 [ + - ]: 1 : const auto entry7_high = pool.GetIter(tx7->GetHash()).value();
112 [ + - ]: 1 : const auto entry8_high = pool.GetIter(tx8->GetHash()).value();
113 : :
114 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry1_normal->GetFee(), normal_fee);
115 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry2_normal->GetFee(), normal_fee);
116 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry3_low->GetFee(), low_fee);
117 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry4_high->GetFee(), high_fee);
118 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry5_low->GetFee(), low_fee);
119 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry6_low_prioritised->GetFee(), low_fee);
120 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry7_high->GetFee(), high_fee);
121 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(entry8_high->GetFee(), high_fee);
122 : :
123 [ + - ]: 1 : CTxMemPool::setEntries set_12_normal{entry1_normal, entry2_normal};
124 : 1 : CTxMemPool::setEntries empty_set;
125 : :
126 [ + - ]: 1 : const auto unused_txid = Txid::FromUint256(GetRandHash());
127 : :
128 : : // Tests for EntriesAndTxidsDisjoint
129 [ + - + - : 2 : BOOST_CHECK(EntriesAndTxidsDisjoint(empty_set, {tx1->GetHash()}, unused_txid) == std::nullopt);
+ - + - +
- ]
130 [ + - + - : 2 : BOOST_CHECK(EntriesAndTxidsDisjoint(set_12_normal, {tx3->GetHash()}, unused_txid) == std::nullopt);
+ - + - +
- ]
131 [ + - + - : 2 : BOOST_CHECK(EntriesAndTxidsDisjoint({entry2_normal}, {tx2->GetHash()}, unused_txid).has_value());
+ - + - +
- + - ]
132 [ + - + - : 2 : BOOST_CHECK(EntriesAndTxidsDisjoint(set_12_normal, {tx1->GetHash()}, unused_txid).has_value());
+ - + - +
- ]
133 [ + - + - : 2 : BOOST_CHECK(EntriesAndTxidsDisjoint(set_12_normal, {tx2->GetHash()}, unused_txid).has_value());
+ - + - +
- ]
134 : : // EntriesAndTxidsDisjoint does not calculate descendants of iters_conflicting; it uses whatever
135 : : // the caller passed in. As such, no error is returned even though entry2_normal is a descendant of tx1.
136 [ + - + - : 2 : BOOST_CHECK(EntriesAndTxidsDisjoint({entry2_normal}, {tx1->GetHash()}, unused_txid) == std::nullopt);
+ - + - +
- + - ]
137 : :
138 : : // Tests for PaysForRBF
139 : 1 : const CFeeRate incremental_relay_feerate{DEFAULT_INCREMENTAL_RELAY_FEE};
140 : 1 : const CFeeRate higher_relay_feerate{2 * DEFAULT_INCREMENTAL_RELAY_FEE};
141 : : // Must pay at least as much as the original.
142 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(/*original_fees=*/high_fee,
+ - + - ]
143 : : /*replacement_fees=*/high_fee,
144 : : /*replacement_vsize=*/1,
145 : : /*relay_fee=*/CFeeRate(0),
146 : : /*txid=*/unused_txid)
147 : : == std::nullopt);
148 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(high_fee, high_fee - 1, 1, CFeeRate(0), unused_txid).has_value());
+ - + - ]
149 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(high_fee + 1, high_fee, 1, CFeeRate(0), unused_txid).has_value());
+ - + - ]
150 : : // Additional fees must cover the replacement's vsize at incremental relay fee
151 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(high_fee, high_fee + 1, 11, incremental_relay_feerate, unused_txid).has_value());
+ - + - ]
152 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(high_fee, high_fee + 1, 10, incremental_relay_feerate, unused_txid) == std::nullopt);
+ - + - ]
153 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(high_fee, high_fee + 2, 11, higher_relay_feerate, unused_txid).has_value());
+ - + - ]
154 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(high_fee, high_fee + 4, 20, higher_relay_feerate, unused_txid) == std::nullopt);
+ - + - ]
155 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(low_fee, high_fee, 99999999, incremental_relay_feerate, unused_txid).has_value());
+ - + - ]
156 [ + - + - : 2 : BOOST_CHECK(PaysForRBF(low_fee, high_fee + 99999999, 99999999, incremental_relay_feerate, unused_txid) == std::nullopt);
+ - ]
157 [ + - + - : 28 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - +
- ]
158 : :
159 [ + - + - : 7 : BOOST_FIXTURE_TEST_CASE(rbf_conflicts_calculator, TestChain100Setup)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
160 : : {
161 [ - + ]: 1 : CTxMemPool& pool = *Assert(m_node.mempool);
162 [ + - ]: 1 : LOCK2(::cs_main, pool.cs);
163 : 1 : TestMemPoolEntryHelper entry;
164 : :
165 : 1 : const CAmount normal_fee{CENT/10};
166 : :
167 : : // Create two parent transactions with 51 outputs each
168 : 1 : const int NUM_OUTPUTS = 51;
169 : 1 : std::vector<CAmount> output_values;
170 [ + - ]: 1 : output_values.reserve(NUM_OUTPUTS);
171 [ + + ]: 52 : for (int i = 0; i < NUM_OUTPUTS; ++i) {
172 [ + - ]: 51 : output_values.push_back(1 * COIN);
173 : : }
174 : :
175 [ + - + - : 3 : const auto parent_tx_1 = make_tx(/*inputs=*/ {m_coinbase_txns[0]}, /*output_values=*/ output_values);
+ + + - +
- - - - -
- - ]
176 [ + - + - : 3 : const auto parent_tx_2 = make_tx(/*inputs=*/ {m_coinbase_txns[1]}, /*output_values=*/ output_values);
+ + + - -
- - - ]
177 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(parent_tx_1));
178 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(parent_tx_2));
179 : :
180 : 1 : std::vector<CTransactionRef> direct_children;
181 : :
182 : : // Create individual spends of these outputs
183 [ + - + - : 9 : for (const auto& parent_tx : {parent_tx_1, parent_tx_2}) {
+ + + - -
- ]
184 [ + + ]: 104 : for (auto i = 0; i < NUM_OUTPUTS; ++i) {
185 [ + - + - : 408 : auto pretx = make_tx(/*inputs=*/ {parent_tx}, /*output_values=*/ {995 * CENT});
+ + + - +
- - - -
- ]
186 [ + - ]: 102 : CMutableTransaction tx(*pretx);
187 [ + - ]: 102 : tx.vin[0].prevout.n = i;
188 [ + - + - ]: 102 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx));
189 [ + - + - : 204 : BOOST_CHECK(pool.GetIter(tx.GetHash()).has_value());
+ - + - +
- ]
190 [ + - + - : 204 : direct_children.push_back(MakeTransactionRef(tx));
- + ]
191 [ + - ]: 204 : }
192 [ + + - - ]: 3 : }
193 : :
194 : : // At this point, we should have 2 clusters in the mempool, each with 52
195 : : // transactions.
196 : :
197 : : // parent_tx and all children are in one cluster, so we can have as many
198 : : // conflicts within this cluster as we want without violating the RBF conflicts
199 : : // limit.
200 [ + - ]: 1 : const auto parent_entry_1 = pool.GetIter(parent_tx_1->GetHash()).value();
201 [ + - ]: 1 : const auto parent_entry_2 = pool.GetIter(parent_tx_2->GetHash()).value();
202 [ + - + - : 5 : const auto conflicting_transaction = make_tx({parent_tx_1, parent_tx_2}, {50 * CENT});
+ + + - +
- - - -
- ]
203 [ + - ]: 1 : CTxMemPool::setEntries all_conflicts, dummy;
204 [ + - + - : 2 : BOOST_CHECK(GetEntriesForConflicts(/*tx=*/ *conflicting_transaction.get(),
+ - + - ]
205 : : /*pool=*/ pool,
206 : : /*iters_conflicting=*/ {parent_entry_1, parent_entry_2},
207 : : /*all_conflicts=*/ all_conflicts) == std::nullopt);
208 : :
209 : 1 : dummy.clear();
210 : : // Conflicting directly with all those conflicts doesn't change anything.
211 [ + - + - : 2 : BOOST_CHECK(GetEntriesForConflicts(/*tx=*/ *conflicting_transaction.get(),
+ - + - ]
212 : : /*pool=*/ pool,
213 : : /*iters_conflicting=*/ all_conflicts,
214 : : /*all_conflicts=*/ dummy) == std::nullopt);
215 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(all_conflicts.size(), dummy.size());
216 : 1 : dummy.clear();
217 : :
218 : : // If we mine the parent_tx's, then the clusters split (102 clusters).
219 [ + - + + : 3 : pool.removeForBlock({parent_tx_1, parent_tx_2});
+ - - - -
- ]
220 : :
221 : : // Add some descendants now to each of the direct children (we can do this now that the clusters have split).
222 [ + + ]: 103 : for (const auto& child : direct_children) {
223 [ + - ]: 204 : add_descendants(child, 10, pool);
224 : : }
225 : :
226 : : // We can conflict with 100 different clusters, even if they have lots of transactions.
227 : 1 : CTxMemPool::setEntries conflicts;
228 [ + + ]: 101 : for (auto i = 0; i < 100; ++i) {
229 [ + - + - ]: 200 : conflicts.insert(pool.GetIter(direct_children[i]->GetHash()).value());
230 : : }
231 [ + - + - : 2 : BOOST_CHECK(GetEntriesForConflicts(/*tx=*/ *conflicting_transaction.get(),
+ - + - ]
232 : : /*pool=*/ pool,
233 : : /*iters_conflicting=*/ conflicts,
234 : : /*all_conflicts=*/ dummy) == std::nullopt);
235 : :
236 : : // Conflicting with 1 more distinct cluster causes failure, however.
237 [ + - + - ]: 2 : conflicts.insert(pool.GetIter(direct_children[100]->GetHash()).value());
238 [ + - + - : 2 : BOOST_CHECK(GetEntriesForConflicts(/*tx=*/ *conflicting_transaction.get(),
+ - ]
239 : : /*pool=*/ pool,
240 : : /*iters_conflicting=*/ conflicts,
241 : : /*all_conflicts=*/ dummy).has_value());
242 [ + - + - : 218 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
243 : :
244 [ + - + - : 7 : BOOST_FIXTURE_TEST_CASE(improves_feerate, TestChain100Setup)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
245 : : {
246 [ - + ]: 1 : CTxMemPool& pool = *Assert(m_node.mempool);
247 [ + - ]: 1 : LOCK2(::cs_main, pool.cs);
248 : 1 : TestMemPoolEntryHelper entry;
249 : :
250 : 1 : const CAmount low_fee{CENT/100};
251 : 1 : const CAmount normal_fee{CENT/10};
252 : :
253 : : // low feerate parent with normal feerate child
254 [ + - + - : 5 : const auto tx1 = make_tx(/*inputs=*/ {m_coinbase_txns[0], m_coinbase_txns[1]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
255 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(tx1));
256 [ + - + - : 4 : const auto tx2 = make_tx(/*inputs=*/ {tx1}, /*output_values=*/ {995 * CENT});
+ + + - +
- - - -
- ]
257 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx2));
258 : :
259 [ + - ]: 1 : const auto entry1 = pool.GetIter(tx1->GetHash()).value();
260 [ + - ]: 1 : const auto tx1_fee = entry1->GetModifiedFee();
261 [ + - ]: 1 : const auto entry2 = pool.GetIter(tx2->GetHash()).value();
262 [ + - ]: 1 : const auto tx2_fee = entry2->GetModifiedFee();
263 : :
264 : : // conflicting transactions
265 [ + - + - : 5 : const auto tx1_conflict = make_tx(/*inputs=*/ {m_coinbase_txns[0], m_coinbase_txns[2]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
266 [ + - + - : 4 : const auto tx3 = make_tx(/*inputs=*/ {tx1_conflict}, /*output_values=*/ {995 * CENT});
+ + + - +
- - - -
- ]
267 [ + - ]: 1 : auto entry3 = entry.FromTx(tx3);
268 : :
269 : : // Now test ImprovesFeerateDiagram with various levels of "package rbf" feerates
270 : :
271 : : // It doesn't improve itself
272 : 1 : {
273 [ + - ]: 1 : auto changeset{pool.GetChangeSet()};
274 [ + - ]: 1 : changeset->StageRemoval(entry1);
275 [ + - ]: 1 : changeset->StageRemoval(entry2);
276 [ + - ]: 1 : changeset->StageAddition(tx1_conflict, tx1_fee, 0, 1, 0, false, 4, LockPoints());
277 [ + - ]: 1 : changeset->StageAddition(tx3, tx2_fee, 0, 1, 0, false, 4, LockPoints());
278 [ + - ]: 1 : const auto res1 = ImprovesFeerateDiagram(*changeset);
279 [ + - + - : 2 : BOOST_CHECK(res1.has_value());
+ - ]
280 [ + - + - : 2 : BOOST_CHECK(res1.value().first == DiagramCheckError::FAILURE);
+ - + - ]
281 [ + - + - : 2 : BOOST_CHECK(res1.value().second == "insufficient feerate: does not improve feerate diagram");
+ - ]
282 : 1 : }
283 : :
284 : : // With one more satoshi it does
285 : 1 : {
286 [ + - ]: 1 : auto changeset{pool.GetChangeSet()};
287 [ + - ]: 1 : changeset->StageRemoval(entry1);
288 [ + - ]: 1 : changeset->StageRemoval(entry2);
289 [ + - ]: 1 : changeset->StageAddition(tx1_conflict, tx1_fee + 1, 0, 1, 0, false, 4, LockPoints());
290 [ + - ]: 1 : changeset->StageAddition(tx3, tx2_fee, 0, 1, 0, false, 4, LockPoints());
291 [ + - + - : 2 : BOOST_CHECK(ImprovesFeerateDiagram(*changeset) == std::nullopt);
+ - ]
292 : 0 : }
293 : :
294 : : // With prioritisation of in-mempool conflicts, it affects the results of the comparison using the same args as just above
295 [ + - + - ]: 2 : pool.PrioritiseTransaction(entry1->GetSharedTx()->GetHash(), /*nFeeDelta=*/1);
296 : 1 : {
297 [ + - ]: 1 : auto changeset{pool.GetChangeSet()};
298 [ + - ]: 1 : changeset->StageRemoval(entry1);
299 [ + - ]: 1 : changeset->StageRemoval(entry2);
300 [ + - ]: 1 : changeset->StageAddition(tx1_conflict, tx1_fee + 1, 0, 1, 0, false, 4, LockPoints());
301 [ + - ]: 1 : changeset->StageAddition(tx3, tx2_fee, 0, 1, 0, false, 4, LockPoints());
302 [ + - ]: 1 : const auto res2 = ImprovesFeerateDiagram(*changeset);
303 [ + - + - : 2 : BOOST_CHECK(res2.has_value());
+ - ]
304 [ + - + - : 2 : BOOST_CHECK(res2.value().first == DiagramCheckError::FAILURE);
+ - + - ]
305 [ + - + - : 2 : BOOST_CHECK(res2.value().second == "insufficient feerate: does not improve feerate diagram");
+ - ]
306 : 1 : }
307 [ + - + - ]: 2 : pool.PrioritiseTransaction(entry1->GetSharedTx()->GetHash(), /*nFeeDelta=*/-1);
308 : :
309 : : // With fewer vbytes it does
310 [ + - ]: 1 : CMutableTransaction tx4{entry3.GetTx()};
311 : 1 : tx4.vin[0].scriptWitness = CScriptWitness(); // Clear out the witness, to reduce size
312 [ + - + - ]: 2 : auto entry4 = entry.FromTx(MakeTransactionRef(tx4));
313 : 1 : {
314 [ + - ]: 1 : auto changeset{pool.GetChangeSet()};
315 [ + - ]: 1 : changeset->StageRemoval(entry1);
316 [ + - ]: 1 : changeset->StageRemoval(entry2);
317 [ + - ]: 1 : changeset->StageAddition(tx1_conflict, tx1_fee, 0, 1, 0, false, 4, LockPoints());
318 [ + - + - ]: 2 : changeset->StageAddition(entry4.GetSharedTx(), tx2_fee, 0, 1, 0, false, 4, LockPoints());
319 [ + - + - : 2 : BOOST_CHECK(ImprovesFeerateDiagram(*changeset) == std::nullopt);
+ - ]
320 : 0 : }
321 : :
322 : : // Adding a grandchild makes the cluster size 3, which is also calculable
323 [ + - + - : 4 : const auto tx5 = make_tx(/*inputs=*/{tx2}, /*output_values=*/{995 * CENT});
+ + + - +
- - - -
- ]
324 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(normal_fee).FromTx(tx5));
325 [ + - ]: 1 : const auto entry5 = pool.GetIter(tx5->GetHash()).value();
326 : 1 : {
327 [ + - ]: 1 : auto changeset{pool.GetChangeSet()};
328 [ + - ]: 1 : changeset->StageRemoval(entry1);
329 [ + - ]: 1 : changeset->StageRemoval(entry2);
330 [ + - ]: 1 : changeset->StageRemoval(entry5);
331 [ + - ]: 1 : changeset->StageAddition(tx1_conflict, tx1_fee, 0, 1, 0, false, 4, LockPoints());
332 [ + - + - ]: 2 : changeset->StageAddition(entry4.GetSharedTx(), tx2_fee + entry5->GetModifiedFee() + 1, 0, 1, 0, false, 4, LockPoints());
333 [ + - ]: 1 : const auto res3 = ImprovesFeerateDiagram(*changeset);
334 [ + - + - ]: 2 : BOOST_CHECK(res3 == std::nullopt);
335 [ + - ]: 1 : }
336 [ + - + - : 18 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - ]
337 : :
338 [ + - + - : 7 : BOOST_FIXTURE_TEST_CASE(calc_feerate_diagram_rbf, TestChain100Setup)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
339 : : {
340 [ - + ]: 1 : CTxMemPool& pool = *Assert(m_node.mempool);
341 [ + - ]: 1 : LOCK2(::cs_main, pool.cs);
342 : 1 : TestMemPoolEntryHelper entry;
343 : :
344 : 1 : const CAmount low_fee{CENT/100};
345 : 1 : const CAmount high_fee{CENT};
346 : :
347 : : // low -> high -> medium fee transactions that would result in two chunks together since they
348 : : // are all same size
349 [ + - + - : 4 : const auto low_tx = make_tx(/*inputs=*/ {m_coinbase_txns[0]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
350 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(low_tx));
351 : :
352 [ + - ]: 1 : const auto entry_low = pool.GetIter(low_tx->GetHash()).value();
353 [ + - ]: 1 : const auto low_size = entry_low->GetAdjustedWeight();
354 : :
355 [ + - + - : 4 : const auto replacement_tx = make_tx(/*inputs=*/ {m_coinbase_txns[0]}, /*output_values=*/ {9 * COIN});
+ - + + +
- + - - -
- - ]
356 [ + - ]: 1 : auto entry_replacement = entry.FromTx(replacement_tx);
357 : :
358 : : // Replacement of size 1
359 : 1 : {
360 [ + - ]: 1 : auto changeset = pool.GetChangeSet();
361 [ + - ]: 1 : changeset->StageRemoval(entry_low);
362 [ + - ]: 1 : changeset->StageAddition(replacement_tx, 0, 0, 1, 0, false, 4, LockPoints());
363 [ + - ]: 1 : const auto replace_one{changeset->CalculateChunksForRBF()};
364 [ + - + - : 2 : BOOST_CHECK(replace_one.has_value());
+ - ]
365 [ + - ]: 1 : std::vector<FeeFrac> expected_old_chunks{{low_fee, low_size}};
366 [ + - + - : 2 : BOOST_CHECK(replace_one->first == expected_old_chunks);
+ - ]
367 [ + - + - ]: 1 : std::vector<FeeFrac> expected_new_chunks{{0, entry_replacement.GetAdjustedWeight()}};
368 [ + - + - ]: 2 : BOOST_CHECK(replace_one->second == expected_new_chunks);
369 : 1 : }
370 : :
371 : : // Non-zero replacement fee/size
372 : 1 : {
373 [ + - ]: 1 : auto changeset = pool.GetChangeSet();
374 [ + - ]: 1 : changeset->StageRemoval(entry_low);
375 [ + - ]: 1 : changeset->StageAddition(replacement_tx, high_fee, 0, 1, 0, false, 4, LockPoints());
376 [ + - ]: 1 : const auto replace_one_fee{changeset->CalculateChunksForRBF()};
377 [ + - + - : 2 : BOOST_CHECK(replace_one_fee.has_value());
+ - ]
378 [ + - ]: 1 : std::vector<FeeFrac> expected_old_diagram{{low_fee, low_size}};
379 [ + - + - : 2 : BOOST_CHECK(replace_one_fee->first == expected_old_diagram);
+ - ]
380 [ + - + - ]: 1 : std::vector<FeeFrac> expected_new_diagram{{high_fee, entry_replacement.GetAdjustedWeight()}};
381 [ + - + - ]: 2 : BOOST_CHECK(replace_one_fee->second == expected_new_diagram);
382 : 1 : }
383 : :
384 : : // Add a second transaction to the cluster that will make a single chunk, to be evicted in the RBF
385 [ + - + - : 4 : const auto high_tx = make_tx(/*inputs=*/ {low_tx}, /*output_values=*/ {995 * CENT});
+ + + - +
- - - -
- ]
386 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(high_fee).FromTx(high_tx));
387 [ + - ]: 1 : const auto entry_high = pool.GetIter(high_tx->GetHash()).value();
388 [ + - ]: 1 : const auto high_size = entry_high->GetAdjustedWeight();
389 : :
390 : 1 : {
391 [ + - ]: 1 : auto changeset = pool.GetChangeSet();
392 [ + - ]: 1 : changeset->StageRemoval(entry_low);
393 [ + - ]: 1 : changeset->StageRemoval(entry_high);
394 [ + - ]: 1 : changeset->StageAddition(replacement_tx, high_fee, 0, 1, 0, false, 4, LockPoints());
395 [ + - ]: 1 : const auto replace_single_chunk{changeset->CalculateChunksForRBF()};
396 [ + - + - : 2 : BOOST_CHECK(replace_single_chunk.has_value());
+ - ]
397 [ + - ]: 1 : std::vector<FeeFrac> expected_old_chunks{{low_fee + high_fee, low_size + high_size}};
398 [ + - + - : 2 : BOOST_CHECK(replace_single_chunk->first == expected_old_chunks);
+ - ]
399 [ + - + - ]: 1 : std::vector<FeeFrac> expected_new_chunks{{high_fee, entry_replacement.GetAdjustedWeight()}};
400 [ + - + - ]: 2 : BOOST_CHECK(replace_single_chunk->second == expected_new_chunks);
401 : 1 : }
402 : :
403 : : // Conflict with the 2nd tx, resulting in new diagram with three entries
404 : 1 : {
405 [ + - ]: 1 : auto changeset = pool.GetChangeSet();
406 [ + - ]: 1 : changeset->StageRemoval(entry_high);
407 [ + - ]: 1 : changeset->StageAddition(replacement_tx, high_fee, 0, 1, 0, false, 4, LockPoints());
408 [ + - ]: 1 : const auto replace_cpfp_child{changeset->CalculateChunksForRBF()};
409 [ + - + - : 2 : BOOST_CHECK(replace_cpfp_child.has_value());
+ - ]
410 [ + - ]: 1 : std::vector<FeeFrac> expected_old_chunks{{low_fee + high_fee, low_size + high_size}};
411 [ + - + - : 2 : BOOST_CHECK(replace_cpfp_child->first == expected_old_chunks);
+ - ]
412 [ + - + - ]: 1 : std::vector<FeeFrac> expected_new_chunks{{high_fee, entry_replacement.GetAdjustedWeight()}, {low_fee, low_size}};
413 [ + - + - ]: 2 : BOOST_CHECK(replace_cpfp_child->second == expected_new_chunks);
414 : 1 : }
415 : :
416 : : // Make a size 2 cluster that is itself two chunks; evict both txns
417 [ + - + - : 4 : const auto high_tx_2 = make_tx(/*inputs=*/ {m_coinbase_txns[1]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
418 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(high_fee).FromTx(high_tx_2));
419 [ + - ]: 1 : const auto entry_high_2 = pool.GetIter(high_tx_2->GetHash()).value();
420 [ + - ]: 1 : const auto high_size_2 = entry_high_2->GetAdjustedWeight();
421 : :
422 [ + - + - : 4 : const auto low_tx_2 = make_tx(/*inputs=*/ {high_tx_2}, /*output_values=*/ {9 * COIN});
+ + + - +
- - - -
- ]
423 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(low_tx_2));
424 [ + - ]: 1 : const auto entry_low_2 = pool.GetIter(low_tx_2->GetHash()).value();
425 [ + - ]: 1 : const auto low_size_2 = entry_low_2->GetAdjustedWeight();
426 : :
427 : 1 : {
428 [ + - ]: 1 : auto changeset = pool.GetChangeSet();
429 [ + - ]: 1 : changeset->StageRemoval(entry_high_2);
430 [ + - ]: 1 : changeset->StageRemoval(entry_low_2);
431 [ + - ]: 1 : changeset->StageAddition(replacement_tx, high_fee, 0, 1, 0, false, 4, LockPoints());
432 [ + - ]: 1 : const auto replace_two_chunks_single_cluster{changeset->CalculateChunksForRBF()};
433 [ + - + - : 2 : BOOST_CHECK(replace_two_chunks_single_cluster.has_value());
+ - ]
434 [ + - ]: 1 : std::vector<FeeFrac> expected_old_chunks{{high_fee, high_size_2}, {low_fee, low_size_2}};
435 [ + - + - : 2 : BOOST_CHECK(replace_two_chunks_single_cluster->first == expected_old_chunks);
+ - ]
436 [ + - ]: 1 : std::vector<FeeFrac> expected_new_chunks{{high_fee, low_size_2}};
437 [ + - + - ]: 2 : BOOST_CHECK(replace_two_chunks_single_cluster->second == expected_new_chunks);
438 : 1 : }
439 : :
440 : : // You can have more than two direct conflicts
441 [ + - + - : 4 : const auto conflict_1 = make_tx(/*inputs=*/ {m_coinbase_txns[2]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
442 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(conflict_1));
443 [ + - ]: 1 : const auto conflict_1_entry = pool.GetIter(conflict_1->GetHash()).value();
444 : :
445 [ + - + - : 4 : const auto conflict_2 = make_tx(/*inputs=*/ {m_coinbase_txns[3]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
446 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(conflict_2));
447 [ + - ]: 1 : const auto conflict_2_entry = pool.GetIter(conflict_2->GetHash()).value();
448 : :
449 [ + - + - : 4 : const auto conflict_3 = make_tx(/*inputs=*/ {m_coinbase_txns[4]}, /*output_values=*/ {10 * COIN});
+ - + + +
- + - - -
- - ]
450 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(conflict_3));
451 [ + - ]: 1 : const auto conflict_3_entry = pool.GetIter(conflict_3->GetHash()).value();
452 : :
453 : 1 : {
454 [ + - ]: 1 : auto changeset = pool.GetChangeSet();
455 [ + - ]: 1 : changeset->StageRemoval(conflict_1_entry);
456 [ + - ]: 1 : changeset->StageRemoval(conflict_2_entry);
457 [ + - ]: 1 : changeset->StageRemoval(conflict_3_entry);
458 [ + - ]: 1 : changeset->StageAddition(replacement_tx, high_fee, 0, 1, 0, false, 4, LockPoints());
459 [ + - ]: 1 : const auto replace_multiple_clusters{changeset->CalculateChunksForRBF()};
460 [ + - + - : 2 : BOOST_CHECK(replace_multiple_clusters.has_value());
+ - ]
461 [ + - - + : 2 : BOOST_CHECK(replace_multiple_clusters->first.size() == 3);
+ - + - ]
462 [ + - - + : 2 : BOOST_CHECK(replace_multiple_clusters->second.size() == 1);
+ - ]
463 : 1 : }
464 : :
465 : : // Add a child transaction to conflict_1 and make it cluster size 2, two chunks due to same feerate
466 [ + - + - : 4 : const auto conflict_1_child = make_tx(/*inputs=*/{conflict_1}, /*output_values=*/ {995 * CENT});
+ + + - +
- - - -
- ]
467 [ + - + - ]: 1 : TryAddToMempool(pool, entry.Fee(low_fee).FromTx(conflict_1_child));
468 [ + - ]: 1 : const auto conflict_1_child_entry = pool.GetIter(conflict_1_child->GetHash()).value();
469 : :
470 : 1 : {
471 [ + - ]: 1 : auto changeset = pool.GetChangeSet();
472 [ + - ]: 1 : changeset->StageRemoval(conflict_1_entry);
473 [ + - ]: 1 : changeset->StageRemoval(conflict_2_entry);
474 [ + - ]: 1 : changeset->StageRemoval(conflict_3_entry);
475 [ + - ]: 1 : changeset->StageRemoval(conflict_1_child_entry);
476 [ + - ]: 1 : changeset->StageAddition(replacement_tx, high_fee, 0, 1, 0, false, 4, LockPoints());
477 [ + - ]: 1 : const auto replace_multiple_clusters_2{changeset->CalculateChunksForRBF()};
478 : :
479 [ + - + - : 2 : BOOST_CHECK(replace_multiple_clusters_2.has_value());
+ - ]
480 [ + - - + : 2 : BOOST_CHECK(replace_multiple_clusters_2->first.size() == 4);
+ - + - ]
481 [ + - - + : 2 : BOOST_CHECK(replace_multiple_clusters_2->second.size() == 1);
+ - ]
482 [ + - ]: 1 : }
483 [ + - + - : 23 : }
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - +
- ]
484 : :
485 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(feerate_chunks_utilities)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
486 : : {
487 : : // Sanity check the correctness of the feerate chunks comparison.
488 : :
489 : : // A strictly better case.
490 : 1 : std::vector<FeeFrac> old_chunks{{{950, 300}, {100, 100}}};
491 [ + - ]: 1 : std::vector<FeeFrac> new_chunks{{{1000, 300}, {50, 100}}};
492 : :
493 [ + - - + : 2 : BOOST_CHECK(std::is_lt(CompareChunks(old_chunks, new_chunks)));
- + + - +
- + - ]
494 [ + - - + : 2 : BOOST_CHECK(std::is_gt(CompareChunks(new_chunks, old_chunks)));
- + + - +
- + - ]
495 : :
496 : : // Incomparable diagrams
497 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 100}};
498 [ + - ]: 1 : new_chunks = {{1000, 300}, {0, 100}};
499 : :
500 [ + - - + : 3 : BOOST_CHECK(CompareChunks(old_chunks, new_chunks) == std::partial_ordering::unordered);
- + + - +
- + - ]
501 [ + - - + : 3 : BOOST_CHECK(CompareChunks(new_chunks, old_chunks) == std::partial_ordering::unordered);
- + + - +
- + - ]
502 : :
503 : : // Strictly better but smaller size.
504 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 100}};
505 [ + - ]: 1 : new_chunks = {{1100, 300}};
506 : :
507 [ + - - + : 2 : BOOST_CHECK(std::is_lt(CompareChunks(old_chunks, new_chunks)));
- + + - +
- + - ]
508 [ + - - + : 2 : BOOST_CHECK(std::is_gt(CompareChunks(new_chunks, old_chunks)));
- + + - +
- + - ]
509 : :
510 : : // New diagram is strictly better due to the first chunk, even though
511 : : // second chunk contributes no fees
512 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 100}};
513 [ + - ]: 1 : new_chunks = {{1100, 100}, {0, 100}};
514 : :
515 [ + - - + : 2 : BOOST_CHECK(std::is_lt(CompareChunks(old_chunks, new_chunks)));
- + + - +
- + - ]
516 [ + - - + : 2 : BOOST_CHECK(std::is_gt(CompareChunks(new_chunks, old_chunks)));
- + + - +
- + - ]
517 : :
518 : : // Feerate of first new chunk is better with, but second chunk is worse
519 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 100}};
520 [ + - ]: 1 : new_chunks = {{750, 100}, {249, 250}, {151, 650}};
521 : :
522 [ + - - + : 3 : BOOST_CHECK(CompareChunks(old_chunks, new_chunks) == std::partial_ordering::unordered);
- + + - +
- + - ]
523 [ + - - + : 3 : BOOST_CHECK(CompareChunks(new_chunks, old_chunks) == std::partial_ordering::unordered);
- + + - +
- + - ]
524 : :
525 : : // If we make the second chunk slightly better, the new diagram now wins.
526 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 100}};
527 [ + - ]: 1 : new_chunks = {{750, 100}, {250, 250}, {150, 150}};
528 : :
529 [ + - - + : 2 : BOOST_CHECK(std::is_lt(CompareChunks(old_chunks, new_chunks)));
- + + - +
- + - ]
530 [ + - - + : 2 : BOOST_CHECK(std::is_gt(CompareChunks(new_chunks, old_chunks)));
- + + - +
- + - ]
531 : :
532 : : // Identical diagrams, cannot be strictly better
533 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 100}};
534 [ + - ]: 1 : new_chunks = {{950, 300}, {100, 100}};
535 : :
536 [ + - - + : 2 : BOOST_CHECK(std::is_eq(CompareChunks(old_chunks, new_chunks)));
- + + - +
- + - ]
537 [ + - - + : 2 : BOOST_CHECK(std::is_eq(CompareChunks(new_chunks, old_chunks)));
- + + - +
- + - ]
538 : :
539 : : // Same aggregate fee, but different total size (trigger single tail fee check step)
540 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 99}};
541 [ + - ]: 1 : new_chunks = {{950, 300}, {100, 100}};
542 : :
543 : : // No change in evaluation when tail check needed.
544 [ + - - + : 2 : BOOST_CHECK(std::is_gt(CompareChunks(old_chunks, new_chunks)));
- + + - +
- + - ]
545 [ + - - + : 2 : BOOST_CHECK(std::is_lt(CompareChunks(new_chunks, old_chunks)));
- + + - +
- + - ]
546 : :
547 : : // Trigger multiple tail fee check steps
548 [ + - ]: 1 : old_chunks = {{950, 300}, {100, 99}};
549 [ + - ]: 1 : new_chunks = {{950, 300}, {100, 100}, {0, 1}, {0, 1}};
550 : :
551 [ + - - + : 2 : BOOST_CHECK(std::is_gt(CompareChunks(old_chunks, new_chunks)));
- + + - +
- + - ]
552 [ + - - + : 2 : BOOST_CHECK(std::is_lt(CompareChunks(new_chunks, old_chunks)));
- + + - +
- + - ]
553 : :
554 : : // Multiple tail fee check steps, unordered result
555 [ + - ]: 1 : new_chunks = {{950, 300}, {100, 100}, {0, 1}, {0, 1}, {1, 1}};
556 [ + - - + : 3 : BOOST_CHECK(CompareChunks(old_chunks, new_chunks) == std::partial_ordering::unordered);
- + + - +
- + - ]
557 [ + - - + : 3 : BOOST_CHECK(CompareChunks(new_chunks, old_chunks) == std::partial_ordering::unordered);
- + + - +
- ]
558 : 1 : }
559 : :
560 : : BOOST_AUTO_TEST_SUITE_END()
|
