Branch data Line data Source code
1 : : // Copyright (c) 2011-present The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <addresstype.h>
6 : : #include <chain.h>
7 : : #include <coins.h>
8 : : #include <consensus/amount.h>
9 : : #include <consensus/consensus.h>
10 : : #include <consensus/merkle.h>
11 : : #include <consensus/tx_verify.h>
12 : : #include <interfaces/mining.h>
13 : : #include <interfaces/types.h>
14 : : #include <kernel/chainparams.h>
15 : : #include <node/miner.h>
16 : : #include <node/mining_args.h>
17 : : #include <node/mining_types.h>
18 : : #include <policy/feerate.h>
19 : : #include <policy/policy.h>
20 : : #include <pow.h>
21 : : #include <primitives/block.h>
22 : : #include <primitives/transaction.h>
23 : : #include <random.h>
24 : : #include <script/script.h>
25 : : #include <serialize.h>
26 : : #include <sync.h>
27 : : #include <test/util/common.h>
28 : : #include <test/util/setup_common.h>
29 : : #include <test/util/transaction_utils.h>
30 : : #include <test/util/time.h>
31 : : #include <test/util/txmempool.h>
32 : : #include <txmempool.h>
33 : : #include <uint256.h>
34 : : #include <util/check.h>
35 : : #include <util/feefrac.h>
36 : : #include <util/strencodings.h>
37 : : #include <util/translation.h>
38 : : #include <validation.h>
39 : : #include <versionbits.h>
40 : :
41 : : #include <boost/test/unit_test.hpp>
42 : :
43 : : #include <cstddef>
44 : : #include <cstdint>
45 : : #include <iterator>
46 : : #include <memory>
47 : : #include <optional>
48 : : #include <span>
49 : : #include <stdexcept>
50 : : #include <string>
51 : : #include <vector>
52 : :
53 : : using namespace util::hex_literals;
54 : : using interfaces::BlockTemplate;
55 : : using interfaces::Mining;
56 : : using node::BlockAssembler;
57 : : using node::BlockCreateOptions;
58 : :
59 : : namespace miner_tests {
60 : 2 : struct MinerTestingSetup : public TestingSetup {
61 : : void TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
62 : : void TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
63 : : void TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
64 : 8 : bool TestSequenceLocks(const CTransaction& tx, CTxMemPool& tx_mempool) EXCLUSIVE_LOCKS_REQUIRED(::cs_main)
65 : : {
66 : 8 : CCoinsViewMemPool view_mempool{&m_node.chainman->ActiveChainstate().CoinsTip(), tx_mempool};
67 [ + - - + ]: 8 : CBlockIndex* tip{m_node.chainman->ActiveChain().Tip()};
68 [ + - ]: 8 : const std::optional<LockPoints> lock_points{CalculateLockPointsAtTip(tip, view_mempool, tx)};
69 [ + - + - : 16 : return lock_points.has_value() && CheckSequenceLocksAtTip(tip, *lock_points);
+ + ]
70 : 8 : }
71 : 11 : CTxMemPool& MakeMempool()
72 : : {
73 : : // Delete the previous mempool to ensure with valgrind that the old
74 : : // pointer is not accessed, when the new one should be accessed
75 : : // instead.
76 [ + - ]: 11 : m_node.mempool.reset();
77 [ + - ]: 11 : bilingual_str error;
78 [ + - ]: 11 : auto opts = MemPoolOptionsForTest(m_node);
79 : : // The "block size > limit" test creates a cluster of 1192590 vbytes,
80 : : // so set the cluster vbytes limit big enough so that the txgraph
81 : : // doesn't become oversized.
82 : 11 : opts.limits.cluster_size_vbytes = 1'200'000;
83 [ + - ]: 11 : m_node.mempool = std::make_unique<CTxMemPool>(opts, error);
84 [ - + ]: 11 : Assert(error.empty());
85 : 11 : return *m_node.mempool;
86 : 11 : }
87 : 4 : std::unique_ptr<Mining> MakeMining()
88 : : {
89 : 4 : return interfaces::MakeMining(m_node, /*wait_loaded=*/false);
90 : : }
91 : : };
92 : : } // namespace miner_tests
93 : :
94 : : BOOST_FIXTURE_TEST_SUITE(miner_tests, MinerTestingSetup)
95 : :
96 : : static CFeeRate blockMinFeeRate = CFeeRate(DEFAULT_BLOCK_MIN_TX_FEE);
97 : :
98 : : constexpr static struct {
99 : : unsigned int extranonce;
100 : : unsigned int nonce;
101 : : } BLOCKINFO[]{{0, 3552706918}, {500, 37506755}, {1000, 948987788}, {400, 524762339}, {800, 258510074}, {300, 102309278},
102 : : {1300, 54365202}, {600, 1107740426}, {1000, 203094491}, {900, 391178848}, {800, 381177271}, {600, 87188412},
103 : : {0, 66522866}, {800, 874942736}, {1000, 89200838}, {400, 312638088}, {400, 66263693}, {500, 924648304},
104 : : {400, 369913599}, {500, 47630099}, {500, 115045364}, {100, 277026602}, {1100, 809621409}, {700, 155345322},
105 : : {800, 943579953}, {400, 28200730}, {900, 77200495}, {0, 105935488}, {400, 698721821}, {500, 111098863},
106 : : {1300, 445389594}, {500, 621849894}, {1400, 56010046}, {1100, 370669776}, {1200, 380301940}, {1200, 110654905},
107 : : {400, 213771024}, {1500, 120014726}, {1200, 835019014}, {1500, 624817237}, {900, 1404297}, {400, 189414558},
108 : : {400, 293178348}, {1100, 15393789}, {600, 396764180}, {800, 1387046371}, {800, 199368303}, {700, 111496662},
109 : : {100, 129759616}, {200, 536577982}, {500, 125881300}, {500, 101053391}, {1200, 471590548}, {900, 86957729},
110 : : {1200, 179604104}, {600, 68658642}, {1000, 203295701}, {500, 139615361}, {900, 233693412}, {300, 153225163},
111 : : {0, 27616254}, {1200, 9856191}, {100, 220392722}, {200, 66257599}, {1100, 145489641}, {1300, 37859442},
112 : : {400, 5816075}, {1200, 215752117}, {1400, 32361482}, {1400, 6529223}, {500, 143332977}, {800, 878392},
113 : : {700, 159290408}, {400, 123197595}, {700, 43988693}, {300, 304224916}, {700, 214771621}, {1100, 274148273},
114 : : {400, 285632418}, {1100, 923451065}, {600, 12818092}, {1200, 736282054}, {1000, 246683167}, {600, 92950402},
115 : : {1400, 29223405}, {1000, 841327192}, {700, 174301283}, {1400, 214009854}, {1000, 6989517}, {1200, 278226956},
116 : : {700, 540219613}, {400, 93663104}, {1100, 152345635}, {1500, 464194499}, {1300, 333850111}, {600, 258311263},
117 : : {600, 90173162}, {1000, 33590797}, {1500, 332866027}, {100, 204704427}, {1000, 463153545}, {800, 303244785},
118 : : {600, 88096214}, {0, 137477892}, {1200, 195514506}, {300, 704114595}, {900, 292087369}, {1400, 758684870},
119 : : {1300, 163493028}, {1200, 53151293}};
120 : :
121 : 2 : static std::unique_ptr<CBlockIndex> CreateBlockIndex(int nHeight, CBlockIndex* active_chain_tip) EXCLUSIVE_LOCKS_REQUIRED(cs_main)
122 : : {
123 : 2 : auto index{std::make_unique<CBlockIndex>()};
124 : 2 : index->nHeight = nHeight;
125 : 2 : index->pprev = active_chain_tip;
126 : 2 : return index;
127 : : }
128 : :
129 : : // Test suite for ancestor feerate transaction selection.
130 : : // Implemented as an additional function, rather than a separate test case,
131 : : // to allow reusing the blockchain created in CreateNewBlock_validity.
132 : 1 : void MinerTestingSetup::TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
133 : : {
134 : 1 : CTxMemPool& tx_mempool{MakeMempool()};
135 : 1 : auto mining{MakeMining()};
136 : 1 : BlockCreateOptions options{
137 : : .coinbase_output_script = scriptPubKey,
138 : 1 : };
139 : :
140 [ + - ]: 1 : LOCK(tx_mempool.cs);
141 [ + - + - : 2 : BOOST_CHECK(tx_mempool.size() == 0);
+ - + - ]
142 : :
143 : : // Block template should only have a coinbase when there's nothing in the mempool
144 [ + - ]: 1 : std::unique_ptr<BlockTemplate> block_template = mining->createNewBlock(options, /*cooldown=*/false);
145 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
146 [ + - ]: 1 : CBlock block{block_template->getBlock()};
147 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 1U);
+ - ]
148 : :
149 : : // waitNext() on an empty mempool should return nullptr because there is no better template
150 [ + - ]: 1 : auto should_be_nullptr = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 1});
151 [ + - + - : 2 : BOOST_REQUIRE(should_be_nullptr == nullptr);
+ - ]
152 : :
153 : : // Unless fee_threshold is 0
154 [ + - ]: 2 : block_template = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 0});
155 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
156 : :
157 : : // Test the ancestor feerate transaction selection.
158 : 1 : TestMemPoolEntryHelper entry;
159 : :
160 : : // Test that a medium fee transaction will be selected after a higher fee
161 : : // rate package with a low fee rate parent.
162 [ + - ]: 1 : CMutableTransaction tx;
163 [ + - ]: 1 : tx.vin.resize(1);
164 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
165 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
166 : 1 : tx.vin[0].prevout.n = 0;
167 [ + - ]: 1 : tx.vout.resize(1);
168 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 1000;
169 : : // This tx has a low fee: 1000 satoshis
170 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
171 [ + - ]: 1 : const auto parent_tx{entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
172 [ + - ]: 1 : TryAddToMempool(tx_mempool, parent_tx);
173 : :
174 : : // This tx has a medium fee: 10000 satoshis
175 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
176 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
177 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
178 [ + - ]: 1 : const auto medium_fee_tx{entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
179 [ + - ]: 1 : TryAddToMempool(tx_mempool, medium_fee_tx);
180 : :
181 : : // This tx has a high fee, but depends on the first transaction
182 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
183 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 50k satoshi fee
184 [ + - ]: 1 : Txid hashHighFeeTx = tx.GetHash();
185 [ + - ]: 1 : const auto high_fee_tx{entry.Fee(50000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx)};
186 [ + - ]: 1 : TryAddToMempool(tx_mempool, high_fee_tx);
187 : :
188 [ + - ]: 2 : block_template = mining->createNewBlock(options, /*cooldown=*/false);
189 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
190 [ + - ]: 1 : block = block_template->getBlock();
191 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 4U);
+ - ]
192 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashParentTx);
+ - ]
193 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashHighFeeTx);
+ - ]
194 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashMediumFeeTx);
+ - ]
195 : :
196 : : // Test the inclusion of package feerates in the block template and ensure they are sequential.
197 : : // Can't use the Mining interface because it needs access to m_package_feerates.
198 : 1 : const auto block_package_feerates = BlockAssembler{
199 : : m_node.chainman->ActiveChainstate(),
200 : : &tx_mempool,
201 [ + - ]: 2 : MergeMiningOptions(options, m_node.mining_args),
202 [ + - + - : 2 : }.CreateNewBlock()->m_package_feerates;
+ - + - ]
203 [ + - - + : 2 : BOOST_CHECK(block_package_feerates.size() == 2);
+ - + - ]
204 : :
205 : : // parent_tx and high_fee_tx are added to the block as a package.
206 : 1 : const auto combined_txs_fee = parent_tx.GetFee() + high_fee_tx.GetFee();
207 [ + - + - ]: 1 : const auto combined_txs_size = parent_tx.GetTxSize() + high_fee_tx.GetTxSize();
208 [ + - ]: 1 : FeeFrac package_feefrac{combined_txs_fee, combined_txs_size};
209 : : // The package should be added first.
210 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[0] == package_feefrac);
+ - + - ]
211 : :
212 : : // The medium_fee_tx should be added next.
213 [ + - + - ]: 1 : FeeFrac medium_tx_feefrac{medium_fee_tx.GetFee(), medium_fee_tx.GetTxSize()};
214 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[1] == medium_tx_feefrac);
+ - + - ]
215 : :
216 : : // Test that a package below the block min tx fee doesn't get included
217 [ + - ]: 1 : tx.vin[0].prevout.hash = hashHighFeeTx;
218 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 0 fee
219 [ + - ]: 1 : Txid hashFreeTx = tx.GetHash();
220 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).FromTx(tx));
221 : 1 : uint64_t freeTxSize{::GetSerializeSize(TX_WITH_WITNESS(tx))};
222 : :
223 : : // Calculate a fee on child transaction that will put the package just
224 : : // below the block min tx fee (assuming 1 child tx of the same size).
225 [ + - ]: 1 : CAmount feeToUse = blockMinFeeRate.GetFee(2*freeTxSize) - 1;
226 : :
227 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx;
228 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000 - feeToUse;
229 [ + - ]: 1 : Txid hashLowFeeTx = tx.GetHash();
230 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(feeToUse).FromTx(tx));
231 : :
232 : : // waitNext() should return nullptr because there is no better template
233 [ + - ]: 2 : should_be_nullptr = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 1});
234 [ + - + - : 2 : BOOST_REQUIRE(should_be_nullptr == nullptr);
+ - ]
235 : :
236 [ + - ]: 1 : block = block_template->getBlock();
237 : : // Verify that the free tx and the low fee tx didn't get selected
238 [ - + + + ]: 5 : for (size_t i=0; i<block.vtx.size(); ++i) {
239 [ + - + - : 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx);
+ - ]
240 [ + - + - ]: 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx);
241 : : }
242 : :
243 : : // Test that packages above the min relay fee do get included, even if one
244 : : // of the transactions is below the min relay fee
245 : : // Remove the low fee transaction and replace with a higher fee transaction
246 [ + - + - ]: 1 : tx_mempool.removeRecursive(CTransaction(tx), MemPoolRemovalReason::REPLACED);
247 [ + - ]: 1 : tx.vout[0].nValue -= 2; // Now we should be just over the min relay fee
248 [ + - ]: 1 : hashLowFeeTx = tx.GetHash();
249 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(feeToUse + 2).FromTx(tx));
250 : :
251 : : // waitNext() should return if fees for the new template are at least 1 sat up
252 [ + - ]: 2 : block_template = block_template->waitNext({.fee_threshold = 1});
253 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
254 [ + - ]: 1 : block = block_template->getBlock();
255 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
+ - ]
256 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashFreeTx);
+ - ]
257 [ + - + - : 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashLowFeeTx);
+ - ]
258 : :
259 : : // Test that transaction selection properly updates ancestor fee
260 : : // calculations as ancestor transactions get included in a block.
261 : : // Add a 0-fee transaction that has 2 outputs.
262 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
263 [ + - ]: 1 : tx.vout.resize(2);
264 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000;
265 : 1 : tx.vout[1].nValue = 100000000; // 1BTC output
266 : : // Increase size to avoid rounding errors: when the feerate is extremely small (i.e. 1sat/kvB), evaluating the fee
267 : : // at smaller sizes gives us rounded values that are equal to each other, which means we incorrectly include
268 : : // hashFreeTx2 + hashLowFeeTx2.
269 [ + - ]: 1 : BulkTransaction(tx, 4000);
270 [ + - ]: 1 : Txid hashFreeTx2 = tx.GetHash();
271 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
272 : :
273 : : // This tx can't be mined by itself
274 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx2;
275 [ + - ]: 1 : tx.vout.resize(1);
276 [ + - ]: 1 : feeToUse = blockMinFeeRate.GetFee(freeTxSize);
277 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000 - feeToUse;
278 [ + - ]: 1 : Txid hashLowFeeTx2 = tx.GetHash();
279 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(feeToUse).SpendsCoinbase(false).FromTx(tx));
280 [ + - ]: 2 : block_template = mining->createNewBlock(options, /*cooldown=*/false);
281 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
282 [ + - ]: 1 : block = block_template->getBlock();
283 : :
284 : : // Verify that this tx isn't selected.
285 [ - + + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
286 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx2);
+ - ]
287 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx2);
288 : : }
289 : :
290 : : // This tx will be mineable, and should cause hashLowFeeTx2 to be selected
291 : : // as well.
292 [ + - ]: 1 : tx.vin[0].prevout.n = 1;
293 : 1 : tx.vout[0].nValue = 100000000 - 10000; // 10k satoshi fee
294 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(10000).FromTx(tx));
295 [ + - ]: 2 : block_template = mining->createNewBlock(options, /*cooldown=*/false);
296 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
297 [ + - ]: 1 : block = block_template->getBlock();
298 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 9U);
+ - ]
299 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[8]->GetHash() == hashLowFeeTx2);
300 [ + - ]: 3 : }
301 : :
302 : 2 : std::vector<CTransactionRef> CreateBigSigOpsCluster(const CTransactionRef& first_tx)
303 : : {
304 : 2 : std::vector<CTransactionRef> ret;
305 : :
306 [ + - ]: 2 : CMutableTransaction tx;
307 : : // block sigops > limit: 1000 CHECKMULTISIG + 1
308 [ + - ]: 2 : tx.vin.resize(1);
309 : : // NOTE: OP_NOP is used to force 20 SigOps for the CHECKMULTISIG
310 [ + - + - : 2 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_0 << OP_CHECKSIG << OP_1;
+ - + - ]
311 [ + - ]: 2 : tx.vin[0].prevout.hash = first_tx->GetHash();
312 : 2 : tx.vin[0].prevout.n = 0;
313 [ + - ]: 2 : tx.vout.resize(50);
314 [ + + ]: 102 : for (auto &out : tx.vout) {
315 [ + - ]: 100 : out.nValue = first_tx->vout[0].nValue / 50;
316 [ + - ]: 100 : out.scriptPubKey = CScript() << OP_1;
317 : : }
318 : :
319 [ + - ]: 2 : tx.vout[0].nValue -= CENT;
320 [ + - ]: 2 : CTransactionRef parent_tx = MakeTransactionRef(tx);
321 [ + - ]: 2 : ret.push_back(parent_tx);
322 [ + - + - ]: 2 : assert(GetLegacySigOpCount(*parent_tx) == 1);
323 : :
324 : : // Tx1 has 1 sigops, 1 input, 50 outputs.
325 : : // Tx2-51 has 400 sigops: 1 input, 20 CHECKMULTISIG outputs
326 : : // Total: 1000 CHECKMULTISIG + 1
327 [ + + ]: 102 : for (unsigned int i = 0; i < 50; ++i) {
328 [ + - ]: 100 : auto tx2 = tx;
329 [ + - ]: 100 : tx2.vin.resize(1);
330 [ + - ]: 100 : tx2.vin[0].prevout.hash = parent_tx->GetHash();
331 : 100 : tx2.vin[0].prevout.n = i;
332 [ + - ]: 100 : tx2.vin[0].scriptSig = CScript() << OP_1;
333 [ + - ]: 100 : tx2.vout.resize(20);
334 : 100 : tx2.vout[0].nValue = parent_tx->vout[i].nValue - CENT;
335 [ + + ]: 2100 : for (auto &out : tx2.vout) {
336 : 2000 : out.nValue = 0;
337 [ + - + - : 2000 : out.scriptPubKey = CScript() << OP_0 << OP_0 << OP_0 << OP_NOP << OP_CHECKMULTISIG << OP_1;
+ - + - +
- + - ]
338 : : }
339 [ + - + - : 200 : ret.push_back(MakeTransactionRef(tx2));
- + ]
340 : 100 : }
341 [ + - ]: 2 : return ret;
342 : 4 : }
343 : :
344 : 1 : void MinerTestingSetup::TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight)
345 : : {
346 : 1 : FakeNodeClock clock{};
347 : :
348 [ + - ]: 1 : Txid hash;
349 [ + - ]: 1 : CMutableTransaction tx;
350 : 1 : TestMemPoolEntryHelper entry;
351 : 1 : entry.nFee = 11;
352 : 1 : entry.nHeight = 11;
353 : :
354 : 1 : const CAmount BLOCKSUBSIDY = 50 * COIN;
355 : 1 : const CAmount LOWFEE = CENT;
356 : 1 : const CAmount HIGHFEE = COIN;
357 : 1 : const CAmount HIGHERFEE = 4 * COIN;
358 : :
359 [ + - ]: 1 : auto mining{MakeMining()};
360 [ + - + - ]: 2 : BOOST_REQUIRE(mining);
361 : :
362 : 1 : BlockCreateOptions options{
363 : : .coinbase_output_script = scriptPubKey,
364 : 1 : };
365 : :
366 : 1 : {
367 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
368 [ + - ]: 1 : LOCK(tx_mempool.cs);
369 : :
370 : : // Just to make sure we can still make simple blocks
371 [ + - ]: 1 : auto block_template{mining->createNewBlock(options, /*cooldown=*/false)};
372 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
373 [ + - ]: 1 : CBlock block{block_template->getBlock()};
374 : :
375 [ + - ]: 1 : auto txs = CreateBigSigOpsCluster(txFirst[0]);
376 : :
377 : 1 : int64_t legacy_sigops = 0;
378 [ + + ]: 52 : for (auto& t : txs) {
379 : : // If we don't set the number of sigops in the CTxMemPoolEntry,
380 : : // template creation fails during sanity checks.
381 [ + - + - ]: 51 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(t));
382 [ + - ]: 51 : legacy_sigops += GetLegacySigOpCount(*t);
383 [ + - + - : 102 : BOOST_CHECK(tx_mempool.GetIter(t->GetHash()).has_value());
+ - ]
384 : : }
385 [ - + ]: 1 : assert(tx_mempool.mapTx.size() == 51);
386 [ - + ]: 1 : assert(legacy_sigops == 20001);
387 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("bad-blk-sigops"));
- - - - -
+ + - + -
+ - ]
388 [ + - ]: 1 : }
389 : :
390 : 1 : {
391 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
392 [ + - ]: 1 : LOCK(tx_mempool.cs);
393 : :
394 : : // Check that the mempool is empty.
395 [ - + ]: 1 : assert(tx_mempool.mapTx.empty());
396 : :
397 : : // Just to make sure we can still make simple blocks
398 [ + - ]: 1 : auto block_template{mining->createNewBlock(options, /*cooldown=*/false)};
399 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
400 [ + - ]: 1 : CBlock block{block_template->getBlock()};
401 : :
402 [ + - ]: 1 : auto txs = CreateBigSigOpsCluster(txFirst[0]);
403 : :
404 : 1 : int64_t legacy_sigops = 0;
405 [ + + ]: 52 : for (auto& t : txs) {
406 [ + - + - : 51 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).SigOpsCost(GetLegacySigOpCount(*t)*WITNESS_SCALE_FACTOR).FromTx(t));
+ - ]
407 [ + - ]: 51 : legacy_sigops += GetLegacySigOpCount(*t);
408 [ + - + - : 102 : BOOST_CHECK(tx_mempool.GetIter(t->GetHash()).has_value());
+ - ]
409 : : }
410 [ - + ]: 1 : assert(tx_mempool.mapTx.size() == 51);
411 [ - + ]: 1 : assert(legacy_sigops == 20001);
412 : :
413 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
+ - ]
414 [ + - ]: 1 : }
415 : :
416 : 1 : {
417 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
418 [ + - ]: 1 : LOCK(tx_mempool.cs);
419 : :
420 : : // block size > limit
421 [ + - ]: 1 : tx.vin.resize(1);
422 [ + - ]: 1 : tx.vout.resize(1);
423 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
424 : : // 36 * (520char + DROP) + OP_1 = 18757 bytes
425 [ + - ]: 1 : std::vector<unsigned char> vchData(520);
426 [ + + ]: 19 : for (unsigned int i = 0; i < 18; ++i) {
427 [ - + + - ]: 18 : tx.vin[0].scriptSig << vchData << OP_DROP;
428 [ - + + - ]: 18 : tx.vout[0].scriptPubKey << vchData << OP_DROP;
429 : : }
430 [ + - ]: 1 : tx.vin[0].scriptSig << OP_1;
431 [ + - ]: 1 : tx.vout[0].scriptPubKey << OP_1;
432 : 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
433 : 1 : tx.vin[0].prevout.n = 0;
434 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
435 [ + + ]: 64 : for (unsigned int i = 0; i < 63; ++i) {
436 [ + - ]: 63 : tx.vout[0].nValue -= LOWFEE;
437 [ + - ]: 63 : hash = tx.GetHash();
438 : 63 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
439 [ + - + - ]: 63 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).FromTx(tx));
440 [ + - + - : 126 : BOOST_CHECK(tx_mempool.GetIter(hash).has_value());
+ - ]
441 : 63 : tx.vin[0].prevout.hash = hash;
442 : : }
443 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
+ - ]
444 [ + - ]: 1 : }
445 : :
446 : 1 : {
447 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
448 [ + - ]: 1 : LOCK(tx_mempool.cs);
449 : :
450 : : // orphan in tx_mempool, template creation fails
451 [ + - ]: 1 : hash = tx.GetHash();
452 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).FromTx(tx));
453 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
454 : 0 : }
455 : :
456 : 1 : {
457 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
458 [ + - ]: 1 : LOCK(tx_mempool.cs);
459 : :
460 : : // child with higher feerate than parent
461 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
462 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
463 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
464 [ + - ]: 1 : hash = tx.GetHash();
465 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
466 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
467 [ + - ]: 1 : tx.vin.resize(2);
468 [ + - ]: 1 : tx.vin[1].scriptSig = CScript() << OP_1;
469 [ + - ]: 1 : tx.vin[1].prevout.hash = txFirst[0]->GetHash();
470 : 1 : tx.vin[1].prevout.n = 0;
471 : 1 : tx.vout[0].nValue = tx.vout[0].nValue + BLOCKSUBSIDY - HIGHERFEE; // First txn output + fresh coinbase - new txn fee
472 [ + - ]: 1 : hash = tx.GetHash();
473 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHERFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
474 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
+ - + - ]
475 : 0 : }
476 : :
477 : 1 : {
478 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
479 [ + - ]: 1 : LOCK(tx_mempool.cs);
480 : :
481 : : // coinbase in tx_mempool, template creation fails
482 [ + - ]: 1 : tx.vin.resize(1);
483 : 1 : tx.vin[0].prevout.SetNull();
484 [ + - + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_1;
485 [ + - ]: 1 : tx.vout[0].nValue = 0;
486 [ + - ]: 1 : hash = tx.GetHash();
487 : : // give it a fee so it'll get mined
488 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
489 : : // Should throw bad-cb-multiple
490 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("bad-cb-multiple"));
- - - - +
- - + + -
+ - + - ]
491 : 0 : }
492 : :
493 : 1 : {
494 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
495 [ + - ]: 1 : LOCK(tx_mempool.cs);
496 : :
497 : : // double spend txn pair in tx_mempool, template creation fails
498 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
499 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
500 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
501 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
502 [ + - ]: 1 : hash = tx.GetHash();
503 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
504 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_2;
505 [ + - ]: 1 : hash = tx.GetHash();
506 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
507 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
508 : 0 : }
509 : :
510 : 1 : {
511 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
512 [ + - ]: 1 : LOCK(tx_mempool.cs);
513 : :
514 : : // subsidy changing
515 [ + - - + ]: 1 : int nHeight = m_node.chainman->ActiveChain().Height();
516 : : // Create an actual 209999-long block chain (without valid blocks).
517 [ + - - + : 419780 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 209999) {
+ + ]
518 [ + - - + ]: 209889 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
519 [ + - ]: 209889 : CBlockIndex* next = new CBlockIndex();
520 [ + - ]: 209889 : next->phashBlock = new uint256(m_rng.rand256());
521 [ + - + - : 209889 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
522 : 209889 : next->pprev = prev;
523 : 209889 : next->nHeight = prev->nHeight + 1;
524 [ + - ]: 209889 : next->BuildSkip();
525 [ + - + - ]: 209889 : m_node.chainman->ActiveChain().SetTip(*next);
526 : : }
527 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
+ - ]
528 : : // Extend to a 210000-long block chain.
529 [ + - - + : 4 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 210000) {
+ + ]
530 [ + - - + ]: 1 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
531 [ + - ]: 1 : CBlockIndex* next = new CBlockIndex();
532 [ + - ]: 1 : next->phashBlock = new uint256(m_rng.rand256());
533 [ + - + - : 1 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
534 : 1 : next->pprev = prev;
535 : 1 : next->nHeight = prev->nHeight + 1;
536 [ + - ]: 1 : next->BuildSkip();
537 [ + - + - ]: 1 : m_node.chainman->ActiveChain().SetTip(*next);
538 : : }
539 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
+ - + - ]
540 : :
541 : : // invalid p2sh txn in tx_mempool, template creation fails
542 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
543 : 1 : tx.vin[0].prevout.n = 0;
544 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
545 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - LOWFEE;
546 [ + - ]: 1 : CScript script = CScript() << OP_0;
547 [ + - + - ]: 1 : tx.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(script));
548 [ + - ]: 1 : hash = tx.GetHash();
549 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
550 [ - + ]: 1 : tx.vin[0].prevout.hash = hash;
551 [ - + + - ]: 2 : tx.vin[0].scriptSig = CScript() << std::vector<unsigned char>(script.begin(), script.end());
552 [ + - ]: 1 : tx.vout[0].nValue -= LOWFEE;
553 [ + - ]: 1 : hash = tx.GetHash();
554 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
555 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("block-script-verify-flag-failed"));
- - - - -
+ + - + -
+ - ]
556 : :
557 : : // Delete the dummy blocks again.
558 [ + - - + : 419782 : while (m_node.chainman->ActiveChain().Tip()->nHeight > nHeight) {
+ + ]
559 [ + - - + ]: 209890 : CBlockIndex* del = m_node.chainman->ActiveChain().Tip();
560 [ + - - + : 209890 : m_node.chainman->ActiveChain().SetTip(*Assert(del->pprev));
+ - ]
561 [ + - + - : 209890 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(del->pprev->GetBlockHash());
+ - ]
562 [ + - ]: 209890 : delete del->phashBlock;
563 [ + - ]: 209890 : delete del;
564 : : }
565 [ + - ]: 1 : }
566 : :
567 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
568 [ + - ]: 1 : LOCK(tx_mempool.cs);
569 : :
570 : : // non-final txs in mempool
571 [ + - - + : 2 : clock.set(std::chrono::seconds{m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1});
+ - ]
572 : 1 : const int flags{LOCKTIME_VERIFY_SEQUENCE};
573 : : // height map
574 : 1 : std::vector<int> prevheights;
575 : :
576 : : // relative height locked
577 : 1 : tx.version = 2;
578 [ + - ]: 1 : tx.vin.resize(1);
579 [ + - ]: 1 : prevheights.resize(1);
580 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash(); // only 1 transaction
581 : 1 : tx.vin[0].prevout.n = 0;
582 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
583 [ + - - + : 2 : tx.vin[0].nSequence = m_node.chainman->ActiveChain().Tip()->nHeight + 1; // txFirst[0] is the 2nd block
+ - ]
584 : 1 : prevheights[0] = baseheight + 1;
585 [ + - ]: 1 : tx.vout.resize(1);
586 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY-HIGHFEE;
587 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
588 : 1 : tx.nLockTime = 0;
589 [ + - ]: 1 : hash = tx.GetHash();
590 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
591 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + -
+ + - + -
+ - ]
592 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
593 : :
594 : 1 : {
595 [ + - - + ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
596 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 2, active_chain_tip))); // Sequence locks pass on 2nd block
+ - + - +
- + - ]
597 : : }
598 : :
599 : : // relative time locked
600 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
601 [ + - - + : 3 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | (((m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()+1-m_node.chainman->ActiveChain()[1]->GetMedianTimePast()) >> CTxIn::SEQUENCE_LOCKTIME_GRANULARITY) + 1); // txFirst[1] is the 3rd block
+ - - + +
- ]
602 : 1 : prevheights[0] = baseheight + 2;
603 [ + - ]: 1 : hash = tx.GetHash();
604 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
605 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + -
+ + - + -
+ - ]
606 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - ]
607 : :
608 : 1 : const int SEQUENCE_LOCK_TIME = 512; // Sequence locks pass 512 seconds later
609 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i)
610 [ + - - + : 33 : m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i)->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
+ - - + +
- ]
611 : 1 : {
612 [ + - - + ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
613 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 1, active_chain_tip)));
+ - + - +
- ]
614 : : }
615 : :
616 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
617 [ + - - + : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - - + +
- - + ]
618 : 11 : ancestor->nTime -= SEQUENCE_LOCK_TIME; // undo tricked MTP
619 : : }
620 : :
621 : : // absolute height locked
622 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
623 : 1 : tx.vin[0].nSequence = CTxIn::MAX_SEQUENCE_NONFINAL;
624 : 1 : prevheights[0] = baseheight + 3;
625 [ + - - + ]: 1 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
626 [ + - ]: 1 : hash = tx.GetHash();
627 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
628 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - - + -
+ + - + -
+ - ]
629 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
630 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast())); // Locktime passes on 2nd block
- + + - -
+ + - + -
+ - + - ]
631 : :
632 : : // ensure tx is final for a specific case where there is no locktime and block height is zero
633 : 1 : tx.nLockTime = 0;
634 [ + - + - : 4 : BOOST_CHECK(IsFinalTx(CTransaction(tx), /*nBlockHeight=*/0, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()));
- + + - +
- + - +
- ]
635 : :
636 : : // absolute time locked
637 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
638 [ + - - + ]: 2 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->GetMedianTimePast();
639 [ + - ]: 1 : prevheights.resize(1);
640 [ + - ]: 1 : prevheights[0] = baseheight + 4;
641 [ + - ]: 1 : hash = tx.GetHash();
642 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
643 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - - + -
+ + - + -
+ - ]
644 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
645 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1)); // Locktime passes 1 second later
- + + - -
+ + - + -
+ - + - ]
646 : :
647 : : // mempool-dependent transactions (not added)
648 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
649 [ + - - + : 2 : prevheights[0] = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
+ - ]
650 : 1 : tx.nLockTime = 0;
651 : 1 : tx.vin[0].nSequence = 0;
652 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + -
+ + - + -
+ - ]
653 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
654 [ + - ]: 1 : tx.vin[0].nSequence = 1;
655 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
656 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG;
657 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
658 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | 1;
659 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
660 : :
661 [ + - ]: 1 : auto block_template = mining->createNewBlock(options, /*cooldown=*/false);
662 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
663 : :
664 : : // None of the of the absolute height/time locked tx should have made
665 : : // it into the template because we still check IsFinalTx in CreateNewBlock,
666 : : // but relative locked txs will if inconsistently added to mempool.
667 : : // For now these will still generate a valid template until BIP68 soft fork
668 [ + - ]: 1 : CBlock block{block_template->getBlock()};
669 [ + - - + : 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 3U);
+ - ]
670 : : // However if we advance height by 1 and time by SEQUENCE_LOCK_TIME, all of them should be mined
671 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
672 [ + - - + : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - - + +
- - + ]
673 : 11 : ancestor->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
674 : : }
675 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight++;
676 [ + - - + : 2 : clock.set(std::chrono::seconds{m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1});
+ - ]
677 : :
678 [ + - ]: 2 : block_template = mining->createNewBlock(options, /*cooldown=*/false);
679 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
680 [ + - ]: 1 : block = block_template->getBlock();
681 [ + - - + : 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 5U);
+ - ]
682 [ + - ]: 3 : }
683 : :
684 : 1 : void MinerTestingSetup::TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
685 : : {
686 : 1 : auto mining{MakeMining()};
687 [ + - + - ]: 2 : BOOST_REQUIRE(mining);
688 : :
689 : 1 : BlockCreateOptions options{
690 : : .coinbase_output_script = scriptPubKey,
691 : 1 : };
692 : :
693 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
694 [ + - ]: 1 : LOCK(tx_mempool.cs);
695 : :
696 : 1 : TestMemPoolEntryHelper entry;
697 : :
698 : : // Test that a tx below min fee but prioritised is included
699 [ + - ]: 1 : CMutableTransaction tx;
700 [ + - ]: 1 : tx.vin.resize(1);
701 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
702 : 1 : tx.vin[0].prevout.n = 0;
703 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
704 [ + - ]: 1 : tx.vout.resize(1);
705 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
706 [ + - ]: 1 : Txid hashFreePrioritisedTx = tx.GetHash();
707 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
708 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreePrioritisedTx, 5 * COIN);
709 : :
710 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
711 : 1 : tx.vin[0].prevout.n = 0;
712 : 1 : tx.vout[0].nValue = 5000000000LL - 1000;
713 : : // This tx has a low fee: 1000 satoshis
714 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
715 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
716 : :
717 : : // This tx has a medium fee: 10000 satoshis
718 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
719 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
720 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
721 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
722 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashMediumFeeTx, -5 * COIN);
723 : :
724 : : // This tx also has a low fee, but is prioritised
725 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
726 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 1000; // 1000 satoshi fee
727 [ + - ]: 1 : Txid hashPrioritsedChild = tx.GetHash();
728 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
729 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashPrioritsedChild, 2 * COIN);
730 : :
731 : : // Test that transaction selection properly updates ancestor fee calculations as prioritised
732 : : // parents get included in a block. Create a transaction with two prioritised ancestors, each
733 : : // included by itself: FreeParent <- FreeChild <- FreeGrandchild.
734 : : // When FreeParent is added, a modified entry will be created for FreeChild + FreeGrandchild
735 : : // FreeParent's prioritisation should not be included in that entry.
736 : : // When FreeChild is included, FreeChild's prioritisation should also not be included.
737 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
738 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
739 [ + - ]: 1 : Txid hashFreeParent = tx.GetHash();
740 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
741 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeParent, 10 * COIN);
742 : :
743 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeParent;
744 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
745 [ + - ]: 1 : Txid hashFreeChild = tx.GetHash();
746 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
747 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeChild, 1 * COIN);
748 : :
749 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeChild;
750 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
751 [ + - ]: 1 : Txid hashFreeGrandchild = tx.GetHash();
752 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
753 : :
754 [ + - ]: 1 : auto block_template = mining->createNewBlock(options, /*cooldown=*/false);
755 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
756 [ + - ]: 1 : CBlock block{block_template->getBlock()};
757 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
+ - ]
758 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashFreeParent);
+ - ]
759 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashFreePrioritisedTx);
+ - ]
760 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashParentTx);
+ - ]
761 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashPrioritsedChild);
+ - ]
762 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashFreeChild);
763 [ - + + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
764 : : // The FreeParent and FreeChild's prioritisations should not impact the child.
765 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeGrandchild);
+ - ]
766 : : // De-prioritised transaction should not be included.
767 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashMediumFeeTx);
768 : : }
769 [ + - ]: 3 : }
770 : :
771 : : // NOTE: These tests rely on CreateNewBlock doing its own self-validation!
772 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(CreateNewBlock_validity)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
773 : : {
774 : 1 : auto mining{MakeMining()};
775 [ + - + - ]: 2 : BOOST_REQUIRE(mining);
776 : :
777 : : // Note that by default, these tests run with size accounting enabled.
778 [ + - ]: 1 : CScript scriptPubKey = CScript() << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f"_hex << OP_CHECKSIG;
779 : 1 : BlockCreateOptions options{
780 : : .coinbase_output_script = scriptPubKey,
781 : 1 : };
782 : :
783 : : // Create and check a simple template
784 [ + - ]: 1 : std::unique_ptr<BlockTemplate> block_template = mining->createNewBlock(options, /*cooldown=*/false);
785 [ + - + - ]: 2 : BOOST_REQUIRE(block_template);
786 : :
787 : 1 : BlockCreateOptions invalid_options{options};
788 [ - + ]: 1 : invalid_options.block_max_weight = DEFAULT_BLOCK_RESERVED_WEIGHT - 1;
789 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(invalid_options, /*cooldown=*/false),
- - - - -
+ + - + -
+ - ]
790 : : std::runtime_error,
791 : : HasReason("block_reserved_weight (8000) exceeds block_max_weight (7999)"));
792 : :
793 : 1 : {
794 [ + - ]: 1 : CBlock block{block_template->getBlock()};
795 : 1 : {
796 [ + - ]: 1 : std::string reason;
797 : 1 : std::string debug;
798 [ + - + - : 2 : BOOST_REQUIRE(!mining->checkBlock(block, {.check_pow = false}, reason, debug));
+ - + - ]
799 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "bad-txnmrklroot");
800 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "hashMerkleRoot mismatch");
801 : 1 : }
802 : :
803 [ + - ]: 1 : block.hashMerkleRoot = BlockMerkleRoot(block);
804 : :
805 : 1 : {
806 [ + - ]: 1 : std::string reason;
807 : 1 : std::string debug;
808 [ + - + - : 2 : BOOST_REQUIRE(mining->checkBlock(block, {.check_pow = false}, reason, debug));
+ - + - ]
809 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "");
810 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "");
811 : 1 : }
812 : :
813 : 1 : {
814 : : // A block template does not have proof-of-work, but it might pass
815 : : // verification by coincidence. Grind the nonce if needed:
816 [ - + + - : 1 : while (CheckProofOfWork(block.GetHash(), block.nBits, Assert(m_node.chainman)->GetParams().GetConsensus())) {
+ - - + ]
817 : 0 : block.nNonce++;
818 : : }
819 : :
820 [ + - ]: 1 : std::string reason;
821 : 1 : std::string debug;
822 [ + - + - : 2 : BOOST_REQUIRE(!mining->checkBlock(block, {.check_pow = true}, reason, debug));
+ - + - ]
823 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "high-hash");
824 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "proof of work failed");
825 : 1 : }
826 : 0 : }
827 : :
828 : : // We can't make transactions until we have inputs
829 : : // Therefore, load 110 blocks :)
830 : 1 : static_assert(std::size(BLOCKINFO) == 110, "Should have 110 blocks to import");
831 : 1 : int baseheight = 0;
832 : 1 : std::vector<CTransactionRef> txFirst;
833 [ + + ]: 111 : for (const auto& bi : BLOCKINFO) {
834 [ + - ]: 110 : const int current_height{mining->getTip()->height};
835 : :
836 : : /**
837 : : * Simple block creation, nothing special yet.
838 : : * If current_height is odd, block_template will have already been
839 : : * set at the end of the previous loop.
840 : : */
841 [ + + ]: 110 : if (current_height % 2 == 0) {
842 [ + - ]: 110 : block_template = mining->createNewBlock(options, /*cooldown=*/false);
843 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
844 : : }
845 : :
846 [ + - ]: 110 : CBlock block{block_template->getBlock()};
847 [ + - ]: 110 : CMutableTransaction txCoinbase(*block.vtx[0]);
848 : 110 : {
849 [ + - ]: 110 : LOCK(cs_main);
850 : 110 : block.nVersion = VERSIONBITS_TOP_BITS;
851 [ - + + - : 220 : block.nTime = Assert(m_node.chainman)->ActiveChain().Tip()->GetMedianTimePast()+1;
- + ]
852 : 110 : txCoinbase.version = 1;
853 [ + - + - ]: 110 : txCoinbase.vin[0].scriptSig = CScript{} << (current_height + 1) << bi.extranonce;
854 [ + - ]: 110 : txCoinbase.vout.resize(1); // Ignore the (optional) segwit commitment added by CreateNewBlock (as the hardcoded nonces don't account for this)
855 : 110 : txCoinbase.vout[0].scriptPubKey = CScript();
856 [ + - - + ]: 220 : block.vtx[0] = MakeTransactionRef(txCoinbase);
857 [ - + + + ]: 110 : if (txFirst.size() == 0)
858 : 1 : baseheight = current_height;
859 [ + + ]: 110 : if (txFirst.size() < 4)
860 [ + - ]: 4 : txFirst.push_back(block.vtx[0]);
861 [ + - ]: 110 : block.hashMerkleRoot = BlockMerkleRoot(block);
862 [ + - ]: 110 : block.nNonce = bi.nonce;
863 : 0 : }
864 : : // Alternate calls between submitBlock and submitSolution via the
865 : : // Mining interface.
866 [ + + ]: 110 : if (current_height % 2 == 0) {
867 [ + - ]: 55 : std::string reason{"stale reason"};
868 [ + - ]: 55 : std::string debug{"stale debug"};
869 [ + - + - : 110 : BOOST_REQUIRE(mining->submitBlock(block, reason, debug));
+ - + - ]
870 [ + - + - ]: 55 : BOOST_REQUIRE_EQUAL(reason, "");
871 [ + - + - ]: 55 : BOOST_REQUIRE_EQUAL(debug, "");
872 : :
873 [ + - ]: 55 : reason = "stale reason";
874 [ + - ]: 55 : debug = "stale debug";
875 [ + - + - : 110 : BOOST_REQUIRE(!mining->submitBlock(block, reason, debug));
+ - + - ]
876 [ + - + - ]: 55 : BOOST_REQUIRE_EQUAL(reason, "duplicate");
877 [ + - + - ]: 55 : BOOST_REQUIRE_EQUAL(debug, "");
878 : 55 : } else {
879 [ + - + - : 165 : BOOST_REQUIRE(block_template->submitSolution(block.nVersion, block.nTime, block.nNonce, MakeTransactionRef(txCoinbase)));
+ - + - -
+ ]
880 : : }
881 : 110 : {
882 [ + - ]: 110 : LOCK(cs_main);
883 : : // The above calls don't guarantee the tip is actually updated, so
884 : : // we explicitly check this.
885 [ - + + - : 110 : auto maybe_new_tip{Assert(m_node.chainman)->ActiveChain().Tip()};
- + ]
886 [ + - + - : 110 : BOOST_REQUIRE_EQUAL(maybe_new_tip->GetBlockHash(), block.GetHash());
+ - + - ]
887 : 0 : }
888 [ + + ]: 110 : if (current_height % 2 == 0) {
889 [ + - ]: 110 : block_template = block_template->waitNext();
890 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
891 : : } else {
892 : : // This just adds coverage
893 [ + - ]: 55 : mining->waitTipChanged(block.hashPrevBlock);
894 : : }
895 : 110 : }
896 : :
897 [ + - ]: 1 : LOCK(cs_main);
898 : :
899 [ + - ]: 1 : TestBasicMining(scriptPubKey, txFirst, baseheight);
900 : :
901 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
902 : :
903 [ + - ]: 1 : TestPackageSelection(scriptPubKey, txFirst);
904 : :
905 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
906 : :
907 [ + - ]: 1 : TestPrioritisedMining(scriptPubKey, txFirst);
908 : 1 : }
909 : :
910 : : BOOST_AUTO_TEST_SUITE_END()
|
