Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <addresstype.h>
6 : : #include <coins.h>
7 : : #include <common/system.h>
8 : : #include <consensus/consensus.h>
9 : : #include <consensus/merkle.h>
10 : : #include <consensus/tx_verify.h>
11 : : #include <interfaces/mining.h>
12 : : #include <node/miner.h>
13 : : #include <policy/policy.h>
14 : : #include <test/util/random.h>
15 : : #include <test/util/transaction_utils.h>
16 : : #include <test/util/txmempool.h>
17 : : #include <txmempool.h>
18 : : #include <uint256.h>
19 : : #include <util/check.h>
20 : : #include <util/feefrac.h>
21 : : #include <util/strencodings.h>
22 : : #include <util/time.h>
23 : : #include <util/translation.h>
24 : : #include <validation.h>
25 : : #include <versionbits.h>
26 : : #include <pow.h>
27 : :
28 : : #include <test/util/setup_common.h>
29 : :
30 : : #include <memory>
31 : : #include <vector>
32 : :
33 : : #include <boost/test/unit_test.hpp>
34 : :
35 : : using namespace util::hex_literals;
36 : : using interfaces::BlockTemplate;
37 : : using interfaces::Mining;
38 : : using node::BlockAssembler;
39 : :
40 : : namespace miner_tests {
41 : 2 : struct MinerTestingSetup : public TestingSetup {
42 : : void TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
43 : : void TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
44 : : void TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
45 : 8 : bool TestSequenceLocks(const CTransaction& tx, CTxMemPool& tx_mempool) EXCLUSIVE_LOCKS_REQUIRED(::cs_main)
46 : : {
47 : 8 : CCoinsViewMemPool view_mempool{&m_node.chainman->ActiveChainstate().CoinsTip(), tx_mempool};
48 [ + - - + ]: 8 : CBlockIndex* tip{m_node.chainman->ActiveChain().Tip()};
49 [ + - ]: 8 : const std::optional<LockPoints> lock_points{CalculateLockPointsAtTip(tip, view_mempool, tx)};
50 [ + - + - : 16 : return lock_points.has_value() && CheckSequenceLocksAtTip(tip, *lock_points);
+ + ]
51 : 8 : }
52 : 11 : CTxMemPool& MakeMempool()
53 : : {
54 : : // Delete the previous mempool to ensure with valgrind that the old
55 : : // pointer is not accessed, when the new one should be accessed
56 : : // instead.
57 [ + - ]: 11 : m_node.mempool.reset();
58 [ + - ]: 11 : bilingual_str error;
59 [ + - + - ]: 11 : m_node.mempool = std::make_unique<CTxMemPool>(MemPoolOptionsForTest(m_node), error);
60 [ + - ]: 11 : Assert(error.empty());
61 : 11 : return *m_node.mempool;
62 : 11 : }
63 : 4 : std::unique_ptr<Mining> MakeMining()
64 : : {
65 : 4 : return interfaces::MakeMining(m_node);
66 : : }
67 : : };
68 : : } // namespace miner_tests
69 : :
70 : : BOOST_FIXTURE_TEST_SUITE(miner_tests, MinerTestingSetup)
71 : :
72 : : static CFeeRate blockMinFeeRate = CFeeRate(DEFAULT_BLOCK_MIN_TX_FEE);
73 : :
74 : : constexpr static struct {
75 : : unsigned int extranonce;
76 : : unsigned int nonce;
77 : : } BLOCKINFO[]{{0, 3552706918}, {500, 37506755}, {1000, 948987788}, {400, 524762339}, {800, 258510074}, {300, 102309278},
78 : : {1300, 54365202}, {600, 1107740426}, {1000, 203094491}, {900, 391178848}, {800, 381177271}, {600, 87188412},
79 : : {0, 66522866}, {800, 874942736}, {1000, 89200838}, {400, 312638088}, {400, 66263693}, {500, 924648304},
80 : : {400, 369913599}, {500, 47630099}, {500, 115045364}, {100, 277026602}, {1100, 809621409}, {700, 155345322},
81 : : {800, 943579953}, {400, 28200730}, {900, 77200495}, {0, 105935488}, {400, 698721821}, {500, 111098863},
82 : : {1300, 445389594}, {500, 621849894}, {1400, 56010046}, {1100, 370669776}, {1200, 380301940}, {1200, 110654905},
83 : : {400, 213771024}, {1500, 120014726}, {1200, 835019014}, {1500, 624817237}, {900, 1404297}, {400, 189414558},
84 : : {400, 293178348}, {1100, 15393789}, {600, 396764180}, {800, 1387046371}, {800, 199368303}, {700, 111496662},
85 : : {100, 129759616}, {200, 536577982}, {500, 125881300}, {500, 101053391}, {1200, 471590548}, {900, 86957729},
86 : : {1200, 179604104}, {600, 68658642}, {1000, 203295701}, {500, 139615361}, {900, 233693412}, {300, 153225163},
87 : : {0, 27616254}, {1200, 9856191}, {100, 220392722}, {200, 66257599}, {1100, 145489641}, {1300, 37859442},
88 : : {400, 5816075}, {1200, 215752117}, {1400, 32361482}, {1400, 6529223}, {500, 143332977}, {800, 878392},
89 : : {700, 159290408}, {400, 123197595}, {700, 43988693}, {300, 304224916}, {700, 214771621}, {1100, 274148273},
90 : : {400, 285632418}, {1100, 923451065}, {600, 12818092}, {1200, 736282054}, {1000, 246683167}, {600, 92950402},
91 : : {1400, 29223405}, {1000, 841327192}, {700, 174301283}, {1400, 214009854}, {1000, 6989517}, {1200, 278226956},
92 : : {700, 540219613}, {400, 93663104}, {1100, 152345635}, {1500, 464194499}, {1300, 333850111}, {600, 258311263},
93 : : {600, 90173162}, {1000, 33590797}, {1500, 332866027}, {100, 204704427}, {1000, 463153545}, {800, 303244785},
94 : : {600, 88096214}, {0, 137477892}, {1200, 195514506}, {300, 704114595}, {900, 292087369}, {1400, 758684870},
95 : : {1300, 163493028}, {1200, 53151293}};
96 : :
97 : 2 : static std::unique_ptr<CBlockIndex> CreateBlockIndex(int nHeight, CBlockIndex* active_chain_tip) EXCLUSIVE_LOCKS_REQUIRED(cs_main)
98 : : {
99 : 2 : auto index{std::make_unique<CBlockIndex>()};
100 : 2 : index->nHeight = nHeight;
101 : 2 : index->pprev = active_chain_tip;
102 : 2 : return index;
103 : : }
104 : :
105 : : // Test suite for ancestor feerate transaction selection.
106 : : // Implemented as an additional function, rather than a separate test case,
107 : : // to allow reusing the blockchain created in CreateNewBlock_validity.
108 : 1 : void MinerTestingSetup::TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
109 : : {
110 : 1 : CTxMemPool& tx_mempool{MakeMempool()};
111 : 1 : auto mining{MakeMining()};
112 [ + - ]: 1 : BlockAssembler::Options options;
113 : 1 : options.coinbase_output_script = scriptPubKey;
114 : :
115 [ + - ]: 1 : LOCK(tx_mempool.cs);
116 [ + - + - : 2 : BOOST_CHECK(tx_mempool.size() == 0);
+ - + - ]
117 : :
118 : : // Block template should only have a coinbase when there's nothing in the mempool
119 [ + - ]: 1 : std::unique_ptr<BlockTemplate> block_template = mining->createNewBlock(options);
120 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
121 [ + - ]: 1 : CBlock block{block_template->getBlock()};
122 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 1U);
+ - ]
123 : :
124 : : // waitNext() on an empty mempool should return nullptr because there is no better template
125 [ + - ]: 1 : auto should_be_nullptr = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 1});
126 [ + - + - : 2 : BOOST_REQUIRE(should_be_nullptr == nullptr);
+ - ]
127 : :
128 : : // Unless fee_threshold is 0
129 [ + - ]: 2 : block_template = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 0});
130 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
131 : :
132 : : // Test the ancestor feerate transaction selection.
133 : 1 : TestMemPoolEntryHelper entry;
134 : :
135 : : // Test that a medium fee transaction will be selected after a higher fee
136 : : // rate package with a low fee rate parent.
137 [ + - ]: 1 : CMutableTransaction tx;
138 [ + - ]: 1 : tx.vin.resize(1);
139 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
140 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
141 : 1 : tx.vin[0].prevout.n = 0;
142 [ + - ]: 1 : tx.vout.resize(1);
143 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 1000;
144 : : // This tx has a low fee: 1000 satoshis
145 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
146 [ + - ]: 1 : const auto parent_tx{entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
147 [ + - ]: 1 : AddToMempool(tx_mempool, parent_tx);
148 : :
149 : : // This tx has a medium fee: 10000 satoshis
150 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
151 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
152 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
153 [ + - ]: 1 : const auto medium_fee_tx{entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
154 [ + - ]: 1 : AddToMempool(tx_mempool, medium_fee_tx);
155 : :
156 : : // This tx has a high fee, but depends on the first transaction
157 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
158 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 50k satoshi fee
159 [ + - ]: 1 : Txid hashHighFeeTx = tx.GetHash();
160 [ + - ]: 1 : const auto high_fee_tx{entry.Fee(50000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx)};
161 [ + - ]: 1 : AddToMempool(tx_mempool, high_fee_tx);
162 : :
163 [ + - ]: 2 : block_template = mining->createNewBlock(options);
164 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
165 [ + - ]: 1 : block = block_template->getBlock();
166 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 4U);
+ - ]
167 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashParentTx);
+ - ]
168 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashHighFeeTx);
+ - ]
169 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashMediumFeeTx);
+ - ]
170 : :
171 : : // Test the inclusion of package feerates in the block template and ensure they are sequential.
172 [ + - + - : 1 : const auto block_package_feerates = BlockAssembler{m_node.chainman->ActiveChainstate(), &tx_mempool, options}.CreateNewBlock()->m_package_feerates;
+ - + - ]
173 [ + - - + : 2 : BOOST_CHECK(block_package_feerates.size() == 2);
+ - + - ]
174 : :
175 : : // parent_tx and high_fee_tx are added to the block as a package.
176 : 1 : const auto combined_txs_fee = parent_tx.GetFee() + high_fee_tx.GetFee();
177 [ + - + - ]: 1 : const auto combined_txs_size = parent_tx.GetTxSize() + high_fee_tx.GetTxSize();
178 [ + - ]: 1 : FeeFrac package_feefrac{combined_txs_fee, combined_txs_size};
179 : : // The package should be added first.
180 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[0] == package_feefrac);
+ - + - ]
181 : :
182 : : // The medium_fee_tx should be added next.
183 [ + - + - ]: 1 : FeeFrac medium_tx_feefrac{medium_fee_tx.GetFee(), medium_fee_tx.GetTxSize()};
184 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[1] == medium_tx_feefrac);
+ - + - ]
185 : :
186 : : // Test that a package below the block min tx fee doesn't get included
187 [ + - ]: 1 : tx.vin[0].prevout.hash = hashHighFeeTx;
188 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 0 fee
189 [ + - ]: 1 : Txid hashFreeTx = tx.GetHash();
190 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).FromTx(tx));
191 : 1 : size_t freeTxSize = ::GetSerializeSize(TX_WITH_WITNESS(tx));
192 : :
193 : : // Calculate a fee on child transaction that will put the package just
194 : : // below the block min tx fee (assuming 1 child tx of the same size).
195 [ + - ]: 1 : CAmount feeToUse = blockMinFeeRate.GetFee(2*freeTxSize) - 1;
196 : :
197 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx;
198 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000 - feeToUse;
199 [ + - ]: 1 : Txid hashLowFeeTx = tx.GetHash();
200 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(feeToUse).FromTx(tx));
201 : :
202 : : // waitNext() should return nullptr because there is no better template
203 [ + - ]: 2 : should_be_nullptr = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 1});
204 [ + - + - : 2 : BOOST_REQUIRE(should_be_nullptr == nullptr);
+ - ]
205 : :
206 [ + - ]: 1 : block = block_template->getBlock();
207 : : // Verify that the free tx and the low fee tx didn't get selected
208 [ - + + + ]: 5 : for (size_t i=0; i<block.vtx.size(); ++i) {
209 [ + - + - : 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx);
+ - ]
210 [ + - + - ]: 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx);
211 : : }
212 : :
213 : : // Test that packages above the min relay fee do get included, even if one
214 : : // of the transactions is below the min relay fee
215 : : // Remove the low fee transaction and replace with a higher fee transaction
216 [ + - + - ]: 1 : tx_mempool.removeRecursive(CTransaction(tx), MemPoolRemovalReason::REPLACED);
217 [ + - ]: 1 : tx.vout[0].nValue -= 2; // Now we should be just over the min relay fee
218 [ + - ]: 1 : hashLowFeeTx = tx.GetHash();
219 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(feeToUse + 2).FromTx(tx));
220 : :
221 : : // waitNext() should return if fees for the new template are at least 1 sat up
222 [ + - ]: 2 : block_template = block_template->waitNext({.fee_threshold = 1});
223 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
224 [ + - ]: 1 : block = block_template->getBlock();
225 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
+ - ]
226 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashFreeTx);
+ - ]
227 [ + - + - : 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashLowFeeTx);
+ - ]
228 : :
229 : : // Test that transaction selection properly updates ancestor fee
230 : : // calculations as ancestor transactions get included in a block.
231 : : // Add a 0-fee transaction that has 2 outputs.
232 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
233 [ + - ]: 1 : tx.vout.resize(2);
234 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000;
235 : 1 : tx.vout[1].nValue = 100000000; // 1BTC output
236 : : // Increase size to avoid rounding errors: when the feerate is extremely small (i.e. 1sat/kvB), evaluating the fee
237 : : // at smaller sizes gives us rounded values that are equal to each other, which means we incorrectly include
238 : : // hashFreeTx2 + hashLowFeeTx2.
239 [ + - ]: 1 : BulkTransaction(tx, 4000);
240 [ + - ]: 1 : Txid hashFreeTx2 = tx.GetHash();
241 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
242 : :
243 : : // This tx can't be mined by itself
244 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx2;
245 [ + - ]: 1 : tx.vout.resize(1);
246 [ + - ]: 1 : feeToUse = blockMinFeeRate.GetFee(freeTxSize);
247 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000 - feeToUse;
248 [ + - ]: 1 : Txid hashLowFeeTx2 = tx.GetHash();
249 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(feeToUse).SpendsCoinbase(false).FromTx(tx));
250 [ + - ]: 2 : block_template = mining->createNewBlock(options);
251 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
252 [ + - ]: 1 : block = block_template->getBlock();
253 : :
254 : : // Verify that this tx isn't selected.
255 [ - + + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
256 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx2);
+ - ]
257 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx2);
258 : : }
259 : :
260 : : // This tx will be mineable, and should cause hashLowFeeTx2 to be selected
261 : : // as well.
262 [ + - ]: 1 : tx.vin[0].prevout.n = 1;
263 : 1 : tx.vout[0].nValue = 100000000 - 10000; // 10k satoshi fee
264 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(10000).FromTx(tx));
265 [ + - ]: 2 : block_template = mining->createNewBlock(options);
266 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
267 [ + - ]: 1 : block = block_template->getBlock();
268 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 9U);
+ - ]
269 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[8]->GetHash() == hashLowFeeTx2);
270 [ + - ]: 3 : }
271 : :
272 : 1 : void MinerTestingSetup::TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight)
273 : : {
274 : 1 : Txid hash;
275 : 1 : CMutableTransaction tx;
276 : 1 : TestMemPoolEntryHelper entry;
277 : 1 : entry.nFee = 11;
278 : 1 : entry.nHeight = 11;
279 : :
280 : 1 : const CAmount BLOCKSUBSIDY = 50 * COIN;
281 : 1 : const CAmount LOWFEE = CENT;
282 : 1 : const CAmount HIGHFEE = COIN;
283 : 1 : const CAmount HIGHERFEE = 4 * COIN;
284 : :
285 [ + - ]: 1 : auto mining{MakeMining()};
286 [ + - + - : 2 : BOOST_REQUIRE(mining);
+ - ]
287 : :
288 [ + - ]: 1 : BlockAssembler::Options options;
289 : 1 : options.coinbase_output_script = scriptPubKey;
290 : :
291 : 1 : {
292 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
293 [ + - ]: 1 : LOCK(tx_mempool.cs);
294 : :
295 : : // Just to make sure we can still make simple blocks
296 [ + - ]: 1 : auto block_template{mining->createNewBlock(options)};
297 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
298 [ + - ]: 1 : CBlock block{block_template->getBlock()};
299 : :
300 : : // block sigops > limit: 1000 CHECKMULTISIG + 1
301 [ + - ]: 1 : tx.vin.resize(1);
302 : : // NOTE: OP_NOP is used to force 20 SigOps for the CHECKMULTISIG
303 [ + - + - : 1 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_0 << OP_0 << OP_NOP << OP_CHECKMULTISIG << OP_1;
+ - + - +
- + - ]
304 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
305 : 1 : tx.vin[0].prevout.n = 0;
306 [ + - ]: 1 : tx.vout.resize(1);
307 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
308 [ + + ]: 1002 : for (unsigned int i = 0; i < 1001; ++i) {
309 [ + - ]: 1001 : tx.vout[0].nValue -= LOWFEE;
310 [ + - ]: 1001 : hash = tx.GetHash();
311 : 1001 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
312 : : // If we don't set the # of sig ops in the CTxMemPoolEntry, template creation fails
313 [ + - + - ]: 1001 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).FromTx(tx));
314 : 1001 : tx.vin[0].prevout.hash = hash;
315 : : }
316 : :
317 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-blk-sigops"));
- - - - -
+ + - + -
+ - ]
318 [ + - ]: 1 : }
319 : :
320 : 1 : {
321 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
322 [ + - ]: 1 : LOCK(tx_mempool.cs);
323 : :
324 : 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
325 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
326 [ + + ]: 1002 : for (unsigned int i = 0; i < 1001; ++i) {
327 [ + - ]: 1001 : tx.vout[0].nValue -= LOWFEE;
328 [ + - ]: 1001 : hash = tx.GetHash();
329 : 1001 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
330 : : // If we do set the # of sig ops in the CTxMemPoolEntry, template creation passes
331 [ + - + - ]: 1001 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).SigOpsCost(80).FromTx(tx));
332 : 1001 : tx.vin[0].prevout.hash = hash;
333 : : }
334 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
335 : 0 : }
336 : :
337 : 1 : {
338 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
339 [ + - ]: 1 : LOCK(tx_mempool.cs);
340 : :
341 : : // block size > limit
342 : 1 : tx.vin[0].scriptSig = CScript();
343 : : // 18 * (520char + DROP) + OP_1 = 9433 bytes
344 [ + - ]: 1 : std::vector<unsigned char> vchData(520);
345 [ + + ]: 19 : for (unsigned int i = 0; i < 18; ++i) {
346 [ - + + - ]: 18 : tx.vin[0].scriptSig << vchData << OP_DROP;
347 : : }
348 [ + - ]: 1 : tx.vin[0].scriptSig << OP_1;
349 : 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
350 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
351 [ + + ]: 129 : for (unsigned int i = 0; i < 128; ++i) {
352 [ + - ]: 128 : tx.vout[0].nValue -= LOWFEE;
353 [ + - ]: 128 : hash = tx.GetHash();
354 : 128 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
355 [ + - + - ]: 128 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).FromTx(tx));
356 : 128 : tx.vin[0].prevout.hash = hash;
357 : : }
358 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - ]
359 [ + - ]: 1 : }
360 : :
361 : 1 : {
362 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
363 [ + - ]: 1 : LOCK(tx_mempool.cs);
364 : :
365 : : // orphan in tx_mempool, template creation fails
366 [ + - ]: 1 : hash = tx.GetHash();
367 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).FromTx(tx));
368 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
369 : 0 : }
370 : :
371 : 1 : {
372 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
373 [ + - ]: 1 : LOCK(tx_mempool.cs);
374 : :
375 : : // child with higher feerate than parent
376 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
377 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
378 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
379 [ + - ]: 1 : hash = tx.GetHash();
380 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
381 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
382 [ + - ]: 1 : tx.vin.resize(2);
383 [ + - ]: 1 : tx.vin[1].scriptSig = CScript() << OP_1;
384 [ + - ]: 1 : tx.vin[1].prevout.hash = txFirst[0]->GetHash();
385 : 1 : tx.vin[1].prevout.n = 0;
386 : 1 : tx.vout[0].nValue = tx.vout[0].nValue + BLOCKSUBSIDY - HIGHERFEE; // First txn output + fresh coinbase - new txn fee
387 [ + - ]: 1 : hash = tx.GetHash();
388 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHERFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
389 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
390 : 0 : }
391 : :
392 : 1 : {
393 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
394 [ + - ]: 1 : LOCK(tx_mempool.cs);
395 : :
396 : : // coinbase in tx_mempool, template creation fails
397 [ + - ]: 1 : tx.vin.resize(1);
398 : 1 : tx.vin[0].prevout.SetNull();
399 [ + - + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_1;
400 [ + - ]: 1 : tx.vout[0].nValue = 0;
401 [ + - ]: 1 : hash = tx.GetHash();
402 : : // give it a fee so it'll get mined
403 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
404 : : // Should throw bad-cb-multiple
405 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-cb-multiple"));
- - - - +
- - + + -
+ - + - ]
406 : 0 : }
407 : :
408 : 1 : {
409 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
410 [ + - ]: 1 : LOCK(tx_mempool.cs);
411 : :
412 : : // double spend txn pair in tx_mempool, template creation fails
413 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
414 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
415 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
416 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
417 [ + - ]: 1 : hash = tx.GetHash();
418 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
419 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_2;
420 [ + - ]: 1 : hash = tx.GetHash();
421 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
422 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
423 : 0 : }
424 : :
425 : 1 : {
426 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
427 [ + - ]: 1 : LOCK(tx_mempool.cs);
428 : :
429 : : // subsidy changing
430 [ + - - + ]: 1 : int nHeight = m_node.chainman->ActiveChain().Height();
431 : : // Create an actual 209999-long block chain (without valid blocks).
432 [ + - - + : 419780 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 209999) {
+ + ]
433 [ + - - + ]: 209889 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
434 [ + - ]: 209889 : CBlockIndex* next = new CBlockIndex();
435 [ + - ]: 209889 : next->phashBlock = new uint256(m_rng.rand256());
436 [ + - + - : 209889 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
437 : 209889 : next->pprev = prev;
438 : 209889 : next->nHeight = prev->nHeight + 1;
439 [ + - ]: 209889 : next->BuildSkip();
440 [ + - + - ]: 209889 : m_node.chainman->ActiveChain().SetTip(*next);
441 : : }
442 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - ]
443 : : // Extend to a 210000-long block chain.
444 [ + - - + : 4 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 210000) {
+ + ]
445 [ + - - + ]: 1 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
446 [ + - ]: 1 : CBlockIndex* next = new CBlockIndex();
447 [ + - ]: 1 : next->phashBlock = new uint256(m_rng.rand256());
448 [ + - + - : 1 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
449 : 1 : next->pprev = prev;
450 : 1 : next->nHeight = prev->nHeight + 1;
451 [ + - ]: 1 : next->BuildSkip();
452 [ + - + - ]: 1 : m_node.chainman->ActiveChain().SetTip(*next);
453 : : }
454 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
455 : :
456 : : // invalid p2sh txn in tx_mempool, template creation fails
457 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
458 : 1 : tx.vin[0].prevout.n = 0;
459 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
460 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - LOWFEE;
461 [ + - ]: 1 : CScript script = CScript() << OP_0;
462 [ + - + - ]: 1 : tx.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(script));
463 [ + - ]: 1 : hash = tx.GetHash();
464 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
465 [ - + ]: 1 : tx.vin[0].prevout.hash = hash;
466 [ - + + - ]: 2 : tx.vin[0].scriptSig = CScript() << std::vector<unsigned char>(script.begin(), script.end());
467 [ + - ]: 1 : tx.vout[0].nValue -= LOWFEE;
468 [ + - ]: 1 : hash = tx.GetHash();
469 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
470 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("block-script-verify-flag-failed"));
- - - - -
+ + - + -
+ - ]
471 : :
472 : : // Delete the dummy blocks again.
473 [ + - - + : 419782 : while (m_node.chainman->ActiveChain().Tip()->nHeight > nHeight) {
+ + ]
474 [ + - - + ]: 209890 : CBlockIndex* del = m_node.chainman->ActiveChain().Tip();
475 [ + - + - : 209890 : m_node.chainman->ActiveChain().SetTip(*Assert(del->pprev));
+ - ]
476 [ + - + - : 209890 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(del->pprev->GetBlockHash());
+ - ]
477 [ + - ]: 209890 : delete del->phashBlock;
478 [ + - ]: 209890 : delete del;
479 : : }
480 [ + - ]: 1 : }
481 : :
482 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
483 [ + - ]: 1 : LOCK(tx_mempool.cs);
484 : :
485 : : // non-final txs in mempool
486 [ + - - + : 2 : SetMockTime(m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1);
+ - ]
487 : 1 : const int flags{LOCKTIME_VERIFY_SEQUENCE};
488 : : // height map
489 : 1 : std::vector<int> prevheights;
490 : :
491 : : // relative height locked
492 : 1 : tx.version = 2;
493 [ + - ]: 1 : tx.vin.resize(1);
494 [ + - ]: 1 : prevheights.resize(1);
495 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash(); // only 1 transaction
496 : 1 : tx.vin[0].prevout.n = 0;
497 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
498 [ + - - + : 2 : tx.vin[0].nSequence = m_node.chainman->ActiveChain().Tip()->nHeight + 1; // txFirst[0] is the 2nd block
+ - ]
499 : 1 : prevheights[0] = baseheight + 1;
500 [ + - ]: 1 : tx.vout.resize(1);
501 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY-HIGHFEE;
502 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
503 : 1 : tx.nLockTime = 0;
504 [ + - ]: 1 : hash = tx.GetHash();
505 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
506 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + +
- + - + -
+ - ]
507 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
508 : :
509 : 1 : {
510 [ + - - + ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
511 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 2, active_chain_tip))); // Sequence locks pass on 2nd block
+ - + - +
- + - ]
512 : : }
513 : :
514 : : // relative time locked
515 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
516 [ + - - + : 3 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | (((m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()+1-m_node.chainman->ActiveChain()[1]->GetMedianTimePast()) >> CTxIn::SEQUENCE_LOCKTIME_GRANULARITY) + 1); // txFirst[1] is the 3rd block
+ - - + +
- ]
517 : 1 : prevheights[0] = baseheight + 2;
518 [ + - ]: 1 : hash = tx.GetHash();
519 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
520 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + +
- + - + -
+ - ]
521 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - ]
522 : :
523 : 1 : const int SEQUENCE_LOCK_TIME = 512; // Sequence locks pass 512 seconds later
524 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i)
525 [ + - - + : 33 : m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i)->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
+ - - + +
- ]
526 : 1 : {
527 [ + - - + ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
528 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 1, active_chain_tip)));
+ - + - +
- ]
529 : : }
530 : :
531 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
532 [ + - - + : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - - + +
- + - ]
533 : 11 : ancestor->nTime -= SEQUENCE_LOCK_TIME; // undo tricked MTP
534 : : }
535 : :
536 : : // absolute height locked
537 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
538 : 1 : tx.vin[0].nSequence = CTxIn::MAX_SEQUENCE_NONFINAL;
539 : 1 : prevheights[0] = baseheight + 3;
540 [ + - - + ]: 1 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
541 [ + - ]: 1 : hash = tx.GetHash();
542 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
543 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - - + +
- + - + -
+ - ]
544 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
545 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast())); // Locktime passes on 2nd block
- + + - -
+ + - + -
+ - + - ]
546 : :
547 : : // ensure tx is final for a specific case where there is no locktime and block height is zero
548 : 1 : tx.nLockTime = 0;
549 [ + - + - : 4 : BOOST_CHECK(IsFinalTx(CTransaction(tx), /*nBlockHeight=*/0, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()));
- + + - +
- + - +
- ]
550 : :
551 : : // absolute time locked
552 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
553 [ + - - + ]: 2 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->GetMedianTimePast();
554 [ + - ]: 1 : prevheights.resize(1);
555 [ + - ]: 1 : prevheights[0] = baseheight + 4;
556 [ + - ]: 1 : hash = tx.GetHash();
557 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
558 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - - + +
- + - + -
+ - ]
559 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
560 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1)); // Locktime passes 1 second later
- + + - -
+ + - + -
+ - + - ]
561 : :
562 : : // mempool-dependent transactions (not added)
563 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
564 [ + - - + : 2 : prevheights[0] = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
+ - ]
565 : 1 : tx.nLockTime = 0;
566 : 1 : tx.vin[0].nSequence = 0;
567 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + +
- + - + -
+ - ]
568 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
569 [ + - ]: 1 : tx.vin[0].nSequence = 1;
570 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
571 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG;
572 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
573 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | 1;
574 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
575 : :
576 [ + - ]: 1 : auto block_template = mining->createNewBlock(options);
577 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
578 : :
579 : : // None of the of the absolute height/time locked tx should have made
580 : : // it into the template because we still check IsFinalTx in CreateNewBlock,
581 : : // but relative locked txs will if inconsistently added to mempool.
582 : : // For now these will still generate a valid template until BIP68 soft fork
583 [ + - ]: 1 : CBlock block{block_template->getBlock()};
584 [ + - - + : 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 3U);
+ - ]
585 : : // However if we advance height by 1 and time by SEQUENCE_LOCK_TIME, all of them should be mined
586 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
587 [ + - - + : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - - + +
- + - ]
588 : 11 : ancestor->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
589 : : }
590 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight++;
591 [ + - - + : 2 : SetMockTime(m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1);
+ - ]
592 : :
593 [ + - ]: 2 : block_template = mining->createNewBlock(options);
594 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
595 [ + - ]: 1 : block = block_template->getBlock();
596 [ + - - + : 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 5U);
+ - ]
597 [ + - ]: 3 : }
598 : :
599 : 1 : void MinerTestingSetup::TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
600 : : {
601 : 1 : auto mining{MakeMining()};
602 [ + - + - : 2 : BOOST_REQUIRE(mining);
+ - ]
603 : :
604 [ + - ]: 1 : BlockAssembler::Options options;
605 : 1 : options.coinbase_output_script = scriptPubKey;
606 : :
607 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
608 [ + - ]: 1 : LOCK(tx_mempool.cs);
609 : :
610 : 1 : TestMemPoolEntryHelper entry;
611 : :
612 : : // Test that a tx below min fee but prioritised is included
613 [ + - ]: 1 : CMutableTransaction tx;
614 [ + - ]: 1 : tx.vin.resize(1);
615 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
616 : 1 : tx.vin[0].prevout.n = 0;
617 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
618 [ + - ]: 1 : tx.vout.resize(1);
619 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
620 [ + - ]: 1 : Txid hashFreePrioritisedTx = tx.GetHash();
621 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
622 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreePrioritisedTx, 5 * COIN);
623 : :
624 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
625 : 1 : tx.vin[0].prevout.n = 0;
626 : 1 : tx.vout[0].nValue = 5000000000LL - 1000;
627 : : // This tx has a low fee: 1000 satoshis
628 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
629 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
630 : :
631 : : // This tx has a medium fee: 10000 satoshis
632 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
633 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
634 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
635 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
636 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashMediumFeeTx, -5 * COIN);
637 : :
638 : : // This tx also has a low fee, but is prioritised
639 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
640 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 1000; // 1000 satoshi fee
641 [ + - ]: 1 : Txid hashPrioritsedChild = tx.GetHash();
642 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
643 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashPrioritsedChild, 2 * COIN);
644 : :
645 : : // Test that transaction selection properly updates ancestor fee calculations as prioritised
646 : : // parents get included in a block. Create a transaction with two prioritised ancestors, each
647 : : // included by itself: FreeParent <- FreeChild <- FreeGrandchild.
648 : : // When FreeParent is added, a modified entry will be created for FreeChild + FreeGrandchild
649 : : // FreeParent's prioritisation should not be included in that entry.
650 : : // When FreeChild is included, FreeChild's prioritisation should also not be included.
651 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
652 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
653 [ + - ]: 1 : Txid hashFreeParent = tx.GetHash();
654 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
655 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeParent, 10 * COIN);
656 : :
657 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeParent;
658 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
659 [ + - ]: 1 : Txid hashFreeChild = tx.GetHash();
660 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
661 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeChild, 1 * COIN);
662 : :
663 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeChild;
664 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
665 [ + - ]: 1 : Txid hashFreeGrandchild = tx.GetHash();
666 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
667 : :
668 [ + - ]: 1 : auto block_template = mining->createNewBlock(options);
669 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
670 [ + - ]: 1 : CBlock block{block_template->getBlock()};
671 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
+ - ]
672 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashFreeParent);
+ - ]
673 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashFreePrioritisedTx);
+ - ]
674 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashParentTx);
+ - ]
675 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashPrioritsedChild);
+ - ]
676 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashFreeChild);
677 [ - + + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
678 : : // The FreeParent and FreeChild's prioritisations should not impact the child.
679 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeGrandchild);
+ - ]
680 : : // De-prioritised transaction should not be included.
681 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashMediumFeeTx);
682 : : }
683 [ + - ]: 3 : }
684 : :
685 : : // NOTE: These tests rely on CreateNewBlock doing its own self-validation!
686 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(CreateNewBlock_validity)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
687 : : {
688 : 1 : auto mining{MakeMining()};
689 [ + - + - ]: 2 : BOOST_REQUIRE(mining);
690 : :
691 : : // Note that by default, these tests run with size accounting enabled.
692 [ + - ]: 1 : CScript scriptPubKey = CScript() << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f"_hex << OP_CHECKSIG;
693 [ + - ]: 1 : BlockAssembler::Options options;
694 : 1 : options.coinbase_output_script = scriptPubKey;
695 : :
696 : : // Create and check a simple template
697 [ + - ]: 1 : std::unique_ptr<BlockTemplate> block_template = mining->createNewBlock(options);
698 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
699 : 1 : {
700 [ + - ]: 1 : CBlock block{block_template->getBlock()};
701 : 1 : {
702 [ + - ]: 1 : std::string reason;
703 : 1 : std::string debug;
704 [ + - + - : 2 : BOOST_REQUIRE(!mining->checkBlock(block, {.check_pow = false}, reason, debug));
+ - + - ]
705 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "bad-txnmrklroot");
706 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "hashMerkleRoot mismatch");
707 : 1 : }
708 : :
709 [ + - ]: 1 : block.hashMerkleRoot = BlockMerkleRoot(block);
710 : :
711 : 1 : {
712 [ + - ]: 1 : std::string reason;
713 : 1 : std::string debug;
714 [ + - + - : 2 : BOOST_REQUIRE(mining->checkBlock(block, {.check_pow = false}, reason, debug));
+ - + - ]
715 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "");
716 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "");
717 : 1 : }
718 : :
719 : 1 : {
720 : : // A block template does not have proof-of-work, but it might pass
721 : : // verification by coincidence. Grind the nonce if needed:
722 [ + - + - : 1 : while (CheckProofOfWork(block.GetHash(), block.nBits, Assert(m_node.chainman)->GetParams().GetConsensus())) {
+ - - + ]
723 : 0 : block.nNonce++;
724 : : }
725 : :
726 [ + - ]: 1 : std::string reason;
727 : 1 : std::string debug;
728 [ + - + - : 2 : BOOST_REQUIRE(!mining->checkBlock(block, {.check_pow = true}, reason, debug));
+ - + - ]
729 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "high-hash");
730 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "proof of work failed");
731 : 1 : }
732 : 0 : }
733 : :
734 : : // We can't make transactions until we have inputs
735 : : // Therefore, load 110 blocks :)
736 : 1 : static_assert(std::size(BLOCKINFO) == 110, "Should have 110 blocks to import");
737 : 1 : int baseheight = 0;
738 : 1 : std::vector<CTransactionRef> txFirst;
739 [ + + ]: 111 : for (const auto& bi : BLOCKINFO) {
740 [ + - ]: 110 : const int current_height{mining->getTip()->height};
741 : :
742 : : /**
743 : : * Simple block creation, nothing special yet.
744 : : * If current_height is odd, block_template will have already been
745 : : * set at the end of the previous loop.
746 : : */
747 [ + + ]: 110 : if (current_height % 2 == 0) {
748 [ + - ]: 110 : block_template = mining->createNewBlock(options);
749 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
750 : : }
751 : :
752 [ + - ]: 110 : CBlock block{block_template->getBlock()};
753 [ + - ]: 110 : CMutableTransaction txCoinbase(*block.vtx[0]);
754 : 110 : {
755 [ + - ]: 110 : LOCK(cs_main);
756 : 110 : block.nVersion = VERSIONBITS_TOP_BITS;
757 [ + - + - : 220 : block.nTime = Assert(m_node.chainman)->ActiveChain().Tip()->GetMedianTimePast()+1;
- + ]
758 : 110 : txCoinbase.version = 1;
759 [ + - + - ]: 110 : txCoinbase.vin[0].scriptSig = CScript{} << (current_height + 1) << bi.extranonce;
760 [ + - ]: 110 : txCoinbase.vout.resize(1); // Ignore the (optional) segwit commitment added by CreateNewBlock (as the hardcoded nonces don't account for this)
761 : 110 : txCoinbase.vout[0].scriptPubKey = CScript();
762 [ + - - + ]: 220 : block.vtx[0] = MakeTransactionRef(txCoinbase);
763 [ - + + + ]: 110 : if (txFirst.size() == 0)
764 : 1 : baseheight = current_height;
765 [ + + ]: 110 : if (txFirst.size() < 4)
766 [ + - ]: 4 : txFirst.push_back(block.vtx[0]);
767 [ + - ]: 110 : block.hashMerkleRoot = BlockMerkleRoot(block);
768 [ + - ]: 110 : block.nNonce = bi.nonce;
769 : 0 : }
770 [ + - ]: 110 : std::shared_ptr<const CBlock> shared_pblock = std::make_shared<const CBlock>(block);
771 : : // Alternate calls between Chainman's ProcessNewBlock and submitSolution
772 : : // via the Mining interface. The former is used by net_processing as well
773 : : // as the submitblock RPC.
774 [ + + ]: 110 : if (current_height % 2 == 0) {
775 [ + - + - : 110 : BOOST_REQUIRE(Assert(m_node.chainman)->ProcessNewBlock(shared_pblock, /*force_processing=*/true, /*min_pow_checked=*/true, nullptr));
+ - + - ]
776 : : } else {
777 [ + - + - : 165 : BOOST_REQUIRE(block_template->submitSolution(block.nVersion, block.nTime, block.nNonce, MakeTransactionRef(txCoinbase)));
+ - + - -
+ ]
778 : : }
779 : 110 : {
780 [ + - ]: 110 : LOCK(cs_main);
781 : : // The above calls don't guarantee the tip is actually updated, so
782 : : // we explicitly check this.
783 [ + - + - : 110 : auto maybe_new_tip{Assert(m_node.chainman)->ActiveChain().Tip()};
- + ]
784 [ + - + - : 110 : BOOST_REQUIRE_EQUAL(maybe_new_tip->GetBlockHash(), block.GetHash());
+ - + - ]
785 : 0 : }
786 [ + + ]: 110 : if (current_height % 2 == 0) {
787 [ + - ]: 110 : block_template = block_template->waitNext();
788 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
789 : : } else {
790 : : // This just adds coverage
791 [ + - ]: 55 : mining->waitTipChanged(block.hashPrevBlock);
792 : : }
793 : 220 : }
794 : :
795 [ + - ]: 1 : LOCK(cs_main);
796 : :
797 [ + - ]: 1 : TestBasicMining(scriptPubKey, txFirst, baseheight);
798 : :
799 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
800 [ + - ]: 1 : SetMockTime(0);
801 : :
802 [ + - ]: 1 : TestPackageSelection(scriptPubKey, txFirst);
803 : :
804 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
805 [ + - ]: 1 : SetMockTime(0);
806 : :
807 [ + - ]: 1 : TestPrioritisedMining(scriptPubKey, txFirst);
808 : 1 : }
809 : :
810 : : BOOST_AUTO_TEST_SUITE_END()
|
