Branch data Line data Source code
1 : : // Copyright (c) 2011-present The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <addresstype.h>
6 : : #include <coins.h>
7 : : #include <common/system.h>
8 : : #include <consensus/consensus.h>
9 : : #include <consensus/merkle.h>
10 : : #include <consensus/tx_verify.h>
11 : : #include <interfaces/mining.h>
12 : : #include <node/miner.h>
13 : : #include <policy/policy.h>
14 : : #include <test/util/random.h>
15 : : #include <test/util/transaction_utils.h>
16 : : #include <test/util/txmempool.h>
17 : : #include <txmempool.h>
18 : : #include <uint256.h>
19 : : #include <util/check.h>
20 : : #include <util/feefrac.h>
21 : : #include <util/strencodings.h>
22 : : #include <util/time.h>
23 : : #include <util/translation.h>
24 : : #include <validation.h>
25 : : #include <versionbits.h>
26 : : #include <pow.h>
27 : :
28 : : #include <test/util/setup_common.h>
29 : :
30 : : #include <memory>
31 : : #include <vector>
32 : :
33 : : #include <boost/test/unit_test.hpp>
34 : :
35 : : using namespace util::hex_literals;
36 : : using interfaces::BlockTemplate;
37 : : using interfaces::Mining;
38 : : using node::BlockAssembler;
39 : :
40 : : namespace miner_tests {
41 : 2 : struct MinerTestingSetup : public TestingSetup {
42 : : void TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
43 : : void TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
44 : : void TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
45 : 8 : bool TestSequenceLocks(const CTransaction& tx, CTxMemPool& tx_mempool) EXCLUSIVE_LOCKS_REQUIRED(::cs_main)
46 : : {
47 : 8 : CCoinsViewMemPool view_mempool{&m_node.chainman->ActiveChainstate().CoinsTip(), tx_mempool};
48 [ + - - + ]: 8 : CBlockIndex* tip{m_node.chainman->ActiveChain().Tip()};
49 [ + - ]: 8 : const std::optional<LockPoints> lock_points{CalculateLockPointsAtTip(tip, view_mempool, tx)};
50 [ + - + - : 16 : return lock_points.has_value() && CheckSequenceLocksAtTip(tip, *lock_points);
+ + ]
51 : 8 : }
52 : 11 : CTxMemPool& MakeMempool()
53 : : {
54 : : // Delete the previous mempool to ensure with valgrind that the old
55 : : // pointer is not accessed, when the new one should be accessed
56 : : // instead.
57 [ + - ]: 11 : m_node.mempool.reset();
58 [ + - ]: 11 : bilingual_str error;
59 [ + - ]: 11 : auto opts = MemPoolOptionsForTest(m_node);
60 : : // The "block size > limit" test creates a cluster of 1192590 vbytes,
61 : : // so set the cluster vbytes limit big enough so that the txgraph
62 : : // doesn't become oversized.
63 : 11 : opts.limits.cluster_size_vbytes = 1'200'000;
64 [ + - ]: 11 : m_node.mempool = std::make_unique<CTxMemPool>(opts, error);
65 [ - + ]: 11 : Assert(error.empty());
66 : 11 : return *m_node.mempool;
67 : 11 : }
68 : 4 : std::unique_ptr<Mining> MakeMining()
69 : : {
70 : 4 : return interfaces::MakeMining(m_node);
71 : : }
72 : : };
73 : : } // namespace miner_tests
74 : :
75 : : BOOST_FIXTURE_TEST_SUITE(miner_tests, MinerTestingSetup)
76 : :
77 : : static CFeeRate blockMinFeeRate = CFeeRate(DEFAULT_BLOCK_MIN_TX_FEE);
78 : :
79 : : constexpr static struct {
80 : : unsigned int extranonce;
81 : : unsigned int nonce;
82 : : } BLOCKINFO[]{{0, 3552706918}, {500, 37506755}, {1000, 948987788}, {400, 524762339}, {800, 258510074}, {300, 102309278},
83 : : {1300, 54365202}, {600, 1107740426}, {1000, 203094491}, {900, 391178848}, {800, 381177271}, {600, 87188412},
84 : : {0, 66522866}, {800, 874942736}, {1000, 89200838}, {400, 312638088}, {400, 66263693}, {500, 924648304},
85 : : {400, 369913599}, {500, 47630099}, {500, 115045364}, {100, 277026602}, {1100, 809621409}, {700, 155345322},
86 : : {800, 943579953}, {400, 28200730}, {900, 77200495}, {0, 105935488}, {400, 698721821}, {500, 111098863},
87 : : {1300, 445389594}, {500, 621849894}, {1400, 56010046}, {1100, 370669776}, {1200, 380301940}, {1200, 110654905},
88 : : {400, 213771024}, {1500, 120014726}, {1200, 835019014}, {1500, 624817237}, {900, 1404297}, {400, 189414558},
89 : : {400, 293178348}, {1100, 15393789}, {600, 396764180}, {800, 1387046371}, {800, 199368303}, {700, 111496662},
90 : : {100, 129759616}, {200, 536577982}, {500, 125881300}, {500, 101053391}, {1200, 471590548}, {900, 86957729},
91 : : {1200, 179604104}, {600, 68658642}, {1000, 203295701}, {500, 139615361}, {900, 233693412}, {300, 153225163},
92 : : {0, 27616254}, {1200, 9856191}, {100, 220392722}, {200, 66257599}, {1100, 145489641}, {1300, 37859442},
93 : : {400, 5816075}, {1200, 215752117}, {1400, 32361482}, {1400, 6529223}, {500, 143332977}, {800, 878392},
94 : : {700, 159290408}, {400, 123197595}, {700, 43988693}, {300, 304224916}, {700, 214771621}, {1100, 274148273},
95 : : {400, 285632418}, {1100, 923451065}, {600, 12818092}, {1200, 736282054}, {1000, 246683167}, {600, 92950402},
96 : : {1400, 29223405}, {1000, 841327192}, {700, 174301283}, {1400, 214009854}, {1000, 6989517}, {1200, 278226956},
97 : : {700, 540219613}, {400, 93663104}, {1100, 152345635}, {1500, 464194499}, {1300, 333850111}, {600, 258311263},
98 : : {600, 90173162}, {1000, 33590797}, {1500, 332866027}, {100, 204704427}, {1000, 463153545}, {800, 303244785},
99 : : {600, 88096214}, {0, 137477892}, {1200, 195514506}, {300, 704114595}, {900, 292087369}, {1400, 758684870},
100 : : {1300, 163493028}, {1200, 53151293}};
101 : :
102 : 2 : static std::unique_ptr<CBlockIndex> CreateBlockIndex(int nHeight, CBlockIndex* active_chain_tip) EXCLUSIVE_LOCKS_REQUIRED(cs_main)
103 : : {
104 : 2 : auto index{std::make_unique<CBlockIndex>()};
105 : 2 : index->nHeight = nHeight;
106 : 2 : index->pprev = active_chain_tip;
107 : 2 : return index;
108 : : }
109 : :
110 : : // Test suite for ancestor feerate transaction selection.
111 : : // Implemented as an additional function, rather than a separate test case,
112 : : // to allow reusing the blockchain created in CreateNewBlock_validity.
113 : 1 : void MinerTestingSetup::TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
114 : : {
115 : 1 : CTxMemPool& tx_mempool{MakeMempool()};
116 : 1 : auto mining{MakeMining()};
117 [ + - ]: 1 : BlockAssembler::Options options;
118 : 1 : options.coinbase_output_script = scriptPubKey;
119 : 1 : options.include_dummy_extranonce = true;
120 : :
121 [ + - ]: 1 : LOCK(tx_mempool.cs);
122 [ + - + - : 2 : BOOST_CHECK(tx_mempool.size() == 0);
+ - + - ]
123 : :
124 : : // Block template should only have a coinbase when there's nothing in the mempool
125 [ + - ]: 1 : std::unique_ptr<BlockTemplate> block_template = mining->createNewBlock(options);
126 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
127 [ + - ]: 1 : CBlock block{block_template->getBlock()};
128 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 1U);
+ - ]
129 : :
130 : : // waitNext() on an empty mempool should return nullptr because there is no better template
131 [ + - ]: 1 : auto should_be_nullptr = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 1});
132 [ + - + - : 2 : BOOST_REQUIRE(should_be_nullptr == nullptr);
+ - ]
133 : :
134 : : // Unless fee_threshold is 0
135 [ + - ]: 2 : block_template = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 0});
136 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
137 : :
138 : : // Test the ancestor feerate transaction selection.
139 : 1 : TestMemPoolEntryHelper entry;
140 : :
141 : : // Test that a medium fee transaction will be selected after a higher fee
142 : : // rate package with a low fee rate parent.
143 [ + - ]: 1 : CMutableTransaction tx;
144 [ + - ]: 1 : tx.vin.resize(1);
145 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
146 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
147 : 1 : tx.vin[0].prevout.n = 0;
148 [ + - ]: 1 : tx.vout.resize(1);
149 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 1000;
150 : : // This tx has a low fee: 1000 satoshis
151 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
152 [ + - ]: 1 : const auto parent_tx{entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
153 [ + - ]: 1 : TryAddToMempool(tx_mempool, parent_tx);
154 : :
155 : : // This tx has a medium fee: 10000 satoshis
156 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
157 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
158 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
159 [ + - ]: 1 : const auto medium_fee_tx{entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
160 [ + - ]: 1 : TryAddToMempool(tx_mempool, medium_fee_tx);
161 : :
162 : : // This tx has a high fee, but depends on the first transaction
163 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
164 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 50k satoshi fee
165 [ + - ]: 1 : Txid hashHighFeeTx = tx.GetHash();
166 [ + - ]: 1 : const auto high_fee_tx{entry.Fee(50000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx)};
167 [ + - ]: 1 : TryAddToMempool(tx_mempool, high_fee_tx);
168 : :
169 [ + - ]: 2 : block_template = mining->createNewBlock(options);
170 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
171 [ + - ]: 1 : block = block_template->getBlock();
172 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 4U);
+ - ]
173 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashParentTx);
+ - ]
174 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashHighFeeTx);
+ - ]
175 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashMediumFeeTx);
+ - ]
176 : :
177 : : // Test the inclusion of package feerates in the block template and ensure they are sequential.
178 [ + - + - : 1 : const auto block_package_feerates = BlockAssembler{m_node.chainman->ActiveChainstate(), &tx_mempool, options}.CreateNewBlock()->m_package_feerates;
+ - + - ]
179 [ + - - + : 2 : BOOST_CHECK(block_package_feerates.size() == 2);
+ - + - ]
180 : :
181 : : // parent_tx and high_fee_tx are added to the block as a package.
182 : 1 : const auto combined_txs_fee = parent_tx.GetFee() + high_fee_tx.GetFee();
183 [ + - + - ]: 1 : const auto combined_txs_size = parent_tx.GetTxSize() + high_fee_tx.GetTxSize();
184 [ + - ]: 1 : FeeFrac package_feefrac{combined_txs_fee, combined_txs_size};
185 : : // The package should be added first.
186 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[0] == package_feefrac);
+ - + - ]
187 : :
188 : : // The medium_fee_tx should be added next.
189 [ + - + - ]: 1 : FeeFrac medium_tx_feefrac{medium_fee_tx.GetFee(), medium_fee_tx.GetTxSize()};
190 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[1] == medium_tx_feefrac);
+ - + - ]
191 : :
192 : : // Test that a package below the block min tx fee doesn't get included
193 [ + - ]: 1 : tx.vin[0].prevout.hash = hashHighFeeTx;
194 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 0 fee
195 [ + - ]: 1 : Txid hashFreeTx = tx.GetHash();
196 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).FromTx(tx));
197 : 1 : uint64_t freeTxSize{::GetSerializeSize(TX_WITH_WITNESS(tx))};
198 : :
199 : : // Calculate a fee on child transaction that will put the package just
200 : : // below the block min tx fee (assuming 1 child tx of the same size).
201 [ + - ]: 1 : CAmount feeToUse = blockMinFeeRate.GetFee(2*freeTxSize) - 1;
202 : :
203 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx;
204 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000 - feeToUse;
205 [ + - ]: 1 : Txid hashLowFeeTx = tx.GetHash();
206 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(feeToUse).FromTx(tx));
207 : :
208 : : // waitNext() should return nullptr because there is no better template
209 [ + - ]: 2 : should_be_nullptr = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 1});
210 [ + - + - : 2 : BOOST_REQUIRE(should_be_nullptr == nullptr);
+ - ]
211 : :
212 [ + - ]: 1 : block = block_template->getBlock();
213 : : // Verify that the free tx and the low fee tx didn't get selected
214 [ - + + + ]: 5 : for (size_t i=0; i<block.vtx.size(); ++i) {
215 [ + - + - : 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx);
+ - ]
216 [ + - + - ]: 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx);
217 : : }
218 : :
219 : : // Test that packages above the min relay fee do get included, even if one
220 : : // of the transactions is below the min relay fee
221 : : // Remove the low fee transaction and replace with a higher fee transaction
222 [ + - + - ]: 1 : tx_mempool.removeRecursive(CTransaction(tx), MemPoolRemovalReason::REPLACED);
223 [ + - ]: 1 : tx.vout[0].nValue -= 2; // Now we should be just over the min relay fee
224 [ + - ]: 1 : hashLowFeeTx = tx.GetHash();
225 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(feeToUse + 2).FromTx(tx));
226 : :
227 : : // waitNext() should return if fees for the new template are at least 1 sat up
228 [ + - ]: 2 : block_template = block_template->waitNext({.fee_threshold = 1});
229 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
230 [ + - ]: 1 : block = block_template->getBlock();
231 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
+ - ]
232 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashFreeTx);
+ - ]
233 [ + - + - : 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashLowFeeTx);
+ - ]
234 : :
235 : : // Test that transaction selection properly updates ancestor fee
236 : : // calculations as ancestor transactions get included in a block.
237 : : // Add a 0-fee transaction that has 2 outputs.
238 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
239 [ + - ]: 1 : tx.vout.resize(2);
240 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000;
241 : 1 : tx.vout[1].nValue = 100000000; // 1BTC output
242 : : // Increase size to avoid rounding errors: when the feerate is extremely small (i.e. 1sat/kvB), evaluating the fee
243 : : // at smaller sizes gives us rounded values that are equal to each other, which means we incorrectly include
244 : : // hashFreeTx2 + hashLowFeeTx2.
245 [ + - ]: 1 : BulkTransaction(tx, 4000);
246 [ + - ]: 1 : Txid hashFreeTx2 = tx.GetHash();
247 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
248 : :
249 : : // This tx can't be mined by itself
250 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx2;
251 [ + - ]: 1 : tx.vout.resize(1);
252 [ + - ]: 1 : feeToUse = blockMinFeeRate.GetFee(freeTxSize);
253 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000 - feeToUse;
254 [ + - ]: 1 : Txid hashLowFeeTx2 = tx.GetHash();
255 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(feeToUse).SpendsCoinbase(false).FromTx(tx));
256 [ + - ]: 2 : block_template = mining->createNewBlock(options);
257 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
258 [ + - ]: 1 : block = block_template->getBlock();
259 : :
260 : : // Verify that this tx isn't selected.
261 [ - + + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
262 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx2);
+ - ]
263 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx2);
264 : : }
265 : :
266 : : // This tx will be mineable, and should cause hashLowFeeTx2 to be selected
267 : : // as well.
268 [ + - ]: 1 : tx.vin[0].prevout.n = 1;
269 : 1 : tx.vout[0].nValue = 100000000 - 10000; // 10k satoshi fee
270 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(10000).FromTx(tx));
271 [ + - ]: 2 : block_template = mining->createNewBlock(options);
272 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
273 [ + - ]: 1 : block = block_template->getBlock();
274 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 9U);
+ - ]
275 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[8]->GetHash() == hashLowFeeTx2);
276 [ + - ]: 3 : }
277 : :
278 : 2 : std::vector<CTransactionRef> CreateBigSigOpsCluster(const CTransactionRef& first_tx)
279 : : {
280 : 2 : std::vector<CTransactionRef> ret;
281 : :
282 [ + - ]: 2 : CMutableTransaction tx;
283 : : // block sigops > limit: 1000 CHECKMULTISIG + 1
284 [ + - ]: 2 : tx.vin.resize(1);
285 : : // NOTE: OP_NOP is used to force 20 SigOps for the CHECKMULTISIG
286 [ + - + - : 2 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_0 << OP_CHECKSIG << OP_1;
+ - + - ]
287 [ + - ]: 2 : tx.vin[0].prevout.hash = first_tx->GetHash();
288 : 2 : tx.vin[0].prevout.n = 0;
289 [ + - ]: 2 : tx.vout.resize(50);
290 [ + + ]: 102 : for (auto &out : tx.vout) {
291 [ + - ]: 100 : out.nValue = first_tx->vout[0].nValue / 50;
292 [ + - ]: 100 : out.scriptPubKey = CScript() << OP_1;
293 : : }
294 : :
295 [ + - ]: 2 : tx.vout[0].nValue -= CENT;
296 [ + - ]: 2 : CTransactionRef parent_tx = MakeTransactionRef(tx);
297 [ + - ]: 2 : ret.push_back(parent_tx);
298 [ + - + - ]: 2 : assert(GetLegacySigOpCount(*parent_tx) == 1);
299 : :
300 : : // Tx1 has 1 sigops, 1 input, 50 outputs.
301 : : // Tx2-51 has 400 sigops: 1 input, 20 CHECKMULTISIG outputs
302 : : // Total: 1000 CHECKMULTISIG + 1
303 [ + + ]: 102 : for (unsigned int i = 0; i < 50; ++i) {
304 [ + - ]: 100 : auto tx2 = tx;
305 [ + - ]: 100 : tx2.vin.resize(1);
306 [ + - ]: 100 : tx2.vin[0].prevout.hash = parent_tx->GetHash();
307 : 100 : tx2.vin[0].prevout.n = i;
308 [ + - ]: 100 : tx2.vin[0].scriptSig = CScript() << OP_1;
309 [ + - ]: 100 : tx2.vout.resize(20);
310 : 100 : tx2.vout[0].nValue = parent_tx->vout[i].nValue - CENT;
311 [ + + ]: 2100 : for (auto &out : tx2.vout) {
312 : 2000 : out.nValue = 0;
313 [ + - + - : 2000 : out.scriptPubKey = CScript() << OP_0 << OP_0 << OP_0 << OP_NOP << OP_CHECKMULTISIG << OP_1;
+ - + - +
- + - ]
314 : : }
315 [ + - + - : 200 : ret.push_back(MakeTransactionRef(tx2));
- + ]
316 : 100 : }
317 [ + - ]: 2 : return ret;
318 : 4 : }
319 : :
320 : 1 : void MinerTestingSetup::TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight)
321 : : {
322 : 1 : Txid hash;
323 : 1 : CMutableTransaction tx;
324 : 1 : TestMemPoolEntryHelper entry;
325 : 1 : entry.nFee = 11;
326 : 1 : entry.nHeight = 11;
327 : :
328 : 1 : const CAmount BLOCKSUBSIDY = 50 * COIN;
329 : 1 : const CAmount LOWFEE = CENT;
330 : 1 : const CAmount HIGHFEE = COIN;
331 : 1 : const CAmount HIGHERFEE = 4 * COIN;
332 : :
333 [ + - ]: 1 : auto mining{MakeMining()};
334 [ + - + - : 2 : BOOST_REQUIRE(mining);
+ - ]
335 : :
336 [ + - ]: 1 : BlockAssembler::Options options;
337 : 1 : options.coinbase_output_script = scriptPubKey;
338 : 1 : options.include_dummy_extranonce = true;
339 : :
340 : 1 : {
341 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
342 [ + - ]: 1 : LOCK(tx_mempool.cs);
343 : :
344 : : // Just to make sure we can still make simple blocks
345 [ + - ]: 1 : auto block_template{mining->createNewBlock(options)};
346 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
347 [ + - ]: 1 : CBlock block{block_template->getBlock()};
348 : :
349 [ + - ]: 1 : auto txs = CreateBigSigOpsCluster(txFirst[0]);
350 : :
351 : 1 : int64_t legacy_sigops = 0;
352 [ + + ]: 52 : for (auto& t : txs) {
353 : : // If we don't set the number of sigops in the CTxMemPoolEntry,
354 : : // template creation fails during sanity checks.
355 [ + - + - ]: 51 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(t));
356 [ + - ]: 51 : legacy_sigops += GetLegacySigOpCount(*t);
357 [ + - + - : 102 : BOOST_CHECK(tx_mempool.GetIter(t->GetHash()).has_value());
+ - ]
358 : : }
359 [ - + ]: 1 : assert(tx_mempool.mapTx.size() == 51);
360 [ - + ]: 1 : assert(legacy_sigops == 20001);
361 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-blk-sigops"));
- - - - -
+ + - + -
+ - ]
362 [ + - ]: 1 : }
363 : :
364 : 1 : {
365 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
366 [ + - ]: 1 : LOCK(tx_mempool.cs);
367 : :
368 : : // Check that the mempool is empty.
369 [ - + ]: 1 : assert(tx_mempool.mapTx.empty());
370 : :
371 : : // Just to make sure we can still make simple blocks
372 [ + - ]: 1 : auto block_template{mining->createNewBlock(options)};
373 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
374 [ + - ]: 1 : CBlock block{block_template->getBlock()};
375 : :
376 [ + - ]: 1 : auto txs = CreateBigSigOpsCluster(txFirst[0]);
377 : :
378 : 1 : int64_t legacy_sigops = 0;
379 [ + + ]: 52 : for (auto& t : txs) {
380 [ + - + - : 51 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).SigOpsCost(GetLegacySigOpCount(*t)*WITNESS_SCALE_FACTOR).FromTx(t));
+ - ]
381 [ + - ]: 51 : legacy_sigops += GetLegacySigOpCount(*t);
382 [ + - + - : 102 : BOOST_CHECK(tx_mempool.GetIter(t->GetHash()).has_value());
+ - ]
383 : : }
384 [ - + ]: 1 : assert(tx_mempool.mapTx.size() == 51);
385 [ - + ]: 1 : assert(legacy_sigops == 20001);
386 : :
387 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - ]
388 [ + - ]: 1 : }
389 : :
390 : 1 : {
391 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
392 [ + - ]: 1 : LOCK(tx_mempool.cs);
393 : :
394 : : // block size > limit
395 [ + - ]: 1 : tx.vin.resize(1);
396 [ + - ]: 1 : tx.vout.resize(1);
397 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
398 : : // 36 * (520char + DROP) + OP_1 = 18757 bytes
399 [ + - ]: 1 : std::vector<unsigned char> vchData(520);
400 [ + + ]: 19 : for (unsigned int i = 0; i < 18; ++i) {
401 [ - + + - ]: 18 : tx.vin[0].scriptSig << vchData << OP_DROP;
402 [ - + + - ]: 18 : tx.vout[0].scriptPubKey << vchData << OP_DROP;
403 : : }
404 [ + - ]: 1 : tx.vin[0].scriptSig << OP_1;
405 [ + - ]: 1 : tx.vout[0].scriptPubKey << OP_1;
406 : 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
407 : 1 : tx.vin[0].prevout.n = 0;
408 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
409 [ + + ]: 64 : for (unsigned int i = 0; i < 63; ++i) {
410 [ + - ]: 63 : tx.vout[0].nValue -= LOWFEE;
411 [ + - ]: 63 : hash = tx.GetHash();
412 : 63 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
413 [ + - + - ]: 63 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).FromTx(tx));
414 [ + - + - : 126 : BOOST_CHECK(tx_mempool.GetIter(hash).has_value());
+ - ]
415 : 63 : tx.vin[0].prevout.hash = hash;
416 : : }
417 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - ]
418 [ + - ]: 1 : }
419 : :
420 : 1 : {
421 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
422 [ + - ]: 1 : LOCK(tx_mempool.cs);
423 : :
424 : : // orphan in tx_mempool, template creation fails
425 [ + - ]: 1 : hash = tx.GetHash();
426 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).FromTx(tx));
427 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
428 : 0 : }
429 : :
430 : 1 : {
431 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
432 [ + - ]: 1 : LOCK(tx_mempool.cs);
433 : :
434 : : // child with higher feerate than parent
435 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
436 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
437 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
438 [ + - ]: 1 : hash = tx.GetHash();
439 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
440 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
441 [ + - ]: 1 : tx.vin.resize(2);
442 [ + - ]: 1 : tx.vin[1].scriptSig = CScript() << OP_1;
443 [ + - ]: 1 : tx.vin[1].prevout.hash = txFirst[0]->GetHash();
444 : 1 : tx.vin[1].prevout.n = 0;
445 : 1 : tx.vout[0].nValue = tx.vout[0].nValue + BLOCKSUBSIDY - HIGHERFEE; // First txn output + fresh coinbase - new txn fee
446 [ + - ]: 1 : hash = tx.GetHash();
447 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHERFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
448 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
449 : 0 : }
450 : :
451 : 1 : {
452 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
453 [ + - ]: 1 : LOCK(tx_mempool.cs);
454 : :
455 : : // coinbase in tx_mempool, template creation fails
456 [ + - ]: 1 : tx.vin.resize(1);
457 : 1 : tx.vin[0].prevout.SetNull();
458 [ + - + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_1;
459 [ + - ]: 1 : tx.vout[0].nValue = 0;
460 [ + - ]: 1 : hash = tx.GetHash();
461 : : // give it a fee so it'll get mined
462 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
463 : : // Should throw bad-cb-multiple
464 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-cb-multiple"));
- - - - +
- - + + -
+ - + - ]
465 : 0 : }
466 : :
467 : 1 : {
468 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
469 [ + - ]: 1 : LOCK(tx_mempool.cs);
470 : :
471 : : // double spend txn pair in tx_mempool, template creation fails
472 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
473 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
474 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
475 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
476 [ + - ]: 1 : hash = tx.GetHash();
477 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
478 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_2;
479 [ + - ]: 1 : hash = tx.GetHash();
480 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
481 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
482 : 0 : }
483 : :
484 : 1 : {
485 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
486 [ + - ]: 1 : LOCK(tx_mempool.cs);
487 : :
488 : : // subsidy changing
489 [ + - - + ]: 1 : int nHeight = m_node.chainman->ActiveChain().Height();
490 : : // Create an actual 209999-long block chain (without valid blocks).
491 [ + - - + : 419780 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 209999) {
+ + ]
492 [ + - - + ]: 209889 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
493 [ + - ]: 209889 : CBlockIndex* next = new CBlockIndex();
494 [ + - ]: 209889 : next->phashBlock = new uint256(m_rng.rand256());
495 [ + - + - : 209889 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
496 : 209889 : next->pprev = prev;
497 : 209889 : next->nHeight = prev->nHeight + 1;
498 [ + - ]: 209889 : next->BuildSkip();
499 [ + - + - ]: 209889 : m_node.chainman->ActiveChain().SetTip(*next);
500 : : }
501 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - ]
502 : : // Extend to a 210000-long block chain.
503 [ + - - + : 4 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 210000) {
+ + ]
504 [ + - - + ]: 1 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
505 [ + - ]: 1 : CBlockIndex* next = new CBlockIndex();
506 [ + - ]: 1 : next->phashBlock = new uint256(m_rng.rand256());
507 [ + - + - : 1 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
508 : 1 : next->pprev = prev;
509 : 1 : next->nHeight = prev->nHeight + 1;
510 [ + - ]: 1 : next->BuildSkip();
511 [ + - + - ]: 1 : m_node.chainman->ActiveChain().SetTip(*next);
512 : : }
513 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
514 : :
515 : : // invalid p2sh txn in tx_mempool, template creation fails
516 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
517 : 1 : tx.vin[0].prevout.n = 0;
518 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
519 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - LOWFEE;
520 [ + - ]: 1 : CScript script = CScript() << OP_0;
521 [ + - + - ]: 1 : tx.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(script));
522 [ + - ]: 1 : hash = tx.GetHash();
523 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
524 [ - + ]: 1 : tx.vin[0].prevout.hash = hash;
525 [ - + + - ]: 2 : tx.vin[0].scriptSig = CScript() << std::vector<unsigned char>(script.begin(), script.end());
526 [ + - ]: 1 : tx.vout[0].nValue -= LOWFEE;
527 [ + - ]: 1 : hash = tx.GetHash();
528 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
529 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("block-script-verify-flag-failed"));
- - - - -
+ + - + -
+ - ]
530 : :
531 : : // Delete the dummy blocks again.
532 [ + - - + : 419782 : while (m_node.chainman->ActiveChain().Tip()->nHeight > nHeight) {
+ + ]
533 [ + - - + ]: 209890 : CBlockIndex* del = m_node.chainman->ActiveChain().Tip();
534 [ + - - + : 209890 : m_node.chainman->ActiveChain().SetTip(*Assert(del->pprev));
+ - ]
535 [ + - + - : 209890 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(del->pprev->GetBlockHash());
+ - ]
536 [ + - ]: 209890 : delete del->phashBlock;
537 [ + - ]: 209890 : delete del;
538 : : }
539 [ + - ]: 1 : }
540 : :
541 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
542 [ + - ]: 1 : LOCK(tx_mempool.cs);
543 : :
544 : : // non-final txs in mempool
545 [ + - - + : 2 : SetMockTime(m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1);
+ - ]
546 : 1 : const int flags{LOCKTIME_VERIFY_SEQUENCE};
547 : : // height map
548 : 1 : std::vector<int> prevheights;
549 : :
550 : : // relative height locked
551 : 1 : tx.version = 2;
552 [ + - ]: 1 : tx.vin.resize(1);
553 [ + - ]: 1 : prevheights.resize(1);
554 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash(); // only 1 transaction
555 : 1 : tx.vin[0].prevout.n = 0;
556 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
557 [ + - - + : 2 : tx.vin[0].nSequence = m_node.chainman->ActiveChain().Tip()->nHeight + 1; // txFirst[0] is the 2nd block
+ - ]
558 : 1 : prevheights[0] = baseheight + 1;
559 [ + - ]: 1 : tx.vout.resize(1);
560 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY-HIGHFEE;
561 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
562 : 1 : tx.nLockTime = 0;
563 [ + - ]: 1 : hash = tx.GetHash();
564 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
565 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + -
+ + - + -
+ - ]
566 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
567 : :
568 : 1 : {
569 [ + - - + ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
570 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 2, active_chain_tip))); // Sequence locks pass on 2nd block
+ - + - +
- + - ]
571 : : }
572 : :
573 : : // relative time locked
574 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
575 [ + - - + : 3 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | (((m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()+1-m_node.chainman->ActiveChain()[1]->GetMedianTimePast()) >> CTxIn::SEQUENCE_LOCKTIME_GRANULARITY) + 1); // txFirst[1] is the 3rd block
+ - - + +
- ]
576 : 1 : prevheights[0] = baseheight + 2;
577 [ + - ]: 1 : hash = tx.GetHash();
578 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
579 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + -
+ + - + -
+ - ]
580 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - ]
581 : :
582 : 1 : const int SEQUENCE_LOCK_TIME = 512; // Sequence locks pass 512 seconds later
583 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i)
584 [ + - - + : 33 : m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i)->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
+ - - + +
- ]
585 : 1 : {
586 [ + - - + ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
587 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 1, active_chain_tip)));
+ - + - +
- ]
588 : : }
589 : :
590 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
591 [ + - - + : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - - + +
- - + ]
592 : 11 : ancestor->nTime -= SEQUENCE_LOCK_TIME; // undo tricked MTP
593 : : }
594 : :
595 : : // absolute height locked
596 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
597 : 1 : tx.vin[0].nSequence = CTxIn::MAX_SEQUENCE_NONFINAL;
598 : 1 : prevheights[0] = baseheight + 3;
599 [ + - - + ]: 1 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
600 [ + - ]: 1 : hash = tx.GetHash();
601 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
602 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - - + -
+ + - + -
+ - ]
603 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
604 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast())); // Locktime passes on 2nd block
- + + - -
+ + - + -
+ - + - ]
605 : :
606 : : // ensure tx is final for a specific case where there is no locktime and block height is zero
607 : 1 : tx.nLockTime = 0;
608 [ + - + - : 4 : BOOST_CHECK(IsFinalTx(CTransaction(tx), /*nBlockHeight=*/0, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()));
- + + - +
- + - +
- ]
609 : :
610 : : // absolute time locked
611 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
612 [ + - - + ]: 2 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->GetMedianTimePast();
613 [ + - ]: 1 : prevheights.resize(1);
614 [ + - ]: 1 : prevheights[0] = baseheight + 4;
615 [ + - ]: 1 : hash = tx.GetHash();
616 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
617 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - - + -
+ + - + -
+ - ]
618 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
619 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1)); // Locktime passes 1 second later
- + + - -
+ + - + -
+ - + - ]
620 : :
621 : : // mempool-dependent transactions (not added)
622 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
623 [ + - - + : 2 : prevheights[0] = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
+ - ]
624 : 1 : tx.nLockTime = 0;
625 : 1 : tx.vin[0].nSequence = 0;
626 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - - + -
+ + - + -
+ - ]
627 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
628 [ + - ]: 1 : tx.vin[0].nSequence = 1;
629 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
630 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG;
631 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
632 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | 1;
633 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
634 : :
635 [ + - ]: 1 : auto block_template = mining->createNewBlock(options);
636 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
637 : :
638 : : // None of the of the absolute height/time locked tx should have made
639 : : // it into the template because we still check IsFinalTx in CreateNewBlock,
640 : : // but relative locked txs will if inconsistently added to mempool.
641 : : // For now these will still generate a valid template until BIP68 soft fork
642 [ + - ]: 1 : CBlock block{block_template->getBlock()};
643 [ + - - + : 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 3U);
+ - ]
644 : : // However if we advance height by 1 and time by SEQUENCE_LOCK_TIME, all of them should be mined
645 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
646 [ + - - + : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - - + +
- - + ]
647 : 11 : ancestor->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
648 : : }
649 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight++;
650 [ + - - + : 2 : SetMockTime(m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1);
+ - ]
651 : :
652 [ + - ]: 2 : block_template = mining->createNewBlock(options);
653 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
654 [ + - ]: 1 : block = block_template->getBlock();
655 [ + - - + : 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 5U);
+ - ]
656 [ + - ]: 3 : }
657 : :
658 : 1 : void MinerTestingSetup::TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
659 : : {
660 : 1 : auto mining{MakeMining()};
661 [ + - + - : 2 : BOOST_REQUIRE(mining);
+ - ]
662 : :
663 [ + - ]: 1 : BlockAssembler::Options options;
664 : 1 : options.coinbase_output_script = scriptPubKey;
665 : 1 : options.include_dummy_extranonce = true;
666 : :
667 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
668 [ + - ]: 1 : LOCK(tx_mempool.cs);
669 : :
670 : 1 : TestMemPoolEntryHelper entry;
671 : :
672 : : // Test that a tx below min fee but prioritised is included
673 [ + - ]: 1 : CMutableTransaction tx;
674 [ + - ]: 1 : tx.vin.resize(1);
675 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
676 : 1 : tx.vin[0].prevout.n = 0;
677 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
678 [ + - ]: 1 : tx.vout.resize(1);
679 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
680 [ + - ]: 1 : Txid hashFreePrioritisedTx = tx.GetHash();
681 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
682 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreePrioritisedTx, 5 * COIN);
683 : :
684 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
685 : 1 : tx.vin[0].prevout.n = 0;
686 : 1 : tx.vout[0].nValue = 5000000000LL - 1000;
687 : : // This tx has a low fee: 1000 satoshis
688 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
689 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
690 : :
691 : : // This tx has a medium fee: 10000 satoshis
692 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
693 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
694 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
695 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
696 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashMediumFeeTx, -5 * COIN);
697 : :
698 : : // This tx also has a low fee, but is prioritised
699 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
700 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 1000; // 1000 satoshi fee
701 [ + - ]: 1 : Txid hashPrioritsedChild = tx.GetHash();
702 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
703 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashPrioritsedChild, 2 * COIN);
704 : :
705 : : // Test that transaction selection properly updates ancestor fee calculations as prioritised
706 : : // parents get included in a block. Create a transaction with two prioritised ancestors, each
707 : : // included by itself: FreeParent <- FreeChild <- FreeGrandchild.
708 : : // When FreeParent is added, a modified entry will be created for FreeChild + FreeGrandchild
709 : : // FreeParent's prioritisation should not be included in that entry.
710 : : // When FreeChild is included, FreeChild's prioritisation should also not be included.
711 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
712 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
713 [ + - ]: 1 : Txid hashFreeParent = tx.GetHash();
714 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
715 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeParent, 10 * COIN);
716 : :
717 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeParent;
718 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
719 [ + - ]: 1 : Txid hashFreeChild = tx.GetHash();
720 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
721 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeChild, 1 * COIN);
722 : :
723 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeChild;
724 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
725 [ + - ]: 1 : Txid hashFreeGrandchild = tx.GetHash();
726 [ + - + - ]: 1 : TryAddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
727 : :
728 [ + - ]: 1 : auto block_template = mining->createNewBlock(options);
729 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
730 [ + - ]: 1 : CBlock block{block_template->getBlock()};
731 [ + - - + : 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
+ - ]
732 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashFreeParent);
+ - ]
733 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashFreePrioritisedTx);
+ - ]
734 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashParentTx);
+ - ]
735 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashPrioritsedChild);
+ - ]
736 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashFreeChild);
737 [ - + + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
738 : : // The FreeParent and FreeChild's prioritisations should not impact the child.
739 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeGrandchild);
+ - ]
740 : : // De-prioritised transaction should not be included.
741 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashMediumFeeTx);
742 : : }
743 [ + - ]: 3 : }
744 : :
745 : : // NOTE: These tests rely on CreateNewBlock doing its own self-validation!
746 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(CreateNewBlock_validity)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
747 : : {
748 : 1 : auto mining{MakeMining()};
749 [ + - + - ]: 2 : BOOST_REQUIRE(mining);
750 : :
751 : : // Note that by default, these tests run with size accounting enabled.
752 [ + - ]: 1 : CScript scriptPubKey = CScript() << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f"_hex << OP_CHECKSIG;
753 [ + - ]: 1 : BlockAssembler::Options options;
754 : 1 : options.coinbase_output_script = scriptPubKey;
755 : 1 : options.include_dummy_extranonce = true;
756 : :
757 : : // Create and check a simple template
758 [ + - ]: 1 : std::unique_ptr<BlockTemplate> block_template = mining->createNewBlock(options);
759 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
760 : 1 : {
761 [ + - ]: 1 : CBlock block{block_template->getBlock()};
762 : 1 : {
763 [ + - ]: 1 : std::string reason;
764 : 1 : std::string debug;
765 [ + - + - : 2 : BOOST_REQUIRE(!mining->checkBlock(block, {.check_pow = false}, reason, debug));
+ - + - ]
766 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "bad-txnmrklroot");
767 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "hashMerkleRoot mismatch");
768 : 1 : }
769 : :
770 [ + - ]: 1 : block.hashMerkleRoot = BlockMerkleRoot(block);
771 : :
772 : 1 : {
773 [ + - ]: 1 : std::string reason;
774 : 1 : std::string debug;
775 [ + - + - : 2 : BOOST_REQUIRE(mining->checkBlock(block, {.check_pow = false}, reason, debug));
+ - + - ]
776 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "");
777 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "");
778 : 1 : }
779 : :
780 : 1 : {
781 : : // A block template does not have proof-of-work, but it might pass
782 : : // verification by coincidence. Grind the nonce if needed:
783 [ - + + - : 1 : while (CheckProofOfWork(block.GetHash(), block.nBits, Assert(m_node.chainman)->GetParams().GetConsensus())) {
+ - - + ]
784 : 0 : block.nNonce++;
785 : : }
786 : :
787 [ + - ]: 1 : std::string reason;
788 : 1 : std::string debug;
789 [ + - + - : 2 : BOOST_REQUIRE(!mining->checkBlock(block, {.check_pow = true}, reason, debug));
+ - + - ]
790 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(reason, "high-hash");
791 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(debug, "proof of work failed");
792 : 1 : }
793 : 0 : }
794 : :
795 : : // We can't make transactions until we have inputs
796 : : // Therefore, load 110 blocks :)
797 : 1 : static_assert(std::size(BLOCKINFO) == 110, "Should have 110 blocks to import");
798 : 1 : int baseheight = 0;
799 : 1 : std::vector<CTransactionRef> txFirst;
800 [ + + ]: 111 : for (const auto& bi : BLOCKINFO) {
801 [ + - ]: 110 : const int current_height{mining->getTip()->height};
802 : :
803 : : /**
804 : : * Simple block creation, nothing special yet.
805 : : * If current_height is odd, block_template will have already been
806 : : * set at the end of the previous loop.
807 : : */
808 [ + + ]: 110 : if (current_height % 2 == 0) {
809 [ + - ]: 110 : block_template = mining->createNewBlock(options);
810 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
811 : : }
812 : :
813 [ + - ]: 110 : CBlock block{block_template->getBlock()};
814 [ + - ]: 110 : CMutableTransaction txCoinbase(*block.vtx[0]);
815 : 110 : {
816 [ + - ]: 110 : LOCK(cs_main);
817 : 110 : block.nVersion = VERSIONBITS_TOP_BITS;
818 [ - + + - : 220 : block.nTime = Assert(m_node.chainman)->ActiveChain().Tip()->GetMedianTimePast()+1;
- + ]
819 : 110 : txCoinbase.version = 1;
820 [ + - + - ]: 110 : txCoinbase.vin[0].scriptSig = CScript{} << (current_height + 1) << bi.extranonce;
821 [ + - ]: 110 : txCoinbase.vout.resize(1); // Ignore the (optional) segwit commitment added by CreateNewBlock (as the hardcoded nonces don't account for this)
822 : 110 : txCoinbase.vout[0].scriptPubKey = CScript();
823 [ + - - + ]: 220 : block.vtx[0] = MakeTransactionRef(txCoinbase);
824 [ - + + + ]: 110 : if (txFirst.size() == 0)
825 : 1 : baseheight = current_height;
826 [ + + ]: 110 : if (txFirst.size() < 4)
827 [ + - ]: 4 : txFirst.push_back(block.vtx[0]);
828 [ + - ]: 110 : block.hashMerkleRoot = BlockMerkleRoot(block);
829 [ + - ]: 110 : block.nNonce = bi.nonce;
830 : 0 : }
831 [ + - ]: 110 : std::shared_ptr<const CBlock> shared_pblock = std::make_shared<const CBlock>(block);
832 : : // Alternate calls between Chainman's ProcessNewBlock and submitSolution
833 : : // via the Mining interface. The former is used by net_processing as well
834 : : // as the submitblock RPC.
835 [ + + ]: 110 : if (current_height % 2 == 0) {
836 [ + - - + : 110 : BOOST_REQUIRE(Assert(m_node.chainman)->ProcessNewBlock(shared_pblock, /*force_processing=*/true, /*min_pow_checked=*/true, nullptr));
+ - + - ]
837 : : } else {
838 [ + - + - : 165 : BOOST_REQUIRE(block_template->submitSolution(block.nVersion, block.nTime, block.nNonce, MakeTransactionRef(txCoinbase)));
+ - + - -
+ ]
839 : : }
840 : 110 : {
841 [ + - ]: 110 : LOCK(cs_main);
842 : : // The above calls don't guarantee the tip is actually updated, so
843 : : // we explicitly check this.
844 [ - + + - : 110 : auto maybe_new_tip{Assert(m_node.chainman)->ActiveChain().Tip()};
- + ]
845 [ + - + - : 110 : BOOST_REQUIRE_EQUAL(maybe_new_tip->GetBlockHash(), block.GetHash());
+ - + - ]
846 : 0 : }
847 [ + + ]: 110 : if (current_height % 2 == 0) {
848 [ + - ]: 110 : block_template = block_template->waitNext();
849 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
850 : : } else {
851 : : // This just adds coverage
852 [ + - ]: 55 : mining->waitTipChanged(block.hashPrevBlock);
853 : : }
854 : 220 : }
855 : :
856 [ + - ]: 1 : LOCK(cs_main);
857 : :
858 [ + - ]: 1 : TestBasicMining(scriptPubKey, txFirst, baseheight);
859 : :
860 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
861 [ + - ]: 1 : SetMockTime(0);
862 : :
863 [ + - ]: 1 : TestPackageSelection(scriptPubKey, txFirst);
864 : :
865 [ + - - + ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
866 [ + - ]: 1 : SetMockTime(0);
867 : :
868 [ + - ]: 1 : TestPrioritisedMining(scriptPubKey, txFirst);
869 : 1 : }
870 : :
871 : : BOOST_AUTO_TEST_SUITE_END()
|
