Branch data Line data Source code
1 : : // Copyright (c) 2011-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <addresstype.h>
6 : : #include <coins.h>
7 : : #include <common/system.h>
8 : : #include <consensus/consensus.h>
9 : : #include <consensus/merkle.h>
10 : : #include <consensus/tx_verify.h>
11 : : #include <interfaces/mining.h>
12 : : #include <node/miner.h>
13 : : #include <policy/policy.h>
14 : : #include <test/util/random.h>
15 : : #include <test/util/txmempool.h>
16 : : #include <txmempool.h>
17 : : #include <uint256.h>
18 : : #include <util/check.h>
19 : : #include <util/feefrac.h>
20 : : #include <util/strencodings.h>
21 : : #include <util/time.h>
22 : : #include <util/translation.h>
23 : : #include <validation.h>
24 : : #include <versionbits.h>
25 : :
26 : : #include <test/util/setup_common.h>
27 : :
28 : : #include <memory>
29 : : #include <vector>
30 : :
31 : : #include <boost/test/unit_test.hpp>
32 : :
33 : : using namespace util::hex_literals;
34 : : using interfaces::BlockTemplate;
35 : : using interfaces::Mining;
36 : : using node::BlockAssembler;
37 : :
38 : : namespace miner_tests {
39 : 2 : struct MinerTestingSetup : public TestingSetup {
40 : : void TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
41 : : void TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
42 : : void TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst) EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
43 : 8 : bool TestSequenceLocks(const CTransaction& tx, CTxMemPool& tx_mempool) EXCLUSIVE_LOCKS_REQUIRED(::cs_main)
44 : : {
45 : 8 : CCoinsViewMemPool view_mempool{&m_node.chainman->ActiveChainstate().CoinsTip(), tx_mempool};
46 [ + - + - ]: 8 : CBlockIndex* tip{m_node.chainman->ActiveChain().Tip()};
47 [ + - ]: 8 : const std::optional<LockPoints> lock_points{CalculateLockPointsAtTip(tip, view_mempool, tx)};
48 [ + - + - : 16 : return lock_points.has_value() && CheckSequenceLocksAtTip(tip, *lock_points);
+ + ]
49 : 8 : }
50 : 11 : CTxMemPool& MakeMempool()
51 : : {
52 : : // Delete the previous mempool to ensure with valgrind that the old
53 : : // pointer is not accessed, when the new one should be accessed
54 : : // instead.
55 [ + - ]: 11 : m_node.mempool.reset();
56 [ + - ]: 11 : bilingual_str error;
57 [ + - + - ]: 11 : m_node.mempool = std::make_unique<CTxMemPool>(MemPoolOptionsForTest(m_node), error);
58 [ + - ]: 11 : Assert(error.empty());
59 : 11 : return *m_node.mempool;
60 : 11 : }
61 : 4 : std::unique_ptr<Mining> MakeMining()
62 : : {
63 : 4 : return interfaces::MakeMining(m_node);
64 : : }
65 : : };
66 : : } // namespace miner_tests
67 : :
68 : : BOOST_FIXTURE_TEST_SUITE(miner_tests, MinerTestingSetup)
69 : :
70 : : static CFeeRate blockMinFeeRate = CFeeRate(DEFAULT_BLOCK_MIN_TX_FEE);
71 : :
72 : : constexpr static struct {
73 : : unsigned int extranonce;
74 : : unsigned int nonce;
75 : : } BLOCKINFO[]{{0, 3552706918}, {500, 37506755}, {1000, 948987788}, {400, 524762339}, {800, 258510074}, {300, 102309278},
76 : : {1300, 54365202}, {600, 1107740426}, {1000, 203094491}, {900, 391178848}, {800, 381177271}, {600, 87188412},
77 : : {0, 66522866}, {800, 874942736}, {1000, 89200838}, {400, 312638088}, {400, 66263693}, {500, 924648304},
78 : : {400, 369913599}, {500, 47630099}, {500, 115045364}, {100, 277026602}, {1100, 809621409}, {700, 155345322},
79 : : {800, 943579953}, {400, 28200730}, {900, 77200495}, {0, 105935488}, {400, 698721821}, {500, 111098863},
80 : : {1300, 445389594}, {500, 621849894}, {1400, 56010046}, {1100, 370669776}, {1200, 380301940}, {1200, 110654905},
81 : : {400, 213771024}, {1500, 120014726}, {1200, 835019014}, {1500, 624817237}, {900, 1404297}, {400, 189414558},
82 : : {400, 293178348}, {1100, 15393789}, {600, 396764180}, {800, 1387046371}, {800, 199368303}, {700, 111496662},
83 : : {100, 129759616}, {200, 536577982}, {500, 125881300}, {500, 101053391}, {1200, 471590548}, {900, 86957729},
84 : : {1200, 179604104}, {600, 68658642}, {1000, 203295701}, {500, 139615361}, {900, 233693412}, {300, 153225163},
85 : : {0, 27616254}, {1200, 9856191}, {100, 220392722}, {200, 66257599}, {1100, 145489641}, {1300, 37859442},
86 : : {400, 5816075}, {1200, 215752117}, {1400, 32361482}, {1400, 6529223}, {500, 143332977}, {800, 878392},
87 : : {700, 159290408}, {400, 123197595}, {700, 43988693}, {300, 304224916}, {700, 214771621}, {1100, 274148273},
88 : : {400, 285632418}, {1100, 923451065}, {600, 12818092}, {1200, 736282054}, {1000, 246683167}, {600, 92950402},
89 : : {1400, 29223405}, {1000, 841327192}, {700, 174301283}, {1400, 214009854}, {1000, 6989517}, {1200, 278226956},
90 : : {700, 540219613}, {400, 93663104}, {1100, 152345635}, {1500, 464194499}, {1300, 333850111}, {600, 258311263},
91 : : {600, 90173162}, {1000, 33590797}, {1500, 332866027}, {100, 204704427}, {1000, 463153545}, {800, 303244785},
92 : : {600, 88096214}, {0, 137477892}, {1200, 195514506}, {300, 704114595}, {900, 292087369}, {1400, 758684870},
93 : : {1300, 163493028}, {1200, 53151293}};
94 : :
95 : 2 : static std::unique_ptr<CBlockIndex> CreateBlockIndex(int nHeight, CBlockIndex* active_chain_tip) EXCLUSIVE_LOCKS_REQUIRED(cs_main)
96 : : {
97 : 2 : auto index{std::make_unique<CBlockIndex>()};
98 : 2 : index->nHeight = nHeight;
99 : 2 : index->pprev = active_chain_tip;
100 : 2 : return index;
101 : : }
102 : :
103 : : // Test suite for ancestor feerate transaction selection.
104 : : // Implemented as an additional function, rather than a separate test case,
105 : : // to allow reusing the blockchain created in CreateNewBlock_validity.
106 : 1 : void MinerTestingSetup::TestPackageSelection(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
107 : : {
108 : 1 : CTxMemPool& tx_mempool{MakeMempool()};
109 : 1 : auto mining{MakeMining()};
110 [ + - ]: 1 : BlockAssembler::Options options;
111 : 1 : options.coinbase_output_script = scriptPubKey;
112 : :
113 [ + - ]: 1 : LOCK(tx_mempool.cs);
114 : : // Test the ancestor feerate transaction selection.
115 : 1 : TestMemPoolEntryHelper entry;
116 : :
117 : : // Test that a medium fee transaction will be selected after a higher fee
118 : : // rate package with a low fee rate parent.
119 [ + - ]: 1 : CMutableTransaction tx;
120 [ + - ]: 1 : tx.vin.resize(1);
121 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
122 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
123 : 1 : tx.vin[0].prevout.n = 0;
124 [ + - ]: 1 : tx.vout.resize(1);
125 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 1000;
126 : : // This tx has a low fee: 1000 satoshis
127 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
128 [ + - ]: 1 : const auto parent_tx{entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
129 [ + - ]: 1 : AddToMempool(tx_mempool, parent_tx);
130 : :
131 : : // This tx has a medium fee: 10000 satoshis
132 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
133 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
134 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
135 [ + - ]: 1 : const auto medium_fee_tx{entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx)};
136 [ + - ]: 1 : AddToMempool(tx_mempool, medium_fee_tx);
137 : :
138 : : // This tx has a high fee, but depends on the first transaction
139 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
140 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 50k satoshi fee
141 [ + - ]: 1 : Txid hashHighFeeTx = tx.GetHash();
142 [ + - ]: 1 : const auto high_fee_tx{entry.Fee(50000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx)};
143 [ + - ]: 1 : AddToMempool(tx_mempool, high_fee_tx);
144 : :
145 [ + - ]: 1 : std::unique_ptr<BlockTemplate> block_template = mining->createNewBlock(options);
146 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
147 [ + - ]: 1 : CBlock block{block_template->getBlock()};
148 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 4U);
149 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashParentTx);
+ - ]
150 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashHighFeeTx);
+ - ]
151 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashMediumFeeTx);
+ - ]
152 : :
153 : : // Test the inclusion of package feerates in the block template and ensure they are sequential.
154 [ + - + - : 1 : const auto block_package_feerates = BlockAssembler{m_node.chainman->ActiveChainstate(), &tx_mempool, options}.CreateNewBlock()->m_package_feerates;
+ - + - ]
155 [ + - + - : 2 : BOOST_CHECK(block_package_feerates.size() == 2);
+ - ]
156 : :
157 : : // parent_tx and high_fee_tx are added to the block as a package.
158 : 1 : const auto combined_txs_fee = parent_tx.GetFee() + high_fee_tx.GetFee();
159 [ + - + - ]: 1 : const auto combined_txs_size = parent_tx.GetTxSize() + high_fee_tx.GetTxSize();
160 [ + - ]: 1 : FeeFrac package_feefrac{combined_txs_fee, combined_txs_size};
161 : : // The package should be added first.
162 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[0] == package_feefrac);
+ - + - ]
163 : :
164 : : // The medium_fee_tx should be added next.
165 [ + - + - ]: 1 : FeeFrac medium_tx_feefrac{medium_fee_tx.GetFee(), medium_fee_tx.GetTxSize()};
166 [ + - + - : 3 : BOOST_CHECK(block_package_feerates[1] == medium_tx_feefrac);
+ - + - ]
167 : :
168 : : // Test that a package below the block min tx fee doesn't get included
169 [ + - ]: 1 : tx.vin[0].prevout.hash = hashHighFeeTx;
170 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000; // 0 fee
171 [ + - ]: 1 : Txid hashFreeTx = tx.GetHash();
172 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).FromTx(tx));
173 : 1 : size_t freeTxSize = ::GetSerializeSize(TX_WITH_WITNESS(tx));
174 : :
175 : : // Calculate a fee on child transaction that will put the package just
176 : : // below the block min tx fee (assuming 1 child tx of the same size).
177 [ + - ]: 1 : CAmount feeToUse = blockMinFeeRate.GetFee(2*freeTxSize) - 1;
178 : :
179 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx;
180 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 50000 - feeToUse;
181 [ + - ]: 1 : Txid hashLowFeeTx = tx.GetHash();
182 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(feeToUse).FromTx(tx));
183 : :
184 : : // waitNext() should return nullptr because there is no better template
185 [ + - ]: 1 : auto should_be_nullptr = block_template->waitNext({.timeout = MillisecondsDouble{0}, .fee_threshold = 1});
186 [ + - + - : 2 : BOOST_REQUIRE(should_be_nullptr == nullptr);
+ - ]
187 : :
188 [ + - ]: 1 : block = block_template->getBlock();
189 : : // Verify that the free tx and the low fee tx didn't get selected
190 [ + + ]: 5 : for (size_t i=0; i<block.vtx.size(); ++i) {
191 [ + - + - : 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx);
+ - ]
192 [ + - + - ]: 8 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx);
193 : : }
194 : :
195 : : // Test that packages above the min relay fee do get included, even if one
196 : : // of the transactions is below the min relay fee
197 : : // Remove the low fee transaction and replace with a higher fee transaction
198 [ + - + - ]: 1 : tx_mempool.removeRecursive(CTransaction(tx), MemPoolRemovalReason::REPLACED);
199 [ + - ]: 1 : tx.vout[0].nValue -= 2; // Now we should be just over the min relay fee
200 [ + - ]: 1 : hashLowFeeTx = tx.GetHash();
201 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(feeToUse + 2).FromTx(tx));
202 : :
203 : : // waitNext() should return if fees for the new template are at least 1 sat up
204 [ + - ]: 2 : block_template = block_template->waitNext({.fee_threshold = 1});
205 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
206 [ + - ]: 1 : block = block_template->getBlock();
207 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
208 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashFreeTx);
+ - ]
209 [ + - + - : 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashLowFeeTx);
+ - ]
210 : :
211 : : // Test that transaction selection properly updates ancestor fee
212 : : // calculations as ancestor transactions get included in a block.
213 : : // Add a 0-fee transaction that has 2 outputs.
214 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
215 [ + - ]: 1 : tx.vout.resize(2);
216 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000;
217 : 1 : tx.vout[1].nValue = 100000000; // 1BTC output
218 [ + - ]: 1 : Txid hashFreeTx2 = tx.GetHash();
219 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
220 : :
221 : : // This tx can't be mined by itself
222 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeTx2;
223 [ + - ]: 1 : tx.vout.resize(1);
224 [ + - ]: 1 : feeToUse = blockMinFeeRate.GetFee(freeTxSize);
225 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL - 100000000 - feeToUse;
226 [ + - ]: 1 : Txid hashLowFeeTx2 = tx.GetHash();
227 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(feeToUse).SpendsCoinbase(false).FromTx(tx));
228 [ + - ]: 2 : block_template = mining->createNewBlock(options);
229 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
230 [ + - ]: 1 : block = block_template->getBlock();
231 : :
232 : : // Verify that this tx isn't selected.
233 [ + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
234 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeTx2);
+ - ]
235 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashLowFeeTx2);
236 : : }
237 : :
238 : : // This tx will be mineable, and should cause hashLowFeeTx2 to be selected
239 : : // as well.
240 [ + - ]: 1 : tx.vin[0].prevout.n = 1;
241 : 1 : tx.vout[0].nValue = 100000000 - 10000; // 10k satoshi fee
242 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(10000).FromTx(tx));
243 [ + - ]: 2 : block_template = mining->createNewBlock(options);
244 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
245 [ + - ]: 1 : block = block_template->getBlock();
246 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 9U);
247 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[8]->GetHash() == hashLowFeeTx2);
248 [ + - ]: 3 : }
249 : :
250 : 1 : void MinerTestingSetup::TestBasicMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst, int baseheight)
251 : : {
252 : 1 : Txid hash;
253 : 1 : CMutableTransaction tx;
254 : 1 : TestMemPoolEntryHelper entry;
255 : 1 : entry.nFee = 11;
256 : 1 : entry.nHeight = 11;
257 : :
258 : 1 : const CAmount BLOCKSUBSIDY = 50 * COIN;
259 : 1 : const CAmount LOWFEE = CENT;
260 : 1 : const CAmount HIGHFEE = COIN;
261 : 1 : const CAmount HIGHERFEE = 4 * COIN;
262 : :
263 [ + - ]: 1 : auto mining{MakeMining()};
264 [ + - + - : 2 : BOOST_REQUIRE(mining);
+ - ]
265 : :
266 [ + - ]: 1 : BlockAssembler::Options options;
267 : 1 : options.coinbase_output_script = scriptPubKey;
268 : :
269 : 1 : {
270 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
271 [ + - ]: 1 : LOCK(tx_mempool.cs);
272 : :
273 : : // Just to make sure we can still make simple blocks
274 [ + - ]: 1 : auto block_template{mining->createNewBlock(options)};
275 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
276 [ + - ]: 1 : CBlock block{block_template->getBlock()};
277 : :
278 : : // block sigops > limit: 1000 CHECKMULTISIG + 1
279 [ + - ]: 1 : tx.vin.resize(1);
280 : : // NOTE: OP_NOP is used to force 20 SigOps for the CHECKMULTISIG
281 [ + - + - : 1 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_0 << OP_0 << OP_NOP << OP_CHECKMULTISIG << OP_1;
+ - + - +
- + - ]
282 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
283 : 1 : tx.vin[0].prevout.n = 0;
284 [ + - ]: 1 : tx.vout.resize(1);
285 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
286 [ + + ]: 1002 : for (unsigned int i = 0; i < 1001; ++i) {
287 [ + - ]: 1001 : tx.vout[0].nValue -= LOWFEE;
288 [ + - ]: 1001 : hash = tx.GetHash();
289 : 1001 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
290 : : // If we don't set the # of sig ops in the CTxMemPoolEntry, template creation fails
291 [ + - + - ]: 1001 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).FromTx(tx));
292 : 1001 : tx.vin[0].prevout.hash = hash;
293 : : }
294 : :
295 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-blk-sigops"));
- - - - -
+ + - + -
+ - ]
296 [ + - ]: 1 : }
297 : :
298 : 1 : {
299 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
300 [ + - ]: 1 : LOCK(tx_mempool.cs);
301 : :
302 : 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
303 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
304 [ + + ]: 1002 : for (unsigned int i = 0; i < 1001; ++i) {
305 [ + - ]: 1001 : tx.vout[0].nValue -= LOWFEE;
306 [ + - ]: 1001 : hash = tx.GetHash();
307 : 1001 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
308 : : // If we do set the # of sig ops in the CTxMemPoolEntry, template creation passes
309 [ + - + - ]: 1001 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).SigOpsCost(80).FromTx(tx));
310 : 1001 : tx.vin[0].prevout.hash = hash;
311 : : }
312 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
313 : 0 : }
314 : :
315 : 1 : {
316 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
317 [ + - ]: 1 : LOCK(tx_mempool.cs);
318 : :
319 : : // block size > limit
320 : 1 : tx.vin[0].scriptSig = CScript();
321 : : // 18 * (520char + DROP) + OP_1 = 9433 bytes
322 [ + - ]: 1 : std::vector<unsigned char> vchData(520);
323 [ + + ]: 19 : for (unsigned int i = 0; i < 18; ++i) {
324 [ + - ]: 18 : tx.vin[0].scriptSig << vchData << OP_DROP;
325 : : }
326 [ + - ]: 1 : tx.vin[0].scriptSig << OP_1;
327 : 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
328 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY;
329 [ + + ]: 129 : for (unsigned int i = 0; i < 128; ++i) {
330 [ + - ]: 128 : tx.vout[0].nValue -= LOWFEE;
331 [ + - ]: 128 : hash = tx.GetHash();
332 : 128 : bool spendsCoinbase = i == 0; // only first tx spends coinbase
333 [ + - + - ]: 128 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(spendsCoinbase).FromTx(tx));
334 : 128 : tx.vin[0].prevout.hash = hash;
335 : : }
336 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - ]
337 [ + - ]: 1 : }
338 : :
339 : 1 : {
340 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
341 [ + - ]: 1 : LOCK(tx_mempool.cs);
342 : :
343 : : // orphan in tx_mempool, template creation fails
344 [ + - ]: 1 : hash = tx.GetHash();
345 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).FromTx(tx));
346 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
347 : 0 : }
348 : :
349 : 1 : {
350 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
351 [ + - ]: 1 : LOCK(tx_mempool.cs);
352 : :
353 : : // child with higher feerate than parent
354 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
355 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
356 : 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
357 [ + - ]: 1 : hash = tx.GetHash();
358 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
359 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
360 [ + - ]: 1 : tx.vin.resize(2);
361 [ + - ]: 1 : tx.vin[1].scriptSig = CScript() << OP_1;
362 [ + - ]: 1 : tx.vin[1].prevout.hash = txFirst[0]->GetHash();
363 : 1 : tx.vin[1].prevout.n = 0;
364 : 1 : tx.vout[0].nValue = tx.vout[0].nValue + BLOCKSUBSIDY - HIGHERFEE; // First txn output + fresh coinbase - new txn fee
365 [ + - ]: 1 : hash = tx.GetHash();
366 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHERFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
367 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
368 : 0 : }
369 : :
370 : 1 : {
371 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
372 [ + - ]: 1 : LOCK(tx_mempool.cs);
373 : :
374 : : // coinbase in tx_mempool, template creation fails
375 [ + - ]: 1 : tx.vin.resize(1);
376 : 1 : tx.vin[0].prevout.SetNull();
377 [ + - + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_0 << OP_1;
378 [ + - ]: 1 : tx.vout[0].nValue = 0;
379 [ + - ]: 1 : hash = tx.GetHash();
380 : : // give it a fee so it'll get mined
381 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
382 : : // Should throw bad-cb-multiple
383 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-cb-multiple"));
- - - - +
- - + + -
+ - + - ]
384 : 0 : }
385 : :
386 : 1 : {
387 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
388 [ + - ]: 1 : LOCK(tx_mempool.cs);
389 : :
390 : : // double spend txn pair in tx_mempool, template creation fails
391 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
392 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
393 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
394 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
395 [ + - ]: 1 : hash = tx.GetHash();
396 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
397 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_2;
398 [ + - ]: 1 : hash = tx.GetHash();
399 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
400 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
- - - - +
- - + + -
+ - + - ]
401 : 0 : }
402 : :
403 : 1 : {
404 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
405 [ + - ]: 1 : LOCK(tx_mempool.cs);
406 : :
407 : : // subsidy changing
408 [ + - ]: 1 : int nHeight = m_node.chainman->ActiveChain().Height();
409 : : // Create an actual 209999-long block chain (without valid blocks).
410 [ + - + - : 419780 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 209999) {
+ + ]
411 [ + - + - ]: 209889 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
412 [ + - ]: 209889 : CBlockIndex* next = new CBlockIndex();
413 [ + - ]: 209889 : next->phashBlock = new uint256(m_rng.rand256());
414 [ + - + - : 209889 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
415 : 209889 : next->pprev = prev;
416 : 209889 : next->nHeight = prev->nHeight + 1;
417 [ + - ]: 209889 : next->BuildSkip();
418 [ + - + - ]: 209889 : m_node.chainman->ActiveChain().SetTip(*next);
419 : : }
420 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - ]
421 : : // Extend to a 210000-long block chain.
422 [ + - + - : 4 : while (m_node.chainman->ActiveChain().Tip()->nHeight < 210000) {
+ + ]
423 [ + - + - ]: 1 : CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
424 [ + - ]: 1 : CBlockIndex* next = new CBlockIndex();
425 [ + - ]: 1 : next->phashBlock = new uint256(m_rng.rand256());
426 [ + - + - : 1 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
+ - ]
427 : 1 : next->pprev = prev;
428 : 1 : next->nHeight = prev->nHeight + 1;
429 [ + - ]: 1 : next->BuildSkip();
430 [ + - + - ]: 1 : m_node.chainman->ActiveChain().SetTip(*next);
431 : : }
432 [ + - + - : 2 : BOOST_REQUIRE(mining->createNewBlock(options));
+ - + - ]
433 : :
434 : : // invalid p2sh txn in tx_mempool, template creation fails
435 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
436 : 1 : tx.vin[0].prevout.n = 0;
437 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
438 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY - LOWFEE;
439 [ + - ]: 1 : CScript script = CScript() << OP_0;
440 [ + - + - ]: 1 : tx.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(script));
441 [ + - ]: 1 : hash = tx.GetHash();
442 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
443 [ - + ]: 1 : tx.vin[0].prevout.hash = hash;
444 [ - + + - ]: 1 : tx.vin[0].scriptSig = CScript() << std::vector<unsigned char>(script.begin(), script.end());
445 [ + - ]: 1 : tx.vout[0].nValue -= LOWFEE;
446 [ + - ]: 1 : hash = tx.GetHash();
447 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
448 [ + - - + : 2 : BOOST_CHECK_EXCEPTION(mining->createNewBlock(options), std::runtime_error, HasReason("mandatory-script-verify-flag-failed"));
- - - - -
+ + - + -
+ - ]
449 : :
450 : : // Delete the dummy blocks again.
451 [ + - + - : 419782 : while (m_node.chainman->ActiveChain().Tip()->nHeight > nHeight) {
+ + ]
452 [ + - + - ]: 209890 : CBlockIndex* del = m_node.chainman->ActiveChain().Tip();
453 [ + - + - : 209890 : m_node.chainman->ActiveChain().SetTip(*Assert(del->pprev));
+ - ]
454 [ + - + - : 209890 : m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(del->pprev->GetBlockHash());
+ - ]
455 [ + - ]: 209890 : delete del->phashBlock;
456 [ + - ]: 209890 : delete del;
457 : : }
458 [ + - ]: 1 : }
459 : :
460 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
461 [ + - ]: 1 : LOCK(tx_mempool.cs);
462 : :
463 : : // non-final txs in mempool
464 [ + - + - : 2 : SetMockTime(m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1);
+ - ]
465 : 1 : const int flags{LOCKTIME_VERIFY_SEQUENCE};
466 : : // height map
467 : 1 : std::vector<int> prevheights;
468 : :
469 : : // relative height locked
470 : 1 : tx.version = 2;
471 [ + - ]: 1 : tx.vin.resize(1);
472 [ + - ]: 1 : prevheights.resize(1);
473 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash(); // only 1 transaction
474 : 1 : tx.vin[0].prevout.n = 0;
475 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
476 [ + - + - : 2 : tx.vin[0].nSequence = m_node.chainman->ActiveChain().Tip()->nHeight + 1; // txFirst[0] is the 2nd block
+ - ]
477 : 1 : prevheights[0] = baseheight + 1;
478 [ + - ]: 1 : tx.vout.resize(1);
479 [ + - ]: 1 : tx.vout[0].nValue = BLOCKSUBSIDY-HIGHFEE;
480 [ + - ]: 1 : tx.vout[0].scriptPubKey = CScript() << OP_1;
481 : 1 : tx.nLockTime = 0;
482 [ + - ]: 1 : hash = tx.GetHash();
483 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
484 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - + - +
- + - + -
+ - ]
485 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
486 : :
487 : 1 : {
488 [ + - + - ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
489 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 2, active_chain_tip))); // Sequence locks pass on 2nd block
+ - + - +
- + - ]
490 : : }
491 : :
492 : : // relative time locked
493 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
494 [ + - + - : 3 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | (((m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()+1-m_node.chainman->ActiveChain()[1]->GetMedianTimePast()) >> CTxIn::SEQUENCE_LOCKTIME_GRANULARITY) + 1); // txFirst[1] is the 3rd block
+ - + - +
- ]
495 : 1 : prevheights[0] = baseheight + 2;
496 [ + - ]: 1 : hash = tx.GetHash();
497 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
498 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - + - +
- + - + -
+ - ]
499 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - ]
500 : :
501 : 1 : const int SEQUENCE_LOCK_TIME = 512; // Sequence locks pass 512 seconds later
502 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i)
503 [ + - + - : 33 : m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i)->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
+ - + - +
- ]
504 : 1 : {
505 [ + - + - ]: 1 : CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
506 [ + - + - : 3 : BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 1, active_chain_tip)));
+ - + - +
- ]
507 : : }
508 : :
509 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
510 [ + - + - : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - + - +
- + - ]
511 : 11 : ancestor->nTime -= SEQUENCE_LOCK_TIME; // undo tricked MTP
512 : : }
513 : :
514 : : // absolute height locked
515 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
516 : 1 : tx.vin[0].nSequence = CTxIn::MAX_SEQUENCE_NONFINAL;
517 : 1 : prevheights[0] = baseheight + 3;
518 [ + - + - ]: 1 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
519 [ + - ]: 1 : hash = tx.GetHash();
520 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
521 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - + - +
- + - + -
+ - ]
522 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
523 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast())); // Locktime passes on 2nd block
+ - + - +
- + - + -
+ - + - ]
524 : :
525 : : // absolute time locked
526 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
527 [ + - + - ]: 2 : tx.nLockTime = m_node.chainman->ActiveChain().Tip()->GetMedianTimePast();
528 [ + - ]: 1 : prevheights.resize(1);
529 [ + - ]: 1 : prevheights[0] = baseheight + 4;
530 [ + - ]: 1 : hash = tx.GetHash();
531 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
532 [ + - + - : 4 : BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
+ - + - +
- + - + -
+ - ]
533 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
534 [ + - + - : 5 : BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1)); // Locktime passes 1 second later
+ - + - +
- + - + -
+ - + - ]
535 : :
536 : : // mempool-dependent transactions (not added)
537 [ + - ]: 1 : tx.vin[0].prevout.hash = hash;
538 [ + - + - : 2 : prevheights[0] = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
+ - ]
539 : 1 : tx.nLockTime = 0;
540 : 1 : tx.vin[0].nSequence = 0;
541 [ + - + - : 4 : BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
+ - + - +
- + - + -
+ - ]
542 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
543 [ + - ]: 1 : tx.vin[0].nSequence = 1;
544 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
545 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG;
546 [ + - + - : 3 : BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
+ - + - +
- ]
547 [ + - ]: 1 : tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | 1;
548 [ + - + - : 3 : BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
+ - + - +
- ]
549 : :
550 [ + - ]: 1 : auto block_template = mining->createNewBlock(options);
551 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
552 : :
553 : : // None of the of the absolute height/time locked tx should have made
554 : : // it into the template because we still check IsFinalTx in CreateNewBlock,
555 : : // but relative locked txs will if inconsistently added to mempool.
556 : : // For now these will still generate a valid template until BIP68 soft fork
557 [ + - ]: 1 : CBlock block{block_template->getBlock()};
558 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 3U);
559 : : // However if we advance height by 1 and time by SEQUENCE_LOCK_TIME, all of them should be mined
560 [ + + ]: 12 : for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
561 [ + - + - : 33 : CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
+ - + - +
- + - ]
562 : 11 : ancestor->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
563 : : }
564 [ + - + - ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight++;
565 [ + - + - : 2 : SetMockTime(m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1);
+ - ]
566 : :
567 [ + - ]: 2 : block_template = mining->createNewBlock(options);
568 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
569 [ + - ]: 1 : block = block_template->getBlock();
570 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(block.vtx.size(), 5U);
571 [ + - ]: 3 : }
572 : :
573 : 1 : void MinerTestingSetup::TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
574 : : {
575 : 1 : auto mining{MakeMining()};
576 [ + - + - : 2 : BOOST_REQUIRE(mining);
+ - ]
577 : :
578 [ + - ]: 1 : BlockAssembler::Options options;
579 : 1 : options.coinbase_output_script = scriptPubKey;
580 : :
581 [ + - ]: 1 : CTxMemPool& tx_mempool{MakeMempool()};
582 [ + - ]: 1 : LOCK(tx_mempool.cs);
583 : :
584 : 1 : TestMemPoolEntryHelper entry;
585 : :
586 : : // Test that a tx below min fee but prioritised is included
587 [ + - ]: 1 : CMutableTransaction tx;
588 [ + - ]: 1 : tx.vin.resize(1);
589 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[0]->GetHash();
590 : 1 : tx.vin[0].prevout.n = 0;
591 [ + - ]: 1 : tx.vin[0].scriptSig = CScript() << OP_1;
592 [ + - ]: 1 : tx.vout.resize(1);
593 [ + - ]: 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
594 [ + - ]: 1 : uint256 hashFreePrioritisedTx = tx.GetHash();
595 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
596 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreePrioritisedTx, 5 * COIN);
597 : :
598 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[1]->GetHash();
599 : 1 : tx.vin[0].prevout.n = 0;
600 : 1 : tx.vout[0].nValue = 5000000000LL - 1000;
601 : : // This tx has a low fee: 1000 satoshis
602 [ + - ]: 1 : Txid hashParentTx = tx.GetHash(); // save this txid for later use
603 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
604 : :
605 : : // This tx has a medium fee: 10000 satoshis
606 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[2]->GetHash();
607 : 1 : tx.vout[0].nValue = 5000000000LL - 10000;
608 [ + - ]: 1 : Txid hashMediumFeeTx = tx.GetHash();
609 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(10000).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
610 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashMediumFeeTx, -5 * COIN);
611 : :
612 : : // This tx also has a low fee, but is prioritised
613 [ + - ]: 1 : tx.vin[0].prevout.hash = hashParentTx;
614 : 1 : tx.vout[0].nValue = 5000000000LL - 1000 - 1000; // 1000 satoshi fee
615 [ + - ]: 1 : Txid hashPrioritsedChild = tx.GetHash();
616 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(1000).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
617 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashPrioritsedChild, 2 * COIN);
618 : :
619 : : // Test that transaction selection properly updates ancestor fee calculations as prioritised
620 : : // parents get included in a block. Create a transaction with two prioritised ancestors, each
621 : : // included by itself: FreeParent <- FreeChild <- FreeGrandchild.
622 : : // When FreeParent is added, a modified entry will be created for FreeChild + FreeGrandchild
623 : : // FreeParent's prioritisation should not be included in that entry.
624 : : // When FreeChild is included, FreeChild's prioritisation should also not be included.
625 [ + - ]: 1 : tx.vin[0].prevout.hash = txFirst[3]->GetHash();
626 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
627 [ + - ]: 1 : Txid hashFreeParent = tx.GetHash();
628 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
629 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeParent, 10 * COIN);
630 : :
631 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeParent;
632 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
633 [ + - ]: 1 : Txid hashFreeChild = tx.GetHash();
634 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
635 [ + - ]: 1 : tx_mempool.PrioritiseTransaction(hashFreeChild, 1 * COIN);
636 : :
637 [ + - ]: 1 : tx.vin[0].prevout.hash = hashFreeChild;
638 : 1 : tx.vout[0].nValue = 5000000000LL; // 0 fee
639 [ + - ]: 1 : Txid hashFreeGrandchild = tx.GetHash();
640 [ + - + - ]: 1 : AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(false).FromTx(tx));
641 : :
642 [ + - ]: 1 : auto block_template = mining->createNewBlock(options);
643 [ + - + - : 2 : BOOST_REQUIRE(block_template);
+ - ]
644 [ + - ]: 1 : CBlock block{block_template->getBlock()};
645 [ + - + - ]: 1 : BOOST_REQUIRE_EQUAL(block.vtx.size(), 6U);
646 [ + - + - : 2 : BOOST_CHECK(block.vtx[1]->GetHash() == hashFreeParent);
+ - ]
647 [ + - + - : 2 : BOOST_CHECK(block.vtx[2]->GetHash() == hashFreePrioritisedTx);
+ - ]
648 [ + - + - : 2 : BOOST_CHECK(block.vtx[3]->GetHash() == hashParentTx);
+ - ]
649 [ + - + - : 2 : BOOST_CHECK(block.vtx[4]->GetHash() == hashPrioritsedChild);
+ - ]
650 [ + - + - ]: 2 : BOOST_CHECK(block.vtx[5]->GetHash() == hashFreeChild);
651 [ + + ]: 7 : for (size_t i=0; i<block.vtx.size(); ++i) {
652 : : // The FreeParent and FreeChild's prioritisations should not impact the child.
653 [ + - + - : 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashFreeGrandchild);
+ - ]
654 : : // De-prioritised transaction should not be included.
655 [ + - + - ]: 12 : BOOST_CHECK(block.vtx[i]->GetHash() != hashMediumFeeTx);
656 : : }
657 [ + - ]: 3 : }
658 : :
659 : : // NOTE: These tests rely on CreateNewBlock doing its own self-validation!
660 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(CreateNewBlock_validity)
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- + - + -
+ - + - +
- ]
661 : : {
662 : 1 : auto mining{MakeMining()};
663 [ + - + - ]: 2 : BOOST_REQUIRE(mining);
664 : :
665 : : // Note that by default, these tests run with size accounting enabled.
666 [ + - ]: 1 : CScript scriptPubKey = CScript() << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f"_hex << OP_CHECKSIG;
667 [ + - ]: 1 : BlockAssembler::Options options;
668 : 1 : options.coinbase_output_script = scriptPubKey;
669 : 1 : std::unique_ptr<BlockTemplate> block_template;
670 : :
671 : : // We can't make transactions until we have inputs
672 : : // Therefore, load 110 blocks :)
673 : 1 : static_assert(std::size(BLOCKINFO) == 110, "Should have 110 blocks to import");
674 : 1 : int baseheight = 0;
675 : 1 : std::vector<CTransactionRef> txFirst;
676 [ + + ]: 111 : for (const auto& bi : BLOCKINFO) {
677 [ + - ]: 110 : const int current_height{mining->getTip()->height};
678 : :
679 : : /**
680 : : * Simple block creation, nothing special yet.
681 : : * If current_height is odd, block_template will have already been
682 : : * set at the end of the previous loop.
683 : : */
684 [ + + ]: 110 : if (current_height % 2 == 0) {
685 [ + - ]: 110 : block_template = mining->createNewBlock(options);
686 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
687 : : }
688 : :
689 [ + - ]: 110 : CBlock block{block_template->getBlock()};
690 [ + - ]: 110 : CMutableTransaction txCoinbase(*block.vtx[0]);
691 : 110 : {
692 [ + - ]: 110 : LOCK(cs_main);
693 : 110 : block.nVersion = VERSIONBITS_TOP_BITS;
694 [ + - + - : 220 : block.nTime = Assert(m_node.chainman)->ActiveChain().Tip()->GetMedianTimePast()+1;
+ - ]
695 : 110 : txCoinbase.version = 1;
696 [ + - + - ]: 110 : txCoinbase.vin[0].scriptSig = CScript{} << (current_height + 1) << bi.extranonce;
697 [ + - ]: 110 : txCoinbase.vout.resize(1); // Ignore the (optional) segwit commitment added by CreateNewBlock (as the hardcoded nonces don't account for this)
698 : 110 : txCoinbase.vout[0].scriptPubKey = CScript();
699 [ + - - + ]: 220 : block.vtx[0] = MakeTransactionRef(txCoinbase);
700 [ + + ]: 110 : if (txFirst.size() == 0)
701 : 1 : baseheight = current_height;
702 [ + + ]: 110 : if (txFirst.size() < 4)
703 [ + - ]: 4 : txFirst.push_back(block.vtx[0]);
704 [ + - ]: 110 : block.hashMerkleRoot = BlockMerkleRoot(block);
705 [ + - ]: 110 : block.nNonce = bi.nonce;
706 : 0 : }
707 [ + - ]: 110 : std::shared_ptr<const CBlock> shared_pblock = std::make_shared<const CBlock>(block);
708 : : // Alternate calls between Chainman's ProcessNewBlock and submitSolution
709 : : // via the Mining interface. The former is used by net_processing as well
710 : : // as the submitblock RPC.
711 [ + + ]: 110 : if (current_height % 2 == 0) {
712 [ + - + - : 110 : BOOST_REQUIRE(Assert(m_node.chainman)->ProcessNewBlock(shared_pblock, /*force_processing=*/true, /*min_pow_checked=*/true, nullptr));
+ - + - ]
713 : : } else {
714 [ + - + - : 165 : BOOST_REQUIRE(block_template->submitSolution(block.nVersion, block.nTime, block.nNonce, MakeTransactionRef(txCoinbase)));
+ - + - -
+ ]
715 : : }
716 : 110 : {
717 [ + - ]: 110 : LOCK(cs_main);
718 : : // The above calls don't guarantee the tip is actually updated, so
719 : : // we explicitly check this.
720 [ + - + - : 110 : auto maybe_new_tip{Assert(m_node.chainman)->ActiveChain().Tip()};
+ - ]
721 [ + - + - : 110 : BOOST_REQUIRE_EQUAL(maybe_new_tip->GetBlockHash(), block.GetHash());
+ - + - ]
722 : 0 : }
723 [ + + ]: 110 : if (current_height % 2 == 0) {
724 [ + - ]: 110 : block_template = block_template->waitNext();
725 [ + - + - ]: 110 : BOOST_REQUIRE(block_template);
726 : : } else {
727 : : // This just adds coverage
728 [ + - ]: 55 : mining->waitTipChanged(block.hashPrevBlock);
729 : : }
730 : 220 : }
731 : :
732 [ + - ]: 1 : LOCK(cs_main);
733 : :
734 [ + - ]: 1 : TestBasicMining(scriptPubKey, txFirst, baseheight);
735 : :
736 [ + - + - ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
737 [ + - ]: 1 : SetMockTime(0);
738 : :
739 [ + - ]: 1 : TestPackageSelection(scriptPubKey, txFirst);
740 : :
741 [ + - + - ]: 1 : m_node.chainman->ActiveChain().Tip()->nHeight--;
742 [ + - ]: 1 : SetMockTime(0);
743 : :
744 [ + - ]: 1 : TestPrioritisedMining(scriptPubKey, txFirst);
745 : 1 : }
746 : :
747 : : BOOST_AUTO_TEST_SUITE_END()
|
