Branch data Line data Source code
1 : : // Copyright (c) 2012-2022 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <addrdb.h>
6 : : #include <addrman.h>
7 : : #include <addrman_impl.h>
8 : : #include <chainparams.h>
9 : : #include <clientversion.h>
10 : : #include <hash.h>
11 : : #include <netbase.h>
12 : : #include <random.h>
13 : : #include <test/data/asmap.raw.h>
14 : : #include <test/util/setup_common.h>
15 : : #include <util/asmap.h>
16 : : #include <util/string.h>
17 : :
18 : : #include <boost/test/unit_test.hpp>
19 : :
20 : : #include <optional>
21 : : #include <string>
22 : :
23 : : using namespace std::literals;
24 : : using node::NodeContext;
25 : : using util::ToString;
26 : :
27 : : static NetGroupManager EMPTY_NETGROUPMAN{std::vector<bool>()};
28 : : static const bool DETERMINISTIC{true};
29 : :
30 : 24 : static int32_t GetCheckRatio(const NodeContext& node_ctx)
31 : : {
32 [ + - + - ]: 48 : return std::clamp<int32_t>(node_ctx.args->GetIntArg("-checkaddrman", 100), 0, 1000000);
33 : : }
34 : :
35 : 6819 : static CNetAddr ResolveIP(const std::string& ip)
36 : : {
37 [ + - ]: 6819 : const std::optional<CNetAddr> addr{LookupHost(ip, false)};
38 [ + - + - : 13638 : BOOST_CHECK_MESSAGE(addr.has_value(), strprintf("failed to resolve: %s", ip));
+ - ]
39 [ + - ]: 6819 : return addr.value_or(CNetAddr{});
40 : 6819 : }
41 : :
42 : 6631 : static CService ResolveService(const std::string& ip, uint16_t port = 0)
43 : : {
44 [ + - ]: 6631 : const std::optional<CService> serv{Lookup(ip, port, false)};
45 [ + - + - : 13262 : BOOST_CHECK_MESSAGE(serv.has_value(), strprintf("failed to resolve: %s:%i", ip, port));
+ - ]
46 [ + - ]: 6631 : return serv.value_or(CService{});
47 : 6631 : }
48 : :
49 : :
50 : 3 : static std::vector<bool> FromBytes(std::span<const std::byte> source)
51 : : {
52 : 3 : int vector_size(source.size() * 8);
53 : 3 : std::vector<bool> result(vector_size);
54 [ + + ]: 180 : for (int byte_i = 0; byte_i < vector_size / 8; ++byte_i) {
55 : 177 : uint8_t cur_byte{std::to_integer<uint8_t>(source[byte_i])};
56 [ + + ]: 1593 : for (int bit_i = 0; bit_i < 8; ++bit_i) {
57 : 1416 : result[byte_i * 8 + bit_i] = (cur_byte >> bit_i) & 1;
58 : : }
59 : : }
60 : 3 : return result;
61 : : }
62 : :
63 : : BOOST_FIXTURE_TEST_SUITE(addrman_tests, BasicTestingSetup)
64 : :
65 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_simple)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
66 : : {
67 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
68 : :
69 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
70 : :
71 : : // Test: Does Addrman respond correctly when empty.
72 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 0U);
+ - ]
73 [ + - ]: 1 : auto addr_null = addrman->Select().first;
74 [ + - + - : 1 : BOOST_CHECK_EQUAL(addr_null.ToStringAddrPort(), "[::]:0");
+ - ]
75 : :
76 : : // Test: Does Addrman::Add work as expected.
77 [ + - + - ]: 1 : CService addr1 = ResolveService("250.1.1.1", 8333);
78 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
+ - + + +
- - - ]
79 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
80 [ + - ]: 1 : auto addr_ret1 = addrman->Select().first;
81 [ + - + - : 1 : BOOST_CHECK_EQUAL(addr_ret1.ToStringAddrPort(), "250.1.1.1:8333");
+ - ]
82 : :
83 : : // Test: Does IP address deduplication work correctly.
84 : : // Expected dup IP should not be added.
85 [ + - + - ]: 1 : CService addr1_dup = ResolveService("250.1.1.1", 8333);
86 [ + - + - : 5 : BOOST_CHECK(!addrman->Add({CAddress(addr1_dup, NODE_NONE)}, source));
+ - + + +
- - - ]
87 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
88 : :
89 : :
90 : : // Test: New table has one addr and we add a diff addr we should
91 : : // have at least one addr.
92 : : // Note that addrman's size cannot be tested reliably after insertion, as
93 : : // hash collisions may occur. But we can always be sure of at least one
94 : : // success.
95 : :
96 [ + - + - ]: 1 : CService addr2 = ResolveService("250.1.1.2", 8333);
97 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
+ - + + +
- - - ]
98 [ + - + - : 2 : BOOST_CHECK(addrman->Size() >= 1);
+ - + - ]
99 : :
100 : : // Test: reset addrman and test AddrMan::Add multiple addresses works as expected
101 [ + - + - ]: 2 : addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
102 : 1 : std::vector<CAddress> vAddr;
103 [ + - + - : 2 : vAddr.emplace_back(ResolveService("250.1.1.3", 8333), NODE_NONE);
+ - ]
104 [ + - + - : 2 : vAddr.emplace_back(ResolveService("250.1.1.4", 8333), NODE_NONE);
+ - ]
105 [ + - + - : 2 : BOOST_CHECK(addrman->Add(vAddr, source));
+ - + - ]
106 [ + - + - : 2 : BOOST_CHECK(addrman->Size() >= 1);
+ - ]
107 [ + - + - : 7 : }
+ - ]
108 : :
109 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_ports)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
110 : : {
111 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
112 : :
113 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
114 : :
115 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 0U);
+ - ]
116 : :
117 : : // Test 7; Addr with same IP but diff port does not replace existing addr.
118 [ + - + - ]: 1 : CService addr1 = ResolveService("250.1.1.1", 8333);
119 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
+ - + + +
- - - ]
120 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
121 : :
122 [ + - + - ]: 1 : CService addr1_port = ResolveService("250.1.1.1", 8334);
123 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1_port, NODE_NONE)}, source));
+ - + + +
- - - ]
124 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 2U);
+ - ]
125 [ + - ]: 1 : auto addr_ret2 = addrman->Select().first;
126 [ + - + - : 3 : BOOST_CHECK(addr_ret2.ToStringAddrPort() == "250.1.1.1:8333" || addr_ret2.ToStringAddrPort() == "250.1.1.1:8334");
- + - - -
- + - - +
- - - - ]
127 : :
128 : : // Test: Add same IP but diff port to tried table; this converts the entry with
129 : : // the specified port to tried, but not the other.
130 [ + - ]: 2 : addrman->Good(CAddress(addr1_port, NODE_NONE));
131 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 2U);
+ - ]
132 : 1 : bool new_only = true;
133 [ + - ]: 1 : auto addr_ret3 = addrman->Select(new_only).first;
134 [ + - + - : 1 : BOOST_CHECK_EQUAL(addr_ret3.ToStringAddrPort(), "250.1.1.1:8333");
+ - ]
135 [ + - + - ]: 5 : }
136 : :
137 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_select)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
138 : : {
139 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
140 [ + - + - : 2 : BOOST_CHECK(!addrman->Select(false).first.IsValid());
+ - + - +
- ]
141 [ + - + - : 2 : BOOST_CHECK(!addrman->Select(true).first.IsValid());
+ - + - +
- ]
142 : :
143 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
144 : :
145 : : // Add 1 address to the new table
146 [ + - + - ]: 1 : CService addr1 = ResolveService("250.1.1.1", 8333);
147 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
+ - + + +
- - - ]
148 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
149 : :
150 [ + - + - : 2 : BOOST_CHECK(addrman->Select(/*new_only=*/true).first == addr1);
+ - + - +
- ]
151 [ + - + - : 2 : BOOST_CHECK(addrman->Select(/*new_only=*/false).first == addr1);
+ - + - +
- ]
152 : :
153 : : // Move address to the tried table
154 [ + - + - : 2 : BOOST_CHECK(addrman->Good(CAddress(addr1, NODE_NONE)));
+ - + - ]
155 : :
156 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
157 [ + - + - : 2 : BOOST_CHECK(!addrman->Select(/*new_only=*/true).first.IsValid());
+ - + - +
- ]
158 [ + - + - : 2 : BOOST_CHECK(addrman->Select().first == addr1);
+ - + - +
- ]
159 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
160 : :
161 : : // Add one address to the new table
162 [ + - + - ]: 1 : CService addr2 = ResolveService("250.3.1.1", 8333);
163 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, addr2));
+ - + + +
- - - ]
164 [ + - + - : 2 : BOOST_CHECK(addrman->Select(/*new_only=*/true).first == addr2);
+ - + - +
- ]
165 : :
166 : : // Add two more addresses to the new table
167 [ + - + - ]: 1 : CService addr3 = ResolveService("250.3.2.2", 9999);
168 [ + - + - ]: 1 : CService addr4 = ResolveService("250.3.3.3", 9999);
169 : :
170 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr3, NODE_NONE)}, addr2));
+ - + + +
- - - ]
171 [ + - + - : 6 : BOOST_CHECK(addrman->Add({CAddress(addr4, NODE_NONE)}, ResolveService("250.4.1.1", 8333)));
+ - + - +
- + + + -
- - ]
172 : :
173 : : // Add three addresses to tried table.
174 [ + - + - ]: 1 : CService addr5 = ResolveService("250.4.4.4", 8333);
175 [ + - + - ]: 1 : CService addr6 = ResolveService("250.4.5.5", 7777);
176 [ + - + - ]: 1 : CService addr7 = ResolveService("250.4.6.6", 8333);
177 : :
178 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr5, NODE_NONE)}, addr3));
+ - + + +
- - - ]
179 [ + - + - : 2 : BOOST_CHECK(addrman->Good(CAddress(addr5, NODE_NONE)));
+ - + - ]
180 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr6, NODE_NONE)}, addr3));
+ - + + +
- - - ]
181 [ + - + - : 2 : BOOST_CHECK(addrman->Good(CAddress(addr6, NODE_NONE)));
+ - + - ]
182 [ + - + - : 6 : BOOST_CHECK(addrman->Add({CAddress(addr7, NODE_NONE)}, ResolveService("250.1.1.3", 8333)));
+ - + - +
- + + + -
- - ]
183 [ + - + - : 2 : BOOST_CHECK(addrman->Good(CAddress(addr7, NODE_NONE)));
+ - + - ]
184 : :
185 : : // 6 addrs + 1 addr from last test = 7.
186 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 7U);
+ - ]
187 : :
188 : : // Select pulls from new and tried regardless of port number.
189 : 1 : std::set<uint16_t> ports;
190 [ + + ]: 21 : for (int i = 0; i < 20; ++i) {
191 [ + - + - : 40 : ports.insert(addrman->Select().first.GetPort());
+ - ]
192 : : }
193 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(ports.size(), 3U);
194 [ + - + - : 15 : }
+ - + - +
- + - +
- ]
195 : :
196 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_select_by_network)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
197 : : {
198 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
199 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_IPV4}).first.IsValid());
+ - + - +
- + - ]
200 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV4}).first.IsValid());
+ - + - +
- + - ]
201 : :
202 : : // add ipv4 address to the new table
203 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
204 [ + - + - ]: 1 : CService addr1 = ResolveService("250.1.1.1", 8333);
205 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
+ - + + +
- - - ]
206 : :
207 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_IPV4}).first == addr1);
+ - + - +
- + - ]
208 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
+ - + - +
- + - ]
209 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV6}).first.IsValid());
+ - + - +
- + - ]
210 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_ONION}).first.IsValid());
+ - + - +
- + - ]
211 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_I2P}).first.IsValid());
+ - + - +
- + - ]
212 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_CJDNS}).first.IsValid());
+ - + - +
- + - ]
213 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_CJDNS}).first.IsValid());
+ - + - +
- + - ]
214 [ + - + - : 2 : BOOST_CHECK(addrman->Select(/*new_only=*/false).first == addr1);
+ - + - +
- ]
215 : :
216 : : // add I2P address to the new table
217 [ + - ]: 1 : CAddress i2p_addr;
218 [ + - ]: 1 : i2p_addr.SetSpecial("udhdrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.i2p");
219 [ + - + - : 3 : BOOST_CHECK(addrman->Add({i2p_addr}, source));
+ - + - +
+ - - ]
220 : :
221 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_I2P}).first == i2p_addr);
+ - + - +
- + - ]
222 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_I2P}).first == i2p_addr);
+ - + - +
- + - ]
223 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
+ - + - +
- + - ]
224 [ + - + - ]: 2 : std::unordered_set<Network> nets_with_entries = {NET_IPV4, NET_I2P};
225 [ + - + - : 2 : BOOST_CHECK(addrman->Select(/*new_only=*/false, nets_with_entries).first.IsValid());
+ - + - +
- ]
226 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_IPV6}).first.IsValid());
+ - + - +
- + - ]
227 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_ONION}).first.IsValid());
+ - + - +
- + - ]
228 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, {NET_CJDNS}).first.IsValid());
+ - + - +
- + - ]
229 [ + - + - ]: 2 : std::unordered_set<Network> nets_without_entries = {NET_IPV6, NET_ONION, NET_CJDNS};
230 [ + - + - : 2 : BOOST_CHECK(!addrman->Select(/*new_only=*/false, nets_without_entries).first.IsValid());
+ - + - +
- ]
231 : :
232 : : // bump I2P address to tried table
233 [ + - + - : 2 : BOOST_CHECK(addrman->Good(i2p_addr));
+ - + - ]
234 : :
235 [ + - + - : 3 : BOOST_CHECK(!addrman->Select(/*new_only=*/true, {NET_I2P}).first.IsValid());
+ - + - +
- + - ]
236 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_I2P}).first == i2p_addr);
+ - + - +
- + - ]
237 : :
238 : : // add another I2P address to the new table
239 [ + - ]: 1 : CAddress i2p_addr2;
240 [ + - ]: 1 : i2p_addr2.SetSpecial("c4gfnttsuwqomiygupdqqqyy5y5emnk5c73hrfvatri67prd7vyq.b32.i2p");
241 [ + - + - : 3 : BOOST_CHECK(addrman->Add({i2p_addr2}, source));
+ - + - +
+ - - ]
242 : :
243 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/true, {NET_I2P}).first == i2p_addr2);
+ - + - +
- ]
244 : :
245 : : // ensure that both new and tried table are selected from
246 : 1 : bool new_selected{false};
247 : 1 : bool tried_selected{false};
248 : 1 : int counter = 256;
249 : :
250 [ + - + + ]: 3 : while (--counter > 0 && (!new_selected || !tried_selected)) {
251 [ + - + - : 4 : const CAddress selected{addrman->Select(/*new_only=*/false, {NET_I2P}).first};
+ - ]
252 [ + - + - : 5 : BOOST_REQUIRE(selected == i2p_addr || selected == i2p_addr2);
+ + + - +
- + - +
- ]
253 [ + - + + ]: 2 : if (selected == i2p_addr) {
254 : : tried_selected = true;
255 : : } else {
256 : 1 : new_selected = true;
257 : : }
258 : 2 : }
259 : :
260 [ + - + - : 2 : BOOST_CHECK(new_selected);
+ - ]
261 [ + - + - ]: 2 : BOOST_CHECK(tried_selected);
262 [ + - ]: 5 : }
263 : :
264 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_select_special)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
265 : : {
266 : : // use a non-deterministic addrman to ensure a passing test isn't due to setup
267 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, /*deterministic=*/false, GetCheckRatio(m_node));
268 : :
269 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
270 : :
271 : : // add I2P address to the tried table
272 [ + - ]: 1 : CAddress i2p_addr;
273 [ + - ]: 1 : i2p_addr.SetSpecial("udhdrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.i2p");
274 [ + - + - : 3 : BOOST_CHECK(addrman->Add({i2p_addr}, source));
+ - + - +
+ - - ]
275 [ + - + - : 2 : BOOST_CHECK(addrman->Good(i2p_addr));
+ - + - ]
276 : :
277 : : // add ipv4 address to the new table
278 [ + - + - ]: 1 : CService addr1 = ResolveService("250.1.1.3", 8333);
279 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
+ - + + +
- - - ]
280 : :
281 : : // since the only ipv4 address is on the new table, ensure that the new
282 : : // table gets selected even if new_only is false. if the table was being
283 : : // selected at random, this test will sporadically fail
284 [ + - + - : 3 : BOOST_CHECK(addrman->Select(/*new_only=*/false, {NET_IPV4}).first == addr1);
+ - + - +
- ]
285 [ + - ]: 4 : }
286 : :
287 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_new_collisions)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
288 : : {
289 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
290 : :
291 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
292 : :
293 : 1 : uint32_t num_addrs{0};
294 : :
295 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
+ - ]
296 : :
297 [ + + ]: 23 : while (num_addrs < 22) { // Magic number! 250.1.1.1 - 250.1.1.22 do not collide with deterministic key = 1
298 [ + - + - : 44 : CService addr = ResolveService("250.1.1." + ToString(++num_addrs));
+ - ]
299 [ + - + - : 110 : BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
+ - + + +
- - - ]
300 : :
301 : : // Test: No collision in new table yet.
302 [ + - + - : 22 : BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
+ - ]
303 : 22 : }
304 : :
305 : : // Test: new table collision!
306 [ + - + - : 2 : CService addr1 = ResolveService("250.1.1." + ToString(++num_addrs));
+ - ]
307 : 1 : uint32_t collisions{1};
308 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
+ - + + +
- - - ]
309 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), num_addrs - collisions);
+ - ]
310 : :
311 [ + - + - : 2 : CService addr2 = ResolveService("250.1.1." + ToString(++num_addrs));
+ - ]
312 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
+ - + + +
- - - ]
313 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), num_addrs - collisions);
+ - ]
314 [ + - + - : 49 : }
+ - ]
315 : :
316 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_new_multiplicity)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
317 : : {
318 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
319 [ + - + - ]: 2 : CAddress addr{CAddress(ResolveService("253.3.3.3", 8333), NODE_NONE)};
320 : 1 : const auto start_time{Now<NodeSeconds>()};
321 : 1 : addr.nTime = start_time;
322 : :
323 : : // test that multiplicity stays at 1 if nTime doesn't increase
324 [ + + ]: 20 : for (unsigned int i = 1; i < 20; ++i) {
325 [ + - + - : 57 : std::string addr_ip{ToString(i % 256) + "." + ToString(i >> 8 % 256) + ".1.1"};
+ - ]
326 [ + - ]: 19 : CNetAddr source{ResolveIP(addr_ip)};
327 [ + - + - : 38 : addrman->Add({addr}, source);
+ + - - ]
328 : 19 : }
329 [ + - ]: 1 : AddressPosition addr_pos = addrman->FindAddressEntry(addr).value();
330 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(addr_pos.multiplicity, 1U);
331 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
332 : :
333 : : // if nTime increases, an addr can occur in up to 8 buckets
334 : : // The acceptance probability decreases exponentially with existing multiplicity -
335 : : // choose number of iterations such that it gets to 8 with deterministic addrman.
336 [ + + ]: 400 : for (unsigned int i = 1; i < 400; ++i) {
337 [ + - + - : 1197 : std::string addr_ip{ToString(i % 256) + "." + ToString(i >> 8 % 256) + ".1.1"};
+ - ]
338 [ + - ]: 399 : CNetAddr source{ResolveIP(addr_ip)};
339 : 399 : addr.nTime = start_time + std::chrono::seconds{i};
340 [ + - + - : 798 : addrman->Add({addr}, source);
+ + - - ]
341 : 399 : }
342 [ + - ]: 1 : AddressPosition addr_pos_multi = addrman->FindAddressEntry(addr).value();
343 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(addr_pos_multi.multiplicity, 8U);
344 : : // multiplicity doesn't affect size
345 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
346 : 419 : }
347 : :
348 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_tried_collisions)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
349 : : {
350 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
351 : :
352 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
353 : :
354 : 1 : uint32_t num_addrs{0};
355 : :
356 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), num_addrs);
+ - ]
357 : :
358 [ + + ]: 36 : while (num_addrs < 35) { // Magic number! 250.1.1.1 - 250.1.1.35 do not collide in tried with deterministic key = 1
359 [ + - + - : 70 : CService addr = ResolveService("250.1.1." + ToString(++num_addrs));
+ - ]
360 [ + - + - : 175 : BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
+ - + + +
- - - ]
361 : :
362 : : // Test: Add to tried without collision
363 [ + - + - : 70 : BOOST_CHECK(addrman->Good(CAddress(addr, NODE_NONE)));
+ - ]
364 : :
365 : 35 : }
366 : :
367 : : // Test: Unable to add to tried table due to collision!
368 [ + - + - : 2 : CService addr1 = ResolveService("250.1.1." + ToString(++num_addrs));
+ - ]
369 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr1, NODE_NONE)}, source));
+ - + + +
- - - ]
370 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(CAddress(addr1, NODE_NONE)));
+ - + - ]
371 : :
372 : : // Test: Add the next address to tried without collision
373 [ + - + - : 2 : CService addr2 = ResolveService("250.1.1." + ToString(++num_addrs));
+ - ]
374 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr2, NODE_NONE)}, source));
+ - + + +
- - - ]
375 [ + - + - : 2 : BOOST_CHECK(addrman->Good(CAddress(addr2, NODE_NONE)));
+ - ]
376 [ + - + - : 75 : }
+ - ]
377 : :
378 : :
379 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_getaddr)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
380 : : {
381 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
382 : :
383 : : // Test: Sanity check, GetAddr should never return anything if addrman
384 : : // is empty.
385 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 0U);
+ - ]
386 [ + - ]: 1 : std::vector<CAddress> vAddr1 = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
387 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr1.size(), 0U);
+ - ]
388 : :
389 [ + - + - ]: 2 : CAddress addr1 = CAddress(ResolveService("250.250.2.1", 8333), NODE_NONE);
390 : 1 : addr1.nTime = Now<NodeSeconds>(); // Set time so isTerrible = false
391 [ + - + - ]: 2 : CAddress addr2 = CAddress(ResolveService("250.251.2.2", 9999), NODE_NONE);
392 : 1 : addr2.nTime = Now<NodeSeconds>();
393 [ + - + - ]: 2 : CAddress addr3 = CAddress(ResolveService("251.252.2.3", 8333), NODE_NONE);
394 : 1 : addr3.nTime = Now<NodeSeconds>();
395 [ + - + - ]: 2 : CAddress addr4 = CAddress(ResolveService("252.253.3.4", 8333), NODE_NONE);
396 : 1 : addr4.nTime = Now<NodeSeconds>();
397 [ + - + - ]: 2 : CAddress addr5 = CAddress(ResolveService("252.254.4.5", 8333), NODE_NONE);
398 : 1 : addr5.nTime = Now<NodeSeconds>();
399 [ + - + - ]: 1 : CNetAddr source1 = ResolveIP("250.1.2.1");
400 [ + - + - ]: 1 : CNetAddr source2 = ResolveIP("250.2.3.3");
401 : :
402 : : // Test: Ensure GetAddr works with new addresses.
403 [ + - + - : 6 : BOOST_CHECK(addrman->Add({addr1, addr3, addr5}, source1));
+ - + - +
+ - - ]
404 [ + - + - : 5 : BOOST_CHECK(addrman->Add({addr2, addr4}, source2));
+ - + - +
+ - - ]
405 : :
406 [ + - + - : 2 : BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 5U);
+ - ]
407 : : // Net processing asks for 23% of addresses. 23% of 5 is 1 rounded down.
408 [ + - + - : 2 : BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt).size(), 1U);
+ - ]
409 : :
410 : : // Test: Ensure GetAddr works with new and tried addresses.
411 [ + - + - : 2 : BOOST_CHECK(addrman->Good(CAddress(addr1, NODE_NONE)));
+ - + - ]
412 [ + - + - : 2 : BOOST_CHECK(addrman->Good(CAddress(addr2, NODE_NONE)));
+ - + - ]
413 [ + - + - : 2 : BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 5U);
+ - ]
414 [ + - + - : 2 : BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt).size(), 1U);
+ - ]
415 : :
416 : : // Test: Ensure GetAddr still returns 23% when addrman has many addrs.
417 [ + + ]: 2048 : for (unsigned int i = 1; i < (8 * 256); i++) {
418 : 2047 : int octet1 = i % 256;
419 : 2047 : int octet2 = i >> 8 % 256;
420 [ + - + - : 6141 : std::string strAddr = ToString(octet1) + "." + ToString(octet2) + ".1.23";
+ - ]
421 [ + - ]: 4094 : CAddress addr = CAddress(ResolveService(strAddr), NODE_NONE);
422 : :
423 : : // Ensure that for all addrs in addrman, isTerrible == false.
424 : 2047 : addr.nTime = Now<NodeSeconds>();
425 [ + - + - : 6141 : addrman->Add({addr}, ResolveIP(strAddr));
+ - + + -
- ]
426 [ + + ]: 2047 : if (i % 8 == 0)
427 [ + - ]: 255 : addrman->Good(addr);
428 : 2047 : }
429 [ + - ]: 1 : std::vector<CAddress> vAddr = addrman->GetAddr(/*max_addresses=*/2500, /*max_pct=*/23, /*network=*/std::nullopt);
430 : :
431 [ + - ]: 1 : size_t percent23 = (addrman->Size() * 23) / 100;
432 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr.size(), percent23);
+ - ]
433 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr.size(), 461U);
+ - ]
434 : : // (addrman.Size() < number of addresses added) due to address collisions.
435 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 2006U);
+ - ]
436 : 2050 : }
437 : :
438 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(getaddr_unfiltered)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
439 : : {
440 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
441 : :
442 : : // Set time on this addr so isTerrible = false
443 [ + - + - ]: 2 : CAddress addr1 = CAddress(ResolveService("250.250.2.1", 8333), NODE_NONE);
444 : 1 : addr1.nTime = Now<NodeSeconds>();
445 : : // Not setting time so this addr should be isTerrible = true
446 [ + - + - ]: 2 : CAddress addr2 = CAddress(ResolveService("250.251.2.2", 9999), NODE_NONE);
447 : :
448 [ + - + - ]: 1 : CNetAddr source = ResolveIP("250.1.2.1");
449 [ + - + - : 5 : BOOST_CHECK(addrman->Add({addr1, addr2}, source));
+ - + - +
+ - - ]
450 : :
451 : : // Set time on this addr so isTerrible = false
452 [ + - + - ]: 2 : CAddress addr3 = CAddress(ResolveService("250.251.2.3", 9998), NODE_NONE);
453 : 1 : addr3.nTime = Now<NodeSeconds>();
454 [ + - ]: 1 : addrman->Good(addr3, /*time=*/Now<NodeSeconds>());
455 [ + - + - : 3 : BOOST_CHECK(addrman->Add({addr3}, source));
+ - + - +
+ - - ]
456 : : // The time is set, but after ADDRMAN_RETRIES unsuccessful attempts not
457 : : // retried in the last minute, this addr should be isTerrible = true
458 [ + + ]: 4 : for (size_t i = 0; i < 3; ++i) {
459 [ + - ]: 3 : addrman->Attempt(addr3, /*fCountFailure=*/true, /*time=*/Now<NodeSeconds>() - 61s);
460 : : }
461 : :
462 : : // Set time more than 10 minutes in the future (flying DeLorean), so this
463 : : // addr should be isTerrible = true
464 [ + - + - ]: 2 : CAddress addr4 = CAddress(ResolveService("250.252.2.4", 9997), NODE_NONE);
465 : 1 : addr4.nTime = Now<NodeSeconds>() + 11min;
466 [ + - + - : 3 : BOOST_CHECK(addrman->Add({addr4}, source));
+ - + - +
+ - - ]
467 : :
468 : : // GetAddr filtered by quality (i.e. not IsTerrible) should only return addr1
469 [ + - + - : 2 : BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt).size(), 1U);
+ - ]
470 : : // Unfiltered GetAddr should return all addrs
471 [ + - + - : 2 : BOOST_CHECK_EQUAL(addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt, /*filtered=*/false).size(), 4U);
+ - ]
472 : 4 : }
473 : :
474 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket_legacy)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
475 : : {
476 [ + - ]: 2 : CAddress addr1 = CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE);
477 [ + - + - ]: 2 : CAddress addr2 = CAddress(ResolveService("250.1.1.1", 9999), NODE_NONE);
478 : :
479 [ + - + - ]: 1 : CNetAddr source1 = ResolveIP("250.1.1.1");
480 : :
481 : :
482 : 1 : AddrInfo info1 = AddrInfo(addr1, source1);
483 : :
484 [ + - + - : 1 : uint256 nKey1 = (HashWriter{} << 1).GetHash();
+ - ]
485 [ + - + - : 1 : uint256 nKey2 = (HashWriter{} << 2).GetHash();
+ - ]
486 : :
487 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN), 40);
+ - ]
488 : :
489 : : // Test: Make sure key actually randomizes bucket placement. A fail on
490 : : // this test could be a security issue.
491 [ + - + - : 2 : BOOST_CHECK(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN) != info1.GetTriedBucket(nKey2, EMPTY_NETGROUPMAN));
+ - + - ]
492 : :
493 : : // Test: Two addresses with same IP but different ports can map to
494 : : // different buckets because they have different keys.
495 : 1 : AddrInfo info2 = AddrInfo(addr2, source1);
496 : :
497 [ + - + - : 2 : BOOST_CHECK(info1.GetKey() != info2.GetKey());
+ - + - +
- ]
498 [ + - + - : 2 : BOOST_CHECK(info1.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN) != info2.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN));
+ - + - ]
499 : :
500 : 1 : std::set<int> buckets;
501 [ + + ]: 256 : for (int i = 0; i < 255; i++) {
502 : 255 : AddrInfo infoi = AddrInfo(
503 [ + - + - : 510 : CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
+ - ]
504 [ + - + - : 765 : ResolveIP("250.1.1." + ToString(i)));
+ - ]
505 [ + - ]: 255 : int bucket = infoi.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN);
506 [ + - ]: 255 : buckets.insert(bucket);
507 : 255 : }
508 : : // Test: IP addresses in the same /16 prefix should
509 : : // never get more than 8 buckets with legacy grouping
510 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(buckets.size(), 8U);
511 : :
512 : 1 : buckets.clear();
513 [ + + ]: 256 : for (int j = 0; j < 255; j++) {
514 : 255 : AddrInfo infoj = AddrInfo(
515 [ + - + - : 765 : CAddress(ResolveService("250." + ToString(j) + ".1.1"), NODE_NONE),
+ - ]
516 [ + - + - : 1020 : ResolveIP("250." + ToString(j) + ".1.1"));
+ - ]
517 [ + - ]: 255 : int bucket = infoj.GetTriedBucket(nKey1, EMPTY_NETGROUPMAN);
518 [ + - ]: 255 : buckets.insert(bucket);
519 : 255 : }
520 : : // Test: IP addresses in the different /16 prefix should map to more than
521 : : // 8 buckets with legacy grouping
522 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(buckets.size(), 160U);
523 : 3 : }
524 : :
525 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket_legacy)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
526 : : {
527 [ + - ]: 2 : CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
528 [ + - + - ]: 2 : CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
529 : :
530 [ + - + - ]: 1 : CNetAddr source1 = ResolveIP("250.1.2.1");
531 : :
532 : 1 : AddrInfo info1 = AddrInfo(addr1, source1);
533 : :
534 [ + - + - : 1 : uint256 nKey1 = (HashWriter{} << 1).GetHash();
+ - ]
535 [ + - + - : 1 : uint256 nKey2 = (HashWriter{} << 2).GetHash();
+ - ]
536 : :
537 : : // Test: Make sure the buckets are what we expect
538 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN), 786);
+ - ]
539 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, source1, EMPTY_NETGROUPMAN), 786);
+ - ]
540 : :
541 : : // Test: Make sure key actually randomizes bucket placement. A fail on
542 : : // this test could be a security issue.
543 [ + - + - : 2 : BOOST_CHECK(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN) != info1.GetNewBucket(nKey2, EMPTY_NETGROUPMAN));
+ - + - ]
544 : :
545 : : // Test: Ports should not affect bucket placement in the addr
546 : 1 : AddrInfo info2 = AddrInfo(addr2, source1);
547 [ + - + - : 2 : BOOST_CHECK(info1.GetKey() != info2.GetKey());
+ - + - +
- ]
548 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, EMPTY_NETGROUPMAN), info2.GetNewBucket(nKey1, EMPTY_NETGROUPMAN));
+ - + - ]
549 : :
550 : 1 : std::set<int> buckets;
551 [ + + ]: 256 : for (int i = 0; i < 255; i++) {
552 : 255 : AddrInfo infoi = AddrInfo(
553 [ + - + - : 510 : CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
+ - ]
554 [ + - + - : 765 : ResolveIP("250.1.1." + ToString(i)));
+ - ]
555 [ + - ]: 255 : int bucket = infoi.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
556 [ + - ]: 255 : buckets.insert(bucket);
557 : 255 : }
558 : : // Test: IP addresses in the same group (\16 prefix for IPv4) should
559 : : // always map to the same bucket.
560 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(buckets.size(), 1U);
561 : :
562 : 1 : buckets.clear();
563 [ + + ]: 1021 : for (int j = 0; j < 4 * 255; j++) {
564 : 1020 : AddrInfo infoj = AddrInfo(CAddress(
565 : 1020 : ResolveService(
566 [ + - + - : 4080 : ToString(250 + (j / 255)) + "." + ToString(j % 256) + ".1.1"), NODE_NONE),
+ - + - ]
567 [ + - + - ]: 3060 : ResolveIP("251.4.1.1"));
568 [ + - ]: 1020 : int bucket = infoj.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
569 [ + - ]: 1020 : buckets.insert(bucket);
570 : 1020 : }
571 : : // Test: IP addresses in the same source groups should map to NO MORE
572 : : // than 64 buckets.
573 [ + - + - ]: 2 : BOOST_CHECK(buckets.size() <= 64);
574 : :
575 : 1 : buckets.clear();
576 [ + + ]: 256 : for (int p = 0; p < 255; p++) {
577 : 255 : AddrInfo infoj = AddrInfo(
578 [ + - + - ]: 510 : CAddress(ResolveService("250.1.1.1"), NODE_NONE),
579 [ + - + - : 1020 : ResolveIP("250." + ToString(p) + ".1.1"));
+ - ]
580 [ + - ]: 255 : int bucket = infoj.GetNewBucket(nKey1, EMPTY_NETGROUPMAN);
581 [ + - ]: 255 : buckets.insert(bucket);
582 : 255 : }
583 : : // Test: IP addresses in the different source groups should map to MORE
584 : : // than 64 buckets.
585 [ + - + - ]: 2 : BOOST_CHECK(buckets.size() > 64);
586 : 3 : }
587 : :
588 : : // The following three test cases use asmap.raw
589 : : // We use an artificial minimal mock mapping
590 : : // 250.0.0.0/8 AS1000
591 : : // 101.1.0.0/16 AS1
592 : : // 101.2.0.0/16 AS2
593 : : // 101.3.0.0/16 AS3
594 : : // 101.4.0.0/16 AS4
595 : : // 101.5.0.0/16 AS5
596 : : // 101.6.0.0/16 AS6
597 : : // 101.7.0.0/16 AS7
598 : : // 101.8.0.0/16 AS8
599 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
600 : : {
601 : 1 : std::vector<bool> asmap = FromBytes(test::data::asmap);
602 [ + - ]: 1 : NetGroupManager ngm_asmap{asmap};
603 : :
604 [ + - + - ]: 2 : CAddress addr1 = CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE);
605 [ + - + - ]: 2 : CAddress addr2 = CAddress(ResolveService("250.1.1.1", 9999), NODE_NONE);
606 : :
607 [ + - + - ]: 1 : CNetAddr source1 = ResolveIP("250.1.1.1");
608 : :
609 : :
610 : 1 : AddrInfo info1 = AddrInfo(addr1, source1);
611 : :
612 [ + - + - : 1 : uint256 nKey1 = (HashWriter{} << 1).GetHash();
+ - ]
613 [ + - + - : 1 : uint256 nKey2 = (HashWriter{} << 2).GetHash();
+ - ]
614 : :
615 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetTriedBucket(nKey1, ngm_asmap), 236);
+ - ]
616 : :
617 : : // Test: Make sure key actually randomizes bucket placement. A fail on
618 : : // this test could be a security issue.
619 [ + - + - : 2 : BOOST_CHECK(info1.GetTriedBucket(nKey1, ngm_asmap) != info1.GetTriedBucket(nKey2, ngm_asmap));
+ - + - ]
620 : :
621 : : // Test: Two addresses with same IP but different ports can map to
622 : : // different buckets because they have different keys.
623 : 1 : AddrInfo info2 = AddrInfo(addr2, source1);
624 : :
625 [ + - + - : 2 : BOOST_CHECK(info1.GetKey() != info2.GetKey());
+ - + - +
- ]
626 [ + - + - : 2 : BOOST_CHECK(info1.GetTriedBucket(nKey1, ngm_asmap) != info2.GetTriedBucket(nKey1, ngm_asmap));
+ - + - ]
627 : :
628 : 1 : std::set<int> buckets;
629 [ + + ]: 256 : for (int j = 0; j < 255; j++) {
630 : 255 : AddrInfo infoj = AddrInfo(
631 [ + - + - : 765 : CAddress(ResolveService("101." + ToString(j) + ".1.1"), NODE_NONE),
+ - ]
632 [ + - + - : 1020 : ResolveIP("101." + ToString(j) + ".1.1"));
+ - ]
633 [ + - ]: 255 : int bucket = infoj.GetTriedBucket(nKey1, ngm_asmap);
634 [ + - ]: 255 : buckets.insert(bucket);
635 : 255 : }
636 : : // Test: IP addresses in the different /16 prefix MAY map to more than
637 : : // 8 buckets.
638 [ + - + - ]: 2 : BOOST_CHECK(buckets.size() > 8);
639 : :
640 : 1 : buckets.clear();
641 [ + + ]: 256 : for (int j = 0; j < 255; j++) {
642 : 255 : AddrInfo infoj = AddrInfo(
643 [ + - + - : 765 : CAddress(ResolveService("250." + ToString(j) + ".1.1"), NODE_NONE),
+ - ]
644 [ + - + - : 1020 : ResolveIP("250." + ToString(j) + ".1.1"));
+ - ]
645 [ + - ]: 255 : int bucket = infoj.GetTriedBucket(nKey1, ngm_asmap);
646 [ + - ]: 255 : buckets.insert(bucket);
647 : 255 : }
648 : : // Test: IP addresses in the different /16 prefix MAY NOT map to more than
649 : : // 8 buckets.
650 [ + - + - ]: 2 : BOOST_CHECK(buckets.size() == 8);
651 : 3 : }
652 : :
653 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
654 : : {
655 : 1 : std::vector<bool> asmap = FromBytes(test::data::asmap);
656 [ + - ]: 1 : NetGroupManager ngm_asmap{asmap};
657 : :
658 [ + - + - ]: 2 : CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
659 [ + - + - ]: 2 : CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
660 : :
661 [ + - + - ]: 1 : CNetAddr source1 = ResolveIP("250.1.2.1");
662 : :
663 : 1 : AddrInfo info1 = AddrInfo(addr1, source1);
664 : :
665 [ + - + - : 1 : uint256 nKey1 = (HashWriter{} << 1).GetHash();
+ - ]
666 [ + - + - : 1 : uint256 nKey2 = (HashWriter{} << 2).GetHash();
+ - ]
667 : :
668 : : // Test: Make sure the buckets are what we expect
669 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, ngm_asmap), 795);
+ - ]
670 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, source1, ngm_asmap), 795);
+ - ]
671 : :
672 : : // Test: Make sure key actually randomizes bucket placement. A fail on
673 : : // this test could be a security issue.
674 [ + - + - : 2 : BOOST_CHECK(info1.GetNewBucket(nKey1, ngm_asmap) != info1.GetNewBucket(nKey2, ngm_asmap));
+ - + - ]
675 : :
676 : : // Test: Ports should not affect bucket placement in the addr
677 : 1 : AddrInfo info2 = AddrInfo(addr2, source1);
678 [ + - + - : 2 : BOOST_CHECK(info1.GetKey() != info2.GetKey());
+ - + - +
- ]
679 [ + - + - : 1 : BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, ngm_asmap), info2.GetNewBucket(nKey1, ngm_asmap));
+ - + - ]
680 : :
681 : 1 : std::set<int> buckets;
682 [ + + ]: 256 : for (int i = 0; i < 255; i++) {
683 : 255 : AddrInfo infoi = AddrInfo(
684 [ + - + - : 510 : CAddress(ResolveService("250.1.1." + ToString(i)), NODE_NONE),
+ - ]
685 [ + - + - : 765 : ResolveIP("250.1.1." + ToString(i)));
+ - ]
686 [ + - ]: 255 : int bucket = infoi.GetNewBucket(nKey1, ngm_asmap);
687 [ + - ]: 255 : buckets.insert(bucket);
688 : 255 : }
689 : : // Test: IP addresses in the same /16 prefix
690 : : // usually map to the same bucket.
691 [ + - + - ]: 1 : BOOST_CHECK_EQUAL(buckets.size(), 1U);
692 : :
693 : 1 : buckets.clear();
694 [ + + ]: 1021 : for (int j = 0; j < 4 * 255; j++) {
695 : 1020 : AddrInfo infoj = AddrInfo(CAddress(
696 : 1020 : ResolveService(
697 [ + - + - : 4080 : ToString(250 + (j / 255)) + "." + ToString(j % 256) + ".1.1"), NODE_NONE),
+ - + - ]
698 [ + - + - ]: 3060 : ResolveIP("251.4.1.1"));
699 [ + - ]: 1020 : int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
700 [ + - ]: 1020 : buckets.insert(bucket);
701 : 1020 : }
702 : : // Test: IP addresses in the same source /16 prefix should not map to more
703 : : // than 64 buckets.
704 [ + - + - ]: 2 : BOOST_CHECK(buckets.size() <= 64);
705 : :
706 : 1 : buckets.clear();
707 [ + + ]: 256 : for (int p = 0; p < 255; p++) {
708 : 255 : AddrInfo infoj = AddrInfo(
709 [ + - + - ]: 510 : CAddress(ResolveService("250.1.1.1"), NODE_NONE),
710 [ + - + - : 1020 : ResolveIP("101." + ToString(p) + ".1.1"));
+ - ]
711 [ + - ]: 255 : int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
712 [ + - ]: 255 : buckets.insert(bucket);
713 : 255 : }
714 : : // Test: IP addresses in the different source /16 prefixes usually map to MORE
715 : : // than 1 bucket.
716 [ + - + - ]: 2 : BOOST_CHECK(buckets.size() > 1);
717 : :
718 : 1 : buckets.clear();
719 [ + + ]: 256 : for (int p = 0; p < 255; p++) {
720 : 255 : AddrInfo infoj = AddrInfo(
721 [ + - + - ]: 510 : CAddress(ResolveService("250.1.1.1"), NODE_NONE),
722 [ + - + - : 1020 : ResolveIP("250." + ToString(p) + ".1.1"));
+ - ]
723 [ + - ]: 255 : int bucket = infoj.GetNewBucket(nKey1, ngm_asmap);
724 [ + - ]: 255 : buckets.insert(bucket);
725 : 255 : }
726 : : // Test: IP addresses in the different source /16 prefixes sometimes map to NO MORE
727 : : // than 1 bucket.
728 [ + - + - ]: 2 : BOOST_CHECK(buckets.size() == 1);
729 : 3 : }
730 : :
731 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_serialization)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
732 : : {
733 : 1 : std::vector<bool> asmap1 = FromBytes(test::data::asmap);
734 [ + - ]: 1 : NetGroupManager netgroupman{asmap1};
735 : :
736 [ + - ]: 1 : const auto ratio = GetCheckRatio(m_node);
737 [ + - ]: 1 : auto addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
738 [ + - ]: 1 : auto addrman_asmap1_dup = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
739 [ + - ]: 1 : auto addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
740 : :
741 : 1 : DataStream stream{};
742 : :
743 [ + - + - ]: 2 : CAddress addr = CAddress(ResolveService("250.1.1.1"), NODE_NONE);
744 [ + - ]: 1 : CNetAddr default_source;
745 : :
746 [ + - + - : 2 : addrman_asmap1->Add({addr}, default_source);
+ + - - ]
747 : :
748 [ + - ]: 1 : stream << *addrman_asmap1;
749 : : // serizalizing/deserializing addrman with the same asmap
750 [ + - ]: 1 : stream >> *addrman_asmap1_dup;
751 : :
752 [ + - ]: 1 : AddressPosition addr_pos1 = addrman_asmap1->FindAddressEntry(addr).value();
753 [ + - ]: 1 : AddressPosition addr_pos2 = addrman_asmap1_dup->FindAddressEntry(addr).value();
754 [ + - + - : 2 : BOOST_CHECK(addr_pos1.multiplicity != 0);
+ - ]
755 [ + - + - : 2 : BOOST_CHECK(addr_pos2.multiplicity != 0);
+ - ]
756 : :
757 [ + - + - : 2 : BOOST_CHECK(addr_pos1 == addr_pos2);
+ - ]
758 : :
759 : : // deserializing asmaped peers.dat to non-asmaped addrman
760 [ + - ]: 1 : stream << *addrman_asmap1;
761 [ + - ]: 1 : stream >> *addrman_noasmap;
762 [ + - ]: 1 : AddressPosition addr_pos3 = addrman_noasmap->FindAddressEntry(addr).value();
763 [ + - + - : 2 : BOOST_CHECK(addr_pos3.multiplicity != 0);
+ - ]
764 [ + - + - : 2 : BOOST_CHECK(addr_pos1.bucket != addr_pos3.bucket);
+ - ]
765 [ + - + - : 2 : BOOST_CHECK(addr_pos1.position != addr_pos3.position);
+ - ]
766 : :
767 : : // deserializing non-asmaped peers.dat to asmaped addrman
768 [ + - ]: 2 : addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
769 [ + - ]: 2 : addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
770 [ + - + - : 2 : addrman_noasmap->Add({addr}, default_source);
+ + - - ]
771 [ + - ]: 1 : stream << *addrman_noasmap;
772 [ + - ]: 1 : stream >> *addrman_asmap1;
773 : :
774 [ + - ]: 1 : AddressPosition addr_pos4 = addrman_asmap1->FindAddressEntry(addr).value();
775 [ + - + - : 2 : BOOST_CHECK(addr_pos4.multiplicity != 0);
+ - ]
776 [ + - + - : 2 : BOOST_CHECK(addr_pos4.bucket != addr_pos3.bucket);
+ - ]
777 [ + - + - : 2 : BOOST_CHECK(addr_pos4 == addr_pos2);
+ - ]
778 : :
779 : : // used to map to different buckets, now maps to the same bucket.
780 [ + - ]: 2 : addrman_asmap1 = std::make_unique<AddrMan>(netgroupman, DETERMINISTIC, ratio);
781 [ + - ]: 2 : addrman_noasmap = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, ratio);
782 [ + - + - ]: 2 : CAddress addr1 = CAddress(ResolveService("250.1.1.1"), NODE_NONE);
783 [ + - + - ]: 2 : CAddress addr2 = CAddress(ResolveService("250.2.1.1"), NODE_NONE);
784 [ + - + - : 4 : addrman_noasmap->Add({addr, addr2}, default_source);
+ + - - ]
785 [ + - ]: 1 : AddressPosition addr_pos5 = addrman_noasmap->FindAddressEntry(addr1).value();
786 [ + - ]: 1 : AddressPosition addr_pos6 = addrman_noasmap->FindAddressEntry(addr2).value();
787 [ + - + - : 2 : BOOST_CHECK(addr_pos5.bucket != addr_pos6.bucket);
+ - ]
788 [ + - ]: 1 : stream << *addrman_noasmap;
789 [ + - ]: 1 : stream >> *addrman_asmap1;
790 [ + - ]: 1 : AddressPosition addr_pos7 = addrman_asmap1->FindAddressEntry(addr1).value();
791 [ + - ]: 1 : AddressPosition addr_pos8 = addrman_asmap1->FindAddressEntry(addr2).value();
792 [ + - + - : 2 : BOOST_CHECK(addr_pos7.bucket == addr_pos8.bucket);
+ - ]
793 [ + - + - ]: 2 : BOOST_CHECK(addr_pos7.position != addr_pos8.position);
794 : 4 : }
795 : :
796 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(remove_invalid)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
797 : : {
798 : : // Confirm that invalid addresses are ignored in unserialization.
799 : :
800 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
801 : 1 : DataStream stream{};
802 : :
803 [ + - + - ]: 2 : const CAddress new1{ResolveService("5.5.5.5"), NODE_NONE};
804 [ + - + - ]: 2 : const CAddress new2{ResolveService("6.6.6.6"), NODE_NONE};
805 [ + - + - ]: 2 : const CAddress tried1{ResolveService("7.7.7.7"), NODE_NONE};
806 [ + - + - ]: 2 : const CAddress tried2{ResolveService("8.8.8.8"), NODE_NONE};
807 : :
808 [ + - + - : 6 : addrman->Add({new1, tried1, new2, tried2}, CNetAddr{});
+ - + + -
- ]
809 [ + - ]: 1 : addrman->Good(tried1);
810 [ + - ]: 1 : addrman->Good(tried2);
811 [ + - + - : 1 : BOOST_REQUIRE_EQUAL(addrman->Size(), 4);
+ - ]
812 : :
813 [ + - ]: 1 : stream << *addrman;
814 : :
815 [ + - ]: 1 : const std::string str{stream.str()};
816 : 1 : size_t pos;
817 : :
818 : 1 : const char new2_raw[]{6, 6, 6, 6};
819 : 1 : const uint8_t new2_raw_replacement[]{0, 0, 0, 0}; // 0.0.0.0 is !IsValid()
820 : 1 : pos = str.find(new2_raw, 0, sizeof(new2_raw));
821 [ + - + - : 2 : BOOST_REQUIRE(pos != std::string::npos);
+ - ]
822 [ + - - + : 2 : BOOST_REQUIRE(pos + sizeof(new2_raw_replacement) <= stream.size());
+ - ]
823 : 1 : memcpy(stream.data() + pos, new2_raw_replacement, sizeof(new2_raw_replacement));
824 : :
825 : 1 : const char tried2_raw[]{8, 8, 8, 8};
826 : 1 : const uint8_t tried2_raw_replacement[]{255, 255, 255, 255}; // 255.255.255.255 is !IsValid()
827 : 1 : pos = str.find(tried2_raw, 0, sizeof(tried2_raw));
828 [ + - + - : 2 : BOOST_REQUIRE(pos != std::string::npos);
+ - ]
829 [ + - - + : 2 : BOOST_REQUIRE(pos + sizeof(tried2_raw_replacement) <= stream.size());
+ - + - ]
830 [ + - ]: 1 : memcpy(stream.data() + pos, tried2_raw_replacement, sizeof(tried2_raw_replacement));
831 : :
832 [ + - + - ]: 2 : addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
833 [ + - ]: 1 : stream >> *addrman;
834 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 2);
+ - ]
835 : 2 : }
836 : :
837 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_selecttriedcollision)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
838 : : {
839 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
840 : :
841 [ + - + - : 2 : BOOST_CHECK(addrman->Size() == 0);
+ - + - ]
842 : :
843 : : // Empty addrman should return blank addrman info.
844 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - +
- ]
845 : :
846 : : // Add twenty two addresses.
847 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
848 [ + + ]: 23 : for (unsigned int i = 1; i < 23; i++) {
849 [ + - + - : 44 : CService addr = ResolveService("250.1.1." + ToString(i));
+ - ]
850 [ + - + - : 110 : BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
+ - + + +
- - - ]
851 : :
852 : : // No collisions in tried.
853 [ + - + - : 44 : BOOST_CHECK(addrman->Good(addr));
+ - + - ]
854 [ + - + - : 44 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - ]
855 : 22 : }
856 : :
857 : : // Ensure Good handles duplicates well.
858 : : // If an address is a duplicate, Good will return false but will not count it as a collision.
859 [ + + ]: 23 : for (unsigned int i = 1; i < 23; i++) {
860 [ + - + - : 44 : CService addr = ResolveService("250.1.1." + ToString(i));
+ - ]
861 : :
862 : : // Unable to add duplicate address to tried table.
863 [ + - + - : 44 : BOOST_CHECK(!addrman->Good(addr));
+ - + - ]
864 : :
865 : : // Verify duplicate address not marked as a collision.
866 [ + - + - : 44 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - ]
867 : 22 : }
868 [ + - ]: 45 : }
869 : :
870 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_noevict)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
871 : : {
872 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
873 : :
874 : : // Add 35 addresses.
875 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
876 [ + + ]: 36 : for (unsigned int i = 1; i < 36; i++) {
877 [ + - + - : 70 : CService addr = ResolveService("250.1.1." + ToString(i));
+ - ]
878 [ + - + - : 175 : BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
+ - + + +
- - - ]
879 : :
880 : : // No collision yet.
881 [ + - + - : 70 : BOOST_CHECK(addrman->Good(addr));
+ - ]
882 : 35 : }
883 : :
884 : : // Collision in tried table between 36 and 19.
885 [ + - + - ]: 1 : CService addr36 = ResolveService("250.1.1.36");
886 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr36, NODE_NONE)}, source));
+ - + + +
- - - ]
887 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(addr36));
+ - + - ]
888 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.19:0");
+ - + - ]
889 : :
890 : : // 36 should be discarded and 19 not evicted.
891 : : // This means we keep 19 in the tried table and
892 : : // 36 stays in the new table.
893 [ + - ]: 1 : addrman->ResolveCollisions();
894 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - ]
895 : :
896 : : // Lets create two collisions.
897 [ + + ]: 23 : for (unsigned int i = 37; i < 59; i++) {
898 [ + - + - : 44 : CService addr = ResolveService("250.1.1." + ToString(i));
+ - ]
899 [ + - + - : 110 : BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
+ - + + +
- - - ]
900 [ + - + - : 44 : BOOST_CHECK(addrman->Good(addr));
+ - ]
901 : 22 : }
902 : :
903 : : // Cause a collision in the tried table.
904 [ + - + - ]: 1 : CService addr59 = ResolveService("250.1.1.59");
905 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr59, NODE_NONE)}, source));
+ - + + +
- - - ]
906 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(addr59));
+ - + - ]
907 : :
908 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.10:0");
+ - + - ]
909 : :
910 : : // Cause a second collision in the new table.
911 [ + - + - : 5 : BOOST_CHECK(!addrman->Add({CAddress(addr36, NODE_NONE)}, source));
+ - + + +
- - - ]
912 : :
913 : : // 36 still cannot be moved from new to tried due to colliding with 19
914 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(addr36));
+ - + - ]
915 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() != "[::]:0");
+ - + - +
- ]
916 : :
917 : : // Resolve all collisions.
918 [ + - ]: 1 : addrman->ResolveCollisions();
919 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - ]
920 [ + - + - : 121 : }
+ - + - +
- ]
921 : :
922 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_evictionworks)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
923 : : {
924 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
925 : :
926 [ + - + - : 2 : BOOST_CHECK(addrman->Size() == 0);
+ - + - ]
927 : :
928 : : // Empty addrman should return blank addrman info.
929 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - +
- ]
930 : :
931 : : // Add 35 addresses
932 [ + - + - ]: 1 : CNetAddr source = ResolveIP("252.2.2.2");
933 [ + + ]: 36 : for (unsigned int i = 1; i < 36; i++) {
934 [ + - + - : 70 : CService addr = ResolveService("250.1.1." + ToString(i));
+ - ]
935 [ + - + - : 175 : BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
+ - + + +
- - - ]
936 : :
937 : : // No collision yet.
938 [ + - + - : 70 : BOOST_CHECK(addrman->Good(addr));
+ - ]
939 : 35 : }
940 : :
941 : : // Collision between 36 and 19.
942 [ + - + - ]: 1 : CService addr = ResolveService("250.1.1.36");
943 [ + - + - : 5 : BOOST_CHECK(addrman->Add({CAddress(addr, NODE_NONE)}, source));
+ - + + +
- - - ]
944 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(addr));
+ - + - ]
945 : :
946 [ + - ]: 1 : auto info = addrman->SelectTriedCollision().first;
947 [ + - + - : 1 : BOOST_CHECK_EQUAL(info.ToStringAddrPort(), "250.1.1.19:0");
+ - ]
948 : :
949 : : // Ensure test of address fails, so that it is evicted.
950 : : // Update entry in tried by setting last good connection in the deep past.
951 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(info, NodeSeconds{1s}));
+ - ]
952 [ + - ]: 1 : addrman->Attempt(info, /*fCountFailure=*/false, Now<NodeSeconds>() - 61s);
953 : :
954 : : // Should swap 36 for 19.
955 [ + - ]: 1 : addrman->ResolveCollisions();
956 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - ]
957 [ + - ]: 2 : AddressPosition addr_pos{addrman->FindAddressEntry(CAddress(addr, NODE_NONE)).value()};
958 [ + - + - : 2 : BOOST_CHECK(addr_pos.tried);
+ - ]
959 : :
960 : : // If 36 was swapped for 19, then adding 36 to tried should fail because we
961 : : // are attempting to add a duplicate.
962 : : // We check this by verifying Good() returns false and also verifying that
963 : : // we have no collisions.
964 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(addr));
+ - + - ]
965 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - +
- ]
966 : :
967 : : // 19 should fail as a collision (not a duplicate) if we now attempt to move
968 : : // it to the tried table.
969 [ + - + - ]: 1 : CService addr19 = ResolveService("250.1.1.19");
970 [ + - + - : 2 : BOOST_CHECK(!addrman->Good(addr19));
+ - + - ]
971 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->SelectTriedCollision().first.ToStringAddrPort(), "250.1.1.36:0");
+ - + - ]
972 : :
973 : : // Eviction is also successful if too much time has passed since last try
974 [ + - + - ]: 1 : SetMockTime(GetTime() + 4 * 60 *60);
975 [ + - ]: 1 : addrman->ResolveCollisions();
976 [ + - + - : 2 : BOOST_CHECK(addrman->SelectTriedCollision().first.ToStringAddrPort() == "[::]:0");
+ - + - ]
977 : : //Now 19 is in tried again, and 36 back to new
978 [ + - ]: 2 : AddressPosition addr_pos19{addrman->FindAddressEntry(CAddress(addr19, NODE_NONE)).value()};
979 [ + - + - ]: 2 : BOOST_CHECK(addr_pos19.tried);
980 [ + - ]: 2 : AddressPosition addr_pos36{addrman->FindAddressEntry(CAddress(addr, NODE_NONE)).value()};
981 [ + - + - ]: 2 : BOOST_CHECK(!addr_pos36.tried);
982 [ + - + - ]: 73 : }
983 : :
984 : 2 : static auto AddrmanToStream(const AddrMan& addrman)
985 : : {
986 : 2 : DataStream ssPeersIn{};
987 [ + - + - ]: 2 : ssPeersIn << Params().MessageStart();
988 [ + - ]: 2 : ssPeersIn << addrman;
989 : 2 : return ssPeersIn;
990 : 0 : }
991 : :
992 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(load_addrman)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
993 : : {
994 : 1 : AddrMan addrman{EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node)};
995 : :
996 : 1 : std::optional<CService> addr1, addr2, addr3, addr4;
997 [ + - + - : 2 : addr1 = Lookup("250.7.1.1", 8333, false);
+ - ]
998 [ + - + - : 2 : BOOST_CHECK(addr1.has_value());
+ - ]
999 [ + - + - : 2 : addr2 = Lookup("250.7.2.2", 9999, false);
+ - ]
1000 [ + - + - : 2 : BOOST_CHECK(addr2.has_value());
+ - ]
1001 [ + - + - : 2 : addr3 = Lookup("250.7.3.3", 9999, false);
+ - ]
1002 [ + - + - : 2 : BOOST_CHECK(addr3.has_value());
+ - ]
1003 [ + - + - ]: 3 : addr3 = Lookup("250.7.3.3"s, 9999, false);
1004 [ + - + - : 2 : BOOST_CHECK(addr3.has_value());
+ - ]
1005 [ + - + - ]: 3 : addr4 = Lookup("250.7.3.3\0example.com"s, 9999, false);
1006 [ + - + - : 2 : BOOST_CHECK(!addr4.has_value());
+ - ]
1007 : :
1008 : : // Add three addresses to new table.
1009 [ + - + - : 2 : const std::optional<CService> source{Lookup("252.5.1.1", 8333, false)};
+ - ]
1010 [ + - + - : 2 : BOOST_CHECK(source.has_value());
+ - ]
1011 [ + + - - ]: 8 : std::vector<CAddress> addresses{CAddress(addr1.value(), NODE_NONE), CAddress(addr2.value(), NODE_NONE), CAddress(addr3.value(), NODE_NONE)};
1012 [ + - + - : 2 : BOOST_CHECK(addrman.Add(addresses, source.value()));
+ - + - +
- ]
1013 [ + - + - : 2 : BOOST_CHECK(addrman.Size() == 3);
+ - + - ]
1014 : :
1015 : : // Test that the de-serialization does not throw an exception.
1016 [ + - ]: 1 : auto ssPeers1{AddrmanToStream(addrman)};
1017 : 1 : bool exceptionThrown = false;
1018 [ + - + - ]: 1 : AddrMan addrman1{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
1019 : :
1020 [ + - + - : 2 : BOOST_CHECK(addrman1.Size() == 0);
+ - + - ]
1021 : 1 : try {
1022 : 1 : unsigned char pchMsgTmp[4];
1023 [ + - ]: 1 : ssPeers1 >> pchMsgTmp;
1024 [ + - ]: 1 : ssPeers1 >> addrman1;
1025 [ - - ]: 0 : } catch (const std::exception&) {
1026 : 0 : exceptionThrown = true;
1027 : 0 : }
1028 : :
1029 [ + - + - : 2 : BOOST_CHECK(addrman1.Size() == 3);
+ - + - ]
1030 [ + - + - : 2 : BOOST_CHECK(exceptionThrown == false);
+ - ]
1031 : :
1032 : : // Test that ReadFromStream creates an addrman with the correct number of addrs.
1033 [ + - ]: 1 : DataStream ssPeers2 = AddrmanToStream(addrman);
1034 : :
1035 [ + - + - ]: 1 : AddrMan addrman2{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
1036 [ + - + - : 2 : BOOST_CHECK(addrman2.Size() == 0);
+ - + - ]
1037 [ + - ]: 1 : ReadFromStream(addrman2, ssPeers2);
1038 [ + - + - : 2 : BOOST_CHECK(addrman2.Size() == 3);
+ - ]
1039 [ + - + - : 5 : }
+ - - + -
- ]
1040 : :
1041 : : // Produce a corrupt peers.dat that claims 20 addrs when it only has one addr.
1042 : 2 : static auto MakeCorruptPeersDat()
1043 : : {
1044 : 2 : DataStream s{};
1045 [ + - + - ]: 2 : s << ::Params().MessageStart();
1046 : :
1047 : 2 : unsigned char nVersion = 1;
1048 [ + - ]: 2 : s << nVersion;
1049 [ + - ]: 2 : s << ((unsigned char)32);
1050 [ + - ]: 2 : s << uint256::ONE;
1051 [ + - ]: 2 : s << 10; // nNew
1052 [ + - ]: 2 : s << 10; // nTried
1053 : :
1054 : 2 : int nUBuckets = ADDRMAN_NEW_BUCKET_COUNT ^ (1 << 30);
1055 [ + - ]: 2 : s << nUBuckets;
1056 : :
1057 [ + - + - : 4 : const std::optional<CService> serv{Lookup("252.1.1.1", 7777, false)};
+ - ]
1058 [ + - + - : 4 : BOOST_REQUIRE(serv.has_value());
+ - ]
1059 [ + - ]: 2 : CAddress addr = CAddress(serv.value(), NODE_NONE);
1060 [ + - + - : 4 : std::optional<CNetAddr> resolved{LookupHost("252.2.2.2", false)};
+ - ]
1061 [ + - + - : 4 : BOOST_REQUIRE(resolved.has_value());
+ - ]
1062 [ + - ]: 2 : AddrInfo info = AddrInfo(addr, resolved.value());
1063 [ + - ]: 2 : s << CAddress::V1_DISK(info);
1064 : :
1065 : 2 : return s;
1066 : 2 : }
1067 : :
1068 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(load_addrman_corrupted)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
1069 : : {
1070 : : // Test that the de-serialization of corrupted peers.dat throws an exception.
1071 : 1 : auto ssPeers1{MakeCorruptPeersDat()};
1072 : 1 : bool exceptionThrown = false;
1073 [ + - + - ]: 1 : AddrMan addrman1{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
1074 [ + - + - : 2 : BOOST_CHECK(addrman1.Size() == 0);
+ - + - ]
1075 : 1 : try {
1076 : 1 : unsigned char pchMsgTmp[4];
1077 [ + - ]: 1 : ssPeers1 >> pchMsgTmp;
1078 [ - + ]: 1 : ssPeers1 >> addrman1;
1079 [ - + ]: 1 : } catch (const std::exception&) {
1080 : 1 : exceptionThrown = true;
1081 : 1 : }
1082 [ + - + - : 2 : BOOST_CHECK(exceptionThrown);
+ - ]
1083 : :
1084 : : // Test that ReadFromStream fails if peers.dat is corrupt
1085 [ + - ]: 1 : auto ssPeers2{MakeCorruptPeersDat()};
1086 : :
1087 [ + - + - ]: 1 : AddrMan addrman2{EMPTY_NETGROUPMAN, !DETERMINISTIC, GetCheckRatio(m_node)};
1088 [ + - + - : 2 : BOOST_CHECK(addrman2.Size() == 0);
+ - + - ]
1089 [ + - - + : 2 : BOOST_CHECK_THROW(ReadFromStream(addrman2, ssPeers2), std::ios_base::failure);
- - - - -
+ + - +
- ]
1090 : 1 : }
1091 : :
1092 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_update_address)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
1093 : : {
1094 : : // Tests updating nTime via Connected() and nServices via SetServices() and Add()
1095 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
1096 [ + - + - ]: 1 : CNetAddr source{ResolveIP("252.2.2.2")};
1097 [ + - + - ]: 2 : CAddress addr{CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE)};
1098 : :
1099 : 1 : const auto start_time{Now<NodeSeconds>() - 10000s};
1100 : 1 : addr.nTime = start_time;
1101 [ + - + - : 3 : BOOST_CHECK(addrman->Add({addr}, source));
+ - + - +
+ - - ]
1102 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(), 1U);
+ - ]
1103 : :
1104 : : // Updating an addrman entry with a different port doesn't change it
1105 [ + - + - ]: 2 : CAddress addr_diff_port{CAddress(ResolveService("250.1.1.1", 8334), NODE_NONE)};
1106 : 1 : addr_diff_port.nTime = start_time;
1107 [ + - ]: 1 : addrman->Connected(addr_diff_port);
1108 [ + - ]: 1 : addrman->SetServices(addr_diff_port, NODE_NETWORK_LIMITED);
1109 [ + - ]: 1 : std::vector<CAddress> vAddr1{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
1110 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr1.size(), 1U);
+ - ]
1111 [ + - + - : 2 : BOOST_CHECK(vAddr1.at(0).nTime == start_time);
+ - + - ]
1112 [ + - + - : 1 : BOOST_CHECK_EQUAL(vAddr1.at(0).nServices, NODE_NONE);
+ - ]
1113 : :
1114 : : // Updating an addrman entry with the correct port is successful
1115 [ + - ]: 1 : addrman->Connected(addr);
1116 [ + - ]: 1 : addrman->SetServices(addr, NODE_NETWORK_LIMITED);
1117 [ + - ]: 1 : std::vector<CAddress> vAddr2 = addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt);
1118 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr2.size(), 1U);
+ - ]
1119 [ + - + - : 2 : BOOST_CHECK(vAddr2.at(0).nTime >= start_time + 10000s);
+ - + - ]
1120 [ + - + - : 1 : BOOST_CHECK_EQUAL(vAddr2.at(0).nServices, NODE_NETWORK_LIMITED);
+ - ]
1121 : :
1122 : : // Updating an existing addr through Add() (used in gossip relay) can add additional services but can't remove existing ones.
1123 [ + - + - ]: 2 : CAddress addr_v2{CAddress(ResolveService("250.1.1.1", 8333), NODE_P2P_V2)};
1124 : 1 : addr_v2.nTime = start_time;
1125 [ + - + - : 3 : BOOST_CHECK(!addrman->Add({addr_v2}, source));
+ - + - +
+ - - ]
1126 [ + - ]: 1 : std::vector<CAddress> vAddr3{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
1127 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr3.size(), 1U);
+ - ]
1128 [ + - + - : 1 : BOOST_CHECK_EQUAL(vAddr3.at(0).nServices, NODE_P2P_V2 | NODE_NETWORK_LIMITED);
+ - ]
1129 : :
1130 : : // SetServices() (used when we connected to them) overwrites existing service flags
1131 [ + - ]: 1 : addrman->SetServices(addr, NODE_NETWORK);
1132 [ + - ]: 1 : std::vector<CAddress> vAddr4{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
1133 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr4.size(), 1U);
+ - ]
1134 [ + - + - : 1 : BOOST_CHECK_EQUAL(vAddr4.at(0).nServices, NODE_NETWORK);
+ - ]
1135 : :
1136 : : // Promoting to Tried does not affect the service flags
1137 [ + - + - : 2 : BOOST_CHECK(addrman->Good(addr)); // addr has NODE_NONE
+ - + - ]
1138 [ + - ]: 1 : std::vector<CAddress> vAddr5{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
1139 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr5.size(), 1U);
+ - ]
1140 [ + - + - : 1 : BOOST_CHECK_EQUAL(vAddr5.at(0).nServices, NODE_NETWORK);
+ - ]
1141 : :
1142 : : // Adding service flags even works when the addr is in Tried
1143 [ + - + - : 3 : BOOST_CHECK(!addrman->Add({addr_v2}, source));
+ - + - +
+ - - ]
1144 [ + - ]: 1 : std::vector<CAddress> vAddr6{addrman->GetAddr(/*max_addresses=*/0, /*max_pct=*/0, /*network=*/std::nullopt)};
1145 [ + - - + : 1 : BOOST_CHECK_EQUAL(vAddr6.size(), 1U);
+ - ]
1146 [ + - + - : 1 : BOOST_CHECK_EQUAL(vAddr6.at(0).nServices, NODE_NETWORK | NODE_P2P_V2);
+ - ]
1147 : 4 : }
1148 : :
1149 [ + - + - : 7 : BOOST_AUTO_TEST_CASE(addrman_size)
+ - + - -
+ + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- + - + -
+ - + - +
- + - - +
+ - + - +
- + - + -
+ - - + +
- ]
1150 : : {
1151 : 1 : auto addrman = std::make_unique<AddrMan>(EMPTY_NETGROUPMAN, DETERMINISTIC, GetCheckRatio(m_node));
1152 [ + - + - ]: 1 : const CNetAddr source = ResolveIP("252.2.2.2");
1153 : :
1154 : : // empty addrman
1155 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 0U);
+ - ]
1156 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 0U);
+ - ]
1157 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 0U);
+ - ]
1158 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/false), 0U);
+ - ]
1159 : :
1160 : : // add two ipv4 addresses, one to tried and new
1161 [ + - + - ]: 2 : const CAddress addr1{ResolveService("250.1.1.1", 8333), NODE_NONE};
1162 [ + - + - : 3 : BOOST_CHECK(addrman->Add({addr1}, source));
+ - + - +
+ - - ]
1163 [ + - + - : 2 : BOOST_CHECK(addrman->Good(addr1));
+ - + - ]
1164 [ + - + - ]: 2 : const CAddress addr2{ResolveService("250.1.1.2", 8333), NODE_NONE};
1165 [ + - + - : 3 : BOOST_CHECK(addrman->Add({addr2}, source));
+ - + - +
+ - - ]
1166 : :
1167 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 2U);
+ - ]
1168 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 2U);
+ - ]
1169 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 1U);
+ - ]
1170 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/false), 1U);
+ - ]
1171 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/true), 1U);
+ - ]
1172 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/false), 1U);
+ - ]
1173 : :
1174 : : // add one i2p address to new
1175 [ + - ]: 1 : CService i2p_addr;
1176 [ + - ]: 1 : i2p_addr.SetSpecial("UDHDrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.I2P");
1177 : 1 : const CAddress addr3{i2p_addr, NODE_NONE};
1178 [ + - + - : 3 : BOOST_CHECK(addrman->Add({addr3}, source));
+ - + - +
+ - - ]
1179 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/std::nullopt), 3U);
+ - ]
1180 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_IPV4, /*in_new=*/std::nullopt), 2U);
+ - ]
1181 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_I2P, /*in_new=*/std::nullopt), 1U);
+ - ]
1182 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/NET_I2P, /*in_new=*/true), 1U);
+ - ]
1183 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/true), 2U);
+ - ]
1184 [ + - + - : 1 : BOOST_CHECK_EQUAL(addrman->Size(/*net=*/std::nullopt, /*in_new=*/false), 1U);
+ - ]
1185 : 4 : }
1186 : :
1187 : : BOOST_AUTO_TEST_SUITE_END()
|
