Branch data Line data Source code
1 : : // Copyright (c) 2020-2021 The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <crypto/common.h>
6 : : #include <crypto/sha256.h>
7 : : #include <crypto/siphash.h>
8 : : #include <primitives/transaction.h>
9 : : #include <test/fuzz/fuzz.h>
10 : : #include <txrequest.h>
11 : :
12 : : #include <bitset>
13 : : #include <cstdint>
14 : : #include <queue>
15 : : #include <vector>
16 : :
17 : : namespace {
18 : :
19 : : constexpr int MAX_TXHASHES = 16;
20 : : constexpr int MAX_PEERS = 16;
21 : :
22 : : //! Randomly generated GenTxids used in this test (length is MAX_TXHASHES).
23 : : uint256 TXHASHES[MAX_TXHASHES];
24 : :
25 : : //! Precomputed random durations (positive and negative, each ~exponentially distributed).
26 : : std::chrono::microseconds DELAYS[256];
27 : :
28 : : struct Initializer
29 : : {
30 : 216 : Initializer()
31 : : {
32 [ + + ]: 3672 : for (uint8_t txhash = 0; txhash < MAX_TXHASHES; txhash += 1) {
33 : 3456 : CSHA256().Write(&txhash, 1).Finalize(TXHASHES[txhash].begin());
34 : : }
35 : : int i = 0;
36 : : // DELAYS[N] for N=0..15 is just N microseconds.
37 [ + + ]: 3672 : for (; i < 16; ++i) {
38 : 3456 : DELAYS[i] = std::chrono::microseconds{i};
39 : : }
40 : : // DELAYS[N] for N=16..127 has randomly-looking but roughly exponentially increasing values up to
41 : : // 198.416453 seconds.
42 [ + + ]: 24408 : for (; i < 128; ++i) {
43 : 24192 : int diff_bits = ((i - 10) * 2) / 9;
44 : 24192 : uint64_t diff = 1 + (CSipHasher(0, 0).Write(i).Finalize() >> (64 - diff_bits));
45 : 24192 : DELAYS[i] = DELAYS[i - 1] + std::chrono::microseconds{diff};
46 : : }
47 : : // DELAYS[N] for N=128..255 are negative delays with the same magnitude as N=0..127.
48 [ + + ]: 27864 : for (; i < 256; ++i) {
49 : 27648 : DELAYS[i] = -DELAYS[255 - i];
50 : : }
51 : 216 : }
52 : : } g_initializer;
53 : :
54 : : /** Tester class for TxRequestTracker
55 : : *
56 : : * It includes a naive reimplementation of its behavior, for a limited set
57 : : * of MAX_TXHASHES distinct txids, and MAX_PEERS peer identifiers.
58 : : *
59 : : * All of the public member functions perform the same operation on
60 : : * an actual TxRequestTracker and on the state of the reimplementation.
61 : : * The output of GetRequestable is compared with the expected value
62 : : * as well.
63 : : *
64 : : * Check() calls the TxRequestTracker's sanity check, plus compares the
65 : : * output of the constant accessors (Size(), CountLoad(), CountTracked())
66 : : * with expected values.
67 : : */
68 : 431 : class Tester
69 : : {
70 : : //! TxRequestTracker object being tested.
71 : : TxRequestTracker m_tracker;
72 : :
73 : : //! States for txid/peer combinations in the naive data structure.
74 : : enum class State {
75 : : NOTHING, //!< Absence of this txid/peer combination
76 : :
77 : : // Note that this implementation does not distinguish between DELAYED/READY/BEST variants of CANDIDATE.
78 : : CANDIDATE,
79 : : REQUESTED,
80 : : COMPLETED,
81 : : };
82 : :
83 : : //! Sequence numbers, incremented whenever a new CANDIDATE is added.
84 : : uint64_t m_current_sequence{0};
85 : :
86 : : //! List of future 'events' (all inserted reqtimes/exptimes). This is used to implement AdvanceToEvent.
87 : : std::priority_queue<std::chrono::microseconds, std::vector<std::chrono::microseconds>,
88 : : std::greater<std::chrono::microseconds>> m_events;
89 : :
90 : : //! Information about a txhash/peer combination.
91 : 110336 : struct Announcement
92 : : {
93 : : std::chrono::microseconds m_time;
94 : : uint64_t m_sequence;
95 : : State m_state{State::NOTHING};
96 : : bool m_preferred;
97 : : bool m_is_wtxid;
98 : : uint64_t m_priority; //!< Precomputed priority.
99 : : };
100 : :
101 : : //! Information about all txhash/peer combination.
102 : : Announcement m_announcements[MAX_TXHASHES][MAX_PEERS];
103 : :
104 : : //! The current time; can move forward and backward.
105 : : std::chrono::microseconds m_now{244466666};
106 : :
107 : : //! Delete txhashes whose only announcements are COMPLETED.
108 : 13142588 : void Cleanup(int txhash)
109 : : {
110 : 13142588 : bool all_nothing = true;
111 [ + + ]: 146611052 : for (int peer = 0; peer < MAX_PEERS; ++peer) {
112 : 140541403 : const Announcement& ann = m_announcements[txhash][peer];
113 [ + + ]: 140541403 : if (ann.m_state != State::NOTHING) {
114 [ + + ]: 7825458 : if (ann.m_state != State::COMPLETED) return;
115 : : all_nothing = false;
116 : : }
117 : : }
118 [ + + ]: 6069649 : if (all_nothing) return;
119 [ + + ]: 1637797 : for (int peer = 0; peer < MAX_PEERS; ++peer) {
120 : 1541456 : m_announcements[txhash][peer].m_state = State::NOTHING;
121 : : }
122 : : }
123 : :
124 : : //! Find the current best peer to request from for a txhash (or -1 if none).
125 : 890667 : int GetSelected(int txhash) const
126 : : {
127 : 890667 : int ret = -1;
128 : 890667 : uint64_t ret_priority = 0;
129 [ + + ]: 14893397 : for (int peer = 0; peer < MAX_PEERS; ++peer) {
130 : 14030926 : const Announcement& ann = m_announcements[txhash][peer];
131 : : // Return -1 if there already is a (non-expired) in-flight request.
132 [ + + ]: 14030926 : if (ann.m_state == State::REQUESTED) return -1;
133 : : // If it's a viable candidate, see if it has lower priority than the best one so far.
134 [ + + + + ]: 14002730 : if (ann.m_state == State::CANDIDATE && ann.m_time <= m_now) {
135 [ + + + + ]: 1829050 : if (ret == -1 || ann.m_priority > ret_priority) {
136 : 1170279 : std::tie(ret, ret_priority) = std::tie(peer, ann.m_priority);
137 : : }
138 : : }
139 : : }
140 : 862471 : return ret;
141 : : }
142 : :
143 : : public:
144 [ + + + + ]: 117663 : Tester() : m_tracker(true) {}
145 : :
146 : 2394257 : std::chrono::microseconds Now() const { return m_now; }
147 : :
148 : 2631695 : void AdvanceTime(std::chrono::microseconds offset)
149 : : {
150 : 2631695 : m_now += offset;
151 [ + + + + ]: 3150551 : while (!m_events.empty() && m_events.top() <= m_now) m_events.pop();
152 : 2631695 : }
153 : :
154 : 2222875 : void AdvanceToEvent()
155 : : {
156 [ + + + + ]: 2495030 : while (!m_events.empty() && m_events.top() <= m_now) m_events.pop();
157 [ + + ]: 2222875 : if (!m_events.empty()) {
158 : 423026 : m_now = m_events.top();
159 : 423026 : m_events.pop();
160 : : }
161 : 2222875 : }
162 : :
163 : 673214 : void DisconnectedPeer(int peer)
164 : : {
165 : : // Apply to naive structure: all announcements for that peer are wiped.
166 [ + + ]: 11444638 : for (int txhash = 0; txhash < MAX_TXHASHES; ++txhash) {
167 [ + + ]: 10771424 : if (m_announcements[txhash][peer].m_state != State::NOTHING) {
168 : 738004 : m_announcements[txhash][peer].m_state = State::NOTHING;
169 : 738004 : Cleanup(txhash);
170 : : }
171 : : }
172 : :
173 : : // Call TxRequestTracker's implementation.
174 : 673214 : m_tracker.DisconnectedPeer(peer);
175 : 673214 : }
176 : :
177 : 835334 : void ForgetTxHash(int txhash)
178 : : {
179 : : // Apply to naive structure: all announcements for that txhash are wiped.
180 [ + + ]: 14200678 : for (int peer = 0; peer < MAX_PEERS; ++peer) {
181 : 13365344 : m_announcements[txhash][peer].m_state = State::NOTHING;
182 : : }
183 : 835334 : Cleanup(txhash);
184 : :
185 : : // Call TxRequestTracker's implementation.
186 : 835334 : m_tracker.ForgetTxHash(TXHASHES[txhash]);
187 : 835334 : }
188 : :
189 : 2547114 : void ReceivedInv(int peer, int txhash, bool is_wtxid, bool preferred, std::chrono::microseconds reqtime)
190 : : {
191 : : // Apply to naive structure: if no announcement for txidnum/peer combination
192 : : // already, create a new CANDIDATE; otherwise do nothing.
193 : 2547114 : Announcement& ann = m_announcements[txhash][peer];
194 [ + + ]: 2547114 : if (ann.m_state == State::NOTHING) {
195 : 1591118 : ann.m_preferred = preferred;
196 : 1591118 : ann.m_state = State::CANDIDATE;
197 : 1591118 : ann.m_time = reqtime;
198 : 1591118 : ann.m_is_wtxid = is_wtxid;
199 : 1591118 : ann.m_sequence = m_current_sequence++;
200 : 1591118 : ann.m_priority = m_tracker.ComputePriority(TXHASHES[txhash], peer, ann.m_preferred);
201 : :
202 : : // Add event so that AdvanceToEvent can quickly jump to the point where its reqtime passes.
203 [ + + ]: 1591118 : if (reqtime > m_now) m_events.push(reqtime);
204 : : }
205 : :
206 : : // Call TxRequestTracker's implementation.
207 [ + + ]: 2547114 : m_tracker.ReceivedInv(peer, is_wtxid ? GenTxid::Wtxid(TXHASHES[txhash]) : GenTxid::Txid(TXHASHES[txhash]), preferred, reqtime);
208 : 2547114 : }
209 : :
210 : 1251862 : void RequestedTx(int peer, int txhash, std::chrono::microseconds exptime)
211 : : {
212 : : // Apply to naive structure: if a CANDIDATE announcement exists for peer/txhash,
213 : : // convert it to REQUESTED, and change any existing REQUESTED announcement for the same txhash to COMPLETED.
214 [ + + ]: 1251862 : if (m_announcements[txhash][peer].m_state == State::CANDIDATE) {
215 [ + + ]: 2159306 : for (int peer2 = 0; peer2 < MAX_PEERS; ++peer2) {
216 [ + + ]: 2032288 : if (m_announcements[txhash][peer2].m_state == State::REQUESTED) {
217 : 11257 : m_announcements[txhash][peer2].m_state = State::COMPLETED;
218 : : }
219 : : }
220 : 127018 : m_announcements[txhash][peer].m_state = State::REQUESTED;
221 : 127018 : m_announcements[txhash][peer].m_time = exptime;
222 : : }
223 : :
224 : : // Add event so that AdvanceToEvent can quickly jump to the point where its exptime passes.
225 [ + + ]: 1251862 : if (exptime > m_now) m_events.push(exptime);
226 : :
227 : : // Call TxRequestTracker's implementation.
228 : 1251862 : m_tracker.RequestedTx(peer, TXHASHES[txhash], exptime);
229 : 1251862 : }
230 : :
231 : 381209 : void ReceivedResponse(int peer, int txhash)
232 : : {
233 : : // Apply to naive structure: convert anything to COMPLETED.
234 [ + + ]: 381209 : if (m_announcements[txhash][peer].m_state != State::NOTHING) {
235 : 93026 : m_announcements[txhash][peer].m_state = State::COMPLETED;
236 : 93026 : Cleanup(txhash);
237 : : }
238 : :
239 : : // Call TxRequestTracker's implementation.
240 : 381209 : m_tracker.ReceivedResponse(peer, TXHASHES[txhash]);
241 : 381209 : }
242 : :
243 : 717264 : void GetRequestable(int peer)
244 : : {
245 : : // Implement using naive structure:
246 : :
247 : : //! list of (sequence number, txhash, is_wtxid) tuples.
248 : 717264 : std::vector<std::tuple<uint64_t, int, bool>> result;
249 : 717264 : std::vector<std::pair<NodeId, GenTxid>> expected_expired;
250 [ + + ]: 12193488 : for (int txhash = 0; txhash < MAX_TXHASHES; ++txhash) {
251 : : // Mark any expired REQUESTED announcements as COMPLETED.
252 [ + + ]: 194214364 : for (int peer2 = 0; peer2 < MAX_PEERS; ++peer2) {
253 : 182837103 : Announcement& ann2 = m_announcements[txhash][peer2];
254 [ + + + + ]: 182837103 : if (ann2.m_state == State::REQUESTED && ann2.m_time <= m_now) {
255 [ + + + - ]: 98963 : expected_expired.emplace_back(peer2, ann2.m_is_wtxid ? GenTxid::Wtxid(TXHASHES[txhash]) : GenTxid::Txid(TXHASHES[txhash]));
256 : 98963 : ann2.m_state = State::COMPLETED;
257 : 98963 : break;
258 : : }
259 : : }
260 : : // And delete txids with only COMPLETED announcements left.
261 : 11476224 : Cleanup(txhash);
262 : : // CANDIDATEs for which this announcement has the highest priority get returned.
263 : 11476224 : const Announcement& ann = m_announcements[txhash][peer];
264 [ + + + + ]: 11476224 : if (ann.m_state == State::CANDIDATE && GetSelected(txhash) == peer) {
265 [ + - ]: 412977 : result.emplace_back(ann.m_sequence, txhash, ann.m_is_wtxid);
266 : : }
267 : : }
268 : : // Sort the results by sequence number.
269 : 717264 : std::sort(result.begin(), result.end());
270 : 717264 : std::sort(expected_expired.begin(), expected_expired.end());
271 : :
272 : : // Compare with TxRequestTracker's implementation.
273 : 717264 : std::vector<std::pair<NodeId, GenTxid>> expired;
274 [ + - ]: 717264 : const auto actual = m_tracker.GetRequestable(peer, m_now, &expired);
275 : 717264 : std::sort(expired.begin(), expired.end());
276 [ - + ]: 717264 : assert(expired == expected_expired);
277 : :
278 [ + - ]: 717264 : m_tracker.PostGetRequestableSanityCheck(m_now);
279 [ - + ]: 717264 : assert(result.size() == actual.size());
280 [ + + ]: 1130241 : for (size_t pos = 0; pos < actual.size(); ++pos) {
281 [ - + ]: 412977 : assert(TXHASHES[std::get<1>(result[pos])] == actual[pos].GetHash());
282 [ - + ]: 412977 : assert(std::get<2>(result[pos]) == actual[pos].IsWtxid());
283 : : }
284 : 717264 : }
285 : :
286 : 431 : void Check()
287 : : {
288 : : // Compare CountTracked and CountLoad with naive structure.
289 : 431 : size_t total = 0;
290 [ + + ]: 7327 : for (int peer = 0; peer < MAX_PEERS; ++peer) {
291 : : size_t tracked = 0;
292 : : size_t inflight = 0;
293 : : size_t candidates = 0;
294 [ + + ]: 117232 : for (int txhash = 0; txhash < MAX_TXHASHES; ++txhash) {
295 : 110336 : tracked += m_announcements[txhash][peer].m_state != State::NOTHING;
296 : 110336 : inflight += m_announcements[txhash][peer].m_state == State::REQUESTED;
297 : 110336 : candidates += m_announcements[txhash][peer].m_state == State::CANDIDATE;
298 : :
299 : 110336 : std::bitset<MAX_PEERS> expected_announcers;
300 [ + + ]: 1875712 : for (int peer = 0; peer < MAX_PEERS; ++peer) {
301 [ + + ]: 1765376 : if (m_announcements[txhash][peer].m_state == State::CANDIDATE || m_announcements[txhash][peer].m_state == State::REQUESTED) {
302 : 138400 : expected_announcers[peer] = true;
303 : : }
304 : : }
305 : 110336 : std::vector<NodeId> candidate_peers;
306 [ + - ]: 110336 : m_tracker.GetCandidatePeers(TXHASHES[txhash], candidate_peers);
307 [ - + ]: 110336 : assert(expected_announcers.count() == candidate_peers.size());
308 [ + + ]: 248736 : for (const auto& peer : candidate_peers) {
309 [ - + ]: 138400 : assert(expected_announcers[peer]);
310 : : }
311 : 110336 : }
312 [ - + ]: 6896 : assert(m_tracker.Count(peer) == tracked);
313 [ - + ]: 6896 : assert(m_tracker.CountInFlight(peer) == inflight);
314 [ - + ]: 6896 : assert(m_tracker.CountCandidates(peer) == candidates);
315 : 6896 : total += tracked;
316 : : }
317 : : // Compare Size.
318 [ - + ]: 431 : assert(m_tracker.Size() == total);
319 : :
320 : : // Invoke internal consistency check of TxRequestTracker object.
321 : 431 : m_tracker.SanityCheck();
322 : 431 : }
323 : : };
324 : : } // namespace
325 : :
326 [ + - ]: 863 : FUZZ_TARGET(txrequest)
327 : : {
328 : : // Tester object (which encapsulates a TxRequestTracker).
329 : 431 : Tester tester;
330 : :
331 : : // Decode the input as a sequence of instructions with parameters
332 : 431 : auto it = buffer.begin();
333 [ + + ]: 11260998 : while (it != buffer.end()) {
334 [ + + + + : 11260567 : int cmd = *(it++) % 11;
+ + + + +
- ]
335 : 11260567 : int peer, txidnum, delaynum;
336 [ + + + + : 11260567 : switch (cmd) {
+ + + + +
- ]
337 : 2222875 : case 0: // Make time jump to the next event (m_time of CANDIDATE or REQUESTED)
338 : 2222875 : tester.AdvanceToEvent();
339 : : break;
340 : 2631695 : case 1: // Change time
341 [ + + ]: 2631695 : delaynum = it == buffer.end() ? 0 : *(it++);
342 : 2631695 : tester.AdvanceTime(DELAYS[delaynum]);
343 : : break;
344 : 717264 : case 2: // Query for requestable txs
345 [ + + ]: 717264 : peer = it == buffer.end() ? 0 : *(it++) % MAX_PEERS;
346 [ + - ]: 717264 : tester.GetRequestable(peer);
347 : : break;
348 : 673214 : case 3: // Peer went offline
349 [ + + ]: 673214 : peer = it == buffer.end() ? 0 : *(it++) % MAX_PEERS;
350 [ + - ]: 673214 : tester.DisconnectedPeer(peer);
351 : : break;
352 : 835334 : case 4: // No longer need tx
353 [ + + ]: 835334 : txidnum = it == buffer.end() ? 0 : *(it++);
354 [ + - ]: 835334 : tester.ForgetTxHash(txidnum % MAX_TXHASHES);
355 : : break;
356 : 1404719 : case 5: // Received immediate preferred inv
357 : 1404719 : case 6: // Same, but non-preferred.
358 [ + + ]: 1404719 : peer = it == buffer.end() ? 0 : *(it++) % MAX_PEERS;
359 [ + + ]: 1404719 : txidnum = it == buffer.end() ? 0 : *(it++);
360 [ + - ]: 1404719 : tester.ReceivedInv(peer, txidnum % MAX_TXHASHES, (txidnum / MAX_TXHASHES) & 1, cmd & 1,
361 : : std::chrono::microseconds::min());
362 : : break;
363 : 1142395 : case 7: // Received delayed preferred inv
364 : 1142395 : case 8: // Same, but non-preferred.
365 [ + + ]: 1142395 : peer = it == buffer.end() ? 0 : *(it++) % MAX_PEERS;
366 [ + + ]: 1142395 : txidnum = it == buffer.end() ? 0 : *(it++);
367 [ + + ]: 1142395 : delaynum = it == buffer.end() ? 0 : *(it++);
368 : 1142395 : tester.ReceivedInv(peer, txidnum % MAX_TXHASHES, (txidnum / MAX_TXHASHES) & 1, cmd & 1,
369 [ + - ]: 1142395 : tester.Now() + DELAYS[delaynum]);
370 : : break;
371 : 1251862 : case 9: // Requested tx from peer
372 [ + + ]: 1251862 : peer = it == buffer.end() ? 0 : *(it++) % MAX_PEERS;
373 [ + + ]: 1251862 : txidnum = it == buffer.end() ? 0 : *(it++);
374 [ + + ]: 1251862 : delaynum = it == buffer.end() ? 0 : *(it++);
375 [ + - ]: 1251862 : tester.RequestedTx(peer, txidnum % MAX_TXHASHES, tester.Now() + DELAYS[delaynum]);
376 : : break;
377 : 381209 : case 10: // Received response
378 [ + + ]: 381209 : peer = it == buffer.end() ? 0 : *(it++) % MAX_PEERS;
379 [ + + ]: 381209 : txidnum = it == buffer.end() ? 0 : *(it++);
380 [ + - ]: 381209 : tester.ReceivedResponse(peer, txidnum % MAX_TXHASHES);
381 : : break;
382 : 0 : default:
383 : 0 : assert(false);
384 : : }
385 : : }
386 [ + - ]: 431 : tester.Check();
387 : 431 : }
|
