Branch data Line data Source code
1 : : // Copyright (c) The Bitcoin Core developers
2 : : // Distributed under the MIT software license, see the accompanying
3 : : // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 : :
5 : : #include <cluster_linearize.h>
6 : : #include <test/fuzz/FuzzedDataProvider.h>
7 : : #include <test/fuzz/fuzz.h>
8 : : #include <test/util/cluster_linearize.h>
9 : : #include <test/util/random.h>
10 : : #include <txgraph.h>
11 : : #include <util/bitset.h>
12 : : #include <util/feefrac.h>
13 : :
14 : : #include <algorithm>
15 : : #include <cstdint>
16 : : #include <iterator>
17 : : #include <map>
18 : : #include <memory>
19 : : #include <set>
20 : : #include <utility>
21 : :
22 : : using namespace cluster_linearize;
23 : :
24 : : namespace {
25 : :
26 : : /** Data type representing a naive simulated TxGraph, keeping all transactions (even from
27 : : * disconnected components) in a single DepGraph. Unlike the real TxGraph, this only models
28 : : * a single graph, and multiple instances are used to simulate main/staging. */
29 : : struct SimTxGraph
30 : : {
31 : : /** Maximum number of transactions to support simultaneously. Set this higher than txgraph's
32 : : * cluster count, so we can exercise situations with more transactions than fit in one
33 : : * cluster. */
34 : : static constexpr unsigned MAX_TRANSACTIONS = MAX_CLUSTER_COUNT_LIMIT * 2;
35 : : /** Set type to use in the simulation. */
36 : : using SetType = BitSet<MAX_TRANSACTIONS>;
37 : : /** Data type for representing positions within SimTxGraph::graph. */
38 : : using Pos = DepGraphIndex;
39 : : /** Constant to mean "missing in this graph". */
40 : : static constexpr auto MISSING = Pos(-1);
41 : :
42 : : /** The dependency graph (for all transactions in the simulation, regardless of
43 : : * connectivity/clustering). */
44 : : DepGraph<SetType> graph;
45 : : /** For each position in graph, which TxGraph::Ref it corresponds with (if any). Use shared_ptr
46 : : * so that a SimTxGraph can be copied to create a staging one, while sharing Refs with
47 : : * the main graph. */
48 : : std::array<std::shared_ptr<TxGraph::Ref>, MAX_TRANSACTIONS> simmap;
49 : : /** For each TxGraph::Ref in graph, the position it corresponds with. */
50 : : std::map<const TxGraph::Ref*, Pos> simrevmap;
51 : : /** The set of TxGraph::Ref entries that have been removed, but not yet destroyed. */
52 : : std::vector<std::shared_ptr<TxGraph::Ref>> removed;
53 : : /** Whether the graph is oversized (true = yes, false = no, std::nullopt = unknown). */
54 : : std::optional<bool> oversized;
55 : : /** The configured maximum number of transactions per cluster. */
56 : : DepGraphIndex max_cluster_count;
57 : : /** Which transactions have been modified in the graph since creation, either directly or by
58 : : * being in a cluster which includes modifications. Only relevant for the staging graph. */
59 : : SetType modified;
60 : : /** The configured maximum total size of transactions per cluster. */
61 : : uint64_t max_cluster_size;
62 : : /** Whether the corresponding real graph is known to be optimally linearized. */
63 : : bool real_is_optimal{false};
64 : :
65 : : /** Construct a new SimTxGraph with the specified maximum cluster count and size. */
66 : 2933 : explicit SimTxGraph(DepGraphIndex cluster_count, uint64_t cluster_size) :
67 : 2933 : max_cluster_count(cluster_count), max_cluster_size(cluster_size) {}
68 : :
69 : : // Permit copying and moving.
70 [ + - + - ]: 17601 : SimTxGraph(const SimTxGraph&) noexcept = default;
71 : : SimTxGraph& operator=(const SimTxGraph&) noexcept = default;
72 : 0 : SimTxGraph(SimTxGraph&&) noexcept = default;
73 : 8868 : SimTxGraph& operator=(SimTxGraph&&) noexcept = default;
74 : :
75 : : /** Get the connected components within this simulated transaction graph. */
76 : 47986 : std::vector<SetType> GetComponents()
77 : : {
78 : 47986 : auto todo = graph.Positions();
79 : 47986 : std::vector<SetType> ret;
80 : : // Iterate over all connected components of the graph.
81 [ + + ]: 2551166 : while (todo.Any()) {
82 : 1227597 : auto component = graph.FindConnectedComponent(todo);
83 [ + - ]: 1227597 : ret.push_back(component);
84 : 1227597 : todo -= component;
85 : : }
86 : 47986 : return ret;
87 : 0 : }
88 : :
89 : : /** Check whether this graph is oversized (contains a connected component whose number of
90 : : * transactions exceeds max_cluster_count. */
91 : 2743434 : bool IsOversized()
92 : : {
93 [ + + ]: 2743434 : if (!oversized.has_value()) {
94 : : // Only recompute when oversized isn't already known.
95 : 35444 : oversized = false;
96 [ + + ]: 986211 : for (auto component : GetComponents()) {
97 [ + + ]: 950767 : if (component.Count() > max_cluster_count) oversized = true;
98 : 950767 : uint64_t component_size{0};
99 [ + + ]: 2124067 : for (auto i : component) component_size += graph.FeeRate(i).size;
100 [ + + ]: 950767 : if (component_size > max_cluster_size) oversized = true;
101 : 35444 : }
102 : : }
103 : 2743434 : return *oversized;
104 : : }
105 : :
106 : 267266 : void MakeModified(DepGraphIndex index)
107 : : {
108 : 267266 : modified |= graph.GetConnectedComponent(graph.Positions(), index);
109 : 267266 : }
110 : :
111 : : /** Determine the number of (non-removed) transactions in the graph. */
112 [ + + - + : 1692172 : DepGraphIndex GetTransactionCount() const { return graph.TxCount(); }
+ + - + -
+ ]
113 : :
114 : : /** Get the sum of all fees/sizes in the graph. */
115 : 9841 : FeePerWeight SumAll() const
116 : : {
117 : 9841 : FeePerWeight ret;
118 [ + + ]: 283365 : for (auto i : graph.Positions()) {
119 : 273524 : ret += graph.FeeRate(i);
120 : : }
121 : 9841 : return ret;
122 : : }
123 : :
124 : : /** Get the position where ref occurs in this simulated graph, or -1 if it does not. */
125 : 4527491 : Pos Find(const TxGraph::Ref* ref) const
126 : : {
127 : 4527491 : auto it = simrevmap.find(ref);
128 [ + + ]: 4527491 : if (it != simrevmap.end()) return it->second;
129 : : return MISSING;
130 : : }
131 : :
132 : : /** Given a position in this simulated graph, get the corresponding TxGraph::Ref. */
133 : 3823371 : TxGraph::Ref* GetRef(Pos pos)
134 : : {
135 [ - + ]: 3823371 : assert(graph.Positions()[pos]);
136 [ - + ]: 3823371 : assert(simmap[pos]);
137 : 3823371 : return simmap[pos].get();
138 : : }
139 : :
140 : : /** Add a new transaction to the simulation. */
141 : 149014 : void AddTransaction(TxGraph::Ref&& ref, const FeePerWeight& feerate)
142 : : {
143 [ - + ]: 149014 : assert(graph.TxCount() < MAX_TRANSACTIONS);
144 : 149014 : auto simpos = graph.AddTransaction(feerate);
145 : 149014 : real_is_optimal = false;
146 : 149014 : MakeModified(simpos);
147 [ - + ]: 149014 : assert(graph.Positions()[simpos]);
148 [ - + ]: 149014 : simmap[simpos] = std::make_shared<TxGraph::Ref>(std::move(ref));
149 : 149014 : auto ptr = simmap[simpos].get();
150 : 149014 : simrevmap[ptr] = simpos;
151 : : // This may invalidate our cached oversized value.
152 [ + + + + ]: 149014 : if (oversized.has_value() && !*oversized) oversized = std::nullopt;
153 : 149014 : }
154 : :
155 : : /** Add a dependency between two positions in this graph. */
156 : 89656 : void AddDependency(TxGraph::Ref* parent, TxGraph::Ref* child)
157 : : {
158 : 89656 : auto par_pos = Find(parent);
159 [ + + ]: 89656 : if (par_pos == MISSING) return;
160 : 87615 : auto chl_pos = Find(child);
161 [ + + ]: 87615 : if (chl_pos == MISSING) return;
162 : 85941 : graph.AddDependencies(SetType::Singleton(par_pos), chl_pos);
163 : 85941 : MakeModified(par_pos);
164 : 85941 : real_is_optimal = false;
165 : : // This may invalidate our cached oversized value.
166 [ + + + + ]: 85941 : if (oversized.has_value() && !*oversized) oversized = std::nullopt;
167 : : }
168 : :
169 : : /** Modify the transaction fee of a ref, if it exists. */
170 : 7474 : void SetTransactionFee(TxGraph::Ref* ref, int64_t fee)
171 : : {
172 : 7474 : auto pos = Find(ref);
173 [ + + ]: 7474 : if (pos == MISSING) return;
174 : : // No need to invoke MakeModified, because this equally affects main and staging.
175 : 5396 : real_is_optimal = false;
176 : 5396 : graph.FeeRate(pos).fee = fee;
177 : : }
178 : :
179 : : /** Remove the transaction in the specified position from the graph. */
180 : 25916 : void RemoveTransaction(TxGraph::Ref* ref)
181 : : {
182 : 25916 : auto pos = Find(ref);
183 [ + + ]: 25916 : if (pos == MISSING) return;
184 : 20930 : MakeModified(pos);
185 : 20930 : real_is_optimal = false;
186 : 20930 : graph.RemoveTransactions(SetType::Singleton(pos));
187 : 20930 : simrevmap.erase(simmap[pos].get());
188 : : // Retain the TxGraph::Ref corresponding to this position, so the Ref destruction isn't
189 : : // invoked until the simulation explicitly decided to do so.
190 : 20930 : removed.push_back(std::move(simmap[pos]));
191 : 20930 : simmap[pos].reset();
192 : : // This may invalidate our cached oversized value.
193 [ + + + + ]: 20930 : if (oversized.has_value() && *oversized) oversized = std::nullopt;
194 : : }
195 : :
196 : : /** Destroy the transaction from the graph, including from the removed set. This will
197 : : * trigger TxGraph::Ref::~Ref. reset_oversize controls whether the cached oversized
198 : : * value is cleared (destroying does not clear oversizedness in TxGraph of the main
199 : : * graph while staging exists). */
200 : 14670 : void DestroyTransaction(TxGraph::Ref* ref, bool reset_oversize)
201 : : {
202 : 14670 : auto pos = Find(ref);
203 [ + + ]: 14670 : if (pos == MISSING) {
204 : : // Wipe the ref, if it exists, from the removed vector. Use std::partition rather
205 : : // than std::erase because we don't care about the order of the entries that
206 : : // remain.
207 [ + + - + ]: 12770 : auto remove = std::partition(removed.begin(), removed.end(), [&](auto& arg) { return arg.get() != ref; });
208 : 3289 : removed.erase(remove, removed.end());
209 : : } else {
210 : 11381 : MakeModified(pos);
211 : 11381 : graph.RemoveTransactions(SetType::Singleton(pos));
212 : 11381 : real_is_optimal = false;
213 : 11381 : simrevmap.erase(simmap[pos].get());
214 : 11381 : simmap[pos].reset();
215 : : // This may invalidate our cached oversized value.
216 [ + + + + : 11381 : if (reset_oversize && oversized.has_value() && *oversized) {
+ + ]
217 : 1087 : oversized = std::nullopt;
218 : : }
219 : : }
220 : 14670 : }
221 : :
222 : : /** Construct the set with all positions in this graph corresponding to the specified
223 : : * TxGraph::Refs. All of them must occur in this graph and not be removed. */
224 : 543135 : SetType MakeSet(std::span<TxGraph::Ref* const> arg)
225 : : {
226 : 543135 : SetType ret;
227 [ + + ]: 2686347 : for (TxGraph::Ref* ptr : arg) {
228 : 2143212 : auto pos = Find(ptr);
229 [ - + ]: 2143212 : assert(pos != Pos(-1));
230 : 2143212 : ret.Set(pos);
231 : : }
232 : 543135 : return ret;
233 : : }
234 : :
235 : : /** Get the set of ancestors (desc=false) or descendants (desc=true) in this graph. */
236 : 48937 : SetType GetAncDesc(TxGraph::Ref* arg, bool desc)
237 : : {
238 : 48937 : auto pos = Find(arg);
239 [ + + ]: 48937 : if (pos == MISSING) return {};
240 [ + + ]: 34641 : return desc ? graph.Descendants(pos) : graph.Ancestors(pos);
241 : : }
242 : :
243 : : /** Given a set of Refs (given as a vector of pointers), expand the set to include all its
244 : : * ancestors (desc=false) or all its descendants (desc=true) in this graph. */
245 : 22374 : void IncludeAncDesc(std::vector<TxGraph::Ref*>& arg, bool desc)
246 : : {
247 : 22374 : std::vector<TxGraph::Ref*> ret;
248 [ + + ]: 48071 : for (auto ptr : arg) {
249 : 25697 : auto simpos = Find(ptr);
250 [ + + ]: 25697 : if (simpos != MISSING) {
251 [ + + + + ]: 45178 : for (auto i : desc ? graph.Descendants(simpos) : graph.Ancestors(simpos)) {
252 [ + - ]: 27828 : ret.push_back(simmap[i].get());
253 : : }
254 : : } else {
255 [ + - ]: 8347 : ret.push_back(ptr);
256 : : }
257 : : }
258 : : // Construct deduplicated version in input (do not use std::sort/std::unique for
259 : : // deduplication as it'd rely on non-deterministic pointer comparison).
260 [ + - ]: 22374 : arg.clear();
261 [ + + ]: 58549 : for (auto ptr : ret) {
262 [ + + ]: 36175 : if (std::find(arg.begin(), arg.end(), ptr) == arg.end()) {
263 [ + - ]: 28911 : arg.push_back(ptr);
264 : : }
265 : : }
266 : 22374 : }
267 : :
268 : :
269 : : /** Verify that set contains transactions from every oversized cluster, and nothing from
270 : : * non-oversized ones. */
271 : 2245 : bool MatchesOversizedClusters(const SetType& set)
272 : : {
273 [ + - + - ]: 4490 : if (set.Any() && !IsOversized()) return false;
274 : :
275 : 2245 : auto todo = graph.Positions();
276 [ + - ]: 4490 : if (!set.IsSubsetOf(todo)) return false;
277 : :
278 : : // Walk all clusters, and make sure all of set doesn't come from non-oversized clusters
279 [ + + ]: 80838 : while (todo.Any()) {
280 : 38174 : auto component = graph.FindConnectedComponent(todo);
281 : : // Determine whether component is oversized, due to either the size or count limit.
282 : 38174 : bool is_oversized = component.Count() > max_cluster_count;
283 : 38174 : uint64_t component_size{0};
284 [ + + ]: 131042 : for (auto i : component) component_size += graph.FeeRate(i).size;
285 : 38174 : is_oversized |= component_size > max_cluster_size;
286 : : // Check whether overlap with set matches is_oversized.
287 [ + - ]: 76348 : if (is_oversized != set.Overlaps(component)) return false;
288 : 38174 : todo -= component;
289 : : }
290 : : return true;
291 : : }
292 : : };
293 : :
294 : : } // namespace
295 : :
296 [ + - ]: 3389 : FUZZ_TARGET(txgraph)
297 : : {
298 : : // This is a big simulation test for TxGraph, which performs a fuzz-derived sequence of valid
299 : : // operations on a TxGraph instance, as well as on a simpler (mostly) reimplementation (see
300 : : // SimTxGraph above), comparing the outcome of functions that return a result, and finally
301 : : // performing a full comparison between the two.
302 : :
303 : 2933 : SeedRandomStateForTest(SeedRand::ZEROS);
304 : 2933 : FuzzedDataProvider provider(buffer.data(), buffer.size());
305 : :
306 : : /** Internal test RNG, used only for decisions which would require significant amount of data
307 : : * to be read from the provider, without realistically impacting test sensitivity, and for
308 : : * specialized test cases that are hard to perform more generically. */
309 : 2933 : InsecureRandomContext rng(provider.ConsumeIntegral<uint64_t>());
310 : :
311 : : /** Variable used whenever an empty TxGraph::Ref is needed. */
312 : 2933 : TxGraph::Ref empty_ref;
313 : :
314 : : /** The maximum number of transactions per (non-oversized) cluster we will use in this
315 : : * simulation. */
316 : 2933 : auto max_cluster_count = provider.ConsumeIntegralInRange<DepGraphIndex>(1, MAX_CLUSTER_COUNT_LIMIT);
317 : : /** The maximum total size of transactions in a (non-oversized) cluster. */
318 : 2933 : auto max_cluster_size = provider.ConsumeIntegralInRange<uint64_t>(1, 0x3fffff * MAX_CLUSTER_COUNT_LIMIT);
319 : : /** The number of iterations to consider a cluster acceptably linearized. */
320 : 2933 : auto acceptable_iters = provider.ConsumeIntegralInRange<uint64_t>(0, 10000);
321 : :
322 : : // Construct a real graph, and a vector of simulated graphs (main, and possibly staging).
323 : 2933 : auto real = MakeTxGraph(max_cluster_count, max_cluster_size, acceptable_iters);
324 : 2933 : std::vector<SimTxGraph> sims;
325 [ + - ]: 2933 : sims.reserve(2);
326 [ + - ]: 2933 : sims.emplace_back(max_cluster_count, max_cluster_size);
327 : :
328 : : /** Struct encapsulating information about a BlockBuilder that's currently live. */
329 : 8895 : struct BlockBuilderData
330 : : {
331 : : /** BlockBuilder object from real. */
332 : : std::unique_ptr<TxGraph::BlockBuilder> builder;
333 : : /** The set of transactions marked as included in *builder. */
334 : : SimTxGraph::SetType included;
335 : : /** The set of transactions marked as included or skipped in *builder. */
336 : : SimTxGraph::SetType done;
337 : : /** The last chunk feerate returned by *builder. IsEmpty() if none yet. */
338 : : FeePerWeight last_feerate;
339 : :
340 : 3078 : BlockBuilderData(std::unique_ptr<TxGraph::BlockBuilder> builder_in) : builder(std::move(builder_in)) {}
341 : : };
342 : :
343 : : /** Currently active block builders. */
344 : 2933 : std::vector<BlockBuilderData> block_builders;
345 : :
346 : : /** Function to pick any Ref (for either sim in sims: from sim.simmap or sim.removed, or the
347 : : * empty Ref). */
348 : 436637 : auto pick_fn = [&]() noexcept -> TxGraph::Ref* {
349 [ - + ]: 433704 : size_t tx_count[2] = {sims[0].GetTransactionCount(), 0};
350 : : /** The number of possible choices. */
351 [ - + ]: 433704 : size_t choices = tx_count[0] + sims[0].removed.size() + 1;
352 [ - + + + ]: 433704 : if (sims.size() == 2) {
353 [ - + ]: 123481 : tx_count[1] = sims[1].GetTransactionCount();
354 [ - + ]: 123481 : choices += tx_count[1] + sims[1].removed.size();
355 : : }
356 : : /** Pick one of them. */
357 : 433704 : auto choice = provider.ConsumeIntegralInRange<size_t>(0, choices - 1);
358 : : // Consider both main and (if it exists) staging.
359 [ - + + + ]: 533000 : for (size_t level = 0; level < sims.size(); ++level) {
360 [ + + ]: 488603 : auto& sim = sims[level];
361 [ + + ]: 488603 : if (choice < tx_count[level]) {
362 : : // Return from graph.
363 [ + - ]: 3191839 : for (auto i : sim.graph.Positions()) {
364 [ + + ]: 3191839 : if (choice == 0) return sim.GetRef(i);
365 : 2837285 : --choice;
366 : : }
367 : 0 : assert(false);
368 : : } else {
369 : 134049 : choice -= tx_count[level];
370 : : }
371 [ - + + + ]: 134049 : if (choice < sim.removed.size()) {
372 : : // Return from removed.
373 : 34753 : return sim.removed[choice].get();
374 : : } else {
375 : 99296 : choice -= sim.removed.size();
376 : : }
377 : : }
378 : : // Return empty.
379 [ - + ]: 44397 : assert(choice == 0);
380 : 44397 : return &empty_ref;
381 : 2933 : };
382 : :
383 : : /** Function to construct the correct fee-size diagram a real graph has based on its graph
384 : : * order (as reported by GetCluster(), so it works for both main and staging). */
385 : 6402 : auto get_diagram_fn = [&](TxGraph::Level level_select) -> std::vector<FeeFrac> {
386 [ + + - + ]: 3469 : int level = level_select == TxGraph::Level::MAIN ? 0 : sims.size() - 1;
387 : 3469 : auto& sim = sims[level];
388 : : // For every transaction in the graph, request its cluster, and throw them into a set.
389 : 3469 : std::set<std::vector<TxGraph::Ref*>> clusters;
390 [ + + ]: 129303 : for (auto i : sim.graph.Positions()) {
391 : 125834 : auto ref = sim.GetRef(i);
392 [ + - ]: 251668 : clusters.insert(real->GetCluster(*ref, level_select));
393 : : }
394 : : // Compute the chunkings of each (deduplicated) cluster.
395 : 3469 : size_t num_tx{0};
396 : 3469 : std::vector<FeeFrac> chunk_feerates;
397 [ + + ]: 100173 : for (const auto& cluster : clusters) {
398 [ - + ]: 96704 : num_tx += cluster.size();
399 : 96704 : std::vector<SimTxGraph::Pos> linearization;
400 [ + - ]: 96704 : linearization.reserve(cluster.size());
401 [ + - + + ]: 222538 : for (auto refptr : cluster) linearization.push_back(sim.Find(refptr));
402 [ - + + + ]: 212446 : for (const FeeFrac& chunk_feerate : ChunkLinearization(sim.graph, linearization)) {
403 [ + - ]: 115742 : chunk_feerates.push_back(chunk_feerate);
404 : 96704 : }
405 : 96704 : }
406 : : // Verify the number of transactions after deduplicating clusters. This implicitly verifies
407 : : // that GetCluster on each element of a cluster reports the cluster transactions in the same
408 : : // order.
409 [ - + ]: 3469 : assert(num_tx == sim.GetTransactionCount());
410 : : // Sort by feerate only, since violating topological constraints within same-feerate
411 : : // chunks won't affect diagram comparisons.
412 : 3469 : std::sort(chunk_feerates.begin(), chunk_feerates.end(), std::greater{});
413 : 3469 : return chunk_feerates;
414 : 6402 : };
415 : :
416 [ + + + + ]: 416750 : LIMITED_WHILE(provider.remaining_bytes() > 0, 200) {
417 : : // Read a one-byte command.
418 : 413817 : int command = provider.ConsumeIntegral<uint8_t>();
419 : 413817 : int orig_command = command;
420 : :
421 : : // Treat the lowest bit of a command as a flag (which selects a variant of some of the
422 : : // operations), and the second-lowest bit as a way of selecting main vs. staging, and leave
423 : : // the rest of the bits in command.
424 : 413817 : bool alt = command & 1;
425 : 413817 : TxGraph::Level level_select = (command & 2) ? TxGraph::Level::MAIN : TxGraph::Level::TOP;
426 : 413817 : command >>= 2;
427 : :
428 : : /** Use the bottom 2 bits of command to select an entry in the block_builders vector (if
429 : : * any). These use the same bits as alt/level_select, so don't use those in actions below
430 : : * where builder_idx is used as well. */
431 [ - + + + ]: 413817 : int builder_idx = block_builders.empty() ? -1 : int((orig_command & 3) % block_builders.size());
432 : :
433 : : // Provide convenient aliases for the top simulated graph (main, or staging if it exists),
434 : : // one for the simulated graph selected based on level_select (for operations that can operate
435 : : // on both graphs), and one that always refers to the main graph.
436 : 413817 : auto& top_sim = sims.back();
437 [ + + ]: 413817 : auto& sel_sim = level_select == TxGraph::Level::MAIN ? sims[0] : top_sim;
438 : 413817 : auto& main_sim = sims[0];
439 : :
440 : : // Keep decrementing command for each applicable operation, until one is hit. Multiple
441 : : // iterations may be necessary.
442 : 603223 : while (true) {
443 [ + + + + : 713975 : if ((block_builders.empty() || sims.size() > 1) && top_sim.GetTransactionCount() < SimTxGraph::MAX_TRANSACTIONS && command-- == 0) {
+ + + + ]
444 : : // AddTransaction.
445 : 149014 : int64_t fee;
446 : 149014 : int32_t size;
447 [ + + ]: 149014 : if (alt) {
448 : : // If alt is true, pick fee and size from the entire range.
449 : 5130 : fee = provider.ConsumeIntegralInRange<int64_t>(-0x8000000000000, 0x7ffffffffffff);
450 : 5130 : size = provider.ConsumeIntegralInRange<int32_t>(1, 0x3fffff);
451 : : } else {
452 : : // Otherwise, use smaller range which consume fewer fuzz input bytes, as just
453 : : // these are likely sufficient to trigger all interesting code paths already.
454 : 143884 : fee = provider.ConsumeIntegral<uint8_t>();
455 : 143884 : size = provider.ConsumeIntegralInRange<uint32_t>(1, 0xff);
456 : : }
457 : 149014 : FeePerWeight feerate{fee, size};
458 : : // Create a real TxGraph::Ref.
459 : 149014 : auto ref = real->AddTransaction(feerate);
460 : : // Create a shared_ptr place in the simulation to put the Ref in.
461 [ + - ]: 149014 : top_sim.AddTransaction(std::move(ref), feerate);
462 : 149014 : break;
463 [ + + + + : 702597 : } else if ((block_builders.empty() || sims.size() > 1) && top_sim.GetTransactionCount() + top_sim.removed.size() > 1 && command-- == 0) {
- + + + +
+ ]
464 : : // AddDependency.
465 : 26414 : auto par = pick_fn();
466 : 26414 : auto chl = pick_fn();
467 : 26414 : auto pos_par = top_sim.Find(par);
468 : 26414 : auto pos_chl = top_sim.Find(chl);
469 [ + + ]: 26414 : if (pos_par != SimTxGraph::MISSING && pos_chl != SimTxGraph::MISSING) {
470 : : // Determine if adding this would introduce a cycle (not allowed by TxGraph),
471 : : // and if so, skip.
472 [ + + ]: 22699 : if (top_sim.graph.Ancestors(pos_par)[pos_chl]) break;
473 : : }
474 : 20111 : top_sim.AddDependency(par, chl);
475 : 20111 : top_sim.real_is_optimal = false;
476 : 20111 : real->AddDependency(*par, *chl);
477 : 20111 : break;
478 [ + + + + : 525486 : } else if ((block_builders.empty() || sims.size() > 1) && top_sim.removed.size() < 100 && command-- == 0) {
- + + + +
+ ]
479 : : // RemoveTransaction. Either all its ancestors or all its descendants are also
480 : : // removed (if any), to make sure TxGraph's reordering of removals and dependencies
481 : : // has no effect.
482 : 9601 : std::vector<TxGraph::Ref*> to_remove;
483 [ + - ]: 9601 : to_remove.push_back(pick_fn());
484 [ + - ]: 9601 : top_sim.IncludeAncDesc(to_remove, alt);
485 : : // The order in which these ancestors/descendants are removed should not matter;
486 : : // randomly shuffle them.
487 : 9601 : std::shuffle(to_remove.begin(), to_remove.end(), rng);
488 [ + + ]: 20402 : for (TxGraph::Ref* ptr : to_remove) {
489 : 10801 : real->RemoveTransaction(*ptr);
490 [ + - ]: 10801 : top_sim.RemoveTransaction(ptr);
491 : : }
492 : 9601 : break;
493 [ - + + + : 427795 : } else if (sel_sim.removed.size() > 0 && command-- == 0) {
+ + ]
494 : : // ~Ref (of an already-removed transaction). Destroying a TxGraph::Ref has an
495 : : // observable effect on the TxGraph it refers to, so this simulation permits doing
496 : : // so separately from other actions on TxGraph.
497 : :
498 : : // Pick a Ref of sel_sim.removed to destroy. Note that the same Ref may still occur
499 : : // in the other graph, and thus not actually trigger ~Ref yet (which is exactly
500 : : // what we want, as destroying Refs is only allowed when it does not refer to an
501 : : // existing transaction in either graph).
502 : 4168 : auto removed_pos = provider.ConsumeIntegralInRange<size_t>(0, sel_sim.removed.size() - 1);
503 [ - + + + ]: 4168 : if (removed_pos != sel_sim.removed.size() - 1) {
504 : 2625 : std::swap(sel_sim.removed[removed_pos], sel_sim.removed.back());
505 : : }
506 : 4168 : sel_sim.removed.pop_back();
507 : 4168 : break;
508 [ + + + + ]: 414026 : } else if (block_builders.empty() && command-- == 0) {
509 : : // ~Ref (of any transaction).
510 : 9096 : std::vector<TxGraph::Ref*> to_destroy;
511 [ + - ]: 9096 : to_destroy.push_back(pick_fn());
512 : 9796 : while (true) {
513 : : // Keep adding either the ancestors or descendants the already picked
514 : : // transactions have in both graphs (main and staging) combined. Destroying
515 : : // will trigger deletions in both, so to have consistent TxGraph behavior, the
516 : : // set must be closed under ancestors, or descendants, in both graphs.
517 [ - + ]: 9796 : auto old_size = to_destroy.size();
518 [ + - + + ]: 22569 : for (auto& sim : sims) sim.IncludeAncDesc(to_destroy, alt);
519 [ - + + + ]: 9796 : if (to_destroy.size() == old_size) break;
520 : : }
521 : : // The order in which these ancestors/descendants are destroyed should not matter;
522 : : // randomly shuffle them.
523 : 9096 : std::shuffle(to_destroy.begin(), to_destroy.end(), rng);
524 [ + + ]: 20206 : for (TxGraph::Ref* ptr : to_destroy) {
525 [ - + + + ]: 25780 : for (size_t level = 0; level < sims.size(); ++level) {
526 : 14670 : sims[level].DestroyTransaction(ptr, level == sims.size() - 1);
527 : : }
528 : : }
529 : 9096 : break;
530 [ + + + + ]: 414026 : } else if (block_builders.empty() && command-- == 0) {
531 : : // SetTransactionFee.
532 : 6356 : int64_t fee;
533 [ + + ]: 6356 : if (alt) {
534 : 2639 : fee = provider.ConsumeIntegralInRange<int64_t>(-0x8000000000000, 0x7ffffffffffff);
535 : : } else {
536 : 3717 : fee = provider.ConsumeIntegral<uint8_t>();
537 : : }
538 : 6356 : auto ref = pick_fn();
539 : 6356 : real->SetTransactionFee(*ref, fee);
540 [ + + ]: 13830 : for (auto& sim : sims) {
541 : 7474 : sim.SetTransactionFee(ref, fee);
542 : : }
543 : : break;
544 [ + + ]: 398574 : } else if (command-- == 0) {
545 : : // GetTransactionCount.
546 [ - + ]: 26125 : assert(real->GetTransactionCount(level_select) == sel_sim.GetTransactionCount());
547 : : break;
548 [ + + ]: 372449 : } else if (command-- == 0) {
549 : : // Exists.
550 : 7867 : auto ref = pick_fn();
551 : 7867 : bool exists = real->Exists(*ref, level_select);
552 : 7867 : bool should_exist = sel_sim.Find(ref) != SimTxGraph::MISSING;
553 [ - + ]: 7867 : assert(exists == should_exist);
554 : : break;
555 [ + + ]: 364582 : } else if (command-- == 0) {
556 : : // IsOversized.
557 [ + - - + ]: 9111 : assert(sel_sim.IsOversized() == real->IsOversized(level_select));
558 : : break;
559 [ + + ]: 355471 : } else if (command-- == 0) {
560 : : // GetIndividualFeerate.
561 : 6329 : auto ref = pick_fn();
562 : 6329 : auto feerate = real->GetIndividualFeerate(*ref);
563 : 6329 : bool found{false};
564 [ + + ]: 14196 : for (auto& sim : sims) {
565 : 7867 : auto simpos = sim.Find(ref);
566 [ + + ]: 7867 : if (simpos != SimTxGraph::MISSING) {
567 : 5316 : found = true;
568 [ + - ]: 13183 : assert(feerate == sim.graph.FeeRate(simpos));
569 : : }
570 : : }
571 [ + + - + ]: 6329 : if (!found) assert(feerate.IsEmpty());
572 : : break;
573 [ + - + + : 349142 : } else if (!main_sim.IsOversized() && command-- == 0) {
+ + ]
574 : : // GetMainChunkFeerate.
575 : 5815 : auto ref = pick_fn();
576 : 5815 : auto feerate = real->GetMainChunkFeerate(*ref);
577 : 5815 : auto simpos = main_sim.Find(ref);
578 [ + + ]: 5815 : if (simpos == SimTxGraph::MISSING) {
579 [ - + ]: 1532 : assert(feerate.IsEmpty());
580 : : } else {
581 : : // Just do some quick checks that the reported value is in range. A full
582 : : // recomputation of expected chunk feerates is done at the end.
583 [ - + ]: 4283 : assert(feerate.size >= main_sim.graph.FeeRate(simpos).size);
584 [ - + ]: 4283 : assert(feerate.size <= main_sim.SumAll().size);
585 : : }
586 : : break;
587 [ + - + + : 343327 : } else if (!sel_sim.IsOversized() && command-- == 0) {
+ + ]
588 : : // GetAncestors/GetDescendants.
589 : 8623 : auto ref = pick_fn();
590 [ + + ]: 8623 : auto result = alt ? real->GetDescendants(*ref, level_select)
591 : 8623 : : real->GetAncestors(*ref, level_select);
592 [ - + - + ]: 8623 : assert(result.size() <= max_cluster_count);
593 : 8623 : auto result_set = sel_sim.MakeSet(result);
594 [ - + - + ]: 8623 : assert(result.size() == result_set.Count());
595 : 8623 : auto expect_set = sel_sim.GetAncDesc(ref, alt);
596 [ - + ]: 8623 : assert(result_set == expect_set);
597 : 8623 : break;
598 [ + - + + : 343327 : } else if (!sel_sim.IsOversized() && command-- == 0) {
+ + ]
599 : : // GetAncestorsUnion/GetDescendantsUnion.
600 : 5684 : std::vector<TxGraph::Ref*> refs;
601 : : // Gather a list of up to 15 Ref pointers.
602 : 5684 : auto count = provider.ConsumeIntegralInRange<size_t>(0, 15);
603 [ + - ]: 5684 : refs.resize(count);
604 [ + + ]: 45998 : for (size_t i = 0; i < count; ++i) {
605 : 40314 : refs[i] = pick_fn();
606 : : }
607 : : // Their order should not matter, shuffle them.
608 : 5684 : std::shuffle(refs.begin(), refs.end(), rng);
609 : : // Invoke the real function, and convert to SimPos set.
610 [ + + ]: 5684 : auto result = alt ? real->GetDescendantsUnion(refs, level_select)
611 [ - + - + ]: 5684 : : real->GetAncestorsUnion(refs, level_select);
612 [ - + ]: 5684 : auto result_set = sel_sim.MakeSet(result);
613 [ - + - + ]: 5684 : assert(result.size() == result_set.Count());
614 : : // Compute the expected result.
615 : 5684 : SimTxGraph::SetType expect_set;
616 [ + + ]: 45998 : for (TxGraph::Ref* ref : refs) expect_set |= sel_sim.GetAncDesc(ref, alt);
617 : : // Compare.
618 [ - + ]: 5684 : assert(result_set == expect_set);
619 : 5684 : break;
620 [ + - + + : 334704 : } else if (!sel_sim.IsOversized() && command-- == 0) {
+ + ]
621 : : // GetCluster.
622 : 13610 : auto ref = pick_fn();
623 : 13610 : auto result = real->GetCluster(*ref, level_select);
624 : : // Check cluster count limit.
625 [ - + - + ]: 13610 : assert(result.size() <= max_cluster_count);
626 : : // Require the result to be topologically valid and not contain duplicates.
627 : 13610 : auto left = sel_sim.graph.Positions();
628 : 13610 : uint64_t total_size{0};
629 [ + + ]: 36052 : for (auto refptr : result) {
630 : 22442 : auto simpos = sel_sim.Find(refptr);
631 [ - + ]: 22442 : total_size += sel_sim.graph.FeeRate(simpos).size;
632 [ - + ]: 22442 : assert(simpos != SimTxGraph::MISSING);
633 [ - + ]: 22442 : assert(left[simpos]);
634 : 22442 : left.Reset(simpos);
635 [ - + ]: 44884 : assert(!sel_sim.graph.Ancestors(simpos).Overlaps(left));
636 : : }
637 : : // Check cluster size limit.
638 [ - + ]: 13610 : assert(total_size <= max_cluster_size);
639 : : // Require the set to be connected.
640 [ - + ]: 13610 : auto result_set = sel_sim.MakeSet(result);
641 [ - + ]: 13610 : assert(sel_sim.graph.IsConnected(result_set));
642 : : // If ref exists, the result must contain it. If not, it must be empty.
643 : 13610 : auto simpos = sel_sim.Find(ref);
644 [ + + ]: 13610 : if (simpos != SimTxGraph::MISSING) {
645 [ - + ]: 7581 : assert(result_set[simpos]);
646 : : } else {
647 [ - + ]: 6029 : assert(result_set.None());
648 : : }
649 : : // Require the set not to have ancestors or descendants outside of it.
650 [ + + ]: 36052 : for (auto i : result_set) {
651 [ - + ]: 44884 : assert(sel_sim.graph.Ancestors(i).IsSubsetOf(result_set));
652 [ - + ]: 22442 : assert(sel_sim.graph.Descendants(i).IsSubsetOf(result_set));
653 : : }
654 : 13610 : break;
655 [ + + ]: 329020 : } else if (command-- == 0) {
656 : : // HaveStaging.
657 [ - + - + ]: 12400 : assert((sims.size() == 2) == real->HaveStaging());
658 : : break;
659 [ - + + + : 303010 : } else if (sims.size() < 2 && command-- == 0) {
+ + ]
660 : : // StartStaging.
661 [ + - ]: 5867 : sims.emplace_back(sims.back());
662 : 5867 : sims.back().modified = SimTxGraph::SetType{};
663 : 5867 : real->StartStaging();
664 : 5867 : break;
665 [ + + + + : 297143 : } else if (block_builders.empty() && sims.size() > 1 && command-- == 0) {
+ + ]
666 : : // CommitStaging.
667 : 2956 : real->CommitStaging();
668 : : // Resulting main level is only guaranteed to be optimal if all levels are
669 [ + + ]: 6349 : const bool main_optimal = std::all_of(sims.cbegin(), sims.cend(), [](const auto &sim) { return sim.real_is_optimal; });
670 : 2956 : sims.erase(sims.begin());
671 : 2956 : sims.front().real_is_optimal = main_optimal;
672 : 2956 : break;
673 [ + + + + ]: 294187 : } else if (sims.size() > 1 && command-- == 0) {
674 : : // AbortStaging.
675 : 1698 : real->AbortStaging();
676 : 1698 : sims.pop_back();
677 : : // Reset the cached oversized value (if TxGraph::Ref destructions triggered
678 : : // removals of main transactions while staging was active, then aborting will
679 : : // cause it to be re-evaluated in TxGraph).
680 [ + - ]: 415515 : sims.back().oversized = std::nullopt;
681 : : break;
682 [ + - + + : 292489 : } else if (!main_sim.IsOversized() && command-- == 0) {
+ + ]
683 : : // CompareMainOrder.
684 : 6309 : auto ref_a = pick_fn();
685 : 6309 : auto ref_b = pick_fn();
686 : 6309 : auto sim_a = main_sim.Find(ref_a);
687 : 6309 : auto sim_b = main_sim.Find(ref_b);
688 : : // Both transactions must exist in the main graph.
689 [ + + ]: 6309 : if (sim_a == SimTxGraph::MISSING || sim_b == SimTxGraph::MISSING) break;
690 : 3761 : auto cmp = real->CompareMainOrder(*ref_a, *ref_b);
691 : : // Distinct transactions have distinct places.
692 [ + + - + ]: 3761 : if (sim_a != sim_b) assert(cmp != 0);
693 : : // Ancestors go before descendants.
694 [ + + - + ]: 3761 : if (main_sim.graph.Ancestors(sim_a)[sim_b]) assert(cmp >= 0);
695 [ + + - + ]: 3761 : if (main_sim.graph.Descendants(sim_a)[sim_b]) assert(cmp <= 0);
696 : : // Do not verify consistency with chunk feerates, as we cannot easily determine
697 : : // these here without making more calls to real, which could affect its internal
698 : : // state. A full comparison is done at the end.
699 : : break;
700 [ + - + + : 286180 : } else if (!sel_sim.IsOversized() && command-- == 0) {
+ + ]
701 : : // CountDistinctClusters.
702 : 6756 : std::vector<TxGraph::Ref*> refs;
703 : : // Gather a list of up to 15 (or up to 255) Ref pointers.
704 [ + + ]: 11452 : auto count = provider.ConsumeIntegralInRange<size_t>(0, alt ? 255 : 15);
705 [ + - ]: 6756 : refs.resize(count);
706 [ + + ]: 267403 : for (size_t i = 0; i < count; ++i) {
707 : 260647 : refs[i] = pick_fn();
708 : : }
709 : : // Their order should not matter, shuffle them.
710 : 6756 : std::shuffle(refs.begin(), refs.end(), rng);
711 : : // Invoke the real function.
712 [ - + ]: 6756 : auto result = real->CountDistinctClusters(refs, level_select);
713 : : // Build a set with representatives of the clusters the Refs occur in in the
714 : : // simulated graph. For each, remember the lowest-index transaction SimPos in the
715 : : // cluster.
716 : 6756 : SimTxGraph::SetType sim_reps;
717 [ + + ]: 267403 : for (auto ref : refs) {
718 : : // Skip Refs that do not occur in the simulated graph.
719 : 260647 : auto simpos = sel_sim.Find(ref);
720 [ + + ]: 260647 : if (simpos == SimTxGraph::MISSING) continue;
721 : : // Find the component that includes ref.
722 : 207336 : auto component = sel_sim.graph.GetConnectedComponent(sel_sim.graph.Positions(), simpos);
723 : : // Remember the lowest-index SimPos in component, as a representative for it.
724 [ - + ]: 414672 : assert(component.Any());
725 : 207336 : sim_reps.Set(component.First());
726 : : }
727 : : // Compare the number of deduplicated representatives with the value returned by
728 : : // the real function.
729 [ - + ]: 6756 : assert(result == sim_reps.Count());
730 : 6756 : break;
731 [ + + ]: 286180 : } else if (command-- == 0) {
732 : : // DoWork.
733 [ + + ]: 28370 : uint64_t iters = provider.ConsumeIntegralInRange<uint64_t>(0, alt ? 10000 : 255);
734 : 16612 : bool ret = real->DoWork(iters);
735 : 16612 : uint64_t iters_for_optimal{0};
736 [ - + + + ]: 40083 : for (unsigned level = 0; level < sims.size(); ++level) {
737 : : // DoWork() will not optimize oversized levels, or the main level if a builder
738 : : // is present. Note that this impacts the DoWork() return value, as true means
739 : : // that non-optimal clusters may remain within such oversized or builder-having
740 : : // levels.
741 [ + - + + ]: 23471 : if (sims[level].IsOversized()) continue;
742 [ + + + + ]: 14877 : if (level == 0 && !block_builders.empty()) continue;
743 : : // If neither of the two above conditions holds, and DoWork() returned true,
744 : : // then the level is optimal.
745 [ + + ]: 11377 : if (ret) {
746 : 10523 : sims[level].real_is_optimal = true;
747 : : }
748 : : // Compute how many iterations would be needed to make everything optimal.
749 [ + - + + ]: 246935 : for (auto component : sims[level].GetComponents()) {
750 : 235558 : auto iters_opt_this_cluster = MaxOptimalLinearizationIters(component.Count());
751 [ + + ]: 235558 : if (iters_opt_this_cluster > acceptable_iters) {
752 : : // If the number of iterations required to linearize this cluster
753 : : // optimally exceeds acceptable_iters, DoWork() may process it in two
754 : : // stages: once to acceptable, and once to optimal.
755 : 61966 : iters_for_optimal += iters_opt_this_cluster + acceptable_iters;
756 : : } else {
757 : 173592 : iters_for_optimal += iters_opt_this_cluster;
758 : : }
759 : 11377 : }
760 : : }
761 [ + + ]: 16612 : if (!ret) {
762 : : // DoWork can only have more work left if the requested number of iterations
763 : : // was insufficient to linearize everything optimally within the levels it is
764 : : // allowed to touch.
765 [ - + ]: 510 : assert(iters <= iters_for_optimal);
766 : : }
767 : : break;
768 [ - + + + : 262812 : } else if (sims.size() == 2 && !sims[0].IsOversized() && !sims[1].IsOversized() && command-- == 0) {
+ - + + +
- + + +
+ ]
769 : : // GetMainStagingDiagrams()
770 : 2779 : auto [real_main_diagram, real_staged_diagram] = real->GetMainStagingDiagrams();
771 : 2779 : auto real_sum_main = std::accumulate(real_main_diagram.begin(), real_main_diagram.end(), FeeFrac{});
772 : 2779 : auto real_sum_staged = std::accumulate(real_staged_diagram.begin(), real_staged_diagram.end(), FeeFrac{});
773 : 2779 : auto real_gain = real_sum_staged - real_sum_main;
774 [ + - ]: 2779 : auto sim_gain = sims[1].SumAll() - sims[0].SumAll();
775 : : // Just check that the total fee gained/lost and size gained/lost according to the
776 : : // diagram matches the difference in these values in the simulated graph. A more
777 : : // complete check of the GetMainStagingDiagrams result is performed at the end.
778 [ + - ]: 2779 : assert(sim_gain == real_gain);
779 : : // Check that the feerates in each diagram are monotonically decreasing.
780 [ - + + + ]: 21979 : for (size_t i = 1; i < real_main_diagram.size(); ++i) {
781 [ - + ]: 19200 : assert(FeeRateCompare(real_main_diagram[i], real_main_diagram[i - 1]) <= 0);
782 : : }
783 [ - + + + ]: 42354 : for (size_t i = 1; i < real_staged_diagram.size(); ++i) {
784 [ - + ]: 39575 : assert(FeeRateCompare(real_staged_diagram[i], real_staged_diagram[i - 1]) <= 0);
785 : : }
786 : 2779 : break;
787 [ - + + + : 262812 : } else if (block_builders.size() < 4 && !main_sim.IsOversized() && command-- == 0) {
+ - + + +
+ ]
788 : : // GetBlockBuilder.
789 [ + - ]: 3078 : block_builders.emplace_back(real->GetBlockBuilder());
790 : 3078 : break;
791 [ + + + + ]: 256955 : } else if (!block_builders.empty() && command-- == 0) {
792 : : // ~BlockBuilder.
793 : 1580 : block_builders.erase(block_builders.begin() + builder_idx);
794 : : break;
795 [ + + + + ]: 255375 : } else if (!block_builders.empty() && command-- == 0) {
796 : : // BlockBuilder::GetCurrentChunk, followed by Include/Skip.
797 : 2973 : auto& builder_data = block_builders[builder_idx];
798 : 2973 : auto new_included = builder_data.included;
799 : 2973 : auto new_done = builder_data.done;
800 : 2973 : auto chunk = builder_data.builder->GetCurrentChunk();
801 [ + + ]: 2973 : if (chunk) {
802 : : // Chunk feerates must be monotonously decreasing.
803 [ + + ]: 1621 : if (!builder_data.last_feerate.IsEmpty()) {
804 [ - + ]: 1055 : assert(!(chunk->second >> builder_data.last_feerate));
805 : : }
806 : 1621 : builder_data.last_feerate = chunk->second;
807 : : // Verify the contents of GetCurrentChunk.
808 : 1621 : FeePerWeight sum_feerate;
809 [ + + ]: 3464 : for (TxGraph::Ref* ref : chunk->first) {
810 : : // Each transaction in the chunk must exist in the main graph.
811 : 1843 : auto simpos = main_sim.Find(ref);
812 [ - + ]: 1843 : assert(simpos != SimTxGraph::MISSING);
813 : : // Verify the claimed chunk feerate.
814 : 1843 : sum_feerate += main_sim.graph.FeeRate(simpos);
815 : : // Make sure no transaction is reported twice.
816 [ - + ]: 1843 : assert(!new_done[simpos]);
817 : 1843 : new_done.Set(simpos);
818 : : // The concatenation of all included transactions must be topologically valid.
819 : 1843 : new_included.Set(simpos);
820 [ - + ]: 3686 : assert(main_sim.graph.Ancestors(simpos).IsSubsetOf(new_included));
821 : : }
822 [ + - ]: 1621 : assert(sum_feerate == chunk->second);
823 : : } else {
824 : : // When we reach the end, if nothing was skipped, the entire graph should have
825 : : // been reported.
826 [ + + ]: 1352 : if (builder_data.done == builder_data.included) {
827 [ - + ]: 813 : assert(builder_data.done.Count() == main_sim.GetTransactionCount());
828 : : }
829 : : }
830 : : // Possibly invoke GetCurrentChunk() again, which should give the same result.
831 [ + + ]: 2973 : if ((orig_command % 7) >= 5) {
832 : 1018 : auto chunk2 = builder_data.builder->GetCurrentChunk();
833 [ - + ]: 1018 : assert(chunk == chunk2);
834 : 1018 : }
835 : : // Skip or include.
836 [ + + ]: 2973 : if ((orig_command % 5) >= 3) {
837 : : // Skip.
838 : 1222 : builder_data.builder->Skip();
839 : : } else {
840 : : // Include.
841 : 1751 : builder_data.builder->Include();
842 : 1751 : builder_data.included = new_included;
843 : : }
844 : 2973 : builder_data.done = new_done;
845 : 2973 : break;
846 [ + - + + : 255375 : } else if (!main_sim.IsOversized() && command-- == 0) {
+ + ]
847 : : // GetWorstMainChunk.
848 [ + + ]: 17389 : auto [worst_chunk, worst_chunk_feerate] = real->GetWorstMainChunk();
849 : : // Just do some sanity checks here. Consistency with GetBlockBuilder is checked
850 : : // below.
851 [ + + ]: 17389 : if (main_sim.GetTransactionCount() == 0) {
852 [ - + ]: 1604 : assert(worst_chunk.empty());
853 [ - + ]: 1604 : assert(worst_chunk_feerate.IsEmpty());
854 : : } else {
855 [ - + ]: 15785 : assert(!worst_chunk.empty());
856 : 15785 : SimTxGraph::SetType done;
857 : 15785 : FeePerWeight sum;
858 [ + + ]: 42411 : for (TxGraph::Ref* ref : worst_chunk) {
859 : : // Each transaction in the chunk must exist in the main graph.
860 : 26626 : auto simpos = main_sim.Find(ref);
861 [ - + ]: 26626 : assert(simpos != SimTxGraph::MISSING);
862 : 26626 : sum += main_sim.graph.FeeRate(simpos);
863 : : // Make sure the chunk contains no duplicate transactions.
864 [ - + ]: 26626 : assert(!done[simpos]);
865 : 26626 : done.Set(simpos);
866 : : // All elements are preceded by all their descendants.
867 [ - + ]: 53252 : assert(main_sim.graph.Descendants(simpos).IsSubsetOf(done));
868 : : }
869 [ + - ]: 15785 : assert(sum == worst_chunk_feerate);
870 : : }
871 : 17389 : break;
872 [ + + + + : 294813 : } else if ((block_builders.empty() || sims.size() > 1) && command-- == 0) {
+ + ]
873 : : // Trim.
874 [ + - ]: 14865 : bool was_oversized = top_sim.IsOversized();
875 : 14865 : auto removed = real->Trim();
876 : : // Verify that something was removed if and only if there was an oversized cluster.
877 [ - + ]: 14865 : assert(was_oversized == !removed.empty());
878 [ + + ]: 14865 : if (!was_oversized) break;
879 [ - + ]: 1080 : auto removed_set = top_sim.MakeSet(removed);
880 : : // The removed set must contain all its own descendants.
881 [ + + ]: 7464 : for (auto simpos : removed_set) {
882 [ - + ]: 12768 : assert(top_sim.graph.Descendants(simpos).IsSubsetOf(removed_set));
883 : : }
884 : : // Something from every oversized cluster should have been removed, and nothing
885 : : // else.
886 [ + - - + ]: 1080 : assert(top_sim.MatchesOversizedClusters(removed_set));
887 : :
888 : : // Apply all removals to the simulation, and verify the result is no longer
889 : : // oversized. Don't query the real graph for oversizedness; it is compared
890 : : // against the simulation anyway later.
891 [ + + ]: 7464 : for (auto simpos : removed_set) {
892 [ + - ]: 6384 : top_sim.RemoveTransaction(top_sim.GetRef(simpos));
893 : : }
894 [ + - - + ]: 1080 : assert(!top_sim.IsOversized());
895 : : break;
896 [ + + ]: 54486 : } else if ((block_builders.empty() || sims.size() > 1) &&
897 [ + + + + : 238322 : top_sim.GetTransactionCount() > max_cluster_count && !top_sim.IsOversized() && command-- == 0) {
+ - + + +
+ ]
898 : : // Trim (special case which avoids apparent cycles in the implicit approximate
899 : : // dependency graph constructed inside the Trim() implementation). This is worth
900 : : // testing separately, because such cycles cannot occur in realistic scenarios,
901 : : // but this is hard to replicate in general in this fuzz test.
902 : :
903 : : // First, we need to have dependencies applied and linearizations fixed to avoid
904 : : // circular dependencies in implied graph; trigger it via whatever means.
905 : 1165 : real->CountDistinctClusters({}, TxGraph::Level::TOP);
906 : :
907 : : // Gather the current clusters.
908 [ + - ]: 1165 : auto clusters = top_sim.GetComponents();
909 : :
910 : : // Merge clusters randomly until at least one oversized one appears.
911 : 1165 : bool made_oversized = false;
912 [ - + ]: 1165 : auto merges_left = clusters.size() - 1;
913 [ + + ]: 35958 : while (merges_left > 0) {
914 : 34793 : --merges_left;
915 : : // Find positions of clusters in the clusters vector to merge together.
916 [ - + ]: 34793 : auto par_cl = rng.randrange(clusters.size());
917 [ - + ]: 34793 : auto chl_cl = rng.randrange(clusters.size() - 1);
918 : 34793 : chl_cl += (chl_cl >= par_cl);
919 [ - + ]: 34793 : Assume(chl_cl != par_cl);
920 : : // Add between 1 and 3 dependencies between them. As all are in the same
921 : : // direction (from the child cluster to parent cluster), no cycles are possible,
922 : : // regardless of what internal topology Trim() uses as approximation within the
923 : : // clusters.
924 : 34793 : int num_deps = rng.randrange(3) + 1;
925 [ + + ]: 104338 : for (int i = 0; i < num_deps; ++i) {
926 : : // Find a parent transaction in the parent cluster.
927 : 69545 : auto par_idx = rng.randrange(clusters[par_cl].Count());
928 : 69545 : SimTxGraph::Pos par_pos = 0;
929 [ + - ]: 162947 : for (auto j : clusters[par_cl]) {
930 [ + + ]: 162947 : if (par_idx == 0) {
931 : : par_pos = j;
932 : : break;
933 : : }
934 : 93402 : --par_idx;
935 : : }
936 : : // Find a child transaction in the child cluster.
937 : 69545 : auto chl_idx = rng.randrange(clusters[chl_cl].Count());
938 : 69545 : SimTxGraph::Pos chl_pos = 0;
939 [ + - ]: 162781 : for (auto j : clusters[chl_cl]) {
940 [ + + ]: 162781 : if (chl_idx == 0) {
941 : : chl_pos = j;
942 : : break;
943 : : }
944 : 93236 : --chl_idx;
945 : : }
946 : : // Add dependency to both simulation and real TxGraph.
947 : 69545 : auto par_ref = top_sim.GetRef(par_pos);
948 : 69545 : auto chl_ref = top_sim.GetRef(chl_pos);
949 : 69545 : top_sim.AddDependency(par_ref, chl_ref);
950 : 69545 : real->AddDependency(*par_ref, *chl_ref);
951 : : }
952 : : // Compute the combined cluster.
953 : 34793 : auto par_cluster = clusters[par_cl];
954 : 34793 : auto chl_cluster = clusters[chl_cl];
955 : 34793 : auto new_cluster = par_cluster | chl_cluster;
956 : : // Remove the parent and child cluster from clusters.
957 [ + + + + ]: 1403245 : std::erase_if(clusters, [&](const auto& cl) noexcept { return cl == par_cluster || cl == chl_cluster; });
958 : : // Add the combined cluster.
959 [ + - ]: 34793 : clusters.push_back(new_cluster);
960 : : // If this is the first merge that causes an oversized cluster to appear, pick
961 : : // a random number of further merges to appear.
962 [ + + ]: 34793 : if (!made_oversized) {
963 : 29096 : made_oversized = new_cluster.Count() > max_cluster_count;
964 [ + + ]: 29096 : if (!made_oversized) {
965 : 27965 : FeeFrac total;
966 [ + + ]: 196035 : for (auto i : new_cluster) total += top_sim.graph.FeeRate(i);
967 [ + + ]: 27965 : if (uint32_t(total.size) > max_cluster_size) made_oversized = true;
968 : : }
969 [ + + - + ]: 29096 : if (made_oversized) merges_left = rng.randrange(clusters.size());
970 : : }
971 : : }
972 : :
973 : : // Determine an upper bound on how many transactions are removed.
974 : 1165 : uint32_t max_removed = 0;
975 [ + + ]: 7644 : for (auto& cluster : clusters) {
976 : : // Gather all transaction sizes in the to-be-combined cluster.
977 : 6479 : std::vector<uint32_t> sizes;
978 [ + - + + ]: 62991 : for (auto i : cluster) sizes.push_back(top_sim.graph.FeeRate(i).size);
979 : 6479 : auto sum_sizes = std::accumulate(sizes.begin(), sizes.end(), uint64_t{0});
980 : : // Sort from large to small.
981 : 6479 : std::sort(sizes.begin(), sizes.end(), std::greater{});
982 : : // In the worst case, only the smallest transactions are removed.
983 [ - + + + : 20166 : while (sizes.size() > max_cluster_count || sum_sizes > max_cluster_size) {
+ + ]
984 : 13687 : sum_sizes -= sizes.back();
985 : 13687 : sizes.pop_back();
986 : 13687 : ++max_removed;
987 : : }
988 : 6479 : }
989 : :
990 : : // Invoke Trim now on the definitely-oversized txgraph.
991 : 1165 : auto removed = real->Trim();
992 : : // Verify that the number of removals is within range.
993 [ - + - + ]: 1165 : assert(removed.size() >= 1);
994 [ - + ]: 1165 : assert(removed.size() <= max_removed);
995 : : // The removed set must contain all its own descendants.
996 : 1165 : auto removed_set = top_sim.MakeSet(removed);
997 [ + + ]: 9896 : for (auto simpos : removed_set) {
998 [ - + ]: 17462 : assert(top_sim.graph.Descendants(simpos).IsSubsetOf(removed_set));
999 : : }
1000 : : // Something from every oversized cluster should have been removed, and nothing
1001 : : // else.
1002 [ + - - + ]: 1165 : assert(top_sim.MatchesOversizedClusters(removed_set));
1003 : :
1004 : : // Apply all removals to the simulation, and verify the result is no longer
1005 : : // oversized. Don't query the real graph for oversizedness; it is compared
1006 : : // against the simulation anyway later.
1007 [ + + ]: 9896 : for (auto simpos : removed_set) {
1008 [ + - ]: 8731 : top_sim.RemoveTransaction(top_sim.GetRef(simpos));
1009 : : }
1010 [ + - - + ]: 1165 : assert(!top_sim.IsOversized());
1011 : 1165 : break;
1012 [ + + ]: 220148 : } else if (command-- == 0) {
1013 : : // GetMainMemoryUsage().
1014 : 29577 : auto usage = real->GetMainMemoryUsage();
1015 : : // Test stability.
1016 [ + + ]: 29577 : if (alt) {
1017 : 4705 : auto usage2 = real->GetMainMemoryUsage();
1018 [ - + ]: 4705 : assert(usage == usage2);
1019 : : }
1020 : : // Only empty graphs have 0 memory usage.
1021 [ + + ]: 29577 : if (main_sim.GetTransactionCount() == 0) {
1022 [ - + ]: 1315 : assert(usage == 0);
1023 : : } else {
1024 [ - + ]: 28262 : assert(usage > 0);
1025 : : }
1026 : : break;
1027 : : }
1028 : : }
1029 : : }
1030 : :
1031 : : // After running all modifications, perform an internal sanity check (before invoking
1032 : : // inspectors that may modify the internal state).
1033 [ + - ]: 2933 : real->SanityCheck();
1034 : :
1035 [ + - + + ]: 2933 : if (!sims[0].IsOversized()) {
1036 : : // If the main graph is not oversized, verify the total ordering implied by
1037 : : // CompareMainOrder.
1038 : : // First construct two distinct randomized permutations of the positions in sims[0].
1039 : 2501 : std::vector<SimTxGraph::Pos> vec1;
1040 [ + - + + ]: 85385 : for (auto i : sims[0].graph.Positions()) vec1.push_back(i);
1041 : 2501 : std::shuffle(vec1.begin(), vec1.end(), rng);
1042 [ + - ]: 2501 : auto vec2 = vec1;
1043 : 2501 : std::shuffle(vec2.begin(), vec2.end(), rng);
1044 [ + + ]: 2501 : if (vec1 == vec2) std::next_permutation(vec2.begin(), vec2.end());
1045 : : // Sort both according to CompareMainOrder. By having randomized starting points, the order
1046 : : // of CompareMainOrder invocations is somewhat randomized as well.
1047 : 1132888 : auto cmp = [&](SimTxGraph::Pos a, SimTxGraph::Pos b) noexcept {
1048 : 1130387 : return real->CompareMainOrder(*sims[0].GetRef(a), *sims[0].GetRef(b)) < 0;
1049 : 2501 : };
1050 : 2501 : std::sort(vec1.begin(), vec1.end(), cmp);
1051 : 2501 : std::sort(vec2.begin(), vec2.end(), cmp);
1052 : :
1053 : : // Verify the resulting orderings are identical. This could only fail if the ordering was
1054 : : // not total.
1055 [ - + ]: 2501 : assert(vec1 == vec2);
1056 : :
1057 : : // Verify that the ordering is topological.
1058 : 2501 : auto todo = sims[0].graph.Positions();
1059 [ + + ]: 85385 : for (auto i : vec1) {
1060 : 82884 : todo.Reset(i);
1061 [ - + ]: 165768 : assert(!sims[0].graph.Ancestors(i).Overlaps(todo));
1062 : : }
1063 [ - + ]: 2501 : assert(todo.None());
1064 : :
1065 : : // If the real graph claims to be optimal (the last DoWork() call returned true), verify
1066 : : // that calling Linearize on it does not improve it further.
1067 [ + + ]: 2501 : if (sims[0].real_is_optimal) {
1068 [ - + ]: 253 : auto real_diagram = ChunkLinearization(sims[0].graph, vec1);
1069 [ - + - + ]: 253 : auto [sim_lin, _optimal, _cost] = Linearize(sims[0].graph, 300000, rng.rand64(), vec1);
1070 [ - + ]: 253 : auto sim_diagram = ChunkLinearization(sims[0].graph, sim_lin);
1071 [ - + - + : 253 : auto cmp = CompareChunks(real_diagram, sim_diagram);
+ - ]
1072 [ - + ]: 253 : assert(cmp == 0);
1073 : 253 : }
1074 : :
1075 : : // For every transaction in the total ordering, find a random one before it and after it,
1076 : : // and compare their chunk feerates, which must be consistent with the ordering.
1077 [ - + + + ]: 85385 : for (size_t pos = 0; pos < vec1.size(); ++pos) {
1078 : 82884 : auto pos_feerate = real->GetMainChunkFeerate(*sims[0].GetRef(vec1[pos]));
1079 [ + + ]: 82884 : if (pos > 0) {
1080 : 80578 : size_t before = rng.randrange<size_t>(pos);
1081 : 80578 : auto before_feerate = real->GetMainChunkFeerate(*sims[0].GetRef(vec1[before]));
1082 [ - + ]: 80578 : assert(FeeRateCompare(before_feerate, pos_feerate) >= 0);
1083 : : }
1084 [ - + + + ]: 82884 : if (pos + 1 < vec1.size()) {
1085 : 80578 : size_t after = pos + 1 + rng.randrange<size_t>(vec1.size() - 1 - pos);
1086 : 80578 : auto after_feerate = real->GetMainChunkFeerate(*sims[0].GetRef(vec1[after]));
1087 [ - + ]: 80578 : assert(FeeRateCompare(after_feerate, pos_feerate) <= 0);
1088 : : }
1089 : : }
1090 : :
1091 : : // The same order should be obtained through a BlockBuilder as implied by CompareMainOrder,
1092 : : // if nothing is skipped.
1093 : 2501 : auto builder = real->GetBlockBuilder();
1094 : 2501 : std::vector<SimTxGraph::Pos> vec_builder;
1095 : 2501 : std::vector<TxGraph::Ref*> last_chunk;
1096 : 2501 : FeePerWeight last_chunk_feerate;
1097 [ + + ]: 156857 : while (auto chunk = builder->GetCurrentChunk()) {
1098 : 77178 : FeePerWeight sum;
1099 [ + + ]: 160062 : for (TxGraph::Ref* ref : chunk->first) {
1100 : : // The reported chunk feerate must match the chunk feerate obtained by asking
1101 : : // it for each of the chunk's transactions individually.
1102 [ + - ]: 82884 : assert(real->GetMainChunkFeerate(*ref) == chunk->second);
1103 : : // Verify the chunk feerate matches the sum of the reported individual feerates.
1104 : 82884 : sum += real->GetIndividualFeerate(*ref);
1105 : : // Chunks must contain transactions that exist in the graph.
1106 : 82884 : auto simpos = sims[0].Find(ref);
1107 [ - + ]: 82884 : assert(simpos != SimTxGraph::MISSING);
1108 [ + - ]: 82884 : vec_builder.push_back(simpos);
1109 : : }
1110 [ + - ]: 77178 : assert(sum == chunk->second);
1111 : 77178 : last_chunk = std::move(chunk->first);
1112 : 77178 : last_chunk_feerate = chunk->second;
1113 : 77178 : builder->Include();
1114 : 77178 : }
1115 [ - + ]: 2501 : assert(vec_builder == vec1);
1116 : :
1117 : : // The last chunk returned by the BlockBuilder must match GetWorstMainChunk, in reverse.
1118 : 2501 : std::reverse(last_chunk.begin(), last_chunk.end());
1119 [ - + ]: 2501 : auto [worst_chunk, worst_chunk_feerate] = real->GetWorstMainChunk();
1120 [ - + ]: 2501 : assert(last_chunk == worst_chunk);
1121 [ + - ]: 2501 : assert(last_chunk_feerate == worst_chunk_feerate);
1122 : :
1123 : : // Check that the implied ordering gives rise to a combined diagram that matches the
1124 : : // diagram constructed from the individual cluster linearization chunkings.
1125 [ + - ]: 2501 : auto main_real_diagram = get_diagram_fn(TxGraph::Level::MAIN);
1126 [ - + ]: 2501 : auto main_implied_diagram = ChunkLinearization(sims[0].graph, vec1);
1127 [ - + - + : 2501 : assert(CompareChunks(main_real_diagram, main_implied_diagram) == 0);
+ - - + ]
1128 : :
1129 [ - + + + : 2501 : if (sims.size() >= 2 && !sims[1].IsOversized()) {
+ - + + ]
1130 : : // When the staging graph is not oversized as well, call GetMainStagingDiagrams, and
1131 : : // fully verify the result.
1132 : 968 : auto [main_cmp_diagram, stage_cmp_diagram] = real->GetMainStagingDiagrams();
1133 : : // Check that the feerates in each diagram are monotonically decreasing.
1134 [ - + + + ]: 9208 : for (size_t i = 1; i < main_cmp_diagram.size(); ++i) {
1135 [ - + ]: 8240 : assert(FeeRateCompare(main_cmp_diagram[i], main_cmp_diagram[i - 1]) <= 0);
1136 : : }
1137 [ - + + + ]: 15121 : for (size_t i = 1; i < stage_cmp_diagram.size(); ++i) {
1138 [ - + ]: 14153 : assert(FeeRateCompare(stage_cmp_diagram[i], stage_cmp_diagram[i - 1]) <= 0);
1139 : : }
1140 : : // Treat the diagrams as sets of chunk feerates, and sort them in the same way so that
1141 : : // std::set_difference can be used on them below. The exact ordering does not matter
1142 : : // here, but it has to be consistent with the one used in main_real_diagram and
1143 : : // stage_real_diagram).
1144 : 968 : std::sort(main_cmp_diagram.begin(), main_cmp_diagram.end(), std::greater{});
1145 : 968 : std::sort(stage_cmp_diagram.begin(), stage_cmp_diagram.end(), std::greater{});
1146 : : // Find the chunks that appear in main_diagram but are missing from main_cmp_diagram.
1147 : : // This is allowed, because GetMainStagingDiagrams omits clusters in main unaffected
1148 : : // by staging.
1149 : 968 : std::vector<FeeFrac> missing_main_cmp;
1150 [ + - ]: 968 : std::set_difference(main_real_diagram.begin(), main_real_diagram.end(),
1151 : : main_cmp_diagram.begin(), main_cmp_diagram.end(),
1152 : : std::inserter(missing_main_cmp, missing_main_cmp.end()),
1153 : : std::greater{});
1154 [ - + - + : 968 : assert(main_cmp_diagram.size() + missing_main_cmp.size() == main_real_diagram.size());
- + - + ]
1155 : : // Do the same for chunks in stage_diagram missing from stage_cmp_diagram.
1156 [ + - ]: 968 : auto stage_real_diagram = get_diagram_fn(TxGraph::Level::TOP);
1157 : 968 : std::vector<FeeFrac> missing_stage_cmp;
1158 [ + - ]: 968 : std::set_difference(stage_real_diagram.begin(), stage_real_diagram.end(),
1159 : : stage_cmp_diagram.begin(), stage_cmp_diagram.end(),
1160 : : std::inserter(missing_stage_cmp, missing_stage_cmp.end()),
1161 : : std::greater{});
1162 [ - + - + : 968 : assert(stage_cmp_diagram.size() + missing_stage_cmp.size() == stage_real_diagram.size());
- + - + ]
1163 : : // The missing chunks must be equal across main & staging (otherwise they couldn't have
1164 : : // been omitted).
1165 [ - + ]: 968 : assert(missing_main_cmp == missing_stage_cmp);
1166 : :
1167 : : // The missing part must include at least all transactions in staging which have not been
1168 : : // modified, or been in a cluster together with modified transactions, since they were
1169 : : // copied from main. Note that due to the reordering of removals w.r.t. dependency
1170 : : // additions, it is possible that the real implementation found more unaffected things.
1171 : 968 : FeeFrac missing_real;
1172 [ + + ]: 24649 : for (const auto& feerate : missing_main_cmp) missing_real += feerate;
1173 : 968 : FeeFrac missing_expected = sims[1].graph.FeeRate(sims[1].graph.Positions() - sims[1].modified);
1174 : : // Note that missing_real.fee < missing_expected.fee is possible to due the presence of
1175 : : // negative-fee transactions.
1176 [ - + ]: 968 : assert(missing_real.size >= missing_expected.size);
1177 : 1936 : }
1178 : 2501 : }
1179 : :
1180 [ - + - + ]: 2933 : assert(real->HaveStaging() == (sims.size() > 1));
1181 : :
1182 : : // Try to run a full comparison, for both TxGraph::Level::MAIN and TxGraph::Level::TOP in
1183 : : // TxGraph inspector functions that support both.
1184 [ + + ]: 8799 : for (auto level : {TxGraph::Level::TOP, TxGraph::Level::MAIN}) {
1185 [ + + ]: 5866 : auto& sim = level == TxGraph::Level::TOP ? sims.back() : sims.front();
1186 : : // Compare simple properties of the graph with the simulation.
1187 [ + - - + ]: 5866 : assert(real->IsOversized(level) == sim.IsOversized());
1188 [ - + ]: 5866 : assert(real->GetTransactionCount(level) == sim.GetTransactionCount());
1189 : : // If the graph (and the simulation) are not oversized, perform a full comparison.
1190 [ + - + + ]: 5866 : if (!sim.IsOversized()) {
1191 : 4928 : auto todo = sim.graph.Positions();
1192 : : // Iterate over all connected components of the resulting (simulated) graph, each of which
1193 : : // should correspond to a cluster in the real one.
1194 [ + + ]: 278242 : while (todo.Any()) {
1195 : 134193 : auto component = sim.graph.FindConnectedComponent(todo);
1196 : 134193 : todo -= component;
1197 : : // Iterate over the transactions in that component.
1198 [ + + ]: 305184 : for (auto i : component) {
1199 : : // Check its individual feerate against simulation.
1200 [ + - ]: 170991 : assert(sim.graph.FeeRate(i) == real->GetIndividualFeerate(*sim.GetRef(i)));
1201 : : // Check its ancestors against simulation.
1202 : 170991 : auto expect_anc = sim.graph.Ancestors(i);
1203 [ - + ]: 170991 : auto anc = sim.MakeSet(real->GetAncestors(*sim.GetRef(i), level));
1204 [ - + ]: 170991 : assert(anc.Count() <= max_cluster_count);
1205 [ - + ]: 170991 : assert(anc == expect_anc);
1206 : : // Check its descendants against simulation.
1207 : 170991 : auto expect_desc = sim.graph.Descendants(i);
1208 [ - + ]: 170991 : auto desc = sim.MakeSet(real->GetDescendants(*sim.GetRef(i), level));
1209 [ - + ]: 170991 : assert(desc.Count() <= max_cluster_count);
1210 [ - + ]: 170991 : assert(desc == expect_desc);
1211 : : // Check the cluster the transaction is part of.
1212 : 170991 : auto cluster = real->GetCluster(*sim.GetRef(i), level);
1213 [ - + - + ]: 170991 : assert(cluster.size() <= max_cluster_count);
1214 [ - + ]: 170991 : assert(sim.MakeSet(cluster) == component);
1215 : : // Check that the cluster is reported in a valid topological order (its
1216 : : // linearization).
1217 : 170991 : std::vector<DepGraphIndex> simlin;
1218 : 170991 : SimTxGraph::SetType done;
1219 : 170991 : uint64_t total_size{0};
1220 [ + + ]: 1634424 : for (TxGraph::Ref* ptr : cluster) {
1221 : 1463433 : auto simpos = sim.Find(ptr);
1222 [ - + ]: 2926866 : assert(sim.graph.Descendants(simpos).IsSubsetOf(component - done));
1223 : 1463433 : done.Set(simpos);
1224 [ - + ]: 2926866 : assert(sim.graph.Ancestors(simpos).IsSubsetOf(done));
1225 [ + - ]: 1463433 : simlin.push_back(simpos);
1226 : 1463433 : total_size += sim.graph.FeeRate(simpos).size;
1227 : : }
1228 : : // Check cluster size.
1229 [ - + ]: 170991 : assert(total_size <= max_cluster_size);
1230 : : // Construct a chunking object for the simulated graph, using the reported cluster
1231 : : // linearization as ordering, and compare it against the reported chunk feerates.
1232 [ - + + + : 170991 : if (sims.size() == 1 || level == TxGraph::Level::MAIN) {
+ + ]
1233 [ - + ]: 127604 : cluster_linearize::LinearizationChunking simlinchunk(sim.graph, simlin);
1234 : 127604 : DepGraphIndex idx{0};
1235 [ - + + + ]: 719271 : for (unsigned chunknum = 0; chunknum < simlinchunk.NumChunksLeft(); ++chunknum) {
1236 : 591667 : auto chunk = simlinchunk.GetChunk(chunknum);
1237 : : // Require that the chunks of cluster linearizations are connected (this must
1238 : : // be the case as all linearizations inside are PostLinearized).
1239 [ - + ]: 591667 : assert(sim.graph.IsConnected(chunk.transactions));
1240 : : // Check the chunk feerates of all transactions in the cluster.
1241 [ + + ]: 3037350 : while (chunk.transactions.Any()) {
1242 [ - + ]: 927008 : assert(chunk.transactions[simlin[idx]]);
1243 : 927008 : chunk.transactions.Reset(simlin[idx]);
1244 [ + - ]: 927008 : assert(chunk.feerate == real->GetMainChunkFeerate(*cluster[idx]));
1245 : 927008 : ++idx;
1246 : : }
1247 : : }
1248 : 127604 : }
1249 : 170991 : }
1250 : : }
1251 : : }
1252 : : }
1253 : :
1254 : : // Sanity check again (because invoking inspectors may modify internal unobservable state).
1255 [ + - ]: 2933 : real->SanityCheck();
1256 : :
1257 : : // Kill the block builders.
1258 : 2933 : block_builders.clear();
1259 : : // Kill the TxGraph object.
1260 [ + - ]: 2933 : real.reset();
1261 : : // Kill the simulated graphs, with all remaining Refs in it. If any, this verifies that Refs
1262 : : // can outlive the TxGraph that created them.
1263 : 2933 : sims.clear();
1264 : 2933 : }
|
